cucumber 2.99.0 → 3.0.0

data/spec/cucumber/formatter/junit_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 require 'cucumber/formatter/spec_helper'
 
@@ -19,7 +20,7 @@ module Cucumber
         end
       end
 
-      context "With no options" do
+      context 'With no options' do
         before(:each) do
           allow(File).to receive(:directory?) { true }
           @formatter = TestDoubleJunitFormatter.new(actual_runtime.configuration.with_options(out_stream: ''))
@@ -29,7 +30,7 @@ module Cucumber
           $stdout = STDOUT
         end
 
-        describe "is able to strip control chars from cdata" do
+        describe 'is able to strip control chars from cdata' do
           before(:each) do
             run_defined_feature
             @doc = Nokogiri.XML(@formatter.written_files.values.first)
@@ -42,47 +43,45 @@ module Cucumber
             "
           class Junit
             def before_step(step)
-              if step.name.match("a passing ctrl scenario")
-                Interceptor::Pipe.unwrap! :stdout
-                @fake_io = $stdout = StringIO.new
-                $stdout.sync = true
-                @interceptedout = Interceptor::Pipe.wrap(:stdout)
-              end
+              return unless step.text.match('a passing ctrl scenario')
+              Interceptor::Pipe.unwrap! :stdout
+              @fake_io = $stdout = StringIO.new
+              $stdout.sync = true
+              @interceptedout = Interceptor::Pipe.wrap(:stdout)
             end
 
             def after_step(step)
-              if step.name.match("a passing ctrl scenario")
-                @interceptedout.write("boo\b\cx\e\a\f boo ")
-                $stdout = STDOUT
-                @fake_io.close
-              end
+              return unless step.text.match('a passing ctrl scenario')
+              @interceptedout.write("boo\b\cx\e\a\f boo ")
+              $stdout = STDOUT
+              @fake_io.close
             end
           end
 
           it { expect(@doc.xpath('//testsuite/testcase/system-out').first.content).to match(/\s+boo boo\s+/) }
         end
 
-        describe "a feature with no name" do
+        describe 'a feature with no name' do
           define_feature <<-FEATURE
             Feature:
               Scenario: Passing
                 Given a passing scenario
           FEATURE
 
-          it "raises an exception" do
+          it 'raises an exception' do
             expect(-> {
               run_defined_feature
             }).to raise_error(Junit::UnNamedFeatureError)
           end
         end
 
-        describe "given a single feature" do
+        describe 'given a single feature' do
           before(:each) do
             run_defined_feature
             @doc = Nokogiri.XML(@formatter.written_files.values.first)
           end
 
-          describe "with a single scenario" do
+          describe 'with a single scenario' do
             define_feature <<-FEATURE
               Feature: One passing scenario, one failing scenario
 
@@ -90,7 +89,7 @@ module Cucumber
                   Given a passing scenario
             FEATURE
 
-            it { expect(@doc.to_s).to match /One passing scenario, one failing scenario/ }
+            it { expect(@doc.to_s).to match(/One passing scenario, one failing scenario/) }
 
             it 'has not a root system-out node' do
               expect(@doc.xpath('//testsuite/system-out').size).to eq 0
@@ -109,7 +108,7 @@ module Cucumber
             end
           end
 
-          describe "with a scenario in a subdirectory" do
+          describe 'with a scenario in a subdirectory' do
             define_feature %{
               Feature: One passing scenario, one failing scenario
 
@@ -117,12 +116,12 @@ module Cucumber
                   Given a passing scenario
             }, File.join('features', 'some', 'path', 'spec.feature')
 
-            it 'writes the filename including the subdirectory' do
-              expect(@formatter.written_files.keys.first).to eq File.join('', 'TEST-features-some-path-spec.xml')
+            it 'writes the filename with absolute path' do
+              expect(@formatter.written_files.keys.first).to eq File.absolute_path('TEST-features-some-path-spec.xml')
             end
           end
 
-          describe "with a scenario outline table" do
+          describe 'with a scenario outline table' do
             define_steps do
               Given(/.*/) {  }
             end
@@ -145,16 +144,16 @@ module Cucumber
                   | Big Mac  |
             FEATURE
 
-            it { expect(@doc.to_s).to match /Eat things when hungry/ }
-            it { expect(@doc.to_s).to match /Cucumber/ }
-            it { expect(@doc.to_s).to match /Whisky/ }
-            it { expect(@doc.to_s).to match /Big Mac/ }
-            it { expect(@doc.to_s).not_to match /Things/ }
-            it { expect(@doc.to_s).not_to match /Good|Evil/ }
-            it { expect(@doc.to_s).not_to match /type="skipped"/}
+            it { expect(@doc.to_s).to match(/Eat things when hungry/) }
+            it { expect(@doc.to_s).to match(/Cucumber/) }
+            it { expect(@doc.to_s).to match(/Whisky/) }
+            it { expect(@doc.to_s).to match(/Big Mac/) }
+            it { expect(@doc.to_s).not_to match(/Things/) }
+            it { expect(@doc.to_s).not_to match(/Good|Evil/) }
+            it { expect(@doc.to_s).not_to match(/type="skipped"/)}
           end
 
-          describe "scenario with skipped test in junit report" do
+          describe 'scenario with skipped test in junit report' do
             define_feature <<-FEATURE
               Feature: junit report with skipped test
 
@@ -167,10 +166,10 @@ module Cucumber
                   | still undefined  |
             FEATURE
 
-            it { expect(@doc.to_s).to match /skipped="2"/}
+            it { expect(@doc.to_s).to match(/skipped="2"/)}
           end
 
-          describe "with a regular data table scenario" do
+          describe 'with a regular data table scenario' do
             define_steps do
               Given(/the following items on a shortlist/) { |table| }
               When(/I go.*/) {  }
@@ -190,13 +189,13 @@ module Cucumber
 
             FEATURE
             # these type of tables shouldn't crash (or generate test cases)
-            it { expect(@doc.to_s).not_to match /milk/ }
-            it { expect(@doc.to_s).not_to match /cookies/ }
+            it { expect(@doc.to_s).not_to match(/milk/) }
+            it { expect(@doc.to_s).not_to match(/cookies/) }
           end
         end
       end
-      
-      context "In --expand mode" do
+
+      context 'In --expand mode' do
         let(:runtime)   { Runtime.new({:expand => true}) }
         before(:each) do
           allow(File).to receive(:directory?) { true }
@@ -207,13 +206,13 @@ module Cucumber
           $stdout = STDOUT
         end
 
-        describe "given a single feature" do
+        describe 'given a single feature' do
           before(:each) do
             run_defined_feature
             @doc = Nokogiri.XML(@formatter.written_files.values.first)
           end
-          
-          describe "with a scenario outline table" do
+
+          describe 'with a scenario outline table' do
             define_steps do
               Given(/.*/) {  }
             end
@@ -236,16 +235,16 @@ module Cucumber
                   | Big Mac  |
             FEATURE
 
-            it { expect(@doc.to_s).to match /Eat things when hungry/ }
-            it { expect(@doc.to_s).to match /Cucumber/ }
-            it { expect(@doc.to_s).to match /Whisky/ }
-            it { expect(@doc.to_s).to match /Big Mac/ }
-            it { expect(@doc.to_s).not_to match /Things/ }
-            it { expect(@doc.to_s).not_to match /Good|Evil/ }
-            it { expect(@doc.to_s).not_to match /type="skipped"/}
+            it { expect(@doc.to_s).to match(/Eat things when hungry/) }
+            it { expect(@doc.to_s).to match(/Cucumber/) }
+            it { expect(@doc.to_s).to match(/Whisky/) }
+            it { expect(@doc.to_s).to match(/Big Mac/) }
+            it { expect(@doc.to_s).not_to match(/Things/) }
+            it { expect(@doc.to_s).not_to match(/Good|Evil/) }
+            it { expect(@doc.to_s).not_to match(/type="skipped"/)}
           end
         end
-        
+
       end
     end
   end