cucumber 2.99.0 → 3.0.0

data/spec/cucumber/formatter/json_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 require 'cucumber/formatter/spec_helper'
 require 'cucumber/formatter/json'
@@ -10,39 +11,14 @@ module Cucumber
       extend SpecHelperDsl
       include SpecHelper
 
-      context "Given a single feature" do
+      context 'Given a single feature' do
         before(:each) do
           @out = StringIO.new
           @formatter = Json.new(actual_runtime.configuration.with_options(out_stream: @out))
           run_defined_feature
         end
 
-        describe "with a scenario with no steps" do
-          define_feature <<-FEATURE
-          Feature: Banana party
-
-            Scenario: Monkey eats bananas
-            FEATURE
-
-          it "outputs the json data" do
-            expect(load_normalised_json(@out)).to eq MultiJson.load(%{
-              [{"id": "banana-party",
-                "uri": "spec.feature",
-                "keyword": "Feature",
-                "name": "Banana party",
-                "line": 1,
-                "description": "",
-                "elements":
-                 [{"id": "banana-party;monkey-eats-bananas",
-                   "keyword": "Scenario",
-                   "name": "Monkey eats bananas",
-                   "line": 3,
-                   "description": "",
-                   "type": "scenario"}]}]})
-          end
-        end
-
-        describe "with a scenario with an undefined step" do
+        describe 'with a scenario with an undefined step' do
           define_feature <<-FEATURE
           Feature: Banana party
 
@@ -50,7 +26,7 @@ module Cucumber
               Given there are bananas
             FEATURE
 
-          it "outputs the json data" do
+          it 'outputs the json data' do
             expect(load_normalised_json(@out)).to eq MultiJson.load(%{
               [{"id": "banana-party",
                 "uri": "spec.feature",
@@ -74,7 +50,7 @@ module Cucumber
           end
         end
 
-        describe "with a scenario with a passed step" do
+        describe 'with a scenario with a passed step' do
           define_feature <<-FEATURE
           Feature: Banana party
 
@@ -86,7 +62,7 @@ module Cucumber
             Given(/^there are bananas$/) {}
           end
 
-          it "outputs the json data" do
+          it 'outputs the json data' do
             expect(load_normalised_json(@out)).to eq MultiJson.load(%{
               [{"id": "banana-party",
                 "uri": "spec.feature",
@@ -105,13 +81,13 @@ module Cucumber
                     [{"keyword": "Given ",
                       "name": "there are bananas",
                       "line": 4,
-                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:86"},
+                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:62"},
                       "result": {"status": "passed",
                                  "duration": 1}}]}]}]})
           end
         end
 
-        describe "with a scenario with a failed step" do
+        describe 'with a scenario with a failed step' do
           define_feature <<-FEATURE
           Feature: Banana party
 
@@ -120,10 +96,10 @@ module Cucumber
             FEATURE
 
           define_steps do
-            Given(/^there are bananas$/) { raise "no bananas" }
+            Given(/^there are bananas$/) { raise 'no bananas' }
           end
 
-          it "outputs the json data" do
+          it 'outputs the json data' do
             expect(load_normalised_json(@out)).to eq MultiJson.load(%{
               [{"id": "banana-party",
                 "uri": "spec.feature",
@@ -142,14 +118,14 @@ module Cucumber
                     [{"keyword": "Given ",
                       "name": "there are bananas",
                       "line": 4,
-                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:123"},
+                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:99"},
                       "result": {"status": "failed",
-                                 "error_message": "no bananas (RuntimeError)\\n./spec/cucumber/formatter/json_spec.rb:123:in `/^there are bananas$/'\\nspec.feature:4:in `Given there are bananas'",
+                                 "error_message": "no bananas (RuntimeError)\\n./spec/cucumber/formatter/json_spec.rb:99:in `/^there are bananas$/'\\nspec.feature:4:in `Given there are bananas'",
                                  "duration": 1}}]}]}]})
           end
         end
 
-        describe "with a scenario with a pending step" do
+        describe 'with a scenario with a pending step' do
           define_feature <<-FEATURE
           Feature: Banana party
 
@@ -161,7 +137,7 @@ module Cucumber
             Given(/^there are bananas$/) { pending }
           end
 
-          it "outputs the json data" do
+          it 'outputs the json data' do
             expect(load_normalised_json(@out)).to eq MultiJson.load(%{
               [{"id": "banana-party",
                 "uri": "spec.feature",
@@ -180,14 +156,14 @@ module Cucumber
                     [{"keyword": "Given ",
                       "name": "there are bananas",
                       "line": 4,
-                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:161"},
+                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:137"},
                       "result": {"status": "pending",
-                                 "error_message": "TODO (Cucumber::Pending)\\n./spec/cucumber/formatter/json_spec.rb:161:in `/^there are bananas$/'\\nspec.feature:4:in `Given there are bananas'",
+                                 "error_message": "TODO (Cucumber::Pending)\\n./spec/cucumber/formatter/json_spec.rb:137:in `/^there are bananas$/'\\nspec.feature:4:in `Given there are bananas'",
                                  "duration": 1}}]}]}]})
           end
         end
 
-        describe "with a scenario outline with one example" do
+        describe 'with a scenario outline with one example' do
           define_feature <<-FEATURE
           Feature: Banana party
 
@@ -203,7 +179,7 @@ module Cucumber
             Given(/^there are bananas$/) {}
           end
 
-          it "outputs the json data" do
+          it 'outputs the json data' do
             expect(load_normalised_json(@out)).to eq MultiJson.load(%{
               [{"id": "banana-party",
                 "uri": "spec.feature",
@@ -222,13 +198,13 @@ module Cucumber
                     [{"keyword": "Given ",
                       "name": "there are bananas",
                       "line": 8,
-                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:203"},
+                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:179"},
                       "result": {"status": "passed",
                                  "duration": 1}}]}]}]})
           end
         end
 
-        describe "with tags in the feature file" do
+        describe 'with tags in the feature file' do
           define_feature <<-FEATURE
           @f
           Feature: Banana party
@@ -251,7 +227,7 @@ module Cucumber
             Given(/^there are bananas$/) {}
           end
 
-          it "the tags are included in the json data" do
+          it 'the tags are included in the json data' do
             expect(load_normalised_json(@out)).to eq MultiJson.load(%{
               [{"id": "banana-party",
                 "uri": "spec.feature",
@@ -276,7 +252,7 @@ module Cucumber
                     [{"keyword": "Given ",
                       "name": "there are bananas",
                       "line": 6,
-                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:251"},
+                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:227"},
                       "result": {"status": "passed",
                                  "duration": 1}}]},
                    {"id": "banana-party;monkey-eats-bananas;fruit-table;2",
@@ -295,13 +271,13 @@ module Cucumber
                     [{"keyword": "Given ",
                       "name": "there are bananas",
                       "line": 15,
-                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:251"},
+                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:227"},
                       "result": {"status": "passed",
                                  "duration": 1}}]}]}]})
           end
         end
 
-        describe "with comments in the feature file" do
+        describe 'with comments in the feature file' do
           define_feature <<-FEATURE
           #feature comment
           Feature: Banana party
@@ -332,7 +308,7 @@ module Cucumber
             Then(/^the monkey eats bananas$/) {}
           end
 
-          it "the comments are included in the json data" do
+          it 'the comments are included in the json data' do
             expect(load_normalised_json(@out)).to eq MultiJson.load(%{
               [{"id": "banana-party",
                 "uri": "spec.feature",
@@ -354,7 +330,7 @@ module Cucumber
                     [{"keyword": "Given ",
                       "name": "there are bananas",
                       "line": 6,
-                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:331"},
+                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:307"},
                       "result": {"status": "passed",
                                  "duration": 1}}]},
                   {"id": "banana-party;monkey-eats-bananas",
@@ -371,7 +347,7 @@ module Cucumber
                       "line": 11,
                       "comments": [{"value": "#step comment1",
                                     "line": 10}],
-                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:332"},
+                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:308"},
                       "result": {"status": "passed",
                                  "duration": 1}}]},
                   {"keyword": "Background",
@@ -385,7 +361,7 @@ module Cucumber
                     [{"keyword": "Given ",
                       "name": "there are bananas",
                       "line": 6,
-                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:331"},
+                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:307"},
                       "result": {"status": "passed",
                                  "duration": 1}}]},
                    {"id": "banana-party;monkey-eats-bananas;fruit-table;2",
@@ -406,13 +382,13 @@ module Cucumber
                       "line": 22,
                       "comments": [{"value": "#step comment2",
                                     "line": 15}],
-                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:332"},
+                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:308"},
                       "result": {"status": "passed",
                                  "duration": 1}}]}]}]})
           end
         end
 
-        describe "with a scenario with a step with a doc string" do
+        describe 'with a scenario with a step with a doc string' do
           define_feature <<-FEATURE
           Feature: Banana party
 
@@ -427,7 +403,7 @@ module Cucumber
             Given(/^there are bananas$/) { |s| s }
           end
 
-          it "includes the doc string in the json data" do
+          it 'includes the doc string in the json data' do
             expect(load_normalised_json(@out)).to eq MultiJson.load(%{
               [{"id": "banana-party",
                 "uri": "spec.feature",
@@ -449,13 +425,13 @@ module Cucumber
                       "doc_string": {"value": "the doc string",
                                      "content_type": "",
                                      "line": 5},
-                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:427"},
+                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:403"},
                       "result": {"status": "passed",
                                  "duration": 1}}]}]}]})
           end
         end
 
-        describe "with a scenario with a step that use puts" do
+        describe 'with a scenario with a step that use puts' do
           define_feature <<-FEATURE
           Feature: Banana party
 
@@ -464,10 +440,10 @@ module Cucumber
             FEATURE
 
           define_steps do
-            Given(/^there are bananas$/) { puts "from step" }
+            Given(/^there are bananas$/) { puts 'from step' }
           end
 
-          it "includes the output from the step in the json data" do
+          it 'includes the output from the step in the json data' do
             expect(load_normalised_json(@out)).to eq MultiJson.load(%{
               [{"id": "banana-party",
                 "uri": "spec.feature",
@@ -487,13 +463,13 @@ module Cucumber
                       "name": "there are bananas",
                       "line": 4,
                       "output": ["from step"],
-                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:467"},
+                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:443"},
                       "result": {"status": "passed",
                                  "duration": 1}}]}]}]})
           end
         end
 
-        describe "with a background" do
+        describe 'with a background' do
           define_feature <<-FEATURE
           Feature: Banana party
 
@@ -507,7 +483,7 @@ module Cucumber
               Then the monkey eats more bananas
             FEATURE
 
-          it "includes the background in the json data each time it is executed" do
+          it 'includes the background in the json data each time it is executed' do
             expect(load_normalised_json(@out)).to eq MultiJson.load(%{
               [{"id": "banana-party",
                 "uri": "spec.feature",
@@ -565,7 +541,7 @@ module Cucumber
           end
         end
 
-        describe "with a scenario with a step that embeds data directly" do
+        describe 'with a scenario with a step that embeds data directly' do
           define_feature <<-FEATURE
           Feature: Banana party
 
@@ -574,11 +550,11 @@ module Cucumber
             FEATURE
 
           define_steps do
-            Given(/^there are bananas$/) { data = "YWJj"
-              embed data, "mime-type;base64" }
+            Given(/^there are bananas$/) { data = 'YWJj'
+              embed data, 'mime-type;base64' }
           end
 
-          it "includes the data from the step in the json data" do
+          it 'includes the data from the step in the json data' do
             expect(load_normalised_json(@out)).to eq MultiJson.load(%{
               [{"id": "banana-party",
                 "uri": "spec.feature",
@@ -599,13 +575,13 @@ module Cucumber
                       "line": 4,
                       "embeddings": [{"mime_type": "mime-type",
                                       "data": "YWJj"}],
-                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:577"},
+                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:553"},
                       "result": {"status": "passed",
                                  "duration": 1}}]}]}]})
           end
         end
 
-        describe "with a scenario with a step that embeds a file" do
+        describe 'with a scenario with a step that embeds a file' do
           define_feature <<-FEATURE
           Feature: Banana party
 
@@ -618,12 +594,12 @@ module Cucumber
               RSpec::Mocks.allow_message(File, :file?) { true }
               f1 = RSpec::Mocks::Double.new
               RSpec::Mocks.allow_message(File, :open)  { |&block| block.call(f1) }
-              RSpec::Mocks.allow_message(f1, :read)  { "foo" }
+              RSpec::Mocks.allow_message(f1, :read)  { 'foo' }
               embed('out/snapshot.jpeg', 'image/png')
             }
           end
 
-          it "includes the file content in the json data" do
+          it 'includes the file content in the json data' do
             expect(load_normalised_json(@out)).to eq MultiJson.load(%{
               [{"id": "banana-party",
                 "uri": "spec.feature",
@@ -644,13 +620,13 @@ module Cucumber
                       "line": 4,
                       "embeddings": [{"mime_type": "image/png",
                                       "data": "Zm9v"}],
-                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:617"},
+                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:593"},
                       "result": {"status": "passed",
                                  "duration": 1}}]}]}]})
           end
         end
 
-        describe "with a scenario with hooks" do
+        describe 'with a scenario with hooks' do
           define_feature <<-FEATURE
           Feature: Banana party
 
@@ -669,7 +645,7 @@ module Cucumber
             Given(/^there are bananas$/) {}
           end
 
-          it "includes all hooks except the around hook in the json data" do
+          it 'includes all hooks except the around hook in the json data' do
             expect(load_normalised_json(@out)).to eq MultiJson.load(%{
               [{"id": "banana-party",
                 "uri": "spec.feature",
@@ -685,37 +661,37 @@ module Cucumber
                    "description": "",
                    "type": "scenario",
                    "before":
-                    [{"match": {"location": "spec/cucumber/formatter/json_spec.rb:662"},
+                    [{"match": {"location": "spec/cucumber/formatter/json_spec.rb:638"},
                       "result": {"status": "passed",
                                  "duration": 1}},
-                     {"match": {"location": "spec/cucumber/formatter/json_spec.rb:663"},
+                     {"match": {"location": "spec/cucumber/formatter/json_spec.rb:639"},
                       "result": {"status": "passed",
                                  "duration": 1}}],
                    "steps":
                     [{"keyword": "Given ",
                       "name": "there are bananas",
                       "line": 4,
-                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:669"},
+                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:645"},
                       "result": {"status": "passed",
                                  "duration": 1},
                       "after":
-                       [{"match": {"location": "spec/cucumber/formatter/json_spec.rb:666"},
+                       [{"match": {"location": "spec/cucumber/formatter/json_spec.rb:642"},
                          "result": {"status": "passed",
                                     "duration": 1}},
-                        {"match": {"location": "spec/cucumber/formatter/json_spec.rb:667"},
+                        {"match": {"location": "spec/cucumber/formatter/json_spec.rb:643"},
                          "result": {"status": "passed",
                                     "duration": 1}}]}],
                    "after":
-                    [{"match": {"location": "spec/cucumber/formatter/json_spec.rb:665"},
+                    [{"match": {"location": "spec/cucumber/formatter/json_spec.rb:641"},
                       "result": {"status": "passed",
                                  "duration": 1}},
-                     {"match": {"location": "spec/cucumber/formatter/json_spec.rb:664"},
+                     {"match": {"location": "spec/cucumber/formatter/json_spec.rb:640"},
                       "result": {"status": "passed",
                                  "duration": 1}}]}]}]})
           end
         end
 
-        describe "with a scenario when only an around hook is failing" do
+        describe 'with a scenario when only an around hook is failing' do
           define_feature <<-FEATURE
           Feature: Banana party
 
@@ -724,11 +700,11 @@ module Cucumber
             FEATURE
 
           define_steps do
-            Around() { |scenario, block| block.call; raise RuntimeError, "error" }
+            Around() { |scenario, block| block.call; raise RuntimeError, 'error' }
             Given(/^there are bananas$/) {}
           end
 
-          it "includes the around hook result in the json data" do
+          it 'includes the around hook result in the json data' do
             expect(load_normalised_json(@out)).to eq MultiJson.load(%{
               [{"id": "banana-party",
                 "uri": "spec.feature",
@@ -747,18 +723,18 @@ module Cucumber
                     [{"keyword": "Given ",
                       "name": "there are bananas",
                       "line": 4,
-                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:728"},
+                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:704"},
                       "result": {"status": "passed",
                                  "duration": 1}}],
                    "around":
                     [{"match": {"location": "unknown_hook_location:1"},
                       "result": {"status": "failed",
-                                 "error_message": "error (RuntimeError)\\n./spec/cucumber/formatter/json_spec.rb:727:in `Around'",
+                                 "error_message": "error (RuntimeError)\\n./spec/cucumber/formatter/json_spec.rb:703:in `Around'",
                                  "duration": 1}}]}]}]})
           end
         end
 
-        describe "with a scenario with a step with a data table" do
+        describe 'with a scenario with a step with a data table' do
           define_feature <<-FEATURE
           Feature: Banana party
 
@@ -772,7 +748,7 @@ module Cucumber
             Given(/^there are bananas$/) { |s| s }
           end
 
-          it "includes the doc string in the json data" do
+          it 'includes the doc string in the json data' do
             expect(load_normalised_json(@out)).to eq MultiJson.load(%{
               [{"id": "banana-party",
                 "uri": "spec.feature",
@@ -791,10 +767,10 @@ module Cucumber
                      [{"keyword": "Given ",
                        "name": "there are bananas",
                        "line": 4,
-                       "rows": 
-                         [{"cells": ["aa", "bb"]}, 
+                       "rows":
+                         [{"cells": ["aa", "bb"]},
                           {"cells": ["cc", "dd"]}],
-                       "match": {"location": "spec/cucumber/formatter/json_spec.rb:772"},
+                       "match": {"location": "spec/cucumber/formatter/json_spec.rb:748"},
                        "result": {"status": "passed",
                                   "duration": 1}}]}]}]})
           end
@@ -811,7 +787,7 @@ module Cucumber
         json.each do |feature|
           elements = feature.fetch('elements') { [] }
           elements.each do |scenario|
-            ['steps', 'before', 'after', 'around'].each do |type|
+            %w(steps before after around).each do |type|
               if scenario[type]
                 scenario[type].each do |step_or_hook|
                   normalise_json_step_or_hook(step_or_hook)
@@ -828,12 +804,10 @@ module Cucumber
       end
 
       def normalise_json_step_or_hook(step_or_hook)
-        if step_or_hook['result']
-          if step_or_hook['result']['duration']
-            expect(step_or_hook['result']['duration']).to be >= 0
-            step_or_hook['result']['duration'] = 1
-          end
-        end
+        return unless step_or_hook['result'] && step_or_hook['result']['duration']
+
+        expect(step_or_hook['result']['duration']).to be >= 0
+        step_or_hook['result']['duration'] = 1
       end
 
     end