cucumber 2.99.0 → 3.0.0.pre.1

data/spec/cucumber/formatter/junit_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 require 'cucumber/formatter/spec_helper'
 

data/spec/cucumber/formatter/legacy_api/adapter_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/formatter/legacy_api/adapter'
 require 'cucumber/core'
 require 'cucumber/core/gherkin/writer'
@@ -13,9 +14,10 @@ module Cucumber
       include Core::Gherkin::Writer
       include Core
 
-      let(:report)    { Adapter.new(formatter, runtime.results, runtime.configuration) }
+      let!(:report)    { Adapter.new(formatter, runtime.results, runtime.configuration) }
       let(:formatter) { double('formatter').as_null_object }
       let(:runtime)   { Runtime.new }
+      let(:events)    { runtime.configuration.event_bus }
       let(:step_match_search) { SimpleStepDefinitionSearch.new }
 
       Failure = Class.new(StandardError)
@@ -106,8 +108,9 @@ module Cucumber
               end
             end,
           ]
-          runner = Core::Test::Runner.new(report)
+          runner = Core::Test::Runner.new(events)
           compile gherkin_docs, runner, default_filters
+          events.test_run_finished
           expect( formatter.legacy_messages ).to eq [
             :before_features,
               :before_feature,
@@ -2166,8 +2169,10 @@ module Cucumber
       end
 
       def execute_gherkin(filters = default_filters, &gherkin)
-        runner = Core::Test::Runner.new(report)
+        runner = Core::Test::Runner.new(events)
         compile [gherkin(&gherkin)], runner, filters
+        events.test_run_finished
+        self
       end
 
       def default_filters

data/spec/cucumber/formatter/pretty_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 require 'cucumber/formatter/spec_helper'
 require 'cucumber/formatter/pretty'

data/spec/cucumber/formatter/progress_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 require 'cucumber/formatter/spec_helper'
 require 'cucumber/formatter/progress'
@@ -12,7 +13,7 @@ module Cucumber
       before(:each) do
         Cucumber::Term::ANSIColor.coloring = false
         @out = StringIO.new
-        @formatter = Progress.new(runtime, @out, Cucumber::Cli::Options.new)
+        @formatter = Progress.new(actual_runtime.configuration.with_options(out_stream: @out))
       end
 
       describe "given a single feature" do

data/spec/cucumber/formatter/rerun_spec.rb

@@ -1,90 +1,96 @@
+# frozen_string_literal: true
 require 'cucumber/formatter/rerun'
 require 'cucumber/core'
 require 'cucumber/core/gherkin/writer'
 require 'cucumber/core/filter'
 require 'support/standard_step_actions'
-
-module Cucumber::Formatter
-  describe Rerun do
-    include Cucumber::Core::Gherkin::Writer
-    include Cucumber::Core
-
-    # after_test_case
-    context 'when 2 scenarios fail in the same file' do
-      it 'Prints the locations of the failed scenarios' do
-        gherkin = gherkin('foo.feature') do
-          feature do
-            scenario do
-              step 'failing'
-            end
-
-            scenario do
-              step 'failing'
-            end
-
-            scenario do
-              step 'passing'
+require 'cucumber/configuration'
+
+module Cucumber
+  module Formatter
+    describe Rerun do
+      include Cucumber::Core::Gherkin::Writer
+      include Cucumber::Core
+
+      let(:config) { Cucumber::Configuration.new(out_stream: io) }
+      let(:io) { StringIO.new }
+
+      # after_test_case
+      context 'when 2 scenarios fail in the same file' do
+        it 'Prints the locations of the failed scenarios' do
+          gherkin = gherkin('foo.feature') do
+            feature do
+              scenario do
+                step 'failing'
+              end
+
+              scenario do
+                step 'failing'
+              end
+
+              scenario do
+                step 'passing'
+              end
             end
           end
-        end
-        io = StringIO.new
-        report = Rerun.new(double, io, {})
-
-        execute [gherkin], report, [StandardStepActions.new]
+          Rerun.new(config)
+          execute [gherkin], [StandardStepActions.new], config.event_bus
+          config.event_bus.test_run_finished
 
-        expect( io.string ).to eq 'foo.feature:3:6'
+          expect( io.string ).to eq 'foo.feature:3:6'
+        end
       end
-    end
 
-    context 'with failures in multiple files' do
-      it 'prints the location of the failed scenarios in each file' do
-        foo = gherkin('foo.feature') do
-          feature do
-            scenario do
-              step 'failing'
-            end
-
-            scenario do
-              step 'failing'
-            end
-
-            scenario do
-              step 'passing'
+      context 'with failures in multiple files' do
+        it 'prints the location of the failed scenarios in each file' do
+          foo = gherkin('foo.feature') do
+            feature do
+              scenario do
+                step 'failing'
+              end
+
+              scenario do
+                step 'failing'
+              end
+
+              scenario do
+                step 'passing'
+              end
             end
           end
-        end
 
-        bar = gherkin('bar.feature') do
-          feature do
-            scenario do
-              step 'failing'
+          bar = gherkin('bar.feature') do
+            feature do
+              scenario do
+                step 'failing'
+              end
             end
           end
-        end
 
-        io = StringIO.new
-        report = Rerun.new(double, io, {})
+          Rerun.new(config)
+          execute [foo, bar], [StandardStepActions.new], config.event_bus
+          config.event_bus.test_run_finished
 
-        execute [foo, bar], report, [StandardStepActions.new]
-
-        expect(io.string).to eq 'foo.feature:3:6 bar.feature:3'
+          expect(io.string).to eq 'foo.feature:3:6 bar.feature:3'
+        end
       end
-    end
 
-    context 'when there are no failing scenarios' do
-      it 'prints nothing' do
-        gherkin = gherkin('foo.feature') do
-          feature do
-            scenario do
-              step 'passing'
+      context 'when there are no failing scenarios' do
+        it 'prints nothing' do
+          gherkin = gherkin('foo.feature') do
+            feature do
+              scenario do
+                step 'passing'
+              end
             end
           end
-        end
 
-        io = StringIO.new
-        report = Rerun.new(double, io, {})
+          Rerun.new(config)
+          execute [gherkin], [StandardStepActions.new], config.event_bus
+          config.event_bus.test_run_finished
 
-        execute [gherkin], report, [StandardStepActions.new]
+          expect(io.string).to eq ''
+        end
       end
     end
   end

data/spec/cucumber/formatter/spec_helper.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Cucumber
   module Formatter
     module SpecHelperDsl
@@ -21,7 +22,7 @@ module Cucumber
         define_steps
         actual_runtime.visitor = report
 
-        receiver = Test::Runner.new(report)
+        receiver = Test::Runner.new(event_bus)
         filters = [
           Filters::ActivateSteps.new(
             StepMatchSearch.new(actual_runtime.support_code.ruby.method(:step_matches), actual_runtime.configuration),
@@ -34,17 +35,13 @@ module Cucumber
           Filters::PrepareWorld.new(actual_runtime)
         ]
         compile [gherkin_doc], receiver, filters
-      end
-
-      require 'cucumber/formatter/event_bus_report'
-      def event_bus_report
-        @event_bus_report ||= Formatter::EventBusReport.new(actual_runtime.configuration)
+        event_bus.test_run_finished
       end
 
       require 'cucumber/formatter/legacy_api/adapter'
       def report
         @report ||= LegacyApi::Adapter.new(
-          Fanout.new([@formatter, event_bus_report]),
+          Fanout.new([@formatter]),
           actual_runtime.results,
           actual_runtime.configuration)
       end
@@ -66,6 +63,10 @@ module Cucumber
         @runtime ||= Runtime.new(options)
       end
 
+      def event_bus
+        actual_runtime.configuration.event_bus
+      end
+
       def define_steps
         return unless step_defs = self.class.step_defs
         rb = runtime.support_code.ruby

data/spec/cucumber/hooks_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/hooks'
 module Cucumber::Hooks
   shared_examples_for 'a source node' do

data/spec/cucumber/multiline_argument/data_table_spec.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 require 'spec_helper'
 require 'cucumber/multiline_argument/data_table'
 

data/spec/cucumber/project_initializer_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 require 'tmpdir'
 
@@ -84,4 +85,4 @@ module Cucumber
 
     end
   end
-end
+end

data/spec/cucumber/rake/forked_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 require 'cucumber/rake/task'
 require 'rake'

data/spec/cucumber/rake/task_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 require 'cucumber/rake/task'
 require 'rake'

data/spec/cucumber/rb_support/rb_language_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 require 'cucumber/rb_support/rb_language'
 
@@ -17,10 +18,11 @@ module Cucumber
       describe "#load_code_file" do
         after do
           FileUtils.rm_rf('tmp.rb')
+          FileUtils.rm_rf('docs.md')
         end
 
         def a_file_called(name)
-          File.open('tmp.rb', 'w') do |f|
+          File.open(name, 'w') do |f|
             f.puts yield
           end
         end
@@ -43,10 +45,10 @@ module Cucumber
         end
 
         it "only loads ruby files" do
-          a_file_called("readme.md") do
+          a_file_called("docs.md") do
             "yo"
           end
-          rb.load_code_file('readme.md')
+          rb.load_code_file('docs.md')
         end
       end
 
@@ -104,6 +106,82 @@ or http://wiki.github.com/cucumber/cucumber/a-whole-new-world.
         end
       end
 
+      describe 'Handling namespaced World' do
+        module ModuleOne
+          def method_one
+            1
+          end
+        end
+
+        module ModuleMinusOne
+          def method_one
+            -1
+          end
+        end
+
+        module ModuleTwo
+          def method_two
+            2
+          end
+        end
+
+        module ModuleThree
+          def method_three
+            3
+          end
+        end
+
+        it 'extends the world with namespaces' do
+          dsl.World(ModuleOne, module_two: ModuleTwo, module_three: ModuleThree)
+          rb.begin_scenario(double('scenario').as_null_object)
+          class << rb.current_world
+            extend RSpec::Matchers
+            expect(included_modules.inspect).to match(/ModuleOne/)
+          end
+          expect(rb.current_world.class).to eq Object
+          expect(rb.current_world).to respond_to(:method_one)
+
+          expect(rb.current_world.module_two.class).to eq Object
+          expect(rb.current_world.module_two).to respond_to(:method_two)
+
+          expect(rb.current_world.module_three.class).to eq Object
+          expect(rb.current_world.module_three).to respond_to(:method_three)
+        end
+
+        it 'allows to inspect the included modules' do
+          dsl.World(ModuleOne, module_two: ModuleTwo, module_three: ModuleThree)
+          rb.begin_scenario(double('scenario').as_null_object)
+          class << rb.current_world
+            extend RSpec::Matchers
+          end
+          expect(rb.current_world.inspect).to match(/ModuleOne/)
+          expect(rb.current_world.inspect).to include('ModuleTwo (as module_two)')
+          expect(rb.current_world.inspect).to include('ModuleThree (as module_three)')
+        end
+
+        it 'merges methods when assigning different modules to the same namespace' do
+          dsl.World(namespace: ModuleOne)
+          dsl.World(namespace: ModuleTwo)
+          rb.begin_scenario(double('scenario').as_null_object)
+          class << rb.current_world
+            extend RSpec::Matchers
+          end
+          expect(rb.current_world.namespace).to respond_to(:method_one)
+          expect(rb.current_world.namespace).to respond_to(:method_two)
+        end
+
+        it 'resolves conflicts when assigning different modules to the same namespace' do
+          dsl.World(namespace: ModuleOne)
+          dsl.World(namespace: ModuleMinusOne)
+          rb.begin_scenario(double('scenario').as_null_object)
+          class << rb.current_world
+            extend RSpec::Matchers
+          end
+          expect(rb.current_world.namespace).to respond_to(:method_one)
+          expect(rb.current_world.namespace.method_one).to eql(-1)
+        end
+      end
+
       describe "step argument transformations" do
         describe "without capture groups" do
           it "complains when registering with a with no transform block" do

data/spec/cucumber/rb_support/rb_step_definition_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 require 'cucumber/rb_support/rb_language'
 

data/spec/cucumber/rb_support/rb_transform_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 require 'cucumber/rb_support/rb_transform'
 

data/spec/cucumber/rb_support/rb_world_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 require 'cucumber/formatter/spec_helper'
 require 'cucumber/formatter/pretty'
@@ -26,7 +27,7 @@ module Cucumber
 
           define_steps do
             When(/^puts is called twice for the same variable$/) do
-              foo = 'a'
+              foo = String.new('a')
               puts foo
               foo.upcase!
               puts foo

data/spec/cucumber/rb_support/snippet_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 require 'cucumber/rb_support/snippet'