cucumber 2.99.0 → 3.0.0.pre.1

data/lib/cucumber/unit.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Cucumber
   class Unit
     def initialize(step_collection)

data/lib/cucumber/version

@@ -1 +1 @@
-2.99.0
+3.0.0.pre.1

data/lib/simplecov_setup.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 if ENV['SIMPLECOV']
   begin
     # Suppress warnings in order not to pollute stdout which tests expectations rely on

data/spec/cucumber/cli/configuration_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 require 'yaml'
 

data/spec/cucumber/cli/main_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 require 'yaml'
 

data/spec/cucumber/cli/options_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 require 'yaml'
 require 'cucumber/cli/options'

data/spec/cucumber/cli/profile_loader_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 require 'yaml'
 

data/spec/cucumber/cli/rerun_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 
 module Cucumber

data/spec/cucumber/configuration_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 
 module Cucumber

data/spec/cucumber/constantize_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 
 module Html end

data/spec/cucumber/core_ext/instance_exec_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/core_ext/instance_exec'
 
 describe 'cucumber_instance_exec' do

data/spec/cucumber/file_specs_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/file_specs'
 
 module Cucumber

data/spec/cucumber/filters/activate_steps_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/filters/activate_steps'
 require 'cucumber/core/gherkin/writer'
 require 'cucumber/core'
@@ -32,9 +33,10 @@ describe Cucumber::Filters::ActivateSteps do
     end
 
     it "notifies with a StepMatch event" do
-      expect(configuration).to receive(:notify) do |event|
-        expect(event.test_step.name).to eq 'a passing step'
-        expect(event.step_match).to eq step_match
+      expect(configuration).to receive(:notify) do |message, test_step, step_match|
+        expect(message).to eq :step_match
+        expect(test_step.name).to eq 'a passing step'
+        expect(step_match).to eq step_match
       end
       compile [doc], receiver, [filter]
     end
@@ -111,9 +113,10 @@ describe Cucumber::Filters::ActivateSteps do
     end
 
     it "notifies with a StepMatch event" do
-      expect(configuration).to receive(:notify) do |event|
-        expect(event.test_step.name).to eq 'a passing step'
-        expect(event.step_match).to eq step_match
+      expect(configuration).to receive(:notify) do |message, test_step, step_match|
+        expect(message).to eq :step_match
+        expect(test_step.name).to eq 'a passing step'
+        expect(step_match).to eq step_match
       end
       compile [doc], receiver, [filter]
     end

data/spec/cucumber/filters/gated_receiver_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "cucumber/filters/gated_receiver"
 
 describe Cucumber::Filters::GatedReceiver do

data/spec/cucumber/filters/retry_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber'
 require 'cucumber/filters/retry'
 require 'cucumber/core/gherkin/writer'
@@ -22,29 +23,22 @@ describe Cucumber::Filters::Retry do
   it { is_expected.to respond_to(:with_receiver) }
   it { is_expected.to respond_to(:done) }
 
-  context "general" do
-    before(:each) do
-      filter.with_receiver(receiver)
-    end
-
-    it "registers the :after_test_case event" do
-      expect(configuration).to receive(:on_event).with(:after_test_case)
-      filter.test_case(test_case)
-    end
-  end
-
   context "passing test case" do
+    let(:result) { Cucumber::Core::Test::Result::Passed.new(0) }
+
     it "describes the test case once" do
-      expect(test_case).to receive(:describe_to).with(receiver)
-      filter.test_case(test_case)
-      configuration.notify(pass)
+      expect(receiver).to receive(:test_case).with(test_case).once
+      test_case.describe_to filter
+      configuration.notify :test_case_finished, test_case, result
     end
   end
 
-  context "failing test case" do
+  context "consistently failing test case" do
+    let(:result) { Cucumber::Core::Test::Result::Failed.new(0, StandardError.new) }
+
     it "describes the test case the specified number of times" do
       expect(receiver).to receive(:test_case) {|test_case|
-        configuration.notify(fail)
+        configuration.notify :test_case_finished, test_case, result
       }.exactly(3).times
 
       filter.test_case(test_case)
@@ -54,10 +48,16 @@ describe Cucumber::Filters::Retry do
   context "flaky test cases" do
 
     context "a little flaky" do
+      let(:results) {
+        [
+          Cucumber::Core::Test::Result::Failed.new(0, StandardError.new),
+          Cucumber::Core::Test::Result::Passed.new(0)
+        ]
+      }
+
       it "describes the test case twice" do
-        results = [fail, pass]
         expect(receiver).to receive(:test_case) {|test_case|
-          configuration.notify(results.shift)
+          configuration.notify :test_case_finished, test_case, results.shift
         }.exactly(2).times
 
         filter.test_case(test_case)
@@ -65,11 +65,17 @@ describe Cucumber::Filters::Retry do
     end
 
     context "really flaky" do
-      it "describes the test case 3 times" do
-        results = [fail, fail, pass]
+      let(:results) {
+        [
+          Cucumber::Core::Test::Result::Failed.new(0, StandardError.new),
+          Cucumber::Core::Test::Result::Failed.new(0, StandardError.new),
+          Cucumber::Core::Test::Result::Passed.new(0)
+        ]
+      }
 
+      it "describes the test case 3 times" do
         expect(receiver).to receive(:test_case) {|test_case|
-          configuration.notify(results.shift)
+          configuration.notify :test_case_finished, test_case, results.shift
         }.exactly(3).times
 
         filter.test_case(test_case)

data/spec/cucumber/filters/tag_limits/test_case_index_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "cucumber/filters/tag_limits"
 
 describe Cucumber::Filters::TagLimits::TestCaseIndex do

data/spec/cucumber/filters/tag_limits/verifier_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "cucumber/filters/tag_limits"
 
 describe Cucumber::Filters::TagLimits::Verifier do

data/spec/cucumber/filters/tag_limits_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "cucumber/filters/tag_limits"
 
 describe Cucumber::Filters::TagLimits do

data/spec/cucumber/formatter/ansicolor_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 require 'cucumber/formatter/ansicolor'
 

data/spec/cucumber/formatter/console_counts_spec.rb

@@ -0,0 +1,14 @@
+require 'cucumber/configuration'
+require 'cucumber/formatter/console_counts'
+
+module Cucumber
+  module Formatter
+    describe ConsoleCounts do
+      it "works for zero" do
+        config = Configuration.new
+        counts = ConsoleCounts.new(config)
+        expect(counts.to_s).to eq "0 scenarios\n0 steps"
+      end
+    end
+  end
+end

data/spec/cucumber/formatter/debug_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 require 'cucumber/formatter/spec_helper'
 require 'cucumber/formatter/debug'

data/spec/cucumber/formatter/duration_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 require 'cucumber/formatter/duration'
 

data/spec/cucumber/formatter/fail_fast_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/formatter/fail_fast'
 require 'cucumber/core'
 require 'cucumber/core/gherkin/writer'
@@ -14,7 +15,6 @@ module Cucumber::Formatter
 
     let(:configuration) { Cucumber::Configuration.new }
     before { FailFast.new(configuration) }
-    let(:report) { EventBusReport.new(configuration) }
 
     context 'failing scenario' do 
       before(:each) do 
@@ -36,7 +36,7 @@ module Cucumber::Formatter
       end
 
       it 'sets Cucumber.wants_to_quit' do 
-        execute([@gherkin], report, [StandardStepActions.new])
+        execute [@gherkin], [StandardStepActions.new], configuration.event_bus
         expect(Cucumber.wants_to_quit).to be true
       end
     end
@@ -53,7 +53,7 @@ module Cucumber::Formatter
       end
 
       it 'doesn\'t set Cucumber.wants_to_quit' do 
-        execute([@gherkin], report, [StandardStepActions.new])
+        execute [@gherkin], [StandardStepActions.new], configuration.event_bus
         expect(Cucumber.wants_to_quit).to be_falsey
       end
     end
@@ -70,7 +70,7 @@ module Cucumber::Formatter
       end
 
       it 'doesn\'t set Cucumber.wants_to_quit' do 
-        execute([@gherkin], report, [StandardStepActions.new])
+        execute [@gherkin], [StandardStepActions.new], configuration.event_bus
         expect(Cucumber.wants_to_quit).to be_falsey
       end
 
@@ -78,7 +78,7 @@ module Cucumber::Formatter
         let(:configuration) { Cucumber::Configuration.new strict: true }
 
         it 'sets Cucumber.wants_to_quit' do 
-          execute([@gherkin], report, [StandardStepActions.new])
+          execute [@gherkin], [StandardStepActions.new], configuration.event_bus
           expect(Cucumber.wants_to_quit).to be_truthy
         end
       end

data/spec/cucumber/formatter/html_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 require 'cucumber/formatter/spec_helper'
 require 'cucumber/formatter/html'
@@ -31,7 +32,6 @@ module Cucumber
 
       describe "when writing the report to a file" do
         before(:each) do
-          allow(@out).to receive(:respond_to?).with(:path, false).and_return(true)
           allow(@out).to receive(:respond_to?).with(:path).and_return(true)
           expect(@out).to receive(:path).and_return('out/file.html')
           run_defined_feature
@@ -267,6 +267,11 @@ module Cucumber
 
           it { expect(@doc).to have_css_node('.feature .scenario .step.failed .message', /eek/) }
           it { expect(@doc).to have_css_node('.feature .scenario .step.failed .message', /StandardError/) }
+          it 'has the backtrace embeded in the output once and only once' do
+            html_str = @doc.to_s
+            expect(html_str).not_to match(%r{<pre\b.*html_spec.rb:.*html_spec.rb:.*</pre>}m)
+            expect(html_str).to match(%r{<pre\b.*html_spec.rb:.*</pre>}m)
+          end
         end
 
         describe "with a step that fails in the background" do

data/spec/cucumber/formatter/interceptor_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 require 'cucumber/formatter/interceptor'
 

data/spec/cucumber/formatter/json_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 require 'cucumber/formatter/spec_helper'
 require 'cucumber/formatter/json'
@@ -105,7 +106,7 @@ module Cucumber
                     [{"keyword": "Given ",
                       "name": "there are bananas",
                       "line": 4,
-                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:86"},
+                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:87"},
                       "result": {"status": "passed",
                                  "duration": 1}}]}]}]})
           end
@@ -142,9 +143,9 @@ module Cucumber
                     [{"keyword": "Given ",
                       "name": "there are bananas",
                       "line": 4,
-                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:123"},
+                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:124"},
                       "result": {"status": "failed",
-                                 "error_message": "no bananas (RuntimeError)\\n./spec/cucumber/formatter/json_spec.rb:123:in `/^there are bananas$/'\\nspec.feature:4:in `Given there are bananas'",
+                                 "error_message": "no bananas (RuntimeError)\\n./spec/cucumber/formatter/json_spec.rb:124:in `/^there are bananas$/'\\nspec.feature:4:in `Given there are bananas'",
                                  "duration": 1}}]}]}]})
           end
         end
@@ -180,9 +181,9 @@ module Cucumber
                     [{"keyword": "Given ",
                       "name": "there are bananas",
                       "line": 4,
-                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:161"},
+                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:162"},
                       "result": {"status": "pending",
-                                 "error_message": "TODO (Cucumber::Pending)\\n./spec/cucumber/formatter/json_spec.rb:161:in `/^there are bananas$/'\\nspec.feature:4:in `Given there are bananas'",
+                                 "error_message": "TODO (Cucumber::Pending)\\n./spec/cucumber/formatter/json_spec.rb:162:in `/^there are bananas$/'\\nspec.feature:4:in `Given there are bananas'",
                                  "duration": 1}}]}]}]})
           end
         end
@@ -222,7 +223,7 @@ module Cucumber
                     [{"keyword": "Given ",
                       "name": "there are bananas",
                       "line": 8,
-                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:203"},
+                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:204"},
                       "result": {"status": "passed",
                                  "duration": 1}}]}]}]})
           end
@@ -276,7 +277,7 @@ module Cucumber
                     [{"keyword": "Given ",
                       "name": "there are bananas",
                       "line": 6,
-                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:251"},
+                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:252"},
                       "result": {"status": "passed",
                                  "duration": 1}}]},
                    {"id": "banana-party;monkey-eats-bananas;fruit-table;2",
@@ -295,7 +296,7 @@ module Cucumber
                     [{"keyword": "Given ",
                       "name": "there are bananas",
                       "line": 15,
-                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:251"},
+                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:252"},
                       "result": {"status": "passed",
                                  "duration": 1}}]}]}]})
           end
@@ -354,7 +355,7 @@ module Cucumber
                     [{"keyword": "Given ",
                       "name": "there are bananas",
                       "line": 6,
-                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:331"},
+                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:332"},
                       "result": {"status": "passed",
                                  "duration": 1}}]},
                   {"id": "banana-party;monkey-eats-bananas",
@@ -371,7 +372,7 @@ module Cucumber
                       "line": 11,
                       "comments": [{"value": "#step comment1",
                                     "line": 10}],
-                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:332"},
+                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:333"},
                       "result": {"status": "passed",
                                  "duration": 1}}]},
                   {"keyword": "Background",
@@ -385,7 +386,7 @@ module Cucumber
                     [{"keyword": "Given ",
                       "name": "there are bananas",
                       "line": 6,
-                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:331"},
+                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:332"},
                       "result": {"status": "passed",
                                  "duration": 1}}]},
                    {"id": "banana-party;monkey-eats-bananas;fruit-table;2",
@@ -406,7 +407,7 @@ module Cucumber
                       "line": 22,
                       "comments": [{"value": "#step comment2",
                                     "line": 15}],
-                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:332"},
+                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:333"},
                       "result": {"status": "passed",
                                  "duration": 1}}]}]}]})
           end
@@ -449,7 +450,7 @@ module Cucumber
                       "doc_string": {"value": "the doc string",
                                      "content_type": "",
                                      "line": 5},
-                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:427"},
+                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:428"},
                       "result": {"status": "passed",
                                  "duration": 1}}]}]}]})
           end
@@ -487,7 +488,7 @@ module Cucumber
                       "name": "there are bananas",
                       "line": 4,
                       "output": ["from step"],
-                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:467"},
+                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:468"},
                       "result": {"status": "passed",
                                  "duration": 1}}]}]}]})
           end
@@ -599,7 +600,7 @@ module Cucumber
                       "line": 4,
                       "embeddings": [{"mime_type": "mime-type",
                                       "data": "YWJj"}],
-                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:577"},
+                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:578"},
                       "result": {"status": "passed",
                                  "duration": 1}}]}]}]})
           end
@@ -644,7 +645,7 @@ module Cucumber
                       "line": 4,
                       "embeddings": [{"mime_type": "image/png",
                                       "data": "Zm9v"}],
-                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:617"},
+                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:618"},
                       "result": {"status": "passed",
                                  "duration": 1}}]}]}]})
           end
@@ -685,31 +686,31 @@ module Cucumber
                    "description": "",
                    "type": "scenario",
                    "before":
-                    [{"match": {"location": "spec/cucumber/formatter/json_spec.rb:662"},
+                    [{"match": {"location": "spec/cucumber/formatter/json_spec.rb:663"},
                       "result": {"status": "passed",
                                  "duration": 1}},
-                     {"match": {"location": "spec/cucumber/formatter/json_spec.rb:663"},
+                     {"match": {"location": "spec/cucumber/formatter/json_spec.rb:664"},
                       "result": {"status": "passed",
                                  "duration": 1}}],
                    "steps":
                     [{"keyword": "Given ",
                       "name": "there are bananas",
                       "line": 4,
-                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:669"},
+                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:670"},
                       "result": {"status": "passed",
                                  "duration": 1},
                       "after":
-                       [{"match": {"location": "spec/cucumber/formatter/json_spec.rb:666"},
+                       [{"match": {"location": "spec/cucumber/formatter/json_spec.rb:667"},
                          "result": {"status": "passed",
                                     "duration": 1}},
-                        {"match": {"location": "spec/cucumber/formatter/json_spec.rb:667"},
+                        {"match": {"location": "spec/cucumber/formatter/json_spec.rb:668"},
                          "result": {"status": "passed",
                                     "duration": 1}}]}],
                    "after":
-                    [{"match": {"location": "spec/cucumber/formatter/json_spec.rb:665"},
+                    [{"match": {"location": "spec/cucumber/formatter/json_spec.rb:666"},
                       "result": {"status": "passed",
                                  "duration": 1}},
-                     {"match": {"location": "spec/cucumber/formatter/json_spec.rb:664"},
+                     {"match": {"location": "spec/cucumber/formatter/json_spec.rb:665"},
                       "result": {"status": "passed",
                                  "duration": 1}}]}]}]})
           end
@@ -747,13 +748,13 @@ module Cucumber
                     [{"keyword": "Given ",
                       "name": "there are bananas",
                       "line": 4,
-                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:728"},
+                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:729"},
                       "result": {"status": "passed",
                                  "duration": 1}}],
                    "around":
                     [{"match": {"location": "unknown_hook_location:1"},
                       "result": {"status": "failed",
-                                 "error_message": "error (RuntimeError)\\n./spec/cucumber/formatter/json_spec.rb:727:in `Around'",
+                                 "error_message": "error (RuntimeError)\\n./spec/cucumber/formatter/json_spec.rb:728:in `Around'",
                                  "duration": 1}}]}]}]})
           end
         end
@@ -791,10 +792,10 @@ module Cucumber
                      [{"keyword": "Given ",
                        "name": "there are bananas",
                        "line": 4,
-                       "rows": 
-                         [{"cells": ["aa", "bb"]}, 
+                       "rows":
+                         [{"cells": ["aa", "bb"]},
                           {"cells": ["cc", "dd"]}],
-                       "match": {"location": "spec/cucumber/formatter/json_spec.rb:772"},
+                       "match": {"location": "spec/cucumber/formatter/json_spec.rb:773"},
                        "result": {"status": "passed",
                                   "duration": 1}}]}]}]})
           end