cucumber 2.99.0 → 3.0.0.pre.1

data/features/docs/gherkin/unicode_table.feature

@@ -1,4 +1,4 @@
-@spawn
+@spawn @wip-jruby
 Feature: Unicode in tables
 
   You are free to use unicode in your tables: we've taken care to

data/features/docs/post_configuration_hook.feature

@@ -4,22 +4,6 @@ Feature: Post Configuration Hook [#423]
   As a developer
   I want to manipulate the Cucumber configuration after it has been created
 
-  # Fails on Travis under JRuby
-  @spawn
-  @wip-jruby
-  Scenario: Using options directly gets a deprecation warning
-    Given a file named "features/support/env.rb" with:
-      """
-      AfterConfiguration do |config|
-        config.options[:blah]
-      end
-      """
-    When I run `cucumber features`
-    Then the stderr should contain:
-      """
-      Deprecated
-      """
-
   Scenario: Changing the output format
     Given a file named "features/support/env.rb" with:
       """

data/features/docs/writing_support_code/world.feature

@@ -0,0 +1,129 @@
+Feature: World
+
+  In order to isolate each test scenario, the steps definitions belonging to the
+  same scenario will run in a isolated context, called 'world'. A world also
+  contains the helpers methods that will be used in the step definitions.
+
+  It is possible to add helpers methods to a world in three different ways:
+
+  1. Passing a module. In this case its methods will be added directly to the
+     world and be usable in the step definitions.
+
+  2. Passing a block, where the return value is the world object.
+
+  3. Passing a hash, where the keys are namespaces and the values are
+     modules. In this case, the methods of each module will be accessible using
+     the key as prefix.
+
+  Scenario: A world is extended using a module
+    Given a file named "features/support/helpers.rb" with:
+      """
+      module Helpers
+        def helper_method
+          42
+        end
+      end
+
+      World(Helpers)
+      """
+    And a file named "features/step_definitions/step.rb" with:
+      """
+      Then /^the helper method is called$/ do
+        expect(helper_method).to eql(42)
+      end
+      """
+    And a file named "features/f.feature" with:
+      """
+      Feature: Calling a method
+        Scenario: I call a method without namespaces
+          Then the helper method is called
+      """
+    When I run `cucumber features/f.feature`
+    Then it should pass
+
+  Scenario: A world is created using a block
+    Given a file named "features/support/helpers.rb" with:
+      """
+      class Helper
+        def helper_method
+          42
+        end
+      end
+
+      World do
+        Helper.new
+      end
+      """
+    And a file named "features/step_definitions/step.rb" with:
+      """
+      Then /^the helper method is called$/ do
+        expect(helper_method).to eql(42)
+      end
+      """
+    And a file named "features/f.feature" with:
+      """
+      Feature: Calling a method
+        Scenario: I call a method from a namespace
+          Then the helper method is called
+      """
+    When I run `cucumber features/f.feature`
+    Then it should pass
+
+  Scenario: A world is extended using a module with namespace
+    Given a file named "features/support/helpers.rb" with:
+      """
+      module Helpers
+        def helper_method
+          42
+        end
+      end
+
+      World(my_namespace: Helpers)
+      """
+    And a file named "features/step_definitions/step.rb" with:
+      """
+      Then /^the helper method is called$/ do
+        expect(my_namespace.helper_method).to eql(42)
+      end
+      """
+    And a file named "features/f.feature" with:
+      """
+      Feature: Calling a method
+        Scenario: I call a method from a namespace
+          Then the helper method is called
+      """
+    When I run `cucumber features/f.feature`
+    Then it should pass
+
+  Scenario: A world is extended using multiple modules with different namespaces
+    Given a file named "features/support/helpers.rb" with:
+      """
+      module ModuleOne
+        def forty_one
+          41
+        end
+      end
+
+      module ModuleTwo
+        def forty_two
+          42
+        end
+      end
+
+      World(module_one: ModuleOne, module_two: ModuleTwo)
+      """
+    And a file named "features/step_definitions/step.rb" with:
+      """
+      Then /^the helper method is called$/ do
+        expect(module_one.forty_one).to eql(41)
+        expect(module_two.forty_two).to eql(42)
+      end
+      """
+    And a file named "features/f.feature" with:
+      """
+      Feature: Calling a method
+        Scenario: I call a method from two namespaces
+          Then the helper method is called
+      """
+    When I run `cucumber features/f.feature`
+    Then it should pass

data/features/lib/step_definitions/aruba_steps.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 Given('a Gemfile with:') do |content|
   path = File.expand_path(current_dir + "/Gemfile")
   write_file path, content

data/features/lib/step_definitions/cli_steps.rb

@@ -0,0 +1,4 @@
+# frozen_string_literal: true
+Then(/^I should see the CLI help$/) do
+  expect(all_output).to include("Usage:")
+end

data/features/lib/step_definitions/cucumber_steps.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 Given /^a directory without standard Cucumber project directory structure$/ do
   in_current_dir do
     FileUtils.rm_rf 'features' if File.directory?('features')

data/features/lib/step_definitions/iso-8859-1_steps.rb

@@ -1,4 +1,5 @@
 # encoding: iso-8859-1
+# frozen_string_literal: true
 # Ideally we would use Norwegian keywords here, but that won't work unless this file is UTF-8 encoded.
 # Alternatively it would be possible to use Norwegian keywords and encode the file as UTF-8.
 #

data/features/lib/step_definitions/json_steps.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 Then /^it should (pass|fail) with JSON:$/ do |pass_fail, json|
   actual = normalise_json(MultiJson.load(all_stdout))
   expected = MultiJson.load(json)

data/features/lib/step_definitions/junit_steps.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 Then(/^the junit output file "(.*?)" should contain:$/) do |actual_file, text|
   actual = IO.read(current_dir + '/' + actual_file)
   actual = replace_junit_time(actual)

data/features/lib/step_definitions/language_steps.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 
 Then(/^cucumber lists all the supported languages$/) do
   sample_languages = ["Arabic", "български", "Pirate", "English", "日本語"]

data/features/lib/step_definitions/profile_steps.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 Given /^the following profiles? (?:are|is) defined:$/ do |profiles|
   write_file 'cucumber.yml', profiles
 end

data/features/lib/step_definitions/retry_steps.rb

@@ -1,35 +1,55 @@
-Given /^a scenario "([^\"]*)" that fails once, then passes$/ do |name|
+# frozen_string_literal: true
+Given /^a scenario "([^\"]*)" that fails once, then passes$/ do |full_name|
+  name = snake_case(full_name)
   write_file "features/#{name}.feature",
   <<-FEATURE
-  Feature: #{name}
-    Scenario: #{name}
+  Feature: #{full_name} feature
+    Scenario: #{full_name}
       Given it fails once, then passes
   FEATURE
 
   write_file "features/step_defnitions/#{name}_steps.rb",
   <<-STEPS
   Given(/^it fails once, then passes$/) do
-    $#{name.downcase} ||= 0
-    $#{name.downcase} += 1
-    expect($#{name.downcase}).to eql 2
+    $#{name} += 1
+    expect($#{name}).to be > 1
   end
   STEPS
+
+  write_file "features/support/#{name}_init.rb",
+  <<-INIT
+  $#{name} = 0
+  INIT
 end
 
-Given /^a scenario "([^\"]*)" that fails twice, then passes$/ do |name|
+Given /^a scenario "([^\"]*)" that fails twice, then passes$/ do |full_name|
+  name = snake_case(full_name)
   write_file "features/#{name}.feature",
   <<-FEATURE
-  Feature: #{name}
-    Scenario: #{name}
+  Feature: #{full_name} feature
+    Scenario: #{full_name}
       Given it fails twice, then passes
   FEATURE
 
   write_file "features/step_definitions/#{name}_steps.rb",
   <<-STEPS
   Given(/^it fails twice, then passes$/) do
-    $#{name.downcase} ||= 0
-    $#{name.downcase} += 1
-    expect($#{name.downcase}).to eql 3
+    $#{name} ||= 0
+    $#{name} += 1
+    expect($#{name}).to be > 2
   end
   STEPS
+
+  write_file "features/support/#{name}_init.rb",
+  <<-INIT
+  $#{name} = 0
+  INIT
+end
+
+module SnakeCase
+  def snake_case(name)
+    name.downcase.gsub(/\W/, '_')
+  end
 end
+
+World(SnakeCase)

data/features/lib/step_definitions/ruby_steps.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 When(/^I run the following Ruby code:$/) do |code|
   run_simple %{ruby -e "#{code}"}
 end

data/features/lib/step_definitions/wire_steps.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 Given /^there is a wire server (running |)on port (\d+) which understands the following protocol:$/ do |running, port, table|
   protocol = table.hashes.map do |table_hash|
     table_hash['response'] = table_hash['response'].gsub(/\n/, '\n')

data/features/lib/support/env.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'aruba/cucumber'
 require 'aruba/in_process'
 require 'aruba/spawn_process'
@@ -17,5 +18,5 @@ Before do
   # set_env('SIMPLECOV', 'true')
 
   # Set a longer timeout for aruba, and a really long one if running on JRuby
-  @aruba_timeout_seconds = Cucumber::JRUBY ? 35 : 15
+  @aruba_timeout_seconds = Cucumber::JRUBY ? 60 : 15
 end

data/features/lib/support/fake_wire_server.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'multi_json'
 require 'socket'
 

data/features/lib/support/feature_factory.rb

@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# frozen_string_literal: true
 module FeatureFactory
   def create_feature(name = generate_feature_name)
     gherkin = <<-GHERKIN

data/features/lib/support/normalise_output.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # override aruba to filter out some stuff
 module NormaliseArubaOutput
   def all_stdout

data/gem_tasks/contributors.rake

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 desc 'List contributors'
 task :contributors do
   contributors = `git log --pretty=short --no-merges | git shortlog -ne | egrep -ve '^ +' | egrep -ve '^$'`.split("\n")

data/gem_tasks/cov.rake

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 desc 'Run all tests and collect code coverage'
 task :cov do
   ENV['SIMPLECOV'] = 'features'

data/gem_tasks/cucumber.rake

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/rake/task'
 require 'cucumber/platform'
 

data/gem_tasks/downloads.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'httparty'
 require 'multi_json'
 

data/gem_tasks/environment.rake

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 task :ruby_env do
   RUBY_APP = if RUBY_PLATFORM =~ /java/
     "jruby"

data/gem_tasks/examples.rake

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 desc 'Run all exmples'
 task :examples do
   Dir['examples/*'].each do |example_dir|
@@ -8,4 +9,4 @@ task :examples do
       sh "rake cucumber"
     end
   end
-end
+end

data/gem_tasks/fix_cr_lf.rake

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 desc 'Make all files use UNIX (\n) line endings'
 task :fix_cr_lf do
   files = FileList['**/*']
@@ -7,4 +8,4 @@ task :fix_cr_lf do
     s.gsub!(/\r?\n/, "\n")
     File.open(f, "w") { |io| io.write(s) }
   end
-end
+end

data/gem_tasks/flog.rake

@@ -1,4 +1,5 @@
+# frozen_string_literal: true
 desc "Run flog over significant files"
 task :flog do
   sh "find lib/cucumber -name \\*.rb | grep -v parser\/feature\\.rb | xargs flog"
-end
+end

data/gem_tasks/rspec.rake

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'rspec/core/rake_task'
 
 desc "Run RSpec"

data/gem_tasks/sass.rake

@@ -1,4 +1,5 @@
+# frozen_string_literal: true
 desc 'Generate the css for the html formatter from sass'
 task :sass do
   sh 'sass -t expanded lib/cucumber/formatter/cucumber.sass > lib/cucumber/formatter/cucumber.css'
-end
+end

data/lib/autotest/cucumber.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'autotest'
 require 'autotest/cucumber_mixin'
 

data/lib/autotest/cucumber_mixin.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'autotest'
 require 'tempfile'
 require 'cucumber'

data/lib/autotest/cucumber_rails.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'autotest/rails'
 require 'autotest/cucumber_mixin'
 

data/lib/autotest/cucumber_rails_rspec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'autotest/cucumber_mixin'
 require 'autotest/rails_rspec'
 

data/lib/autotest/cucumber_rails_rspec2.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'autotest/cucumber_mixin'
 require 'autotest/rails_rspec2'
 

data/lib/autotest/cucumber_rspec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'autotest/cucumber_mixin'
 require 'autotest/rspec'
 

data/lib/autotest/cucumber_rspec2.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'autotest/cucumber_mixin'
 require 'autotest/rspec2'
 

data/lib/autotest/discover.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 Autotest.add_discovery do
   if File.directory?('features')
     if ENV['AUTOFEATURE'] =~ /true/i

data/lib/cucumber.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'yaml'
 require 'cucumber/encoding'
 require 'cucumber/platform'
@@ -20,18 +21,5 @@ module Cucumber
     def logger=(logger)
       @log = logger
     end
-
-    if Cucumber::RUBY_1_9
-      # Backported from Ruby 2.0 to 1.9
-      def Hash(other)
-        return {} if other.nil? || other == []
-        raise TypeError, "can't convert #{other.class} into Hash" unless other.respond_to?(:to_hash)
-        other.to_hash
-      end
-    else
-      def Hash(other)
-        Kernel::Hash(other)
-      end
-    end
   end
 end