cookstyle 8.7.6 → 9.0.9

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (272) hide show
  1. checksums.yaml +4 -4
  2. data/config/chefstyle.yml +14 -0
  3. data/config/cookstyle.yml +157 -6
  4. data/lib/cookstyle/version.rb +2 -2
  5. data/lib/cookstyle.rb +5 -6
  6. data/lib/rubocop/chef/autocorrect_helpers.rb +1 -1
  7. data/lib/rubocop/chef/cookbook_helpers.rb +24 -1
  8. data/lib/rubocop/chef/platform_helpers.rb +1 -1
  9. data/lib/rubocop/chef.rb +1 -1
  10. data/lib/rubocop/cop/chef/correctness/block_guard_clause_string_only.rb +1 -1
  11. data/lib/rubocop/cop/chef/correctness/chef_application_fatal.rb +17 -5
  12. data/lib/rubocop/cop/chef/correctness/conditional_ruby_shellout.rb +1 -1
  13. data/lib/rubocop/cop/chef/correctness/conditional_unified_mode_true.rb +91 -0
  14. data/lib/rubocop/cop/chef/correctness/dnf_package_allow_downgrades.rb +1 -1
  15. data/lib/rubocop/cop/chef/correctness/empty_resource_guard.rb +18 -2
  16. data/lib/rubocop/cop/chef/correctness/execute_delete_file.rb +127 -0
  17. data/lib/rubocop/cop/chef/correctness/incorrect_library_injection.rb +1 -1
  18. data/lib/rubocop/cop/chef/correctness/invalid_checksum.rb +79 -0
  19. data/lib/rubocop/cop/chef/correctness/invalid_cookbook_name.rb +1 -1
  20. data/lib/rubocop/cop/chef/correctness/invalid_default_action.rb +1 -1
  21. data/lib/rubocop/cop/chef/correctness/invalid_notification_resource.rb +1 -1
  22. data/lib/rubocop/cop/chef/correctness/invalid_notification_timing.rb +1 -1
  23. data/lib/rubocop/cop/chef/correctness/invalid_platform_family_helper.rb +2 -2
  24. data/lib/rubocop/cop/chef/correctness/invalid_platform_family_values_in_case.rb +11 -1
  25. data/lib/rubocop/cop/chef/correctness/invalid_platform_helper.rb +1 -1
  26. data/lib/rubocop/cop/chef/correctness/invalid_platform_metadata.rb +1 -1
  27. data/lib/rubocop/cop/chef/correctness/invalid_platform_values_in_case.rb +11 -1
  28. data/lib/rubocop/cop/chef/correctness/invalid_value_for_platform_family_helper.rb +1 -1
  29. data/lib/rubocop/cop/chef/correctness/invalid_value_for_platform_helper.rb +2 -1
  30. data/lib/rubocop/cop/chef/correctness/invalid_version_metadata.rb +1 -1
  31. data/lib/rubocop/cop/chef/correctness/lazy_eval_node_attribute_defaults.rb +1 -1
  32. data/lib/rubocop/cop/chef/correctness/lazy_in_resource_guard.rb +1 -1
  33. data/lib/rubocop/cop/chef/correctness/macos_userdefaults_invalid_type.rb +1 -1
  34. data/lib/rubocop/cop/chef/correctness/malformed_value_for_platform.rb +1 -1
  35. data/lib/rubocop/cop/chef/correctness/metadata_malformed_version.rb +1 -1
  36. data/lib/rubocop/cop/chef/correctness/metadata_missing_name.rb +1 -1
  37. data/lib/rubocop/cop/chef/correctness/metadata_missing_version.rb +1 -1
  38. data/lib/rubocop/cop/chef/correctness/node_save.rb +1 -1
  39. data/lib/rubocop/cop/chef/correctness/notifies_action_not_symbol.rb +1 -1
  40. data/lib/rubocop/cop/chef/correctness/octal_mode_as_string.rb +1 -1
  41. data/lib/rubocop/cop/chef/correctness/openssl_password_helpers.rb +1 -1
  42. data/lib/rubocop/cop/chef/correctness/platform_version_string_comparison.rb +66 -0
  43. data/lib/rubocop/cop/chef/correctness/powershell_delete_file.rb +6 -6
  44. data/lib/rubocop/cop/chef/correctness/powershell_file_exists.rb +2 -2
  45. data/lib/rubocop/cop/chef/correctness/property_without_type.rb +1 -1
  46. data/lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb +1 -1
  47. data/lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb +1 -1
  48. data/lib/rubocop/cop/chef/correctness/resource_with_none_action.rb +4 -4
  49. data/lib/rubocop/cop/chef/correctness/ruby_guard_without_block.rb +91 -0
  50. data/lib/rubocop/cop/chef/correctness/scoped_file_exist.rb +1 -1
  51. data/lib/rubocop/cop/chef/correctness/service_resource.rb +71 -20
  52. data/lib/rubocop/cop/chef/correctness/supports_must_be_float.rb +1 -1
  53. data/lib/rubocop/cop/chef/deprecation/cb_depends_on_self.rb +1 -1
  54. data/lib/rubocop/cop/chef/deprecation/chef_handler_recipe.rb +9 -2
  55. data/lib/rubocop/cop/chef/deprecation/chef_handler_supports.rb +1 -1
  56. data/lib/rubocop/cop/chef/deprecation/chef_rest.rb +5 -2
  57. data/lib/rubocop/cop/chef/deprecation/chef_rewind.rb +1 -1
  58. data/lib/rubocop/cop/chef/deprecation/chef_shellout.rb +3 -3
  59. data/lib/rubocop/cop/chef/deprecation/chef_sugar_helpers.rb +7 -1
  60. data/lib/rubocop/cop/chef/deprecation/chef_windows_platform_helper.rb +2 -2
  61. data/lib/rubocop/cop/chef/deprecation/chefdk_generators.rb +1 -1
  62. data/lib/rubocop/cop/chef/deprecation/cheffile.rb +1 -1
  63. data/lib/rubocop/cop/chef/deprecation/chefspec_coverage_report.rb +1 -1
  64. data/lib/rubocop/cop/chef/deprecation/chefspec_legacy_runner.rb +1 -1
  65. data/lib/rubocop/cop/chef/deprecation/chocolatey_package_uninstall_action.rb +4 -4
  66. data/lib/rubocop/cop/chef/deprecation/delivery.rb +1 -1
  67. data/lib/rubocop/cop/chef/deprecation/depends_chef_nginx_cookbook.rb +1 -1
  68. data/lib/rubocop/cop/chef/deprecation/depends_chef_reporting_cookbook.rb +1 -1
  69. data/lib/rubocop/cop/chef/deprecation/depends_compat_resource.rb +1 -1
  70. data/lib/rubocop/cop/chef/deprecation/depends_omnibus_updater_cookbook.rb +1 -1
  71. data/lib/rubocop/cop/chef/deprecation/depends_partial_search.rb +5 -1
  72. data/lib/rubocop/cop/chef/deprecation/depends_poise.rb +1 -1
  73. data/lib/rubocop/cop/chef/deprecation/deprecated_chefspec_platform.rb +1 -1
  74. data/lib/rubocop/cop/chef/deprecation/deprecated_mixins.rb +3 -3
  75. data/lib/rubocop/cop/chef/deprecation/deprecated_platform_methods.rb +1 -1
  76. data/lib/rubocop/cop/chef/deprecation/deprecated_shellout_methods.rb +1 -1
  77. data/lib/rubocop/cop/chef/deprecation/deprecated_sudo_actions.rb +1 -1
  78. data/lib/rubocop/cop/chef/deprecation/deprecated_windows_version_check.rb +1 -1
  79. data/lib/rubocop/cop/chef/deprecation/deprecated_yum_repository_actions.rb +1 -1
  80. data/lib/rubocop/cop/chef/deprecation/deprecated_yum_repository_properties.rb +1 -1
  81. data/lib/rubocop/cop/chef/deprecation/easy_install.rb +1 -1
  82. data/lib/rubocop/cop/chef/deprecation/eol_audit_mode.rb +1 -1
  83. data/lib/rubocop/cop/chef/deprecation/epic_fail.rb +1 -1
  84. data/lib/rubocop/cop/chef/deprecation/erl_call.rb +1 -1
  85. data/lib/rubocop/cop/chef/deprecation/execute_path_property.rb +1 -1
  86. data/lib/rubocop/cop/chef/deprecation/execute_relative_creates_without_cwd.rb +1 -1
  87. data/lib/rubocop/cop/chef/deprecation/foodcritic_file.rb +1 -1
  88. data/lib/rubocop/cop/chef/deprecation/foodcritic_testing.rb +1 -1
  89. data/lib/rubocop/cop/chef/deprecation/hwrp_without_provides.rb +5 -5
  90. data/lib/rubocop/cop/chef/deprecation/hwrp_without_unified_mode_true.rb +3 -3
  91. data/lib/rubocop/cop/chef/deprecation/inherits_compat_resource.rb +4 -4
  92. data/lib/rubocop/cop/chef/deprecation/launchd_deprecated_hash_property.rb +1 -1
  93. data/lib/rubocop/cop/chef/deprecation/legacy_notify_syntax.rb +1 -1
  94. data/lib/rubocop/cop/chef/deprecation/legacy_yum_cookbook_recipes.rb +10 -2
  95. data/lib/rubocop/cop/chef/deprecation/librarian_chefspec.rb +1 -1
  96. data/lib/rubocop/cop/chef/deprecation/locale_lc_all_property.rb +6 -1
  97. data/lib/rubocop/cop/chef/deprecation/log_resource_notifications.rb +1 -1
  98. data/lib/rubocop/cop/chef/deprecation/macos_userdefaults_global_property.rb +1 -1
  99. data/lib/rubocop/cop/chef/deprecation/name_property_and_default.rb +1 -1
  100. data/lib/rubocop/cop/chef/deprecation/node_methods_not_attributes.rb +1 -1
  101. data/lib/rubocop/cop/chef/deprecation/partial_search_class_usage.rb +1 -1
  102. data/lib/rubocop/cop/chef/deprecation/partial_search_helper_usage.rb +1 -1
  103. data/lib/rubocop/cop/chef/deprecation/poise_archive.rb +1 -1
  104. data/lib/rubocop/cop/chef/deprecation/policyfile_community_source.rb +1 -1
  105. data/lib/rubocop/cop/chef/deprecation/powershell_cookbook_helpers.rb +1 -1
  106. data/lib/rubocop/cop/chef/deprecation/require_recipe.rb +1 -1
  107. data/lib/rubocop/cop/chef/deprecation/resource_overrides_provides_method.rb +1 -1
  108. data/lib/rubocop/cop/chef/deprecation/resource_uses_dsl_name_method.rb +1 -1
  109. data/lib/rubocop/cop/chef/deprecation/resource_uses_only_resource_name.rb +10 -2
  110. data/lib/rubocop/cop/chef/deprecation/resource_uses_provider_base_method.rb +5 -1
  111. data/lib/rubocop/cop/chef/deprecation/resource_uses_updated_method.rb +1 -1
  112. data/lib/rubocop/cop/chef/deprecation/resource_without_unified_mode_true.rb +1 -1
  113. data/lib/rubocop/cop/chef/deprecation/ruby_27_keyword_argument_warnings.rb +1 -1
  114. data/lib/rubocop/cop/chef/deprecation/ruby_block_create_action.rb +43 -4
  115. data/lib/rubocop/cop/chef/deprecation/run_command_helper.rb +1 -1
  116. data/lib/rubocop/cop/chef/deprecation/search_uses_positional_parameters.rb +1 -1
  117. data/lib/rubocop/cop/chef/deprecation/use_automatic_resource_name.rb +10 -1
  118. data/lib/rubocop/cop/chef/deprecation/use_inline_resources.rb +1 -1
  119. data/lib/rubocop/cop/chef/deprecation/use_yaml_dump.rb +6 -1
  120. data/lib/rubocop/cop/chef/deprecation/user_supports_property.rb +1 -1
  121. data/lib/rubocop/cop/chef/deprecation/verify_property_file_expansion.rb +1 -1
  122. data/lib/rubocop/cop/chef/deprecation/windows_feature_servermanagercmd.rb +1 -1
  123. data/lib/rubocop/cop/chef/deprecation/windows_package_installer_type_string.rb +1 -1
  124. data/lib/rubocop/cop/chef/deprecation/windows_task_change_action.rb +1 -1
  125. data/lib/rubocop/cop/chef/deprecation/windows_version_helpers.rb +1 -1
  126. data/lib/rubocop/cop/chef/deprecation/xml_ruby_recipe.rb +6 -2
  127. data/lib/rubocop/cop/chef/deprecation/yum_dnf_compat_recipe.rb +1 -1
  128. data/lib/rubocop/cop/chef/effortless/berksfile.rb +1 -1
  129. data/lib/rubocop/cop/chef/effortless/data_bags.rb +1 -1
  130. data/lib/rubocop/cop/chef/effortless/node_environment.rb +1 -1
  131. data/lib/rubocop/cop/chef/effortless/node_policygroup.rb +1 -1
  132. data/lib/rubocop/cop/chef/effortless/node_roles.rb +1 -1
  133. data/lib/rubocop/cop/chef/effortless/search_for_environments_or_roles.rb +1 -1
  134. data/lib/rubocop/cop/chef/effortless/search_used.rb +1 -1
  135. data/lib/rubocop/cop/chef/modernize/action_method_in_resource.rb +1 -1
  136. data/lib/rubocop/cop/chef/modernize/allowed_actions_initializer.rb +1 -1
  137. data/lib/rubocop/cop/chef/modernize/apt_default_recipe.rb +2 -2
  138. data/lib/rubocop/cop/chef/modernize/berksfile_source.rb +1 -1
  139. data/lib/rubocop/cop/chef/modernize/build_essential.rb +5 -2
  140. data/lib/rubocop/cop/chef/modernize/chef_14_resources.rb +9 -1
  141. data/lib/rubocop/cop/chef/modernize/chef_15_resources.rb +12 -1
  142. data/lib/rubocop/cop/chef/modernize/chef_gem_nokogiri.rb +5 -1
  143. data/lib/rubocop/cop/chef/modernize/class_eval_action_class.rb +1 -1
  144. data/lib/rubocop/cop/chef/modernize/compile_time_resources.rb +1 -1
  145. data/lib/rubocop/cop/chef/modernize/conditional_using_test.rb +11 -4
  146. data/lib/rubocop/cop/chef/modernize/cron_d_file_or_template.rb +7 -5
  147. data/lib/rubocop/cop/chef/modernize/cron_manage_resource.rb +1 -1
  148. data/lib/rubocop/cop/chef/modernize/databag_helpers.rb +7 -4
  149. data/lib/rubocop/cop/chef/modernize/declare_action_class.rb +1 -1
  150. data/lib/rubocop/cop/chef/modernize/default_action_initializer.rb +1 -1
  151. data/lib/rubocop/cop/chef/modernize/defines_chefspec_matchers.rb +1 -1
  152. data/lib/rubocop/cop/chef/modernize/definitions.rb +1 -1
  153. data/lib/rubocop/cop/chef/modernize/depends_chef_vault_cookbook.rb +5 -1
  154. data/lib/rubocop/cop/chef/modernize/depends_chocolatey_cookbooks.rb +8 -1
  155. data/lib/rubocop/cop/chef/modernize/depends_kernel_module_cookbook.rb +7 -1
  156. data/lib/rubocop/cop/chef/modernize/depends_locale_cookbook.rb +7 -1
  157. data/lib/rubocop/cop/chef/modernize/depends_openssl_cookbook.rb +10 -1
  158. data/lib/rubocop/cop/chef/modernize/depends_timezone_lwrp_cookbook.rb +5 -1
  159. data/lib/rubocop/cop/chef/modernize/depends_windows_firewall_cookbook.rb +9 -1
  160. data/lib/rubocop/cop/chef/modernize/depends_zypper_cookbook.rb +8 -1
  161. data/lib/rubocop/cop/chef/modernize/dsl_include_in_resource.rb +2 -2
  162. data/lib/rubocop/cop/chef/modernize/empty_resource_initialize.rb +1 -1
  163. data/lib/rubocop/cop/chef/modernize/execute_apt_update.rb +4 -2
  164. data/lib/rubocop/cop/chef/modernize/execute_archive_extract.rb +121 -0
  165. data/lib/rubocop/cop/chef/modernize/execute_sc_exe.rb +1 -1
  166. data/lib/rubocop/cop/chef/modernize/execute_sleep.rb +1 -1
  167. data/lib/rubocop/cop/chef/modernize/execute_sysctl.rb +1 -1
  168. data/lib/rubocop/cop/chef/modernize/execute_tzutil.rb +1 -1
  169. data/lib/rubocop/cop/chef/modernize/execute_update_alternatives.rb +100 -0
  170. data/lib/rubocop/cop/chef/modernize/foodcritic_comments.rb +1 -1
  171. data/lib/rubocop/cop/chef/modernize/if_provides_default_action.rb +1 -1
  172. data/lib/rubocop/cop/chef/modernize/includes_mixin_shellout.rb +5 -1
  173. data/lib/rubocop/cop/chef/modernize/libarchive_file.rb +6 -4
  174. data/lib/rubocop/cop/chef/modernize/macos_user_defaults.rb +1 -1
  175. data/lib/rubocop/cop/chef/modernize/minitest_handler_usage.rb +1 -1
  176. data/lib/rubocop/cop/chef/modernize/node_init_package.rb +1 -1
  177. data/lib/rubocop/cop/chef/modernize/node_roles_include.rb +1 -1
  178. data/lib/rubocop/cop/chef/modernize/ohai_default_recipe.rb +7 -2
  179. data/lib/rubocop/cop/chef/modernize/openssl_rsa_key_resource.rb +1 -1
  180. data/lib/rubocop/cop/chef/modernize/openssl_x509_resource.rb +1 -1
  181. data/lib/rubocop/cop/chef/modernize/osx_config_profile_resource.rb +1 -1
  182. data/lib/rubocop/cop/chef/modernize/powershell_download_file.rb +64 -0
  183. data/lib/rubocop/cop/chef/modernize/powershell_expand_archive.rb +9 -2
  184. data/lib/rubocop/cop/chef/modernize/powershell_guard_interpreter.rb +5 -5
  185. data/lib/rubocop/cop/chef/modernize/powershell_install_package.rb +1 -1
  186. data/lib/rubocop/cop/chef/modernize/powershell_install_windowsfeature.rb +1 -1
  187. data/lib/rubocop/cop/chef/modernize/property_with_name_attribute.rb +1 -1
  188. data/lib/rubocop/cop/chef/modernize/provides_initializer.rb +1 -1
  189. data/lib/rubocop/cop/chef/modernize/resource_name_initializer.rb +1 -1
  190. data/lib/rubocop/cop/chef/modernize/resource_set_or_return.rb +1 -1
  191. data/lib/rubocop/cop/chef/modernize/resource_with_attributes.rb +1 -1
  192. data/lib/rubocop/cop/chef/modernize/respond_to_compile_time.rb +1 -1
  193. data/lib/rubocop/cop/chef/modernize/respond_to_metadata.rb +1 -1
  194. data/lib/rubocop/cop/chef/modernize/respond_to_provides.rb +1 -1
  195. data/lib/rubocop/cop/chef/modernize/respond_to_resource_name.rb +1 -1
  196. data/lib/rubocop/cop/chef/modernize/sc_windows_resource.rb +3 -3
  197. data/lib/rubocop/cop/chef/modernize/seven_zip_archive.rb +8 -2
  198. data/lib/rubocop/cop/chef/modernize/shell_out_helper.rb +1 -1
  199. data/lib/rubocop/cop/chef/modernize/shellouts_to_chocolatey.rb +16 -5
  200. data/lib/rubocop/cop/chef/modernize/simplify_apt_ppa_setup.rb +1 -1
  201. data/lib/rubocop/cop/chef/modernize/sysctl_param_resource.rb +1 -1
  202. data/lib/rubocop/cop/chef/modernize/unnecessary_mixlib_shellout_require.rb +1 -1
  203. data/lib/rubocop/cop/chef/modernize/use_chef_language_cloud_helpers.rb +1 -1
  204. data/lib/rubocop/cop/chef/modernize/use_chef_language_env_helpers.rb +1 -1
  205. data/lib/rubocop/cop/chef/modernize/use_chef_language_systemd_helper.rb +1 -1
  206. data/lib/rubocop/cop/chef/modernize/use_multipackage_installs.rb +1 -1
  207. data/lib/rubocop/cop/chef/modernize/use_require_relative.rb +2 -2
  208. data/lib/rubocop/cop/chef/modernize/whyrun_supported_true.rb +1 -1
  209. data/lib/rubocop/cop/chef/modernize/windows_default_recipe.rb +2 -2
  210. data/lib/rubocop/cop/chef/modernize/windows_registry_uac.rb +1 -1
  211. data/lib/rubocop/cop/chef/modernize/windows_zipfile.rb +9 -3
  212. data/lib/rubocop/cop/chef/modernize/zipfile_resource.rb +8 -2
  213. data/lib/rubocop/cop/chef/modernize/zypper_repo.rb +3 -3
  214. data/lib/rubocop/cop/chef/redundant/apt_repository_distribution_default.rb +1 -1
  215. data/lib/rubocop/cop/chef/redundant/apt_repository_notifies_apt_update.rb +1 -1
  216. data/lib/rubocop/cop/chef/redundant/attribute_metadata.rb +1 -1
  217. data/lib/rubocop/cop/chef/redundant/conflicts_metadata.rb +1 -1
  218. data/lib/rubocop/cop/chef/redundant/custom_resource_with_allowed_actions.rb +11 -1
  219. data/lib/rubocop/cop/chef/redundant/double_compile_time.rb +23 -9
  220. data/lib/rubocop/cop/chef/redundant/grouping_metadata.rb +1 -1
  221. data/lib/rubocop/cop/chef/redundant/long_description_metadata.rb +1 -1
  222. data/lib/rubocop/cop/chef/redundant/multiple_platform_checks.rb +1 -1
  223. data/lib/rubocop/cop/chef/redundant/name_property_and_required.rb +1 -1
  224. data/lib/rubocop/cop/chef/redundant/ohai_attribute_to_string.rb +1 -1
  225. data/lib/rubocop/cop/chef/redundant/property_splat_regex.rb +1 -1
  226. data/lib/rubocop/cop/chef/redundant/property_with_default_and_required.rb +1 -1
  227. data/lib/rubocop/cop/chef/redundant/provides_metadata.rb +1 -1
  228. data/lib/rubocop/cop/chef/redundant/recipe_metadata.rb +1 -1
  229. data/lib/rubocop/cop/chef/redundant/replaces_metadata.rb +1 -1
  230. data/lib/rubocop/cop/chef/redundant/resource_with_nothing_action.rb +1 -1
  231. data/lib/rubocop/cop/chef/redundant/sensitive_property_in_resource.rb +1 -1
  232. data/lib/rubocop/cop/chef/redundant/service_guard_on_stop_disable.rb +117 -0
  233. data/lib/rubocop/cop/chef/redundant/string_property_with_nil_default.rb +3 -3
  234. data/lib/rubocop/cop/chef/redundant/suggests_metadata.rb +1 -1
  235. data/lib/rubocop/cop/chef/redundant/unnecessary_desired_state.rb +1 -1
  236. data/lib/rubocop/cop/chef/redundant/unnecessary_name_property.rb +2 -2
  237. data/lib/rubocop/cop/chef/redundant/use_create_if_missing.rb +1 -1
  238. data/lib/rubocop/cop/chef/security/insecure_remote_file_source.rb +82 -0
  239. data/lib/rubocop/cop/chef/security/ssh_private_key.rb +10 -1
  240. data/lib/rubocop/cop/chef/sharing/default_maintainer_metadata.rb +1 -1
  241. data/lib/rubocop/cop/chef/sharing/empty_metadata_field.rb +1 -1
  242. data/lib/rubocop/cop/chef/sharing/empty_property_description.rb +62 -0
  243. data/lib/rubocop/cop/chef/sharing/include_property_descriptions.rb +1 -1
  244. data/lib/rubocop/cop/chef/sharing/include_resource_descriptions.rb +1 -1
  245. data/lib/rubocop/cop/chef/sharing/include_resource_examples.rb +1 -1
  246. data/lib/rubocop/cop/chef/sharing/insecure_cookbook_url.rb +1 -1
  247. data/lib/rubocop/cop/chef/sharing/invalid_license_string.rb +1 -1
  248. data/lib/rubocop/cop/chef/style/chef_whaaat.rb +1 -1
  249. data/lib/rubocop/cop/chef/style/comment_sentence_spacing.rb +1 -1
  250. data/lib/rubocop/cop/chef/style/comments_copyright_format.rb +1 -1
  251. data/lib/rubocop/cop/chef/style/comments_default_copyright.rb +1 -1
  252. data/lib/rubocop/cop/chef/style/comments_format.rb +1 -1
  253. data/lib/rubocop/cop/chef/style/immediate_notification_timing.rb +1 -1
  254. data/lib/rubocop/cop/chef/style/include_recipe_with_parentheses.rb +6 -3
  255. data/lib/rubocop/cop/chef/style/negating_only_if.rb +1 -1
  256. data/lib/rubocop/cop/chef/style/overly_complex_supports_depends_metadata.rb +1 -1
  257. data/lib/rubocop/cop/chef/style/simplify_platform_major_version_check.rb +1 -1
  258. data/lib/rubocop/cop/chef/style/true_false_resource_properties.rb +2 -2
  259. data/lib/rubocop/cop/chef/style/unnecessary_os_check.rb +1 -1
  260. data/lib/rubocop/cop/chef/style/unnecessary_platform_case_statement.rb +1 -1
  261. data/lib/rubocop/cop/chef/style/use_platform_helpers.rb +1 -1
  262. data/lib/rubocop/cop/chef.rb +349 -0
  263. data/lib/rubocop/cop/chefstyle/ruby/gemspec_license.rb +1 -1
  264. data/lib/rubocop/cop/chefstyle/ruby/gemspec_require_rubygems.rb +1 -1
  265. data/lib/rubocop/cop/chefstyle/ruby/legacy_powershell_out_methods.rb +1 -1
  266. data/lib/rubocop/cop/chefstyle/ruby/require_net_https.rb +1 -1
  267. data/lib/rubocop/cop/chefstyle/ruby/unless_defined_require.rb +1 -1
  268. data/lib/rubocop/cop/inspec/deprecation/attribute_default.rb +1 -1
  269. data/lib/rubocop/cop/inspec/deprecation/attribute_helper.rb +1 -1
  270. data/lib/rubocop/cop/inspec.rb +31 -0
  271. data/lib/rubocop/monkey_patches/directive_comment.rb +21 -3
  272. metadata +21 -8
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -26,6 +26,10 @@ module RuboCop
26
26
  # # bad
27
27
  # depends 'chef-vault'
28
28
  #
29
+ # # good
30
+ # # the chef-vault helpers ship in Chef Infra Client 16+, so use them without a depends
31
+ # chef_vault_item('secrets', 'my_secret')
32
+ #
29
33
  class DependsOnChefVaultCookbook < Base
30
34
  extend AutoCorrector
31
35
  extend TargetChefVersion
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -27,6 +27,13 @@ module RuboCop
27
27
  # depends 'chocolatey_source'
28
28
  # depends 'chocolatey_config'
29
29
  #
30
+ # # good
31
+ # # the resources ship in Chef Infra Client 14.3+, so use them without a depends
32
+ # chocolatey_source 'internal' do
33
+ # source 'https://mycorp.example/nuget'
34
+ # action :add
35
+ # end
36
+ #
30
37
  class DependsOnChocolateyCookbooks < Base
31
38
  extend AutoCorrector
32
39
  extend TargetChefVersion
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -26,6 +26,12 @@ module RuboCop
26
26
  # # bad
27
27
  # depends 'kernel_module'
28
28
  #
29
+ # # good
30
+ # # the resource ships in Chef Infra Client 14.3+, so use it without a depends
31
+ # kernel_module 'loop' do
32
+ # action :install
33
+ # end
34
+ #
29
35
  class DependsOnKernelModuleCookbook < Base
30
36
  extend AutoCorrector
31
37
  extend TargetChefVersion
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -26,6 +26,12 @@ module RuboCop
26
26
  # # bad
27
27
  # depends 'locale'
28
28
  #
29
+ # # good
30
+ # # the resource ships in Chef Infra Client 14.5+, so use it without a depends
31
+ # locale 'set locale' do
32
+ # lang 'en_us.UTF-8'
33
+ # end
34
+ #
29
35
  class DependsOnLocaleCookbook < Base
30
36
  extend AutoCorrector
31
37
  extend TargetChefVersion
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -26,6 +26,15 @@ module RuboCop
26
26
  # # bad
27
27
  # depends 'openssl'
28
28
  #
29
+ # # good
30
+ # # the openssl_* resources ship in Chef Infra Client 14.4+, so use them without a depends
31
+ # openssl_x509_certificate '/etc/httpd/ssl/mycert.pem' do
32
+ # common_name 'www.example.com'
33
+ # org 'Example Inc'
34
+ # org_unit 'IT'
35
+ # country 'US'
36
+ # end
37
+ #
29
38
  class DependsOnOpensslCookbook < Base
30
39
  extend AutoCorrector
31
40
  extend TargetChefVersion
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -26,6 +26,10 @@ module RuboCop
26
26
  # # bad
27
27
  # depends 'timezone_lwrp'
28
28
  #
29
+ # # good
30
+ # # the resource ships in Chef Infra Client 14.6+, so use it without a depends
31
+ # timezone 'UTC'
32
+ #
29
33
  class DependsOnTimezoneLwrpCookbook < Base
30
34
  extend AutoCorrector
31
35
  extend TargetChefVersion
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -26,6 +26,14 @@ module RuboCop
26
26
  # # bad
27
27
  # depends 'windows_firewall'
28
28
  #
29
+ # # good
30
+ # # the resource ships in Chef Infra Client 14.7+, so use it without a depends
31
+ # windows_firewall_rule 'permit ssh' do
32
+ # local_port '22'
33
+ # protocol 'TCP'
34
+ # firewall_action :allow
35
+ # end
36
+ #
29
37
  class DependsOnWindowsFirewallCookbook < Base
30
38
  extend AutoCorrector
31
39
  extend TargetChefVersion
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -26,6 +26,13 @@ module RuboCop
26
26
  # # bad
27
27
  # depends 'zypper'
28
28
  #
29
+ # # good
30
+ # # the resource ships in Chef Infra Client 13.3+, so use it without a depends
31
+ # zypper_repository 'apache' do
32
+ # baseurl 'https://download.opensuse.org/repositories/Apache'
33
+ # action :add
34
+ # end
35
+ #
29
36
  class DependsOnZypperCookbook < Base
30
37
  extend AutoCorrector
31
38
  extend TargetChefVersion
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -38,7 +38,7 @@ module RuboCop
38
38
  (send nil? :include
39
39
  (const
40
40
  (const
41
- (const nil? :Chef) :DSL) {:Recipe :IncludeRecipe}))
41
+ (const {nil? cbase} :Chef) :DSL) {:Recipe :IncludeRecipe}))
42
42
  PATTERN
43
43
 
44
44
  def on_send(node)
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -53,8 +53,10 @@ module RuboCop
53
53
  (send nil? :execute (str { "apt-get update" "apt-get update -y" "apt-get -y update" }))
54
54
  PATTERN
55
55
 
56
+ # the notification timing is optional and defaults to :delayed, so the trailing
57
+ # argument is matched with ... rather than being required
56
58
  def_node_matcher :notification_property?, <<-PATTERN
57
- (send nil? {:notifies :subscribes} (sym _) $(...) (sym _))
59
+ (send nil? {:notifies :subscribes} (sym _) $(...) ...)
58
60
  PATTERN
59
61
 
60
62
  def_node_matcher :execute_command?, <<-PATTERN
@@ -0,0 +1,121 @@
1
+ # frozen_string_literal: true
2
+ #
3
+ # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
+ #
6
+ # Licensed under the Apache License, Version 2.0 (the "License");
7
+ # you may not use this file except in compliance with the License.
8
+ # You may obtain a copy of the License at
9
+ #
10
+ # http://www.apache.org/licenses/LICENSE-2.0
11
+ #
12
+ # Unless required by applicable law or agreed to in writing, software
13
+ # distributed under the License is distributed on an "AS IS" BASIS,
14
+ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15
+ # See the License for the specific language governing permissions and
16
+ # limitations under the License.
17
+ #
18
+ module RuboCop
19
+ module Cop
20
+ module Chef
21
+ module Modernize
22
+ # Use the archive_file resource built into Chef Infra Client 15+ instead of shelling out to
23
+ # tar or unzip. The resource extracts tar, tar.gz, tar.bz2, tar.xz, and zip archives, and it
24
+ # only runs when the archive is newer than what was already extracted, where the shelled out
25
+ # command re-extracts on every converge.
26
+ #
27
+ # @example
28
+ #
29
+ # # bad
30
+ # execute 'extract nginx' do
31
+ # command "tar xzf #{Chef::Config[:file_cache_path]}/nginx.tar.gz -C /opt/nginx"
32
+ # end
33
+ #
34
+ # execute 'unzip -o /tmp/app.zip -d /opt/app'
35
+ #
36
+ # # good
37
+ # archive_file 'extract nginx' do
38
+ # path "#{Chef::Config[:file_cache_path]}/nginx.tar.gz"
39
+ # destination '/opt/nginx'
40
+ # end
41
+ #
42
+ class ExecuteArchiveExtract < Base
43
+ include RuboCop::Chef::CookbookHelpers
44
+ extend TargetChefVersion
45
+
46
+ minimum_target_chef_version '15.0'
47
+
48
+ MSG = 'Use the archive_file resource built into Chef Infra Client 15+ instead of shelling out to tar or unzip'
49
+ RESTRICT_ON_SEND = [:execute].freeze
50
+
51
+ # `tar` extracts when its short flags include an x, or with the --extract long option.
52
+ # Anchoring the flag cluster directly after `tar` keeps `tar czf` (create), `tar tzf`
53
+ # (list), and `tar --exclude=.git -czf` from matching, since none of those put an x
54
+ # in the first cluster.
55
+ EXTRACT_COMMAND = %r{
56
+ \A\s*(?:\S*/)?(?:
57
+ tar\s+(?:-)?[a-z]*x[a-z]*(?:\s|\z) | # tar xzf / tar -xzf / tar zxvf
58
+ tar\s+--extract\b | # tar --extract --file
59
+ unzip(?:\s|\z) # unzip -o foo.zip -d /opt
60
+ )
61
+ }xi.freeze
62
+
63
+ # the shell resources whose script lives in a code property
64
+ SCRIPT_RESOURCES = %i(bash sh csh ksh zsh script).freeze
65
+
66
+ # A command that chains, pipes, or substitutes is doing more than extracting, so
67
+ # archive_file cannot replace it wholesale and the suggestion would be wrong.
68
+ SHELL_OPERATORS = ['&&', '||', ';', '|', '`', '$(', "\n"].freeze
69
+
70
+ def on_send(node)
71
+ command = node.arguments.first
72
+ return unless command
73
+
74
+ # Match on source rather than .value so an interpolated name such as
75
+ # execute "tar xzf #{node['foo']['tarball']}" is caught too -- that is a
76
+ # dstr node whose .value does not exist.
77
+ return unless %i(str dstr).include?(command.type)
78
+
79
+ add_offense(node, severity: :refactor) if extracts_archive?(unquote(command.source))
80
+ end
81
+
82
+ def on_block(node)
83
+ match_property_in_resource?(:execute, 'command', node) do |property|
84
+ report_property(node, property)
85
+ end
86
+
87
+ match_property_in_resource?(SCRIPT_RESOURCES, 'code', node) do |property|
88
+ report_property(node, property)
89
+ end
90
+ end
91
+
92
+ private
93
+
94
+ # strip the surrounding quotes off a string literal's source so the
95
+ # command regexes, which are anchored at the start, still match
96
+ #
97
+ # @param [String] source
98
+ #
99
+ # @return [String]
100
+ def unquote(source)
101
+ source.sub(/\A["']/, '').sub(/["']\z/, '')
102
+ end
103
+
104
+ def report_property(node, property)
105
+ command = method_arg_ast_to_string(property)
106
+ add_offense(node, severity: :refactor) if command && extracts_archive?(command)
107
+ end
108
+
109
+ # @param [String] command
110
+ #
111
+ # @return [Boolean]
112
+ def extracts_archive?(command)
113
+ return false if SHELL_OPERATORS.any? { |operator| command.include?(operator) }
114
+
115
+ EXTRACT_COMMAND.match?(command)
116
+ end
117
+ end
118
+ end
119
+ end
120
+ end
121
+ end
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -0,0 +1,100 @@
1
+ # frozen_string_literal: true
2
+ #
3
+ # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
+ #
6
+ # Licensed under the Apache License, Version 2.0 (the "License");
7
+ # you may not use this file except in compliance with the License.
8
+ # You may obtain a copy of the License at
9
+ #
10
+ # http://www.apache.org/licenses/LICENSE-2.0
11
+ #
12
+ # Unless required by applicable law or agreed to in writing, software
13
+ # distributed under the License is distributed on an "AS IS" BASIS,
14
+ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15
+ # See the License for the specific language governing permissions and
16
+ # limitations under the License.
17
+ #
18
+ module RuboCop
19
+ module Cop
20
+ module Chef
21
+ module Modernize
22
+ # Chef Infra Client 16.0 and later includes an `alternatives` resource that should be used to
23
+ # manage alternatives links instead of shelling out to `update-alternatives` or `alternatives`.
24
+ # The resource is idempotent and handles both the Debian and RHEL flavours of the command, where
25
+ # an `execute` re-runs on every converge and reports the resource as updated every time.
26
+ #
27
+ # @example
28
+ #
29
+ # # bad
30
+ # execute 'install java alternative' do
31
+ # command 'update-alternatives --install /usr/bin/java java /usr/lib/jvm/jre-11/bin/java 1'
32
+ # end
33
+ #
34
+ # execute 'alternatives --set java /usr/lib/jvm/jre-11/bin/java'
35
+ #
36
+ # # good
37
+ # alternatives 'java' do
38
+ # link '/usr/bin/java'
39
+ # path '/usr/lib/jvm/jre-11/bin/java'
40
+ # priority 1
41
+ # action :install
42
+ # end
43
+ #
44
+ class ExecuteUpdateAlternatives < Base
45
+ include RuboCop::Chef::CookbookHelpers
46
+ extend TargetChefVersion
47
+
48
+ minimum_target_chef_version '16.0'
49
+
50
+ MSG = 'Chef Infra Client 16.0 and later includes an alternatives resource that should be used to manage alternatives links instead of shelling out to update-alternatives or alternatives'
51
+ RESTRICT_ON_SEND = [:execute].freeze
52
+
53
+ # Debian ships update-alternatives and RHEL ships alternatives, and the resource drives both.
54
+ # Matching is limited to the four subcommands the resource can express: --install, --set,
55
+ # --auto, and --remove. The rest are deliberately left alone -- --config and --display are
56
+ # interactive or read only, and --remove-all has no resource equivalent.
57
+ ALTERNATIVES_COMMAND = %r{
58
+ \A\s*(?:/usr/sbin/|/usr/bin/|/sbin/|/bin/)? # an optional absolute path to the binary
59
+ (?:update-)?alternatives\s+
60
+ --(?:install|set|auto|remove(?!-all))\b
61
+ }x.freeze
62
+
63
+ # the shell resources whose script lives in a code property
64
+ SCRIPT_RESOURCES = %i(bash sh csh ksh zsh).freeze
65
+
66
+ def on_send(node)
67
+ command = node.arguments.first
68
+ return unless command&.str_type? && manages_alternatives?(command.value)
69
+
70
+ add_offense(node, severity: :refactor)
71
+ end
72
+
73
+ def on_block(node)
74
+ match_property_in_resource?(:execute, 'command', node) do |property|
75
+ report_property(node, property)
76
+ end
77
+
78
+ match_property_in_resource?(SCRIPT_RESOURCES, 'code', node) do |property|
79
+ report_property(node, property)
80
+ end
81
+ end
82
+
83
+ private
84
+
85
+ def report_property(node, property)
86
+ command = method_arg_ast_to_string(property)
87
+ add_offense(node, severity: :refactor) if command && manages_alternatives?(command)
88
+ end
89
+
90
+ # @param [String] command
91
+ #
92
+ # @return [Boolean]
93
+ def manages_alternatives?(command)
94
+ ALTERNATIVES_COMMAND.match?(command)
95
+ end
96
+ end
97
+ end
98
+ end
99
+ end
100
+ end
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -29,6 +29,10 @@ module RuboCop
29
29
  # require 'chef/mixin/powershell_out'
30
30
  # include Chef::Mixin::PowershellOut
31
31
  #
32
+ # # good
33
+ # # shell_out is available in resources and providers with no include
34
+ # shell_out!('/opt/app/bin/app --version')
35
+ #
32
36
  class IncludingMixinShelloutInResources < Base
33
37
  extend AutoCorrector
34
38
  include RangeHelp
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -26,12 +26,12 @@ module RuboCop
26
26
  # # bad
27
27
  # depends 'libarchive'
28
28
  #
29
- # libarchive_file "C:\file.zip" do
29
+ # libarchive_file 'C:\file.zip' do
30
30
  # path 'C:\expand_here'
31
31
  # end
32
32
  #
33
33
  # # good
34
- # archive_file "C:\file.zip" do
34
+ # archive_file 'C:\file.zip' do
35
35
  # path 'C:\expand_here'
36
36
  # end
37
37
  #
@@ -44,8 +44,10 @@ module RuboCop
44
44
  MSG = 'Use the archive_file resource built into Chef Infra Client 15+ instead of the libarchive_file resource from the libarchive cookbook'
45
45
  RESTRICT_ON_SEND = [:libarchive_file, :notifies, :subscribes].freeze
46
46
 
47
+ # the notification timing is optional and defaults to :delayed, so the trailing
48
+ # argument is matched with ... rather than being required
47
49
  def_node_matcher :notification_property?, <<-PATTERN
48
- (send nil? {:notifies :subscribes} (sym _) $(...) (sym _))
50
+ (send nil? {:notifies :subscribes} (sym _) $(...) ...)
49
51
  PATTERN
50
52
 
51
53
  def on_send(node)
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.