cookstyle 8.7.6 → 9.0.9
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- checksums.yaml +4 -4
- data/config/chefstyle.yml +14 -0
- data/config/cookstyle.yml +157 -6
- data/lib/cookstyle/version.rb +2 -2
- data/lib/cookstyle.rb +5 -6
- data/lib/rubocop/chef/autocorrect_helpers.rb +1 -1
- data/lib/rubocop/chef/cookbook_helpers.rb +24 -1
- data/lib/rubocop/chef/platform_helpers.rb +1 -1
- data/lib/rubocop/chef.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/block_guard_clause_string_only.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/chef_application_fatal.rb +17 -5
- data/lib/rubocop/cop/chef/correctness/conditional_ruby_shellout.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/conditional_unified_mode_true.rb +91 -0
- data/lib/rubocop/cop/chef/correctness/dnf_package_allow_downgrades.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/empty_resource_guard.rb +18 -2
- data/lib/rubocop/cop/chef/correctness/execute_delete_file.rb +127 -0
- data/lib/rubocop/cop/chef/correctness/incorrect_library_injection.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/invalid_checksum.rb +79 -0
- data/lib/rubocop/cop/chef/correctness/invalid_cookbook_name.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/invalid_default_action.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/invalid_notification_resource.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/invalid_notification_timing.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/invalid_platform_family_helper.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/invalid_platform_family_values_in_case.rb +11 -1
- data/lib/rubocop/cop/chef/correctness/invalid_platform_helper.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/invalid_platform_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/invalid_platform_values_in_case.rb +11 -1
- data/lib/rubocop/cop/chef/correctness/invalid_value_for_platform_family_helper.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/invalid_value_for_platform_helper.rb +2 -1
- data/lib/rubocop/cop/chef/correctness/invalid_version_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/lazy_eval_node_attribute_defaults.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/lazy_in_resource_guard.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/macos_userdefaults_invalid_type.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/malformed_value_for_platform.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/metadata_malformed_version.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/metadata_missing_name.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/metadata_missing_version.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/node_save.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/notifies_action_not_symbol.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/octal_mode_as_string.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/openssl_password_helpers.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/platform_version_string_comparison.rb +66 -0
- data/lib/rubocop/cop/chef/correctness/powershell_delete_file.rb +6 -6
- data/lib/rubocop/cop/chef/correctness/powershell_file_exists.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/property_without_type.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/resource_with_none_action.rb +4 -4
- data/lib/rubocop/cop/chef/correctness/ruby_guard_without_block.rb +91 -0
- data/lib/rubocop/cop/chef/correctness/scoped_file_exist.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/service_resource.rb +71 -20
- data/lib/rubocop/cop/chef/correctness/supports_must_be_float.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/cb_depends_on_self.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chef_handler_recipe.rb +9 -2
- data/lib/rubocop/cop/chef/deprecation/chef_handler_supports.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chef_rest.rb +5 -2
- data/lib/rubocop/cop/chef/deprecation/chef_rewind.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chef_shellout.rb +3 -3
- data/lib/rubocop/cop/chef/deprecation/chef_sugar_helpers.rb +7 -1
- data/lib/rubocop/cop/chef/deprecation/chef_windows_platform_helper.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/chefdk_generators.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/cheffile.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chefspec_coverage_report.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chefspec_legacy_runner.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chocolatey_package_uninstall_action.rb +4 -4
- data/lib/rubocop/cop/chef/deprecation/delivery.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/depends_chef_nginx_cookbook.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/depends_chef_reporting_cookbook.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/depends_compat_resource.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/depends_omnibus_updater_cookbook.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/depends_partial_search.rb +5 -1
- data/lib/rubocop/cop/chef/deprecation/depends_poise.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/deprecated_chefspec_platform.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/deprecated_mixins.rb +3 -3
- data/lib/rubocop/cop/chef/deprecation/deprecated_platform_methods.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/deprecated_shellout_methods.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/deprecated_sudo_actions.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/deprecated_windows_version_check.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/deprecated_yum_repository_actions.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/deprecated_yum_repository_properties.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/easy_install.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/eol_audit_mode.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/epic_fail.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/erl_call.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/execute_path_property.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/execute_relative_creates_without_cwd.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/foodcritic_file.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/foodcritic_testing.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/hwrp_without_provides.rb +5 -5
- data/lib/rubocop/cop/chef/deprecation/hwrp_without_unified_mode_true.rb +3 -3
- data/lib/rubocop/cop/chef/deprecation/inherits_compat_resource.rb +4 -4
- data/lib/rubocop/cop/chef/deprecation/launchd_deprecated_hash_property.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/legacy_notify_syntax.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/legacy_yum_cookbook_recipes.rb +10 -2
- data/lib/rubocop/cop/chef/deprecation/librarian_chefspec.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/locale_lc_all_property.rb +6 -1
- data/lib/rubocop/cop/chef/deprecation/log_resource_notifications.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/macos_userdefaults_global_property.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/name_property_and_default.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/node_methods_not_attributes.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/partial_search_class_usage.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/partial_search_helper_usage.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/poise_archive.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/policyfile_community_source.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/powershell_cookbook_helpers.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/require_recipe.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/resource_overrides_provides_method.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/resource_uses_dsl_name_method.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/resource_uses_only_resource_name.rb +10 -2
- data/lib/rubocop/cop/chef/deprecation/resource_uses_provider_base_method.rb +5 -1
- data/lib/rubocop/cop/chef/deprecation/resource_uses_updated_method.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/resource_without_unified_mode_true.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/ruby_27_keyword_argument_warnings.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/ruby_block_create_action.rb +43 -4
- data/lib/rubocop/cop/chef/deprecation/run_command_helper.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/search_uses_positional_parameters.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/use_automatic_resource_name.rb +10 -1
- data/lib/rubocop/cop/chef/deprecation/use_inline_resources.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/use_yaml_dump.rb +6 -1
- data/lib/rubocop/cop/chef/deprecation/user_supports_property.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/verify_property_file_expansion.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/windows_feature_servermanagercmd.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/windows_package_installer_type_string.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/windows_task_change_action.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/windows_version_helpers.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/xml_ruby_recipe.rb +6 -2
- data/lib/rubocop/cop/chef/deprecation/yum_dnf_compat_recipe.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/berksfile.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/data_bags.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/node_environment.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/node_policygroup.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/node_roles.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/search_for_environments_or_roles.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/search_used.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/action_method_in_resource.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/allowed_actions_initializer.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/apt_default_recipe.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/berksfile_source.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/build_essential.rb +5 -2
- data/lib/rubocop/cop/chef/modernize/chef_14_resources.rb +9 -1
- data/lib/rubocop/cop/chef/modernize/chef_15_resources.rb +12 -1
- data/lib/rubocop/cop/chef/modernize/chef_gem_nokogiri.rb +5 -1
- data/lib/rubocop/cop/chef/modernize/class_eval_action_class.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/compile_time_resources.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/conditional_using_test.rb +11 -4
- data/lib/rubocop/cop/chef/modernize/cron_d_file_or_template.rb +7 -5
- data/lib/rubocop/cop/chef/modernize/cron_manage_resource.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/databag_helpers.rb +7 -4
- data/lib/rubocop/cop/chef/modernize/declare_action_class.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/default_action_initializer.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/defines_chefspec_matchers.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/definitions.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/depends_chef_vault_cookbook.rb +5 -1
- data/lib/rubocop/cop/chef/modernize/depends_chocolatey_cookbooks.rb +8 -1
- data/lib/rubocop/cop/chef/modernize/depends_kernel_module_cookbook.rb +7 -1
- data/lib/rubocop/cop/chef/modernize/depends_locale_cookbook.rb +7 -1
- data/lib/rubocop/cop/chef/modernize/depends_openssl_cookbook.rb +10 -1
- data/lib/rubocop/cop/chef/modernize/depends_timezone_lwrp_cookbook.rb +5 -1
- data/lib/rubocop/cop/chef/modernize/depends_windows_firewall_cookbook.rb +9 -1
- data/lib/rubocop/cop/chef/modernize/depends_zypper_cookbook.rb +8 -1
- data/lib/rubocop/cop/chef/modernize/dsl_include_in_resource.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/empty_resource_initialize.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/execute_apt_update.rb +4 -2
- data/lib/rubocop/cop/chef/modernize/execute_archive_extract.rb +121 -0
- data/lib/rubocop/cop/chef/modernize/execute_sc_exe.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/execute_sleep.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/execute_sysctl.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/execute_tzutil.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/execute_update_alternatives.rb +100 -0
- data/lib/rubocop/cop/chef/modernize/foodcritic_comments.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/if_provides_default_action.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/includes_mixin_shellout.rb +5 -1
- data/lib/rubocop/cop/chef/modernize/libarchive_file.rb +6 -4
- data/lib/rubocop/cop/chef/modernize/macos_user_defaults.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/minitest_handler_usage.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/node_init_package.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/node_roles_include.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/ohai_default_recipe.rb +7 -2
- data/lib/rubocop/cop/chef/modernize/openssl_rsa_key_resource.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/openssl_x509_resource.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/osx_config_profile_resource.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/powershell_download_file.rb +64 -0
- data/lib/rubocop/cop/chef/modernize/powershell_expand_archive.rb +9 -2
- data/lib/rubocop/cop/chef/modernize/powershell_guard_interpreter.rb +5 -5
- data/lib/rubocop/cop/chef/modernize/powershell_install_package.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/powershell_install_windowsfeature.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/property_with_name_attribute.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/provides_initializer.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/resource_name_initializer.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/resource_set_or_return.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/resource_with_attributes.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/respond_to_compile_time.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/respond_to_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/respond_to_provides.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/respond_to_resource_name.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/sc_windows_resource.rb +3 -3
- data/lib/rubocop/cop/chef/modernize/seven_zip_archive.rb +8 -2
- data/lib/rubocop/cop/chef/modernize/shell_out_helper.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/shellouts_to_chocolatey.rb +16 -5
- data/lib/rubocop/cop/chef/modernize/simplify_apt_ppa_setup.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/sysctl_param_resource.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/unnecessary_mixlib_shellout_require.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/use_chef_language_cloud_helpers.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/use_chef_language_env_helpers.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/use_chef_language_systemd_helper.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/use_multipackage_installs.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/use_require_relative.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/whyrun_supported_true.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/windows_default_recipe.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/windows_registry_uac.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/windows_zipfile.rb +9 -3
- data/lib/rubocop/cop/chef/modernize/zipfile_resource.rb +8 -2
- data/lib/rubocop/cop/chef/modernize/zypper_repo.rb +3 -3
- data/lib/rubocop/cop/chef/redundant/apt_repository_distribution_default.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/apt_repository_notifies_apt_update.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/attribute_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/conflicts_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/custom_resource_with_allowed_actions.rb +11 -1
- data/lib/rubocop/cop/chef/redundant/double_compile_time.rb +23 -9
- data/lib/rubocop/cop/chef/redundant/grouping_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/long_description_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/multiple_platform_checks.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/name_property_and_required.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/ohai_attribute_to_string.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/property_splat_regex.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/property_with_default_and_required.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/provides_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/recipe_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/replaces_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/resource_with_nothing_action.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/sensitive_property_in_resource.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/service_guard_on_stop_disable.rb +117 -0
- data/lib/rubocop/cop/chef/redundant/string_property_with_nil_default.rb +3 -3
- data/lib/rubocop/cop/chef/redundant/suggests_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/unnecessary_desired_state.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/unnecessary_name_property.rb +2 -2
- data/lib/rubocop/cop/chef/redundant/use_create_if_missing.rb +1 -1
- data/lib/rubocop/cop/chef/security/insecure_remote_file_source.rb +82 -0
- data/lib/rubocop/cop/chef/security/ssh_private_key.rb +10 -1
- data/lib/rubocop/cop/chef/sharing/default_maintainer_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/sharing/empty_metadata_field.rb +1 -1
- data/lib/rubocop/cop/chef/sharing/empty_property_description.rb +62 -0
- data/lib/rubocop/cop/chef/sharing/include_property_descriptions.rb +1 -1
- data/lib/rubocop/cop/chef/sharing/include_resource_descriptions.rb +1 -1
- data/lib/rubocop/cop/chef/sharing/include_resource_examples.rb +1 -1
- data/lib/rubocop/cop/chef/sharing/insecure_cookbook_url.rb +1 -1
- data/lib/rubocop/cop/chef/sharing/invalid_license_string.rb +1 -1
- data/lib/rubocop/cop/chef/style/chef_whaaat.rb +1 -1
- data/lib/rubocop/cop/chef/style/comment_sentence_spacing.rb +1 -1
- data/lib/rubocop/cop/chef/style/comments_copyright_format.rb +1 -1
- data/lib/rubocop/cop/chef/style/comments_default_copyright.rb +1 -1
- data/lib/rubocop/cop/chef/style/comments_format.rb +1 -1
- data/lib/rubocop/cop/chef/style/immediate_notification_timing.rb +1 -1
- data/lib/rubocop/cop/chef/style/include_recipe_with_parentheses.rb +6 -3
- data/lib/rubocop/cop/chef/style/negating_only_if.rb +1 -1
- data/lib/rubocop/cop/chef/style/overly_complex_supports_depends_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/style/simplify_platform_major_version_check.rb +1 -1
- data/lib/rubocop/cop/chef/style/true_false_resource_properties.rb +2 -2
- data/lib/rubocop/cop/chef/style/unnecessary_os_check.rb +1 -1
- data/lib/rubocop/cop/chef/style/unnecessary_platform_case_statement.rb +1 -1
- data/lib/rubocop/cop/chef/style/use_platform_helpers.rb +1 -1
- data/lib/rubocop/cop/chef.rb +349 -0
- data/lib/rubocop/cop/chefstyle/ruby/gemspec_license.rb +1 -1
- data/lib/rubocop/cop/chefstyle/ruby/gemspec_require_rubygems.rb +1 -1
- data/lib/rubocop/cop/chefstyle/ruby/legacy_powershell_out_methods.rb +1 -1
- data/lib/rubocop/cop/chefstyle/ruby/require_net_https.rb +1 -1
- data/lib/rubocop/cop/chefstyle/ruby/unless_defined_require.rb +1 -1
- data/lib/rubocop/cop/inspec/deprecation/attribute_default.rb +1 -1
- data/lib/rubocop/cop/inspec/deprecation/attribute_helper.rb +1 -1
- data/lib/rubocop/cop/inspec.rb +31 -0
- data/lib/rubocop/monkey_patches/directive_comment.rb +21 -3
- metadata +21 -8
|
@@ -0,0 +1,31 @@
|
|
|
1
|
+
# frozen_string_literal: true
|
|
2
|
+
#
|
|
3
|
+
# Copyright:: 2026, Tim Smith
|
|
4
|
+
# Author:: Tim Smith (<tsmith84@proton.me>)
|
|
5
|
+
#
|
|
6
|
+
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
7
|
+
# you may not use this file except in compliance with the License.
|
|
8
|
+
# You may obtain a copy of the License at
|
|
9
|
+
#
|
|
10
|
+
# http://www.apache.org/licenses/LICENSE-2.0
|
|
11
|
+
#
|
|
12
|
+
# Unless required by applicable law or agreed to in writing, software
|
|
13
|
+
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
14
|
+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
15
|
+
# See the License for the specific language governing permissions and
|
|
16
|
+
# limitations under the License.
|
|
17
|
+
#
|
|
18
|
+
module RuboCop
|
|
19
|
+
module Cop
|
|
20
|
+
# Registers the InSpec cops for lazy loading. See `rubocop/cop/chef` for details.
|
|
21
|
+
module InSpec
|
|
22
|
+
# The InSpec/Deprecations department.
|
|
23
|
+
module Deprecations
|
|
24
|
+
extend LazyLoader
|
|
25
|
+
|
|
26
|
+
register_cop :AttributeDefault, "#{__dir__}/inspec/deprecation/attribute_default"
|
|
27
|
+
register_cop :AttributeHelper, "#{__dir__}/inspec/deprecation/attribute_helper"
|
|
28
|
+
end
|
|
29
|
+
end
|
|
30
|
+
end
|
|
31
|
+
end
|
|
@@ -1,12 +1,30 @@
|
|
|
1
1
|
# frozen_string_literal: true
|
|
2
2
|
module RuboCop
|
|
3
|
-
# we're monkey patching the
|
|
4
|
-
# in addition to the "rubocop: disable whatever that comes with RuboCop
|
|
3
|
+
# we're monkey patching the directive marker to allow for "cookstyle: disable whatever"
|
|
4
|
+
# in addition to the "rubocop: disable whatever" that comes with RuboCop.
|
|
5
|
+
#
|
|
6
|
+
# Everything below the marker is rebuilt exactly the way RuboCop builds it, from
|
|
7
|
+
# RuboCop's own constants, so that directive modes added upstream (push, pop,
|
|
8
|
+
# disable-next, todo-next, ...) keep working here without another patch.
|
|
5
9
|
class DirectiveComment
|
|
10
|
+
remove_const(:DIRECTIVE_MARKER_PATTERN)
|
|
11
|
+
DIRECTIVE_MARKER_PATTERN = '# (?:rubocop|cookstyle) : '
|
|
12
|
+
|
|
13
|
+
remove_const(:DIRECTIVE_MARKER_REGEXP)
|
|
14
|
+
DIRECTIVE_MARKER_REGEXP = Regexp.new(DIRECTIVE_MARKER_PATTERN.gsub(' ', '\s*'))
|
|
15
|
+
|
|
16
|
+
remove_const(:DIRECTIVE_HEADER_PATTERN)
|
|
17
|
+
DIRECTIVE_HEADER_PATTERN = "#{DIRECTIVE_MARKER_PATTERN}((?:#{MODES_PATTERN}))\\b"
|
|
18
|
+
|
|
6
19
|
remove_const(:DIRECTIVE_COMMENT_REGEXP)
|
|
7
20
|
DIRECTIVE_COMMENT_REGEXP = Regexp.new(
|
|
8
|
-
"#
|
|
21
|
+
"#{DIRECTIVE_HEADER_PATTERN}(?:\\s+#{COPS_PATTERN}|\\s+#{PUSH_POP_ARGS_PATTERN})?"
|
|
9
22
|
.gsub(' ', '\s*')
|
|
10
23
|
)
|
|
24
|
+
|
|
25
|
+
remove_const(:MALFORMED_DIRECTIVE_WITHOUT_COP_NAME_REGEXP)
|
|
26
|
+
MALFORMED_DIRECTIVE_WITHOUT_COP_NAME_REGEXP = Regexp.new(
|
|
27
|
+
"\\A#{DIRECTIVE_HEADER_PATTERN}\\s*\\z".gsub(' ', '\s*')
|
|
28
|
+
)
|
|
11
29
|
end
|
|
12
30
|
end
|
metadata
CHANGED
|
@@ -1,15 +1,15 @@
|
|
|
1
1
|
--- !ruby/object:Gem::Specification
|
|
2
2
|
name: cookstyle
|
|
3
3
|
version: !ruby/object:Gem::Version
|
|
4
|
-
version:
|
|
4
|
+
version: 9.0.9
|
|
5
5
|
platform: ruby
|
|
6
6
|
authors:
|
|
7
7
|
- Thom May
|
|
8
8
|
- Tim Smith
|
|
9
|
-
autorequire:
|
|
9
|
+
autorequire:
|
|
10
10
|
bindir: bin
|
|
11
11
|
cert_chain: []
|
|
12
|
-
date: 2026-
|
|
12
|
+
date: 2026-11-16 00:00:00.000000000 Z
|
|
13
13
|
dependencies:
|
|
14
14
|
- !ruby/object:Gem::Dependency
|
|
15
15
|
name: rubocop
|
|
@@ -17,15 +17,15 @@ dependencies:
|
|
|
17
17
|
requirements:
|
|
18
18
|
- - '='
|
|
19
19
|
- !ruby/object:Gem::Version
|
|
20
|
-
version: 1.
|
|
20
|
+
version: 1.91.0
|
|
21
21
|
type: :runtime
|
|
22
22
|
prerelease: false
|
|
23
23
|
version_requirements: !ruby/object:Gem::Requirement
|
|
24
24
|
requirements:
|
|
25
25
|
- - '='
|
|
26
26
|
- !ruby/object:Gem::Version
|
|
27
|
-
version: 1.
|
|
28
|
-
description:
|
|
27
|
+
version: 1.91.0
|
|
28
|
+
description:
|
|
29
29
|
email:
|
|
30
30
|
- thom@chef.io
|
|
31
31
|
- tsmith84@proton.me
|
|
@@ -50,12 +50,16 @@ files:
|
|
|
50
50
|
- lib/rubocop/chef/cookbook_helpers.rb
|
|
51
51
|
- lib/rubocop/chef/cookbook_only.rb
|
|
52
52
|
- lib/rubocop/chef/platform_helpers.rb
|
|
53
|
+
- lib/rubocop/cop/chef.rb
|
|
53
54
|
- lib/rubocop/cop/chef/correctness/block_guard_clause_string_only.rb
|
|
54
55
|
- lib/rubocop/cop/chef/correctness/chef_application_fatal.rb
|
|
55
56
|
- lib/rubocop/cop/chef/correctness/conditional_ruby_shellout.rb
|
|
57
|
+
- lib/rubocop/cop/chef/correctness/conditional_unified_mode_true.rb
|
|
56
58
|
- lib/rubocop/cop/chef/correctness/dnf_package_allow_downgrades.rb
|
|
57
59
|
- lib/rubocop/cop/chef/correctness/empty_resource_guard.rb
|
|
60
|
+
- lib/rubocop/cop/chef/correctness/execute_delete_file.rb
|
|
58
61
|
- lib/rubocop/cop/chef/correctness/incorrect_library_injection.rb
|
|
62
|
+
- lib/rubocop/cop/chef/correctness/invalid_checksum.rb
|
|
59
63
|
- lib/rubocop/cop/chef/correctness/invalid_cookbook_name.rb
|
|
60
64
|
- lib/rubocop/cop/chef/correctness/invalid_default_action.rb
|
|
61
65
|
- lib/rubocop/cop/chef/correctness/invalid_notification_resource.rb
|
|
@@ -81,12 +85,14 @@ files:
|
|
|
81
85
|
- lib/rubocop/cop/chef/correctness/notifies_action_not_symbol.rb
|
|
82
86
|
- lib/rubocop/cop/chef/correctness/octal_mode_as_string.rb
|
|
83
87
|
- lib/rubocop/cop/chef/correctness/openssl_password_helpers.rb
|
|
88
|
+
- lib/rubocop/cop/chef/correctness/platform_version_string_comparison.rb
|
|
84
89
|
- lib/rubocop/cop/chef/correctness/powershell_delete_file.rb
|
|
85
90
|
- lib/rubocop/cop/chef/correctness/powershell_file_exists.rb
|
|
86
91
|
- lib/rubocop/cop/chef/correctness/property_without_type.rb
|
|
87
92
|
- lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb
|
|
88
93
|
- lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb
|
|
89
94
|
- lib/rubocop/cop/chef/correctness/resource_with_none_action.rb
|
|
95
|
+
- lib/rubocop/cop/chef/correctness/ruby_guard_without_block.rb
|
|
90
96
|
- lib/rubocop/cop/chef/correctness/scoped_file_exist.rb
|
|
91
97
|
- lib/rubocop/cop/chef/correctness/service_resource.rb
|
|
92
98
|
- lib/rubocop/cop/chef/correctness/supports_must_be_float.rb
|
|
@@ -208,10 +214,12 @@ files:
|
|
|
208
214
|
- lib/rubocop/cop/chef/modernize/dsl_include_in_resource.rb
|
|
209
215
|
- lib/rubocop/cop/chef/modernize/empty_resource_initialize.rb
|
|
210
216
|
- lib/rubocop/cop/chef/modernize/execute_apt_update.rb
|
|
217
|
+
- lib/rubocop/cop/chef/modernize/execute_archive_extract.rb
|
|
211
218
|
- lib/rubocop/cop/chef/modernize/execute_sc_exe.rb
|
|
212
219
|
- lib/rubocop/cop/chef/modernize/execute_sleep.rb
|
|
213
220
|
- lib/rubocop/cop/chef/modernize/execute_sysctl.rb
|
|
214
221
|
- lib/rubocop/cop/chef/modernize/execute_tzutil.rb
|
|
222
|
+
- lib/rubocop/cop/chef/modernize/execute_update_alternatives.rb
|
|
215
223
|
- lib/rubocop/cop/chef/modernize/foodcritic_comments.rb
|
|
216
224
|
- lib/rubocop/cop/chef/modernize/if_provides_default_action.rb
|
|
217
225
|
- lib/rubocop/cop/chef/modernize/includes_mixin_shellout.rb
|
|
@@ -224,6 +232,7 @@ files:
|
|
|
224
232
|
- lib/rubocop/cop/chef/modernize/openssl_rsa_key_resource.rb
|
|
225
233
|
- lib/rubocop/cop/chef/modernize/openssl_x509_resource.rb
|
|
226
234
|
- lib/rubocop/cop/chef/modernize/osx_config_profile_resource.rb
|
|
235
|
+
- lib/rubocop/cop/chef/modernize/powershell_download_file.rb
|
|
227
236
|
- lib/rubocop/cop/chef/modernize/powershell_expand_archive.rb
|
|
228
237
|
- lib/rubocop/cop/chef/modernize/powershell_guard_interpreter.rb
|
|
229
238
|
- lib/rubocop/cop/chef/modernize/powershell_install_package.rb
|
|
@@ -273,14 +282,17 @@ files:
|
|
|
273
282
|
- lib/rubocop/cop/chef/redundant/replaces_metadata.rb
|
|
274
283
|
- lib/rubocop/cop/chef/redundant/resource_with_nothing_action.rb
|
|
275
284
|
- lib/rubocop/cop/chef/redundant/sensitive_property_in_resource.rb
|
|
285
|
+
- lib/rubocop/cop/chef/redundant/service_guard_on_stop_disable.rb
|
|
276
286
|
- lib/rubocop/cop/chef/redundant/string_property_with_nil_default.rb
|
|
277
287
|
- lib/rubocop/cop/chef/redundant/suggests_metadata.rb
|
|
278
288
|
- lib/rubocop/cop/chef/redundant/unnecessary_desired_state.rb
|
|
279
289
|
- lib/rubocop/cop/chef/redundant/unnecessary_name_property.rb
|
|
280
290
|
- lib/rubocop/cop/chef/redundant/use_create_if_missing.rb
|
|
291
|
+
- lib/rubocop/cop/chef/security/insecure_remote_file_source.rb
|
|
281
292
|
- lib/rubocop/cop/chef/security/ssh_private_key.rb
|
|
282
293
|
- lib/rubocop/cop/chef/sharing/default_maintainer_metadata.rb
|
|
283
294
|
- lib/rubocop/cop/chef/sharing/empty_metadata_field.rb
|
|
295
|
+
- lib/rubocop/cop/chef/sharing/empty_property_description.rb
|
|
284
296
|
- lib/rubocop/cop/chef/sharing/include_property_descriptions.rb
|
|
285
297
|
- lib/rubocop/cop/chef/sharing/include_resource_descriptions.rb
|
|
286
298
|
- lib/rubocop/cop/chef/sharing/include_resource_examples.rb
|
|
@@ -307,6 +319,7 @@ files:
|
|
|
307
319
|
- lib/rubocop/cop/chefstyle/ruby/legacy_powershell_out_methods.rb
|
|
308
320
|
- lib/rubocop/cop/chefstyle/ruby/require_net_https.rb
|
|
309
321
|
- lib/rubocop/cop/chefstyle/ruby/unless_defined_require.rb
|
|
322
|
+
- lib/rubocop/cop/inspec.rb
|
|
310
323
|
- lib/rubocop/cop/inspec/deprecation/attribute_default.rb
|
|
311
324
|
- lib/rubocop/cop/inspec/deprecation/attribute_helper.rb
|
|
312
325
|
- lib/rubocop/cop/target_chef_version.rb
|
|
@@ -326,7 +339,7 @@ metadata:
|
|
|
326
339
|
source_code_uri: https://github.com/chef/cookstyle
|
|
327
340
|
documentation_uri: https://docs.chef.io/workstation/cookstyle/
|
|
328
341
|
bug_tracker_uri: https://github.com/chef/cookstyle/issues
|
|
329
|
-
post_install_message:
|
|
342
|
+
post_install_message:
|
|
330
343
|
rdoc_options: []
|
|
331
344
|
require_paths:
|
|
332
345
|
- lib
|
|
@@ -342,7 +355,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
|
|
|
342
355
|
version: '0'
|
|
343
356
|
requirements: []
|
|
344
357
|
rubygems_version: 3.3.27
|
|
345
|
-
signing_key:
|
|
358
|
+
signing_key:
|
|
346
359
|
specification_version: 4
|
|
347
360
|
summary: Cookstyle is a code linting tool that helps you to write better Chef Infra
|
|
348
361
|
cookbooks by detecting and automatically correcting style, syntax, and logic mistakes
|