cookstyle 8.7.6 → 9.0.9

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (272) hide show
  1. checksums.yaml +4 -4
  2. data/config/chefstyle.yml +14 -0
  3. data/config/cookstyle.yml +157 -6
  4. data/lib/cookstyle/version.rb +2 -2
  5. data/lib/cookstyle.rb +5 -6
  6. data/lib/rubocop/chef/autocorrect_helpers.rb +1 -1
  7. data/lib/rubocop/chef/cookbook_helpers.rb +24 -1
  8. data/lib/rubocop/chef/platform_helpers.rb +1 -1
  9. data/lib/rubocop/chef.rb +1 -1
  10. data/lib/rubocop/cop/chef/correctness/block_guard_clause_string_only.rb +1 -1
  11. data/lib/rubocop/cop/chef/correctness/chef_application_fatal.rb +17 -5
  12. data/lib/rubocop/cop/chef/correctness/conditional_ruby_shellout.rb +1 -1
  13. data/lib/rubocop/cop/chef/correctness/conditional_unified_mode_true.rb +91 -0
  14. data/lib/rubocop/cop/chef/correctness/dnf_package_allow_downgrades.rb +1 -1
  15. data/lib/rubocop/cop/chef/correctness/empty_resource_guard.rb +18 -2
  16. data/lib/rubocop/cop/chef/correctness/execute_delete_file.rb +127 -0
  17. data/lib/rubocop/cop/chef/correctness/incorrect_library_injection.rb +1 -1
  18. data/lib/rubocop/cop/chef/correctness/invalid_checksum.rb +79 -0
  19. data/lib/rubocop/cop/chef/correctness/invalid_cookbook_name.rb +1 -1
  20. data/lib/rubocop/cop/chef/correctness/invalid_default_action.rb +1 -1
  21. data/lib/rubocop/cop/chef/correctness/invalid_notification_resource.rb +1 -1
  22. data/lib/rubocop/cop/chef/correctness/invalid_notification_timing.rb +1 -1
  23. data/lib/rubocop/cop/chef/correctness/invalid_platform_family_helper.rb +2 -2
  24. data/lib/rubocop/cop/chef/correctness/invalid_platform_family_values_in_case.rb +11 -1
  25. data/lib/rubocop/cop/chef/correctness/invalid_platform_helper.rb +1 -1
  26. data/lib/rubocop/cop/chef/correctness/invalid_platform_metadata.rb +1 -1
  27. data/lib/rubocop/cop/chef/correctness/invalid_platform_values_in_case.rb +11 -1
  28. data/lib/rubocop/cop/chef/correctness/invalid_value_for_platform_family_helper.rb +1 -1
  29. data/lib/rubocop/cop/chef/correctness/invalid_value_for_platform_helper.rb +2 -1
  30. data/lib/rubocop/cop/chef/correctness/invalid_version_metadata.rb +1 -1
  31. data/lib/rubocop/cop/chef/correctness/lazy_eval_node_attribute_defaults.rb +1 -1
  32. data/lib/rubocop/cop/chef/correctness/lazy_in_resource_guard.rb +1 -1
  33. data/lib/rubocop/cop/chef/correctness/macos_userdefaults_invalid_type.rb +1 -1
  34. data/lib/rubocop/cop/chef/correctness/malformed_value_for_platform.rb +1 -1
  35. data/lib/rubocop/cop/chef/correctness/metadata_malformed_version.rb +1 -1
  36. data/lib/rubocop/cop/chef/correctness/metadata_missing_name.rb +1 -1
  37. data/lib/rubocop/cop/chef/correctness/metadata_missing_version.rb +1 -1
  38. data/lib/rubocop/cop/chef/correctness/node_save.rb +1 -1
  39. data/lib/rubocop/cop/chef/correctness/notifies_action_not_symbol.rb +1 -1
  40. data/lib/rubocop/cop/chef/correctness/octal_mode_as_string.rb +1 -1
  41. data/lib/rubocop/cop/chef/correctness/openssl_password_helpers.rb +1 -1
  42. data/lib/rubocop/cop/chef/correctness/platform_version_string_comparison.rb +66 -0
  43. data/lib/rubocop/cop/chef/correctness/powershell_delete_file.rb +6 -6
  44. data/lib/rubocop/cop/chef/correctness/powershell_file_exists.rb +2 -2
  45. data/lib/rubocop/cop/chef/correctness/property_without_type.rb +1 -1
  46. data/lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb +1 -1
  47. data/lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb +1 -1
  48. data/lib/rubocop/cop/chef/correctness/resource_with_none_action.rb +4 -4
  49. data/lib/rubocop/cop/chef/correctness/ruby_guard_without_block.rb +91 -0
  50. data/lib/rubocop/cop/chef/correctness/scoped_file_exist.rb +1 -1
  51. data/lib/rubocop/cop/chef/correctness/service_resource.rb +71 -20
  52. data/lib/rubocop/cop/chef/correctness/supports_must_be_float.rb +1 -1
  53. data/lib/rubocop/cop/chef/deprecation/cb_depends_on_self.rb +1 -1
  54. data/lib/rubocop/cop/chef/deprecation/chef_handler_recipe.rb +9 -2
  55. data/lib/rubocop/cop/chef/deprecation/chef_handler_supports.rb +1 -1
  56. data/lib/rubocop/cop/chef/deprecation/chef_rest.rb +5 -2
  57. data/lib/rubocop/cop/chef/deprecation/chef_rewind.rb +1 -1
  58. data/lib/rubocop/cop/chef/deprecation/chef_shellout.rb +3 -3
  59. data/lib/rubocop/cop/chef/deprecation/chef_sugar_helpers.rb +7 -1
  60. data/lib/rubocop/cop/chef/deprecation/chef_windows_platform_helper.rb +2 -2
  61. data/lib/rubocop/cop/chef/deprecation/chefdk_generators.rb +1 -1
  62. data/lib/rubocop/cop/chef/deprecation/cheffile.rb +1 -1
  63. data/lib/rubocop/cop/chef/deprecation/chefspec_coverage_report.rb +1 -1
  64. data/lib/rubocop/cop/chef/deprecation/chefspec_legacy_runner.rb +1 -1
  65. data/lib/rubocop/cop/chef/deprecation/chocolatey_package_uninstall_action.rb +4 -4
  66. data/lib/rubocop/cop/chef/deprecation/delivery.rb +1 -1
  67. data/lib/rubocop/cop/chef/deprecation/depends_chef_nginx_cookbook.rb +1 -1
  68. data/lib/rubocop/cop/chef/deprecation/depends_chef_reporting_cookbook.rb +1 -1
  69. data/lib/rubocop/cop/chef/deprecation/depends_compat_resource.rb +1 -1
  70. data/lib/rubocop/cop/chef/deprecation/depends_omnibus_updater_cookbook.rb +1 -1
  71. data/lib/rubocop/cop/chef/deprecation/depends_partial_search.rb +5 -1
  72. data/lib/rubocop/cop/chef/deprecation/depends_poise.rb +1 -1
  73. data/lib/rubocop/cop/chef/deprecation/deprecated_chefspec_platform.rb +1 -1
  74. data/lib/rubocop/cop/chef/deprecation/deprecated_mixins.rb +3 -3
  75. data/lib/rubocop/cop/chef/deprecation/deprecated_platform_methods.rb +1 -1
  76. data/lib/rubocop/cop/chef/deprecation/deprecated_shellout_methods.rb +1 -1
  77. data/lib/rubocop/cop/chef/deprecation/deprecated_sudo_actions.rb +1 -1
  78. data/lib/rubocop/cop/chef/deprecation/deprecated_windows_version_check.rb +1 -1
  79. data/lib/rubocop/cop/chef/deprecation/deprecated_yum_repository_actions.rb +1 -1
  80. data/lib/rubocop/cop/chef/deprecation/deprecated_yum_repository_properties.rb +1 -1
  81. data/lib/rubocop/cop/chef/deprecation/easy_install.rb +1 -1
  82. data/lib/rubocop/cop/chef/deprecation/eol_audit_mode.rb +1 -1
  83. data/lib/rubocop/cop/chef/deprecation/epic_fail.rb +1 -1
  84. data/lib/rubocop/cop/chef/deprecation/erl_call.rb +1 -1
  85. data/lib/rubocop/cop/chef/deprecation/execute_path_property.rb +1 -1
  86. data/lib/rubocop/cop/chef/deprecation/execute_relative_creates_without_cwd.rb +1 -1
  87. data/lib/rubocop/cop/chef/deprecation/foodcritic_file.rb +1 -1
  88. data/lib/rubocop/cop/chef/deprecation/foodcritic_testing.rb +1 -1
  89. data/lib/rubocop/cop/chef/deprecation/hwrp_without_provides.rb +5 -5
  90. data/lib/rubocop/cop/chef/deprecation/hwrp_without_unified_mode_true.rb +3 -3
  91. data/lib/rubocop/cop/chef/deprecation/inherits_compat_resource.rb +4 -4
  92. data/lib/rubocop/cop/chef/deprecation/launchd_deprecated_hash_property.rb +1 -1
  93. data/lib/rubocop/cop/chef/deprecation/legacy_notify_syntax.rb +1 -1
  94. data/lib/rubocop/cop/chef/deprecation/legacy_yum_cookbook_recipes.rb +10 -2
  95. data/lib/rubocop/cop/chef/deprecation/librarian_chefspec.rb +1 -1
  96. data/lib/rubocop/cop/chef/deprecation/locale_lc_all_property.rb +6 -1
  97. data/lib/rubocop/cop/chef/deprecation/log_resource_notifications.rb +1 -1
  98. data/lib/rubocop/cop/chef/deprecation/macos_userdefaults_global_property.rb +1 -1
  99. data/lib/rubocop/cop/chef/deprecation/name_property_and_default.rb +1 -1
  100. data/lib/rubocop/cop/chef/deprecation/node_methods_not_attributes.rb +1 -1
  101. data/lib/rubocop/cop/chef/deprecation/partial_search_class_usage.rb +1 -1
  102. data/lib/rubocop/cop/chef/deprecation/partial_search_helper_usage.rb +1 -1
  103. data/lib/rubocop/cop/chef/deprecation/poise_archive.rb +1 -1
  104. data/lib/rubocop/cop/chef/deprecation/policyfile_community_source.rb +1 -1
  105. data/lib/rubocop/cop/chef/deprecation/powershell_cookbook_helpers.rb +1 -1
  106. data/lib/rubocop/cop/chef/deprecation/require_recipe.rb +1 -1
  107. data/lib/rubocop/cop/chef/deprecation/resource_overrides_provides_method.rb +1 -1
  108. data/lib/rubocop/cop/chef/deprecation/resource_uses_dsl_name_method.rb +1 -1
  109. data/lib/rubocop/cop/chef/deprecation/resource_uses_only_resource_name.rb +10 -2
  110. data/lib/rubocop/cop/chef/deprecation/resource_uses_provider_base_method.rb +5 -1
  111. data/lib/rubocop/cop/chef/deprecation/resource_uses_updated_method.rb +1 -1
  112. data/lib/rubocop/cop/chef/deprecation/resource_without_unified_mode_true.rb +1 -1
  113. data/lib/rubocop/cop/chef/deprecation/ruby_27_keyword_argument_warnings.rb +1 -1
  114. data/lib/rubocop/cop/chef/deprecation/ruby_block_create_action.rb +43 -4
  115. data/lib/rubocop/cop/chef/deprecation/run_command_helper.rb +1 -1
  116. data/lib/rubocop/cop/chef/deprecation/search_uses_positional_parameters.rb +1 -1
  117. data/lib/rubocop/cop/chef/deprecation/use_automatic_resource_name.rb +10 -1
  118. data/lib/rubocop/cop/chef/deprecation/use_inline_resources.rb +1 -1
  119. data/lib/rubocop/cop/chef/deprecation/use_yaml_dump.rb +6 -1
  120. data/lib/rubocop/cop/chef/deprecation/user_supports_property.rb +1 -1
  121. data/lib/rubocop/cop/chef/deprecation/verify_property_file_expansion.rb +1 -1
  122. data/lib/rubocop/cop/chef/deprecation/windows_feature_servermanagercmd.rb +1 -1
  123. data/lib/rubocop/cop/chef/deprecation/windows_package_installer_type_string.rb +1 -1
  124. data/lib/rubocop/cop/chef/deprecation/windows_task_change_action.rb +1 -1
  125. data/lib/rubocop/cop/chef/deprecation/windows_version_helpers.rb +1 -1
  126. data/lib/rubocop/cop/chef/deprecation/xml_ruby_recipe.rb +6 -2
  127. data/lib/rubocop/cop/chef/deprecation/yum_dnf_compat_recipe.rb +1 -1
  128. data/lib/rubocop/cop/chef/effortless/berksfile.rb +1 -1
  129. data/lib/rubocop/cop/chef/effortless/data_bags.rb +1 -1
  130. data/lib/rubocop/cop/chef/effortless/node_environment.rb +1 -1
  131. data/lib/rubocop/cop/chef/effortless/node_policygroup.rb +1 -1
  132. data/lib/rubocop/cop/chef/effortless/node_roles.rb +1 -1
  133. data/lib/rubocop/cop/chef/effortless/search_for_environments_or_roles.rb +1 -1
  134. data/lib/rubocop/cop/chef/effortless/search_used.rb +1 -1
  135. data/lib/rubocop/cop/chef/modernize/action_method_in_resource.rb +1 -1
  136. data/lib/rubocop/cop/chef/modernize/allowed_actions_initializer.rb +1 -1
  137. data/lib/rubocop/cop/chef/modernize/apt_default_recipe.rb +2 -2
  138. data/lib/rubocop/cop/chef/modernize/berksfile_source.rb +1 -1
  139. data/lib/rubocop/cop/chef/modernize/build_essential.rb +5 -2
  140. data/lib/rubocop/cop/chef/modernize/chef_14_resources.rb +9 -1
  141. data/lib/rubocop/cop/chef/modernize/chef_15_resources.rb +12 -1
  142. data/lib/rubocop/cop/chef/modernize/chef_gem_nokogiri.rb +5 -1
  143. data/lib/rubocop/cop/chef/modernize/class_eval_action_class.rb +1 -1
  144. data/lib/rubocop/cop/chef/modernize/compile_time_resources.rb +1 -1
  145. data/lib/rubocop/cop/chef/modernize/conditional_using_test.rb +11 -4
  146. data/lib/rubocop/cop/chef/modernize/cron_d_file_or_template.rb +7 -5
  147. data/lib/rubocop/cop/chef/modernize/cron_manage_resource.rb +1 -1
  148. data/lib/rubocop/cop/chef/modernize/databag_helpers.rb +7 -4
  149. data/lib/rubocop/cop/chef/modernize/declare_action_class.rb +1 -1
  150. data/lib/rubocop/cop/chef/modernize/default_action_initializer.rb +1 -1
  151. data/lib/rubocop/cop/chef/modernize/defines_chefspec_matchers.rb +1 -1
  152. data/lib/rubocop/cop/chef/modernize/definitions.rb +1 -1
  153. data/lib/rubocop/cop/chef/modernize/depends_chef_vault_cookbook.rb +5 -1
  154. data/lib/rubocop/cop/chef/modernize/depends_chocolatey_cookbooks.rb +8 -1
  155. data/lib/rubocop/cop/chef/modernize/depends_kernel_module_cookbook.rb +7 -1
  156. data/lib/rubocop/cop/chef/modernize/depends_locale_cookbook.rb +7 -1
  157. data/lib/rubocop/cop/chef/modernize/depends_openssl_cookbook.rb +10 -1
  158. data/lib/rubocop/cop/chef/modernize/depends_timezone_lwrp_cookbook.rb +5 -1
  159. data/lib/rubocop/cop/chef/modernize/depends_windows_firewall_cookbook.rb +9 -1
  160. data/lib/rubocop/cop/chef/modernize/depends_zypper_cookbook.rb +8 -1
  161. data/lib/rubocop/cop/chef/modernize/dsl_include_in_resource.rb +2 -2
  162. data/lib/rubocop/cop/chef/modernize/empty_resource_initialize.rb +1 -1
  163. data/lib/rubocop/cop/chef/modernize/execute_apt_update.rb +4 -2
  164. data/lib/rubocop/cop/chef/modernize/execute_archive_extract.rb +121 -0
  165. data/lib/rubocop/cop/chef/modernize/execute_sc_exe.rb +1 -1
  166. data/lib/rubocop/cop/chef/modernize/execute_sleep.rb +1 -1
  167. data/lib/rubocop/cop/chef/modernize/execute_sysctl.rb +1 -1
  168. data/lib/rubocop/cop/chef/modernize/execute_tzutil.rb +1 -1
  169. data/lib/rubocop/cop/chef/modernize/execute_update_alternatives.rb +100 -0
  170. data/lib/rubocop/cop/chef/modernize/foodcritic_comments.rb +1 -1
  171. data/lib/rubocop/cop/chef/modernize/if_provides_default_action.rb +1 -1
  172. data/lib/rubocop/cop/chef/modernize/includes_mixin_shellout.rb +5 -1
  173. data/lib/rubocop/cop/chef/modernize/libarchive_file.rb +6 -4
  174. data/lib/rubocop/cop/chef/modernize/macos_user_defaults.rb +1 -1
  175. data/lib/rubocop/cop/chef/modernize/minitest_handler_usage.rb +1 -1
  176. data/lib/rubocop/cop/chef/modernize/node_init_package.rb +1 -1
  177. data/lib/rubocop/cop/chef/modernize/node_roles_include.rb +1 -1
  178. data/lib/rubocop/cop/chef/modernize/ohai_default_recipe.rb +7 -2
  179. data/lib/rubocop/cop/chef/modernize/openssl_rsa_key_resource.rb +1 -1
  180. data/lib/rubocop/cop/chef/modernize/openssl_x509_resource.rb +1 -1
  181. data/lib/rubocop/cop/chef/modernize/osx_config_profile_resource.rb +1 -1
  182. data/lib/rubocop/cop/chef/modernize/powershell_download_file.rb +64 -0
  183. data/lib/rubocop/cop/chef/modernize/powershell_expand_archive.rb +9 -2
  184. data/lib/rubocop/cop/chef/modernize/powershell_guard_interpreter.rb +5 -5
  185. data/lib/rubocop/cop/chef/modernize/powershell_install_package.rb +1 -1
  186. data/lib/rubocop/cop/chef/modernize/powershell_install_windowsfeature.rb +1 -1
  187. data/lib/rubocop/cop/chef/modernize/property_with_name_attribute.rb +1 -1
  188. data/lib/rubocop/cop/chef/modernize/provides_initializer.rb +1 -1
  189. data/lib/rubocop/cop/chef/modernize/resource_name_initializer.rb +1 -1
  190. data/lib/rubocop/cop/chef/modernize/resource_set_or_return.rb +1 -1
  191. data/lib/rubocop/cop/chef/modernize/resource_with_attributes.rb +1 -1
  192. data/lib/rubocop/cop/chef/modernize/respond_to_compile_time.rb +1 -1
  193. data/lib/rubocop/cop/chef/modernize/respond_to_metadata.rb +1 -1
  194. data/lib/rubocop/cop/chef/modernize/respond_to_provides.rb +1 -1
  195. data/lib/rubocop/cop/chef/modernize/respond_to_resource_name.rb +1 -1
  196. data/lib/rubocop/cop/chef/modernize/sc_windows_resource.rb +3 -3
  197. data/lib/rubocop/cop/chef/modernize/seven_zip_archive.rb +8 -2
  198. data/lib/rubocop/cop/chef/modernize/shell_out_helper.rb +1 -1
  199. data/lib/rubocop/cop/chef/modernize/shellouts_to_chocolatey.rb +16 -5
  200. data/lib/rubocop/cop/chef/modernize/simplify_apt_ppa_setup.rb +1 -1
  201. data/lib/rubocop/cop/chef/modernize/sysctl_param_resource.rb +1 -1
  202. data/lib/rubocop/cop/chef/modernize/unnecessary_mixlib_shellout_require.rb +1 -1
  203. data/lib/rubocop/cop/chef/modernize/use_chef_language_cloud_helpers.rb +1 -1
  204. data/lib/rubocop/cop/chef/modernize/use_chef_language_env_helpers.rb +1 -1
  205. data/lib/rubocop/cop/chef/modernize/use_chef_language_systemd_helper.rb +1 -1
  206. data/lib/rubocop/cop/chef/modernize/use_multipackage_installs.rb +1 -1
  207. data/lib/rubocop/cop/chef/modernize/use_require_relative.rb +2 -2
  208. data/lib/rubocop/cop/chef/modernize/whyrun_supported_true.rb +1 -1
  209. data/lib/rubocop/cop/chef/modernize/windows_default_recipe.rb +2 -2
  210. data/lib/rubocop/cop/chef/modernize/windows_registry_uac.rb +1 -1
  211. data/lib/rubocop/cop/chef/modernize/windows_zipfile.rb +9 -3
  212. data/lib/rubocop/cop/chef/modernize/zipfile_resource.rb +8 -2
  213. data/lib/rubocop/cop/chef/modernize/zypper_repo.rb +3 -3
  214. data/lib/rubocop/cop/chef/redundant/apt_repository_distribution_default.rb +1 -1
  215. data/lib/rubocop/cop/chef/redundant/apt_repository_notifies_apt_update.rb +1 -1
  216. data/lib/rubocop/cop/chef/redundant/attribute_metadata.rb +1 -1
  217. data/lib/rubocop/cop/chef/redundant/conflicts_metadata.rb +1 -1
  218. data/lib/rubocop/cop/chef/redundant/custom_resource_with_allowed_actions.rb +11 -1
  219. data/lib/rubocop/cop/chef/redundant/double_compile_time.rb +23 -9
  220. data/lib/rubocop/cop/chef/redundant/grouping_metadata.rb +1 -1
  221. data/lib/rubocop/cop/chef/redundant/long_description_metadata.rb +1 -1
  222. data/lib/rubocop/cop/chef/redundant/multiple_platform_checks.rb +1 -1
  223. data/lib/rubocop/cop/chef/redundant/name_property_and_required.rb +1 -1
  224. data/lib/rubocop/cop/chef/redundant/ohai_attribute_to_string.rb +1 -1
  225. data/lib/rubocop/cop/chef/redundant/property_splat_regex.rb +1 -1
  226. data/lib/rubocop/cop/chef/redundant/property_with_default_and_required.rb +1 -1
  227. data/lib/rubocop/cop/chef/redundant/provides_metadata.rb +1 -1
  228. data/lib/rubocop/cop/chef/redundant/recipe_metadata.rb +1 -1
  229. data/lib/rubocop/cop/chef/redundant/replaces_metadata.rb +1 -1
  230. data/lib/rubocop/cop/chef/redundant/resource_with_nothing_action.rb +1 -1
  231. data/lib/rubocop/cop/chef/redundant/sensitive_property_in_resource.rb +1 -1
  232. data/lib/rubocop/cop/chef/redundant/service_guard_on_stop_disable.rb +117 -0
  233. data/lib/rubocop/cop/chef/redundant/string_property_with_nil_default.rb +3 -3
  234. data/lib/rubocop/cop/chef/redundant/suggests_metadata.rb +1 -1
  235. data/lib/rubocop/cop/chef/redundant/unnecessary_desired_state.rb +1 -1
  236. data/lib/rubocop/cop/chef/redundant/unnecessary_name_property.rb +2 -2
  237. data/lib/rubocop/cop/chef/redundant/use_create_if_missing.rb +1 -1
  238. data/lib/rubocop/cop/chef/security/insecure_remote_file_source.rb +82 -0
  239. data/lib/rubocop/cop/chef/security/ssh_private_key.rb +10 -1
  240. data/lib/rubocop/cop/chef/sharing/default_maintainer_metadata.rb +1 -1
  241. data/lib/rubocop/cop/chef/sharing/empty_metadata_field.rb +1 -1
  242. data/lib/rubocop/cop/chef/sharing/empty_property_description.rb +62 -0
  243. data/lib/rubocop/cop/chef/sharing/include_property_descriptions.rb +1 -1
  244. data/lib/rubocop/cop/chef/sharing/include_resource_descriptions.rb +1 -1
  245. data/lib/rubocop/cop/chef/sharing/include_resource_examples.rb +1 -1
  246. data/lib/rubocop/cop/chef/sharing/insecure_cookbook_url.rb +1 -1
  247. data/lib/rubocop/cop/chef/sharing/invalid_license_string.rb +1 -1
  248. data/lib/rubocop/cop/chef/style/chef_whaaat.rb +1 -1
  249. data/lib/rubocop/cop/chef/style/comment_sentence_spacing.rb +1 -1
  250. data/lib/rubocop/cop/chef/style/comments_copyright_format.rb +1 -1
  251. data/lib/rubocop/cop/chef/style/comments_default_copyright.rb +1 -1
  252. data/lib/rubocop/cop/chef/style/comments_format.rb +1 -1
  253. data/lib/rubocop/cop/chef/style/immediate_notification_timing.rb +1 -1
  254. data/lib/rubocop/cop/chef/style/include_recipe_with_parentheses.rb +6 -3
  255. data/lib/rubocop/cop/chef/style/negating_only_if.rb +1 -1
  256. data/lib/rubocop/cop/chef/style/overly_complex_supports_depends_metadata.rb +1 -1
  257. data/lib/rubocop/cop/chef/style/simplify_platform_major_version_check.rb +1 -1
  258. data/lib/rubocop/cop/chef/style/true_false_resource_properties.rb +2 -2
  259. data/lib/rubocop/cop/chef/style/unnecessary_os_check.rb +1 -1
  260. data/lib/rubocop/cop/chef/style/unnecessary_platform_case_statement.rb +1 -1
  261. data/lib/rubocop/cop/chef/style/use_platform_helpers.rb +1 -1
  262. data/lib/rubocop/cop/chef.rb +349 -0
  263. data/lib/rubocop/cop/chefstyle/ruby/gemspec_license.rb +1 -1
  264. data/lib/rubocop/cop/chefstyle/ruby/gemspec_require_rubygems.rb +1 -1
  265. data/lib/rubocop/cop/chefstyle/ruby/legacy_powershell_out_methods.rb +1 -1
  266. data/lib/rubocop/cop/chefstyle/ruby/require_net_https.rb +1 -1
  267. data/lib/rubocop/cop/chefstyle/ruby/unless_defined_require.rb +1 -1
  268. data/lib/rubocop/cop/inspec/deprecation/attribute_default.rb +1 -1
  269. data/lib/rubocop/cop/inspec/deprecation/attribute_helper.rb +1 -1
  270. data/lib/rubocop/cop/inspec.rb +31 -0
  271. data/lib/rubocop/monkey_patches/directive_comment.rb +21 -3
  272. metadata +21 -8
@@ -0,0 +1,66 @@
1
+ # frozen_string_literal: true
2
+ #
3
+ # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
+ #
6
+ # Licensed under the Apache License, Version 2.0 (the "License");
7
+ # you may not use this file except in compliance with the License.
8
+ # You may obtain a copy of the License at
9
+ #
10
+ # http://www.apache.org/licenses/LICENSE-2.0
11
+ #
12
+ # Unless required by applicable law or agreed to in writing, software
13
+ # distributed under the License is distributed on an "AS IS" BASIS,
14
+ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15
+ # See the License for the specific language governing permissions and
16
+ # limitations under the License.
17
+ #
18
+ module RuboCop
19
+ module Cop
20
+ module Chef
21
+ module Correctness
22
+ # Ohai reports version attributes as strings, so comparing one with `<`, `>`, `<=`, or `>=`
23
+ # compares them character by character rather than as versions. That gives the wrong answer
24
+ # whenever the version numbers have different digit counts:
25
+ #
26
+ # '7.9' >= '10' # => true, because '7' sorts after '1'
27
+ # '9' > '10' # => true
28
+ #
29
+ # Compare the major version as an integer with `node['platform_version'].to_i`, or compare
30
+ # full versions with `Gem::Version`.
31
+ #
32
+ # @example
33
+ #
34
+ # # bad
35
+ # node['platform_version'] >= '10'
36
+ # node['platform_version'] < '7.4'
37
+ #
38
+ # # good
39
+ # node['platform_version'].to_i >= 10
40
+ # Gem::Version.new(node['platform_version']) >= Gem::Version.new('7.4')
41
+ #
42
+ # # good - equality is a plain string match, which is fine
43
+ # node['platform_version'] == '10'
44
+ #
45
+ class PlatformVersionStringComparison < Base
46
+ MSG = 'Ohai version attributes are strings, so comparing them with an ordering operator compares them character by character. Use .to_i for a major version comparison, or Gem::Version to compare full versions.'
47
+ RESTRICT_ON_SEND = %i(< > <= >=).freeze
48
+
49
+ # the flat Ohai attributes that hold a dotted version string
50
+ def_node_matcher :version_attribute_comparison?, <<-PATTERN
51
+ (send
52
+ (send (send nil? :node) :[] (str {"platform_version" "os_version"}))
53
+ {:< :> :<= :>=}
54
+ (str _))
55
+ PATTERN
56
+
57
+ def on_send(node)
58
+ version_attribute_comparison?(node) do
59
+ add_offense(node, severity: :refactor)
60
+ end
61
+ end
62
+ end
63
+ end
64
+ end
65
+ end
66
+ end
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -26,13 +26,13 @@ module RuboCop
26
26
  # # bad
27
27
  # powershell_script 'Cleanup old files' do
28
28
  # code 'Remove-Item C:\Windows\foo\bar.txt'
29
- # only_if { ::File.exist?('C:\\Windows\\foo\\bar.txt') }
29
+ # only_if { ::File.exist?('C:\Windows\foo\bar.txt') }
30
30
  # end
31
31
  #
32
- # ### correct
33
- # file 'C:\Windows\foo\bar.txt' do
34
- # action :delete
35
- # end
32
+ # # good
33
+ # file 'C:\Windows\foo\bar.txt' do
34
+ # action :delete
35
+ # end
36
36
  #
37
37
  class PowershellScriptDeleteFile < Base
38
38
  include RuboCop::Chef::CookbookHelpers
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -24,7 +24,7 @@ module RuboCop
24
24
  # @example
25
25
  #
26
26
  # # bad
27
- # powershell_out('Test-Path "C:\\Program Files\\LAPS\\CSE\\AdmPwd.dll"').stdout.strip == 'True'
27
+ # powershell_out('Test-Path "C:\Program Files\LAPS\CSE\AdmPwd.dll"').stdout.strip == 'True'
28
28
  #
29
29
  # # good
30
30
  # ::File.exist?('C:\Program Files\LAPS\CSE\AdmPwd.dll')
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -41,10 +41,10 @@ module RuboCop
41
41
 
42
42
  def on_block(node)
43
43
  match_property_in_resource?(nil, 'action', node) do |action_node|
44
- action_node.arguments.each do |action|
45
- next unless action.source == ':none'
44
+ each_action_symbol(action_node) do |action, prefix|
45
+ next unless action.value == :none
46
46
  add_offense(action, severity: :refactor) do |corrector|
47
- corrector.replace(action, ':nothing')
47
+ corrector.replace(action, "#{prefix}nothing")
48
48
  end
49
49
  end
50
50
  end
@@ -0,0 +1,91 @@
1
+ # frozen_string_literal: true
2
+ #
3
+ # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
+ #
6
+ # Licensed under the Apache License, Version 2.0 (the "License");
7
+ # you may not use this file except in compliance with the License.
8
+ # You may obtain a copy of the License at
9
+ #
10
+ # http://www.apache.org/licenses/LICENSE-2.0
11
+ #
12
+ # Unless required by applicable law or agreed to in writing, software
13
+ # distributed under the License is distributed on an "AS IS" BASIS,
14
+ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15
+ # See the License for the specific language governing permissions and
16
+ # limitations under the License.
17
+ #
18
+ module RuboCop
19
+ module Cop
20
+ module Chef
21
+ module Correctness
22
+ # A `not_if`/`only_if` guard takes either a string, which is run as a shell command, or a block,
23
+ # which is run as Ruby. Passing a Ruby expression directly gives the guard the expression's
24
+ # *result* rather than the expression, because it is evaluated while the recipe is compiled.
25
+ #
26
+ # A guard that receives `true` or `false` raises at converge time:
27
+ #
28
+ # ArgumentError: Invalid only_if/not_if command, expected a string: true (TrueClass)
29
+ #
30
+ # Worse, an expression that happens to return a string is accepted and then run as a shell
31
+ # command, so the guard quietly tests something entirely different to what was intended.
32
+ #
33
+ # Only expressions that clearly produce a boolean are flagged, so a shell command built in Ruby
34
+ # and held in a variable is left alone.
35
+ #
36
+ # @example
37
+ #
38
+ # # bad
39
+ # not_if ::File.exist?('/etc/foo')
40
+ # only_if node['foo']['version'] == '1.0'
41
+ #
42
+ # # good
43
+ # not_if { ::File.exist?('/etc/foo') }
44
+ # only_if { node['foo']['version'] == '1.0' }
45
+ #
46
+ # # good - a string guard runs as a shell command
47
+ # not_if 'test -f /etc/foo'
48
+ #
49
+ class RubyGuardWithoutBlock < Base
50
+ extend AutoCorrector
51
+
52
+ MSG = 'A Ruby expression used as a resource guard has to be wrapped in a block. Passing it directly hands the guard the expression result, which raises at converge time or silently runs a shell command.'
53
+ RESTRICT_ON_SEND = [:not_if, :only_if].freeze
54
+
55
+ # comparison and negation operators always produce a boolean
56
+ BOOLEAN_OPERATORS = %i(== != < > <= >= =~ !~ ! equal? eql?).freeze
57
+
58
+ def_node_matcher :guard_with_argument, '(send nil? {:not_if :only_if} $_)'
59
+
60
+ def on_send(node)
61
+ guard_with_argument(node) do |argument|
62
+ next unless boolean_expression?(argument)
63
+
64
+ add_offense(node, severity: :refactor) do |corrector|
65
+ corrector.replace(node, "#{node.method_name} { #{argument.source} }")
66
+ end
67
+ end
68
+ end
69
+
70
+ private
71
+
72
+ # Can we tell that this expression produces a boolean rather than a shell command? Anything
73
+ # we can't be sure about, such as a bare method call or a local variable, is left alone: it
74
+ # may well hold a perfectly good command string.
75
+ #
76
+ # @param [RuboCop::AST::Node] node
77
+ #
78
+ # @return [Boolean]
79
+ def boolean_expression?(node)
80
+ return true if node.boolean_type? || node.defined_type?
81
+ return true if node.operator_keyword? # && and ||
82
+ return node.children.one? && boolean_expression?(node.children.first) if node.begin_type?
83
+ return false unless node.send_type?
84
+
85
+ node.method_name.to_s.end_with?('?') || BOOLEAN_OPERATORS.include?(node.method_name)
86
+ end
87
+ end
88
+ end
89
+ end
90
+ end
91
+ end
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -1,6 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
- # Copyright:: 2016, Chris Henry
3
+ # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
4
5
  #
5
6
  # Licensed under the Apache License, Version 2.0 (the "License");
6
7
  # you may not use this file except in compliance with the License.
@@ -18,36 +19,86 @@ module RuboCop
18
19
  module Cop
19
20
  module Chef
20
21
  module Correctness
21
- # Use a service resource to start and stop services
22
+ # Use the `service` resource to manage services instead of shelling out. The resource is
23
+ # idempotent, picks the right init system for the platform, and reports correctly on what it
24
+ # changed. A shelled out command runs on every converge whether or not anything needed to
25
+ # change, so the run reports the resource as updated every time.
22
26
  #
23
- # @example when command starts a service
27
+ # @example
24
28
  #
25
29
  # # bad
26
- # command "/etc/init.d/mysql start"
27
- # command "/sbin/service/memcached start"
30
+ # execute 'restart apache' do
31
+ # command 'systemctl restart httpd'
32
+ # end
33
+ #
34
+ # execute '/etc/init.d/httpd start'
35
+ #
36
+ # # good
37
+ # service 'httpd' do
38
+ # action :restart
39
+ # end
28
40
  #
29
41
  class ServiceResource < Base
30
- MSG = 'Use a service resource to start and stop services'
31
- RESTRICT_ON_SEND = [:command].freeze
42
+ MSG = 'Use the service resource to manage services instead of shelling out to an init script, service, systemctl, or a similar tool'
43
+ RESTRICT_ON_SEND = %i(command code execute).freeze
44
+
45
+ # the state changing verbs. `status` is left out: a status check is usually a guard rather
46
+ # than something the service resource replaces
47
+ SERVICE_ACTIONS = %w(
48
+ start stop restart reload force-reload try-restart reload-or-restart
49
+ enable disable mask unmask
50
+ ).freeze
51
+
52
+ # commands whose service action is captured and checked against SERVICE_ACTIONS
53
+ ACTION_COMMANDS = [
54
+ %r{\A/(?:etc/init\.d|etc/rc\.d|usr/local/etc/rc\.d)/\S+\s+(\S+)}, # /etc/init.d/httpd start
55
+ %r{\A(?:/usr/sbin/|/sbin/)?service\s+\S+\s+(\S+)}, # service httpd start
56
+ %r{\A(?:/usr/bin/|/bin/)?systemctl\s+(?:--\S+\s+)*(\S+)\s+\S+}, # systemctl start httpd
57
+ /\Ainvoke-rc\.d\s+\S+\s+(\S+)/, # invoke-rc.d httpd start
58
+ /\Ainitctl\s+(\S+)\s+\S+/, # initctl start httpd
59
+ /\Asvcadm\s+(\S+)\s+\S+/, # svcadm enable httpd
60
+ ].freeze
61
+
62
+ # commands that manage a service whatever the rest of the line says
63
+ DIRECT_COMMANDS = [
64
+ /\A(?:start|stop|restart)\s+\S+\z/, # upstart: start httpd
65
+ /\Alaunchctl\s+(?:load|unload|start|stop|enable|disable|bootstrap|bootout)\s/,
66
+ /\Achkconfig\s+(?:--\S+\s+)*\S+\s+(?:on|off)\z/, # chkconfig httpd on
67
+ /\Aupdate-rc\.d\s/, # update-rc.d httpd defaults
68
+ /\A(?:sc|net)\s+(?:start|stop|config)\s+\S+/i, # windows: net start httpd
69
+ ].freeze
70
+
71
+ # a command doing more than the one service action can't be swapped for the resource
72
+ SHELL_OPERATORS = ['&&', '||', ';', '|', '`', '$('].freeze
32
73
 
33
- def_node_matcher :execute_command?, <<-PATTERN
34
- (send nil? :command $str)
35
- PATTERN
74
+ def_node_matcher :command_property?, '(send nil? {:command :code} $str)'
75
+ def_node_matcher :execute_with_command_name?, '(send nil? :execute $str)'
36
76
 
37
77
  def on_send(node)
38
- execute_command?(node) do |command|
39
- if starts_service?(command)
40
- add_offense(command, severity: :refactor)
41
- end
78
+ command_property?(node) do |command|
79
+ add_offense(command, severity: :refactor) if manages_service?(command.value)
80
+ end
81
+
82
+ execute_with_command_name?(node) do |command|
83
+ add_offense(node, severity: :refactor) if manages_service?(command.value)
42
84
  end
43
85
  end
44
86
 
45
- def starts_service?(cmd)
46
- cmd_str = cmd.to_s
47
- (cmd_str.include?('/etc/init.d') || ['service ', '/sbin/service ',
48
- 'start ', 'stop ', 'invoke-rc.d '].any? do |service_cmd|
49
- cmd_str.start_with?(service_cmd)
50
- end) && %w(start stop restart reload).any? { |a| cmd_str.include?(a) }
87
+ private
88
+
89
+ # @param [String] command the literal command string
90
+ #
91
+ # @return [Boolean]
92
+ def manages_service?(command)
93
+ cmd = command.strip
94
+ return false if SHELL_OPERATORS.any? { |operator| cmd.include?(operator) }
95
+
96
+ ACTION_COMMANDS.each do |pattern|
97
+ match = pattern.match(cmd)
98
+ return true if match && SERVICE_ACTIONS.include?(match[1].downcase)
99
+ end
100
+
101
+ DIRECT_COMMANDS.any? { |pattern| cmd.match?(pattern) }
51
102
  end
52
103
  end
53
104
  end
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -27,6 +27,13 @@ module RuboCop
27
27
  # include_recipe 'chef_handler'
28
28
  # include_recipe 'chef_handler::default'
29
29
  #
30
+ # # good
31
+ # # the chef_handler resource ships in Chef Infra Client, so no recipe include is needed
32
+ # chef_handler 'MyHandler' do
33
+ # source '/etc/chef/handlers/my_handler.rb'
34
+ # action :enable
35
+ # end
36
+ #
30
37
  class ChefHandlerRecipe < Base
31
38
  include RangeHelp
32
39
  extend AutoCorrector
@@ -35,7 +42,7 @@ module RuboCop
35
42
  RESTRICT_ON_SEND = [:include_recipe].freeze
36
43
 
37
44
  def_node_matcher :chef_handler_recipe?, <<-PATTERN
38
- (send nil? :include_recipe (str {"chef_handler" "chef_handler::default"}))
45
+ (send {nil? (send nil? :run_context)} :include_recipe (str {"chef_handler" "chef_handler::default"}))
39
46
  PATTERN
40
47
 
41
48
  def on_send(node)
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -27,6 +27,9 @@ module RuboCop
27
27
  # require 'chef/rest'
28
28
  # Chef::REST::RESTRequest.new(:GET, FOO, nil).call
29
29
  #
30
+ # # good
31
+ # Chef::ServerAPI.new(Chef::Config[:chef_server_url]).get('nodes')
32
+ #
30
33
  class UsesChefRESTHelpers < Base
31
34
  MSG = "Don't use the helpers in Chef::REST which were removed in Chef Infra Client 13"
32
35
  RESTRICT_ON_SEND = [:require].freeze
@@ -36,7 +39,7 @@ module RuboCop
36
39
  PATTERN
37
40
 
38
41
  def_node_matcher :rest_const?, <<-PATTERN
39
- (const (const nil? :Chef) :REST)
42
+ (const (const {nil? cbase} :Chef) :REST)
40
43
  PATTERN
41
44
 
42
45
  def on_send(node)
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -43,7 +43,7 @@ module RuboCop
43
43
  def_node_matcher :include_shellout?, <<-PATTERN
44
44
  (send nil? :include
45
45
  (const
46
- (const nil? :Chef) :ShellOut))
46
+ (const {nil? cbase} :Chef) :ShellOut))
47
47
  PATTERN
48
48
 
49
49
  def_node_matcher :require_shellout?, <<-PATTERN
@@ -53,7 +53,7 @@ module RuboCop
53
53
  def_node_matcher :shellout_new?, <<-PATTERN
54
54
  (send
55
55
  (const
56
- (const nil? :Chef) :ShellOut) :new
56
+ (const {nil? cbase} :Chef) :ShellOut) :new
57
57
  ... )
58
58
  PATTERN
59
59
 
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -41,6 +41,12 @@ module RuboCop
41
41
  # nexentacore?
42
42
  # opensolaris?
43
43
  #
44
+ # # good
45
+ # # the equivalents now shipping in Chef Infra Client and in Ruby itself
46
+ # vagrant?
47
+ # node.recipe?('foo::bar')
48
+ # shell_out!('/opt/app/bin/app --version', out: File::NULL)
49
+ #
44
50
  class ChefSugarHelpers < Base
45
51
  MSG = 'Do not use legacy chef-sugar helper methods, which will not be moved into Chef Infra Client itself. For a complete set of chef-sugar helpers now shipping in Chef Infra Client itself see https://github.com/chef/chef/tree/main/chef-utils#getting-started'
46
52
  RESTRICT_ON_SEND = [:vagrant_key?, :vagrant_domain?, :vagrant_user?, :require_chef_gem, :best_ip_for, :nexus?, :ios_xr?, :ruby_20?, :ruby_19?, :includes_recipe?, :wrlinux?, :dev_null, :nexentacore_platform?, :opensolaris_platform?, :nexentacore?, :opensolaris?].freeze
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -38,7 +38,7 @@ module RuboCop
38
38
  def_node_matcher :chef_platform_windows?, <<-PATTERN
39
39
  (send
40
40
  (const
41
- (const nil? :Chef) :Platform) :windows?)
41
+ (const {nil? cbase} :Chef) :Platform) :windows?)
42
42
  PATTERN
43
43
 
44
44
  def on_send(node)
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -41,10 +41,10 @@ module RuboCop
41
41
 
42
42
  def on_block(node)
43
43
  match_property_in_resource?(:chocolatey_package, 'action', node) do |choco_action|
44
- choco_action.arguments.each do |action|
45
- next unless action.source == ':uninstall'
44
+ each_action_symbol(choco_action) do |action, prefix|
45
+ next unless action.value == :uninstall
46
46
  add_offense(action, severity: :warning) do |corrector|
47
- corrector.replace(action, ':remove')
47
+ corrector.replace(action, "#{prefix}remove")
48
48
  end
49
49
  end
50
50
  end
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
  #
3
3
  # Copyright:: Copyright (c) 2016-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
4
- # Author:: Tim Smith (<tsmith84@gmail.com>)
4
+ # Author:: Tim Smith (<tsmith84@proton.me>)
5
5
  #
6
6
  # Licensed under the Apache License, Version 2.0 (the "License");
7
7
  # you may not use this file except in compliance with the License.