cookstyle 7.32.8 → 8.0.0

data/lib/rubocop/cop/inspec/deprecation/attribute_default.rb

@@ -1,53 +1,53 @@
-# frozen_string_literal: true
-#
-# Copyright:: 2021, Chef Software Inc.
-# Author:: Tim Smith (<tsmith84@gmail.com>)
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-module RuboCop
-  module Cop
-    module InSpec
-      module Deprecations
-        # The Chef InSpec inputs `default` option has been replaced with the `value` option.
-        #
-        # @example
-        #
-        #   ### incorrect
-        #   login_defs_umask = input('login_defs_umask', default: '077', description: 'Default umask to set in login.defs')
-        #
-        #   ### correct
-        #   login_defs_umask = input('login_defs_umask', value: '077', description: 'Default umask to set in login.defs')
-        #
-        class AttributeDefault < Base
-          extend AutoCorrector
-
-          MSG = 'The InSpec inputs `default` option has been replaced with the `value` option.'
-          RESTRICT_ON_SEND = [:attribute, :input].freeze
-
-          def_node_matcher :default?, <<-PATTERN
-            (send nil? {:attribute :input} _ (hash <(pair $(sym :default) ...) ...>) )
-          PATTERN
-
-          def on_send(node)
-            default?(node) do |n|
-              add_offense(n, severity: :warning) do |corrector|
-                corrector.replace(n, 'value')
-              end
-            end
-          end
-        end
-      end
-    end
-  end
-end
+# frozen_string_literal: true
+#
+# Copyright:: 2021, Chef Software Inc.
+# Author:: Tim Smith (<tsmith84@gmail.com>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Cop
+    module InSpec
+      module Deprecations
+        # The Chef InSpec inputs `default` option has been replaced with the `value` option.
+        #
+        # @example
+        #
+        #   ### incorrect
+        #   login_defs_umask = input('login_defs_umask', default: '077', description: 'Default umask to set in login.defs')
+        #
+        #   ### correct
+        #   login_defs_umask = input('login_defs_umask', value: '077', description: 'Default umask to set in login.defs')
+        #
+        class AttributeDefault < Base
+          extend AutoCorrector
+
+          MSG = 'The InSpec inputs `default` option has been replaced with the `value` option.'
+          RESTRICT_ON_SEND = [:attribute, :input].freeze
+
+          def_node_matcher :default?, <<-PATTERN
+            (send nil? {:attribute :input} _ (hash <(pair $(sym :default) ...) ...>) )
+          PATTERN
+
+          def on_send(node)
+            default?(node) do |n|
+              add_offense(n, severity: :warning) do |corrector|
+                corrector.replace(n, 'value')
+              end
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/inspec/deprecation/attribute_helper.rb

@@ -1,47 +1,47 @@
-# frozen_string_literal: true
-#
-# Copyright:: 2021, Chef Software Inc.
-# Author:: Tim Smith (<tsmith84@gmail.com>)
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-module RuboCop
-  module Cop
-    module InSpec
-      module Deprecations
-        # Chef InSpec attributes have been renamed to inputs. Use the `input` method not the deprecation `attribute` method to access these values.
-        #
-        # @example
-        #
-        #   ### incorrect
-        #   login_defs_umask = attribute('login_defs_umask', value: '077', description: 'Default umask to set in login.defs')
-        #
-        #   ### correct
-        #   login_defs_umask = input('login_defs_umask', value: '077', description: 'Default umask to set in login.defs')
-        #
-        class AttributeHelper < Base
-          extend AutoCorrector
-
-          MSG = 'InSpec attributes have been renamed to inputs. Use the `input` method not the deprecation `attribute` method to access these values.'
-          RESTRICT_ON_SEND = [:attribute].freeze
-
-          def on_send(node)
-            add_offense(node, severity: :warning) do |corrector|
-              corrector.replace(node.loc.expression, node.loc.expression.source.gsub(/^attribute/, 'input'))
-            end
-          end
-        end
-      end
-    end
-  end
-end
+# frozen_string_literal: true
+#
+# Copyright:: 2021, Chef Software Inc.
+# Author:: Tim Smith (<tsmith84@gmail.com>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Cop
+    module InSpec
+      module Deprecations
+        # Chef InSpec attributes have been renamed to inputs. Use the `input` method not the deprecation `attribute` method to access these values.
+        #
+        # @example
+        #
+        #   ### incorrect
+        #   login_defs_umask = attribute('login_defs_umask', value: '077', description: 'Default umask to set in login.defs')
+        #
+        #   ### correct
+        #   login_defs_umask = input('login_defs_umask', value: '077', description: 'Default umask to set in login.defs')
+        #
+        class AttributeHelper < Base
+          extend AutoCorrector
+
+          MSG = 'InSpec attributes have been renamed to inputs. Use the `input` method not the deprecation `attribute` method to access these values.'
+          RESTRICT_ON_SEND = [:attribute].freeze
+
+          def on_send(node)
+            add_offense(node, severity: :warning) do |corrector|
+              corrector.replace(node.loc.expression, node.loc.expression.source.gsub(/^attribute/, 'input'))
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/target_chef_version.rb

@@ -1,22 +1,22 @@
-# frozen_string_literal: true
-
-# shamelessly borrowed from rubocop-rails. Thanks!
-
-module RuboCop
-  module Cop
-    # Common functionality for checking target chef version.
-    module TargetChefVersion
-      def required_minimum_chef_version
-        @minimum_target_chef_version
-      end
-
-      def minimum_target_chef_version(version)
-        @minimum_target_chef_version = version
-      end
-
-      def support_target_chef_version?(version)
-        Gem::Version.new(@minimum_target_chef_version) <= Gem::Version.new(version)
-      end
-    end
-  end
-end
+# frozen_string_literal: true
+
+# shamelessly borrowed from rubocop-rails. Thanks!
+
+module RuboCop
+  module Cop
+    # Common functionality for checking target chef version.
+    module TargetChefVersion
+      def required_minimum_chef_version
+        @minimum_target_chef_version
+      end
+
+      def minimum_target_chef_version(version)
+        @minimum_target_chef_version = version
+      end
+
+      def support_target_chef_version?(version)
+        Gem::Version.new(@minimum_target_chef_version) <= Gem::Version.new(version)
+      end
+    end
+  end
+end

data/lib/rubocop/monkey_patches/allow_invalid_ruby.rb

@@ -1,28 +1,28 @@
-# frozen_string_literal: true
-require 'rubocop/rspec/expect_offense'
-# rubocop:disable Lint/DuplicateMethods
-
-module RuboCop
-  module RSpec
-    module ExpectOffense
-      # Yields to a block with `parse_processed_source` patched to not raise an
-      # exception.
-      #
-      # RSpec's `expect_offense` helper calls a method called
-      # `parse_processed_source` that parses source code and raises an exception
-      # if it is not valid Ruby. Raising an exception prevents RuboCop from
-      # calling the cop's `on_other_file` method for checking non-Ruby files.
-      def allow_invalid_ruby(&block)
-        alias :parse_processed_source :_parse_invalid_source
-        yield block
-        alias :parse_processed_source :_orig_parse_processed_source
-      end
-
-      alias :_orig_parse_processed_source :parse_processed_source
-
-      def _parse_invalid_source(source, file = nil)
-        parse_source(source, file)
-      end
-    end
-  end
-end
+# frozen_string_literal: true
+require 'rubocop/rspec/expect_offense'
+# rubocop:disable Lint/DuplicateMethods
+
+module RuboCop
+  module RSpec
+    module ExpectOffense
+      # Yields to a block with `parse_processed_source` patched to not raise an
+      # exception.
+      #
+      # RSpec's `expect_offense` helper calls a method called
+      # `parse_processed_source` that parses source code and raises an exception
+      # if it is not valid Ruby. Raising an exception prevents RuboCop from
+      # calling the cop's `on_other_file` method for checking non-Ruby files.
+      def allow_invalid_ruby(&block)
+        alias :parse_processed_source :_parse_invalid_source
+        yield block
+        alias :parse_processed_source :_orig_parse_processed_source
+      end
+
+      alias :_orig_parse_processed_source :parse_processed_source
+
+      def _parse_invalid_source(source, file = nil)
+        parse_source(source, file)
+      end
+    end
+  end
+end

data/lib/rubocop/monkey_patches/base.rb

@@ -1,11 +1,11 @@
-# frozen_string_literal: true
-module RuboCop
-  module Cop
-    class Base
-      # This is a copy of the #target_rails_version method from rubocop-rails
-      def target_chef_version
-        @config.target_chef_version
-      end
-    end
-  end
-end
+# frozen_string_literal: true
+module RuboCop
+  module Cop
+    class Base
+      # This is a copy of the #target_rails_version method from rubocop-rails
+      def target_chef_version
+        @config.target_chef_version
+      end
+    end
+  end
+end

data/lib/rubocop/monkey_patches/config.rb

@@ -1,15 +1,15 @@
-# frozen_string_literal: true
-
-module RuboCop
-  class Config
-    # This is a copy of the #target_rails_version method from RuboCop
-    def target_chef_version
-      @target_chef_version ||=
-        if for_all_cops['TargetChefVersion']
-          for_all_cops['TargetChefVersion'].to_f
-        else
-          99 # just set a high number so we don't need to update this later
-        end
-    end
-  end
-end
+# frozen_string_literal: true
+
+module RuboCop
+  class Config
+    # This is a copy of the #target_rails_version method from RuboCop
+    def target_chef_version
+      @target_chef_version ||=
+        if for_all_cops['TargetChefVersion']
+          for_all_cops['TargetChefVersion'].to_f
+        else
+          99 # just set a high number so we don't need to update this later
+        end
+    end
+  end
+end

data/lib/rubocop/monkey_patches/directive_comment.rb

@@ -1,12 +1,12 @@
-# frozen_string_literal: true
-module RuboCop
-  # we're monkey patching the config regex to allow for # cookstyle: disable whatever
-  # in addition to the # rubocop: disable whatever that comes with RuboCop
-  class DirectiveComment
-    remove_const(:DIRECTIVE_COMMENT_REGEXP)
-    DIRECTIVE_COMMENT_REGEXP = Regexp.new(
-      "# (?:rubocop|cookstyle) : ((?:disable|enable|todo))\\b #{COPS_PATTERN}"
-        .gsub(' ', '\s*')
-    )
-  end
-end
+# frozen_string_literal: true
+module RuboCop
+  # we're monkey patching the config regex to allow for "cookstyle: disable whatever"
+  # in addition to the "rubocop: disable whatever that comes with RuboCop"
+  class DirectiveComment
+    remove_const(:DIRECTIVE_COMMENT_REGEXP)
+    DIRECTIVE_COMMENT_REGEXP = Regexp.new(
+      "# (?:rubocop|cookstyle) : ((?:disable|enable|todo))\\b #{COPS_PATTERN}"
+        .gsub(' ', '\s*')
+    )
+  end
+end

data/lib/rubocop/monkey_patches/registry_cop.rb

@@ -1,15 +1,15 @@
-# frozen_string_literal: true
-module RuboCop
-  module Cop
-    class Registry
-      # we monkeypatch this warning to replace rubocop with cookstyle
-      def print_warning(name, path)
-        message = "#{path}: Warning: no department given for #{name}."
-        if path.end_with?('.rb')
-          message += ' Run `cookstyle -a --only Migration/DepartmentName` to fix.'
-        end
-        warn message
-      end
-    end
-  end
-end
+# frozen_string_literal: true
+module RuboCop
+  module Cop
+    class Registry
+      # we monkeypatch this warning to replace rubocop with cookstyle
+      def print_warning(name, path)
+        message = "#{path}: Warning: no department given for #{name}."
+        if path.end_with?('.rb')
+          message += ' Run `cookstyle -a --only Migration/DepartmentName` to fix.'
+        end
+        warn message
+      end
+    end
+  end
+end

data/lib/rubocop/monkey_patches/team.rb

@@ -1,24 +1,25 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    class Team
-      def support_target_chef_version?(cop)
-        return true unless cop.class.respond_to?(:support_target_chef_version?)
-
-        cop.class.support_target_chef_version?(cop.target_chef_version)
-      end
-
-      ### START COOKSTYLE MODIFICATION
-      def roundup_relevant_cops(filename)
-        cops.reject do |cop|
-          cop.excluded_file?(filename) ||
-            !support_target_ruby_version?(cop) ||
-            !support_target_chef_version?(cop) ||
-            !support_target_rails_version?(cop)
-        end
-      end
-      ### END COOKSTYLE MODIFICATION
-    end
-  end
-end
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    class Team
+      def support_target_chef_version?(cop)
+        return true unless cop.class.respond_to?(:support_target_chef_version?)
+
+        cop.class.support_target_chef_version?(cop.target_chef_version)
+      end
+
+      ### START COOKSTYLE MODIFICATION
+      def roundup_relevant_cops(processed_source)
+        cops.select do |cop|
+          next true if processed_source.comment_config.cop_opted_in?(cop)
+          next false if cop.excluded_file?(processed_source.file_path)
+          next false unless @registry.enabled?(cop, @config)
+
+          support_target_ruby_version?(cop) && support_target_rails_version?(cop) && support_target_chef_version?(cop)
+        end
+      end
+      ### END COOKSTYLE MODIFICATION
+    end
+  end
+end

metadata

@@ -1,15 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cookstyle
 version: !ruby/object:Gem::Version
-  version: 7.32.8
+  version: 8.0.0
 platform: ruby
 authors:
 - Thom May
 - Tim Smith
-autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-02-06 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -17,15 +16,42 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.25.1
+        version: 1.75.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.25.1
-description: 
+        version: 1.75.2
+- !ruby/object:Gem::Dependency
+  name: base64
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: ostruct
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 email:
 - thom@chef.io
 - tsmith84@gmail.com
@@ -324,7 +350,6 @@ metadata:
   source_code_uri: https://github.com/chef/cookstyle
   documentation_uri: https://docs.chef.io/workstation/cookstyle/
   bug_tracker_uri: https://github.com/chef/cookstyle/issues
-post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -339,8 +364,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
-signing_key: 
+rubygems_version: 3.6.8
 specification_version: 4
 summary: Cookstyle is a code linting tool that helps you to write better Chef Infra
   cookbooks by detecting and automatically correcting style, syntax, and logic mistakes