cookstyle 7.32.8 → 8.0.0

data/lib/rubocop/cop/chef/sharing/include_resource_descriptions.rb

@@ -1,52 +1,52 @@
-# frozen_string_literal: true
-#
-# Copyright:: Copyright 2020, Chef Software Inc.
-# Author:: Tim Smith (<tsmith84@gmail.com>)
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-module RuboCop
-  module Cop
-    module Chef
-      module Sharing
-        # Resources should include description fields to allow automated documentation. Requires Chef Infra Client 13.9 or later.
-        #
-        # @example
-        #
-        #   ### correct
-        #   resource_name :foo
-        #   description "The foo resource is used to do..."
-        #
-        class IncludeResourceDescriptions < Base
-          include RangeHelp
-          extend TargetChefVersion
-
-          minimum_target_chef_version '13.9'
-
-          MSG = 'Resources should include description fields to allow automated documentation. Requires Chef Infra Client 13.9 or later.'
-
-          def on_new_investigation
-            return if processed_source.blank? || resource_description(processed_source.ast).any?
-
-            # Using range similar to RuboCop::Cop::Naming::Filename (file_name.rb)
-            range = source_range(processed_source.buffer, 1, 0)
-
-            add_offense(range, severity: :refactor)
-          end
-
-          def_node_search :resource_description, '(send nil? :description ...)'
-        end
-      end
-    end
-  end
-end
+# frozen_string_literal: true
+#
+# Copyright:: Copyright 2020, Chef Software Inc.
+# Author:: Tim Smith (<tsmith84@gmail.com>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Cop
+    module Chef
+      module Sharing
+        # Resources should include description fields to allow automated documentation. Requires Chef Infra Client 13.9 or later.
+        #
+        # @example
+        #
+        #   ### correct
+        #   resource_name :foo
+        #   description "The foo resource is used to do..."
+        #
+        class IncludeResourceDescriptions < Base
+          include RangeHelp
+          extend TargetChefVersion
+
+          minimum_target_chef_version '13.9'
+
+          MSG = 'Resources should include description fields to allow automated documentation. Requires Chef Infra Client 13.9 or later.'
+
+          def on_new_investigation
+            return if processed_source.blank? || resource_description(processed_source.ast).any?
+
+            # Using range similar to RuboCop::Cop::Naming::Filename (file_name.rb)
+            range = source_range(processed_source.buffer, 1, 0)
+
+            add_offense(range, severity: :refactor)
+          end
+
+          def_node_search :resource_description, '(send nil? :description ...)'
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/chef/sharing/include_resource_examples.rb

@@ -1,60 +1,60 @@
-# frozen_string_literal: true
-#
-# Copyright:: Copyright 2020, Chef Software Inc.
-# Author:: Tim Smith (<tsmith84@gmail.com>)
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-module RuboCop
-  module Cop
-    module Chef
-      module Sharing
-        # Resources should include examples field to allow automated documentation. Requires Chef Infra Client 13.9 or later.
-        #
-        # @example
-        #
-        #   ### correct
-        #   examples <<~DOC
-        #     **Specify a global domain value**
-        #
-        #     ```ruby
-        #     macos_userdefaults 'full keyboard access to all controls' do
-        #       key 'AppleKeyboardUIMode'
-        #       value '2'
-        #     end
-        #     ```
-        #   DOC
-        #
-        class IncludeResourceExamples < Base
-          include RangeHelp
-          extend TargetChefVersion
-
-          minimum_target_chef_version '13.9'
-
-          MSG = 'Resources should include examples field to allow automated documentation. Requires Chef Infra Client 13.9 or later.'
-
-          def on_new_investigation
-            return if processed_source.blank? || resource_examples(processed_source.ast).any?
-
-            # Using range similar to RuboCop::Cop::Naming::Filename (file_name.rb)
-            range = source_range(processed_source.buffer, 1, 0)
-
-            add_offense(range, severity: :refactor)
-          end
-
-          def_node_search :resource_examples, '(send nil? :examples dstr ...)'
-        end
-      end
-    end
-  end
-end
+# frozen_string_literal: true
+#
+# Copyright:: Copyright 2020, Chef Software Inc.
+# Author:: Tim Smith (<tsmith84@gmail.com>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Cop
+    module Chef
+      module Sharing
+        # Resources should include examples field to allow automated documentation. Requires Chef Infra Client 13.9 or later.
+        #
+        # @example
+        #
+        #   ### correct
+        #   examples <<~DOC
+        #     **Specify a global domain value**
+        #
+        #     ```ruby
+        #     macos_userdefaults 'full keyboard access to all controls' do
+        #       key 'AppleKeyboardUIMode'
+        #       value '2'
+        #     end
+        #     ```
+        #   DOC
+        #
+        class IncludeResourceExamples < Base
+          include RangeHelp
+          extend TargetChefVersion
+
+          minimum_target_chef_version '13.9'
+
+          MSG = 'Resources should include examples field to allow automated documentation. Requires Chef Infra Client 13.9 or later.'
+
+          def on_new_investigation
+            return if processed_source.blank? || resource_examples(processed_source.ast).any?
+
+            # Using range similar to RuboCop::Cop::Naming::Filename (file_name.rb)
+            range = source_range(processed_source.buffer, 1, 0)
+
+            add_offense(range, severity: :refactor)
+          end
+
+          def_node_search :resource_examples, '(send nil? :examples dstr ...)'
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/chef/sharing/insecure_cookbook_url.rb

@@ -1,62 +1,62 @@
-# frozen_string_literal: true
-#
-# Copyright:: Copyright 2019, Chef Software Inc.
-# Author:: Tim Smith (<tsmith84@gmail.com>)
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-module RuboCop
-  module Cop
-    module Chef
-      module Sharing
-        # Use secure Github and Gitlab URLs for source_url and issues_url
-        #
-        # @example
-        #
-        #   ### incorrect
-        #   source_url 'http://github.com/something/something'
-        #   source_url 'http://www.github.com/something/something'
-        #   source_url 'http://www.gitlab.com/something/something'
-        #   source_url 'http://gitlab.com/something/something'
-        #
-        #   ### correct
-        #   source_url 'http://github.com/something/something'
-        #   source_url 'http://gitlab.com/something/something'
-        #
-        class InsecureCookbookURL < Base
-          extend AutoCorrector
-
-          MSG = 'Insecure http Github or Gitlab URLs for metadata source_url/issues_url fields'
-          RESTRICT_ON_SEND = [:source_url, :issues_url].freeze
-
-          def_node_matcher :insecure_cb_url?, <<-PATTERN
-            (send nil? {:source_url :issues_url} (str #insecure_url?))
-          PATTERN
-
-          def insecure_url?(url)
-            # https://rubular.com/r/dS6L6bQZvwWxWq
-            url.match?(%r{http://(www.)*git(hub|lab)})
-          end
-
-          def on_send(node)
-            insecure_cb_url?(node) do
-              add_offense(node, severity: :refactor) do |corrector|
-                corrector.replace(node, node.source.gsub(%r{http://(www.)*}, 'https://'))
-              end
-            end
-          end
-        end
-      end
-    end
-  end
-end
+# frozen_string_literal: true
+#
+# Copyright:: Copyright 2019, Chef Software Inc.
+# Author:: Tim Smith (<tsmith84@gmail.com>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Cop
+    module Chef
+      module Sharing
+        # Use secure Github and Gitlab URLs for source_url and issues_url
+        #
+        # @example
+        #
+        #   ### incorrect
+        #   source_url 'http://github.com/something/something'
+        #   source_url 'http://www.github.com/something/something'
+        #   source_url 'http://www.gitlab.com/something/something'
+        #   source_url 'http://gitlab.com/something/something'
+        #
+        #   ### correct
+        #   source_url 'http://github.com/something/something'
+        #   source_url 'http://gitlab.com/something/something'
+        #
+        class InsecureCookbookURL < Base
+          extend AutoCorrector
+
+          MSG = 'Insecure http Github or Gitlab URLs for metadata source_url/issues_url fields'
+          RESTRICT_ON_SEND = [:source_url, :issues_url].freeze
+
+          def_node_matcher :insecure_cb_url?, <<-PATTERN
+            (send nil? {:source_url :issues_url} (str #insecure_url?))
+          PATTERN
+
+          def insecure_url?(url)
+            # https://rubular.com/r/dS6L6bQZvwWxWq
+            url.match?(%r{http://(www.)*git(hub|lab)})
+          end
+
+          def on_send(node)
+            insecure_cb_url?(node) do
+              add_offense(node, severity: :refactor) do |corrector|
+                corrector.replace(node, node.source.gsub(%r{http://(www.)*}, 'https://'))
+              end
+            end
+          end
+        end
+      end
+    end
+  end
+end