cookstyle 7.32.8 → 8.0.0

data/lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb

@@ -1,51 +1,51 @@
-# frozen_string_literal: true
-#
-# Copyright:: Copyright 2019, Chef Software Inc.
-# Author:: Tim Smith (<tsmith84@gmail.com>)
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-module RuboCop
-  module Cop
-    module Chef
-      module Correctness
-        # Chef Infra Client uses properties in several resources to track state. These should not be set in recipes as they break the internal workings of the Chef Infra Client
-        #
-        # @example
-        #
-        #   ### incorrect
-        #   service 'foo' do
-        #     running true
-        #     action [:start, :enable]
-        #   end
-        #
-        #   ### correct
-        #   service 'foo' do
-        #     action [:start, :enable]
-        #   end
-        #
-        class ResourceSetsInternalProperties < Base
-          include RuboCop::Chef::CookbookHelpers
-
-          MSG = 'Do not set properties used internally by Chef Infra Client to track the system state.'
-
-          def on_block(node)
-            match_property_in_resource?(:service, 'running', node) do |prop|
-              add_offense(prop, severity: :refactor)
-            end
-          end
-        end
-      end
-    end
-  end
-end
+# frozen_string_literal: true
+#
+# Copyright:: Copyright 2019, Chef Software Inc.
+# Author:: Tim Smith (<tsmith84@gmail.com>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Cop
+    module Chef
+      module Correctness
+        # Chef Infra Client uses properties in several resources to track state. These should not be set in recipes as they break the internal workings of the Chef Infra Client
+        #
+        # @example
+        #
+        #   ### incorrect
+        #   service 'foo' do
+        #     running true
+        #     action [:start, :enable]
+        #   end
+        #
+        #   ### correct
+        #   service 'foo' do
+        #     action [:start, :enable]
+        #   end
+        #
+        class ResourceSetsInternalProperties < Base
+          include RuboCop::Chef::CookbookHelpers
+
+          MSG = 'Do not set properties used internally by Chef Infra Client to track the system state.'
+
+          def on_block(node)
+            match_property_in_resource?(:service, 'running', node) do |prop|
+              add_offense(prop, severity: :refactor)
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb

@@ -1,50 +1,50 @@
-# frozen_string_literal: true
-#
-# Copyright:: 2019, Chef Software Inc.
-# Author:: Tim Smith (<tsmith84@gmail.com>)
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-module RuboCop
-  module Cop
-    module Chef
-      module Correctness
-        # Use name properties instead of setting the name property in a resource. Setting the name property directly causes notification and reporting issues.
-        #
-        # @example
-        #
-        #   ### incorrect
-        #   service 'foo' do
-        #    name 'bar'
-        #   end
-        #
-        #   ### correct
-        #   service 'foo' do
-        #    service_name 'bar'
-        #   end
-        #
-        class ResourceSetsNameProperty < Base
-          include RuboCop::Chef::CookbookHelpers
-
-          MSG = 'Resource sets the name property in the resource instead of using a name_property.'
-
-          def on_block(node)
-            match_property_in_resource?(nil, 'name', node) do |name_node|
-              add_offense(name_node, severity: :refactor)
-            end
-          end
-        end
-      end
-    end
-  end
-end
+# frozen_string_literal: true
+#
+# Copyright:: 2019, Chef Software Inc.
+# Author:: Tim Smith (<tsmith84@gmail.com>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Cop
+    module Chef
+      module Correctness
+        # Use name properties instead of setting the name property in a resource. Setting the name property directly causes notification and reporting issues.
+        #
+        # @example
+        #
+        #   ### incorrect
+        #   service 'foo' do
+        #    name 'bar'
+        #   end
+        #
+        #   ### correct
+        #   service 'foo' do
+        #    service_name 'bar'
+        #   end
+        #
+        class ResourceSetsNameProperty < Base
+          include RuboCop::Chef::CookbookHelpers
+
+          MSG = 'Resource sets the name property in the resource instead of using a name_property.'
+
+          def on_block(node)
+            match_property_in_resource?(nil, 'name', node) do |name_node|
+              add_offense(name_node, severity: :refactor)
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/chef/correctness/resource_with_none_action.rb

@@ -1,56 +1,56 @@
-# frozen_string_literal: true
-#
-# Copyright:: 2019, Chef Software Inc.
-# Author:: Tim Smith (<tsmith84@gmail.com>)
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-module RuboCop
-  module Cop
-    module Chef
-      module Correctness
-        # The :nothing action is often typo'd as :none
-        #
-        # @example
-        #
-        #   ### incorrect
-        #   service 'foo' do
-        #    action :none
-        #   end
-        #
-        #   ### correct
-        #   service 'foo' do
-        #    action :nothing
-        #   end
-        #
-        class ResourceWithNoneAction < Base
-          include RuboCop::Chef::CookbookHelpers
-          extend AutoCorrector
-
-          MSG = 'Resource uses the nonexistent :none action instead of the :nothing action'
-
-          def on_block(node)
-            match_property_in_resource?(nil, 'action', node) do |action_node|
-              action_node.arguments.each do |action|
-                next unless action.source == ':none'
-                add_offense(action, severity: :refactor) do |corrector|
-                  corrector.replace(action, ':nothing')
-                end
-              end
-            end
-          end
-        end
-      end
-    end
-  end
-end
+# frozen_string_literal: true
+#
+# Copyright:: 2019, Chef Software Inc.
+# Author:: Tim Smith (<tsmith84@gmail.com>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Cop
+    module Chef
+      module Correctness
+        # The :nothing action is often typo'd as :none
+        #
+        # @example
+        #
+        #   ### incorrect
+        #   service 'foo' do
+        #    action :none
+        #   end
+        #
+        #   ### correct
+        #   service 'foo' do
+        #    action :nothing
+        #   end
+        #
+        class ResourceWithNoneAction < Base
+          include RuboCop::Chef::CookbookHelpers
+          extend AutoCorrector
+
+          MSG = 'Resource uses the nonexistent :none action instead of the :nothing action'
+
+          def on_block(node)
+            match_property_in_resource?(nil, 'action', node) do |action_node|
+              action_node.arguments.each do |action|
+                next unless action.source == ':none'
+                add_offense(action, severity: :refactor) do |corrector|
+                  corrector.replace(action, ':nothing')
+                end
+              end
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/chef/correctness/scoped_file_exist.rb

@@ -1,52 +1,52 @@
-# frozen_string_literal: true
-#
-# Copyright:: Copyright 2019, Chef Software Inc.
-# Author:: Tim Smith (<tsmith84@gmail.com>)
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-module RuboCop
-  module Cop
-    module Chef
-      module Correctness
-        # Scope file exist to access the correct `File` class by using `::File.exist?` not `File.exist?`.
-        #
-        # @example
-        #
-        #   ### incorrect
-        #   not_if { File.exist?('/etc/foo/bar') }
-        #
-        #   ### correct
-        #   not_if { ::File.exist?('/etc/foo/bar') }
-        #
-        class ScopedFileExist < Base
-          extend AutoCorrector
-
-          MSG = 'Scope file exist to access the correct File class by using ::File.exist? not File.exist?.'
-
-          def_node_matcher :unscoped_file_exist?, <<-PATTERN
-          (block (send nil? {:not_if :only_if}) (args) (send $(const nil? :File) {:exist? :exists?} (...)))
-          PATTERN
-
-          def on_block(node)
-            unscoped_file_exist?(node) do |m|
-              add_offense(m, severity: :refactor) do |corrector|
-                corrector.replace(m, '::File')
-              end
-            end
-          end
-        end
-      end
-    end
-  end
-end
+# frozen_string_literal: true
+#
+# Copyright:: Copyright 2019, Chef Software Inc.
+# Author:: Tim Smith (<tsmith84@gmail.com>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Cop
+    module Chef
+      module Correctness
+        # Scope file exist to access the correct `File` class by using `::File.exist?` not `File.exist?`.
+        #
+        # @example
+        #
+        #   ### incorrect
+        #   not_if { File.exist?('/etc/foo/bar') }
+        #
+        #   ### correct
+        #   not_if { ::File.exist?('/etc/foo/bar') }
+        #
+        class ScopedFileExist < Base
+          extend AutoCorrector
+
+          MSG = 'Scope file exist to access the correct File class by using ::File.exist? not File.exist?.'
+
+          def_node_matcher :unscoped_file_exist?, <<-PATTERN
+          (block (send nil? {:not_if :only_if}) (args) (send $(const nil? :File) {:exist? :exists?} (...)))
+          PATTERN
+
+          def on_block(node)
+            unscoped_file_exist?(node) do |m|
+              add_offense(m, severity: :refactor) do |corrector|
+                corrector.replace(m, '::File')
+              end
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/chef/correctness/service_resource.rb

@@ -1,56 +1,56 @@
-# frozen_string_literal: true
-#
-# Copyright:: 2016, Chris Henry
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-module RuboCop
-  module Cop
-    module Chef
-      module Correctness
-        # Use a service resource to start and stop services
-        #
-        # @example when command starts a service
-        #
-        #   ### incorrect
-        #   command "/etc/init.d/mysql start"
-        #   command "/sbin/service/memcached start"
-        #
-        class ServiceResource < Base
-          MSG = 'Use a service resource to start and stop services'
-          RESTRICT_ON_SEND = [:command].freeze
-
-          def_node_matcher :execute_command?, <<-PATTERN
-            (send nil? :command $str)
-          PATTERN
-
-          def on_send(node)
-            execute_command?(node) do |command|
-              if starts_service?(command)
-                add_offense(command, severity: :refactor)
-              end
-            end
-          end
-
-          def starts_service?(cmd)
-            cmd_str = cmd.to_s
-            (cmd_str.include?('/etc/init.d') || ['service ', '/sbin/service ',
-                                                 'start ', 'stop ', 'invoke-rc.d '].any? do |service_cmd|
-               cmd_str.start_with?(service_cmd)
-             end) && %w(start stop restart reload).any? { |a| cmd_str.include?(a) }
-          end
-        end
-      end
-    end
-  end
-end
+# frozen_string_literal: true
+#
+# Copyright:: 2016, Chris Henry
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Cop
+    module Chef
+      module Correctness
+        # Use a service resource to start and stop services
+        #
+        # @example when command starts a service
+        #
+        #   ### incorrect
+        #   command "/etc/init.d/mysql start"
+        #   command "/sbin/service/memcached start"
+        #
+        class ServiceResource < Base
+          MSG = 'Use a service resource to start and stop services'
+          RESTRICT_ON_SEND = [:command].freeze
+
+          def_node_matcher :execute_command?, <<-PATTERN
+            (send nil? :command $str)
+          PATTERN
+
+          def on_send(node)
+            execute_command?(node) do |command|
+              if starts_service?(command)
+                add_offense(command, severity: :refactor)
+              end
+            end
+          end
+
+          def starts_service?(cmd)
+            cmd_str = cmd.to_s
+            (cmd_str.include?('/etc/init.d') || ['service ', '/sbin/service ',
+                                                 'start ', 'stop ', 'invoke-rc.d '].any? do |service_cmd|
+               cmd_str.start_with?(service_cmd)
+             end) && %w(start stop restart reload).any? { |a| cmd_str.include?(a) }
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/chef/correctness/supports_must_be_float.rb

@@ -1,52 +1,52 @@
-# frozen_string_literal: true
-#
-# Copyright:: 2020, Chef Software Inc.
-# Author:: Tim Smith (<tsmith84@gmail.com>)
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-module RuboCop
-  module Cop
-    module Chef
-      module Correctness
-        # Versions used in metadata.rb supports calls should be floats not integers.
-        #
-        # @example
-        #
-        #   ### incorrect
-        #   supports 'redhat', '> 8'
-        #
-        #   ### correct
-        #   supports 'redhat', '> 8.0'
-        #
-        class SupportsMustBeFloat < Base
-          extend RuboCop::Cop::AutoCorrector
-
-          MSG = 'Versions used in metadata.rb supports calls should be floats not integers.'
-          RESTRICT_ON_SEND = [:supports].freeze
-
-          def_node_matcher :supports_with_constraint?, '(send nil? :supports str $str)'
-
-          def on_send(node)
-            supports_with_constraint?(node) do |ver|
-              return if ver.source.include?('.')
-              add_offense(ver, severity: :refactor) do |corrector|
-                corrector.replace(ver, ver.source.gsub(ver.value, (ver.value + '.0')))
-              end
-            end
-          end
-        end
-      end
-    end
-  end
-end
+# frozen_string_literal: true
+#
+# Copyright:: 2020, Chef Software Inc.
+# Author:: Tim Smith (<tsmith84@gmail.com>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Cop
+    module Chef
+      module Correctness
+        # Versions used in metadata.rb supports calls should be floats not integers.
+        #
+        # @example
+        #
+        #   ### incorrect
+        #   supports 'redhat', '> 8'
+        #
+        #   ### correct
+        #   supports 'redhat', '> 8.0'
+        #
+        class SupportsMustBeFloat < Base
+          extend RuboCop::Cop::AutoCorrector
+
+          MSG = 'Versions used in metadata.rb supports calls should be floats not integers.'
+          RESTRICT_ON_SEND = [:supports].freeze
+
+          def_node_matcher :supports_with_constraint?, '(send nil? :supports str $str)'
+
+          def on_send(node)
+            supports_with_constraint?(node) do |ver|
+              return if ver.source.include?('.')
+              add_offense(ver, severity: :refactor) do |corrector|
+                corrector.replace(ver, ver.source.gsub(ver.value, (ver.value + '.0')))
+              end
+            end
+          end
+        end
+      end
+    end
+  end
+end