cookstyle 7.32.2 → 7.32.8

Sign up to get free protection for your applications and to get access to all the features.
Files changed (262) hide show
  1. checksums.yaml +4 -4
  2. data/bin/cookstyle +6 -1
  3. data/config/chefstyle.yml +741 -0
  4. data/config/cookstyle.yml +46 -46
  5. data/config/default.yml +0 -2
  6. data/lib/cookstyle/chefstyle.rb +5 -0
  7. data/lib/cookstyle/version.rb +1 -1
  8. data/lib/cookstyle.rb +7 -15
  9. data/lib/rubocop/cop/chef/correctness/block_guard_clause_string_only.rb +2 -2
  10. data/lib/rubocop/cop/chef/correctness/chef_application_fatal.rb +2 -2
  11. data/lib/rubocop/cop/chef/correctness/conditional_ruby_shellout.rb +2 -2
  12. data/lib/rubocop/cop/chef/correctness/dnf_package_allow_downgrades.rb +2 -2
  13. data/lib/rubocop/cop/chef/correctness/incorrect_library_injection.rb +2 -2
  14. data/lib/rubocop/cop/chef/correctness/invalid_cookbook_name.rb +2 -2
  15. data/lib/rubocop/cop/chef/correctness/invalid_default_action.rb +2 -2
  16. data/lib/rubocop/cop/chef/correctness/invalid_notification_resource.rb +2 -2
  17. data/lib/rubocop/cop/chef/correctness/invalid_notification_timing.rb +2 -2
  18. data/lib/rubocop/cop/chef/correctness/invalid_platform_family_helper.rb +2 -2
  19. data/lib/rubocop/cop/chef/correctness/invalid_platform_family_values_in_case.rb +1 -1
  20. data/lib/rubocop/cop/chef/correctness/invalid_platform_helper.rb +2 -2
  21. data/lib/rubocop/cop/chef/correctness/invalid_platform_metadata.rb +2 -2
  22. data/lib/rubocop/cop/chef/correctness/invalid_platform_values_in_case.rb +1 -1
  23. data/lib/rubocop/cop/chef/correctness/invalid_value_for_platform_family_helper.rb +2 -2
  24. data/lib/rubocop/cop/chef/correctness/invalid_value_for_platform_helper.rb +2 -2
  25. data/lib/rubocop/cop/chef/correctness/invalid_version_metadata.rb +2 -2
  26. data/lib/rubocop/cop/chef/correctness/lazy_eval_node_attribute_defaults.rb +2 -2
  27. data/lib/rubocop/cop/chef/correctness/lazy_in_resource_guard.rb +2 -2
  28. data/lib/rubocop/cop/chef/correctness/macos_userdefaults_invalid_type.rb +2 -2
  29. data/lib/rubocop/cop/chef/correctness/malformed_value_for_platform.rb +2 -2
  30. data/lib/rubocop/cop/chef/correctness/metadata_malformed_version.rb +2 -2
  31. data/lib/rubocop/cop/chef/correctness/metadata_missing_name.rb +1 -1
  32. data/lib/rubocop/cop/chef/correctness/metadata_missing_version.rb +1 -1
  33. data/lib/rubocop/cop/chef/correctness/node_normal.rb +2 -2
  34. data/lib/rubocop/cop/chef/correctness/node_normal_unless.rb +2 -2
  35. data/lib/rubocop/cop/chef/correctness/node_save.rb +1 -1
  36. data/lib/rubocop/cop/chef/correctness/notifies_action_not_symbol.rb +2 -2
  37. data/lib/rubocop/cop/chef/correctness/octal_mode_as_string.rb +2 -2
  38. data/lib/rubocop/cop/chef/correctness/openssl_password_helpers.rb +1 -1
  39. data/lib/rubocop/cop/chef/correctness/powershell_delete_file.rb +2 -2
  40. data/lib/rubocop/cop/chef/correctness/powershell_file_exists.rb +2 -2
  41. data/lib/rubocop/cop/chef/correctness/property_without_type.rb +2 -2
  42. data/lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb +2 -2
  43. data/lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb +2 -2
  44. data/lib/rubocop/cop/chef/correctness/resource_with_none_action.rb +2 -2
  45. data/lib/rubocop/cop/chef/correctness/scoped_file_exist.rb +2 -2
  46. data/lib/rubocop/cop/chef/correctness/service_resource.rb +1 -1
  47. data/lib/rubocop/cop/chef/correctness/supports_must_be_float.rb +2 -2
  48. data/lib/rubocop/cop/chef/correctness/tmp_path.rb +2 -2
  49. data/lib/rubocop/cop/chef/deprecation/cb_depends_on_self.rb +2 -2
  50. data/lib/rubocop/cop/chef/deprecation/chef_handler_recipe.rb +1 -1
  51. data/lib/rubocop/cop/chef/deprecation/chef_handler_supports.rb +2 -2
  52. data/lib/rubocop/cop/chef/deprecation/chef_rest.rb +1 -1
  53. data/lib/rubocop/cop/chef/deprecation/chef_shellout.rb +2 -2
  54. data/lib/rubocop/cop/chef/deprecation/chef_sugar_helpers.rb +1 -1
  55. data/lib/rubocop/cop/chef/deprecation/chef_windows_platform_helper.rb +2 -2
  56. data/lib/rubocop/cop/chef/deprecation/chefdk_generators.rb +2 -2
  57. data/lib/rubocop/cop/chef/deprecation/chefspec_coverage_report.rb +1 -1
  58. data/lib/rubocop/cop/chef/deprecation/chefspec_legacy_runner.rb +2 -2
  59. data/lib/rubocop/cop/chef/deprecation/chocolatey_package_uninstall_action.rb +2 -2
  60. data/lib/rubocop/cop/chef/deprecation/depends_chef_nginx_cookbook.rb +2 -2
  61. data/lib/rubocop/cop/chef/deprecation/depends_chef_reporting_cookbook.rb +1 -1
  62. data/lib/rubocop/cop/chef/deprecation/depends_compat_resource.rb +1 -1
  63. data/lib/rubocop/cop/chef/deprecation/depends_omnibus_updater_cookbook.rb +2 -2
  64. data/lib/rubocop/cop/chef/deprecation/depends_partial_search.rb +1 -1
  65. data/lib/rubocop/cop/chef/deprecation/depends_poise.rb +1 -1
  66. data/lib/rubocop/cop/chef/deprecation/deprecated_mixins.rb +1 -1
  67. data/lib/rubocop/cop/chef/deprecation/deprecated_platform_methods.rb +2 -2
  68. data/lib/rubocop/cop/chef/deprecation/deprecated_shellout_methods.rb +2 -2
  69. data/lib/rubocop/cop/chef/deprecation/deprecated_sudo_actions.rb +2 -2
  70. data/lib/rubocop/cop/chef/deprecation/deprecated_windows_version_check.rb +1 -1
  71. data/lib/rubocop/cop/chef/deprecation/deprecated_yum_repository_actions.rb +2 -2
  72. data/lib/rubocop/cop/chef/deprecation/deprecated_yum_repository_properties.rb +2 -2
  73. data/lib/rubocop/cop/chef/deprecation/easy_install.rb +1 -1
  74. data/lib/rubocop/cop/chef/deprecation/eol_audit_mode.rb +1 -1
  75. data/lib/rubocop/cop/chef/deprecation/epic_fail.rb +2 -2
  76. data/lib/rubocop/cop/chef/deprecation/erl_call.rb +1 -1
  77. data/lib/rubocop/cop/chef/deprecation/execute_path_property.rb +2 -2
  78. data/lib/rubocop/cop/chef/deprecation/execute_relative_creates_without_cwd.rb +2 -2
  79. data/lib/rubocop/cop/chef/deprecation/foodcritic_testing.rb +1 -1
  80. data/lib/rubocop/cop/chef/deprecation/hwrp_without_provides.rb +4 -4
  81. data/lib/rubocop/cop/chef/deprecation/hwrp_without_unified_mode_true.rb +2 -2
  82. data/lib/rubocop/cop/chef/deprecation/inherits_compat_resource.rb +2 -2
  83. data/lib/rubocop/cop/chef/deprecation/launchd_deprecated_hash_property.rb +2 -2
  84. data/lib/rubocop/cop/chef/deprecation/legacy_notify_syntax.rb +2 -2
  85. data/lib/rubocop/cop/chef/deprecation/legacy_yum_cookbook_recipes.rb +1 -1
  86. data/lib/rubocop/cop/chef/deprecation/librarian_chefspec.rb +1 -1
  87. data/lib/rubocop/cop/chef/deprecation/locale_lc_all_property.rb +1 -1
  88. data/lib/rubocop/cop/chef/deprecation/log_resource_notifications.rb +2 -2
  89. data/lib/rubocop/cop/chef/deprecation/macos_userdefaults_global_property.rb +2 -2
  90. data/lib/rubocop/cop/chef/deprecation/name_property_and_default.rb +2 -2
  91. data/lib/rubocop/cop/chef/deprecation/node_deep_fetch.rb +4 -4
  92. data/lib/rubocop/cop/chef/deprecation/node_methods_not_attributes.rb +2 -2
  93. data/lib/rubocop/cop/chef/deprecation/node_set.rb +2 -2
  94. data/lib/rubocop/cop/chef/deprecation/node_set_unless.rb +2 -2
  95. data/lib/rubocop/cop/chef/deprecation/node_set_without_level.rb +2 -2
  96. data/lib/rubocop/cop/chef/deprecation/partial_search_class_usage.rb +2 -2
  97. data/lib/rubocop/cop/chef/deprecation/partial_search_helper_usage.rb +2 -2
  98. data/lib/rubocop/cop/chef/deprecation/poise_archive.rb +2 -2
  99. data/lib/rubocop/cop/chef/deprecation/policyfile_community_source.rb +2 -2
  100. data/lib/rubocop/cop/chef/deprecation/powershell_cookbook_helpers.rb +2 -2
  101. data/lib/rubocop/cop/chef/deprecation/require_recipe.rb +2 -2
  102. data/lib/rubocop/cop/chef/deprecation/resource_overrides_provides_method.rb +2 -2
  103. data/lib/rubocop/cop/chef/deprecation/resource_uses_dsl_name_method.rb +2 -2
  104. data/lib/rubocop/cop/chef/deprecation/resource_uses_only_resource_name.rb +1 -1
  105. data/lib/rubocop/cop/chef/deprecation/resource_uses_provider_base_method.rb +1 -1
  106. data/lib/rubocop/cop/chef/deprecation/resource_uses_updated_method.rb +2 -2
  107. data/lib/rubocop/cop/chef/deprecation/resource_without_unified_mode_true.rb +2 -2
  108. data/lib/rubocop/cop/chef/deprecation/ruby_27_keyword_argument_warnings.rb +2 -2
  109. data/lib/rubocop/cop/chef/deprecation/ruby_block_create_action.rb +2 -2
  110. data/lib/rubocop/cop/chef/deprecation/run_command_helper.rb +2 -2
  111. data/lib/rubocop/cop/chef/deprecation/search_uses_positional_parameters.rb +2 -2
  112. data/lib/rubocop/cop/chef/deprecation/use_automatic_resource_name.rb +1 -1
  113. data/lib/rubocop/cop/chef/deprecation/use_inline_resources.rb +1 -1
  114. data/lib/rubocop/cop/chef/deprecation/use_yaml_dump.rb +2 -2
  115. data/lib/rubocop/cop/chef/deprecation/user_supports_property.rb +2 -2
  116. data/lib/rubocop/cop/chef/deprecation/verify_property_file_expansion.rb +2 -2
  117. data/lib/rubocop/cop/chef/deprecation/windows_feature_servermanagercmd.rb +2 -2
  118. data/lib/rubocop/cop/chef/deprecation/windows_package_installer_type_string.rb +2 -2
  119. data/lib/rubocop/cop/chef/deprecation/windows_task_change_action.rb +2 -2
  120. data/lib/rubocop/cop/chef/deprecation/windows_version_helpers.rb +2 -2
  121. data/lib/rubocop/cop/chef/deprecation/xml_ruby_recipe.rb +1 -1
  122. data/lib/rubocop/cop/chef/deprecation/yum_dnf_compat_recipe.rb +1 -1
  123. data/lib/rubocop/cop/chef/effortless/chef_vault_used.rb +6 -6
  124. data/lib/rubocop/cop/chef/effortless/data_bags.rb +1 -1
  125. data/lib/rubocop/cop/chef/effortless/depends_chef_vault.rb +1 -1
  126. data/lib/rubocop/cop/chef/effortless/node_environment.rb +1 -1
  127. data/lib/rubocop/cop/chef/effortless/node_policygroup.rb +1 -1
  128. data/lib/rubocop/cop/chef/effortless/node_roles.rb +1 -1
  129. data/lib/rubocop/cop/chef/effortless/search_for_environments_or_roles.rb +1 -1
  130. data/lib/rubocop/cop/chef/effortless/search_used.rb +1 -1
  131. data/lib/rubocop/cop/chef/modernize/action_method_in_resource.rb +2 -2
  132. data/lib/rubocop/cop/chef/modernize/allowed_actions_initializer.rb +2 -2
  133. data/lib/rubocop/cop/chef/modernize/apt_default_recipe.rb +2 -2
  134. data/lib/rubocop/cop/chef/modernize/berksfile_source.rb +2 -2
  135. data/lib/rubocop/cop/chef/modernize/build_essential.rb +2 -2
  136. data/lib/rubocop/cop/chef/modernize/chef_14_resources.rb +1 -1
  137. data/lib/rubocop/cop/chef/modernize/chef_15_resources.rb +1 -1
  138. data/lib/rubocop/cop/chef/modernize/chef_gem_nokogiri.rb +1 -1
  139. data/lib/rubocop/cop/chef/modernize/class_eval_action_class.rb +2 -2
  140. data/lib/rubocop/cop/chef/modernize/compile_time_resources.rb +2 -2
  141. data/lib/rubocop/cop/chef/modernize/conditional_using_test.rb +2 -2
  142. data/lib/rubocop/cop/chef/modernize/cron_d_file_or_template.rb +2 -2
  143. data/lib/rubocop/cop/chef/modernize/cron_manage_resource.rb +2 -2
  144. data/lib/rubocop/cop/chef/modernize/databag_helpers.rb +2 -2
  145. data/lib/rubocop/cop/chef/modernize/declare_action_class.rb +2 -2
  146. data/lib/rubocop/cop/chef/modernize/default_action_initializer.rb +3 -3
  147. data/lib/rubocop/cop/chef/modernize/defines_chefspec_matchers.rb +1 -1
  148. data/lib/rubocop/cop/chef/modernize/depends_chef_vault_cookbook.rb +1 -1
  149. data/lib/rubocop/cop/chef/modernize/depends_chocolatey_cookbooks.rb +1 -1
  150. data/lib/rubocop/cop/chef/modernize/depends_kernel_module_cookbook.rb +1 -1
  151. data/lib/rubocop/cop/chef/modernize/depends_locale_cookbook.rb +1 -1
  152. data/lib/rubocop/cop/chef/modernize/depends_openssl_cookbook.rb +1 -1
  153. data/lib/rubocop/cop/chef/modernize/depends_timezone_lwrp_cookbook.rb +1 -1
  154. data/lib/rubocop/cop/chef/modernize/depends_windows_firewall_cookbook.rb +1 -1
  155. data/lib/rubocop/cop/chef/modernize/depends_zypper_cookbook.rb +1 -1
  156. data/lib/rubocop/cop/chef/modernize/dsl_include_in_resource.rb +1 -1
  157. data/lib/rubocop/cop/chef/modernize/empty_resource_initialize.rb +1 -1
  158. data/lib/rubocop/cop/chef/modernize/execute_apt_update.rb +2 -2
  159. data/lib/rubocop/cop/chef/modernize/execute_sc_exe.rb +2 -2
  160. data/lib/rubocop/cop/chef/modernize/execute_sleep.rb +2 -2
  161. data/lib/rubocop/cop/chef/modernize/execute_sysctl.rb +2 -2
  162. data/lib/rubocop/cop/chef/modernize/execute_tzutil.rb +2 -2
  163. data/lib/rubocop/cop/chef/modernize/foodcritic_comments.rb +1 -1
  164. data/lib/rubocop/cop/chef/modernize/if_provides_default_action.rb +2 -2
  165. data/lib/rubocop/cop/chef/modernize/includes_mixin_shellout.rb +1 -1
  166. data/lib/rubocop/cop/chef/modernize/libarchive_file.rb +2 -2
  167. data/lib/rubocop/cop/chef/modernize/macos_user_defaults.rb +2 -2
  168. data/lib/rubocop/cop/chef/modernize/minitest_handler_usage.rb +1 -1
  169. data/lib/rubocop/cop/chef/modernize/node_init_package.rb +2 -2
  170. data/lib/rubocop/cop/chef/modernize/node_roles_include.rb +2 -2
  171. data/lib/rubocop/cop/chef/modernize/ohai_default_recipe.rb +1 -1
  172. data/lib/rubocop/cop/chef/modernize/openssl_rsa_key_resource.rb +2 -2
  173. data/lib/rubocop/cop/chef/modernize/openssl_x509_resource.rb +2 -2
  174. data/lib/rubocop/cop/chef/modernize/osx_config_profile_resource.rb +2 -2
  175. data/lib/rubocop/cop/chef/modernize/powershell_expand_archive.rb +1 -1
  176. data/lib/rubocop/cop/chef/modernize/powershell_guard_interpreter.rb +2 -2
  177. data/lib/rubocop/cop/chef/modernize/powershell_install_package.rb +2 -2
  178. data/lib/rubocop/cop/chef/modernize/powershell_install_windowsfeature.rb +2 -2
  179. data/lib/rubocop/cop/chef/modernize/property_with_name_attribute.rb +2 -2
  180. data/lib/rubocop/cop/chef/modernize/provides_initializer.rb +2 -2
  181. data/lib/rubocop/cop/chef/modernize/resource_name_initializer.rb +2 -2
  182. data/lib/rubocop/cop/chef/modernize/resource_set_or_return.rb +2 -2
  183. data/lib/rubocop/cop/chef/modernize/resource_with_attributes.rb +2 -2
  184. data/lib/rubocop/cop/chef/modernize/respond_to_compile_time.rb +2 -2
  185. data/lib/rubocop/cop/chef/modernize/respond_to_metadata.rb +2 -2
  186. data/lib/rubocop/cop/chef/modernize/respond_to_provides.rb +2 -2
  187. data/lib/rubocop/cop/chef/modernize/respond_to_resource_name.rb +2 -2
  188. data/lib/rubocop/cop/chef/modernize/sc_windows_resource.rb +2 -2
  189. data/lib/rubocop/cop/chef/modernize/seven_zip_archive.rb +1 -1
  190. data/lib/rubocop/cop/chef/modernize/shell_out_helper.rb +2 -2
  191. data/lib/rubocop/cop/chef/modernize/shellouts_to_chocolatey.rb +1 -1
  192. data/lib/rubocop/cop/chef/modernize/simplify_apt_ppa_setup.rb +2 -2
  193. data/lib/rubocop/cop/chef/modernize/sysctl_param_resource.rb +2 -2
  194. data/lib/rubocop/cop/chef/modernize/unnecessary_mixlib_shellout_require.rb +1 -1
  195. data/lib/rubocop/cop/chef/modernize/use_chef_language_cloud_helpers.rb +2 -2
  196. data/lib/rubocop/cop/chef/modernize/use_chef_language_env_helpers.rb +2 -2
  197. data/lib/rubocop/cop/chef/modernize/use_chef_language_systemd_helper.rb +2 -2
  198. data/lib/rubocop/cop/chef/modernize/use_multipackage_installs.rb +2 -2
  199. data/lib/rubocop/cop/chef/modernize/use_require_relative.rb +2 -2
  200. data/lib/rubocop/cop/chef/modernize/whyrun_supported_true.rb +1 -1
  201. data/lib/rubocop/cop/chef/modernize/windows_default_recipe.rb +1 -1
  202. data/lib/rubocop/cop/chef/modernize/windows_registry_uac.rb +2 -2
  203. data/lib/rubocop/cop/chef/modernize/windows_zipfile.rb +1 -1
  204. data/lib/rubocop/cop/chef/modernize/zipfile_resource.rb +1 -1
  205. data/lib/rubocop/cop/chef/modernize/zypper_repo.rb +2 -2
  206. data/lib/rubocop/cop/chef/redundant/apt_repository_distribution_default.rb +2 -2
  207. data/lib/rubocop/cop/chef/redundant/apt_repository_notifies_apt_update.rb +2 -2
  208. data/lib/rubocop/cop/chef/redundant/attribute_metadata.rb +1 -1
  209. data/lib/rubocop/cop/chef/redundant/conflicts_metadata.rb +1 -1
  210. data/lib/rubocop/cop/chef/redundant/custom_resource_with_allowed_actions.rb +1 -1
  211. data/lib/rubocop/cop/chef/redundant/double_compile_time.rb +2 -2
  212. data/lib/rubocop/cop/chef/redundant/grouping_metadata.rb +1 -1
  213. data/lib/rubocop/cop/chef/redundant/long_description_metadata.rb +1 -1
  214. data/lib/rubocop/cop/chef/redundant/multiple_platform_checks.rb +2 -2
  215. data/lib/rubocop/cop/chef/redundant/name_property_and_required.rb +2 -2
  216. data/lib/rubocop/cop/chef/redundant/ohai_attribute_to_string.rb +2 -2
  217. data/lib/rubocop/cop/chef/redundant/property_splat_regex.rb +2 -2
  218. data/lib/rubocop/cop/chef/redundant/property_with_default_and_required.rb +2 -2
  219. data/lib/rubocop/cop/chef/redundant/provides_metadata.rb +1 -1
  220. data/lib/rubocop/cop/chef/redundant/recipe_metadata.rb +1 -1
  221. data/lib/rubocop/cop/chef/redundant/replaces_metadata.rb +1 -1
  222. data/lib/rubocop/cop/chef/redundant/resource_with_nothing_action.rb +1 -1
  223. data/lib/rubocop/cop/chef/redundant/sensitive_property_in_resource.rb +1 -1
  224. data/lib/rubocop/cop/chef/redundant/string_property_with_nil_default.rb +2 -2
  225. data/lib/rubocop/cop/chef/redundant/suggests_metadata.rb +1 -1
  226. data/lib/rubocop/cop/chef/redundant/unnecessary_desired_state.rb +2 -2
  227. data/lib/rubocop/cop/chef/redundant/unnecessary_name_property.rb +1 -1
  228. data/lib/rubocop/cop/chef/redundant/use_create_if_missing.rb +2 -2
  229. data/lib/rubocop/cop/chef/security/ssh_private_key.rb +1 -1
  230. data/lib/rubocop/cop/chef/sharing/default_maintainer_metadata.rb +2 -2
  231. data/lib/rubocop/cop/chef/sharing/empty_metadata_field.rb +2 -2
  232. data/lib/rubocop/cop/chef/sharing/include_property_descriptions.rb +2 -2
  233. data/lib/rubocop/cop/chef/sharing/include_resource_descriptions.rb +1 -1
  234. data/lib/rubocop/cop/chef/sharing/include_resource_examples.rb +1 -1
  235. data/lib/rubocop/cop/chef/sharing/insecure_cookbook_url.rb +2 -2
  236. data/lib/rubocop/cop/chef/sharing/invalid_license_string.rb +2 -2
  237. data/lib/rubocop/cop/chef/style/attribute_keys.rb +4 -4
  238. data/lib/rubocop/cop/chef/style/chef_whaaat.rb +2 -2
  239. data/lib/rubocop/cop/chef/style/comment_sentence_spacing.rb +1 -1
  240. data/lib/rubocop/cop/chef/style/comments_copyright_format.rb +2 -2
  241. data/lib/rubocop/cop/chef/style/comments_default_copyright.rb +2 -2
  242. data/lib/rubocop/cop/chef/style/comments_format.rb +2 -2
  243. data/lib/rubocop/cop/chef/style/file_mode.rb +2 -2
  244. data/lib/rubocop/cop/chef/style/immediate_notification_timing.rb +2 -2
  245. data/lib/rubocop/cop/chef/style/include_recipe_with_parentheses.rb +2 -2
  246. data/lib/rubocop/cop/chef/style/negating_only_if.rb +2 -2
  247. data/lib/rubocop/cop/chef/style/overly_complex_supports_depends_metadata.rb +2 -2
  248. data/lib/rubocop/cop/chef/style/simplify_platform_major_version_check.rb +2 -2
  249. data/lib/rubocop/cop/chef/style/true_false_resource_properties.rb +2 -2
  250. data/lib/rubocop/cop/chef/style/unnecessary_os_check.rb +2 -2
  251. data/lib/rubocop/cop/chef/style/unnecessary_platform_case_statement.rb +2 -2
  252. data/lib/rubocop/cop/chef/style/use_platform_helpers.rb +2 -2
  253. data/lib/rubocop/cop/chefstyle/ruby/gemspec_license.rb +55 -0
  254. data/lib/rubocop/cop/chefstyle/ruby/gemspec_require_rubygems.rb +46 -0
  255. data/lib/rubocop/cop/chefstyle/ruby/legacy_powershell_out_methods.rb +36 -0
  256. data/lib/rubocop/cop/chefstyle/ruby/require_net_https.rb +54 -0
  257. data/lib/rubocop/cop/chefstyle/ruby/unless_defined_require.rb +122 -0
  258. data/lib/rubocop/cop/inspec/deprecation/attribute_default.rb +2 -2
  259. data/lib/rubocop/cop/inspec/deprecation/attribute_helper.rb +2 -2
  260. metadata +9 -4
  261. data/config/disable_all.yml +0 -987
  262. data/config/upstream.yml +0 -5132
@@ -0,0 +1,55 @@
1
+ # frozen_string_literal: true
2
+ #
3
+ # Copyright:: Chef Software, Inc.
4
+ # Author:: Tim Smith (<tsmith@chef.io>)
5
+ #
6
+ # Licensed under the Apache License, Version 2.0 (the "License");
7
+ # you may not use this file except in compliance with the License.
8
+ # You may obtain a copy of the License at
9
+ #
10
+ # http://www.apache.org/licenses/LICENSE-2.0
11
+ #
12
+ # Unless required by applicable law or agreed to in writing, software
13
+ # distributed under the License is distributed on an "AS IS" BASIS,
14
+ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15
+ # See the License for the specific language governing permissions and
16
+ # limitations under the License.
17
+ #
18
+
19
+ module RuboCop
20
+ module Cop
21
+ module Chef
22
+ module Ruby
23
+ # All gemspec files should define their license.
24
+ #
25
+ # @example
26
+ #
27
+ # # good
28
+ # spec.license = "Apache-2.0"
29
+ #
30
+ class GemspecLicense < Base
31
+ include RangeHelp
32
+
33
+ MSG = 'All gemspec files should define their license.'
34
+
35
+ def_node_search :license, <<~PATTERN
36
+ (send _ {:license= :licenses=} _)
37
+ PATTERN
38
+
39
+ def_node_search :eval_method, <<~PATTERN
40
+ (send nil? {:eval :instance_eval} ... )
41
+ PATTERN
42
+
43
+ def on_new_investigation
44
+ # exit if we find a license statement or any eval since that usually happens
45
+ # when we have a windows platform gem that evals the main gemspec
46
+ return if license(processed_source.ast).first || eval_method(processed_source.ast).first
47
+
48
+ range = source_range(processed_source.buffer, 1, 0)
49
+ add_offense(range, message: MSG, severity: :warning)
50
+ end
51
+ end
52
+ end
53
+ end
54
+ end
55
+ end
@@ -0,0 +1,46 @@
1
+ # frozen_string_literal: true
2
+ #
3
+ # Copyright:: Chef Software, Inc.
4
+ # Author:: Tim Smith (<tsmith@chef.io>)
5
+ #
6
+ # Licensed under the Apache License, Version 2.0 (the "License");
7
+ # you may not use this file except in compliance with the License.
8
+ # You may obtain a copy of the License at
9
+ #
10
+ # http://www.apache.org/licenses/LICENSE-2.0
11
+ #
12
+ # Unless required by applicable law or agreed to in writing, software
13
+ # distributed under the License is distributed on an "AS IS" BASIS,
14
+ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15
+ # See the License for the specific language governing permissions and
16
+ # limitations under the License.
17
+ #
18
+
19
+ module RuboCop
20
+ module Cop
21
+ module Chef
22
+ module Ruby
23
+ # Rubygems does not need to be required in a Gemspec. It's already loaded out of the box in Ruby now.
24
+ class GemspecRequireRubygems < Base
25
+ extend RuboCop::Cop::AutoCorrector
26
+ include RangeHelp
27
+
28
+ MSG = "Rubygems does not need to be required in a Gemspec. It's already loaded out of the box in Ruby now."
29
+
30
+ def_node_matcher :require_rubygems?, <<-PATTERN
31
+ (send nil? :require (str "rubygems") )
32
+ PATTERN
33
+
34
+ def on_send(node)
35
+ require_rubygems?(node) do |_r|
36
+ node = node.parent if node.parent && node.parent.conditional? # make sure we identify conditionals on the require
37
+ add_offense(node.loc.expression, message: MSG, severity: :refactor) do |corrector|
38
+ corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
39
+ end
40
+ end
41
+ end
42
+ end
43
+ end
44
+ end
45
+ end
46
+ end
@@ -0,0 +1,36 @@
1
+ # frozen_string_literal: true
2
+ #
3
+ # Copyright:: Chef Software, Inc.
4
+ # Author:: Tim Smith (<tsmith@chef.io>)
5
+ #
6
+ # Licensed under the Apache License, Version 2.0 (the "License");
7
+ # you may not use this file except in compliance with the License.
8
+ # You may obtain a copy of the License at
9
+ #
10
+ # http://www.apache.org/licenses/LICENSE-2.0
11
+ #
12
+ # Unless required by applicable law or agreed to in writing, software
13
+ # distributed under the License is distributed on an "AS IS" BASIS,
14
+ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15
+ # See the License for the specific language governing permissions and
16
+ # limitations under the License.
17
+ #
18
+
19
+ module RuboCop
20
+ module Cop
21
+ module Chef
22
+ module Ruby
23
+ # Use powershell_exec!/powershell_exec instead of powershell_out!/powershell_out. The new
24
+ # methods don't spawn 2 shells per shellout and instead use .NET bindings to call PS directly.
25
+ class LegacyPowershellOutMethods < Base
26
+ MSG = 'Use powershell_exec!/powershell_exec instead of the slower legacy powershell_out!/powershell_out methods.'
27
+ RESTRICT_ON_SEND = %i(powershell_out! powershell_out).freeze
28
+
29
+ def on_send(node)
30
+ add_offense(node, message: MSG, severity: :refactor)
31
+ end
32
+ end
33
+ end
34
+ end
35
+ end
36
+ end
@@ -0,0 +1,54 @@
1
+ # frozen_string_literal: true
2
+ #
3
+ # Copyright:: Chef Software, Inc.
4
+ # Author:: Tim Smith (<tsmith@chef.io>)
5
+ #
6
+ # Licensed under the Apache License, Version 2.0 (the "License");
7
+ # you may not use this file except in compliance with the License.
8
+ # You may obtain a copy of the License at
9
+ #
10
+ # http://www.apache.org/licenses/LICENSE-2.0
11
+ #
12
+ # Unless required by applicable law or agreed to in writing, software
13
+ # distributed under the License is distributed on an "AS IS" BASIS,
14
+ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15
+ # See the License for the specific language governing permissions and
16
+ # limitations under the License.
17
+ #
18
+
19
+ module RuboCop
20
+ module Cop
21
+ module Chef
22
+ module Ruby
23
+ # net/https is deprecated and just includes net/http and openssl. We should include those directly instead.
24
+ #
25
+ # @example
26
+ #
27
+ # # bad
28
+ # require 'net/https'
29
+ #
30
+ # # good
31
+ # require 'net/http'
32
+ # require 'openssl'
33
+ #
34
+ class RequireNetHttps < Base
35
+ extend RuboCop::Cop::AutoCorrector
36
+
37
+ MSG = 'net/https is deprecated and just includes net/http and openssl. We should include those directly instead.'
38
+
39
+ def_node_matcher :require_net_https?, <<-PATTERN
40
+ (send nil? :require (str "net/https"))
41
+ PATTERN
42
+
43
+ def on_send(node)
44
+ require_net_https?(node) do
45
+ add_offense(node.loc.expression, message: MSG, severity: :refactor) do |corrector|
46
+ corrector.replace(node, %(require "net/http"\nrequire "openssl"))
47
+ end
48
+ end
49
+ end
50
+ end
51
+ end
52
+ end
53
+ end
54
+ end
@@ -0,0 +1,122 @@
1
+ # frozen_string_literal: true
2
+ #
3
+ # Copyright:: Chef Software, Inc.
4
+ # Author:: Tim Smith (<tsmith@chef.io>)
5
+ #
6
+ # Licensed under the Apache License, Version 2.0 (the "License");
7
+ # you may not use this file except in compliance with the License.
8
+ # You may obtain a copy of the License at
9
+ #
10
+ # http://www.apache.org/licenses/LICENSE-2.0
11
+ #
12
+ # Unless required by applicable law or agreed to in writing, software
13
+ # distributed under the License is distributed on an "AS IS" BASIS,
14
+ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15
+ # See the License for the specific language governing permissions and
16
+ # limitations under the License.
17
+ #
18
+
19
+ module RuboCop
20
+ module Cop
21
+ module Chef
22
+ module Ruby
23
+ # Rubygems is VERY slow to require gems even if they've already been loaded. To work around this
24
+ # wrap your require statement with an `if defined?()` check.
25
+ #
26
+ class UnlessDefinedRequire < Base
27
+ extend RuboCop::Cop::AutoCorrector
28
+
29
+ MSG = "Workaround rubygems slow requires by only running require if the class isn't already defined"
30
+
31
+ REQUIRE_TO_CLASS = {
32
+ 'addressable/uri' => 'Addressable::URI',
33
+ 'appscript' => 'Appscript',
34
+ 'base64' => 'Base64',
35
+ 'benchmark' => 'Benchmark',
36
+ 'cgi' => 'CGI',
37
+ 'chef-utils' => 'ChefUtils::CANARY',
38
+ 'chef-utils/dist' => 'ChefUtils::Dist',
39
+ 'csv' => 'CSV',
40
+ 'digest' => 'Digest',
41
+ 'digest/md5' => 'Digest::MD5',
42
+ 'digest/sha1' => 'Digest::SHA1',
43
+ 'digest/sha2' => 'Digest::SHA2',
44
+ 'droplet_kit' => 'DropletKit',
45
+ 'erb' => 'Erb',
46
+ 'erubis' => 'Erubis',
47
+ 'etc' => 'Etc',
48
+ 'excon' => 'Excon',
49
+ 'faraday' => 'Faraday',
50
+ 'ffi_yajl' => 'FFI_Yajl',
51
+ 'ffi' => 'FFI',
52
+ 'fileutils' => 'FileUtils',
53
+ 'find' => 'Find.find',
54
+ 'forwardable' => 'Forwardable',
55
+ 'ipaddr' => 'IPAddr',
56
+ 'json' => 'JSON',
57
+ 'mime/types' => 'MIME::Types',
58
+ 'mixlib/archive' => 'Mixlib::Archive',
59
+ 'mixlib/cli' => 'Mixlib::CLI',
60
+ 'mixlib/config' => 'Mixlib::Config',
61
+ 'mixlib/shellout' => 'Mixlib::ShellOut',
62
+ 'multi_json' => 'MultiJson',
63
+ 'net/http' => 'Net::HTTP',
64
+ 'net/ssh' => 'Net::SSH',
65
+ 'netaddr' => 'NetAddr',
66
+ 'nokogiri' => 'Nokogiri',
67
+ 'ohai' => 'Ohai::System',
68
+ 'open-uri' => 'OpenURI',
69
+ 'openssl' => 'OpenSSL',
70
+ 'optparse' => 'OptionParser',
71
+ 'ostruct' => 'OpenStruct',
72
+ 'pathname' => 'Pathname',
73
+ 'pp' => 'PP',
74
+ 'rack' => 'Rack',
75
+ 'rbconfig' => 'RbConfig',
76
+ 'retryable' => 'Retryable',
77
+ 'rexml/document' => 'REXML::Document',
78
+ 'rubygems' => 'Gem',
79
+ 'rubygems/package' => 'Gem::Package',
80
+ 'securerandom' => 'SecureRandom',
81
+ 'set' => 'Set',
82
+ 'shellwords' => 'Shellwords',
83
+ 'singleton' => 'Singleton',
84
+ 'socket' => 'Socket',
85
+ 'sslshake' => 'SSLShake',
86
+ 'stringio' => 'StringIO',
87
+ 'tempfile' => 'Tempfile',
88
+ 'thor' => 'Thor',
89
+ 'time' => 'Time.zone_offset',
90
+ 'timeout' => 'Timeout',
91
+ 'tmpdir' => 'Dir.mktmpdir',
92
+ 'tomlrb' => 'Tomlrb',
93
+ 'uri' => 'URI',
94
+ 'webrick' => 'WEBrick',
95
+ 'win32/registry' => 'Win32::Registry',
96
+ 'win32ole' => 'WIN32OLE',
97
+ 'winrm' => 'WinRM::Connection',
98
+ 'yard' => 'YARD',
99
+ 'zip' => 'Zip',
100
+ 'zlib' => 'Zlib',
101
+ 'pastel' => 'Pastel',
102
+ }.freeze
103
+
104
+ def_node_matcher :require?, <<-PATTERN
105
+ (send nil? :require (str $_) )
106
+ PATTERN
107
+
108
+ def on_send(node)
109
+ require?(node) do |r|
110
+ next if node.parent && node.parent.conditional? # catch both if and unless
111
+ next unless REQUIRE_TO_CLASS[r]
112
+
113
+ add_offense(node.loc.expression, message: MSG, severity: :refactor) do |corrector|
114
+ corrector.replace(node.loc.expression, "#{node.source} unless defined?(#{REQUIRE_TO_CLASS[r]})")
115
+ end
116
+ end
117
+ end
118
+ end
119
+ end
120
+ end
121
+ end
122
+ end
@@ -23,10 +23,10 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # login_defs_umask = input('login_defs_umask', default: '077', description: 'Default umask to set in login.defs')
28
28
  #
29
- # #### correct
29
+ # ### correct
30
30
  # login_defs_umask = input('login_defs_umask', value: '077', description: 'Default umask to set in login.defs')
31
31
  #
32
32
  class AttributeDefault < Base
@@ -23,10 +23,10 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # login_defs_umask = attribute('login_defs_umask', value: '077', description: 'Default umask to set in login.defs')
28
28
  #
29
- # #### correct
29
+ # ### correct
30
30
  # login_defs_umask = input('login_defs_umask', value: '077', description: 'Default umask to set in login.defs')
31
31
  #
32
32
  class AttributeHelper < Base
metadata CHANGED
@@ -1,7 +1,7 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: cookstyle
3
3
  version: !ruby/object:Gem::Version
4
- version: 7.32.2
4
+ version: 7.32.8
5
5
  platform: ruby
6
6
  authors:
7
7
  - Thom May
@@ -9,7 +9,7 @@ authors:
9
9
  autorequire:
10
10
  bindir: bin
11
11
  cert_chain: []
12
- date: 2023-03-21 00:00:00.000000000 Z
12
+ date: 2024-02-06 00:00:00.000000000 Z
13
13
  dependencies:
14
14
  - !ruby/object:Gem::Dependency
15
15
  name: rubocop
@@ -38,12 +38,12 @@ files:
38
38
  - LICENSE
39
39
  - bin/cookstyle
40
40
  - bin/cookstyle-profile
41
+ - config/chefstyle.yml
41
42
  - config/cookstyle.yml
42
43
  - config/default.yml
43
- - config/disable_all.yml
44
- - config/upstream.yml
45
44
  - cookstyle.gemspec
46
45
  - lib/cookstyle.rb
46
+ - lib/cookstyle/chefstyle.rb
47
47
  - lib/cookstyle/version.rb
48
48
  - lib/rubocop/chef.rb
49
49
  - lib/rubocop/chef/autocorrect_helpers.rb
@@ -301,6 +301,11 @@ files:
301
301
  - lib/rubocop/cop/chef/style/unnecessary_os_check.rb
302
302
  - lib/rubocop/cop/chef/style/unnecessary_platform_case_statement.rb
303
303
  - lib/rubocop/cop/chef/style/use_platform_helpers.rb
304
+ - lib/rubocop/cop/chefstyle/ruby/gemspec_license.rb
305
+ - lib/rubocop/cop/chefstyle/ruby/gemspec_require_rubygems.rb
306
+ - lib/rubocop/cop/chefstyle/ruby/legacy_powershell_out_methods.rb
307
+ - lib/rubocop/cop/chefstyle/ruby/require_net_https.rb
308
+ - lib/rubocop/cop/chefstyle/ruby/unless_defined_require.rb
304
309
  - lib/rubocop/cop/inspec/deprecation/attribute_default.rb
305
310
  - lib/rubocop/cop/inspec/deprecation/attribute_helper.rb
306
311
  - lib/rubocop/cop/target_chef_version.rb