cookstyle 7.32.2 → 7.32.8

data/lib/rubocop/cop/chef/deprecation/hwrp_without_provides.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   class Chef
         #     class Resource
         #       class UlimitRule < Chef::Resource
@@ -35,7 +35,7 @@ module RuboCop
         #     end
         #   end
         #
-        #   #### incorrect
+        #   ### incorrect
         #   class Chef
         #     class Resource
         #       class UlimitRule < Chef::Resource
@@ -49,7 +49,7 @@ module RuboCop
         #     end
         #   end
         #
-        #  #### correct when Chef Infra Client < 15 (but compatible with 16+ as well)
+        #  ### correct when Chef Infra Client < 15 (but compatible with 16+ as well)
         #   class Chef
         #     class Resource
         #       class UlimitRule < Chef::Resource
@@ -64,7 +64,7 @@ module RuboCop
         #     end
         #   end
         #
-        #  #### correct when Chef Infra Client 16+
+        #  ### correct when Chef Infra Client 16+
         #   class Chef
         #     class Resource
         #       class UlimitRule < Chef::Resource

data/lib/rubocop/cop/chef/deprecation/hwrp_without_unified_mode_true.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #  #### incorrect
+        #  ### incorrect
         #   class Chef
         #     class Resource
         #       class UlimitRule < Chef::Resource
@@ -37,7 +37,7 @@ module RuboCop
         #     end
         #   end
         #
-        #  #### correct
+        #  ### correct
         #   class Chef
         #     class Resource
         #       class UlimitRule < Chef::Resource

data/lib/rubocop/cop/chef/deprecation/inherits_compat_resource.rb

@@ -23,12 +23,12 @@ module RuboCop
         #
         # @example
         #
-        #  #### incorrect
+        #  ### incorrect
         #  class AptUpdate < ChefCompat::Resource
         #    # some resource code
         #  end
         #
-        #  #### correct
+        #  ### correct
         #  class AptUpdate < Chef::Resource
         #    # some resource code
         #  end

data/lib/rubocop/cop/chef/deprecation/launchd_deprecated_hash_property.rb

@@ -23,12 +23,12 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   launchd 'foo' do
         #     hash foo: 'bar'
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   launchd 'foo' do
         #     plist_hash foo: 'bar'
         #   end

data/lib/rubocop/cop/chef/deprecation/legacy_notify_syntax.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   template '/etc/www/configures-apache.conf' do
         #     notifies :restart, resources(service: 'apache')
         #   end
@@ -40,7 +40,7 @@ module RuboCop
         #     subscribes :restart, resources(service: service_name_variable), :immediately
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   template '/etc/www/configures-apache.conf' do
         #     notifies :restart, 'service[apache]'
         #   end

data/lib/rubocop/cop/chef/deprecation/legacy_yum_cookbook_recipes.rb

@@ -25,7 +25,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   include_recipe 'yum::elrepo'
         #   include_recipe 'yum::epel'
         #   include_recipe 'yum::ius'

data/lib/rubocop/cop/chef/deprecation/librarian_chefspec.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   require 'chefspec/librarian'
         #
         class LibrarianChefSpec < Base

data/lib/rubocop/cop/chef/deprecation/locale_lc_all_property.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   locale 'set locale' do
         #     lang 'en_gb.utf-8'
         #     lc_all 'en_gb.utf-8'

data/lib/rubocop/cop/chef/deprecation/log_resource_notifications.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   template '/etc/foo' do
         #     source 'bar.erb'
         #     notifies :write, 'log[Aggregate notifications using a single log resource]', :immediately
@@ -33,7 +33,7 @@ module RuboCop
         #     notifies :restart, 'service[foo]', :delayed
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   template '/etc/foo' do
         #     source 'bar.erb'
         #     notifies :run, 'notify_group[Aggregate notifications using a single notify_group resource]', :immediately

data/lib/rubocop/cop/chef/deprecation/macos_userdefaults_global_property.rb

@@ -23,14 +23,14 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   macos_userdefaults 'set a value' do
         #     global true
         #     key 'key'
         #     value 'value'
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   macos_userdefaults 'set a value' do
         #     key 'key'
         #     value 'value'

data/lib/rubocop/cop/chef/deprecation/name_property_and_default.rb

@@ -23,11 +23,11 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   property :config_file, String, default: 'foo', name_property: true
         #   attribute :config_file, String, default: 'foo', name_attribute: true
         #
-        #   #### correct
+        #   ### correct
         #   property :config_file, String, name_property: true
         #   attribute :config_file, String, name_attribute: true
         #

data/lib/rubocop/cop/chef/deprecation/node_deep_fetch.rb

@@ -22,16 +22,16 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   node.deep_fetch("foo")
         #
-        #   #### correct
+        #   ### correct
         #   node.read("foo")
         #
-        #   #### incorrect
+        #   ### incorrect
         #   node.deep_fetch!("foo")
         #
-        #   #### correct
+        #   ### correct
         #   node.read!("foo")
         #
         class NodeDeepFetch < Base

data/lib/rubocop/cop/chef/deprecation/node_methods_not_attributes.rb

@@ -23,14 +23,14 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   node.fqdn
         #   node.platform
         #   node.platform_family
         #   node.platform_version
         #   node.hostname
         #
-        #   #### correct
+        #   ### correct
         #   node['fqdn']
         #   node['platform']
         #   node['platform_family']

data/lib/rubocop/cop/chef/deprecation/node_set.rb

@@ -24,10 +24,10 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   node.set['foo'] = true
         #
-        #   #### correct
+        #   ### correct
         #   node.normal['foo'] = true
         #
         class NodeSet < Base

data/lib/rubocop/cop/chef/deprecation/node_set_unless.rb

@@ -24,10 +24,10 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   node.set_unless['foo'] = true
         #
-        #   #### correct
+        #   ### correct
         #   node.normal_unless['foo'] = true
         #
         class NodeSetUnless < Base

data/lib/rubocop/cop/chef/deprecation/node_set_without_level.rb

@@ -22,13 +22,13 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   node['foo']['bar'] = 1
         #   node['foo']['bar'] << 1
         #   node['foo']['bar'] += 1
         #   node['foo']['bar'] -= 1
         #
-        #   #### correct
+        #   ### correct
         #   node.default['foo']['bar'] = 1
         #   node.default['foo']['bar'] << 1
         #   node.default['foo']['bar'] += 1

data/lib/rubocop/cop/chef/deprecation/partial_search_class_usage.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   ::Chef::PartialSearch.new.search((:node, 'role:web',
         #     keys: { 'name' => [ 'name' ],
         #             'ip' => [ 'ipaddress' ],
@@ -35,7 +35,7 @@ module RuboCop
         #     puts result['kernel_version']
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   search(:node, 'role:web',
         #     filter_result: { 'name' => [ 'name' ],
         #                      'ip' => [ 'ipaddress' ],

data/lib/rubocop/cop/chef/deprecation/partial_search_helper_usage.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   partial_search(:node, 'role:web',
         #     keys: { 'name' => [ 'name' ],
         #             'ip' => [ 'ipaddress' ],
@@ -35,7 +35,7 @@ module RuboCop
         #     puts result['kernel_version']
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   search(:node, 'role:web',
         #     filter_result: { 'name' => [ 'name' ],
         #                      'ip' => [ 'ipaddress' ],

data/lib/rubocop/cop/chef/deprecation/poise_archive.rb

@@ -23,12 +23,12 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   poise_archive 'https://example.com/myapp.tgz' do
         #     destination '/opt/my_app'
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   archive_file 'https://example.com/myapp.tgz' do
         #     destination '/opt/my_app'
         #   end

data/lib/rubocop/cop/chef/deprecation/policyfile_community_source.rb

@@ -23,10 +23,10 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   default_source :community
         #
-        #   #### correct
+        #   ### correct
         #   default_source :supermarket
         #
         class PolicyfileCommunitySource < Base

data/lib/rubocop/cop/chef/deprecation/powershell_cookbook_helpers.rb

@@ -23,10 +23,10 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   Powershell::VersionHelper.powershell_version?('4.0')
         #
-        #   #### correct
+        #   ### correct
         #   node['powershell']['version'].to_f == 4.0
         #
         #   # better (Chef Infra Client 15.8+)

data/lib/rubocop/cop/chef/deprecation/require_recipe.rb

@@ -23,10 +23,10 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   require_recipe 'foo'
         #
-        #   #### correct
+        #   ### correct
         #   include_recipe 'foo'
         #
         class RequireRecipe < Base

data/lib/rubocop/cop/chef/deprecation/resource_overrides_provides_method.rb

@@ -23,12 +23,12 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   def provides?
         #    true
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   provides :SOME_PROVIDER_NAME
         #
         class ResourceOverridesProvidesMethod < Base

data/lib/rubocop/cop/chef/deprecation/resource_uses_dsl_name_method.rb

@@ -23,10 +23,10 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   my_resource = MyResource.dsl_name
         #
-        #   #### correct
+        #   ### correct
         #   my_resource = MyResource.resource_name
         #
         class ResourceUsesDslNameMethod < Base

data/lib/rubocop/cop/chef/deprecation/resource_uses_only_resource_name.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   mycookbook/resources/myresource.rb:
         #   resource_name :mycookbook_myresource
         #

data/lib/rubocop/cop/chef/deprecation/resource_uses_provider_base_method.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   provider_base ::Chef::Provider::SomethingSomething
         #
         class ResourceUsesProviderBaseMethod < Base

data/lib/rubocop/cop/chef/deprecation/resource_uses_updated_method.rb

@@ -23,12 +23,12 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   action :foo do
         #     updated = true
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   action :foo do
         #     converge_by('resource did something') do
         #       # code that causes the resource to converge

data/lib/rubocop/cop/chef/deprecation/resource_without_unified_mode_true.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #  #### incorrect
+        #  ### incorrect
         #   resource_name :foo
         #   provides :foo
         #
@@ -31,7 +31,7 @@ module RuboCop
         #     # some action code
         #   end
         #
-        #  #### correct
+        #  ### correct
         #   resource_name :foo
         #   provides :foo
         #   unified_mode true

data/lib/rubocop/cop/chef/deprecation/ruby_27_keyword_argument_warnings.rb

@@ -23,11 +23,11 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   shell_out!('hostnamectl status', { returns: [0, 1] })
         #   shell_out('hostnamectl status', { returns: [0, 1] })
         #
-        #   #### correct
+        #   ### correct
         #   shell_out!('hostnamectl status', returns: [0, 1])
         #   shell_out('hostnamectl status', returns: [0, 1])
         #

data/lib/rubocop/cop/chef/deprecation/ruby_block_create_action.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   ruby_block 'my special ruby block' do
         #     block do
         #       puts 'running'
@@ -31,7 +31,7 @@ module RuboCop
         #     action :create
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   ruby_block 'my special ruby block' do
         #     block do
         #       puts 'running'

data/lib/rubocop/cop/chef/deprecation/run_command_helper.rb

@@ -23,14 +23,14 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   require 'chef/mixin/command'
         #   include Chef::Mixin::Command
         #
         #   run_command('/bin/foo')
         #   run_command_with_systems_locale('/bin/foo')
         #
-        #   #### correct
+        #   ### correct
         #   shell_out!('/bin/foo')
         #
         class UsesRunCommandHelper < Base

data/lib/rubocop/cop/chef/deprecation/search_uses_positional_parameters.rb

@@ -23,12 +23,12 @@ module RuboCop
         #
         # @example
         #
-        #### incorrect:
+        ### incorrect:
         #  search(:node, '*:*', 0, 1000, { :ip_address => ["ipaddress"] })
         #  search(:node, '*:*', 0, 1000)
         #  search(:node, '*:*', 0)
 
-        #### correct
+        ### correct
         #
         # query(:node, '*:*')
         #  search(:node, '*:*', start: 0, rows: 1000, filter_result: { :ip_address => ["ipaddress"] })

data/lib/rubocop/cop/chef/deprecation/use_automatic_resource_name.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   module MyCookbook
         #     class MyCookbookService < Chef::Resource
         #       use_automatic_resource_name

data/lib/rubocop/cop/chef/deprecation/use_inline_resources.rb

@@ -24,7 +24,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   use_inline_resources
         #   use_inline_resources if defined?(use_inline_resources)
         #   use_inline_resources if respond_to?(:use_inline_resources)

data/lib/rubocop/cop/chef/deprecation/use_yaml_dump.rb

@@ -23,10 +23,10 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   {"foo" => "bar"}.to_yaml
         #
-        #   #### correct
+        #   ### correct
         #   YAML.dump({"foo" => "bar"})
         #
         class UseYamlDump < Base

data/lib/rubocop/cop/chef/deprecation/user_supports_property.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   user "betty" do
         #     supports({
         #       manage_home: true,
@@ -35,7 +35,7 @@ module RuboCop
         #     supports :manage_home => true
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   user "betty" do
         #     manage_home true
         #     non_unique true

data/lib/rubocop/cop/chef/deprecation/verify_property_file_expansion.rb

@@ -23,12 +23,12 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   file '/etc/nginx.conf' do
         #     verify 'nginx -t -c %{file}'
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   file '/etc/nginx.conf' do
         #     verify 'nginx -t -c %{path}'
         #   end

data/lib/rubocop/cop/chef/deprecation/windows_feature_servermanagercmd.rb

@@ -23,12 +23,12 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   windows_feature 'DHCP' do
         #     install_method :servermanagercmd
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   windows_feature 'DHCP' do
         #     install_method :windows_feature_dism
         #   end

data/lib/rubocop/cop/chef/deprecation/windows_package_installer_type_string.rb

@@ -23,14 +23,14 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   windows_package 'AppveyorDeploymentAgent' do
         #     source 'https://www.example.com/appveyor.msi'
         #     installer_type 'msi'
         #     options "/quiet /qn /norestart /log install.log"
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   windows_package 'AppveyorDeploymentAgent' do
         #     source 'https://www.example.com/appveyor.msi'
         #     installer_type :msi

data/lib/rubocop/cop/chef/deprecation/windows_task_change_action.rb

@@ -24,7 +24,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   windows_task 'chef ad-join leave start time' do
         #     task_name 'chef ad-join leave'
         #     start_day '06/09/2016'
@@ -32,7 +32,7 @@ module RuboCop
         #     action [:change, :create]
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   windows_task 'chef ad-join leave start time' do
         #     task_name 'chef ad-join leave'
         #     start_day '06/09/2016'