cookstyle 7.32.2 → 7.32.8

data/lib/rubocop/cop/chef/correctness/node_save.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   node.save
         #
         class CookbookUsesNodeSave < Base

data/lib/rubocop/cop/chef/correctness/notifies_action_not_symbol.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   execute 'some command' do
         #     notifies 'restart', 'service[httpd]', 'delayed'
         #   end
@@ -32,7 +32,7 @@ module RuboCop
         #     subscribes 'restart', 'service[httpd]', 'delayed'
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   execute 'some command' do
         #     notifies :restart, 'service[httpd]', 'delayed'
         #   end

data/lib/rubocop/cop/chef/correctness/octal_mode_as_string.rb

@@ -23,12 +23,12 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   file '/etc/some_file' do
         #     mode '0o755'
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   file '/etc/some_file' do
         #     mode '0755'
         #   end

data/lib/rubocop/cop/chef/correctness/openssl_password_helpers.rb

@@ -21,7 +21,7 @@ module RuboCop
       module Correctness
         # The OpenSSL cookbook provides a deprecated `secure_password` helper in the `Opscode::OpenSSL::Password` class, which should no longer be used. This helper would generate a random password that would be used when a data bag or attribute was no present. The practice of generating passwords to be stored on the node is bad security as it exposes the password to anyone that can view the nodes, and deleting a node deletes the password. Passwords should be retrieved from a secure source for use in cookbooks.
         #
-        #   #### incorrect
+        #   ### incorrect
         #   ::Chef::Recipe.send(:include, Opscode::OpenSSL::Password)
         #   basic_auth_password = secure_password
         #

data/lib/rubocop/cop/chef/correctness/powershell_delete_file.rb

@@ -23,13 +23,13 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   powershell_script 'Cleanup old files' do
         #     code 'Remove-Item C:\Windows\foo\bar.txt'
         #     only_if { ::File.exist?('C:\\Windows\\foo\\bar.txt') }
         #   end
         #
-        #  #### correct
+        #  ### correct
         #  file 'C:\Windows\foo\bar.txt' do
         #    action :delete
         #  end

data/lib/rubocop/cop/chef/correctness/powershell_file_exists.rb

@@ -23,10 +23,10 @@ module RuboCop
         #
         # @example
         #
-        #  #### incorrect
+        #  ### incorrect
         #  powershell_out('Test-Path "C:\\Program Files\\LAPS\\CSE\\AdmPwd.dll"').stdout.strip == 'True'
         #
-        #  #### correct
+        #  ### correct
         #  ::File.exist?('C:\Program Files\LAPS\CSE\AdmPwd.dll')
         #
         class PowershellFileExists < Base

data/lib/rubocop/cop/chef/correctness/property_without_type.rb

@@ -23,11 +23,11 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   property :size, regex: /^\d+[KMGTP]$/
         #   attribute :size, regex: /^\d+[KMGTP]$/
         #
-        #   #### correct
+        #   ### correct
         #   property :size, String, regex: /^\d+[KMGTP]$/
         #   attribute :size, kind_of: String, regex: /^\d+[KMGTP]$/
         #

data/lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb

@@ -23,13 +23,13 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   service 'foo' do
         #     running true
         #     action [:start, :enable]
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   service 'foo' do
         #     action [:start, :enable]
         #   end

data/lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb

@@ -23,12 +23,12 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   service 'foo' do
         #    name 'bar'
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   service 'foo' do
         #    service_name 'bar'
         #   end

data/lib/rubocop/cop/chef/correctness/resource_with_none_action.rb

@@ -23,12 +23,12 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   service 'foo' do
         #    action :none
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   service 'foo' do
         #    action :nothing
         #   end

data/lib/rubocop/cop/chef/correctness/scoped_file_exist.rb

@@ -23,10 +23,10 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   not_if { File.exist?('/etc/foo/bar') }
         #
-        #   #### correct
+        #   ### correct
         #   not_if { ::File.exist?('/etc/foo/bar') }
         #
         class ScopedFileExist < Base

data/lib/rubocop/cop/chef/correctness/service_resource.rb

@@ -22,7 +22,7 @@ module RuboCop
         #
         # @example when command starts a service
         #
-        #   #### incorrect
+        #   ### incorrect
         #   command "/etc/init.d/mysql start"
         #   command "/sbin/service/memcached start"
         #

data/lib/rubocop/cop/chef/correctness/supports_must_be_float.rb

@@ -23,10 +23,10 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   supports 'redhat', '> 8'
         #
-        #   #### correct
+        #   ### correct
         #   supports 'redhat', '> 8.0'
         #
         class SupportsMustBeFloat < Base

data/lib/rubocop/cop/chef/correctness/tmp_path.rb

@@ -22,10 +22,10 @@ module RuboCop
         #
         # @example downloading a large file into /tmp/
         #
-        #   #### incorrect
+        #   ### incorrect
         #   remote_file '/tmp/large-file.tar.gz' do
         #
-        #   #### correct
+        #   ### correct
         #   remote_file "#{Chef::Config[:file_cache_path]}/large-file.tar.gz" do
         #
         class TmpPath < Base

data/lib/rubocop/cop/chef/deprecation/cb_depends_on_self.rb

@@ -23,11 +23,11 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   name 'foo'
         #   depends 'foo'
         #
-        #   #### correct
+        #   ### correct
         #   name 'foo'
         #
         class CookbooksDependsOnSelf < Base

data/lib/rubocop/cop/chef/deprecation/chef_handler_recipe.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   include_recipe 'chef_handler'
         #   include_recipe 'chef_handler::default'
         #

data/lib/rubocop/cop/chef/deprecation/chef_handler_supports.rb

@@ -23,12 +23,12 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   chef_handler 'whatever' do
         #     supports start: true, report: true, exception: true
         #   end0
         #
-        #   #### correct
+        #   ### correct
         #   chef_handler 'whatever' do
         #     type start: true, report: true, exception: true
         #   end

data/lib/rubocop/cop/chef/deprecation/chef_rest.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   require 'chef/rest'
         #   Chef::REST::RESTRequest.new(:GET, FOO, nil).call
         #

data/lib/rubocop/cop/chef/deprecation/chef_shellout.rb

@@ -23,12 +23,12 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   include Chef::ShellOut
         #   require 'chef/shellout'
         #   Chef::ShellOut.new('some_command')
         #
-        #   #### correct
+        #   ### correct
         #   include Mixlib::ShellOut
         #   require 'mixlib/shellout'
         #   Mixlib::ShellOut.new('some_command')

data/lib/rubocop/cop/chef/deprecation/chef_sugar_helpers.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   vagrant_key?
         #   vagrant_domain?
         #   vagrant_user?

data/lib/rubocop/cop/chef/deprecation/chef_windows_platform_helper.rb

@@ -23,10 +23,10 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   Chef::Platform.windows?
         #
-        #   #### correct
+        #   ### correct
         #   platform?('windows')
         #   platform_family?('windows')
         #

data/lib/rubocop/cop/chef/deprecation/chefdk_generators.rb

@@ -23,14 +23,14 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   ChefDK::CLI
         #   ChefDK::Generator::TemplateHelper
         #   module ChefDK
         #     # some additional code
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   ChefCLI::CLI
         #   ChefCLI::Generator::TemplateHelper
         #   module ChefCLI

data/lib/rubocop/cop/chef/deprecation/chefspec_coverage_report.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #
         #   at_exit { ChefSpec::Coverage.report! }
         #

data/lib/rubocop/cop/chef/deprecation/chefspec_legacy_runner.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #
         #   describe 'foo::default' do
         #     subject { ChefSpec::Runner.new.converge(described_recipe) }
@@ -31,7 +31,7 @@ module RuboCop
         #     # some spec code
         #   end
         #
-        #   #### correct
+        #   ### correct
         #
         #   describe 'foo::default' do
         #     subject { ChefSpec::ServerRunner.new.converge(described_recipe) }

data/lib/rubocop/cop/chef/deprecation/chocolatey_package_uninstall_action.rb

@@ -23,12 +23,12 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   chocolatey_package 'nginx' do
         #     action :uninstall
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   chocolatey_package 'nginx' do
         #     action :remove
         #   end

data/lib/rubocop/cop/chef/deprecation/depends_chef_nginx_cookbook.rb

@@ -23,10 +23,10 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   depends 'chef_nginx'
         #
-        #   #### correct
+        #   ### correct
         #   depends 'nginx'
         #
         class DependsOnChefNginxCookbook < Base

data/lib/rubocop/cop/chef/deprecation/depends_chef_reporting_cookbook.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   depends 'chef-reporting'
         #
         class DependsOnChefReportingCookbook < Base

data/lib/rubocop/cop/chef/deprecation/depends_compat_resource.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   depends 'compat_resource'
         #
         class CookbookDependsOnCompatResource < Base

data/lib/rubocop/cop/chef/deprecation/depends_omnibus_updater_cookbook.rb

@@ -23,10 +23,10 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   depends 'omnibus_updater'
         #
-        #   #### correct
+        #   ### correct
         #   depends 'chef_client_updater'
         #
         class DependsOnOmnibusUpdaterCookbook < Base

data/lib/rubocop/cop/chef/deprecation/depends_partial_search.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   depends 'partial_search'
         #
         class CookbookDependsOnPartialSearch < Base

data/lib/rubocop/cop/chef/deprecation/depends_poise.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   depends 'poise'
         #   depends 'poise-service'
         #   depends 'poise-hoist'

data/lib/rubocop/cop/chef/deprecation/deprecated_mixins.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   include Chef::Mixin::LanguageIncludeAttribute
         #   include Chef::Mixin::RecipeDefinitionDSLCore
         #   include Chef::Mixin::LanguageIncludeRecipe

data/lib/rubocop/cop/chef/deprecation/deprecated_platform_methods.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   resource = Chef::Resource::File.new("/tmp/foo.xyz", run_context)
         #   provider = Chef::Platform.provider_for_resource(resource, :create)
         #
@@ -35,7 +35,7 @@ module RuboCop
         #
         #   Chef::Platform.set :platform => :mac_os_x, :resource => :package, :provider => Chef::Provider::Package::Homebrew
         #
-        #   #### correct
+        #   ### correct
         #   resource = Chef::Resource::File.new("/tmp/foo.xyz", run_context)
         #   provider = resource.provider_for_action(:create)
         #

data/lib/rubocop/cop/chef/deprecation/deprecated_shellout_methods.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   shell_out_compact('foo')
         #   shell_out_compact!('foo')
         #   shell_out_with_timeout('foo')
@@ -33,7 +33,7 @@ module RuboCop
         #   shell_out_compact_timeout('foo')
         #   shell_out_compact_timeout!('foo')
         #
-        #   #### correct
+        #   ### correct
         #   shell_out('foo')
         #   shell_out!('foo')
         #   shell_out!('foo', default_env: false) # replaces shell_out_with_systems_locale

data/lib/rubocop/cop/chef/deprecation/deprecated_sudo_actions.rb

@@ -23,14 +23,14 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   sudo 'admins' do
         #     users 'bob'
         #     groups 'sysadmins, superusers'
         #     action :remove
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   sudo 'admins' do
         #     users 'bob'
         #     groups 'sysadmins, superusers'

data/lib/rubocop/cop/chef/deprecation/deprecated_windows_version_check.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   if older_than_win_2012_or_8?
         #     # do some legacy things
         #   end

data/lib/rubocop/cop/chef/deprecation/deprecated_yum_repository_actions.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   yum_repository 'OurCo' do
         #     description 'OurCo yum repository'
         #     baseurl 'http://artifacts.ourco.org/foo/bar'
@@ -31,7 +31,7 @@ module RuboCop
         #     action :add
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   yum_repository 'OurCo' do
         #     description 'OurCo yum repository'
         #     baseurl 'http://artifacts.ourco.org/foo/bar'

data/lib/rubocop/cop/chef/deprecation/deprecated_yum_repository_properties.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   yum_repository 'OurCo' do
         #     description 'OurCo yum repository'
         #     url 'http://artifacts.ourco.org/foo/bar'
@@ -32,7 +32,7 @@ module RuboCop
         #     action :create
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   yum_repository 'OurCo' do
         #     description 'OurCo yum repository'
         #     baseurl 'http://artifacts.ourco.org/foo/bar'

data/lib/rubocop/cop/chef/deprecation/easy_install.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   easy_install "my_thing" do
         #     bar
         #   end

data/lib/rubocop/cop/chef/deprecation/eol_audit_mode.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   control_group 'Baseline' do
         #     control 'SSH' do
         #       it 'should be listening on port 22' do

data/lib/rubocop/cop/chef/deprecation/epic_fail.rb

@@ -23,12 +23,12 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   package "foo" do
         #     epic_fail true
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   package "foo" do
         #     ignore_failure true
         #   end

data/lib/rubocop/cop/chef/deprecation/erl_call.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   erl_call "foo" do
         #     bar
         #   end

data/lib/rubocop/cop/chef/deprecation/execute_path_property.rb

@@ -23,12 +23,12 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   execute 'some_cmd' do
         #     path '/foo/bar'
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   execute 'some_cmd' do
         #     environment {path: '/foo/bar'}
         #   end

data/lib/rubocop/cop/chef/deprecation/execute_relative_creates_without_cwd.rb

@@ -23,12 +23,12 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   execute 'some_cmd' do
         #     creates 'something'
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   execute 'some_cmd' do
         #     creates '/tmp/something'
         #   end

data/lib/rubocop/cop/chef/deprecation/foodcritic_testing.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   gem 'foodcritic'
         #   require 'foodcritic'
         #