cocoapods-core 0.30.0 → 1.15.2

data/lib/cocoapods-core/podfile.rb

@@ -2,18 +2,15 @@ require 'cocoapods-core/podfile/dsl'
 require 'cocoapods-core/podfile/target_definition'
 
 module Pod
-
   # The Podfile is a specification that describes the dependencies of the
   # targets of an Xcode project.
   #
-  # It supports its own DSL and generally is stored in files named
-  # `CocoaPods.podfile` or `Podfile`.
+  # It supports its own DSL and is stored in a file named `Podfile`.
   #
-  # The Podfile creates a hierarchy of target definitions that that store the
-  # information of necessary to generate the CocoaPods libraries.
+  # The Podfile creates a hierarchy of target definitions that store the
+  # information necessary to generate the CocoaPods libraries.
   #
   class Podfile
-
     # @!group DSL support
 
     include Pod::Podfile::DSL
@@ -24,8 +21,8 @@ module Pod
 
     #-------------------------------------------------------------------------#
 
-    # @return [Pathname] the path where the podfile was loaded from. It is nil
-    #         if the podfile was generated programmatically.
+    # @return [Pathname] the path used to load the Podfile. It is nil
+    #         if the Podfile was generated programmatically.
     #
     attr_accessor :defined_in_file
 
@@ -33,7 +30,7 @@ module Pod
     #           the path of the podfile.
     #
     # @param    [Proc] block
-    #           an optional block that configures the podfile through the DSL.
+    #           an optional block that configures the Podfile through the DSL.
     #
     # @example  Creating a Podfile.
     #
@@ -46,8 +43,8 @@ module Pod
       self.defined_in_file = defined_in_file
       @internal_hash = internal_hash
       if block
-        default_target_def = TargetDefinition.new("Pods", self)
-        default_target_def.link_with_first_target = true
+        default_target_def = TargetDefinition.new('Pods', self)
+        default_target_def.abstract = true
         @root_target_definitions = [default_target_def]
         @current_target_definition = default_target_def
         instance_eval(&block)
@@ -60,31 +57,33 @@ module Pod
     #         presented to the user.
     #
     def to_s
-      "Podfile"
+      'Podfile'
     end
 
     #-------------------------------------------------------------------------#
 
     public
 
-    # @!group Working with a podfile
+    # @!group Working with a Podfile
 
     # @return [Hash{Symbol,String => TargetDefinition}] the target definitions
-    #         of the podfile stored by their name.
+    #         of the Podfile stored by their name.
     #
     def target_definitions
       Hash[target_definition_list.map { |td| [td.name, td] }]
     end
 
+    # @return [Array<TargetDefinition>] all target definitions in the Podfile.
+    #
     def target_definition_list
       root_target_definitions.map { |td| [td, td.recursive_children] }.flatten
     end
 
-    # @return [Array<TargetDefinition>] The root target definition.
+    # @return [Array<TargetDefinition>] The root target definitions.
     #
     attr_accessor :root_target_definitions
 
-    # @return [Array<Dependency>] the dependencies of the all the target
+    # @return [Array<Dependency>] the dependencies of all of the target
     #         definitions.
     #
     def dependencies
@@ -97,6 +96,18 @@ module Pod
 
     # @!group Attributes
 
+    # @return [Array<String>] The names of the sources.
+    #
+    def sources
+      get_hash_value('sources') || []
+    end
+
+    # @return [Hash<String, Hash>] The plugins, keyed by name.
+    #
+    def plugins
+      get_hash_value('plugins') || {}
+    end
+
     # @return [String] the path of the workspace if specified by the user.
     #
     def workspace_path
@@ -110,20 +121,28 @@ module Pod
       end
     end
 
-    # @return [Bool] whether the podfile should generate a BridgeSupport
+    # @return [Boolean] whether the podfile should generate a BridgeSupport
     #         metadata document.
     #
     def generate_bridge_support?
       get_hash_value('generate_bridge_support')
     end
 
-    # @return [Bool] whether the -fobjc-arc flag should be added to the
+    # @return [Boolean] whether the -fobjc-arc flag should be added to the
     #         OTHER_LD_FLAGS.
     #
     def set_arc_compatibility_flag?
       get_hash_value('set_arc_compatibility_flag')
     end
 
+    # @return [(String,Hash)] the installation strategy and installation options
+    #         to be used during installation.
+    #
+    def installation_method
+      get_hash_value('installation_method', 'name' => 'cocoapods', 'options' => {}).
+        values_at('name', 'options')
+    end
+
     #-------------------------------------------------------------------------#
 
     public
@@ -135,7 +154,7 @@ module Pod
     # @param  [Pod::Installer] installer
     #         the installer that is performing the installation.
     #
-    # @return [Bool] whether a pre install callback was specified and it was
+    # @return [Boolean] whether a pre install callback was specified and it was
     #         called.
     #
     def pre_install!(installer)
@@ -147,12 +166,29 @@ module Pod
       end
     end
 
+    # Calls the pre integrate callback if defined.
+    #
+    # @param  [Pod::Installer] installer
+    #         the installer that is performing the installation.
+    #
+    # @return [Boolean] whether a pre integrate callback was specified and it was
+    #         called.
+    #
+    def pre_integrate!(installer)
+      if @pre_integrate_callback
+        @pre_integrate_callback.call(installer)
+        true
+      else
+        false
+      end
+    end
+
     # Calls the post install callback if defined.
     #
     # @param  [Pod::Installer] installer
     #         the installer that is performing the installation.
     #
-    # @return [Bool] whether a post install callback was specified and it was
+    # @return [Boolean] whether a post install callback was specified and it was
     #         called.
     #
     def post_install!(installer)
@@ -164,6 +200,23 @@ module Pod
       end
     end
 
+    # Calls the post integrate callback if defined.
+    #
+    # @param  [Pod::Installer] installer
+    #         the installer that is performing the installation.
+    #
+    # @return [Boolean] whether a post install callback was specified and it was
+    #         called.
+    #
+    def post_integrate!(installer)
+      if @post_integrate_callback
+        @post_integrate_callback.call(installer)
+        true
+      else
+        false
+      end
+    end
+
     #-------------------------------------------------------------------------#
 
     public
@@ -173,10 +226,13 @@ module Pod
     # @return [Array] The keys used by the hash representation of the Podfile.
     #
     HASH_KEYS = %w(
-      target_definitions
+      installation_method
       workspace
-      generate_bridge_support
+      sources
+      plugins
       set_arc_compatibility_flag
+      generate_bridge_support
+      target_definitions
     ).freeze
 
     # @return [Hash] The hash representation of the Podfile.
@@ -191,21 +247,40 @@ module Pod
     # @return [String] The YAML representation of the Podfile.
     #
     def to_yaml
-      to_hash.to_yaml
+      require 'cocoapods-core/yaml_helper'
+      "---\n" << YAMLHelper.convert_hash(to_hash, HASH_KEYS)
     end
 
-    #-------------------------------------------------------------------------#
+    # @return [String] The SHA1 digest of the file in which the Podfile
+    #         is defined.
+    #
+    # @return [Nil] If the podfile is not defined in a file.
+    #
+    def checksum
+      @checksum ||= begin
+        unless defined_in_file.nil?
+          require 'digest'
+          checksum = Digest::SHA1.hexdigest(File.read(defined_in_file))
+          checksum = checksum.encode('UTF-8') if checksum.respond_to?(:encode)
+          checksum
+        end
+      end
+    end
 
-    public
+    def ==(other)
+      self.class == other.class &&
+        to_hash == other.to_hash
+    end
 
     # @!group Class methods
+    #-------------------------------------------------------------------------#
 
-    # Initializes a podfile from the file with the given path.
+    # Initializes a Podfile from the file with the given path.
     #
     # @param  [Pathname] path
-    #         the path from where the podfile should be loaded.
+    #         the path from where the Podfile should be loaded.
     #
-    # @return [Podfile] the generated podfile.
+    # @return [Podfile] the generated Podfile.
     #
     def self.from_file(path)
       path = Pathname.new(path)
@@ -214,7 +289,7 @@ module Pod
       end
 
       case path.extname
-      when '', '.podfile'
+      when '', '.podfile', '.rb'
         Podfile.from_ruby(path)
       when '.yaml'
         Podfile.from_yaml(path)
@@ -225,51 +300,59 @@ module Pod
 
     # Configures a new Podfile from the given ruby string.
     #
-    # @param  [String] string
-    #         The ruby string which will configure the podfile with the DSL.
-    #
     # @param  [Pathname] path
     #         The path from which the Podfile is loaded.
     #
+    # @param  [String] contents
+    #         The ruby string which will configure the Podfile with the DSL.
+    #
     # @return [Podfile] the new Podfile
     #
-    def self.from_ruby(path)
-      string = File.open(path, 'r:utf-8') { |f| f.read }
+    def self.from_ruby(path, contents = nil)
+      contents ||= File.open(path, 'r:utf-8', &:read)
+
       # Work around for Rubinius incomplete encoding in 1.9 mode
-      if string.respond_to?(:encoding) && string.encoding.name != "UTF-8"
-        string.encode!('UTF-8')
+      if contents.respond_to?(:encoding) && contents.encoding.name != 'UTF-8'
+        contents.encode!('UTF-8')
+      end
+
+      if contents.tr!('“”‘’‛', %(""'''))
+        # Changes have been made
+        CoreUI.warn "Smart quotes were detected and ignored in your #{path.basename}. " \
+                    'To avoid issues in the future, you should not use ' \
+                    'TextEdit for editing it. If you are not using TextEdit, ' \
+                    'you should turn off smart quotes in your editor of choice.'
       end
+
       podfile = Podfile.new(path) do
+        # rubocop:disable Lint/RescueException
         begin
-          # rubocop:disable Eval
-          eval(string, nil, path.to_s)
-          # rubocop:enable Eval
+          # rubocop:disable Security/Eval
+          eval(contents, nil, path.to_s)
+          # rubocop:enable Security/Eval
         rescue Exception => e
           message = "Invalid `#{path.basename}` file: #{e.message}"
-          raise DSLError.new(message, path, e.backtrace)
+          raise DSLError.new(message, path, e, contents)
         end
+        # rubocop:enable Lint/RescueException
       end
       podfile
     end
 
     # Configures a new Podfile from the given YAML representation.
     #
-    # @param  [String] yaml
-    #         The YAML encoded hash which contains the information of the
-    #         Podfile.
-    #
     # @param  [Pathname] path
     #         The path from which the Podfile is loaded.
     #
     # @return [Podfile] the new Podfile
     #
     def self.from_yaml(path)
-      string = File.open(path, 'r:utf-8') { |f| f.read }
+      string = File.open(path, 'r:utf-8', &:read)
       # Work around for Rubinius incomplete encoding in 1.9 mode
-      if string.respond_to?(:encoding) && string.encoding.name != "UTF-8"
+      if string.respond_to?(:encoding) && string.encoding.name != 'UTF-8'
         string.encode!('UTF-8')
       end
-      hash = YAML.load(string)
+      hash = YAMLHelper.load_string(string)
       from_hash(hash, path)
     end
 
@@ -312,7 +395,7 @@ module Pod
     # @param  [Object] value
     #         The value to store.
     #
-    # @raise  If the key is not recognized.
+    # @raise  [StandardError] If the key is not recognized.
     #
     # @return [void]
     #
@@ -328,15 +411,19 @@ module Pod
     # @param  [String] key
     #         The key for which the value is needed.
     #
-    # @raise  If the key is not recognized.
+    # @param  default
+    #         The default value to return if the internal hash has no entry for
+    #         the given `key`.
+    #
+    # @raise  [StandardError] If the key is not recognized.
     #
     # @return [Object] The value for the key.
     #
-    def get_hash_value(key)
+    def get_hash_value(key, default = nil)
       unless HASH_KEYS.include?(key)
         raise StandardError, "Unsupported hash key `#{key}`"
       end
-      internal_hash[key]
+      internal_hash.fetch(key, default)
     end
 
     # @return [TargetDefinition] The current target definition to which the DSL
@@ -344,20 +431,6 @@ module Pod
     #
     attr_accessor :current_target_definition
 
-    public
-
-    # @!group Deprecations
-    #-------------------------------------------------------------------------#
-
-    # @deprecated Deprecated in favour of the more succinct {#pod}. Remove for
-    #             CocoaPods 1.0.
-    #
-    def dependency(name = nil, *requirements, &block)
-      CoreUI.warn "[DEPRECATED] `dependency' is deprecated (use `pod')"
-      pod(name, *requirements, &block)
-    end
-
     #-------------------------------------------------------------------------#
-
   end
 end

data/lib/cocoapods-core/requirement.rb

@@ -1,5 +1,4 @@
 module Pod
-
   # A Requirement is a set of one or more version restrictions of a
   # {Dependency}.
   #
@@ -10,13 +9,14 @@ module Pod
   #       the Dependency class.
   #
   class Requirement < Pod::Vendor::Gem::Requirement
-
-    quoted_operators = OPS.keys.map { |k| Regexp.quote k }.join "|"
+    quoted_operators = OPS.keys.map { |k| Regexp.quote k }.join '|'
 
     # @return [Regexp] The regular expression used to validate input strings.
     #
     PATTERN = /\A\s*(#{quoted_operators})?\s*(#{Version::VERSION_PATTERN})\s*\z/
 
+    DefaultRequirement = ['>=', Version.new(0)] # rubocop:disable Naming/ConstantName
+
     #-------------------------------------------------------------------------#
 
     # Factory method to create a new requirement.
@@ -47,7 +47,7 @@ module Pod
       new('>= 0')
     end
 
-    # Parses the given object returning an tuple where the first entry is an
+    # Parses the given object returning a tuple where the first entry is an
     # operator and the second a version. If not operator is provided it
     # defaults to `=`.
     #
@@ -57,19 +57,48 @@ module Pod
     # @return [Array] A tuple representing the requirement.
     #
     def self.parse(input)
-      return ["=", input] if input.is_a?(Version)
+      return ['=', input] if input.is_a?(Version)
 
       unless PATTERN =~ input.to_s
         raise ArgumentError, "Illformed requirement `#{input.inspect}`"
       end
 
-      operator = Regexp.last_match[1] || "="
+      operator = Regexp.last_match[1] || '='
       version = Version.new(Regexp.last_match[2])
       [operator, version]
     end
 
-    #-------------------------------------------------------------------------#
+    # Constructs a requirement from `requirements`.
+    #
+    # @param [String, Version, Array<String>, Array<Version>] requirements
+    #        The set of requirements
+    #
+    # @note Duplicate requirements are ignored.
+    #
+    # @note An empty set of `requirements` is the same as `">= 0"`
+    #
+    def initialize(*requirements)
+      requirements = requirements.flatten
+      requirements.compact!
+      requirements.uniq!
 
-  end
+      @requirements = if requirements.empty?
+                        [DefaultRequirement]
+                      else
+                        requirements.map! { |r| self.class.parse r }
+                      end
+    end
 
+    #
+    # @return [Boolean] true if this pod has no requirements.
+    #
+    def none?
+      if @requirements.size == 1
+        @requirements[0] == DefaultRequirement
+      else
+        false
+      end
+    end
+    #-------------------------------------------------------------------------#
+  end
 end

data/lib/cocoapods-core/source/acceptor.rb

@@ -1,12 +1,10 @@
 module Pod
   class Source
-
     # Checks whether a podspec can be accepted by a source. The check takes
     # into account the introduction of 0.0.1 version if there are already
     # tagged ones or whether there is change in the source.
     #
     class Acceptor
-
       # @return [Source] the source where the podspec should be added.
       #
       attr_reader :source
@@ -45,7 +43,7 @@ module Pod
         spec = Specification.from_file(spec_path)
         analyze(spec)
       rescue
-        ["Unable to load the specification."]
+        ['Unable to load the specification.']
       end
 
       private
@@ -61,6 +59,8 @@ module Pod
       # @return [void]
       #
       def check_spec_source_change(spec, errors)
+        require 'cocoapods-core/http'
+
         return unless spec
         return if spec.source[:http]
         return unless reference_spec(spec)
@@ -68,11 +68,15 @@ module Pod
         source = spec.source.values_at(*keys).compact.first
         old_source = reference_spec(spec).source.values_at(*keys).compact.first
         unless source == old_source
-          message = "The source of the spec doesn't match with the recorded "
-          message << "ones. Source: `#{source}`. Previous: `#{old_source}`.\n "
-          message << "Please contact the specs repo maintainers if the"
-          message << "library changed location."
-          errors << message
+          source = HTTP.get_actual_url(source)
+          old_source = HTTP.get_actual_url(old_source)
+          unless source == old_source
+            message = "The source of the spec doesn't match with the recorded "
+            message << "ones. Source: `#{source}`. Previous: `#{old_source}`.\n "
+            message << 'Please contact the specs repo maintainers if the '
+            message << 'library changed location.'
+            errors << message
+          end
         end
       end
 
@@ -90,8 +94,8 @@ module Pod
           s.version != '0.0.1'
         end
         if has_tagged_spec
-          errors << "There is already at least one versioned specification " \
-            "so untagged versions cannot be accepted."
+          errors << 'There is already at least one versioned specification ' \
+            'so untagged versions cannot be accepted.'
         end
       end
 
@@ -104,7 +108,7 @@ module Pod
         return unless previous_spec
         return unless spec.version == Version.new('0.0.1')
         unless spec.source[:commit] == previous_spec.source[:commit]
-          errors << "Attempt to rewrite the commit of a 0.0.1 version."
+          errors << 'Attempt to rewrite the commit of a 0.0.1 version.'
         end
       end
 
@@ -118,7 +122,7 @@ module Pod
           set = source.search(dep)
           unless set && set.specification
             errors << "Unable to find a specification for the `#{dep}` " \
-              "dependency."
+              'dependency.'
           end
         end
       end
@@ -161,7 +165,6 @@ module Pod
       end
 
       #-----------------------------------------------------------------------#
-
     end
   end
 end