cocoapods-core 0.30.0 → 1.15.2

data/lib/cocoapods-core/specification/linter.rb

@@ -1,13 +1,14 @@
+require 'cocoapods-core/specification/linter/result'
+require 'cocoapods-core/specification/linter/analyzer'
+
 module Pod
   class Specification
-
     # The Linter check specifications for errors and warnings.
     #
     # It is designed not only to guarantee the formal functionality of a
     # specification, but also to support the maintenance of sources.
     #
     class Linter
-
       # @return [Specification] the specification to lint.
       #
       attr_reader :spec
@@ -17,6 +18,8 @@ module Pod
       #
       attr_reader :file
 
+      attr_reader :results
+
       # @param  [Specification, Pathname, String] spec_or_path
       #         the Specification or the path of the `podspec` file to lint.
       #
@@ -28,7 +31,7 @@ module Pod
           @file = Pathname.new(spec_or_path)
           begin
             @spec = Specification.from_file(@file)
-          rescue Exception => e
+          rescue => e
             @spec = nil
             @raise_message = e.message
           end
@@ -36,20 +39,21 @@ module Pod
       end
 
       # Lints the specification adding a {Result} for any failed check to the
-      # {#results} list.
+      # {#results} object.
       #
-      # @return [Bool] whether the specification passed validation.
+      # @return [Boolean] whether the specification passed validation.
       #
       def lint
-        @results = []
+        @results = Results.new
         if spec
-          perform_textual_analysis
-          check_required_root_attributes
+          validate_root_name
+          check_required_attributes
+          check_requires_arc_attribute
           run_root_validation_hooks
           perform_all_specs_analysis
         else
-          error "The specification defined in `#{file}` could not be loaded." \
-            "\n\n#{@raise_message}"
+          results.add_error('spec', "The specification defined in `#{file}` "\
+            "could not be loaded.\n\n#{@raise_message}")
         end
         results.empty?
       end
@@ -60,10 +64,6 @@ module Pod
 
       public
 
-      # @return [Array<Result>] all the results generated by the Linter.
-      #
-      attr_reader :results
-
       # @return [Array<Result>] all the errors generated by the Linter.
       #
       def errors
@@ -82,48 +82,58 @@ module Pod
 
       # !@group Lint steps
 
-      # It reads a podspec file and checks for strings corresponding
-      # to features that are or will be deprecated
+      # Checks that the spec's root name matches the filename.
       #
       # @return [void]
       #
-      def perform_textual_analysis
-        return unless @file
-        text = @file.read
-        if text =~ /config\..?os.?/
-          error "`config.ios?` and `config.osx?` are deprecated."
-        end
-        if text =~ /clean_paths/
-          error "clean_paths are deprecated (use preserve_paths)."
+      def validate_root_name
+        if spec.root.name && file
+          acceptable_names = [
+            spec.root.name + '.podspec',
+            spec.root.name + '.podspec.json',
+          ]
+          names_match = acceptable_names.include?(file.basename.to_s)
+          unless names_match
+            results.add_error('name', 'The name of the spec should match the ' \
+                              'name of the file.')
+          end
         end
+      end
 
-        all_lines_count = text.lines.count
-        comments_lines_count = text.scan(/^\s*#\s+/).length
-        comments_ratio = comments_lines_count.fdiv(all_lines_count)
-        if comments_lines_count > 20 && comments_ratio > 0.2
-          warning "Comments must be deleted."
-        end
-        if text.lines.first =~ /^\s*#\s+/
-          warning "Comments placed at the top of the specification must be " \
-            "deleted."
+      # Generates a warning if the requires_arc attribute has true or false string values.
+      #
+      # @return [void]
+      #
+      def check_requires_arc_attribute
+        attribute = DSL.attributes.values.find { |attr| attr.name == :requires_arc }
+        if attribute
+          value = spec.send(attribute.name)
+          if value == 'true' || value == 'false'
+            results.add_warning('requires_arc', value + ' is considered to be the name of a file.')
+          end
         end
       end
 
-      # Checks that every root only attribute which is required has a value.
+      # Checks that every required attribute has a value.
       #
       # @return [void]
       #
-      def check_required_root_attributes
-        attributes = DSL.attributes.values.select(&:root_only?)
+      def check_required_attributes
+        attributes = DSL.attributes.values.select(&:required?)
         attributes.each do |attr|
-          value = spec.send(attr.name)
-          next unless attr.required?
-          unless value && (!value.respond_to?(:empty?) || !value.empty?)
-            if attr.name == :license
-              warning("Missing required attribute `#{attr.name}`.")
-            else
-              error("Missing required attribute `#{attr.name}`.")
+          begin
+            value = spec.send(attr.name)
+            unless value && (!value.respond_to?(:empty?) || !value.empty?)
+              if attr.name == :license
+                results.add_warning('attributes', 'Missing required attribute ' \
+                "`#{attr.name}`.")
+              else
+                results.add_error('attributes', 'Missing required attribute ' \
+                 "`#{attr.name}`.")
+              end
             end
+          rescue => exception
+            results.add_error('attributes', "Unable to parse attribute `#{attr.name}` due to error: #{exception}")
           end
         end
       end
@@ -134,16 +144,10 @@ module Pod
       #
       def run_root_validation_hooks
         attributes = DSL.attributes.values.select(&:root_only?)
-        attributes.each do |attr|
-          validation_hook = "_validate_#{attr.name}"
-          next unless respond_to?(validation_hook, true)
-          value = spec.send(attr.name)
-          next unless value
-          send(validation_hook, value)
-        end
+        run_validation_hooks(attributes, spec)
       end
 
-      # Run validations for multi-platform attributes activating .
+      # Run validations for multi-platform attributes activating.
       #
       # @return [void]
       #
@@ -152,12 +156,12 @@ module Pod
         all_specs.each do |current_spec|
           current_spec.available_platforms.each do |platform|
             @consumer = Specification::Consumer.new(current_spec, platform)
+            results.consumer = @consumer
             run_all_specs_validation_hooks
-            validate_file_patterns
-            check_tmp_arc_not_nil
-            check_if_spec_is_empty
-            check_install_hooks
+            analyzer = Analyzer.new(@consumer, results)
+            results = analyzer.analyze
             @consumer = nil
+            results.consumer = nil
           end
         end
       end
@@ -172,57 +176,81 @@ module Pod
       #
       def run_all_specs_validation_hooks
         attributes = DSL.attributes.values.reject(&:root_only?)
-        attributes.each do |attr|
-          validation_hook = "_validate_#{attr.name}"
-          next unless respond_to?(validation_hook, true)
-          value = consumer.send(attr.name)
-          next unless value
-          send(validation_hook, value)
-        end
+        run_validation_hooks(attributes, consumer)
       end
 
       # Runs the validation hook for each attribute.
       #
       # @note   Hooks are called only if there is a value for the attribute as
       #         required attributes are already checked by the
-      #         {#check_required_root_attributes} step.
+      #         {#check_required_attributes} step.
       #
       # @return [void]
       #
-      # def run_validation_hooks(attributes)
-      #
-      # end
+      def run_validation_hooks(attributes, target)
+        attributes.each do |attr|
+          validation_hook = "_validate_#{attr.name}"
+          next unless respond_to?(validation_hook, true)
+          begin
+            value = target.send(attr.name)
+            next unless value
+            send(validation_hook, value)
+          rescue => e
+            results.add_error(attr.name, "Unable to validate due to exception: #{e}")
+          end
+        end
+      end
 
       #-----------------------------------------------------------------------#
 
       private
 
-      # @!group Root spec validation helpers
-
       # Performs validations related to the `name` attribute.
       #
-      def _validate_name(n)
-        if spec.name && file
-          acceptable_names = [
-            spec.root.name + '.podspec',
-            spec.root.name + '.podspec.json',
-          ]
-          names_match = acceptable_names.include?(file.basename.to_s)
-          unless names_match
-            error "The name of the spec should match the name of the file."
-          end
+      def _validate_name(name)
+        if name =~ %r{/}
+          results.add_error('name', 'The name of a spec should not contain ' \
+                         'a slash.')
+        end
+
+        if name =~ /\s/
+          results.add_error('name', 'The name of a spec should not contain ' \
+                         'whitespace.')
+        end
+
+        if name[0, 1] == '.'
+          results.add_error('name', 'The name of a spec should not begin' \
+          ' with a period.')
+        end
+      end
+
+      # @!group Root spec validation helpers
 
-          if spec.root.name =~ /\s/
-            error "The name of a spec should not contain whitespace."
+      # Performs validations related to the `authors` attribute.
+      #
+      def _validate_authors(a)
+        if a.is_a? Hash
+          if a == { 'YOUR NAME HERE' => 'YOUR EMAIL HERE' }
+            results.add_error('authors', 'The authors have not been updated ' \
+              'from default')
           end
         end
       end
 
+      # Performs validations related to the `version` attribute.
+      #
       def _validate_version(v)
         if v.to_s.empty?
-          error "A version is required."
-        elsif v <= Version::ZERO
-          error "The version of the spec should be higher than 0."
+          results.add_error('version', 'A version is required.')
+        end
+      end
+
+      # Performs validations related to the `module_name` attribute.
+      #
+      def _validate_module_name(m)
+        unless m.nil? || m =~ /^[a-z_][0-9a-z_]*$/i
+          results.add_error('module_name', 'The module name of a spec' \
+            ' should be a valid C99 identifier.')
         end
       end
 
@@ -230,33 +258,37 @@ module Pod
       #
       def _validate_summary(s)
         if s.length > 140
-          warning "The summary should be a short version of `description` " \
-            "(max 140 characters)."
+          results.add_warning('summary', 'The summary should be a short ' \
+            'version of `description` (max 140 characters).')
         end
         if s =~ /A short description of/
-          warning "The summary is not meaningful."
+          results.add_warning('summary', 'The summary is not meaningful.')
         end
       end
 
       # Performs validations related to the `description` attribute.
       #
       def _validate_description(d)
-        if d =~ /An optional longer description of/
-          warning "The description is not meaningful."
-        end
         if d == spec.summary
-          warning "The description is equal to the summary."
+          results.add_warning('description', 'The description is equal to' \
+           ' the summary.')
         end
-        if d.length < spec.summary.length
-          warning "The description is shorter than the summary."
+
+        if d.strip.empty?
+          results.add_error('description', 'The description is empty.')
+        elsif spec.summary && d.length < spec.summary.length
+          results.add_warning('description', 'The description is shorter ' \
+          'than the summary.')
         end
       end
 
       # Performs validations related to the `homepage` attribute.
       #
       def _validate_homepage(h)
+        return unless h.is_a?(String)
         if h =~ %r{http://EXAMPLE}
-          warning "The homepage has not been updated from default"
+          results.add_warning('homepage', 'The homepage has not been updated' \
+           ' from default')
         end
       end
 
@@ -264,7 +296,8 @@ module Pod
       #
       def _validate_frameworks(frameworks)
         if frameworks_invalid?(frameworks)
-          error "A framework should only be specified by its name"
+          results.add_error('frameworks', 'A framework should only be' \
+          ' specified by its name')
         end
       end
 
@@ -272,15 +305,32 @@ module Pod
       #
       def _validate_weak_frameworks(frameworks)
         if frameworks_invalid?(frameworks)
-          error "A weak framework should only be specified by its name"
+          results.add_error('weak_frameworks', 'A weak framework should only be' \
+          ' specified by its name')
         end
       end
 
       # Performs validations related to the `libraries` attribute.
       #
       def _validate_libraries(libs)
-        if libraries_invalid?(libs)
-          error "A library should only be specified by its name"
+        libs.each do |lib|
+          lib = lib.downcase
+          if lib.end_with?('.a') || lib.end_with?('.dylib')
+            results.add_error('libraries', 'Libraries should not include the' \
+            ' extension ' \
+            "(`#{lib}`)")
+          end
+
+          if lib.start_with?('lib')
+            results.add_error('libraries', 'Libraries should omit the `lib`' \
+            ' prefix ' \
+            " (`#{lib}`)")
+          end
+
+          if lib.include?(',')
+            results.add_error('libraries', 'Libraries should not include comas ' \
+            "(`#{lib}`)")
+          end
         end
       end
 
@@ -288,294 +338,245 @@ module Pod
       #
       def _validate_license(l)
         type = l[:type]
+        file = l[:file]
         if type.nil?
-          warning "Missing license type."
+          results.add_warning('license', 'Missing license type.')
         end
-        if type && type.gsub(' ', '').gsub("\n", '').empty?
-          warning "Invalid license type."
+        if type && type.delete(' ').delete("\n").empty?
+          results.add_warning('license', 'Invalid license type.')
         end
         if type && type =~ /\(example\)/
-          error "Sample license type."
+          results.add_error('license', 'Sample license type.')
+        end
+        if file && Pathname.new(file).extname !~ /^(\.(txt|md|markdown|))?$/i
+          results.add_error('license', 'Invalid file type')
         end
       end
 
       # Performs validations related to the `source` attribute.
       #
       def _validate_source(s)
+        return unless s.is_a?(Hash)
         if git = s[:git]
           tag, commit = s.values_at(:tag, :commit)
           version = spec.version.to_s
 
           if git =~ %r{http://EXAMPLE}
-            error "The Git source still contains the example URL."
+            results.add_error('source', 'The Git source still contains the ' \
+            'example URL.')
           end
           if commit && commit.downcase =~ /head/
-            error 'The commit of a Git source cannot be `HEAD`.'
+            results.add_error('source', 'The commit of a Git source cannot be' \
+            ' `HEAD`.')
           end
-          if tag && !tag.include?(version)
-            warning 'The version should be included in the Git tag.'
+          if tag && !tag.to_s.include?(version)
+            results.add_warning('source', 'The version should be included in' \
+             ' the Git tag.')
           end
-
-          if version == '0.0.1'
-            if commit.nil? && tag.nil?
-              error 'Git sources should specify either a commit or a tag.'
-            end
-          else
-            warning 'Git sources should specify a tag.' if tag.nil?
+          if tag.nil?
+            results.add_warning('source', 'Git sources should specify a tag.', true)
           end
         end
 
         perform_github_source_checks(s)
+        check_git_ssh_source(s)
       end
 
-      # Performs validations related to github sources.
+      # Performs validations related to the `deprecated_in_favor_of` attribute.
       #
-      def perform_github_source_checks(s)
-        supported_domains = [
-          'https://github.com',
-          'https://gist.github.com',
-        ]
-
-        if git = s[:git]
-          is_github = git.include?('github.com')
-          if is_github
-            unless git.end_with?('.git')
-              warning "Github repositories should end in `.git`."
-            end
-            unless supported_domains.find { |domain| git.start_with?(domain) }
-              warning "Github repositories should use `https` link."
-            end
-          end
+      def _validate_deprecated_in_favor_of(d)
+        if spec.root.name == Specification.root_name(d)
+          results.add_error('deprecated_in_favor_of', 'a spec cannot be ' \
+            'deprecated in favor of itself')
         end
       end
 
-      #-----------------------------------------------------------------------#
-
-      # @!group All specs validation helpers
+      # Performs validations related to the `test_type` attribute.
+      #
+      def _validate_test_type(t)
+        supported_test_types = Specification::DSL::SUPPORTED_TEST_TYPES.map(&:to_s)
+        unless supported_test_types.include?(t.to_s)
+          results.add_error('test_type', "The test type `#{t}` is not supported. " \
+            "Supported test type values are #{supported_test_types}.")
+        end
+      end
 
-      private
+      def _validate_app_host_name(n)
+        unless consumer.requires_app_host?
+          results.add_error('app_host_name', '`requires_app_host` must be set to ' \
+            '`true` when `app_host_name` is specified.')
+        end
 
-      # Performs validations related to the `compiler_flags` attribute.
-      #
-      def _validate_compiler_flags(flags)
-        if flags.join(' ').split(' ').any? { |flag| flag.start_with?('-Wno') }
-          warning "Warnings must not be disabled (`-Wno' compiler flags)."
+        unless consumer.dependencies.map(&:name).include?(n)
+          results.add_error('app_host_name', "The app host name (#{n}) specified by `#{consumer.spec.name}` could " \
+            'not be found. You must explicitly declare a dependency on that app spec.')
         end
       end
 
-      # Checks the attributes that represent file patterns.
-      #
-      # @todo Check the attributes hash directly.
+      # Performs validations related to the `script_phases` attribute.
       #
-      def validate_file_patterns
-        attributes = DSL.attributes.values.select(&:file_patterns?)
-        attributes.each do |attrb|
-          patterns = consumer.send(attrb.name)
-          if patterns.is_a?(Hash)
-            patterns = patterns.values.flatten(1)
+      def _validate_script_phases(s)
+        s.each do |script_phase|
+          keys = script_phase.keys
+          unrecognized_keys = keys - Specification::ALL_SCRIPT_PHASE_KEYS
+          unless unrecognized_keys.empty?
+            results.add_error('script_phases', "Unrecognized option(s) `#{unrecognized_keys.join(', ')}` in script phase `#{script_phase[:name]}`. " \
+              "Available options are `#{Specification::ALL_SCRIPT_PHASE_KEYS.join(', ')}`.")
           end
-          patterns.each do |pattern|
-            if pattern.start_with?('/')
-              error "File patterns must be relative and cannot start with a " \
-                "slash (#{attrb.name})."
-            end
+          missing_required_keys = Specification::SCRIPT_PHASE_REQUIRED_KEYS - keys
+          unless missing_required_keys.empty?
+            results.add_error('script_phases', "Missing required shell script phase options `#{missing_required_keys.join(', ')}` in script phase `#{script_phase[:name]}`.")
+          end
+          unless Specification::EXECUTION_POSITION_KEYS.include?(script_phase[:execution_position])
+            results.add_error('script_phases', "Invalid execution position value `#{script_phase[:execution_position]}` in shell script `#{script_phase[:name]}`. " \
+            "Available options are `#{Specification::EXECUTION_POSITION_KEYS.join(', ')}`.")
           end
         end
       end
 
-      # @todo remove in 0.18 and switch the default to true.
+      # Performs validations related to the `on_demand_resources` attribute.
       #
-      def check_tmp_arc_not_nil
-        if consumer.requires_arc.nil?
-          warning "A value for `requires_arc` should be specified until the " \
-            "migration to a `true` default."
+      def _validate_on_demand_resources(h)
+        h.values.each do |value|
+          unless Specification::ON_DEMAND_RESOURCES_CATEGORY_KEYS.include?(value[:category])
+            results.add_error('on_demand_resources', "Invalid on demand resources category value `#{value[:category]}`. " \
+              "Available options are `#{Specification::ON_DEMAND_RESOURCES_CATEGORY_KEYS.join(', ')}`.")
+          end
         end
       end
 
-      # Check empty subspec attributes
+      # Performs validation related to the `scheme` attribute.
       #
-      def check_if_spec_is_empty
-        methods = %w(source_files resources preserve_paths dependencies vendored_libraries vendored_frameworks)
-        empty_patterns = methods.all? { |m| consumer.send(m).empty? }
-        empty = empty_patterns && consumer.spec.subspecs.empty?
-        if empty
-          error "The #{consumer.spec} spec is empty (no source files, " \
-            "resources, preserve paths, vendored libraries, " \
-              "vendored frameworks, dependencies or subspecs)."
+      def _validate_scheme(s)
+        unless s.empty?
+          if consumer.spec.subspec? && consumer.spec.library_specification?
+            results.add_error('scheme', 'Scheme configuration is not currently supported for subspecs.')
+            return
+          end
+          if s.key?(:launch_arguments) && !s[:launch_arguments].is_a?(Array)
+            results.add_error('scheme', 'Expected an array for key `launch_arguments`.')
+          end
+          if s.key?(:environment_variables) && !s[:environment_variables].is_a?(Hash)
+            results.add_error('scheme', 'Expected a hash for key `environment_variables`.')
+          end
+          if s.key?(:code_coverage) && ![true, false].include?(s[:code_coverage])
+            results.add_error('scheme', 'Expected a boolean for key `code_coverage`.')
+          end
+          if s.key?(:parallelizable) && ![true, false].include?(s[:parallelizable])
+            results.add_error('scheme', 'Expected a boolean for key `parallelizable`.')
+          end
+          if s.key?(:build_configurations) && !s[:build_configurations].is_a?(Hash)
+            results.add_error('scheme', 'Expected a hash for key `build_configurations`.')
+          end
         end
       end
 
-      # Check the hooks
+      # Performs validations related to github sources.
       #
-      def check_install_hooks
-        unless consumer.spec.pre_install_callback.nil?
-          warning "The pre install hook of the specification DSL has been " \
-            "deprecated, use the `resource_bundles` or the " \
-              "`prepare_command` attributes."
+      def perform_github_source_checks(s)
+        require 'uri'
+
+        if git = s[:git]
+          return unless git =~ /^#{URI.regexp}$/
+          git_uri = URI.parse(git)
+          if git_uri.host
+            perform_github_uri_checks(git, git_uri) if git_uri.host.end_with?('github.com')
+          end
         end
+      end
 
-        unless consumer.spec.post_install_callback.nil?
-          warning "The post install hook of the specification DSL has been " \
-            "deprecated, use the `resource_bundles` or the " \
-              " `prepare_command` attributes."
+      def perform_github_uri_checks(git, git_uri)
+        if git_uri.host.start_with?('www.')
+          results.add_warning('github_sources', 'Github repositories should ' \
+            'not use `www` in their URL.')
+        end
+        unless git.end_with?('.git')
+          results.add_warning('github_sources', 'Github repositories ' \
+            'should end in `.git`.')
+        end
+        unless git_uri.scheme == 'https'
+          results.add_warning('github_sources', 'Github repositories ' \
+            'should use an `https` link.', true)
         end
       end
 
-      # Returns whether the frameworks are valid
+      # Performs validations related to SSH sources
       #
-      # @params frameworks [Array<String>]
-      # The frameworks to be validated
+      def check_git_ssh_source(s)
+        if git = s[:git]
+          if git =~ %r{\w+\@(\w|\.)+\:(/\w+)*}
+            results.add_warning('source', 'Git SSH URLs will NOT work for ' \
+              'people behind firewalls configured to only allow HTTP, ' \
+              'therefore HTTPS is preferred.', true)
+          end
+        end
+      end
+
+      # Performs validations related to the `social_media_url` attribute.
       #
-      # @return [Boolean] true if a framework ends in `.framework`
+      def _validate_social_media_url(s)
+        if s =~ %r{https://twitter.com/EXAMPLE}
+          results.add_warning('social_media_url', 'The social media URL has ' \
+            'not been updated from the default.')
+        end
+      end
+
+      # Performs validations related to the `readme` attribute.
       #
-      def frameworks_invalid?(frameworks)
-        frameworks.any? { |framework| framework.end_with?('.framework') }
+      def _validate_readme(s)
+        if s =~ %r{https://www.example.com/README}
+          results.add_warning('readme', 'The readme has ' \
+            'not been updated from the default.')
+        end
       end
 
-      # Returns whether the libraries are valid
+      # Performs validations related to the `changelog` attribute.
       #
-      # @params libs [Array<String>]
-      # The libraries to be validated
+      def _validate_changelog(s)
+        if s =~ %r{https://www.example.com/CHANGELOG}
+          results.add_warning('changelog', 'The changelog has ' \
+            'not been updated from the default.')
+        end
+      end
+
+      # @param [Hash,Object] value
       #
-      # @return [Boolean] true if a library ends with `.a`, `.dylib`, or
-      # starts with `lib`.
-      def libraries_invalid?(libs)
-        libs.any? { |lib| lib.end_with?('.a', '.dylib') || lib.start_with?('lib') }
+      def _validate_info_plist(value)
+        return if value.empty?
+        if consumer.spec.subspec? && consumer.spec.library_specification?
+          results.add_error('info_plist', 'Info.plist configuration is not currently supported for subspecs.')
+        end
       end
 
       #-----------------------------------------------------------------------#
 
-      # !@group Result Helpers
+      # @!group All specs validation helpers
 
       private
 
-      # Adds an error result with the given message.
-      #
-      # @param  [String] message
-      #         The message of the result.
-      #
-      # @return [void]
-      #
-      def error(message)
-        add_result(:error, message)
-      end
-
-      # Adds an warning result with the given message.
-      #
-      # @param  [String] message
-      #         The message of the result.
-      #
-      # @return [void]
+      # Performs validations related to the `compiler_flags` attribute.
       #
-      def warning(message)
-        add_result(:warning, message)
+      def _validate_compiler_flags(flags)
+        if flags.join(' ').split(' ').any? { |flag| flag.start_with?('-Wno') }
+          results.add_warning('compiler_flags', 'Warnings must not be disabled' \
+          '(`-Wno compiler` flags).')
+        end
       end
 
-      # Adds a result of the given type with the given message. If there is a
-      # current platform it is added to the result. If a result with the same
-      # type and the same message is already available the current platform is
-      # added to the existing result.
-      #
-      # @param  [Symbol] type
-      #         The type of the result (`:error`, `:warning`).
+      # Returns whether the frameworks are valid
       #
-      # @param  [String] message
-      #         The message of the result.
+      # @param frameworks [Array<String>]
+      # The frameworks to be validated
       #
-      # @return [void]
+      # @return [Boolean] true if a framework contains any
+      # non-alphanumeric character or includes an extension.
       #
-      def add_result(type, message)
-        result = results.find { |r| r.type == type && r.message == message }
-        unless result
-          result = Result.new(type, message)
-          results << result
-        end
-        result.platforms << consumer.platform_name if consumer
-      end
-
-      #-----------------------------------------------------------------------#
-
-      class Result
-
-        # @return [Symbol] the type of result.
-        #
-        attr_reader :type
-
-        # @return [String] the message associated with result.
-        #
-        attr_reader :message
-
-        # @param [Symbol] type    @see type
-        # @param [String] message @see message
-        #
-        def initialize(type, message)
-          @type    = type
-          @message = message
-          @platforms = []
-        end
-
-        # @return [Array<Platform>] the platforms where this result was
-        #         generated.
-        #
-        attr_reader :platforms
-
-        # @return [String] a string representation suitable for UI output.
-        #
-        def to_s
-          r = "[#{type.to_s.upcase}] #{message}"
-          if platforms != Specification::PLATFORMS
-            platforms_names = platforms.uniq.map do |p|
-              Platform.string_name(p)
-            end
-            r << " [#{platforms_names * ' - '}]" unless platforms.empty?
-          end
-          r
+      def frameworks_invalid?(frameworks)
+        frameworks.any? do |framework|
+          framework_regex = /[^\w\-\+]/
+          framework =~ framework_regex
         end
       end
-
-      #-----------------------------------------------------------------------#
-
     end
   end
 end
-
-      # # TODO
-      # # Converts the resources file patterns to a hash defaulting to the
-      # # resource key if they are defined as an Array or a String.
-      # #
-      # # @param  [String, Array, Hash] value.
-      # #         The value of the attribute as specified by the user.
-      # #
-      # # @return [Hash] the resources.
-      # #
-      # def _prepare_deployment_target(deployment_target)
-      #   unless @define_for_platforms.count == 1
-      #     raise StandardError, "The deployment target must be defined per platform like `s.ios.deployment_target = '5.0'`."
-      #   end
-      #   Version.new(deployment_target)
-      # end
-
-      # # TODO
-      # # Converts the resources file patterns to a hash defaulting to the
-      # # resource key if they are defined as an Array or a String.
-      # #
-      # # @param  [String, Array, Hash] value.
-      # #         The value of the attribute as specified by the user.
-      # #
-      # # @return [Hash] the resources.
-      # #
-      # def _prepare_platform(name_and_deployment_target)
-      #   return nil if name_and_deployment_target.nil?
-      #   if name_and_deployment_target.is_a?(Array)
-      #     name = name_and_deployment_target.first
-      #     deployment_target = name_and_deployment_target.last
-      #   else
-      #     name = name_and_deployment_target
-      #     deployment_target = nil
-      #   end
-      #   unless PLATFORMS.include?(name)
-      #     raise StandardError, "Unsupported platform `#{name}`. The available " \
-      #       "names are `#{PLATFORMS.inspect}`"
-      #   end
-      #   Platform.new(name, deployment_target)
-      # end