cocoapods-core 0.30.0 → 1.15.2

data/lib/cocoapods-core/specification/dsl/deprecations.rb

@@ -1,136 +1,19 @@
 module Pod
   class Specification
     module DSL
-
       # Provides warning and errors for the deprecated attributes of the DSL.
       #
       module Deprecations
-
-        def preferred_dependency=(name)
-          self.default_subspec = name
-          CoreUI.warn "[#{self}] `preferred_dependency` has been renamed "\
-            "to `default_subspec`."
-        end
-
-        def singleton_method_added(method)
-          if method == :pre_install
-            CoreUI.warn "[#{self}] The use of `#{method}` by overriding " \
-              "the method is deprecated."
-            @pre_install_callback = Proc.new do |pod, target_definition|
-              pre_install(pod, target_definition)
-            end
-
-          elsif method == :post_install
-            CoreUI.warn "[#{self}] The use of `#{method}` by overriding the " \
-              "method is deprecated."
-            @post_install_callback = Proc.new do |target_installer|
-              post_install(target_installer)
-            end
-
-          elsif method == :header_mappings
-            raise Informative, "[#{self}] The use of the `header_mappings` " \
-              "hook has been deprecated.\n Use the `header_dir` and the " \
-                "`header_mappings_dir` attributes."
-
-          elsif method == :copy_header_mapping
-            raise Informative, "[#{self}] The use of the " \
-              "`copy_header_mapping` hook has been deprecated.\nUse" \
-                "the `header_dir` and the `header_mappings_dir` attributes."
-          end
-        end
-
-        def documentation=(value)
-          CoreUI.warn "[#{self}] The `documentation` DSL directive of the " \
-            "podspec format has been deprecated."
-        end
-
-        def clean_paths=(value)
-          raise Informative, "[#{self}] Clean paths are deprecated. " \
-            "CocoaPods now cleans unused files by default. Use the " \
-              "`preserve_paths` attribute if needed."
+        DSL.attribute :xcconfig,
+                      :container => Hash,
+                      :inherited => true
+
+        def xcconfig=(value)
+          self.pod_target_xcconfig = value
+          self.user_target_xcconfig = value
+          CoreUI.warn "[#{self}] `xcconfig` has been split into "\
+            '`pod_target_xcconfig` and `user_target_xcconfig`.'
         end
-
-        DEPRECATED_METHODS = [
-          :part_of_dependency=,
-          :part_of=,
-          :exclude_header_search_paths=,
-        ]
-
-        DEPRECATED_METHODS.each do |method|
-          define_method method do |value|
-            raise Informative, "[#{self}] Attribute "\
-              "`#{method.to_s[0..-2]}` has been deprecated."
-          end
-        end
-
-        # @!group Hooks
-        #
-        #   The specification class provides hooks which are called by
-        #   CocoaPods when a Pod is installed.
-
-        #-----------------------------------------------------------------------#
-
-        # This is a convenience method which gets called after all pods have
-        # been downloaded but before they have been installed, and the Xcode
-        # project and related files have been generated. Note that this hook is
-        # called for each Pods library and only for installations where the Pod
-        # is installed.
-        #
-        # This hook should be used to generate and modify the files of the Pod.
-        #
-        # It receives the
-        # [`Pod::Hooks::PodRepresentation`](http://docs.cocoapods.org/cocoapods/pod/hooks/podrepresentation/)
-        # and the
-        # [`Pod::Hooks::LibraryRepresentation`](http://docs.cocoapods.org/cocoapods/pod/hooks/libraryrepresentation/)
-        # instances.
-        #
-        # Override this to, for instance, to run any build script.
-        #
-        # @example
-        #
-        #   spec.pre_install do |pod, target_definition|
-        #     Dir.chdir(pod.root){ `sh make.sh` }
-        #   end
-        #
-        def pre_install(&block)
-          CoreUI.warn "[#{self}] The pre install hook of the specification " \
-            "DSL has been deprecated, use the `resource_bundles` or the " \
-              "`prepare_command` attributes."
-          @pre_install_callback = block
-        end
-
-        # This is a convenience method which gets called after all pods have been
-        # downloaded, installed, and the Xcode project and related files have
-        # been generated. Note that this hook is called for each Pods library and
-        # only for installations where the Pod is installed.
-        #
-        # To modify and generate files for the Pod the pre install hook should be
-        # used instead of this one.
-        #
-        # It receives a
-        # [`Pod::Hooks::LibraryRepresentation`](http://docs.cocoapods.org/cocoapods/pod/hooks/libraryrepresentation/)
-        # instance for the current target.
-        #
-        # Override this to, for instance, add to the prefix header.
-        #
-        # @example
-        #
-        #   spec.post_install do |library_representation|
-        #     prefix_header = library_representation.prefix_header_path
-        #     prefix_header.open('a') do |file|
-        #       file.puts('#ifdef __OBJC__\n#import "SSToolkitDefines.h"\n#endif')
-        #     end
-        #   end
-        #
-        def post_install(&block)
-          CoreUI.warn "[#{self}] The post install hook of the specification " \
-            "DSL has been deprecated, use the `resource_bundles` or the " \
-              "`prepare_command` attributes."
-          @post_install_callback = block
-        end
-
-        #-----------------------------------------------------------------------#
-
       end
     end
   end

data/lib/cocoapods-core/specification/dsl/platform_proxy.rb

@@ -1,12 +1,10 @@
 module Pod
   class Specification
     module DSL
-
       # The PlatformProxy works in conjunction with Specification#_on_platform.
       # It provides support for a syntax like `spec.ios.source_files = 'file'`.
       #
       class PlatformProxy
-
         # @return [Specification] the specification for this platform proxy.
         #
         attr_accessor :spec
@@ -14,13 +12,14 @@ module Pod
         # @return [Symbol] the platform described by this proxy. Can be either
         #         `:ios` or `:osx`.
         #
-        attr_accessor :platform
+        attr_reader :platform
 
         # @param  [Specification] spec @see spec
         # @param  [Symbol] platform @see platform
         #
         def initialize(spec, platform)
-          @spec, @platform = spec, platform
+          @spec = spec
+          @platform = platform
         end
 
         # Defines a setter method for each attribute of the specification
@@ -30,18 +29,16 @@ module Pod
         # @return [void]
         #
         def method_missing(meth, *args, &block)
-          attribute = Specification::DSL.attributes.values.find do |attr|
-            if attr.writer_name.to_sym == meth
-              true
-            elsif attr.writer_singular_form
-              attr.writer_singular_form.to_sym == meth
-            end
-          end
-          if attribute && attribute.multi_platform?
-            spec.store_attribute(attribute.name, args.first, platform)
-          else
-            super
-          end
+          return super unless attribute = attribute_for_method(meth)
+          raise NoMethodError, "#{attribute} cannot be set per-platform" unless attribute.multi_platform?
+          spec.store_attribute(attribute.name, args.first, platform)
+        end
+
+        # @!visibility private
+        #
+        def respond_to_missing?(method, include_all)
+          attribute = attribute_for_method(method)
+          (attribute && attribute.multi_platform?) || super
         end
 
         # Allows to add dependency for the platform.
@@ -52,8 +49,8 @@ module Pod
           name, *version_requirements = args
           platform_name = platform.to_s
           platform_hash = spec.attributes_hash[platform_name] || {}
-          platform_hash["dependencies"] ||= {}
-          platform_hash["dependencies"][name] = version_requirements
+          platform_hash['dependencies'] ||= {}
+          platform_hash['dependencies'][name] = version_requirements
           spec.attributes_hash[platform_name] = platform_hash
         end
 
@@ -63,8 +60,21 @@ module Pod
         #
         def deployment_target=(value)
           platform_name = platform.to_s
-          spec.attributes_hash["platforms"] ||= {}
-          spec.attributes_hash["platforms"][platform_name] = value
+          spec.attributes_hash['platforms'] ||= {}
+          spec.attributes_hash['platforms'][platform_name] = value
+        end
+
+        private
+
+        def attribute_for_method(method)
+          method = method.to_sym
+          Specification::DSL.attributes.values.find do |attribute|
+            if attribute.writer_name.to_sym == method
+              true
+            elsif attribute.writer_singular_form
+              attribute.writer_singular_form.to_sym == method
+            end
+          end
         end
       end
     end