chef 18.8.11 → 18.8.46

data/spec/unit/formatters/error_inspectors/compile_error_inspector_spec.rb

@@ -1,265 +0,0 @@
-#
-# Author:: Daniel DeLeo (<dan@chef.io>)
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-
-BAD_RECIPE = <<~E.freeze
-  #
-  # Cookbook Name:: syntax-err
-  # Recipe:: default
-  #
-  # Copyright 2012-2016, YOUR_COMPANY_NAME
-  #
-  # All rights reserved - Do Not Redistribute
-  #
-
-
-  file "/tmp/explode-me" do
-    mode 0655
-    owner "root"
-    this_is_not_a_valid_method
-  end
-E
-
-describe Chef::Formatters::ErrorInspectors::CompileErrorInspector do
-
-  let(:node_name) { "test-node.example.com" }
-
-  let(:description) { Chef::Formatters::ErrorDescription.new("Error Evaluating File:") }
-
-  let(:exception) do
-    e = NoMethodError.new("undefined method `this_is_not_a_valid_method' for Chef::Resource::File")
-    e.set_backtrace(trace)
-    e
-  end
-
-  # Change to $stdout to print error messages for manual inspection
-  let(:stdout) { StringIO.new }
-
-  let(:outputter) { Chef::Formatters::IndentableOutputStream.new(StringIO.new, STDERR) }
-
-  subject(:inspector) { described_class.new(path_to_failed_file, exception) }
-
-  describe "finding the code responsible for the error" do
-
-    context "when the stacktrace includes cookbook files" do
-
-      let(:trace) do
-        [
-          "/home/someuser/dev-laptop/cookbooks/syntax-err/recipes/default.rb:14:in `from_file'",
-          "/home/someuser/dev-laptop/cookbooks/syntax-err/recipes/default.rb:11:in `from_file'",
-          "/home/someuser/.multiruby/gems/chef/lib/chef/client.rb:123:in `run'",
-        ]
-      end
-
-      let(:expected_filtered_trace) do
-        [
-          "/home/someuser/dev-laptop/cookbooks/syntax-err/recipes/default.rb:14:in `from_file'",
-          "/home/someuser/dev-laptop/cookbooks/syntax-err/recipes/default.rb:11:in `from_file'",
-        ]
-      end
-
-      let(:path_to_failed_file) { "/home/someuser/dev-laptop/cookbooks/syntax-err/recipes/default.rb" }
-
-      before do
-        # Error inspector originally used file_cache_path which is incorrect on
-        # chef-solo. Using cookbook_path should do the right thing for client and
-        # solo.
-        allow(Chef::Config).to receive(:cookbook_path).and_return([ "/home/someuser/dev-laptop/cookbooks" ])
-      end
-
-      describe "when scrubbing backtraces" do
-        it "shows backtrace lines from cookbook files" do
-          expect(inspector.filtered_bt).to eq(expected_filtered_trace)
-        end
-      end
-
-      describe "when explaining an error in the compile phase" do
-        before do
-          recipe_lines = BAD_RECIPE.split("\n").map { |l| l << "\n" }
-          expect(IO).to receive(:readlines).with(path_to_failed_file).and_return(recipe_lines)
-          inspector.add_explanation(description)
-        end
-
-        it "reports the error was not located within cookbooks" do
-          expect(inspector.found_error_in_cookbooks?).to be(true)
-        end
-
-        it "finds the line number of the error from the stacktrace" do
-          expect(inspector.culprit_line).to eq(14)
-        end
-
-        it "prints a pretty message" do
-          description.display(outputter)
-        end
-      end
-    end
-
-    context "when the error is a RuntimeError about frozen object" do
-      let(:exception) do
-        e = RuntimeError.new("can't modify frozen Array")
-        e.set_backtrace(trace)
-        e
-      end
-
-      let(:path_to_failed_file) { "/tmp/kitchen/cache/cookbooks/foo/recipes/default.rb" }
-
-      let(:trace) do
-        [
-          "/tmp/kitchen/cache/cookbooks/foo/recipes/default.rb:2:in `block in from_file'",
-          "/tmp/kitchen/cache/cookbooks/foo/recipes/default.rb:1:in `from_file'",
-        ]
-      end
-
-      describe "when explaining a runtime error in the compile phase" do
-        it "correctly detects RuntimeError for frozen objects" do
-          expect(inspector.exception_message_modifying_frozen?).to be(true)
-        end
-
-        # could also test for description.section to be called, but would have
-        # to adjust every other test to begin using a test double for description
-      end
-    end
-
-    context "when the error does not contain any lines from cookbooks" do
-
-      let(:trace) do
-        [
-          "/opt/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-10.14.0/lib/chef/run_context.rb:144:in `rescue in block in load_libraries'",
-          "/opt/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-10.14.0/lib/chef/run_context.rb:138:in `block in load_libraries'",
-          "/opt/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-10.14.0/lib/chef/run_context.rb:230:in `call'",
-          "/opt/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-10.14.0/lib/chef/run_context.rb:230:in `block (2 levels) in foreach_cookbook_load_segment'",
-          "/opt/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-10.14.0/lib/chef/run_context.rb:229:in `each'",
-          "/opt/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-10.14.0/lib/chef/run_context.rb:229:in `block in foreach_cookbook_load_segment'",
-          "/opt/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-10.14.0/lib/chef/run_context.rb:227:in `each'",
-          "/opt/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-10.14.0/lib/chef/run_context.rb:227:in `foreach_cookbook_load_segment'",
-          "/opt/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-10.14.0/lib/chef/run_context.rb:137:in `load_libraries'",
-        ]
-      end
-
-      let(:exception) do
-        e = Chef::Exceptions::RecipeNotFound.new("recipe nope:nope not found")
-        e.set_backtrace(trace)
-        e
-      end
-
-      let(:path_to_failed_file) { nil }
-
-      it "gives a full, non-filtered trace" do
-        expect(inspector.filtered_bt).to eq(trace)
-      end
-
-      it "does not error when displaying the error" do
-        expect { description.display(outputter) }.to_not raise_error
-      end
-
-      it "reports the error was not located within cookbooks" do
-        expect(inspector.found_error_in_cookbooks?).to be(false)
-      end
-
-    end
-  end
-
-  describe "when explaining an error on windows" do
-
-    let(:trace_with_upcase_drive) do
-      [
-        "C:/opscode/chef/var/cache/cookbooks/foo/recipes/default.rb:14 in `from_file'",
-        "C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-10.14.0/lib/chef/run_context.rb:144:in `rescue in block in load_libraries'",
-        "C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-10.14.0/lib/chef/run_context.rb:138:in `block in load_libraries'",
-        "C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-10.14.0/lib/chef/run_context.rb:230:in `call'",
-        "C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-10.14.0/lib/chef/run_context.rb:230:in `block (2 levels) in foreach_cookbook_load_segment'",
-        "C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-10.14.0/lib/chef/run_context.rb:229:in `each'",
-        "C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-10.14.0/lib/chef/run_context.rb:229:in `block in foreach_cookbook_load_segment'",
-        "C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-10.14.0/lib/chef/run_context.rb:227:in `each'",
-        "C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-10.14.0/lib/chef/run_context.rb:227:in `foreach_cookbook_load_segment'",
-        "C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-10.14.0/lib/chef/run_context.rb:137:in `load_libraries'",
-        "C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-10.14.0/lib/chef/run_context.rb:62:in `load'",
-        "C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-10.14.0/lib/chef/client.rb:198:in `setup_run_context'",
-        "C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-10.14.0/lib/chef/client.rb:418:in `do_run'",
-        "C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-10.14.0/lib/chef/client.rb:176:in `run'",
-        "C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-10.14.0/lib/chef/application/client.rb:283:in `block in run_application'",
-        "C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-10.14.0/lib/chef/application/client.rb:270:in `loop'",
-        "C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-10.14.0/lib/chef/application/client.rb:270:in `run_application'",
-        "C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-10.14.0/lib/chef/application.rb:70:in `run'",
-        "C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-10.14.0/bin/chef-client:26:in `<top (required)>'",
-        "C:/opscode/chef/bin/chef-client:19:in `load'",
-        "C:/opscode/chef/bin/chef-client:19:in `<main>'",
-      ]
-    end
-
-    let(:trace) { trace_with_upcase_drive }
-
-    let(:path_to_failed_file) { "/var/cache/cookbooks/foo/recipes/default.rb" }
-
-    before do
-      allow(Chef::Config).to receive(:cookbook_path).and_return([ "C:/opscode/chef/var/cache/cookbooks" ])
-      recipe_lines = BAD_RECIPE.split("\n").map { |l| l << "\n" }
-      expect(IO).to receive(:readlines).at_least(1).times.with(full_path_to_failed_file).and_return(recipe_lines)
-      inspector.add_explanation(description)
-    end
-
-    context "when the drive letter in the path is uppercase" do
-
-      let(:full_path_to_failed_file) { "C:/opscode/chef#{path_to_failed_file}" }
-
-      it "reports the error was not located within cookbooks" do
-        expect(inspector.found_error_in_cookbooks?).to be(true)
-      end
-
-      it "finds the culprit recipe name" do
-        expect(inspector.culprit_file).to eq("C:/opscode/chef/var/cache/cookbooks/foo/recipes/default.rb")
-      end
-
-      it "finds the line number of the error from the stack trace" do
-        expect(inspector.culprit_line).to eq(14)
-      end
-
-      it "prints a pretty message" do
-        description.display(outputter)
-      end
-    end
-
-    context "when the drive letter in the path is lowercase" do
-
-      let(:trace) do
-        trace_with_upcase_drive.map { |line| line.gsub(/^C:/, "c:") }
-      end
-
-      let(:full_path_to_failed_file) { "c:/opscode/chef#{path_to_failed_file}" }
-
-      it "reports the error was not located within cookbooks" do
-        expect(inspector.found_error_in_cookbooks?).to be(true)
-      end
-
-      it "finds the culprit recipe name from the stacktrace" do
-        expect(inspector.culprit_file).to eq("c:/opscode/chef/var/cache/cookbooks/foo/recipes/default.rb")
-      end
-
-      it "finds the line number of the error from the stack trace" do
-        expect(inspector.culprit_line).to eq(14)
-      end
-
-      it "prints a pretty message" do
-        description.display(outputter)
-      end
-    end
-
-  end
-
-end

data/spec/unit/formatters/error_inspectors/cookbook_resolve_error_inspector_spec.rb

@@ -1,126 +0,0 @@
-#--
-# Author:: Daniel DeLeo (<dan@chef.io>)
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-
-describe Chef::Formatters::ErrorInspectors::CookbookResolveErrorInspector do
-
-  before do
-    @expanded_run_list = Chef::RunList.new("recipe[annoyances]", "recipe[apache2]", "recipe[users]", "recipe[chef::client]")
-
-    @description = Chef::Formatters::ErrorDescription.new("Error Resolving Cookbooks for Run List:")
-    @outputter_output = StringIO.new
-    @outputter = Chef::Formatters::IndentableOutputStream.new(@outputter_output, STDERR)
-    # @outputter = Chef::Formatters::IndentableOutputStream.new(STDOUT, STDERR)
-  end
-
-  describe "when explaining a 403 error" do
-    before do
-
-      @response_body = %q({"error": [{"message": "gtfo"}])
-      @response = Net::HTTPForbidden.new("1.1", "403", "(response) forbidden")
-      allow(@response).to receive(:body).and_return(@response_body)
-      @exception = Net::HTTPClientException.new("(exception) forbidden", @response)
-
-      @inspector = Chef::Formatters::ErrorInspectors::CookbookResolveErrorInspector.new(@expanded_run_list, @exception)
-      @inspector.add_explanation(@description)
-    end
-
-    it "prints a nice message" do
-      expect { @description.display(@outputter) }.not_to raise_error
-    end
-
-  end
-
-  describe "when explaining a PreconditionFailed (412) error with current error message style" do
-    # Chef currently returns error messages with some fields as JSON strings,
-    # which must be re-parsed to get the actual data.
-
-    before do
-
-      @response_body = "{\"error\":[\"{\\\"non_existent_cookbooks\\\":[\\\"apache2\\\"],\\\"cookbooks_with_no_versions\\\":[\\\"users\\\"],\\\"message\\\":\\\"Run list contains invalid items: no such cookbook nope.\\\"}\"]}"
-      @response = Net::HTTPPreconditionFailed.new("1.1", "412", "(response) unauthorized")
-      allow(@response).to receive(:body).and_return(@response_body)
-      @exception = Net::HTTPClientException.new("(exception) precondition failed", @response)
-
-      @inspector = Chef::Formatters::ErrorInspectors::CookbookResolveErrorInspector.new(@expanded_run_list, @exception)
-      @inspector.add_explanation(@description)
-    end
-
-    it "prints a pretty message" do
-      @description.display(@outputter)
-      @outputter_output.rewind
-      observed_output = @outputter_output.read
-      expect(observed_output).to include("apache2")
-      expect(observed_output).to include("users")
-      expect(observed_output).not_to include("Run list contains invalid items: no such cookbook nope.")
-    end
-
-  end
-
-  describe "when explaining a PreconditionFailed (412) error with current error message style without cookbook details" do
-    # Chef currently returns error messages with some fields as JSON strings,
-    # which must be re-parsed to get the actual data.
-    # In some cases the error message doesn't contain any cookbook
-    # details. But we should still print a pretty error message.
-
-    before do
-
-      @response_body = "{\"error\":[{\"non_existent_cookbooks\":[],\"cookbooks_with_no_versions\":[],\"message\":\"unable to solve dependencies in allotted time.\"}]}"
-      @response = Net::HTTPPreconditionFailed.new("1.1", "412", "(response) unauthorized")
-      allow(@response).to receive(:body).and_return(@response_body)
-      @exception = Net::HTTPClientException.new("(exception) precondition failed", @response)
-
-      @inspector = Chef::Formatters::ErrorInspectors::CookbookResolveErrorInspector.new(@expanded_run_list, @exception)
-      @inspector.add_explanation(@description)
-    end
-
-    it "prints a pretty message" do
-      @description.display(@outputter)
-      @outputter_output.rewind
-      expect(@outputter_output.read).to include("unable to solve dependencies in allotted time.")
-    end
-
-  end
-
-  describe "when explaining a PreconditionFailed (412) error with single encoded JSON" do
-    # Chef currently returns error messages with some fields as JSON strings,
-    # which must be re-parsed to get the actual data.
-
-    before do
-
-      @response_body = "{\"error\":[{\"non_existent_cookbooks\":[\"apache2\"],\"cookbooks_with_no_versions\":[\"users\"],\"message\":\"Run list contains invalid items: no such cookbook nope.\"}]}"
-      @response = Net::HTTPPreconditionFailed.new("1.1", "412", "(response) unauthorized")
-      allow(@response).to receive(:body).and_return(@response_body)
-      @exception = Net::HTTPClientException.new("(exception) precondition failed", @response)
-
-      @inspector = Chef::Formatters::ErrorInspectors::CookbookResolveErrorInspector.new(@expanded_run_list, @exception)
-      @inspector.add_explanation(@description)
-    end
-
-    it "prints a pretty message" do
-      @description.display(@outputter)
-      @outputter_output.rewind
-      observed_output = @outputter_output.read
-      expect(observed_output).to include("apache2")
-      expect(observed_output).to include("users")
-      expect(observed_output).not_to include("Run list contains invalid items: no such cookbook nope.")
-    end
-
-  end
-end

data/spec/unit/formatters/error_inspectors/cookbook_sync_error_inspector_spec.rb

@@ -1,43 +0,0 @@
-#--
-# Author:: Daniel DeLeo (<dan@chef.io>)
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-
-describe Chef::Formatters::ErrorInspectors::CookbookSyncErrorInspector do
-  before do
-    @description = Chef::Formatters::ErrorDescription.new("Error Expanding RunList:")
-    @outputter = Chef::Formatters::IndentableOutputStream.new(StringIO.new, STDERR)
-    # @outputter = Chef::Formatters::IndentableOutputStream.new(STDOUT, STDERR)
-  end
-
-  describe "when explaining a 502 error" do
-    before do
-      @response_body = "sad trombone orchestra"
-      @response = Net::HTTPBadGateway.new("1.1", "502", "(response) bad gateway")
-      allow(@response).to receive(:body).and_return(@response_body)
-      @exception = Net::HTTPFatalError.new("(exception) bad gateway", @response)
-      @inspector = described_class.new({}, @exception)
-      @inspector.add_explanation(@description)
-    end
-
-    it "prints a nice message" do
-      @description.display(@outputter)
-    end
-
-  end
-end

data/spec/unit/formatters/error_inspectors/node_load_error_inspector_spec.rb

@@ -1,26 +0,0 @@
-#
-# Author:: Daniel DeLeo (<dan@chef.io>)
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-
-# spec_helper loads the shared examples already.
-# require 'support/shared/unit/api_error_inspector_spec'
-
-describe Chef::Formatters::ErrorInspectors::NodeLoadErrorInspector do
-  it_behaves_like "an api error inspector"
-end

data/spec/unit/formatters/error_inspectors/registration_error_inspector_spec.rb

@@ -1,26 +0,0 @@
-#
-# Author:: Daniel DeLeo (<dan@chef.io>)
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-
-# spec_helper loads the shared examples already.
-# require 'support/shared/unit/api_error_inspector_spec'
-
-describe Chef::Formatters::ErrorInspectors::RegistrationErrorInspector do
-  it_behaves_like "an api error inspector"
-end

data/spec/unit/formatters/error_inspectors/resource_failure_inspector_spec.rb

@@ -1,191 +0,0 @@
-#
-# Author:: Daniel DeLeo (<dan@chef.io>)
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-
-describe Chef::Formatters::ErrorInspectors::ResourceFailureInspector do
-  include Chef::DSL::Recipe
-
-  def run_context
-    node = Chef::Node.new
-    node.automatic_attrs[:platform] = "ubuntu"
-    node.automatic_attrs[:platform_version] = "10.04"
-    Chef::RunContext.new(node, {}, nil)
-  end
-
-  def cookbook_name
-    "rspec-example"
-  end
-
-  def recipe_name
-    "rspec-example-recipe"
-  end
-
-  before do
-    @description = Chef::Formatters::ErrorDescription.new("Error Converging Resource:")
-    @stdout = StringIO.new
-    @outputter = Chef::Formatters::IndentableOutputStream.new(@stdout, STDERR)
-    # @outputter = Chef::Formatters::IndentableOutputStream.new(STDOUT, STDERR)
-
-    allow(Chef::Config).to receive(:cookbook_path).and_return([ "/var/chef/cache" ])
-  end
-
-  describe "when explaining an error converging a resource" do
-    before do
-      @resource = package("non-existing-package") do
-
-        only_if do
-          true
-        end
-
-        not_if("/bin/false")
-        action :upgrade
-      end
-
-      @trace = [
-        "/var/chef/cache/cookbooks/syntax-err/recipes/default.rb:14:in `from_file'",
-        "/var/chef/cache/cookbooks/syntax-err/recipes/default.rb:11:in `from_file'",
-        "/usr/local/lib/ruby/gems/chef/lib/chef/client.rb:123:in `run'", # should not display
-      ]
-      @exception = Chef::Exceptions::Package.new("No such package 'non-existing-package'")
-      @exception.set_backtrace(@trace)
-      @inspector = Chef::Formatters::ErrorInspectors::ResourceFailureInspector.new(@resource, :create, @exception)
-      @inspector.add_explanation(@description)
-    end
-
-    it "filters chef core code from the backtrace" do
-      @expected_filtered_trace = [
-        "/var/chef/cache/cookbooks/syntax-err/recipes/default.rb:14:in `from_file'",
-        "/var/chef/cache/cookbooks/syntax-err/recipes/default.rb:11:in `from_file'",
-      ]
-
-      expect(@inspector.filtered_bt).to eq(@expected_filtered_trace)
-    end
-
-    it "prints a pretty message" do
-      @description.display(@outputter)
-    end
-
-    describe "and the error is a template error" do
-      before do
-        @description = Chef::Formatters::ErrorDescription.new("Error Converging Resource:")
-        @template_class = Class.new { include Chef::Mixin::Template }
-        @template = @template_class.new
-        @context = Chef::Mixin::Template::TemplateContext.new({})
-        @context[:chef] = "cool"
-
-        @resource = template("/tmp/foo.txt") do
-          mode "0644"
-        end
-
-        @error = begin
-                   @context.render_template_from_string("foo\nbar\nbaz\n<%= this_is_not_defined %>\nquin\nqunx\ndunno")
-                 rescue Chef::Mixin::Template::TemplateError => e
-                   e
-                 end
-
-        @inspector = Chef::Formatters::ErrorInspectors::ResourceFailureInspector.new(@resource, :create, @error)
-        @inspector.add_explanation(@description)
-      end
-
-      it "includes contextual info from the template error in the output" do
-        @description.display(@outputter)
-        expect(@stdout.string).to include(@error.source_listing)
-      end
-
-    end
-
-    describe "recipe_snippet" do
-      before do
-        # fake code to run through #recipe_snippet
-        source_file = [ "if true", "var = non_existent", "end" ]
-        allow(IO).to receive(:readlines).and_return(source_file)
-        allow(File).to receive(:exist?).and_return(true)
-      end
-
-      it "parses a Windows path" do
-        source_line = "C:/Users/btm/chef/chef/spec/unit/fake_file.rb:2: undefined local variable or method `non_existent' for main:Object (NameError)"
-        @resource.source_line = source_line
-        @inspector = Chef::Formatters::ErrorInspectors::ResourceFailureInspector.new(@resource, :create, @exception)
-        expect(@inspector.recipe_snippet).to match(%r{^# In C:/Users/btm})
-      end
-
-      it "parses a Windows path" do
-        source_line = "C:\\Windows\\Temp\\packer\\cookbooks\\fake_file.rb:2: undefined local variable or method `non_existent' for main:Object (NameError)"
-        @resource.source_line = source_line
-        @inspector = Chef::Formatters::ErrorInspectors::ResourceFailureInspector.new(@resource, :create, @exception)
-        expect(@inspector.recipe_snippet).to match(/^# In C:\\Windows\\Temp\\packer\\/)
-      end
-
-      it "parses a unix path" do
-        source_line = "/home/btm/src/chef/chef/spec/unit/fake_file.rb:2: undefined local variable or method `non_existent' for main:Object (NameError)"
-        @resource.source_line = source_line
-        @inspector = Chef::Formatters::ErrorInspectors::ResourceFailureInspector.new(@resource, :create, @exception)
-        expect(@inspector.recipe_snippet).to match(%r{^# In /home/btm})
-      end
-
-      context "when the recipe file does not exist" do
-        before do
-          allow(File).to receive(:exist?).and_return(false)
-          allow(IO).to receive(:readlines).and_raise(Errno::ENOENT)
-        end
-
-        it "does not try to parse a recipe in chef-shell/irb (CHEF-3411)" do
-          @resource.source_line = "(irb#1):1:in `irb_binding'"
-          @inspector = Chef::Formatters::ErrorInspectors::ResourceFailureInspector.new(@resource, :create, @exception)
-          expect(@inspector.recipe_snippet).to be_nil
-        end
-
-        it "does not raise an exception trying to load a non-existent file (CHEF-3411)" do
-          @resource.source_line = "/somewhere/in/space"
-          @inspector = Chef::Formatters::ErrorInspectors::ResourceFailureInspector.new(@resource, :create, @exception)
-          expect { @inspector.recipe_snippet }.not_to raise_error
-        end
-      end
-    end
-
-    describe "when examining a resource that confuses the parser" do
-      before do
-        angry_bash_recipe = File.expand_path("cookbooks/angrybash/recipes/default.rb", CHEF_SPEC_DATA)
-        source_line = "#{angry_bash_recipe}:1:in `<main>'"
-
-        # source_line = caller(0)[0]; @resource = bash "go off the rails" do
-        #   code <<-END
-        #     for i in localhost 127.0.0.1 #{Socket.gethostname()}
-        #     do
-        #       echo "grant all on *.* to root@'$i' identified by 'a_password'; flush privileges;" | mysql -u root -h 127.0.0.1
-        #     done
-        #    END
-        # end
-        @resource = eval(IO.read(angry_bash_recipe))
-        @resource.source_line = source_line
-        @inspector = Chef::Formatters::ErrorInspectors::ResourceFailureInspector.new(@resource, :create, @exception)
-
-        @exception.set_backtrace(@trace)
-        @inspector = Chef::Formatters::ErrorInspectors::ResourceFailureInspector.new(@resource, :create, @exception)
-      end
-
-      it "does not generate an error" do
-        expect { @inspector.add_explanation(@description) }.not_to raise_error
-        @description.display(@outputter)
-      end
-    end
-
-  end
-
-end