chef 18.8.11 → 18.8.46

data/spec/unit/provider/launchd_spec.rb

@@ -1,234 +0,0 @@
-#
-# Author:: Mike Dodge (<mikedodge04@gmail.com>)
-# Copyright:: Copyright (c) 2015 Facebook, Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-
-describe Chef::Provider::Launchd do
-
-  context "When launchd manages call.mom.weekly" do
-    let(:node) { Chef::Node.new }
-    let(:events) { Chef::EventDispatch::Dispatcher.new }
-    let(:run_context) { Chef::RunContext.new(node, {}, events) }
-    let(:provider) { Chef::Provider::Launchd.new(new_resource, run_context) }
-
-    let(:label) { "call.mom.weekly" }
-    let(:new_resource) { Chef::Resource::Launchd.new(label) }
-    let!(:current_resource) { Chef::Resource::Launchd.new(label) }
-    let(:test_plist) { String.new <<~XML }
-      <?xml version="1.0" encoding="UTF-8"?>
-      <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
-      <plist version="1.0">
-      <dict>
-      \t<key>Label</key>
-      \t<string>call.mom.weekly</string>
-      \t<key>Program</key>
-      \t<string>/Library/scripts/call_mom.sh</string>
-      \t<key>StartCalendarInterval</key>
-      \t<dict>
-      \t\t<key>Hour</key>
-      \t\t<integer>10</integer>
-      \t\t<key>Weekday</key>
-      \t\t<integer>7</integer>
-      \t</dict>
-      \t<key>TimeOut</key>
-      \t<integer>300</integer>
-      </dict>
-      </plist>
-    XML
-    let(:test_plist_multiple_intervals) { String.new <<~XML }
-      <?xml version="1.0" encoding="UTF-8"?>
-      <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
-      <plist version="1.0">
-      <dict>
-      \t<key>Label</key>
-      \t<string>call.mom.weekly</string>
-      \t<key>Program</key>
-      \t<string>/Library/scripts/call_mom.sh</string>
-      \t<key>StartCalendarInterval</key>
-      \t<array>
-      \t\t<dict>
-      \t\t\t<key>Hour</key>
-      \t\t\t<integer>11</integer>
-      \t\t\t<key>Weekday</key>
-      \t\t\t<integer>1</integer>
-      \t\t</dict>
-      \t\t<dict>
-      \t\t\t<key>Hour</key>
-      \t\t\t<integer>12</integer>
-      \t\t\t<key>Weekday</key>
-      \t\t\t<integer>2</integer>
-      \t\t</dict>
-      \t</array>
-      \t<key>TimeOut</key>
-      \t<integer>300</integer>
-      </dict>
-      </plist>
-    XML
-
-    let(:test_hash) do
-      {
-      "Label" => "call.mom.weekly",
-      "Program" => "/Library/scripts/call_mom.sh",
-      "StartCalendarInterval" => {
-        "Hour" => 10,
-        "Weekday" => 7,
-      },
-      "TimeOut" => 300,
-    }
-    end
-
-    before(:each) do
-      provider.load_current_resource
-    end
-
-    it "resource name and label should be call.mom.weekly" do
-      expect(new_resource.name).to eql(label)
-      expect(new_resource.label).to eql(label)
-    end
-
-    def run_resource_setup_for_action(action)
-      new_resource.action(action)
-      provider.action = action
-      provider.load_current_resource
-      provider.define_resource_requirements
-      provider.process_resource_requirements
-    end
-
-    describe "with type is set to" do
-      describe "agent" do
-        it "path should be /Library/LaunchAgents/call.mom.weekly.plist" do
-          new_resource.type "agent"
-          expect(provider.gen_path_from_type)
-            .to eq("/Library/LaunchAgents/call.mom.weekly.plist")
-        end
-      end
-      describe "daemon" do
-        it "path should be /Library/LaunchDaemons/call.mom.weekly.plist" do
-          expect(provider.gen_path_from_type)
-            .to eq("/Library/LaunchDaemons/call.mom.weekly.plist")
-        end
-      end
-    end
-
-    describe "with a :create action and" do
-      describe "program is passed" do
-        it "should produce the test_plist from properties" do
-          new_resource.program "/Library/scripts/call_mom.sh"
-          new_resource.time_out 300
-          new_resource.start_calendar_interval "Hour" => 10, "Weekday" => 7
-          expect(provider.file_content?).to be_truthy
-          expect(provider.file_content).to eql(test_plist)
-        end
-      end
-
-      describe "start_calendar_interval is passed" do
-        it "should allow array of Hashes" do
-          allowed = (1..2).collect do |num|
-            {
-              "Hour" => 10 + num,
-              "Weekday" => num,
-            }
-          end
-          new_resource.program "/Library/scripts/call_mom.sh"
-          new_resource.time_out 300
-          new_resource.start_calendar_interval allowed
-          expect(provider.file_content?).to be_truthy
-          expect(provider.file_content).to eql(test_plist_multiple_intervals)
-        end
-
-        it "should allow all StartCalendarInterval keys" do
-          allowed = {
-            "Minute" => 1,
-            "Hour" => 1,
-            "Day" => 1,
-            "Weekday" => 1,
-            "Month" => 1,
-          }
-          new_resource.program "/Library/scripts/call_mom.sh"
-          new_resource.time_out 300
-          new_resource.start_calendar_interval allowed
-          expect(provider.file_content?).to be_truthy
-          %w{Minute Hour Day Weekday Month}.each do |key|
-            expect(provider.file_content).to include("<key>#{key}</key>")
-          end
-        end
-
-        it "should not allow invalid ShowCalendarInterval keys" do
-          new_resource.program "/Library/scripts/call_mom.sh"
-          new_resource.time_out 300
-          expect do
-            new_resource.start_calendar_interval "Hourly" => 1
-          end.to raise_error(/Hourly are invalid/)
-        end
-
-        it "should not allow non-integer values" do
-          new_resource.program "/Library/scripts/call_mom.sh"
-          new_resource.time_out 300
-          expect do
-            new_resource.start_calendar_interval "Weekday" => "1-2"
-          end.to raise_error(/Invalid value.*\(1-2\)/)
-        end
-      end
-
-      describe "hash is passed" do
-        it "should produce the test_plist content from the plist_hash property" do
-          new_resource.plist_hash test_hash
-          expect(provider.file_content?).to be_truthy
-          expect(provider.file_content).to eql(test_plist)
-        end
-      end
-    end
-
-    describe "with an :delete action" do
-      describe "and the ld file is present" do
-        before(:each) do
-          allow(File).to receive(:exist?).and_return(true)
-          allow(provider).to receive(
-            :manage_service
-          ).with(:disable).and_return(true)
-          allow(provider).to receive(
-            :manage_plist
-          ).with(:delete).and_return(true)
-        end
-
-        it "should call manage_service with a :disable action" do
-          expect(provider.manage_service(:disable)).to be_truthy
-        end
-
-        it "works with action :delete" do
-          expect(run_resource_setup_for_action(:delete)).to be_truthy
-          provider.action_delete
-        end
-      end
-
-      describe "and the ld file is not present" do
-        before(:each) do
-          allow(File).to receive(:exist?).and_return(false)
-          allow(provider).to receive(
-            :manage_plist
-          ).with(:delete).and_return(true)
-        end
-
-        it "works with action :delete" do
-          expect(run_resource_setup_for_action(:delete)).to be_truthy
-          provider.action_delete
-        end
-      end
-    end
-  end
-end

data/spec/unit/provider/link_spec.rb

@@ -1,425 +0,0 @@
-#
-# Author:: AJ Christensen (<aj@junglist.gen.nz>)
-# Author:: John Keiser (<jkeiser@chef.io>)
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "ostruct"
-
-require "spec_helper"
-
-if ChefUtils.windows?
-  require "chef/win32/file" # probably need this in spec_helper
-end
-
-describe Chef::Resource::Link do
-  let(:logger) { double("Mixlib::Log::Child").as_null_object }
-  let(:provider) do
-    node = Chef::Node.new
-    @events = Chef::EventDispatch::Dispatcher.new
-    run_context = Chef::RunContext.new(node, {}, @events)
-    allow(run_context).to receive(:logger).and_return(logger)
-    Chef::Provider::Link.new(new_resource, run_context)
-  end
-  let(:new_resource) do
-    result = Chef::Resource::Link.new("#{CHEF_SPEC_DATA}/fofile-link")
-    result.to "#{CHEF_SPEC_DATA}/fofile"
-    result
-  end
-
-  def canonicalize(path)
-    ChefUtils.windows? ? path.tr("/", "\\") : path
-  end
-
-  describe "when the target is a symlink" do
-    before(:each) do
-      lstat = double("stats", ino: 5)
-      allow(lstat).to receive(:uid).and_return(501)
-      allow(lstat).to receive(:gid).and_return(501)
-      allow(lstat).to receive(:mode).and_return(0777)
-      allow(File).to receive(:lstat).with("#{CHEF_SPEC_DATA}/fofile-link").and_return(lstat)
-      allow(provider.file_class).to receive(:symlink?).with("#{CHEF_SPEC_DATA}/fofile-link").and_return(true)
-      allow(provider.file_class).to receive(:readlink).with("#{CHEF_SPEC_DATA}/fofile-link").and_return("#{CHEF_SPEC_DATA}/fofile")
-    end
-
-    describe "to a file that exists" do
-      before do
-        allow(File).to receive(:exist?).with("#{CHEF_SPEC_DATA}/fofile-link").and_return(true)
-        new_resource.owner 501 # only loaded in current_resource if present in new
-        new_resource.group 501
-        provider.load_current_resource
-      end
-
-      it "should set the symlink target" do
-        expect(provider.current_resource.target_file).to eq("#{CHEF_SPEC_DATA}/fofile-link")
-      end
-      it "should set the link type" do
-        expect(provider.current_resource.link_type).to eq(:symbolic)
-      end
-      it "should update the source of the existing link with the links target" do
-        expect(provider.current_resource.to).to  eq(canonicalize("#{CHEF_SPEC_DATA}/fofile"))
-      end
-      it "should set the owner" do
-        expect(provider.current_resource.owner).to eq(501)
-      end
-      it "should set the group" do
-        expect(provider.current_resource.group).to eq(501)
-      end
-
-      # We test create in unit tests because there is no other way to ensure
-      # it does no work.  Other create and delete scenarios are covered in
-      # the functional tests for links.
-      context "when the desired state is identical" do
-        let(:new_resource) do
-          result = Chef::Resource::Link.new("#{CHEF_SPEC_DATA}/fofile-link")
-          result.to "#{CHEF_SPEC_DATA}/fofile"
-          result
-        end
-        it "create does no work" do
-          expect(provider.access_controls).not_to receive(:set_all)
-          provider.run_action(:create)
-        end
-      end
-    end
-
-    describe "to a file that doesn't exist" do
-      before do
-        allow(File).to receive(:exist?).with("#{CHEF_SPEC_DATA}/fofile-link").and_return(false)
-        allow(provider.file_class).to receive(:symlink?).with("#{CHEF_SPEC_DATA}/fofile-link").and_return(true)
-        allow(provider.file_class).to receive(:readlink).with("#{CHEF_SPEC_DATA}/fofile-link").and_return("#{CHEF_SPEC_DATA}/fofile")
-        new_resource.owner "501" # only loaded in current_resource if present in new
-        new_resource.group "501"
-        provider.load_current_resource
-      end
-
-      it "should set the symlink target" do
-        expect(provider.current_resource.target_file).to eq("#{CHEF_SPEC_DATA}/fofile-link")
-      end
-      it "should set the link type" do
-        expect(provider.current_resource.link_type).to eq(:symbolic)
-      end
-      it "should update the source of the existing link to the link's target" do
-        expect(provider.current_resource.to).to eq(canonicalize("#{CHEF_SPEC_DATA}/fofile"))
-      end
-      it "should not set the owner" do
-        expect(provider.current_resource.owner).to be_nil
-      end
-      it "should not set the group" do
-        expect(provider.current_resource.group).to be_nil
-      end
-    end
-  end
-
-  describe "when the target doesn't exist" do
-    before do
-      allow(File).to receive(:exist?).with("#{CHEF_SPEC_DATA}/fofile-link").and_return(false)
-      allow(provider.file_class).to receive(:symlink?).with("#{CHEF_SPEC_DATA}/fofile-link").and_return(false)
-      provider.load_current_resource
-    end
-
-    it "should set the symlink target" do
-      expect(provider.current_resource.target_file).to eq("#{CHEF_SPEC_DATA}/fofile-link")
-    end
-    it "should update the source of the existing link to nil" do
-      expect(provider.current_resource.to).to be_nil
-    end
-    it "should not set the owner" do
-      expect(provider.current_resource.owner).to eq(nil)
-    end
-    it "should not set the group" do
-      expect(provider.current_resource.group).to eq(nil)
-    end
-  end
-
-  describe "when the target is a regular old file" do
-    before do
-      stat = double("stats", ino: 5)
-      allow(stat).to receive(:uid).and_return(501)
-      allow(stat).to receive(:gid).and_return(501)
-      allow(stat).to receive(:mode).and_return(0755)
-      allow(provider.file_class).to receive(:stat).with("#{CHEF_SPEC_DATA}/fofile-link").and_return(stat)
-
-      # XXX: this might be broken?  it preserves prior behavior in the specs caused by File.exist?/exists? interactions
-      allow(Chef::ScanAccessControl).to receive(:new).and_return(instance_double(Chef::ScanAccessControl, set_all!: nil))
-
-      allow(File).to receive(:exist?).with("#{CHEF_SPEC_DATA}/fofile-link").and_return(true)
-      allow(provider.file_class).to receive(:symlink?).with("#{CHEF_SPEC_DATA}/fofile-link").and_return(false)
-    end
-
-    describe "and the source does not exist" do
-      before do
-        expect(File).to receive(:exist?).with("#{CHEF_SPEC_DATA}/fofile").and_return(false)
-        provider.load_current_resource
-      end
-
-      it "should set the symlink target" do
-        expect(provider.current_resource.target_file).to eq("#{CHEF_SPEC_DATA}/fofile-link")
-      end
-      it "should update the current source of the existing link with an empty string" do
-        expect(provider.current_resource.to).to eq("")
-      end
-      it "should not set the owner" do
-        expect(provider.current_resource.owner).to eq(nil)
-      end
-      it "should not set the group" do
-        expect(provider.current_resource.group).to eq(nil)
-      end
-    end
-
-    describe "and the source exists" do
-      before do
-        stat = double("stats", ino: 6)
-        allow(stat).to receive(:uid).and_return(502)
-        allow(stat).to receive(:gid).and_return(502)
-        allow(stat).to receive(:mode).and_return(0644)
-
-        allow(provider.file_class).to receive(:stat).with("#{CHEF_SPEC_DATA}/fofile").and_return(stat)
-
-        allow(File).to receive(:exist?).with("#{CHEF_SPEC_DATA}/fofile").and_return(true)
-        provider.load_current_resource
-      end
-
-      it "should set the symlink target" do
-        expect(provider.current_resource.target_file).to eq("#{CHEF_SPEC_DATA}/fofile-link")
-      end
-      it "should update the current source of the existing link with an empty string" do
-        expect(provider.current_resource.to).to eq("")
-      end
-      it "should not set the owner" do
-        expect(provider.current_resource.owner).to eq(nil)
-      end
-      it "should not set the group" do
-        expect(provider.current_resource.group).to eq(nil)
-      end
-    end
-
-    describe "and is hardlinked to the source" do
-      before do
-        stat = double("stats", ino: 5)
-        allow(stat).to receive(:uid).and_return(502)
-        allow(stat).to receive(:gid).and_return(502)
-        allow(stat).to receive(:mode).and_return(0644)
-
-        allow(provider.file_class).to receive(:stat).with("#{CHEF_SPEC_DATA}/fofile").and_return(stat)
-
-        allow(File).to receive(:exist?).with("#{CHEF_SPEC_DATA}/fofile").and_return(true)
-        provider.load_current_resource
-      end
-
-      it "should set the symlink target" do
-        expect(provider.current_resource.target_file).to eq("#{CHEF_SPEC_DATA}/fofile-link")
-      end
-      it "should set the link type" do
-        expect(provider.current_resource.link_type).to eq(:hard)
-      end
-      it "should update the source of the existing link to the link's target" do
-        expect(provider.current_resource.to).to eq(canonicalize("#{CHEF_SPEC_DATA}/fofile"))
-      end
-      it "should not set the owner" do
-        expect(provider.current_resource.owner).to eq(nil)
-      end
-      it "should not set the group" do
-        expect(provider.current_resource.group).to eq(nil)
-      end
-
-      # We test create in unit tests because there is no other way to ensure
-      # it does no work.  Other create and delete scenarios are covered in
-      # the functional tests for links.
-      context "when the desired state is identical" do
-        let(:new_resource) do
-          result = Chef::Resource::Link.new("#{CHEF_SPEC_DATA}/fofile-link")
-          result.to "#{CHEF_SPEC_DATA}/fofile"
-          result.link_type :hard
-          result
-        end
-        it "create does no work" do
-          expect(provider.file_class).not_to receive(:symlink)
-          expect(provider.file_class).not_to receive(:link)
-          expect(provider.access_controls).not_to receive(:set_all)
-          provider.run_action(:create)
-        end
-      end
-    end
-  end
-
-  describe "action_delete" do
-    before(:each) do
-      stat = double("stats", ino: 5)
-      allow(stat).to receive(:uid).and_return(501)
-      allow(stat).to receive(:gid).and_return(501)
-      allow(stat).to receive(:mode).and_return(0755)
-      allow(provider.file_class).to receive(:stat).with(
-        "#{CHEF_SPEC_DATA}/fofile-link"
-      ).and_return(stat)
-
-      # XXX: this might be broken?  it preserves prior behavior in the specs caused by File.exist?/exists? interactions
-      allow(Chef::ScanAccessControl).to receive(:new).and_return(instance_double(Chef::ScanAccessControl, set_all!: nil))
-
-      provider.load_current_resource
-    end
-
-    shared_context "delete link to directories on Windows" do
-      before do
-        allow(::File).to receive(:directory?).with(
-          "#{CHEF_SPEC_DATA}/fofile-link"
-        ).and_return(true)
-      end
-
-      it "invokes Dir.delete method to delete the link" do
-        expect(::Dir).to receive(:delete).with(provider.new_resource.target_file)
-        expect(logger).to receive(:info).with("#{provider.new_resource} deleted")
-        provider.run_action(:delete)
-      end
-    end
-
-    shared_context "delete link to directories on Linux" do
-      before do
-        allow(::File).to receive(:directory?).with(
-          "#{CHEF_SPEC_DATA}/fofile-link"
-        ).and_return(true)
-      end
-
-      it "invokes File.delete method to delete the link" do
-        expect(::File).to receive(:delete).with(provider.new_resource.target_file)
-        expect(logger).to receive(:info).with("#{provider.new_resource} deleted")
-        provider.run_action(:delete)
-      end
-    end
-
-    shared_context "delete link to files" do
-      before do
-        allow(::File).to receive(:directory?).with(
-          "#{CHEF_SPEC_DATA}/fofile-link"
-        ).and_return(false)
-      end
-
-      it "invokes File.delete method to delete the link" do
-        expect(::File).to receive(:delete).with(provider.new_resource.target_file)
-        expect(logger).to receive(:info).with("#{provider.new_resource} deleted")
-        provider.run_action(:delete)
-      end
-    end
-
-    shared_context "soft links prerequisites" do
-      before(:each) do
-        allow(provider.file_class).to receive(:symlink?).with(
-          "#{CHEF_SPEC_DATA}/fofile-link"
-        ).and_return(true)
-        allow(provider.file_class).to receive(:readlink).with(
-          "#{CHEF_SPEC_DATA}/fofile-link"
-        ).and_return("#{CHEF_SPEC_DATA}/fofile")
-      end
-    end
-
-    shared_context "hard links prerequisites" do
-      let(:new_resource) do
-        result = Chef::Resource::Link.new("#{CHEF_SPEC_DATA}/fofile-link")
-        result.to "#{CHEF_SPEC_DATA}/fofile"
-        result.link_type :hard
-        result
-      end
-
-      before(:each) do
-        stat = double("stats", ino: 5)
-        allow(stat).to receive(:uid).and_return(502)
-        allow(stat).to receive(:gid).and_return(502)
-        allow(stat).to receive(:mode).and_return(0644)
-
-        allow(provider.file_class).to receive(:symlink?).with(
-          "#{CHEF_SPEC_DATA}/fofile-link"
-        ).and_return(false)
-
-        allow(File).to receive(:exist?).with(
-          "#{CHEF_SPEC_DATA}/fofile-link"
-        ).and_return(true)
-        allow(File).to receive(:exist?).with(
-          "#{CHEF_SPEC_DATA}/fofile"
-        ).and_return(true)
-
-        allow(provider.file_class).to receive(:stat).with(
-          "#{CHEF_SPEC_DATA}/fofile"
-        ).and_return(stat)
-      end
-    end
-
-    context "on Windows platform" do
-      let(:resource_link) do
-        Chef::Resource::Link.new(provider.new_resource.name)
-      end
-
-      before(:each) do
-        allow(Chef::Resource::Link).to receive(:new).with(
-          provider.new_resource.name
-        ).and_return(resource_link)
-        allow(ChefUtils).to receive(:windows?).and_return(true)
-      end
-
-      context "soft links" do
-        include_context "soft links prerequisites"
-
-        context "to directories" do
-          include_context "delete link to directories on Windows"
-        end
-
-        context "to files" do
-          include_context "delete link to files"
-        end
-      end
-
-      context "hard links" do
-        include_context "hard links prerequisites"
-
-        context "to directories" do
-          include_context "delete link to directories on Windows"
-        end
-
-        context "to files" do
-          include_context "delete link to files"
-        end
-      end
-    end
-
-    context "on Linux platform" do
-      before(:each) do
-        allow(ChefUtils).to receive(:windows?).and_return(false)
-      end
-
-      context "soft links" do
-        include_context "soft links prerequisites"
-
-        context "to directories" do
-          include_context "delete link to directories on Linux"
-        end
-
-        context "to files" do
-          include_context "delete link to files"
-        end
-      end
-
-      context "hard links" do
-        include_context "hard links prerequisites"
-
-        context "to directories" do
-          include_context "delete link to directories on Linux"
-        end
-
-        context "to files" do
-          include_context "delete link to files"
-        end
-      end
-    end
-  end
-end