chef 15.1.36-universal-mingw32 → 15.2.20-universal-mingw32

data/lib/chef/resource/windows_font.rb

@@ -29,12 +29,12 @@ class Chef
       introduced "14.0"
 
       property :font_name, String,
-               description: "An optional property to set the name of the font to install if it differs from the resource block's name.",
-               name_property: true
+        description: "An optional property to set the name of the font to install if it differs from the resource block's name.",
+        name_property: true
 
       property :source, String,
-               description: "A local filesystem path or URI that is used to source the font file.",
-               coerce: proc { |x| x =~ /^.:.*/ ? x.tr('\\', "/").gsub("//", "/") : x }
+        description: "A local filesystem path or URI that is used to source the font file.",
+        coerce: proc { |x| x =~ /^.:.*/ ? x.tr('\\', "/").gsub("//", "/") : x }
 
       action :install do
         description "Install a font to the system fonts directory."

data/lib/chef/resource/windows_package.rb

@@ -49,11 +49,11 @@ class Chef
       # In the past we accepted return code 127 for an unknown reason and 42 because of a bug
       property :returns, [ String, Integer, Array ], default: [ 0 ], desired_state: false
       property :source, String,
-                coerce: (proc do |s|
-                  unless s.nil?
-                    uri_scheme?(s) ? s : Chef::Util::PathHelper.canonical_path(s, false)
-                  end
-                end)
+        coerce: (proc do |s|
+          unless s.nil?
+            uri_scheme?(s) ? s : Chef::Util::PathHelper.canonical_path(s, false)
+          end
+        end)
       property :checksum, String, desired_state: false
       property :remote_file_attributes, Hash, desired_state: false
     end

data/lib/chef/resource/windows_pagefile.rb

@@ -27,22 +27,22 @@ class Chef
       introduced "14.0"
 
       property :path, String,
-               coerce: proc { |x| x.tr("/", '\\') },
-               description: "An optional property to set the pagefile name if it differs from the resource block's name.",
-               name_property: true
+        coerce: proc { |x| x.tr("/", '\\') },
+        description: "An optional property to set the pagefile name if it differs from the resource block's name.",
+        name_property: true
 
       property :system_managed, [TrueClass, FalseClass],
-               description: "Configures whether the system manages the pagefile size."
+        description: "Configures whether the system manages the pagefile size."
 
       property :automatic_managed, [TrueClass, FalseClass],
-               description: "Enable automatic management of pagefile initial and maximum size. Setting this to true ignores 'initial_size' and 'maximum_size' properties.",
-               default: false
+        description: "Enable automatic management of pagefile initial and maximum size. Setting this to true ignores 'initial_size' and 'maximum_size' properties.",
+        default: false
 
       property :initial_size, Integer,
-               description: "Initial size of the pagefile in megabytes."
+        description: "Initial size of the pagefile in megabytes."
 
       property :maximum_size, Integer,
-               description: "Maximum size of the pagefile in megabytes."
+        description: "Maximum size of the pagefile in megabytes."
 
       action :set do
         description "Configures the default pagefile, creating if it doesn't exist."
@@ -87,6 +87,7 @@ class Chef
         # is set then this validation is not necessary / doesn't make sense at all
         def validate_name
           return if /^.:.*.sys/ =~ new_resource.path
+
           raise "#{new_resource.path} does not match the format DRIVE:\\path\\file.sys for pagefiles. Example: C:\\pagefile.sys"
         end
 

data/lib/chef/resource/windows_path.rb

@@ -31,8 +31,8 @@ class Chef
       default_action :add
 
       property :path, String,
-               description: "An optional property to set the path value if it differs from the resource block's name.",
-               name_property: true
+        description: "An optional property to set the path value if it differs from the resource block's name.",
+        name_property: true
     end
   end
 end

data/lib/chef/resource/windows_printer.rb

@@ -31,37 +31,37 @@ class Chef
       introduced "14.0"
 
       property :device_id, String,
-               description: "An optional property to set the printer queue name if it differs from the resource block's name. Example: 'HP LJ 5200 in fifth floor copy room'.",
-               name_property: true
+        description: "An optional property to set the printer queue name if it differs from the resource block's name. Example: 'HP LJ 5200 in fifth floor copy room'.",
+        name_property: true
 
       property :comment, String,
-               description: "Optional descriptor for the printer queue."
+        description: "Optional descriptor for the printer queue."
 
       property :default, [TrueClass, FalseClass],
-               description: "Determines whether or not this should be the system's default printer.",
-               default: false
+        description: "Determines whether or not this should be the system's default printer.",
+        default: false
 
       property :driver_name, String,
-               description: "The exact name of printer driver installed on the system.",
-               required: true
+        description: "The exact name of printer driver installed on the system.",
+        required: true
 
       property :location, String,
-               description: "Printer location, such as 'Fifth floor copy room'."
+        description: "Printer location, such as 'Fifth floor copy room'."
 
       property :shared, [TrueClass, FalseClass],
-               description: "Determines whether or not the printer is shared.",
-               default: false
+        description: "Determines whether or not the printer is shared.",
+        default: false
 
       property :share_name, String,
-               description: "The name used to identify the shared printer."
+        description: "The name used to identify the shared printer."
 
       property :ipv4_address, String,
-               description: "The IPv4 address of the printer, such as '10.4.64.23'",
-               validation_message: "The ipv4_address property must be in the IPv4 format of WWW.XXX.YYY.ZZZ",
-               regex: Resolv::IPv4::Regex
+        description: "The IPv4 address of the printer, such as '10.4.64.23'",
+        validation_message: "The ipv4_address property must be in the IPv4 format of WWW.XXX.YYY.ZZZ",
+        regex: Resolv::IPv4::Regex
 
       property :exists, [TrueClass, FalseClass],
-               skip_docs: true
+        skip_docs: true
 
       PRINTERS_REG_KEY = 'HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Print\Printers\\'.freeze unless defined?(PRINTERS_REG_KEY)
 

data/lib/chef/resource/windows_printer_port.rb

@@ -31,32 +31,32 @@ class Chef
       introduced "14.0"
 
       property :ipv4_address, String,
-               name_property: true,
-               regex: Resolv::IPv4::Regex,
-               validation_message: "The ipv4_address property must be in the format of WWW.XXX.YYY.ZZZ!",
-               description: "An optional property for the IPv4 address of the printer if it differs from the resource block's name."
+        name_property: true,
+        regex: Resolv::IPv4::Regex,
+        validation_message: "The ipv4_address property must be in the format of WWW.XXX.YYY.ZZZ!",
+        description: "An optional property for the IPv4 address of the printer if it differs from the resource block's name."
 
       property :port_name, String,
-               description: "The port name."
+        description: "The port name."
 
       property :port_number, Integer,
-               description: "The port number.",
-               default: 9100
+        description: "The port number.",
+        default: 9100
 
       property :port_description, String,
-               description: "The description of the port."
+        description: "The description of the port."
 
       property :snmp_enabled, [TrueClass, FalseClass],
-               description: "Determines if SNMP is enabled on the port.",
-               default: false
+        description: "Determines if SNMP is enabled on the port.",
+        default: false
 
       property :port_protocol, Integer,
-               description: "The printer port protocol: 1 (RAW) or 2 (LPR).",
-               validation_message: "port_protocol must be either 1 for RAW or 2 for LPR!",
-               default: 1, equal_to: [1, 2]
+        description: "The printer port protocol: 1 (RAW) or 2 (LPR).",
+        validation_message: "port_protocol must be either 1 for RAW or 2 for LPR!",
+        default: 1, equal_to: [1, 2]
 
       property :exists, [TrueClass, FalseClass],
-               skip_docs: true
+        skip_docs: true
 
       PORTS_REG_KEY = 'HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Print\Monitors\Standard TCP/IP Port\Ports\\'.freeze unless defined?(PORTS_REG_KEY)
 

data/lib/chef/resource/windows_script.rb

@@ -41,7 +41,7 @@ class Chef
       public
 
       def architecture(arg = nil)
-        assert_architecture_compatible!(arg) if ! arg.nil?
+        assert_architecture_compatible!(arg) unless arg.nil?
         result = set_or_return(
           :architecture,
           arg,

data/lib/chef/resource/windows_service.rb

@@ -58,7 +58,7 @@ class Chef
       #   - :manual
       #   - :disabled
       # Reference: https://github.com/chef/win32-service/blob/ffi/lib/win32/windows/constants.rb#L49-L54
-      property :startup_type, [Symbol], equal_to: [:automatic, :manual, :disabled], default: :automatic, coerce: proc { |x|
+      property :startup_type, [Symbol], equal_to: %i{automatic manual disabled}, default: :automatic, coerce: proc { |x|
         if x.is_a?(Integer)
           ALLOWED_START_TYPES.invert.fetch(x) do
             Chef::Log.warn("Unsupported startup_type #{x}, falling back to :automatic")
@@ -75,25 +75,25 @@ class Chef
       # 1 == delayed start is enabled
       # 0 == NO delayed start
       property :delayed_start, [TrueClass, FalseClass],
-               introduced: "14.0",
-               default: false, coerce: proc { |x|
-                 if x.is_a?(Integer)
-                   x == 0 ? false : true
-                 else
-                   x
-                 end
-               }
+        introduced: "14.0",
+        default: false, coerce: proc { |x|
+          if x.is_a?(Integer)
+            x == 0 ? false : true
+          else
+            x
+          end
+        }
 
       # https://github.com/chef/win32-service/blob/ffi/lib/win32/windows/constants.rb#L43-L47
       property :error_control, Integer, default: SERVICE_ERROR_NORMAL
 
       property :binary_path_name, String,
-               introduced: "14.0",
-               description: "The fully qualified path to the service binary file. The path can also include arguments for an auto-start service. This is required for ':create' and ':configure' actions"
+        introduced: "14.0",
+        description: "The fully qualified path to the service binary file. The path can also include arguments for an auto-start service. This is required for ':create' and ':configure' actions"
 
       property :load_order_group, String,
-               introduced: "14.0",
-               description: "The names of the load ordering group of which this service is a member. Don't set this property if the service does not belong to a group."
+        introduced: "14.0",
+        description: "The names of the load ordering group of which this service is a member. Don't set this property if the service does not belong to a group."
 
       # A pointer to a double null-terminated array of null-separated names of
       # services or load ordering groups that the system must start before this
@@ -102,11 +102,11 @@ class Chef
       # at least one member of the group is running after an attempt to start
       # all members of the group.
       property :dependencies, [String, Array],
-               introduced: "14.0"
+        introduced: "14.0"
 
       property :description, String,
-               description: "Description of the service.",
-               introduced: "14.0"
+        description: "Description of the service.",
+        introduced: "14.0"
 
       property :run_as_user, String, default: "LocalSystem"
       property :run_as_password, String, default: ""

data/lib/chef/resource/windows_share.rb

@@ -33,65 +33,65 @@ class Chef
 
       # Specifies a name for the SMB share. The name may be composed of any valid file name characters, but must be less than 80 characters long. The names pipe and mailslot are reserved for use by the computer.
       property :share_name, String,
-               description: "An optional property to set the share name if it differs from the resource block's name.",
-               name_property: true
+        description: "An optional property to set the share name if it differs from the resource block's name.",
+        name_property: true
 
       # Specifies the path of the location of the folder to share. The path must be fully qualified. Relative paths or paths that contain wildcard characters are not permitted.
       property :path, String,
-               description: "The path of the folder to share. Required when creating. If the share already exists on a different path then it is deleted and re-created."
+        description: "The path of the folder to share. Required when creating. If the share already exists on a different path then it is deleted and re-created."
 
       # Specifies an optional description of the SMB share. A description of the share is displayed by running the Get-SmbShare cmdlet. The description may not contain more than 256 characters.
       property :description, String,
-               description: "The description to be applied to the share.",
-               default: ""
+        description: "The description to be applied to the share.",
+        default: ""
 
       # Specifies which accounts are granted full permission to access the share. Use a comma-separated list to specify multiple accounts. An account may not be specified more than once in the FullAccess, ChangeAccess, or ReadAccess parameter lists, but may be specified once in the FullAccess, ChangeAccess, or ReadAccess parameter list and once in the NoAccess parameter list.
       property :full_users, Array,
-               description: "The users that should have 'Full control' permissions on the share in domain\\username format.",
-               default: lazy { [] }, coerce: proc { |u| u.sort }
+        description: "The users that should have 'Full control' permissions on the share in domain\\username format.",
+        default: lazy { [] }, coerce: proc { |u| u.sort }
 
       # Specifies which users are granted modify permission to access the share
       property :change_users, Array,
-               description: "The users that should have 'modify' permission on the share in domain\\username format.",
-               default: lazy { [] }, coerce: proc { |u| u.sort }
+        description: "The users that should have 'modify' permission on the share in domain\\username format.",
+        default: lazy { [] }, coerce: proc { |u| u.sort }
 
       # Specifies which users are granted read permission to access the share. Multiple users can be specified by supplying a comma-separated list.
       property :read_users, Array,
-               description: "The users that should have 'read' permission on the share in domain\\username format.",
-               default: lazy { [] }, coerce: proc { |u| u.sort }
+        description: "The users that should have 'read' permission on the share in domain\\username format.",
+        default: lazy { [] }, coerce: proc { |u| u.sort }
 
       # Specifies the lifetime of the new SMB share. A temporary share does not persist beyond the next restart of the computer. By default, new SMB shares are persistent, and non-temporary.
       property :temporary, [TrueClass, FalseClass],
-               description: "The lifetime of the new SMB share. A temporary share does not persist beyond the next restart of the computer.",
-               default: false
+        description: "The lifetime of the new SMB share. A temporary share does not persist beyond the next restart of the computer.",
+        default: false
 
       # Specifies the scope name of the share.
       property :scope_name, String,
-               description: "The scope name of the share.",
-               default: "*"
+        description: "The scope name of the share.",
+        default: "*"
 
       # Specifies the continuous availability time-out for the share.
       property :ca_timeout, Integer,
-               description: "The continuous availability time-out for the share.",
-               default: 0
+        description: "The continuous availability time-out for the share.",
+        default: 0
 
       # Indicates that the share is continuously available.
       property :continuously_available, [TrueClass, FalseClass],
-               description: "Indicates that the share is continuously available.",
-               default: false
+        description: "Indicates that the share is continuously available.",
+        default: false
 
       # Specifies the caching mode of the offline files for the SMB share.
       # property :caching_mode, String, equal_to: %w(None Manual Documents Programs BranchCache)
 
       # Specifies the maximum number of concurrently connected users that the new SMB share may accommodate. If this parameter is set to zero (0), then the number of users is unlimited.
       property :concurrent_user_limit, Integer,
-               description: "The maximum number of concurrently connected users the share can accommodate.",
-               default: 0
+        description: "The maximum number of concurrently connected users the share can accommodate.",
+        default: 0
 
       # Indicates that the share is encrypted.
       property :encrypt_data, [TrueClass, FalseClass],
-               description: "Indicates that the share is encrypted.",
-               default: false
+        description: "Indicates that the share is encrypted.",
+        default: false
 
       # Specifies which files and folders in the SMB share are visible to users. AccessBased: SMB does not the display the files and folders for a share to a user unless that user has rights to access the files and folders. By default, access-based enumeration is disabled for new SMB shares. Unrestricted: SMB displays files and folders to a user even when the user does not have permission to access the items.
       # property :folder_enumeration_mode, String, equal_to: %(AccessBased Unrestricted)
@@ -160,6 +160,7 @@ class Chef
 
         json_results.each do |perm|
           next unless perm["AccessControlType"] == 0 # allow
+
           case perm["AccessRight"]
           when 0 then f_users << stripped_account(perm["AccountName"]) # 0 full control
           when 1 then c_users << stripped_account(perm["AccountName"]) # 1 == change
@@ -172,7 +173,7 @@ class Chef
 # local names are returned from Get-SmbShareAccess in the full format MACHINE\\NAME
 # but users of this resource would simply say NAME so we need to strip the values for comparison
       def stripped_account(name)
-        name.slice!("#{node['hostname']}\\")
+        name.slice!("#{node["hostname"]}\\")
         name
       end
 
@@ -218,6 +219,7 @@ class Chef
         def different_path?
           return false if current_resource.nil? # going from nil to something isn't different for our concerns
           return false if current_resource.path == Chef::Util::PathHelper.cleanpath(new_resource.path)
+
           true
         end
 
@@ -274,6 +276,7 @@ class Chef
             # set permissions for a brand new share OR
             # update permissions if the current state and desired state differ
             next unless permissions_need_update?(perm_type)
+
             grant_command = "Grant-SmbShareAccess -Name '#{new_resource.share_name}' -AccountName \"#{new_resource.send("#{perm_type}_users").join('","')}\" -Force -AccessRight #{perm_type}"
 
             Chef::Log.debug("Running '#{grant_command}' to update the share permissions")

data/lib/chef/resource/windows_shortcut.rb

@@ -28,23 +28,23 @@ class Chef
       introduced "14.0"
 
       property :shortcut_name, String,
-               description: "An optional property to set the shortcut name if it differs from the resource block's name.",
-               name_property: true
+        description: "An optional property to set the shortcut name if it differs from the resource block's name.",
+        name_property: true
 
       property :target, String,
-               description: "The destination that the shortcut links to."
+        description: "The destination that the shortcut links to."
 
       property :arguments, String,
-               description: "Arguments to pass to the target when the shortcut is executed."
+        description: "Arguments to pass to the target when the shortcut is executed."
 
       property :description, String,
-               description: "The description of the shortcut"
+        description: "The description of the shortcut"
 
       property :cwd, String,
-               description: "Working directory to use when the target is executed."
+        description: "Working directory to use when the target is executed."
 
       property :iconlocation, String,
-               description: "Icon to use for the shortcut. Accepts the format of 'path, index', where index is the icon file to use. See https://msdn.microsoft.com/en-us/library/3s9bx7at.aspx for details"
+        description: "Icon to use for the shortcut. Accepts the format of 'path, index', where index is the icon file to use. See https://msdn.microsoft.com/en-us/library/3s9bx7at.aspx for details"
 
       load_current_value do |desired|
         require "win32ole" if RUBY_PLATFORM =~ /mswin|mingw32|windows/

data/lib/chef/resource/windows_task.rb

@@ -31,98 +31,98 @@ class Chef
       allowed_actions :create, :delete, :run, :end, :enable, :disable, :change
       default_action :create
 
-      property :task_name, String, regex: [/\A[^\/\:\*\?\<\>\|]+\z/],
+      property :task_name, String, regex: [%r{\A[^/\:\*\?\<\>\|]+\z}],
                description: "An optional property to set the task name if it differs from the resource block's name. Example: 'Task Name' or '/Task Name'",
                name_property: true
 
       property :command, String,
-               description: "The command to be executed by the windows scheduled task."
+        description: "The command to be executed by the windows scheduled task."
 
       property :cwd, String,
-               description: "The directory the task will be run from."
+        description: "The directory the task will be run from."
 
       property :user, String,
-               description: "The user to run the task as.",
-               default: lazy { Chef::ReservedNames::Win32::Security::SID.LocalSystem.account_simple_name if Chef::Platform.windows? },
-               default_description: "The localized SYSTEM user for the node."
+        description: "The user to run the task as.",
+        default: lazy { Chef::ReservedNames::Win32::Security::SID.LocalSystem.account_simple_name if Chef::Platform.windows? },
+        default_description: "The localized SYSTEM user for the node."
 
       property :password, String,
-               description: "The user’s password. The user property must be set if using this property."
+        description: "The user’s password. The user property must be set if using this property."
 
-      property :run_level, Symbol, equal_to: [:highest, :limited],
+      property :run_level, Symbol, equal_to: %i{highest limited},
                description: "Run with ':limited' or ':highest' privileges.",
                default: :limited
 
       property :force, [TrueClass, FalseClass],
-               description: "When used with create, will update the task.",
-               default: false
+        description: "When used with create, will update the task.",
+        default: false
 
       property :interactive_enabled, [TrueClass, FalseClass],
-               description: "Allow task to run interactively or non-interactively. Requires user and password to also be set.",
-               default: false
+        description: "Allow task to run interactively or non-interactively. Requires user and password to also be set.",
+        default: false
 
       property :frequency_modifier, [Integer, String],
-               default: 1
-
-      property :frequency, Symbol, equal_to: [:minute,
-                                              :hourly,
-                                              :daily,
-                                              :weekly,
-                                              :monthly,
-                                              :once,
-                                              :on_logon,
-                                              :onstart,
-                                              :on_idle,
-                                              :none],
+        default: 1
+
+      property :frequency, Symbol, equal_to: %i{minute
+                                              hourly
+                                              daily
+                                              weekly
+                                              monthly
+                                              once
+                                              on_logon
+                                              onstart
+                                              on_idle
+                                              none},
                description: "The frequency with which to run the task."
 
       property :start_day, String,
-               description: "Specifies the first date on which the task runs in MM/DD/YYYY format."
+        description: "Specifies the first date on which the task runs in MM/DD/YYYY format."
 
       property :start_time, String,
-               description: "Specifies the start time to run the task, in HH:mm format."
+        description: "Specifies the start time to run the task, in HH:mm format."
 
       property :day, [String, Integer],
-               description: "The day(s) on which the task runs."
+        description: "The day(s) on which the task runs."
 
       property :months, String,
-               description: "The Months of the year on which the task runs, such as: 'JAN, FEB' or '\*'. Multiple months should be comma delimited. e.g. 'Jan, Feb, Mar, Dec'."
+        description: "The Months of the year on which the task runs, such as: 'JAN, FEB' or '\*'. Multiple months should be comma delimited. e.g. 'Jan, Feb, Mar, Dec'."
 
       property :idle_time, Integer,
-               description: "For :on_idle frequency, the time (in minutes) without user activity that must pass to trigger the task, from 1 - 999."
+        description: "For :on_idle frequency, the time (in minutes) without user activity that must pass to trigger the task, from 1 - 999."
 
       property :random_delay, [String, Integer],
-               description: "Delays the task up to a given time (in seconds)."
+        description: "Delays the task up to a given time (in seconds)."
 
       property :execution_time_limit, [String, Integer],
-               description: "The maximum time (in seconds) the task will run.",
-               default: "PT72H" # 72 hours in ISO8601 duration format
+        description: "The maximum time (in seconds) the task will run.",
+        default: "PT72H" # 72 hours in ISO8601 duration format
 
       property :minutes_duration, [String, Integer],
-               description: ""
+        description: ""
 
       property :minutes_interval, [String, Integer],
-               description: ""
+        description: ""
 
       property :priority, Integer,
-               description: "Use to set Priority Levels range from 0 to 10.",
-               default: 7, callbacks: { "should be in range of 0 to 10" => proc { |v| v >= 0 && v <= 10 } }
+        description: "Use to set Priority Levels range from 0 to 10.",
+        default: 7, callbacks: { "should be in range of 0 to 10" => proc { |v| v >= 0 && v <= 10 } }
 
       property :disallow_start_if_on_batteries, [TrueClass, FalseClass],
-               introduced: "14.4", default: false,
-               description: "Disallow start of the task if the system is running on battery power."
+        introduced: "14.4", default: false,
+        description: "Disallow start of the task if the system is running on battery power."
 
       property :stop_if_going_on_batteries, [TrueClass, FalseClass],
-               introduced: "14.4", default: false,
-               description: "Scheduled task option when system is switching on battery."
+        introduced: "14.4", default: false,
+        description: "Scheduled task option when system is switching on battery."
 
       property :description, String,
-               introduced: "14.7",
-               description: "The task description."
+        introduced: "14.7",
+        description: "The task description."
 
       property :start_when_available, [TrueClass, FalseClass],
-               introduced: "15.0", default: false,
-               description: "To start the task at any time after its scheduled time has passed."
+        introduced: "15.0", default: false,
+        description: "To start the task at any time after its scheduled time has passed."
 
       attr_accessor :exists, :task, :command_arguments
 
@@ -140,6 +140,7 @@ class Chef
         if execution_time_limit
           execution_time_limit(259200) if execution_time_limit == "PT72H"
           raise ArgumentError, "Invalid value passed for `execution_time_limit`. Please pass seconds as an Integer (e.g. 60) or a String with numeric values only (e.g. '60')." unless numeric_value_in_string?(execution_time_limit)
+
           execution_time_limit(sec_to_min(execution_time_limit))
         end
 
@@ -174,7 +175,7 @@ class Chef
       end
 
       def validate_frequency(frequency)
-        if frequency.nil? || !([:minute, :hourly, :daily, :weekly, :monthly, :once, :on_logon, :onstart, :on_idle, :none].include?(frequency))
+        if frequency.nil? || !(%i{minute hourly daily weekly monthly once on_logon onstart on_idle none}.include?(frequency))
           raise ArgumentError, "Frequency needs to be provided. Valid frequencies are :minute, :hourly, :daily, :weekly, :monthly, :once, :on_logon, :onstart, :on_idle, :none."
         end
       end
@@ -200,7 +201,7 @@ class Chef
       end
 
       def validate_random_delay(random_delay, frequency)
-        if [:on_logon, :onstart, :on_idle, :none].include? frequency
+        if %i{on_logon onstart on_idle none}.include? frequency
           raise ArgumentError, "`random_delay` property is supported only for frequency :once, :minute, :hourly, :daily, :weekly and :monthly"
         end
 
@@ -215,7 +216,7 @@ class Chef
 
         # make sure the start_day is in MM/DD/YYYY format: http://rubular.com/r/cgjHemtWl5
         if start_day
-          raise ArgumentError, "`start_day` property must be in the MM/DD/YYYY format." unless /^(0[1-9]|1[012])[- \/.](0[1-9]|[12][0-9]|3[01])[- \/.](19|20)\d\d$/ =~ start_day
+          raise ArgumentError, "`start_day` property must be in the MM/DD/YYYY format." unless %r{^(0[1-9]|1[012])[- /.](0[1-9]|[12][0-9]|3[01])[- /.](19|20)\d\d$} =~ start_day
         end
       end
 
@@ -255,7 +256,7 @@ class Chef
       alias non_system_user? password_required?
 
       def validate_create_frequency_modifier(frequency, frequency_modifier)
-        if ([:on_logon, :onstart, :on_idle, :none].include?(frequency)) && ( frequency_modifier != 1)
+        if (%i{on_logon onstart on_idle none}.include?(frequency)) && ( frequency_modifier != 1)
           raise ArgumentError, "frequency_modifier property not supported with frequency :#{frequency}"
         end
 
@@ -287,7 +288,7 @@ class Chef
       end
 
       def validate_create_day(day, frequency, frequency_modifier)
-        raise ArgumentError, "day property is only valid for tasks that run monthly or weekly" unless [:weekly, :monthly].include?(frequency)
+        raise ArgumentError, "day property is only valid for tasks that run monthly or weekly" unless %i{weekly monthly}.include?(frequency)
 
         # This has been verified with schtask.exe https://docs.microsoft.com/en-us/windows-server/administration/windows-commands/schtasks#d-dayday--
         # verified with earlier code if day "*" is given with frequency it raised exception Invalid value for /D option
@@ -301,7 +302,7 @@ class Chef
           else
             days.map! { |day| day.to_s.strip.downcase }
             unless (days - VALID_WEEK_DAYS).empty?
-              raise ArgumentError, "day property invalid. Only valid values are: #{VALID_WEEK_DAYS.map(&:upcase).join(', ')}. Multiple values must be separated by a comma."
+              raise ArgumentError, "day property invalid. Only valid values are: #{VALID_WEEK_DAYS.map(&:upcase).join(", ")}. Multiple values must be separated by a comma."
             end
           end
         end
@@ -309,11 +310,12 @@ class Chef
 
       def validate_create_months(months, frequency)
         raise ArgumentError, "months property is only valid for tasks that run monthly" if frequency != :monthly
+
         if months.is_a?(String)
           months = months.split(",")
           months.map! { |month| month.strip.upcase }
           unless (months - VALID_MONTHS).empty?
-            raise ArgumentError, "months property invalid. Only valid values are: #{VALID_MONTHS.join(', ')}. Multiple values must be separated by a comma."
+            raise ArgumentError, "months property invalid. Only valid values are: #{VALID_MONTHS.join(", ")}. Multiple values must be separated by a comma."
           end
         end
       end