chef 15.1.36-universal-mingw32 → 15.2.20-universal-mingw32

data/lib/chef/resource/windows_dfs_server.rb

@@ -28,27 +28,27 @@ class Chef
       introduced "15.0"
 
       property :use_fqdn, [TrueClass, FalseClass],
-               description: "Indicates whether a DFS namespace server uses FQDNs in referrals. If this parameter has a value of true, the server uses FQDNs in referrals. If this parameter has a value of false, the server uses NetBIOS names.",
-               default: false
+        description: "Indicates whether a DFS namespace server uses FQDNs in referrals. If this parameter has a value of true, the server uses FQDNs in referrals. If this parameter has a value of false, the server uses NetBIOS names.",
+        default: false
 
       property :ldap_timeout_secs, Integer,
-               description: "",
-               default: 30
+        description: "",
+        default: 30
 
       property :prefer_login_dc, [TrueClass, FalseClass],
-               description: "",
-               default: false
+        description: "",
+        default: false
 
       property :enable_site_costed_referrals, [TrueClass, FalseClass],
-               description: "",
-               default: false
+        description: "",
+        default: false
 
       property :sync_interval_secs, Integer,
-               description: "",
-               default: 3600
+        description: "",
+        default: 3600
 
       load_current_value do
-        ps_results = powershell_out("Get-DfsnServerConfiguration -ComputerName '#{ENV['COMPUTERNAME']}' | Select LdapTimeoutSec, PreferLogonDC, EnableSiteCostedReferrals, SyncIntervalSec, UseFqdn | ConvertTo-Json")
+        ps_results = powershell_out("Get-DfsnServerConfiguration -ComputerName '#{ENV["COMPUTERNAME"]}' | Select LdapTimeoutSec, PreferLogonDC, EnableSiteCostedReferrals, SyncIntervalSec, UseFqdn | ConvertTo-Json")
 
         if ps_results.error?
           raise "The dfs_server resource failed to fetch the current state via the Get-DfsnServerConfiguration PowerShell cmlet. Is the DFS Windows feature installed?"
@@ -68,7 +68,7 @@ class Chef
         description "Configure DFS settings."
 
         converge_if_changed do
-          powershell_out("Set-DfsnServerConfiguration -ComputerName '#{ENV['COMPUTERNAME']}' EnableSiteCostedReferrals $#{new_resource.enable_site_costed_referrals} -UseFqdn $#{new_resource.use_fqdn} -LdapTimeoutSec #{new_resource.ldap_timeout_secs} -PreferLogonDC $#{new_resource.prefer_login_dc} -SyncIntervalSec #{new_resource.sync_interval_secs}")
+          powershell_out("Set-DfsnServerConfiguration -ComputerName '#{ENV["COMPUTERNAME"]}' EnableSiteCostedReferrals $#{new_resource.enable_site_costed_referrals} -UseFqdn $#{new_resource.use_fqdn} -LdapTimeoutSec #{new_resource.ldap_timeout_secs} -PreferLogonDC $#{new_resource.prefer_login_dc} -SyncIntervalSec #{new_resource.sync_interval_secs}")
         end
       end
     end

data/lib/chef/resource/windows_dns_record.rb

@@ -28,20 +28,20 @@ class Chef
       introduced "15.0"
 
       property :record_name, String,
-               description: "An optional property to set the dns record name if it differs from the resource block's name.",
-               name_property: true
+        description: "An optional property to set the dns record name if it differs from the resource block's name.",
+        name_property: true
 
       property :zone, String,
-               description: "The zone to create the record in.",
-               required: true
+        description: "The zone to create the record in.",
+        required: true
 
       property :target, String,
-               description: "The target for the record.",
-               required: true
+        description: "The target for the record.",
+        required: true
 
       property :record_type, String,
-               description: "The type of record to create, can be either ARecord, CNAME or PTR.",
-               default: "ARecord", equal_to: %w{ARecord CNAME PTR}
+        description: "The type of record to create, can be either ARecord, CNAME or PTR.",
+        default: "ARecord", equal_to: %w{ARecord CNAME PTR}
 
       action :create do
         description "Creates and updates the DNS entry."

data/lib/chef/resource/windows_dns_zone.rb

@@ -28,16 +28,16 @@ class Chef
       introduced "15.0"
 
       property :zone_name, String,
-               description: "An optional property to set the dns zone name if it differs from the resource block's name.",
-               name_property: true
+        description: "An optional property to set the dns zone name if it differs from the resource block's name.",
+        name_property: true
 
       property :replication_scope, String,
-               description: "The replication scope for the zone, required if server_type set to 'Domain'.",
-               default: "Domain"
+        description: "The replication scope for the zone, required if server_type set to 'Domain'.",
+        default: "Domain"
 
       property :server_type, String,
-               description: "The type of DNS server, Domain or Standalone.",
-               default: "Domain", equal_to: %w{Domain Standalone}
+        description: "The type of DNS server, Domain or Standalone.",
+        default: "Domain", equal_to: %w{Domain Standalone}
 
       action :create do
         description "Creates and updates a DNS Zone."

data/lib/chef/resource/windows_env.rb

@@ -32,16 +32,16 @@ class Chef
       allowed_actions :create, :delete, :modify
 
       property :key_name, String,
-               description: "An optional property to set the name of the key that is to be created, deleted, or modified if it differs from the resource block's name.",
-               identity: true, name_property: true
+        description: "An optional property to set the name of the key that is to be created, deleted, or modified if it differs from the resource block's name.",
+        identity: true, name_property: true
 
       property :value, String,
-               description: "The value of the environmental variable to set.",
-               required: true
+        description: "The value of the environmental variable to set.",
+        required: true
 
       property :delim, [ String, nil, false ],
-               description: "The delimiter that is used to separate multiple values for a single key.",
-               desired_state: false
+        description: "The delimiter that is used to separate multiple values for a single key.",
+        desired_state: false
 
       property :user, String, default: "<System>"
     end

data/lib/chef/resource/windows_feature.rb

@@ -28,28 +28,28 @@ class Chef
       introduced "14.0"
 
       property :feature_name, [Array, String],
-               description: "The name of the feature(s) or role(s) to install if they differ from the resource block's name. The same feature may have different names depending on the underlying installation method being used (ie DHCPServer vs DHCP; DNS-Server-Full-Role vs DNS).",
-               name_property: true
+        description: "The name of the feature(s) or role(s) to install if they differ from the resource block's name. The same feature may have different names depending on the underlying installation method being used (ie DHCPServer vs DHCP; DNS-Server-Full-Role vs DNS).",
+        name_property: true
 
       property :source, String,
-               description: "Specify a local repository for the feature install."
+        description: "Specify a local repository for the feature install."
 
       property :all, [TrueClass, FalseClass],
-               description: "Install all sub features.",
-               default: false
+        description: "Install all sub features.",
+        default: false
 
       property :management_tools, [TrueClass, FalseClass],
-               description: "Install all applicable management tools for the roles, role services, or features (PowerShell-only).",
-               default: false
+        description: "Install all applicable management tools for the roles, role services, or features (PowerShell-only).",
+        default: false
 
       property :install_method, Symbol,
-               description: "The underlying installation method to use for feature installation. Specify ':windows_feature_dism' for DISM or ':windows_feature_powershell' for PowerShell.",
-               equal_to: [:windows_feature_dism, :windows_feature_powershell, :windows_feature_servermanagercmd],
-               default: :windows_feature_dism
+        description: "The underlying installation method to use for feature installation. Specify ':windows_feature_dism' for DISM or ':windows_feature_powershell' for PowerShell.",
+        equal_to: %i{windows_feature_dism windows_feature_powershell windows_feature_servermanagercmd},
+        default: :windows_feature_dism
 
       property :timeout, Integer,
-               description: "Specifies a timeout (in seconds) for the feature installation.",
-               default: 600
+        description: "Specifies a timeout (in seconds) for the feature installation.",
+        default: 600
 
       action :install do
         description "Install a Windows role/feature"

data/lib/chef/resource/windows_feature_dism.rb

@@ -29,20 +29,20 @@ class Chef
       introduced "14.0"
 
       property :feature_name, [Array, String],
-               description: "The name of the feature(s) or role(s) to install if they differ from the resource name.",
-               coerce: proc { |x| to_formatted_array(x) },
-               name_property: true
+        description: "The name of the feature(s) or role(s) to install if they differ from the resource name.",
+        coerce: proc { |x| to_formatted_array(x) },
+        name_property: true
 
       property :source, String,
-               description: "Specify a local repository for the feature install."
+        description: "Specify a local repository for the feature install."
 
       property :all, [TrueClass, FalseClass],
-               description: "Install all sub-features. When set to 'true', this is the equivalent of specifying the /All switch to dism.exe",
-               default: false
+        description: "Install all sub-features. When set to 'true', this is the equivalent of specifying the /All switch to dism.exe",
+        default: false
 
       property :timeout, Integer,
-               description: "Specifies a timeout (in seconds) for the feature installation.",
-               default: 600
+        description: "Specifies a timeout (in seconds) for the feature installation.",
+        default: 600
 
       # @return [Array] lowercase the array unless we're on < Windows 2012
       def to_formatted_array(x)
@@ -58,17 +58,18 @@ class Chef
         reload_cached_dism_data unless node["dism_features_cache"]
         fail_if_unavailable # fail if the features don't exist
 
-        logger.trace("Windows features needing installation: #{features_to_install.empty? ? 'none' : features_to_install.join(',')}")
+        logger.trace("Windows features needing installation: #{features_to_install.empty? ? "none" : features_to_install.join(",")}")
         unless features_to_install.empty?
-          message = "install Windows feature#{'s' if features_to_install.count > 1} #{features_to_install.join(',')}"
+          message = "install Windows feature#{"s" if features_to_install.count > 1} #{features_to_install.join(",")}"
           converge_by(message) do
-            install_command = "dism.exe /online /enable-feature #{features_to_install.map { |f| "/featurename:#{f}" }.join(' ')} /norestart"
+            install_command = "dism.exe /online /enable-feature #{features_to_install.map { |f| "/featurename:#{f}" }.join(" ")} /norestart"
             install_command << " /LimitAccess /Source:\"#{new_resource.source}\"" if new_resource.source
             install_command << " /All" if new_resource.all
             begin
               shell_out!(install_command, returns: [0, 42, 127, 3010], timeout: new_resource.timeout)
             rescue Mixlib::ShellOut::ShellCommandFailed => e
               raise "Error 50 returned by DISM related to parent features, try setting the 'all' property to 'true' on the 'windows_feature_dism' resource." if required_parent_feature?(e.inspect)
+
               raise e.message
             end
 
@@ -82,12 +83,12 @@ class Chef
 
         reload_cached_dism_data unless node["dism_features_cache"]
 
-        logger.trace("Windows features needing removal: #{features_to_remove.empty? ? 'none' : features_to_remove.join(',')}")
+        logger.trace("Windows features needing removal: #{features_to_remove.empty? ? "none" : features_to_remove.join(",")}")
         unless features_to_remove.empty?
-          message = "remove Windows feature#{'s' if features_to_remove.count > 1} #{features_to_remove.join(',')}"
+          message = "remove Windows feature#{"s" if features_to_remove.count > 1} #{features_to_remove.join(",")}"
 
           converge_by(message) do
-            shell_out!("dism.exe /online /disable-feature #{features_to_remove.map { |f| "/featurename:#{f}" }.join(' ')} /norestart", returns: [0, 42, 127, 3010], timeout: new_resource.timeout)
+            shell_out!("dism.exe /online /disable-feature #{features_to_remove.map { |f| "/featurename:#{f}" }.join(" ")} /norestart", returns: [0, 42, 127, 3010], timeout: new_resource.timeout)
 
             reload_cached_dism_data # Reload cached dism feature state
           end
@@ -103,11 +104,11 @@ class Chef
 
         fail_if_unavailable # fail if the features don't exist
 
-        logger.trace("Windows features needing deletion: #{features_to_delete.empty? ? 'none' : features_to_delete.join(',')}")
+        logger.trace("Windows features needing deletion: #{features_to_delete.empty? ? "none" : features_to_delete.join(",")}")
         unless features_to_delete.empty?
-          message = "delete Windows feature#{'s' if features_to_delete.count > 1} #{features_to_delete.join(',')} from the image"
+          message = "delete Windows feature#{"s" if features_to_delete.count > 1} #{features_to_delete.join(",")} from the image"
           converge_by(message) do
-            shell_out!("dism.exe /online /disable-feature #{features_to_delete.map { |f| "/featurename:#{f}" }.join(' ')} /Remove /norestart", returns: [0, 42, 127, 3010], timeout: new_resource.timeout)
+            shell_out!("dism.exe /online /disable-feature #{features_to_delete.map { |f| "/featurename:#{f}" }.join(" ")} /Remove /norestart", returns: [0, 42, 127, 3010], timeout: new_resource.timeout)
 
             reload_cached_dism_data # Reload cached dism feature state
           end
@@ -158,7 +159,7 @@ class Chef
 
           # the difference of desired features to install to all features is what's not available
           unavailable = (new_resource.feature_name - all_available)
-          raise "The Windows feature#{'s' if unavailable.count > 1} #{unavailable.join(',')} #{unavailable.count > 1 ? 'are' : 'is'} not available on this version of Windows. Run 'dism /online /Get-Features' to see the list of available feature names." unless unavailable.empty?
+          raise "The Windows feature#{"s" if unavailable.count > 1} #{unavailable.join(",")} #{unavailable.count > 1 ? "are" : "is"} not available on this version of Windows. Run 'dism /online /Get-Features' to see the list of available feature names." unless unavailable.empty?
         end
 
         # run dism.exe to get a list of all available features and their state
@@ -189,7 +190,7 @@ class Chef
               add_to_feature_mash("disabled", feature_details_raw)
             end
           end
-          logger.trace("The cache contains\n#{node['dism_features_cache']}")
+          logger.trace("The cache contains\n#{node["dism_features_cache"]}")
         end
 
         # parse the feature string and add the values to the appropriate array

data/lib/chef/resource/windows_feature_powershell.rb

@@ -31,24 +31,24 @@ class Chef
       introduced "14.0"
 
       property :feature_name, [Array, String],
-               description: "The name of the feature(s) or role(s) to install if they differ from the resource block's name.",
-               coerce: proc { |x| to_formatted_array(x) },
-               name_property: true
+        description: "The name of the feature(s) or role(s) to install if they differ from the resource block's name.",
+        coerce: proc { |x| to_formatted_array(x) },
+        name_property: true
 
       property :source, String,
-               description: "Specify a local repository for the feature install."
+        description: "Specify a local repository for the feature install."
 
       property :all, [TrueClass, FalseClass],
-               description: "Install all subfeatures. When set to 'true', this is the equivalent of specifying the '-InstallAllSubFeatures' switch with 'Add-WindowsFeature'.",
-               default: false
+        description: "Install all subfeatures. When set to 'true', this is the equivalent of specifying the '-InstallAllSubFeatures' switch with 'Add-WindowsFeature'.",
+        default: false
 
       property :timeout, Integer,
-               description: "Specifies a timeout (in seconds) for the feature installation.",
-               default: 600
+        description: "Specifies a timeout (in seconds) for the feature installation.",
+        default: 600
 
       property :management_tools, [TrueClass, FalseClass],
-               description: "Install all applicable management tools for the roles, role services, or features.",
-               default: false
+        description: "Install all applicable management tools for the roles, role services, or features.",
+        default: false
 
       # Converts strings of features into an Array. Array objects are lowercased unless we're on < 8/2k12+.
       # @return [Array] array of features
@@ -68,10 +68,10 @@ class Chef
         fail_if_unavailable # fail if the features don't exist
         fail_if_removed # fail if the features are in removed state
 
-        Chef::Log.debug("Windows features needing installation: #{features_to_install.empty? ? 'none' : features_to_install.join(',')}")
+        Chef::Log.debug("Windows features needing installation: #{features_to_install.empty? ? "none" : features_to_install.join(",")}")
         unless features_to_install.empty?
-          converge_by("install Windows feature#{'s' if features_to_install.count > 1} #{features_to_install.join(',')}") do
-            install_command = "#{install_feature_cmdlet} #{features_to_install.join(',')}"
+          converge_by("install Windows feature#{"s" if features_to_install.count > 1} #{features_to_install.join(",")}") do
+            install_command = "#{install_feature_cmdlet} #{features_to_install.join(",")}"
             install_command << " -IncludeAllSubFeature"  if new_resource.all
             if older_than_win_2012_or_8? && (new_resource.source || new_resource.management_tools)
               Chef::Log.warn("The 'source' and 'management_tools' properties are only available on Windows 8/2012 or greater. Skipping these properties!")
@@ -93,11 +93,11 @@ class Chef
 
         reload_cached_powershell_data unless node["powershell_features_cache"]
 
-        Chef::Log.debug("Windows features needing removal: #{features_to_remove.empty? ? 'none' : features_to_remove.join(',')}")
+        Chef::Log.debug("Windows features needing removal: #{features_to_remove.empty? ? "none" : features_to_remove.join(",")}")
 
         unless features_to_remove.empty?
-          converge_by("remove Windows feature#{'s' if features_to_remove.count > 1} #{features_to_remove.join(',')}") do
-            cmd = powershell_out!("#{remove_feature_cmdlet} #{features_to_remove.join(',')}", timeout: new_resource.timeout)
+          converge_by("remove Windows feature#{"s" if features_to_remove.count > 1} #{features_to_remove.join(",")}") do
+            cmd = powershell_out!("#{remove_feature_cmdlet} #{features_to_remove.join(",")}", timeout: new_resource.timeout)
             Chef::Log.info(cmd.stdout)
 
             reload_cached_powershell_data # Reload cached powershell feature state
@@ -113,11 +113,11 @@ class Chef
 
         fail_if_unavailable # fail if the features don't exist
 
-        Chef::Log.debug("Windows features needing deletion: #{features_to_delete.empty? ? 'none' : features_to_delete.join(',')}")
+        Chef::Log.debug("Windows features needing deletion: #{features_to_delete.empty? ? "none" : features_to_delete.join(",")}")
 
         unless features_to_delete.empty?
-          converge_by("delete Windows feature#{'s' if features_to_delete.count > 1} #{features_to_delete.join(',')} from the image") do
-            cmd = powershell_out!("Uninstall-WindowsFeature #{features_to_delete.join(',')} -Remove", timeout: new_resource.timeout)
+          converge_by("delete Windows feature#{"s" if features_to_delete.count > 1} #{features_to_delete.join(",")} from the image") do
+            cmd = powershell_out!("Uninstall-WindowsFeature #{features_to_delete.join(",")} -Remove", timeout: new_resource.timeout)
             Chef::Log.info(cmd.stdout)
 
             reload_cached_powershell_data # Reload cached powershell feature state
@@ -132,6 +132,7 @@ class Chef
         def powershell_version
           cmd = powershell_out("$PSVersionTable.psversion.major")
           return 1 if cmd.stdout.empty? # PowerShell 1.0 doesn't have a $PSVersionTable
+
           Regexp.last_match(1).to_i if cmd.stdout =~ /^(\d+)/
         rescue Errno::ENOENT
           0 # zero as in nothing is installed
@@ -195,7 +196,7 @@ class Chef
 
           # the difference of desired features to install to all features is what's not available
           unavailable = (new_resource.feature_name - all_available)
-          raise "The Windows feature#{'s' if unavailable.count > 1} #{unavailable.join(',')} #{unavailable.count > 1 ? 'are' : 'is'} not available on this version of Windows. Run 'Get-WindowsFeature' to see the list of available feature names." unless unavailable.empty?
+          raise "The Windows feature#{"s" if unavailable.count > 1} #{unavailable.join(",")} #{unavailable.count > 1 ? "are" : "is"} not available on this version of Windows. Run 'Get-WindowsFeature' to see the list of available feature names." unless unavailable.empty?
         end
 
         # run Get-WindowsFeature to get a list of all available features and their state
@@ -218,7 +219,7 @@ class Chef
               add_to_feature_mash("disabled", feature_details_raw["Name"])
             end
           end
-          Chef::Log.debug("The powershell cache contains\n#{node['powershell_features_cache']}")
+          Chef::Log.debug("The powershell cache contains\n#{node["powershell_features_cache"]}")
         end
 
         # fetch the list of available feature names and state in JSON and parse the JSON
@@ -245,11 +246,12 @@ class Chef
         # @return [void]
         def fail_if_removed
           return if new_resource.source # if someone provides a source then all is well
+
           if node["platform_version"].to_f > 6.2 # 2012R2 or later
             return if registry_key_exists?('HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Policies\Servicing') && registry_value_exists?('HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Policies\Servicing', name: "LocalSourcePath") # if source is defined in the registry, still fine
           end
           removed = new_resource.feature_name & node["powershell_features_cache"]["removed"]
-          raise "The Windows feature#{'s' if removed.count > 1} #{removed.join(',')} #{removed.count > 1 ? 'are' : 'is'} removed from the host and cannot be installed." unless removed.empty?
+          raise "The Windows feature#{"s" if removed.count > 1} #{removed.join(",")} #{removed.count > 1 ? "are" : "is"} removed from the host and cannot be installed." unless removed.empty?
         end
 
         # Fail unless we're on windows 8+ / 2012+ where deleting a feature is supported

data/lib/chef/resource/windows_firewall_rule.rb

@@ -30,62 +30,62 @@ class Chef
       introduced "14.7"
 
       property :rule_name, String,
-               name_property: true,
-               description: "An optional property to set the name of the firewall rule to assign if it differs from the resource block's name."
+        name_property: true,
+        description: "An optional property to set the name of the firewall rule to assign if it differs from the resource block's name."
 
       property :description, String,
-               default: "Firewall rule",
-               description: "The description to assign to the firewall rule."
+        default: "Firewall rule",
+        description: "The description to assign to the firewall rule."
 
       property :local_address, String,
-               description: "The local address the firewall rule applies to."
+        description: "The local address the firewall rule applies to."
 
       property :local_port, [String, Integer, Array],
                # split various formats of comma separated lists and provide a sorted array of strings to match PS output
-               coerce: proc { |d| d.is_a?(String) ? d.split(/\s*,\s*/).sort : Array(d).sort.map { |x| x.to_s } },
-               description: "The local port the firewall rule applies to."
+        coerce: proc { |d| d.is_a?(String) ? d.split(/\s*,\s*/).sort : Array(d).sort.map(&:to_s) },
+        description: "The local port the firewall rule applies to."
 
       property :remote_address, String,
-               description: "The remote address the firewall rule applies to."
+        description: "The remote address the firewall rule applies to."
 
       property :remote_port, [String, Integer, Array],
                # split various formats of comma separated lists and provide a sorted array of strings to match PS output
-               coerce: proc { |d| d.is_a?(String) ? d.split(/\s*,\s*/).sort : Array(d).sort.map { |x| x.to_s } },
-               description: "The remote port the firewall rule applies to."
+        coerce: proc { |d| d.is_a?(String) ? d.split(/\s*,\s*/).sort : Array(d).sort.map(&:to_s) },
+        description: "The remote port the firewall rule applies to."
 
       property :direction, [Symbol, String],
-               default: :inbound, equal_to: [:inbound, :outbound],
-               description: "The direction of the firewall rule. Direction means either inbound or outbound traffic.",
-               coerce: proc { |d| d.is_a?(String) ? d.downcase.to_sym : d }
+        default: :inbound, equal_to: %i{inbound outbound},
+        description: "The direction of the firewall rule. Direction means either inbound or outbound traffic.",
+        coerce: proc { |d| d.is_a?(String) ? d.downcase.to_sym : d }
 
       property :protocol, String,
-               default: "TCP",
-               description: "The protocol the firewall rule applies to."
+        default: "TCP",
+        description: "The protocol the firewall rule applies to."
 
       property :firewall_action, [Symbol, String],
-               default: :allow, equal_to: [:allow, :block, :notconfigured],
-               description: "The action of the firewall rule.",
-               coerce: proc { |f| f.is_a?(String) ? f.downcase.to_sym : f }
+        default: :allow, equal_to: %i{allow block notconfigured},
+        description: "The action of the firewall rule.",
+        coerce: proc { |f| f.is_a?(String) ? f.downcase.to_sym : f }
 
       property :profile, [Symbol, String],
-               default: :any, equal_to: [:public, :private, :domain, :any, :notapplicable],
-               description: "The profile the firewall rule applies to.",
-               coerce: proc { |p| p.is_a?(String) ? p.downcase.to_sym : p }
+        default: :any, equal_to: %i{public private domain any notapplicable},
+        description: "The profile the firewall rule applies to.",
+        coerce: proc { |p| p.is_a?(String) ? p.downcase.to_sym : p }
 
       property :program, String,
-               description: "The program the firewall rule applies to."
+        description: "The program the firewall rule applies to."
 
       property :service, String,
-               description: "The service the firewall rule applies to."
+        description: "The service the firewall rule applies to."
 
       property :interface_type, [Symbol, String],
-               default: :any, equal_to: [:any, :wireless, :wired, :remoteaccess],
-               description: "The interface type the firewall rule applies to.",
-               coerce: proc { |i| i.is_a?(String) ? i.downcase.to_sym : i }
+        default: :any, equal_to: %i{any wireless wired remoteaccess},
+        description: "The interface type the firewall rule applies to.",
+        coerce: proc { |i| i.is_a?(String) ? i.downcase.to_sym : i }
 
       property :enabled, [TrueClass, FalseClass],
-               default: true,
-               description: "Whether or not to enable the firewall rule."
+        default: true,
+        description: "Whether or not to enable the firewall rule."
 
       alias_method :localip, :local_address
       alias_method :remoteip, :remote_address
@@ -120,10 +120,10 @@ class Chef
 
         if current_resource
           converge_if_changed :rule_name, :local_address, :local_port, :remote_address, :remote_port, :direction,
-                              :protocol, :firewall_action, :profile, :program, :service, :interface_type, :enabled do
-            cmd = firewall_command("Set")
-            powershell_out!(cmd)
-          end
+            :protocol, :firewall_action, :profile, :program, :service, :interface_type, :enabled do
+              cmd = firewall_command("Set")
+              powershell_out!(cmd)
+            end
         else
           converge_by("create firewall rule #{new_resource.rule_name}") do
             cmd = firewall_command("New")
@@ -152,9 +152,9 @@ class Chef
           cmd << " -DisplayName '#{new_resource.rule_name}'" if cmdlet_type == "New"
           cmd << " -Description '#{new_resource.description}'" if new_resource.description
           cmd << " -LocalAddress '#{new_resource.local_address}'" if new_resource.local_address
-          cmd << " -LocalPort #{new_resource.local_port.join(',')}" if new_resource.local_port
+          cmd << " -LocalPort #{new_resource.local_port.join(",")}" if new_resource.local_port
           cmd << " -RemoteAddress '#{new_resource.remote_address}'" if new_resource.remote_address
-          cmd << " -RemotePort #{new_resource.remote_port.join(',')}" if new_resource.remote_port
+          cmd << " -RemotePort #{new_resource.remote_port.join(",")}" if new_resource.remote_port
           cmd << " -Direction '#{new_resource.direction}'" if new_resource.direction
           cmd << " -Protocol '#{new_resource.protocol}'" if new_resource.protocol
           cmd << " -Action '#{new_resource.firewall_action}'" if new_resource.firewall_action