chef 15.1.36-universal-mingw32 → 15.2.20-universal-mingw32

data/lib/chef/resource/paludis_package.rb

@@ -31,8 +31,8 @@ class Chef
       allowed_actions :install, :remove, :upgrade
 
       property :timeout, Integer,
-               description: "The amount of time (in seconds) to wait before timing out.",
-               default: 3600
+        description: "The amount of time (in seconds) to wait before timing out.",
+        default: 3600
     end
   end
 end

data/lib/chef/resource/powershell_package.rb

@@ -32,20 +32,20 @@ class Chef
       allowed_actions :install, :remove
 
       property :package_name, [String, Array],
-               description: "The name of the package. Default value: the name of the resource block.",
-               coerce: proc { |x| [x].flatten }
+        description: "The name of the package. Default value: the name of the resource block.",
+        coerce: proc { |x| [x].flatten }
 
       property :version, [String, Array],
-               description: "The version of a package to be installed or upgraded.",
-               coerce: proc { |x| [x].flatten }
+        description: "The version of a package to be installed or upgraded.",
+        coerce: proc { |x| [x].flatten }
 
       property :source, String,
-               description: "Specify the source of the package.",
-               introduced: "14.0"
+        description: "Specify the source of the package.",
+        introduced: "14.0"
 
       property :skip_publisher_check, [true, false],
-               description: "Skip validating module author.",
-               default: false, introduced: "14.3", desired_state: false
+        description: "Skip validating module author.",
+        default: false, introduced: "14.3", desired_state: false
 
     end
   end

data/lib/chef/resource/powershell_package_source.rb

@@ -27,31 +27,31 @@ class Chef
       introduced "14.3"
 
       property :source_name, String,
-               description: "The name of the package source.",
-               name_property: true
+        description: "The name of the package source.",
+        name_property: true
 
       property :url, String,
-               description: "The url to the package source.",
-               required: true
+        description: "The url to the package source.",
+        required: true
 
       property :trusted, [TrueClass, FalseClass],
-               description: "Whether or not to trust packages from this source.",
-               default: false
+        description: "Whether or not to trust packages from this source.",
+        default: false
 
       property :provider_name, String,
-               equal_to: %w{ Programs msi NuGet msu PowerShellGet psl chocolatey },
-               validation_message: "The following providers are supported: 'Programs', 'msi', 'NuGet', 'msu', 'PowerShellGet', 'psl' or 'chocolatey'",
-               description: "The package management provider for the source. It supports the following providers: 'Programs', 'msi', 'NuGet', 'msu', 'PowerShellGet', 'psl' and 'chocolatey'.",
-               default: "NuGet"
+        equal_to: %w{ Programs msi NuGet msu PowerShellGet psl chocolatey },
+        validation_message: "The following providers are supported: 'Programs', 'msi', 'NuGet', 'msu', 'PowerShellGet', 'psl' or 'chocolatey'",
+        description: "The package management provider for the source. It supports the following providers: 'Programs', 'msi', 'NuGet', 'msu', 'PowerShellGet', 'psl' and 'chocolatey'.",
+        default: "NuGet"
 
       property :publish_location, String,
-               description: "The url where modules will be published to for this source. Only valid if the provider is 'PowerShellGet'."
+        description: "The url where modules will be published to for this source. Only valid if the provider is 'PowerShellGet'."
 
       property :script_source_location, String,
-               description: "The url where scripts are located for this source. Only valid if the provider is 'PowerShellGet'."
+        description: "The url where scripts are located for this source. Only valid if the provider is 'PowerShellGet'."
 
       property :script_publish_location, String,
-               description: "The location where scripts will be published to for this source. Only valid if the provider is 'PowerShellGet'."
+        description: "The location where scripts will be published to for this source. Only valid if the provider is 'PowerShellGet'."
 
       load_current_value do
         cmd = load_resource_state_script(source_name)

data/lib/chef/resource/reboot.rb

@@ -36,12 +36,12 @@ class Chef
       default_action :nothing # make sure people are quite clear what they want
 
       property :reason, String,
-               description: "A string that describes the reboot action.",
-               default: "Reboot by #{Chef::Dist::PRODUCT}"
+        description: "A string that describes the reboot action.",
+        default: "Reboot by #{Chef::Dist::PRODUCT}"
 
       property :delay_mins, Integer,
-               description: "The amount of time (in minutes) to delay a reboot request.",
-               default: 0
+        description: "The amount of time (in minutes) to delay a reboot request.",
+        default: 0
     end
   end
 end

data/lib/chef/resource/registry_key.rb

@@ -86,10 +86,12 @@ class Chef
 
           @values.each do |v|
             raise ArgumentError, "Missing name key in RegistryKey values hash" unless v.key?(:name)
+
             v.each_key do |key|
-              raise ArgumentError, "Bad key #{key} in RegistryKey values hash" unless [:name, :type, :data].include?(key)
+              raise ArgumentError, "Bad key #{key} in RegistryKey values hash" unless %i{name type data}.include?(key)
             end
             raise ArgumentError, "Type of name => #{v[:name]} should be string" unless v[:name].is_a?(String)
+
             if v[:type]
               raise ArgumentError, "Type of type => #{v[:type]} should be symbol" unless v[:type].is_a?(Symbol)
             end
@@ -101,7 +103,7 @@ class Chef
       end
 
       property :recursive, [TrueClass, FalseClass], default: false
-      property :architecture, Symbol, default: :machine, equal_to: [:machine, :x86_64, :i386]
+      property :architecture, Symbol, default: :machine, equal_to: %i{machine x86_64 i386}
 
       private
 
@@ -121,7 +123,7 @@ class Chef
       # Some data types may raise errors when sent as json. Returns true if this
       # value's data may need to be converted to a checksum.
       def needs_checksum?(value)
-        unsafe_types = [:binary, :dword, :dword_big_endian, :qword]
+        unsafe_types = %i{binary dword dword_big_endian qword}
         unsafe_types.include?(value[:type])
       end
 

data/lib/chef/resource/remote_directory.rb

@@ -43,42 +43,42 @@ class Chef
 
       # This same property exists in the directory resource, but we need to change the default to true here.
       property :recursive, [ TrueClass, FalseClass ],
-               description: "Create or delete parent directories recursively. For the owner, group, and mode properties, the value of this attribute applies only to the leaf directory.",
-               default: true, desired_state: false
+        description: "Create or delete parent directories recursively. For the owner, group, and mode properties, the value of this attribute applies only to the leaf directory.",
+        default: true, desired_state: false
 
       property :source, String,
-               description: "The base name of the source file (and inferred from the path property).",
-               default_description: "The base portion of the 'path' property. For example '/some/path/' would be 'path'.",
-               default: lazy { ::File.basename(path) }, desired_state: false
+        description: "The base name of the source file (and inferred from the path property).",
+        default_description: "The base portion of the 'path' property. For example '/some/path/' would be 'path'.",
+        default: lazy { ::File.basename(path) }, desired_state: false
 
       property :files_backup, [ Integer, FalseClass ],
-               description: "The number of backup copies to keep for files in the directory.",
-               default: 5, desired_state: false
+        description: "The number of backup copies to keep for files in the directory.",
+        default: 5, desired_state: false
 
       property :purge, [ TrueClass, FalseClass ],
-               description: "Purge extra files found in the target directory.",
-               default: false, desired_state: false
+        description: "Purge extra files found in the target directory.",
+        default: false, desired_state: false
 
       property :overwrite, [ TrueClass, FalseClass ],
-               description: "Overwrite a file when it is different.",
-               default: true, desired_state: false
+        description: "Overwrite a file when it is different.",
+        default: true, desired_state: false
 
       property :cookbook, String,
-               description: "The cookbook in which a file is located (if it is not located in the current cookbook). The default value is the current cookbook.",
-               desired_state: false
+        description: "The cookbook in which a file is located (if it is not located in the current cookbook). The default value is the current cookbook.",
+        desired_state: false
 
       property :files_group, [String, Integer],
-               description: "Configure group permissions for files. A string or ID that identifies the group owner by group name, including fully qualified group names such as domain\\group or group@domain. If this value is not specified, existing groups remain unchanged and new group assignments use the default POSIX group (if available).",
-               regex: Chef::Config[:group_valid_regex]
+        description: "Configure group permissions for files. A string or ID that identifies the group owner by group name, including fully qualified group names such as domain\\group or group@domain. If this value is not specified, existing groups remain unchanged and new group assignments use the default POSIX group (if available).",
+        regex: Chef::Config[:group_valid_regex]
 
       property :files_mode, [String, Integer, nil],
-               description: "The octal mode for a file.\n UNIX- and Linux-based systems: A quoted 3-5 character string that defines the octal mode that is passed to chmod. For example: '755', '0755', or 00755. If the value is specified as a quoted string, it works exactly as if the chmod command was passed. If the value is specified as an integer, prepend a zero (0) to the value to ensure that it is interpreted as an octal number. For example, to assign read, write, and execute rights for all users, use '0777' or '777'; for the same rights, plus the sticky bit, use 01777 or '1777'.\n Microsoft Windows: A quoted 3-5 character string that defines the octal mode that is translated into rights for Microsoft Windows security. For example: '755', '0755', or 00755. Values up to '0777' are allowed (no sticky bits) and mean the same in Microsoft Windows as they do in UNIX, where 4 equals GENERIC_READ, 2 equals GENERIC_WRITE, and 1 equals GENERIC_EXECUTE. This property cannot be used to set :full_control. This property has no effect if not specified, but when it and rights are both specified, the effects are cumulative.",
-               default_description: "0644 on *nix systems",
-               regex: /^\d{3,4}$/, default: lazy { 0644 unless Chef::Platform.windows? }
+        description: "The octal mode for a file.\n UNIX- and Linux-based systems: A quoted 3-5 character string that defines the octal mode that is passed to chmod. For example: '755', '0755', or 00755. If the value is specified as a quoted string, it works exactly as if the chmod command was passed. If the value is specified as an integer, prepend a zero (0) to the value to ensure that it is interpreted as an octal number. For example, to assign read, write, and execute rights for all users, use '0777' or '777'; for the same rights, plus the sticky bit, use 01777 or '1777'.\n Microsoft Windows: A quoted 3-5 character string that defines the octal mode that is translated into rights for Microsoft Windows security. For example: '755', '0755', or 00755. Values up to '0777' are allowed (no sticky bits) and mean the same in Microsoft Windows as they do in UNIX, where 4 equals GENERIC_READ, 2 equals GENERIC_WRITE, and 1 equals GENERIC_EXECUTE. This property cannot be used to set :full_control. This property has no effect if not specified, but when it and rights are both specified, the effects are cumulative.",
+        default_description: "0644 on *nix systems",
+        regex: /^\d{3,4}$/, default: lazy { 0644 unless Chef::Platform.windows? }
 
       property :files_owner, [String, Integer],
-               description: "Configure owner permissions for files. A string or ID that identifies the group owner by user name, including fully qualified user names such as domain\\user or user@domain. If this value is not specified, existing owners remain unchanged and new owner assignments use the current user (when necessary).",
-               regex: Chef::Config[:user_valid_regex]
+        description: "Configure owner permissions for files. A string or ID that identifies the group owner by user name, including fully qualified user names such as domain\\user or user@domain. If this value is not specified, existing owners remain unchanged and new owner assignments use the current user (when necessary).",
+        regex: Chef::Config[:user_valid_regex]
     end
   end
 end

data/lib/chef/resource/remote_file.rb

@@ -47,10 +47,10 @@ class Chef
       def source(*args)
         arg = parse_source_args(args)
         ret = set_or_return(:source,
-                            arg,
-                            { callbacks: {
-                                validate_source: method(:validate_source),
-                              } })
+          arg,
+          { callbacks: {
+              validate_source: method(:validate_source),
+            } })
         if ret.is_a? String
           Array(ret)
         else
@@ -88,7 +88,7 @@ class Chef
 
       property :ftp_active_mode, [ TrueClass, FalseClass ], default: false
 
-      property :headers, Hash, default: lazy { Hash.new }
+      property :headers, Hash, default: lazy { {} }
 
       property :show_progress, [ TrueClass, FalseClass ], default: false
 
@@ -98,7 +98,7 @@ class Chef
 
       property :remote_password, String, sensitive: true
 
-      property :authentication, equal_to: [:remote, :local], default: :remote
+      property :authentication, equal_to: %i{remote local}, default: :remote
 
       def after_created
         validate_identity_platform(remote_user, remote_password, remote_domain)
@@ -161,6 +161,7 @@ class Chef
       def validate_source(source)
         source = Array(source).flatten
         raise ArgumentError, "#{resource_name} has an empty source" if source.empty?
+
         source.each do |src|
           unless absolute_uri?(src)
             raise Exceptions::InvalidRemoteFileURI,
@@ -171,7 +172,7 @@ class Chef
       end
 
       def absolute_uri?(source)
-        Chef::Provider::RemoteFile::Fetcher.network_share?(source) || (source.kind_of?(String) && as_uri(source).absolute?)
+        Chef::Provider::RemoteFile::Fetcher.network_share?(source) || (source.is_a?(String) && as_uri(source).absolute?)
       rescue URI::InvalidURIError
         false
       end

data/lib/chef/resource/resource_notification.rb

@@ -53,13 +53,13 @@ class Chef
       #
       # @return [void]
       def resolve_resource_reference(resource_collection)
-        return resource if resource.kind_of?(Chef::Resource) && notifying_resource.kind_of?(Chef::Resource)
+        return resource if resource.is_a?(Chef::Resource) && notifying_resource.is_a?(Chef::Resource)
 
-        if not(resource.kind_of?(Chef::Resource))
+        unless resource.is_a?(Chef::Resource)
           fix_resource_reference(resource_collection)
         end
 
-        if not(notifying_resource.kind_of?(Chef::Resource))
+        unless notifying_resource.is_a?(Chef::Resource)
           fix_notifier_reference(resource_collection)
         end
       end
@@ -131,6 +131,7 @@ class Chef
 
       def ==(other)
         return false unless other.is_a?(self.class)
+
         other.resource == resource && other.action == action && other.notifying_resource == notifying_resource
       end
 

data/lib/chef/resource/rhsm_errata.rb

@@ -29,8 +29,8 @@ class Chef
       introduced "14.0"
 
       property :errata_id, String,
-               description: "An optional property for specifying the errata ID if it differs from the resource block's name.",
-               name_property: true
+        description: "An optional property for specifying the errata ID if it differs from the resource block's name.",
+        name_property: true
 
       action :install do
         description "Installs a package for a specific errata ID."

data/lib/chef/resource/rhsm_errata_level.rb

@@ -27,10 +27,10 @@ class Chef
       introduced "14.0"
 
       property :errata_level, String,
-               coerce: proc { |x| x.downcase },
-               equal_to: %w{critical moderate important low},
-               description: "An optional property for specifying the errata level of packages to install if it differs from the resource block's name.",
-               name_property: true
+        coerce: proc { |x| x.downcase },
+        equal_to: %w{critical moderate important low},
+        description: "An optional property for specifying the errata level of packages to install if it differs from the resource block's name.",
+        name_property: true
 
       action :install do
         description "Install all packages of the specified errata level."

data/lib/chef/resource/rhsm_register.rb

@@ -29,36 +29,36 @@ class Chef
       introduced "14.0"
 
       property :activation_key, [String, Array],
-               coerce: proc { |x| Array(x) },
-               description: "A string or array of activation keys to use when registering; you must also specify the 'organization' property when using this property."
+        coerce: proc { |x| Array(x) },
+        description: "A string or array of activation keys to use when registering; you must also specify the 'organization' property when using this property."
 
       property :satellite_host, String,
-               description: "The FQDN of the Satellite host to register with. If this property is not specified, the host will register with Red Hat's public RHSM service."
+        description: "The FQDN of the Satellite host to register with. If this property is not specified, the host will register with Red Hat's public RHSM service."
 
       property :organization, String,
-               description: "The organization to use when registering; required when using the 'activation_key' property."
+        description: "The organization to use when registering; required when using the 'activation_key' property."
 
       property :environment, String,
-               description: "The environment to use when registering; required when using the username and password properties."
+        description: "The environment to use when registering; required when using the username and password properties."
 
       property :username, String,
-               description: "The username to use when registering. This property is not applicable if using an activation key. If specified, password and environment properties are also required."
+        description: "The username to use when registering. This property is not applicable if using an activation key. If specified, password and environment properties are also required."
 
       property :password, String,
-               description: "The password to use when registering. This property is not applicable if using an activation key. If specified, username and environment are also required."
+        description: "The password to use when registering. This property is not applicable if using an activation key. If specified, username and environment are also required."
 
       property :auto_attach,
-               [TrueClass, FalseClass],
-               description: "If true, RHSM will attempt to automatically attach the host to applicable subscriptions. It is generally better to use an activation key with the subscriptions pre-defined.",
-               default: false
+        [TrueClass, FalseClass],
+        description: "If true, RHSM will attempt to automatically attach the host to applicable subscriptions. It is generally better to use an activation key with the subscriptions pre-defined.",
+        default: false
 
       property :install_katello_agent, [TrueClass, FalseClass],
-               description: "If true, the 'katello-agent' RPM will be installed.",
-               default: true
+        description: "If true, the 'katello-agent' RPM will be installed.",
+        default: true
 
       property :force, [TrueClass, FalseClass],
-               description: "If true, the system will be registered even if it is already registered. Normally, any register operations will fail if the machine has already been registered.",
-               default: false, desired_state: false
+        description: "If true, the system will be registered even if it is already registered. Normally, any register operations will fail if the machine has already been registered.",
+        default: false, desired_state: false
 
       action :register do
         description "Register the node with RHSM."

data/lib/chef/resource/rhsm_repo.rb

@@ -28,8 +28,8 @@ class Chef
       introduced "14.0"
 
       property :repo_name, String,
-               description: "An optional property for specifying the repository name if it differs from the resource block's name.",
-               name_property: true
+        description: "An optional property for specifying the repository name if it differs from the resource block's name.",
+        name_property: true
 
       action :enable do
         description "Enable a RHSM repository."
@@ -57,7 +57,7 @@ class Chef
         def repo_enabled?(repo)
           cmd = Mixlib::ShellOut.new("subscription-manager repos --list-enabled", env: { LANG: "en_US" })
           cmd.run_command
-          !cmd.stdout.match(/Repo ID:\s+#{repo}$/).nil?
+          repo == "*" || !cmd.stdout.match(/Repo ID:\s+#{repo}$/).nil?
         end
       end
     end

data/lib/chef/resource/rhsm_subscription.rb

@@ -29,8 +29,8 @@ class Chef
       introduced "14.0"
 
       property :pool_id, String,
-               description: "An optional property for specifying the Pool ID if it differs from the resource block's name.",
-               name_property: true
+        description: "An optional property for specifying the Pool ID if it differs from the resource block's name.",
+        name_property: true
 
       action :attach do
         description "Attach the node to a subscription pool."

data/lib/chef/resource/route.rb

@@ -28,29 +28,29 @@ class Chef
       description "Use the route resource to manage the system routing table in a Linux environment."
 
       property :target, String,
-               description: "The IP address of the target route.",
-               identity: true, name_property: true
+        description: "The IP address of the target route.",
+        identity: true, name_property: true
 
       property :comment, [String, nil],
-               description: "Add a comment for the route.",
-               introduced: "14.0"
+        description: "Add a comment for the route.",
+        introduced: "14.0"
 
       property :metric, [Integer, nil],
-               description: "The route metric value."
+        description: "The route metric value."
 
       property :netmask, [String, nil],
-               description: "The decimal representation of the network mask. For example: 255.255.255.0."
+        description: "The decimal representation of the network mask. For example: 255.255.255.0."
 
       property :gateway, [String, nil],
-               description: "The gateway for the route."
+        description: "The gateway for the route."
 
       property :device, [String, nil],
-               description: "The network interface to which the route applies.",
-               desired_state: false # Has a partial default in the provider of eth0.
+        description: "The network interface to which the route applies.",
+        desired_state: false # Has a partial default in the provider of eth0.
 
       property :route_type, [Symbol, String],
-               description: "",
-               equal_to: [:host, :net], default: :host, desired_state: false
+        description: "",
+        equal_to: %i{host net}, default: :host, desired_state: false
     end
   end
 end

data/lib/chef/resource/scm.rb

@@ -25,49 +25,49 @@ class Chef
       allowed_actions :checkout, :export, :sync, :diff, :log
 
       property :destination, String,
-               description: "The location path to which the source is to be cloned, checked out, or exported. Default value: the name of the resource block.",
-               name_property: true, identity: true
+        description: "The location path to which the source is to be cloned, checked out, or exported. Default value: the name of the resource block.",
+        name_property: true, identity: true
 
       property :repository, String
 
       property :revision, String,
-               description: "The revision to checkout.",
-               default: "HEAD"
+        description: "The revision to checkout.",
+        default: "HEAD"
 
       property :user, [String, Integer],
-               description: "The system user that is responsible for the checked-out code."
+        description: "The system user that is responsible for the checked-out code."
 
       property :group, [String, Integer],
-               description: "The system group that is responsible for the checked-out code."
+        description: "The system group that is responsible for the checked-out code."
 
       # Capistrano and git-deploy use ``shallow clone''
       property :depth, Integer,
-               description: "The number of past revisions to be included in the git shallow clone. Unless specified the default behavior will do a full clone."
+        description: "The number of past revisions to be included in the git shallow clone. Unless specified the default behavior will do a full clone."
 
       property :enable_submodules, [TrueClass, FalseClass],
-               description: "Perform a sub-module initialization and update.",
-               default: false
+        description: "Perform a sub-module initialization and update.",
+        default: false
 
       property :enable_checkout, [TrueClass, FalseClass],
-               description: "Check out a repo from master. Set to false when using the checkout_branch attribute to prevent the git resource from attempting to check out master from master.",
-               default: true
+        description: "Check out a repo from master. Set to false when using the checkout_branch attribute to prevent the git resource from attempting to check out master from master.",
+        default: true
 
       property :remote, String,
-               default: "origin"
+        default: "origin"
 
       property :ssh_wrapper, String,
-               desired_state: false
+        desired_state: false
 
       property :timeout, Integer,
-               desired_state: false
+        desired_state: false
 
       property :checkout_branch, String,
-               description: "Do a one-time checkout **or** use when a branch in the upstream repository is named 'deploy'. To prevent the resource from attempting to check out master from master, set 'enable_checkout' to 'false' when using the 'checkout_branch' property.",
-               default: "deploy"
+        description: "Do a one-time checkout **or** use when a branch in the upstream repository is named 'deploy'. To prevent the resource from attempting to check out master from master, set 'enable_checkout' to 'false' when using the 'checkout_branch' property.",
+        default: "deploy"
 
       property :environment, [Hash, nil],
-               description: "A Hash of environment variables in the form of ({'ENV_VARIABLE' => 'VALUE'}).",
-               default: nil
+        description: "A Hash of environment variables in the form of ({'ENV_VARIABLE' => 'VALUE'}).",
+        default: nil
 
       alias :env :environment
     end