chef 12.0.0.alpha.2-x86-mingw32 → 12.0.0.rc.0-x86-mingw32

data/spec/unit/shell/shell_ext_spec.rb

@@ -121,7 +121,7 @@ describe Shell::Extensions do
       Shell.session.stub(:rebuild_context)
       events = Chef::EventDispatch::Dispatcher.new
       run_context = Chef::RunContext.new(Chef::Node.new, {}, events)
-      run_context.resource_collection.instance_variable_set(:@iterator, :the_iterator)
+      run_context.resource_collection.instance_variable_get(:@resource_list).instance_variable_set(:@iterator, :the_iterator)
       Shell.session.run_context = run_context
       @root_context.chef_run.should == :the_iterator
     end

data/spec/unit/user_spec.rb

@@ -154,6 +154,10 @@ describe Chef::User do
     it "does not include the password if not present" do
       @json.should_not include("password")
     end
+
+    include_examples "to_json equalivent to Chef::JSONCompat.to_json" do
+      let(:jsonable) { @user }
+    end
   end
 
   describe "when deserializing from JSON" do
@@ -163,7 +167,7 @@ describe Chef::User do
         "private_key" => "pandas",
         "password" => "password",
         "admin" => true }
-      @user = Chef::User.from_json(user.to_json)
+      @user = Chef::User.from_json(Chef::JSONCompat.to_json(user))
     end
 
     it "should deserialize to a Chef::User object" do

data/spec/unit/util/dsc/configuration_generator_spec.rb

@@ -0,0 +1,171 @@
+#
+# Author:: Jay Mundrawala <jmundrawala@getchef.com>
+# Copyright:: Copyright (c) 2014 Chef Software, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'chef'
+require 'chef/util/dsc/configuration_generator'
+
+describe Chef::Util::DSC::ConfigurationGenerator do
+  let(:conf_man) do
+    node = Chef::Node.new
+    Chef::Util::DSC::ConfigurationGenerator.new(node, 'tmp')
+  end
+
+  describe '#validate_configuration_name!' do
+    it 'should not raise an error if a name contains all upper case letters' do
+      conf_man.send(:validate_configuration_name!, "HELLO")
+    end
+
+    it 'should not raise an error if the name contains all lower case letters' do
+      conf_man.send(:validate_configuration_name!, "hello")
+    end
+
+    it 'should not raise an error if no special characters are used except _' do
+      conf_man.send(:validate_configuration_name!, "hello_world")
+    end
+
+    %w{! @ # $ % ^ & * & * ( ) - = + \{ \} . ? < > \\ /}.each do |sym|
+      it "raises an Argument error if it configuration name contains #{sym}" do
+        expect {
+          conf_man.send(:validate_configuration_name!, "Hello#{sym}")
+        }.to raise_error(ArgumentError)
+      end
+    end
+  end
+
+  describe "#get_merged_configuration_flags" do
+    context 'when strings are used as switches' do
+      it 'should merge the hash if there are no restricted switches' do
+        merged = conf_man.send(:get_merged_configuration_flags!, {'flag' => 'a'}, 'hello')
+        merged.should include(:flag)
+        merged[:flag].should eql('a')
+        merged.should include(:outputpath)
+      end
+
+      it 'should raise an ArgumentError if you try to override outputpath' do
+        expect {
+          conf_man.send(:get_merged_configuration_flags!, {'outputpath' => 'a'}, 'hello')
+        }.to raise_error(ArgumentError)
+      end
+
+      it 'should be case insensitive for switches that are not allowed' do
+        expect {
+          conf_man.send(:get_merged_configuration_flags!, {'OutputPath' => 'a'}, 'hello')
+        }.to raise_error(ArgumentError)
+      end
+
+      it 'should be case insensitive to switches that are allowed' do
+        merged = conf_man.send(:get_merged_configuration_flags!, {'FLAG' => 'a'}, 'hello')
+        merged.should include(:flag)
+      end
+    end
+
+    context 'when symbols are used as switches' do
+      it 'should merge the hash if there are no restricted switches' do
+        merged = conf_man.send(:get_merged_configuration_flags!, {:flag => 'a'}, 'hello')
+        merged.should include(:flag)
+        merged[:flag].should eql('a')
+        merged.should include(:outputpath)
+      end
+
+      it 'should raise an ArgumentError if you try to override outputpath' do
+        expect {
+          conf_man.send(:get_merged_configuration_flags!, {:outputpath => 'a'}, 'hello')
+        }.to raise_error(ArgumentError)
+      end
+
+      it 'should be case insensitive for switches that are not allowed' do
+        expect {
+          conf_man.send(:get_merged_configuration_flags!, {:OutputPath => 'a'}, 'hello')
+        }.to raise_error(ArgumentError)
+      end
+
+      it 'should be case insensitive to switches that are allowed' do
+        merged = conf_man.send(:get_merged_configuration_flags!, {:FLAG => 'a'}, 'hello')
+        merged.should include(:flag)
+      end
+    end
+
+    context 'when there are no flags' do
+      it 'should supply an output path if configuration_flags is an empty hash' do
+        merged = conf_man.send(:get_merged_configuration_flags!, {}, 'hello')
+        merged.should include(:outputpath)
+        merged.length.should eql(1)
+      end
+
+      it 'should supply an output path if configuration_flags is an empty hash' do
+        merged = conf_man.send(:get_merged_configuration_flags!, nil, 'hello')
+        merged.should include(:outputpath)
+        merged.length.should eql(1)
+      end
+    end
+
+    # What should happen if configuration flags contains duplicates?
+    # flagA => 'a', flaga => 'a'
+    # or
+    # flagA => 'a', flaga => 'b'
+    #
+  end
+
+  describe '#write_document_generation_script' do
+    let(:file_like_object) { double("file like object") }
+
+    it "should write the input to a file" do
+      allow(File).to receive(:open).and_yield(file_like_object)
+      allow(File).to receive(:join) do |a, b|
+        [a,b].join("++")
+      end
+      allow(file_like_object).to receive(:write)
+      conf_man.send(:write_document_generation_script, 'file', 'hello')
+      expect(file_like_object).to have_received(:write)
+    end
+  end
+
+  describe "#find_configuration_document" do
+    it "should find the mof file" do
+      # These tests seem way too implementation specific. Unfortunatly, File and Dir
+      # need to be mocked because they are OS specific
+      allow(File).to receive(:join) do |a, b|
+        [a,b].join("++")
+      end
+
+      allow(Dir).to receive(:entries).with("tmp++hello") {['f1', 'f2', 'hello.mof', 'f3']}
+      expect(conf_man.send(:find_configuration_document, 'hello')).to eql('tmp++hello++hello.mof')
+    end
+
+    it "should return nil if the mof file is not found" do
+      allow(File).to receive(:join) do |a, b|
+        [a,b].join("++")
+      end
+      allow(Dir).to receive(:entries).with("tmp++hello") {['f1', 'f2', 'f3']}
+      expect(conf_man.send(:find_configuration_document, 'hello')).to be_nil
+    end
+  end
+
+  describe "#configuration_code" do
+    it "should build dsc" do
+      dsc = conf_man.send(:configuration_code, 'archive{}', 'hello')
+      found_configuration = false
+      dsc.split(';').each do |command|
+        if command.downcase =~ /\s*configuration\s+'hello'\s*\{\s*node\s+'localhost'\s*\{\s*archive\s*\{\s*\}\s*\}\s*\}\s*/
+          found_configuration = true
+        end
+      end
+      expect(found_configuration).to be_true
+    end
+  end
+end

data/spec/unit/util/dsc/lcm_output_parser_spec.rb

@@ -0,0 +1,169 @@
+#
+# Author:: Bryan McLellan <btm@loftninjas.org>
+# Copyright:: Copyright (c) 2014 Chef Software, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'chef/util/dsc/lcm_output_parser'
+
+describe Chef::Util::DSC::LocalConfigurationManager::Parser do
+  context 'empty input parameter' do
+    it 'returns an empty array for a 0 length string' do
+      Chef::Util::DSC::LocalConfigurationManager::Parser::parse('').should be_empty
+    end
+
+    it 'returns an empty array for a nil input' do
+      Chef::Util::DSC::LocalConfigurationManager::Parser::parse('').should be_empty
+    end
+  end
+
+  context 'correctly formatted output from lcm' do
+    it 'returns an empty array for a log with no resources' do
+      str = <<EOF
+logtype: [machinename]: LCM:  [ Start  Set      ]
+logtype: [machinename]: LCM:  [ End    Set      ]
+EOF
+      Chef::Util::DSC::LocalConfigurationManager::Parser::parse(str).should be_empty
+    end
+
+    it 'returns a single resource when only 1 logged with the correct name' do
+      str = <<EOF
+logtype: [machinename]: LCM:  [ Start  Set      ]
+logtype: [machinename]: LCM:  [ Start  Resource ] [name]
+logtype: [machinename]: LCM:  [ End    Resource ] [name]
+logtype: [machinename]: LCM:  [ End    Set      ]
+EOF
+      resources = Chef::Util::DSC::LocalConfigurationManager::Parser::parse(str)
+      resources.length.should eq(1)
+      resources[0].name.should eq('[name]')
+    end
+
+    it 'identifies when a resource changes the state of the system' do
+      str = <<EOF
+logtype: [machinename]: LCM:  [ Start  Set      ]
+logtype: [machinename]: LCM:  [ Start  Resource ] [name]
+logtype: [machinename]: LCM:  [ Start  Set      ] [name]
+logtype: [machinename]: LCM:  [ End    Set      ] [name]
+logtype: [machinename]: LCM:  [ End    Resource ] [name]
+logtype: [machinename]: LCM:  [ End    Set      ]
+EOF
+      resources = Chef::Util::DSC::LocalConfigurationManager::Parser::parse(str)
+      resources[0].changes_state?.should be_true
+    end
+
+    it 'preserves the log provided for how the system changed the state' do
+      str = <<EOF
+logtype: [machinename]: LCM:  [ Start  Set      ]
+logtype: [machinename]: LCM:  [ Start  Resource ] [name]
+logtype: [machinename]: LCM:  [ Start  Set      ] [name]
+logtype: [machinename]:                           [message]
+logtype: [machinename]: LCM:  [ End    Set      ] [name]
+logtype: [machinename]: LCM:  [ End    Resource ] [name]
+logtype: [machinename]: LCM:  [ End    Set      ]
+EOF
+      resources = Chef::Util::DSC::LocalConfigurationManager::Parser::parse(str)
+      resources[0].change_log.should match_array(["[name]","[message]","[name]"])
+    end
+
+    it 'should return false for changes_state?' do
+      str = <<EOF
+logtype: [machinename]: LCM:  [ Start  Set      ]
+logtype: [machinename]: LCM:  [ Start  Resource ] [name]
+logtype: [machinename]: LCM:  [ Skip   Set      ] [name]
+logtype: [machinename]: LCM:  [ End    Resource ] [name]
+logtype: [machinename]: LCM:  [ End    Set      ]
+EOF
+      resources = Chef::Util::DSC::LocalConfigurationManager::Parser::parse(str)
+      resources[0].changes_state?.should be_false
+    end
+
+    it 'should return an empty array for change_log if changes_state? is false' do
+      str = <<EOF
+logtype: [machinename]: LCM:  [ Start  Set      ]
+logtype: [machinename]: LCM:  [ Start  Resource ] [name]
+logtype: [machinename]: LCM:  [ Skip   Set      ] [name]
+logtype: [machinename]: LCM:  [ End    Resource ] [name]
+logtype: [machinename]: LCM:  [ End    Set      ]
+EOF
+      resources = Chef::Util::DSC::LocalConfigurationManager::Parser::parse(str)
+      resources[0].change_log.should be_empty
+    end
+  end
+
+  context 'Incorrectly formatted output from LCM' do
+    it 'should allow missing a [End Resource] when its the last one and still find all the resource' do
+      str = <<-EOF
+logtype: [machinename]: LCM:  [ Start  Set      ]
+logtype: [machinename]: LCM:  [ Start  Resource ]  [name]
+logtype: [machinename]: LCM:  [ Start  Test     ]
+logtype: [machinename]: LCM:  [ End    Test     ]
+logtype: [machinename]: LCM:  [ Skip   Set      ]
+logtype: [machinename]: LCM:  [ End    Resource ]
+logtype: [machinename]: LCM:  [ Start  Resource ]  [name2]
+logtype: [machinename]: LCM:  [ Start  Test     ]
+logtype: [machinename]: LCM:  [ End    Test     ]
+logtype: [machinename]: LCM:  [ Start  Set      ]
+logtype: [machinename]: LCM:  [ End    Set      ]
+logtype: [machinename]: LCM:  [ End    Set      ]
+EOF
+
+      resources = Chef::Util::DSC::LocalConfigurationManager::Parser::parse(str)
+      resources[0].changes_state?.should be_false
+      resources[1].changes_state?.should be_true
+    end
+
+    it 'should allow missing a [End Resource] when its the first one and still find all the resource' do
+      str = <<-EOF
+logtype: [machinename]: LCM:  [ Start  Set      ]
+logtype: [machinename]: LCM:  [ Start  Resource ]  [name]
+logtype: [machinename]: LCM:  [ Start  Test     ]
+logtype: [machinename]: LCM:  [ End    Test     ]
+logtype: [machinename]: LCM:  [ Skip   Set      ]
+logtype: [machinename]: LCM:  [ Start  Resource ]  [name2]
+logtype: [machinename]: LCM:  [ Start  Test     ]
+logtype: [machinename]: LCM:  [ End    Test     ]
+logtype: [machinename]: LCM:  [ Start  Set      ]
+logtype: [machinename]: LCM:  [ End    Set      ]
+logtype: [machinename]: LCM:  [ End    Resource ]
+logtype: [machinename]: LCM:  [ End    Set      ]
+EOF
+
+      resources = Chef::Util::DSC::LocalConfigurationManager::Parser::parse(str)
+      resources[0].changes_state?.should be_false
+      resources[1].changes_state?.should be_true
+    end
+
+    it 'should allow missing set and end resource and assume an unconverged resource in this case' do
+      str = <<-EOF
+logtype: [machinename]: LCM:  [ Start  Set      ]
+logtype: [machinename]: LCM:  [ Start  Resource ]  [name]
+logtype: [machinename]: LCM:  [ Start  Test     ]
+logtype: [machinename]: LCM:  [ End    Test     ]
+logtype: [machinename]: LCM:  [ Start  Resource ]  [name2]
+logtype: [machinename]: LCM:  [ Start  Test     ]
+logtype: [machinename]: LCM:  [ End    Test     ]
+logtype: [machinename]: LCM:  [ Start  Set      ]
+logtype: [machinename]: LCM:  [ End    Set      ]
+logtype: [machinename]: LCM:  [ End    Resource ]
+logtype: [machinename]: LCM:  [ End    Set      ]
+EOF
+      resources = Chef::Util::DSC::LocalConfigurationManager::Parser::parse(str)
+      resources[0].changes_state?.should be_true
+      resources[0].name.should eql('[name]')
+      resources[1].changes_state?.should be_true
+      resources[1].name.should eql('[name2]')
+    end
+  end
+end

data/spec/unit/util/dsc/local_configuration_manager_spec.rb

@@ -0,0 +1,139 @@
+#
+# Author:: Adam Edwards <adamed@getchef.com>
+# Copyright:: Copyright (c) 2014 Chef Software, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'chef'
+require 'chef/util/dsc/local_configuration_manager'
+
+describe Chef::Util::DSC::LocalConfigurationManager do
+
+  let(:lcm) { Chef::Util::DSC::LocalConfigurationManager.new(nil, 'tmp') }
+
+  let(:normal_lcm_output) { <<-EOH
+logtype: [machinename]: LCM:  [ Start  Set      ]
+logtype: [machinename]: LCM:  [ Start  Resource ] [name]
+logtype: [machinename]: LCM:  [ End    Resource ] [name]
+logtype: [machinename]: LCM:  [ End    Set      ]
+EOH
+  }
+
+  let(:no_whatif_lcm_output) { <<-EOH
+Start-DscConfiguration : A parameter cannot be found\r\n that matches parameter name 'whatif'.
+At line:1 char:123
++ run-somecommand -whatif
++                        ~~~~~~~~
+    + CategoryInfo          : InvalidArgument: (:) [Start-DscConfiguration], ParameterBindingException
+    + FullyQualifiedErrorId : NamedParameterNotFound,SomeCompany.SomeAssembly.Commands.RunSomeCommand
+EOH
+  }
+
+  let(:dsc_resource_import_failure_output) { <<-EOH
+PowerShell provider MSFT_xWebsite failed to execute Test-TargetResource functionality with error message: Please ensure that WebAdministration module is installed. + CategoryInfo : InvalidOperation: (:) [], CimException + FullyQualifiedErrorId : ProviderOperationExecutionFailure + PSComputerName : . PowerShell provider MSFT_xWebsite failed to execute Test-TargetResource functionality with error message: Please ensure that WebAdministration module is installed. + CategoryInfo : InvalidOperation: (:) [], CimException + FullyQualifiedErrorId : ProviderOperationExecutionFailure + PSComputerName : . The SendConfigurationApply function did not succeed. + CategoryInfo : NotSpecified: (root/Microsoft/...gurationManager:String) [], CimException + FullyQualifiedErrorId : MI RESULT 1 + PSComputerName : .
+EOH
+  }
+
+  let(:lcm_status) {
+    double("LCM cmdlet status", :stderr => lcm_standard_error, :return_value => lcm_standard_output, :succeeded? => lcm_cmdlet_success)
+  }
+
+  describe 'test_configuration method invocation' do
+    context 'when interacting with the LCM using a PowerShell cmdlet' do
+      before(:each) do
+        allow(lcm).to receive(:run_configuration_cmdlet).and_return(lcm_status)
+      end
+      context 'that returns successfully' do
+        before(:each) do
+          allow(lcm).to receive(:run_configuration_cmdlet).and_return(lcm_status)
+        end
+
+        let(:lcm_standard_output) { normal_lcm_output }
+        let(:lcm_standard_error) { nil }
+        let(:lcm_cmdlet_success) { true }
+
+        it 'should successfully return resource information for normally formatted output when cmdlet the cmdlet succeeds' do
+          test_configuration_result = lcm.test_configuration('config')
+          expect(test_configuration_result.class).to be(Array)
+          expect(test_configuration_result.length).to be > 0
+          expect(Chef::Log).not_to receive(:warn)
+        end
+      end
+
+      context 'that fails due to missing what-if switch in DSC resource cmdlet implementation' do
+        let(:lcm_standard_output) { '' }
+        let(:lcm_standard_error) { no_whatif_lcm_output }
+        let(:lcm_cmdlet_success) { false }
+
+        it 'returns true when passed to #whatif_not_supported?' do
+          expect(lcm.send(:whatif_not_supported?, no_whatif_lcm_output)).to be_true
+        end
+
+        it 'should should return a (possibly empty) array of ResourceInfo instances' do
+          expect(Chef::Log).to receive(:warn)
+          expect(lcm).to receive(:whatif_not_supported?).and_call_original
+          test_configuration_result = nil
+          expect {test_configuration_result = lcm.test_configuration('config')}.not_to raise_error
+          expect(test_configuration_result.class).to be(Array)
+        end
+      end
+
+      context 'that fails due to a DSC resource not being imported before StartDSCConfiguration -whatif is executed' do
+        let(:lcm_standard_output) { '' }
+        let(:lcm_standard_error) { dsc_resource_import_failure_output }
+        let(:lcm_cmdlet_success) { false }
+
+        it 'should log a warning if the message is formatted as expected when a resource import failure occurs' do
+          expect(Chef::Log).to receive(:warn)
+          expect(lcm).to receive(:dsc_module_import_failure?).and_call_original
+          test_configuration_result = nil
+          expect {test_configuration_result = lcm.test_configuration('config')}.not_to raise_error
+        end
+
+        it 'should return a (possibly empty) array of ResourceInfo instances' do
+          expect(Chef::Log).to receive(:warn)
+          test_configuration_result = nil
+          expect {test_configuration_result = lcm.test_configuration('config')}.not_to raise_error
+          expect(test_configuration_result.class).to be(Array)
+        end
+      end
+
+      context 'that fails due to an unknown PowerShell cmdlet error' do
+        let(:lcm_standard_output) { 'some output' }
+        let(:lcm_standard_error) { 'Abort, Retry, Fail?' }
+        let(:lcm_cmdlet_success) { false }
+
+        it 'should log a warning' do
+          expect(Chef::Log).to receive(:warn)
+          expect(lcm).to receive(:dsc_module_import_failure?).and_call_original
+          expect {lcm.test_configuration('config')}.not_to raise_error
+        end
+      end
+    end
+
+    it 'should identify a correctly formatted error message as a resource import failure' do
+      expect(lcm.send(:dsc_module_import_failure?, dsc_resource_import_failure_output)).to be(true)
+    end
+
+    it 'should not identify an incorrectly formatted error message as a resource import failure' do
+      expect(lcm.send(:dsc_module_import_failure?, dsc_resource_import_failure_output.gsub('module', 'gibberish'))).to be(false)
+    end
+
+    it 'should not identify a message without a CimException reference as a resource import failure' do
+      expect(lcm.send(:dsc_module_import_failure?, dsc_resource_import_failure_output.gsub('CimException', 'ArgumentException'))).to be(false)
+    end
+  end
+end
+