chef 12.0.0.alpha.2-x86-mingw32 → 12.0.0.rc.0-x86-mingw32

data/spec/unit/provider/service/solaris_smf_service_spec.rb

@@ -29,70 +29,70 @@ describe Chef::Provider::Service::Solaris do
     @current_resource = Chef::Resource::Service.new('chef')
 
     @provider = Chef::Provider::Service::Solaris.new(@new_resource, @run_context)
-    Chef::Resource::Service.stub(:new).and_return(@current_resource)
+    allow(Chef::Resource::Service).to receive(:new).and_return(@current_resource)
 
     @stdin = StringIO.new
     @stdout = StringIO.new
     @stderr = StringIO.new
     @pid = 2342
     @stdout_string = "state disabled"
-    @stdout.stub(:gets).and_return(@stdout_string)
+    allow(@stdout).to receive(:gets).and_return(@stdout_string)
     @status = double("Status", :exitstatus => 0, :stdout => @stdout)
-    @provider.stub(:shell_out!).and_return(@status)
+    allow(@provider).to receive(:shell_out!).and_return(@status)
   end
 
   it "should raise an error if /bin/svcs does not exist" do
-    File.should_receive(:exists?).with("/bin/svcs").and_return(false)
-    lambda { @provider.load_current_resource }.should raise_error(Chef::Exceptions::Service)
+    expect(File).to receive(:exists?).with("/bin/svcs").and_return(false)
+    expect { @provider.load_current_resource }.to raise_error(Chef::Exceptions::Service)
   end
 
   describe "on a host with /bin/svcs" do
 
     before do
-      File.stub(:exists?).with('/bin/svcs').and_return(true)
+      allow(File).to receive(:exists?).with('/bin/svcs').and_return(true)
     end
 
     describe "when discovering the current service state" do
       it "should create a current resource with the name of the new resource" do
-        @provider.stub(:shell_out!).with("/bin/svcs -l chef").and_return(@status)
-        Chef::Resource::Service.should_receive(:new).and_return(@current_resource)
+        allow(@provider).to receive(:shell_out!).with("/bin/svcs -l chef").and_return(@status)
+        expect(Chef::Resource::Service).to receive(:new).and_return(@current_resource)
         @provider.load_current_resource
       end
 
       it "should return the current resource" do
-        @provider.stub(:shell_out!).with("/bin/svcs -l chef").and_return(@status)
-        @provider.load_current_resource.should eql(@current_resource)
+        allow(@provider).to receive(:shell_out!).with("/bin/svcs -l chef").and_return(@status)
+        expect(@provider.load_current_resource).to eql(@current_resource)
       end
 
       it "should call '/bin/svcs -l service_name'" do
-        @provider.should_receive(:shell_out!).with("/bin/svcs -l chef", {:returns=>[0, 1]}).and_return(@status)
+        expect(@provider).to receive(:shell_out!).with("/bin/svcs -l chef", {:returns=>[0, 1]}).and_return(@status)
         @provider.load_current_resource
       end
 
       it "should mark service as not running" do
-        @provider.stub(:shell_out!).and_return(@status)
-        @current_resource.should_receive(:running).with(false)
+        allow(@provider).to receive(:shell_out!).and_return(@status)
+        expect(@current_resource).to receive(:running).with(false)
         @provider.load_current_resource
       end
 
       it "should mark service as running" do
         @status = double("Status", :exitstatus => 0, :stdout => 'state online')
-        @provider.stub(:shell_out!).and_return(@status)
-        @current_resource.should_receive(:running).with(true)
+        allow(@provider).to receive(:shell_out!).and_return(@status)
+        expect(@current_resource).to receive(:running).with(true)
         @provider.load_current_resource
       end
 
       it "should not mark service as maintenance" do
-        @provider.stub(:shell_out!).and_return(@status)
+        allow(@provider).to receive(:shell_out!).and_return(@status)
         @provider.load_current_resource
-        @provider.maintenance.should be_false
+        expect(@provider.maintenance).to be_false
       end
 
       it "should mark service as maintenance" do
         @status = double("Status", :exitstatus => 0, :stdout => 'state maintenance')
-        @provider.stub(:shell_out!).and_return(@status)
+        allow(@provider).to receive(:shell_out!).and_return(@status)
         @provider.load_current_resource
-        @provider.maintenance.should be_true
+        expect(@provider.maintenance).to be_true
       end
     end
 
@@ -103,30 +103,27 @@ describe Chef::Provider::Service::Solaris do
       end
 
       it "should call svcadm enable -s chef" do
-        @new_resource.stub(:enable_command).and_return("#{@new_resource.enable_command}")
-        @provider.should_not_receive(:shell_out!).with("/usr/sbin/svcadm clear #{@current_resource.service_name}")
-        @provider.should_receive(:shell_out!).with("/usr/sbin/svcadm enable -s #{@current_resource.service_name}").and_return(@status)
-        @provider.enable_service.should be_true
-        @current_resource.enabled.should be_true
+        expect(@provider).not_to receive(:shell_out!).with("/usr/sbin/svcadm clear #{@current_resource.service_name}")
+        expect(@provider).to receive(:shell_out!).with("/usr/sbin/svcadm enable -s #{@current_resource.service_name}").and_return(@status)
+        expect(@provider.enable_service).to be_true
+        expect(@current_resource.enabled).to be_true
       end
 
       it "should call svcadm enable -s chef for start_service" do
-        @new_resource.stub(:start_command).and_return("#{@new_resource.start_command}")
-        @provider.should_not_receive(:shell_out!).with("/usr/sbin/svcadm clear #{@current_resource.service_name}")
-        @provider.should_receive(:shell_out!).with("/usr/sbin/svcadm enable -s #{@current_resource.service_name}").and_return(@status)
-        @provider.start_service.should be_true
-        @current_resource.enabled.should be_true
+        expect(@provider).not_to receive(:shell_out!).with("/usr/sbin/svcadm clear #{@current_resource.service_name}")
+        expect(@provider).to receive(:shell_out!).with("/usr/sbin/svcadm enable -s #{@current_resource.service_name}").and_return(@status)
+        expect(@provider.start_service).to be_true
+        expect(@current_resource.enabled).to be_true
       end
 
       it "should call svcadm clear chef for start_service when state maintenance" do
         @status = double("Status", :exitstatus => 0, :stdout => 'state maintenance')
-        @provider.stub(:shell_out!).and_return(@status)
+        allow(@provider).to receive(:shell_out!).and_return(@status)
         @provider.load_current_resource
-        @new_resource.stub(:enable_command).and_return("#{@new_resource.enable_command}")
-        @provider.should_receive(:shell_out!).with("/usr/sbin/svcadm clear #{@current_resource.service_name}").and_return(@status)
-        @provider.should_receive(:shell_out!).with("/usr/sbin/svcadm enable -s #{@current_resource.service_name}").and_return(@status)
-        @provider.enable_service.should be_true
-        @current_resource.enabled.should be_true
+        expect(@provider).to receive(:shell_out!).with("/usr/sbin/svcadm clear #{@current_resource.service_name}").and_return(@status)
+        expect(@provider).to receive(:shell_out!).with("/usr/sbin/svcadm enable -s #{@current_resource.service_name}").and_return(@status)
+        expect(@provider.enable_service).to be_true
+        expect(@current_resource.enabled).to be_true
       end
     end
 
@@ -137,15 +134,15 @@ describe Chef::Provider::Service::Solaris do
       end
 
       it "should call svcadm disable -s chef" do
-        @provider.should_receive(:shell_out!).with("/usr/sbin/svcadm disable -s chef").and_return(@status)
-        @provider.disable_service.should be_true
-        @current_resource.enabled.should be_false
+        expect(@provider).to receive(:shell_out!).with("/usr/sbin/svcadm disable -s chef").and_return(@status)
+        expect(@provider.disable_service).to be_true
+        expect(@current_resource.enabled).to be_false
       end
 
       it "should call svcadm disable -s chef for stop_service" do
-        @provider.should_receive(:shell_out!).with("/usr/sbin/svcadm disable -s chef").and_return(@status)
-        @provider.stop_service.should be_true
-        @current_resource.enabled.should be_false
+        expect(@provider).to receive(:shell_out!).with("/usr/sbin/svcadm disable -s chef").and_return(@status)
+        expect(@provider.stop_service).to be_true
+        expect(@current_resource.enabled).to be_false
       end
 
     end
@@ -157,7 +154,7 @@ describe Chef::Provider::Service::Solaris do
       end
 
       it "should call svcadm refresh chef" do
-        @provider.should_receive(:shell_out_with_systems_locale!).with("/usr/sbin/svcadm refresh chef").and_return(@status)
+        expect(@provider).to receive(:shell_out_with_systems_locale!).with("/usr/sbin/svcadm refresh chef").and_return(@status)
         @provider.reload_service
       end
 
@@ -171,15 +168,15 @@ describe Chef::Provider::Service::Solaris do
       end
 
       it "should be marked not running" do
-        @provider.should_receive(:shell_out!).with("/bin/svcs -l chef", {:returns=>[0, 1]}).and_return(@status)
+        expect(@provider).to receive(:shell_out!).with("/bin/svcs -l chef", {:returns=>[0, 1]}).and_return(@status)
         @provider.service_status
-        @current_resource.running.should be_false
+        expect(@current_resource.running).to be_false
       end
 
       it "should be marked not enabled" do
-        @provider.should_receive(:shell_out!).with("/bin/svcs -l chef", {:returns=>[0, 1]}).and_return(@status)
+        expect(@provider).to receive(:shell_out!).with("/bin/svcs -l chef", {:returns=>[0, 1]}).and_return(@status)
         @provider.service_status
-        @current_resource.enabled.should be_false
+        expect(@current_resource.enabled).to be_false
       end
 
     end

data/spec/unit/provider/service/systemd_service_spec.rb

@@ -35,169 +35,169 @@ describe Chef::Provider::Service::Systemd do
   describe "load_current_resource" do
     before(:each) do
       @current_resource = Chef::Resource::Service.new('rsyslog.service')
-      Chef::Resource::Service.stub(:new).and_return(@current_resource)
+      allow(Chef::Resource::Service).to receive(:new).and_return(@current_resource)
 
-      @provider.stub(:is_active?).and_return(false)
-      @provider.stub(:is_enabled?).and_return(false)
+      allow(@provider).to receive(:is_active?).and_return(false)
+      allow(@provider).to receive(:is_enabled?).and_return(false)
     end
 
     it "should create a current resource with the name of the new resource" do
-      Chef::Resource::Service.should_receive(:new).and_return(@current_resource)
+      expect(Chef::Resource::Service).to receive(:new).and_return(@current_resource)
       @provider.load_current_resource
     end
 
     it "should set the current resources service name to the new resources service name" do
-      @current_resource.should_receive(:service_name).with(@new_resource.service_name)
+      expect(@current_resource).to receive(:service_name).with(@new_resource.service_name)
       @provider.load_current_resource
     end
 
     it "should check if the service is running" do
-      @provider.should_receive(:is_active?)
+      expect(@provider).to receive(:is_active?)
       @provider.load_current_resource
     end
 
     it "should set running to true if the service is running" do
-      @provider.stub(:is_active?).and_return(true)
-      @current_resource.should_receive(:running).with(true)
+      allow(@provider).to receive(:is_active?).and_return(true)
+      expect(@current_resource).to receive(:running).with(true)
       @provider.load_current_resource
     end
 
     it "should set running to false if the service is not running" do
-      @provider.stub(:is_active?).and_return(false)
-      @current_resource.should_receive(:running).with(false)
+      allow(@provider).to receive(:is_active?).and_return(false)
+      expect(@current_resource).to receive(:running).with(false)
       @provider.load_current_resource
     end
 
     describe "when a status command has been specified" do
       before do
-        @new_resource.stub(:status_command).and_return("/bin/chefhasmonkeypants status")
+        allow(@new_resource).to receive(:status_command).and_return("/bin/chefhasmonkeypants status")
       end
 
       it "should run the services status command if one has been specified" do
-        @provider.stub(:shell_out).and_return(@shell_out_success)
-        @current_resource.should_receive(:running).with(true)
+        allow(@provider).to receive(:shell_out).and_return(@shell_out_success)
+        expect(@current_resource).to receive(:running).with(true)
         @provider.load_current_resource
       end
 
       it "should run the services status command if one has been specified and properly set status check state" do
-        @provider.stub(:shell_out).with("/bin/chefhasmonkeypants status").and_return(@shell_out_success)
+        allow(@provider).to receive(:shell_out).with("/bin/chefhasmonkeypants status").and_return(@shell_out_success)
         @provider.load_current_resource
-        @provider.instance_variable_get("@status_check_success").should be_true
+        expect(@provider.instance_variable_get("@status_check_success")).to be_true
       end
 
       it "should set running to false if a status command fails" do
-        @provider.stub(:shell_out).and_return(@shell_out_failure)
-        @current_resource.should_receive(:running).with(false)
+        allow(@provider).to receive(:shell_out).and_return(@shell_out_failure)
+        expect(@current_resource).to receive(:running).with(false)
         @provider.load_current_resource
       end
 
       it "should update state to indicate status check failed when a status command fails" do
-        @provider.stub(:shell_out).and_return(@shell_out_failure)
+        allow(@provider).to receive(:shell_out).and_return(@shell_out_failure)
         @provider.load_current_resource
-        @provider.instance_variable_get("@status_check_success").should be_false
+        expect(@provider.instance_variable_get("@status_check_success")).to be_false
       end
     end
 
     it "should check if the service is enabled" do
-      @provider.should_receive(:is_enabled?)
+      expect(@provider).to receive(:is_enabled?)
       @provider.load_current_resource
     end
 
     it "should set enabled to true if the service is enabled" do
-      @provider.stub(:is_enabled?).and_return(true)
-      @current_resource.should_receive(:enabled).with(true)
+      allow(@provider).to receive(:is_enabled?).and_return(true)
+      expect(@current_resource).to receive(:enabled).with(true)
       @provider.load_current_resource
     end
 
     it "should set enabled to false if the service is not enabled" do
-      @provider.stub(:is_enabled?).and_return(false)
-      @current_resource.should_receive(:enabled).with(false)
+      allow(@provider).to receive(:is_enabled?).and_return(false)
+      expect(@current_resource).to receive(:enabled).with(false)
       @provider.load_current_resource
     end
 
     it "should return the current resource" do
-      @provider.load_current_resource.should eql(@current_resource)
+      expect(@provider.load_current_resource).to eql(@current_resource)
     end
   end
 
   describe "start and stop service" do
     before(:each) do
       @current_resource = Chef::Resource::Service.new('rsyslog.service')
-      Chef::Resource::Service.stub(:new).and_return(@current_resource)
+      allow(Chef::Resource::Service).to receive(:new).and_return(@current_resource)
       @provider.current_resource = @current_resource
     end
 
     it "should call the start command if one is specified" do
-      @new_resource.stub(:start_command).and_return("/sbin/rsyslog startyousillysally")
-      @provider.should_receive(:shell_out_with_systems_locale!).with("/sbin/rsyslog startyousillysally")
+      allow(@new_resource).to receive(:start_command).and_return("/sbin/rsyslog startyousillysally")
+      expect(@provider).to receive(:shell_out_with_systems_locale!).with("/sbin/rsyslog startyousillysally")
       @provider.start_service
     end
 
     it "should call '/bin/systemctl start service_name' if no start command is specified" do
-      @provider.should_receive(:shell_out_with_systems_locale!).with("/bin/systemctl start #{@new_resource.service_name}").and_return(@shell_out_success)
+      expect(@provider).to receive(:shell_out_with_systems_locale!).with("/bin/systemctl start #{@new_resource.service_name}").and_return(@shell_out_success)
       @provider.start_service
     end
 
     it "should not call '/bin/systemctl start service_name' if it is already running" do
-      @current_resource.stub(:running).and_return(true)
-      @provider.should_not_receive(:shell_out_with_systems_locale!).with("/bin/systemctl start #{@new_resource.service_name}")
+      allow(@current_resource).to receive(:running).and_return(true)
+      expect(@provider).not_to receive(:shell_out_with_systems_locale!).with("/bin/systemctl start #{@new_resource.service_name}")
       @provider.start_service
     end
 
     it "should call the restart command if one is specified" do
-      @current_resource.stub(:running).and_return(true)
-      @new_resource.stub(:restart_command).and_return("/sbin/rsyslog restartyousillysally")
-      @provider.should_receive(:shell_out_with_systems_locale!).with("/sbin/rsyslog restartyousillysally")
+      allow(@current_resource).to receive(:running).and_return(true)
+      allow(@new_resource).to receive(:restart_command).and_return("/sbin/rsyslog restartyousillysally")
+      expect(@provider).to receive(:shell_out_with_systems_locale!).with("/sbin/rsyslog restartyousillysally")
       @provider.restart_service
     end
 
     it "should call '/bin/systemctl restart service_name' if no restart command is specified" do
-      @current_resource.stub(:running).and_return(true)
-      @provider.should_receive(:shell_out_with_systems_locale!).with("/bin/systemctl restart #{@new_resource.service_name}").and_return(@shell_out_success)
+      allow(@current_resource).to receive(:running).and_return(true)
+      expect(@provider).to receive(:shell_out_with_systems_locale!).with("/bin/systemctl restart #{@new_resource.service_name}").and_return(@shell_out_success)
       @provider.restart_service
     end
 
     describe "reload service" do
       context "when a reload command is specified" do
         it "should call the reload command" do
-          @current_resource.stub(:running).and_return(true)
-          @new_resource.stub(:reload_command).and_return("/sbin/rsyslog reloadyousillysally")
-          @provider.should_receive(:shell_out_with_systems_locale!).with("/sbin/rsyslog reloadyousillysally")
+          allow(@current_resource).to receive(:running).and_return(true)
+          allow(@new_resource).to receive(:reload_command).and_return("/sbin/rsyslog reloadyousillysally")
+          expect(@provider).to receive(:shell_out_with_systems_locale!).with("/sbin/rsyslog reloadyousillysally")
           @provider.reload_service
         end
       end
 
       context "when a reload command is not specified" do
         it "should call '/bin/systemctl reload service_name' if the service is running" do
-          @current_resource.stub(:running).and_return(true)
-          @provider.should_receive(:shell_out_with_systems_locale!).with("/bin/systemctl reload #{@new_resource.service_name}").and_return(@shell_out_success)
+          allow(@current_resource).to receive(:running).and_return(true)
+          expect(@provider).to receive(:shell_out_with_systems_locale!).with("/bin/systemctl reload #{@new_resource.service_name}").and_return(@shell_out_success)
           @provider.reload_service
         end
 
         it "should start the service if the service is not running" do
-          @current_resource.stub(:running).and_return(false)
-          @provider.should_receive(:start_service).and_return(true)
+          allow(@current_resource).to receive(:running).and_return(false)
+          expect(@provider).to receive(:start_service).and_return(true)
           @provider.reload_service
         end
       end
     end
 
     it "should call the stop command if one is specified" do
-      @current_resource.stub(:running).and_return(true)
-      @new_resource.stub(:stop_command).and_return("/sbin/rsyslog stopyousillysally")
-      @provider.should_receive(:shell_out_with_systems_locale!).with("/sbin/rsyslog stopyousillysally")
+      allow(@current_resource).to receive(:running).and_return(true)
+      allow(@new_resource).to receive(:stop_command).and_return("/sbin/rsyslog stopyousillysally")
+      expect(@provider).to receive(:shell_out_with_systems_locale!).with("/sbin/rsyslog stopyousillysally")
       @provider.stop_service
     end
 
     it "should call '/bin/systemctl stop service_name' if no stop command is specified" do
-      @current_resource.stub(:running).and_return(true)
-      @provider.should_receive(:shell_out_with_systems_locale!).with("/bin/systemctl stop #{@new_resource.service_name}").and_return(@shell_out_success)
+      allow(@current_resource).to receive(:running).and_return(true)
+      expect(@provider).to receive(:shell_out_with_systems_locale!).with("/bin/systemctl stop #{@new_resource.service_name}").and_return(@shell_out_success)
       @provider.stop_service
     end
 
     it "should not call '/bin/systemctl stop service_name' if it is already stopped" do
-      @current_resource.stub(:running).and_return(false)
-      @provider.should_not_receive(:shell_out_with_systems_locale!).with("/bin/systemctl stop #{@new_resource.service_name}")
+      allow(@current_resource).to receive(:running).and_return(false)
+      expect(@provider).not_to receive(:shell_out_with_systems_locale!).with("/bin/systemctl stop #{@new_resource.service_name}")
       @provider.stop_service
     end
   end
@@ -205,17 +205,17 @@ describe Chef::Provider::Service::Systemd do
   describe "enable and disable service" do
     before(:each) do
       @current_resource = Chef::Resource::Service.new('rsyslog.service')
-      Chef::Resource::Service.stub(:new).and_return(@current_resource)
+      allow(Chef::Resource::Service).to receive(:new).and_return(@current_resource)
       @provider.current_resource = @current_resource
     end
 
     it "should call '/bin/systemctl enable service_name' to enable the service" do
-      @provider.should_receive(:shell_out!).with("/bin/systemctl enable #{@new_resource.service_name}").and_return(@shell_out_success)
+      expect(@provider).to receive(:shell_out!).with("/bin/systemctl enable #{@new_resource.service_name}").and_return(@shell_out_success)
       @provider.enable_service
     end
 
     it "should call '/bin/systemctl disable service_name' to disable the service" do
-      @provider.should_receive(:shell_out!).with("/bin/systemctl disable #{@new_resource.service_name}").and_return(@shell_out_success)
+      expect(@provider).to receive(:shell_out!).with("/bin/systemctl disable #{@new_resource.service_name}").and_return(@shell_out_success)
       @provider.disable_service
     end
   end
@@ -223,34 +223,34 @@ describe Chef::Provider::Service::Systemd do
   describe "is_active?" do
     before(:each) do
       @current_resource = Chef::Resource::Service.new('rsyslog.service')
-      Chef::Resource::Service.stub(:new).and_return(@current_resource)
+      allow(Chef::Resource::Service).to receive(:new).and_return(@current_resource)
     end
 
     it "should return true if '/bin/systemctl is-active service_name' returns 0" do
-      @provider.should_receive(:shell_out).with('/bin/systemctl is-active rsyslog.service --quiet').and_return(@shell_out_success)
-      @provider.is_active?.should be_true
+      expect(@provider).to receive(:shell_out).with('/bin/systemctl is-active rsyslog.service --quiet').and_return(@shell_out_success)
+      expect(@provider.is_active?).to be_true
     end
 
     it "should return false if '/bin/systemctl is-active service_name' returns anything except 0" do
-      @provider.should_receive(:shell_out).with('/bin/systemctl is-active rsyslog.service --quiet').and_return(@shell_out_failure)
-      @provider.is_active?.should be_false
+      expect(@provider).to receive(:shell_out).with('/bin/systemctl is-active rsyslog.service --quiet').and_return(@shell_out_failure)
+      expect(@provider.is_active?).to be_false
     end
   end
 
   describe "is_enabled?" do
     before(:each) do
       @current_resource = Chef::Resource::Service.new('rsyslog.service')
-      Chef::Resource::Service.stub(:new).and_return(@current_resource)
+      allow(Chef::Resource::Service).to receive(:new).and_return(@current_resource)
     end
 
     it "should return true if '/bin/systemctl is-enabled service_name' returns 0" do
-      @provider.should_receive(:shell_out).with('/bin/systemctl is-enabled rsyslog.service --quiet').and_return(@shell_out_success)
-      @provider.is_enabled?.should be_true
+      expect(@provider).to receive(:shell_out).with('/bin/systemctl is-enabled rsyslog.service --quiet').and_return(@shell_out_success)
+      expect(@provider.is_enabled?).to be_true
     end
 
     it "should return false if '/bin/systemctl is-enabled service_name' returns anything except 0" do
-      @provider.should_receive(:shell_out).with('/bin/systemctl is-enabled rsyslog.service --quiet').and_return(@shell_out_failure)
-      @provider.is_enabled?.should be_false
+      expect(@provider).to receive(:shell_out).with('/bin/systemctl is-enabled rsyslog.service --quiet').and_return(@shell_out_failure)
+      expect(@provider.is_enabled?).to be_false
     end
   end
 end