chef 12.0.0.alpha.2-x86-mingw32 → 12.0.0.rc.0-x86-mingw32

data/spec/unit/provider/group/groupmod_spec.rb

@@ -33,18 +33,18 @@ describe Chef::Provider::Group::Groupmod do
   describe "manage_group" do
     describe "when determining the current group state" do
       it "should raise an error if the required binary /usr/sbin/group doesn't exist" do
-        File.should_receive(:exists?).with("/usr/sbin/group").and_return(false)
-        lambda { @provider.load_current_resource }.should raise_error(Chef::Exceptions::Group)
+        expect(File).to receive(:exists?).with("/usr/sbin/group").and_return(false)
+        expect { @provider.load_current_resource }.to raise_error(Chef::Exceptions::Group)
       end
       it "should raise an error if the required binary /usr/sbin/user doesn't exist" do
-        File.should_receive(:exists?).with("/usr/sbin/group").and_return(true)
-        File.should_receive(:exists?).with("/usr/sbin/user").and_return(false)
-        lambda { @provider.load_current_resource }.should raise_error(Chef::Exceptions::Group)
+        expect(File).to receive(:exists?).with("/usr/sbin/group").and_return(true)
+        expect(File).to receive(:exists?).with("/usr/sbin/user").and_return(false)
+        expect { @provider.load_current_resource }.to raise_error(Chef::Exceptions::Group)
       end
 
       it "shouldn't raise an error if the required binaries exist" do
-        File.stub(:exists?).and_return(true)
-        lambda { @provider.load_current_resource }.should_not raise_error
+        allow(File).to receive(:exists?).and_return(true)
+        expect { @provider.load_current_resource }.not_to raise_error
       end
     end
 
@@ -61,10 +61,10 @@ describe Chef::Provider::Group::Groupmod do
         end
 
         it "logs a message and sets group's members to 'none', then removes existing group members" do
-          Chef::Log.should_receive(:debug).with("group[wheel] setting group members to: none")
-          @provider.should_receive(:shell_out!).with("group mod -n wheel_bak wheel")
-          @provider.should_receive(:shell_out!).with("group add -g '123' -o wheel")
-          @provider.should_receive(:shell_out!).with("group del wheel_bak")
+          expect(Chef::Log).to receive(:debug).with("group[wheel] setting group members to: none")
+          expect(@provider).to receive(:shell_out!).with("group mod -n wheel_bak wheel")
+          expect(@provider).to receive(:shell_out!).with("group add -g '123' -o wheel")
+          expect(@provider).to receive(:shell_out!).with("group del wheel_bak")
           @provider.manage_group
         end
       end
@@ -76,8 +76,8 @@ describe Chef::Provider::Group::Groupmod do
         end
 
         it "logs a message and does not modify group membership" do
-          Chef::Log.should_receive(:debug).with("group[wheel] not changing group members, the group has no members to add")
-          @provider.should_not_receive(:shell_out!)
+          expect(Chef::Log).to receive(:debug).with("group[wheel] not changing group members, the group has no members to add")
+          expect(@provider).not_to receive(:shell_out!)
           @provider.manage_group
         end
       end
@@ -89,11 +89,11 @@ describe Chef::Provider::Group::Groupmod do
         end
 
         it "updates group membership correctly" do
-          Chef::Log.stub(:debug)
-          @provider.should_receive(:shell_out!).with("group mod -n wheel_bak wheel")
-          @provider.should_receive(:shell_out!).with("user mod -G wheel lobster")
-          @provider.should_receive(:shell_out!).with("group add -g '123' -o wheel")
-          @provider.should_receive(:shell_out!).with("group del wheel_bak")
+          allow(Chef::Log).to receive(:debug)
+          expect(@provider).to receive(:shell_out!).with("group mod -n wheel_bak wheel")
+          expect(@provider).to receive(:shell_out!).with("user mod -G wheel lobster")
+          expect(@provider).to receive(:shell_out!).with("group add -g '123' -o wheel")
+          expect(@provider).to receive(:shell_out!).with("group del wheel_bak")
           @provider.manage_group
         end
       end
@@ -108,10 +108,10 @@ describe Chef::Provider::Group::Groupmod do
       end
 
       it "should run a group add command and some user mod commands" do
-        @provider.should_receive(:shell_out!).with("group add -g '123' wheel")
-        @provider.should_receive(:shell_out!).with("user mod -G wheel lobster")
-        @provider.should_receive(:shell_out!).with("user mod -G wheel rage")
-        @provider.should_receive(:shell_out!).with("user mod -G wheel fist")
+        expect(@provider).to receive(:shell_out!).with("group add -g '123' wheel")
+        expect(@provider).to receive(:shell_out!).with("user mod -G wheel lobster")
+        expect(@provider).to receive(:shell_out!).with("user mod -G wheel rage")
+        expect(@provider).to receive(:shell_out!).with("user mod -G wheel fist")
         @provider.create_group
       end
     end
@@ -125,7 +125,7 @@ describe Chef::Provider::Group::Groupmod do
       end
 
       it "should run a group del command" do
-        @provider.should_receive(:shell_out!).with("group del wheel")
+        expect(@provider).to receive(:shell_out!).with("group del wheel")
         @provider.remove_group
       end
     end

data/spec/unit/provider/group/pw_spec.rb

@@ -37,19 +37,19 @@ describe Chef::Provider::Group::Pw do
 
   describe "when setting options for the pw command" do
     it "does not set the gid option if gids match or are unmanaged" do
-      @provider.set_options.should ==  " wheel"
+      expect(@provider.set_options).to eq(" wheel")
     end
 
     it "sets the option for gid if it is not nil" do
       @new_resource.gid(42)
-      @provider.set_options.should eql(" wheel -g '42'")
+      expect(@provider.set_options).to eql(" wheel -g '42'")
     end
   end
 
   describe "when creating a group" do
     it "should run pw groupadd with the return of set_options and set_members_option" do
       @new_resource.gid(23)
-      @provider.should_receive(:run_command).with({ :command => "pw groupadd wheel -g '23' -M root,aj" }).and_return(true)
+      expect(@provider).to receive(:run_command).with({ :command => "pw groupadd wheel -g '23' -M root,aj" }).and_return(true)
       @provider.create_group
     end
   end
@@ -59,8 +59,8 @@ describe Chef::Provider::Group::Pw do
     it "should run pw groupmod with the return of set_options" do
       @new_resource.gid(42)
       @new_resource.members(["someone"])
-      @provider.should_receive(:run_command).with({ :command => "pw groupmod wheel -g '42' -m someone" }).and_return(true)
-      @provider.should_receive(:run_command).with({ :command => "pw groupmod wheel -g '42' -d root,aj" }).and_return(true)
+      expect(@provider).to receive(:run_command).with({ :command => "pw groupmod wheel -g '42' -m someone" }).and_return(true)
+      expect(@provider).to receive(:run_command).with({ :command => "pw groupmod wheel -g '42' -d root,aj" }).and_return(true)
       @provider.manage_group
     end
 
@@ -68,7 +68,7 @@ describe Chef::Provider::Group::Pw do
 
   describe "when removing the group" do
     it "should run pw groupdel with the new resources group name" do
-      @provider.should_receive(:run_command).with({ :command => "pw groupdel wheel" }).and_return(true)
+      expect(@provider).to receive(:run_command).with({ :command => "pw groupdel wheel" }).and_return(true)
       @provider.remove_group
     end
   end
@@ -77,44 +77,44 @@ describe Chef::Provider::Group::Pw do
 
     describe "with an empty members array in both the new and current resource" do
       before do
-        @new_resource.stub(:members).and_return([])
-        @current_resource.stub(:members).and_return([])
+        allow(@new_resource).to receive(:members).and_return([])
+        allow(@current_resource).to receive(:members).and_return([])
       end
 
       it "should set no options" do
-        @provider.set_members_options.should eql([ ])
+        expect(@provider.set_members_options).to eql([ ])
       end
     end
 
     describe "with an empty members array in the new resource and existing members in the current resource" do
       before do
-        @new_resource.stub(:members).and_return([])
-        @current_resource.stub(:members).and_return(["all", "your", "base"])
+        allow(@new_resource).to receive(:members).and_return([])
+        allow(@current_resource).to receive(:members).and_return(["all", "your", "base"])
       end
 
       it "should log an appropriate message" do
-        Chef::Log.should_receive(:debug).with("group[wheel] removing group members: all,your,base")
+        expect(Chef::Log).to receive(:debug).with("group[wheel] removing group members: all,your,base")
         @provider.set_members_options
       end
 
       it "should set the -d option with the members joined by ','" do
-        @provider.set_members_options.should eql([ " -d all,your,base" ])
+        expect(@provider.set_members_options).to eql([ " -d all,your,base" ])
       end
     end
 
     describe "with supplied members array in the new resource and an empty members array in the current resource" do
       before do
-        @new_resource.stub(:members).and_return(["all", "your", "base"])
-        @current_resource.stub(:members).and_return([])
+        allow(@new_resource).to receive(:members).and_return(["all", "your", "base"])
+        allow(@current_resource).to receive(:members).and_return([])
       end
 
       it "should log an appropriate debug message" do
-        Chef::Log.should_receive(:debug).with("group[wheel] adding group members: all,your,base")
+        expect(Chef::Log).to receive(:debug).with("group[wheel] adding group members: all,your,base")
         @provider.set_members_options
       end
 
       it "should set the -m option with the members joined by ','" do
-        @provider.set_members_options.should eql([ " -m all,your,base" ])
+        expect(@provider.set_members_options).to eql([ " -m all,your,base" ])
       end
     end
   end
@@ -126,13 +126,13 @@ describe Chef::Provider::Group::Pw do
       @provider.define_resource_requirements
     end
     it "should raise an error if the required binary /usr/sbin/pw doesn't exist" do
-      File.should_receive(:exists?).with("/usr/sbin/pw").and_return(false)
-      lambda { @provider.process_resource_requirements }.should raise_error(Chef::Exceptions::Group)
+      expect(File).to receive(:exists?).with("/usr/sbin/pw").and_return(false)
+      expect { @provider.process_resource_requirements }.to raise_error(Chef::Exceptions::Group)
     end
 
     it "shouldn't raise an error if /usr/sbin/pw exists" do
-      File.stub(:exists?).and_return(true)
-      lambda { @provider.process_resource_requirements }.should_not raise_error
+      allow(File).to receive(:exists?).and_return(true)
+      expect { @provider.process_resource_requirements }.not_to raise_error
     end
   end
 end

data/spec/unit/provider/group/usermod_spec.rb

@@ -27,19 +27,19 @@ describe Chef::Provider::Group::Usermod do
     @new_resource.members [ "all", "your", "base" ]
     @new_resource.excluded_members [ ]
     @provider = Chef::Provider::Group::Usermod.new(@new_resource, @run_context)
-    @provider.stub(:run_command)
+    allow(@provider).to receive(:run_command)
   end
 
   describe "modify_group_members" do
 
     describe "with an empty members array" do
       before do
-        @new_resource.stub(:append).and_return(true)
-        @new_resource.stub(:members).and_return([])
+        allow(@new_resource).to receive(:append).and_return(true)
+        allow(@new_resource).to receive(:members).and_return([])
       end
 
       it "should log an appropriate message" do
-        @provider.should_not_receive(:shell_out!)
+        expect(@provider).not_to receive(:shell_out!)
         @provider.modify_group_members
       end
     end
@@ -56,8 +56,8 @@ describe Chef::Provider::Group::Usermod do
       }
 
       before do
-        @new_resource.stub(:members).and_return(["all", "your", "base"])
-        File.stub(:exists?).and_return(true)
+        allow(@new_resource).to receive(:members).and_return(["all", "your", "base"])
+        allow(File).to receive(:exists?).and_return(true)
       end
 
       it "should raise an error when setting the entire group directly" do
@@ -65,7 +65,7 @@ describe Chef::Provider::Group::Usermod do
         @provider.load_current_resource
         @provider.instance_variable_set("@group_exists", true)
         @provider.action = :modify
-        lambda { @provider.run_action(@provider.process_resource_requirements) }.should raise_error(Chef::Exceptions::Group, "setting group members directly is not supported by #{@provider.to_s}, must set append true in group")
+        expect { @provider.run_action(@provider.process_resource_requirements) }.to raise_error(Chef::Exceptions::Group, "setting group members directly is not supported by #{@provider.to_s}, must set append true in group")
       end
 
       it "should raise an error when excluded_members are set" do
@@ -73,9 +73,9 @@ describe Chef::Provider::Group::Usermod do
         @provider.load_current_resource
         @provider.instance_variable_set("@group_exists", true)
         @provider.action = :modify
-        @new_resource.stub(:append).and_return(true)
-        @new_resource.stub(:excluded_members).and_return(["someone"])
-        lambda { @provider.run_action(@provider.process_resource_requirements) }.should raise_error(Chef::Exceptions::Group, "excluded_members is not supported by #{@provider.to_s}")
+        allow(@new_resource).to receive(:append).and_return(true)
+        allow(@new_resource).to receive(:excluded_members).and_return(["someone"])
+        expect { @provider.run_action(@provider.process_resource_requirements) }.to raise_error(Chef::Exceptions::Group, "excluded_members is not supported by #{@provider.to_s}")
       end
 
       platforms.each do |platform, flags|
@@ -84,10 +84,10 @@ describe Chef::Provider::Group::Usermod do
           current_resource.members([ ])
           @provider.current_resource = current_resource
           @node.automatic_attrs[:platform] = platform
-          @new_resource.stub(:append).and_return(true)
-          @provider.should_receive(:shell_out!).with("usermod #{flags} wheel all")
-          @provider.should_receive(:shell_out!).with("usermod #{flags} wheel your")
-          @provider.should_receive(:shell_out!).with("usermod #{flags} wheel base")
+          allow(@new_resource).to receive(:append).and_return(true)
+          expect(@provider).to receive(:shell_out!).with("usermod #{flags} wheel all")
+          expect(@provider).to receive(:shell_out!).with("usermod #{flags} wheel your")
+          expect(@provider).to receive(:shell_out!).with("usermod #{flags} wheel base")
           @provider.modify_group_members
         end
       end
@@ -96,20 +96,20 @@ describe Chef::Provider::Group::Usermod do
 
   describe "when loading the current resource" do
     before(:each) do
-      File.stub(:exists?).and_return(false)
+      allow(File).to receive(:exists?).and_return(false)
       @provider.action = :create
       @provider.define_resource_requirements
     end
 
     it "should raise an error if the required binary /usr/sbin/usermod doesn't exist" do
-      File.stub(:exists?).and_return(true)
-      File.should_receive(:exists?).with("/usr/sbin/usermod").and_return(false)
-      lambda { @provider.process_resource_requirements }.should raise_error(Chef::Exceptions::Group)
+      allow(File).to receive(:exists?).and_return(true)
+      expect(File).to receive(:exists?).with("/usr/sbin/usermod").and_return(false)
+      expect { @provider.process_resource_requirements }.to raise_error(Chef::Exceptions::Group)
     end
 
     it "shouldn't raise an error if the required binaries exist" do
-      File.stub(:exists?).and_return(true)
-      lambda { @provider.process_resource_requirements }.should_not raise_error
+      allow(File).to receive(:exists?).and_return(true)
+      expect { @provider.process_resource_requirements }.not_to raise_error
     end
   end
 end

data/spec/unit/provider/group/windows_spec.rb

@@ -34,14 +34,14 @@ describe Chef::Provider::Group::Windows do
     @run_context = Chef::RunContext.new(@node, {}, @events)
     @new_resource = Chef::Resource::Group.new("staff")
     @net_group = double("Chef::Util::Windows::NetGroup")
-    Chef::Util::Windows::NetGroup.stub(:new).and_return(@net_group)
+    allow(Chef::Util::Windows::NetGroup).to receive(:new).and_return(@net_group)
     @provider = Chef::Provider::Group::Windows.new(@new_resource, @run_context)
   end
 
   describe "when creating the group" do
     it "should call @net_group.local_add" do
-      @net_group.should_receive(:local_set_members).with([])
-      @net_group.should_receive(:local_add)
+      expect(@net_group).to receive(:local_set_members).with([])
+      expect(@net_group).to receive(:local_add)
       @provider.create_group
     end
   end
@@ -52,22 +52,22 @@ describe Chef::Provider::Group::Windows do
       @current_resource = Chef::Resource::Group.new("staff")
       @current_resource.members [ "all", "your", "base" ]
 
-      Chef::Util::Windows::NetGroup.stub(:new).and_return(@net_group)
-      @net_group.stub(:local_add_members)
-      @net_group.stub(:local_set_members)
-      @provider.stub(:local_group_name_to_sid)
+      allow(Chef::Util::Windows::NetGroup).to receive(:new).and_return(@net_group)
+      allow(@net_group).to receive(:local_add_members)
+      allow(@net_group).to receive(:local_set_members)
+      allow(@provider).to receive(:local_group_name_to_sid)
       @provider.current_resource = @current_resource
     end
 
     it "should call @net_group.local_set_members" do
-      @new_resource.stub(:append).and_return(false)
-      @net_group.should_receive(:local_set_members).with(@new_resource.members)
+      allow(@new_resource).to receive(:append).and_return(false)
+      expect(@net_group).to receive(:local_set_members).with(@new_resource.members)
       @provider.manage_group
     end
 
     it "should call @net_group.local_add_members" do
-      @new_resource.stub(:append).and_return(true)
-      @net_group.should_receive(:local_add_members).with(@new_resource.members)
+      allow(@new_resource).to receive(:append).and_return(true)
+      expect(@net_group).to receive(:local_add_members).with(@new_resource.members)
       @provider.manage_group
     end
 
@@ -75,12 +75,12 @@ describe Chef::Provider::Group::Windows do
 
   describe "remove_group" do
     before do
-      Chef::Util::Windows::NetGroup.stub(:new).and_return(@net_group)
-      @provider.stub(:run_command).and_return(true)
+      allow(Chef::Util::Windows::NetGroup).to receive(:new).and_return(@net_group)
+      allow(@provider).to receive(:run_command).and_return(true)
     end
 
     it "should call @net_group.local_delete" do
-      @net_group.should_receive(:local_delete)
+      expect(@net_group).to receive(:local_delete)
       @provider.remove_group
     end
   end
@@ -95,7 +95,7 @@ describe Chef::Provider::Group::Windows, "NetGroup" do
     @new_resource.group_name "Remote Desktop Users"
   end
   it 'sets group_name correctly' do
-    Chef::Util::Windows::NetGroup.should_receive(:new).with("Remote Desktop Users")
+    expect(Chef::Util::Windows::NetGroup).to receive(:new).with("Remote Desktop Users")
     Chef::Provider::Group::Windows.new(@new_resource, @run_context)
   end
 end

data/spec/unit/provider/group_spec.rb

@@ -41,89 +41,89 @@ describe Chef::Provider::User do
       :gid => 20,
       :mem => [ "root", "aj" ]
       )
-    Etc.stub(:getgrnam).with('wheel').and_return(@pw_group)
+    allow(Etc).to receive(:getgrnam).with('wheel').and_return(@pw_group)
   end
 
   it "assumes the group exists by default" do
-    @provider.group_exists.should be_true
+    expect(@provider.group_exists).to be_true
   end
 
   describe "when establishing the current state of the group" do
 
     it "sets the group name of the current resource to the group name of the new resource" do
       @provider.load_current_resource
-      @provider.current_resource.group_name.should == 'wheel'
+      expect(@provider.current_resource.group_name).to eq('wheel')
     end
 
     it "does not modify the desired gid if set" do
       @provider.load_current_resource
-      @new_resource.gid.should == 500
+      expect(@new_resource.gid).to eq(500)
     end
 
     it "sets the desired gid to the current gid if none is set" do
       @new_resource.instance_variable_set(:@gid, nil)
       @provider.load_current_resource
-      @new_resource.gid.should == 20
+      expect(@new_resource.gid).to eq(20)
     end
 
     it "looks up the group in /etc/group with getgrnam" do
-      Etc.should_receive(:getgrnam).with(@new_resource.group_name).and_return(@pw_group)
+      expect(Etc).to receive(:getgrnam).with(@new_resource.group_name).and_return(@pw_group)
       @provider.load_current_resource
-      @provider.current_resource.gid.should == 20
-      @provider.current_resource.members.should == %w{root aj}
+      expect(@provider.current_resource.gid).to eq(20)
+      expect(@provider.current_resource.members).to eq(%w{root aj})
     end
 
     it "should flip the value of exists if it cannot be found in /etc/group" do
-      Etc.stub(:getgrnam).and_raise(ArgumentError)
+      allow(Etc).to receive(:getgrnam).and_raise(ArgumentError)
       @provider.load_current_resource
-      @provider.group_exists.should be_false
+      expect(@provider.group_exists).to be_false
     end
 
     it "should return the current resource" do
-      @provider.load_current_resource.should equal(@provider.current_resource)
+      expect(@provider.load_current_resource).to equal(@provider.current_resource)
     end
   end
 
   describe "when determining if the system is already in the target state" do
     [ :gid, :members ].each do |attribute|
       it "should return true if #{attribute} doesn't match" do
-        @current_resource.stub(attribute).and_return("looooooooooooooooooool")
-        @provider.compare_group.should be_true
+        allow(@current_resource).to receive(attribute).and_return("looooooooooooooooooool")
+        expect(@provider.compare_group).to be_true
       end
     end
 
     it "should return false if gid and members are equal" do
-      @provider.compare_group.should be_false
+      expect(@provider.compare_group).to be_false
     end
 
     it "should coerce an integer to a string for comparison" do
-      @current_resource.stub(:gid).and_return("500")
-      @provider.compare_group.should be_false
+      allow(@current_resource).to receive(:gid).and_return("500")
+      expect(@provider.compare_group).to be_false
     end
 
     it "should return false if append is true and the group member(s) already exists" do
       @current_resource.members << "extra_user"
-      @new_resource.stub(:append).and_return(true)
-      @provider.compare_group.should be_false
+      allow(@new_resource).to receive(:append).and_return(true)
+      expect(@provider.compare_group).to be_false
     end
 
     it "should return true if append is true and the group member(s) do not already exist" do
       @new_resource.members << "extra_user"
-      @new_resource.stub(:append).and_return(true)
-      @provider.compare_group.should be_true
+      allow(@new_resource).to receive(:append).and_return(true)
+      expect(@provider.compare_group).to be_true
     end
 
     it "should return false if append is true and excluded_members include a non existing member" do
       @new_resource.excluded_members << "extra_user"
-      @new_resource.stub(:append).and_return(true)
-      @provider.compare_group.should be_false
+      allow(@new_resource).to receive(:append).and_return(true)
+      expect(@provider.compare_group).to be_false
     end
 
     it "should return true if the append is true and excluded_members include an existing user" do
       @new_resource.members.each {|m| @new_resource.excluded_members << m }
       @new_resource.members.clear
-      @new_resource.stub(:append).and_return(true)
-      @provider.compare_group.should be_true
+      allow(@new_resource).to receive(:append).and_return(true)
+      expect(@provider.compare_group).to be_true
     end
 
   end
@@ -131,40 +131,40 @@ describe Chef::Provider::User do
   describe "when creating a group" do
     it "should call create_group if the group does not exist" do
       @provider.group_exists = false
-      @provider.should_receive(:create_group).and_return(true)
+      expect(@provider).to receive(:create_group).and_return(true)
       @provider.run_action(:create)
     end
 
     it "should set the new_resources updated flag when it creates the group" do
       @provider.group_exists = false
-      @provider.stub(:create_group)
+      allow(@provider).to receive(:create_group)
       @provider.run_action(:create)
-      @provider.new_resource.should be_updated
+      expect(@provider.new_resource).to be_updated
     end
 
     it "should check to see if the group has mismatched attributes if the group exists" do
       @provider.group_exists = true
-      @provider.stub(:compare_group).and_return(false)
-      @provider.stub(:change_desc).and_return([ ])
+      allow(@provider).to receive(:compare_group).and_return(false)
+      allow(@provider).to receive(:change_desc).and_return([ ])
       @provider.run_action(:create)
-      @provider.new_resource.should_not be_updated
+      expect(@provider.new_resource).not_to be_updated
     end
 
     it "should call manage_group if the group exists and has mismatched attributes" do
       @provider.group_exists = true
-      @provider.stub(:compare_group).and_return(true)
-      @provider.stub(:change_desc).and_return([ ])
-      @provider.should_receive(:manage_group).and_return(true)
+      allow(@provider).to receive(:compare_group).and_return(true)
+      allow(@provider).to receive(:change_desc).and_return([ ])
+      expect(@provider).to receive(:manage_group).and_return(true)
       @provider.run_action(:create)
     end
 
     it "should set the new_resources updated flag when it creates the group if we call manage_group" do
       @provider.group_exists = true
-      @provider.stub(:compare_group).and_return(true)
-      @provider.stub(:change_desc).and_return(["Some changes are going to be done."])
-      @provider.stub(:manage_group).and_return(true)
+      allow(@provider).to receive(:compare_group).and_return(true)
+      allow(@provider).to receive(:change_desc).and_return(["Some changes are going to be done."])
+      allow(@provider).to receive(:manage_group).and_return(true)
       @provider.run_action(:create)
-      @new_resource.should be_updated
+      expect(@new_resource).to be_updated
     end
   end
 
@@ -172,50 +172,50 @@ describe Chef::Provider::User do
 
     it "should not call remove_group if the group does not exist" do
       @provider.group_exists = false
-      @provider.should_not_receive(:remove_group)
+      expect(@provider).not_to receive(:remove_group)
       @provider.run_action(:remove)
-      @provider.new_resource.should_not be_updated
+      expect(@provider.new_resource).not_to be_updated
     end
 
     it "should call remove_group if the group exists" do
       @provider.group_exists = true
-      @provider.should_receive(:remove_group)
+      expect(@provider).to receive(:remove_group)
       @provider.run_action(:remove)
-      @provider.new_resource.should be_updated
+      expect(@provider.new_resource).to be_updated
     end
   end
 
   describe "when updating a group" do
     before(:each) do
       @provider.group_exists = true
-      @provider.stub(:manage_group).and_return(true)
+      allow(@provider).to receive(:manage_group).and_return(true)
     end
 
     it "should run manage_group if the group exists and has mismatched attributes" do
-      @provider.should_receive(:compare_group).and_return(true)
-      @provider.stub(:change_desc).and_return(["Some changes are going to be done."])
-      @provider.should_receive(:manage_group).and_return(true)
+      expect(@provider).to receive(:compare_group).and_return(true)
+      allow(@provider).to receive(:change_desc).and_return(["Some changes are going to be done."])
+      expect(@provider).to receive(:manage_group).and_return(true)
       @provider.run_action(:manage)
     end
 
     it "should set the new resources updated flag to true if manage_group is called" do
-      @provider.stub(:compare_group).and_return(true)
-      @provider.stub(:change_desc).and_return(["Some changes are going to be done."])
-      @provider.stub(:manage_group).and_return(true)
+      allow(@provider).to receive(:compare_group).and_return(true)
+      allow(@provider).to receive(:change_desc).and_return(["Some changes are going to be done."])
+      allow(@provider).to receive(:manage_group).and_return(true)
       @provider.run_action(:manage)
-      @new_resource.should be_updated
+      expect(@new_resource).to be_updated
     end
 
     it "should not run manage_group if the group does not exist" do
       @provider.group_exists = false
-      @provider.should_not_receive(:manage_group)
+      expect(@provider).not_to receive(:manage_group)
       @provider.run_action(:manage)
     end
 
     it "should not run manage_group if the group exists but has no differing attributes" do
-      @provider.should_receive(:compare_group).and_return(false)
-      @provider.stub(:change_desc).and_return(["Some changes are going to be done."])
-      @provider.should_not_receive(:manage_group)
+      expect(@provider).to receive(:compare_group).and_return(false)
+      allow(@provider).to receive(:change_desc).and_return(["Some changes are going to be done."])
+      expect(@provider).not_to receive(:manage_group)
       @provider.run_action(:manage)
     end
   end
@@ -223,34 +223,34 @@ describe Chef::Provider::User do
   describe "when modifying the group" do
     before(:each) do
       @provider.group_exists = true
-      @provider.stub(:manage_group).and_return(true)
+      allow(@provider).to receive(:manage_group).and_return(true)
     end
 
     it "should run manage_group if the group exists and has mismatched attributes" do
-      @provider.should_receive(:compare_group).and_return(true)
-      @provider.stub(:change_desc).and_return(["Some changes are going to be done."])
-      @provider.should_receive(:manage_group).and_return(true)
+      expect(@provider).to receive(:compare_group).and_return(true)
+      allow(@provider).to receive(:change_desc).and_return(["Some changes are going to be done."])
+      expect(@provider).to receive(:manage_group).and_return(true)
       @provider.run_action(:modify)
     end
 
     it "should set the new resources updated flag to true if manage_group is called" do
-      @provider.stub(:compare_group).and_return(true)
-      @provider.stub(:change_desc).and_return(["Some changes are going to be done."])
-      @provider.stub(:manage_group).and_return(true)
+      allow(@provider).to receive(:compare_group).and_return(true)
+      allow(@provider).to receive(:change_desc).and_return(["Some changes are going to be done."])
+      allow(@provider).to receive(:manage_group).and_return(true)
       @provider.run_action(:modify)
-      @new_resource.should be_updated
+      expect(@new_resource).to be_updated
     end
 
     it "should not run manage_group if the group exists but has no differing attributes" do
-      @provider.should_receive(:compare_group).and_return(false)
-      @provider.stub(:change_desc).and_return(["Some changes are going to be done."])
-      @provider.should_not_receive(:manage_group)
+      expect(@provider).to receive(:compare_group).and_return(false)
+      allow(@provider).to receive(:change_desc).and_return(["Some changes are going to be done."])
+      expect(@provider).not_to receive(:manage_group)
       @provider.run_action(:modify)
     end
 
     it "should raise a Chef::Exceptions::Group if the group doesn't exist" do
       @provider.group_exists = false
-      lambda { @provider.run_action(:modify) }.should raise_error(Chef::Exceptions::Group)
+      expect { @provider.run_action(:modify) }.to raise_error(Chef::Exceptions::Group)
     end
   end
 
@@ -258,28 +258,28 @@ describe Chef::Provider::User do
     it "should report which group members are missing if members are missing and appending to the group" do
        @new_resource.members << "user1"
        @new_resource.members << "user2"
-       @new_resource.stub(:append).and_return true
-       @provider.compare_group.should be_true
-       @provider.change_desc.should == [ "add missing member(s): user1, user2" ]
+       allow(@new_resource).to receive(:append).and_return true
+       expect(@provider.compare_group).to be_true
+       expect(@provider.change_desc).to eq([ "add missing member(s): user1, user2" ])
     end
 
     it "should report that the group members will be overwritten if not appending" do
        @new_resource.members << "user1"
-       @new_resource.stub(:append).and_return false
-       @provider.compare_group.should be_true
-       @provider.change_desc.should == [ "replace group members with new list of members" ]
+       allow(@new_resource).to receive(:append).and_return false
+       expect(@provider.compare_group).to be_true
+       expect(@provider.change_desc).to eq([ "replace group members with new list of members" ])
     end
 
     it "should report the gid will be changed when it does not match" do
-      @current_resource.stub(:gid).and_return("BADF00D")
-      @provider.compare_group.should be_true
-      @provider.change_desc.should == [ "change gid #{@current_resource.gid} to #{@new_resource.gid}" ]
+      allow(@current_resource).to receive(:gid).and_return("BADF00D")
+      expect(@provider.compare_group).to be_true
+      expect(@provider.change_desc).to eq([ "change gid #{@current_resource.gid} to #{@new_resource.gid}" ])
 
     end
 
     it "should report no change reason when no change is required" do
-      @provider.compare_group.should be_false
-      @provider.change_desc.should == [ ]
+      expect(@provider.compare_group).to be_false
+      expect(@provider.change_desc).to eq([ ])
     end
   end