chef 10.12.0 → 10.14.0.beta.1

data/spec/unit/role_spec.rb

@@ -0,0 +1,275 @@
+#
+# Author:: Adam Jacob (<adam@opscode.com>)
+# Copyright:: Copyright (c) 2008 Opscode, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'spec_helper'
+require 'chef/role'
+
+describe Chef::Role do
+  before(:each) do
+    @role = Chef::Role.new
+    @role.name("ops_master")
+  end
+
+  it "has a name" do
+    @role.name("ops_master").should == "ops_master"
+  end
+
+  it "does not accept a name with spaces" do
+    lambda { @role.name "ops master" }.should raise_error(ArgumentError)
+  end
+
+  it "does not accept non-String objects for the name" do
+    lambda { @role.name({}) }.should raise_error(ArgumentError)
+  end
+
+  describe "when a run list is set" do
+
+    before do
+      @role.run_list(%w{ nginx recipe[ree] role[base]})
+    end
+
+
+    it "returns the run list" do
+      @role.run_list.should == %w{ nginx recipe[ree] role[base]}
+    end
+
+    describe "and per-environment run lists are set" do
+      before do
+        @role.name("base")
+        @role.run_list(%w{ recipe[nagios::client] recipe[tims-acl::bork]})
+        @role.env_run_list["prod"] = Chef::RunList.new(*(@role.run_list.to_a << "recipe[prod-base]"))
+        @role.env_run_list["dev"]  = Chef::RunList.new
+      end
+
+      it "uses the default run list as *the* run_list" do
+        @role.run_list.should == Chef::RunList.new("recipe[nagios::client]", "recipe[tims-acl::bork]")
+      end
+
+      it "gives the default run list as the when getting the _default run list" do
+        @role.run_list_for("_default").should == @role.run_list
+      end
+
+      it "gives an environment specific run list" do
+        @role.run_list_for("prod").should == Chef::RunList.new("recipe[nagios::client]", "recipe[tims-acl::bork]", "recipe[prod-base]")
+      end
+
+      it "gives the default run list when no run list exists for the given environment" do
+        @role.run_list_for("qa").should == @role.run_list
+      end
+
+      it "gives the environment specific run list even if it is empty" do
+        @role.run_list_for("dev").should == Chef::RunList.new
+      end
+
+      it "env_run_lists can only be set with _default run list in it" do
+        long_exception_name = Chef::Exceptions::InvalidEnvironmentRunListSpecification
+        lambda {@role.env_run_lists({})}.should raise_error(long_exception_name)
+      end
+
+    end
+
+
+    describe "using the old #recipes API" do
+      it "should let you set the recipe array" do
+        @role.recipes([ "one", "two" ]).should == [ "one", "two" ]
+      end
+
+      it "should let you return the recipe array" do
+        @role.recipes([ "one", "two" ])
+        @role.recipes.should == [ "one", "two" ]
+      end
+
+      it "should not list roles in the recipe array" do
+        @role.run_list([ "one", "role[two]"])
+        @role.recipes.should == [ "recipe[one]", "role[two]" ]
+      end
+
+    end
+
+  end
+
+
+
+  describe "default_attributes" do
+    it "should let you set the default attributes hash explicitly" do
+      @role.default_attributes({ :one => 'two' }).should == { :one => 'two' }
+    end
+
+    it "should let you return the default attributes hash" do
+      @role.default_attributes({ :one => 'two' })
+      @role.default_attributes.should == { :one => 'two' }
+    end
+
+    it "should throw an ArgumentError if we aren't a kind of hash" do
+      lambda { @role.default_attributes(Array.new) }.should raise_error(ArgumentError)
+    end
+  end
+
+  describe "override_attributes" do
+    it "should let you set the override attributes hash explicitly" do
+      @role.override_attributes({ :one => 'two' }).should == { :one => 'two' }
+    end
+
+    it "should let you return the override attributes hash" do
+      @role.override_attributes({ :one => 'two' })
+      @role.override_attributes.should == { :one => 'two' }
+    end
+
+    it "should throw an ArgumentError if we aren't a kind of hash" do
+      lambda { @role.override_attributes(Array.new) }.should raise_error(ArgumentError)
+    end
+  end
+
+  describe "update_from!" do
+    before(:each) do
+      @role.name('mars_volta')
+      @role.description('Great band!')
+      @role.run_list('one', 'two', 'role[a]')
+      @role.default_attributes({ :el_groupo => 'nuevo' })
+      @role.override_attributes({ :deloused => 'in the comatorium' })
+
+      @example = Chef::Role.new
+      @example.name('newname')
+      @example.description('Really Great band!')
+      @example.run_list('alpha', 'bravo', 'role[alpha]')
+      @example.default_attributes({ :el_groupo => 'nuevo dos' })
+      @example.override_attributes({ :deloused => 'in the comatorium XOXO' })
+    end
+
+    it "should update all fields except for name" do
+      @role.update_from!(@example)
+      @role.name.should == "mars_volta"
+      @role.description.should == @example.description
+      @role.run_list.should == @example.run_list
+      @role.default_attributes.should == @example.default_attributes
+      @role.override_attributes.should == @example.override_attributes
+    end
+  end
+
+  describe "when serialized as JSON", :json => true do
+    before(:each) do
+      @role.name('mars_volta')
+      @role.description('Great band!')
+      @role.run_list('one', 'two', 'role[a]')
+      @role.default_attributes({ :el_groupo => 'nuevo' })
+      @role.override_attributes({ :deloused => 'in the comatorium' })
+      @serialized_role = Chef::JSONCompat.to_json(@role)
+    end
+
+    it "should serialize to a json hash" do
+      Chef::JSONCompat.to_json(@role).should match(/^\{.+\}$/)
+    end
+
+    it "includes the name in the JSON output" do
+      @serialized_role.should =~ /"name":"mars_volta"/
+    end
+
+    it "includes its description in the JSON" do
+      @serialized_role.should match(/"description":"Great band!"/)
+    end
+
+    it "should include 'default_attributes'" do
+      @serialized_role.should =~ /"default_attributes":\{"el_groupo":"nuevo"\}/
+    end
+
+    it "should include 'override_attributes'" do
+      @serialized_role.should =~ /"override_attributes":\{"deloused":"in the comatorium"\}/
+    end
+
+    it "should include 'run_list'" do
+      #Activesupport messes with Chef json formatting
+      #This test should pass with and without activesupport
+      @serialized_role.should =~ /"run_list":\["recipe\[one\]","recipe\[two\]","role\[a\]"\]/
+    end
+
+    describe "and it has per-environment run lists" do
+      before do
+        @role.env_run_lists("_default" => ['one', 'two', 'role[a]'], "production" => ['role[monitoring]', 'role[auditing]', 'role[apache]'], "dev" => ["role[nginx]"])
+        @serialized_role = Chef::JSONCompat.from_json(Chef::JSONCompat.to_json(@role), :create_additions => false)
+      end
+
+      it "includes the per-environment run lists" do
+        #Activesupport messes with Chef json formatting
+        #This test should pass with and without activesupport
+        @serialized_role["env_run_lists"]["production"].should == ['role[monitoring]', 'role[auditing]', 'role[apache]']
+        @serialized_role["env_run_lists"]["dev"].should == ["role[nginx]"]
+      end
+
+      it "does not include the default environment in the per-environment run lists" do
+        @serialized_role["env_run_lists"].should_not have_key("_default")
+      end
+
+    end
+  end
+
+  describe "when created from JSON", :json => true do
+    before(:each) do
+      @role.name('mars_volta')
+      @role.description('Great band!')
+      @role.run_list('one', 'two', 'role[a]')
+      @role.default_attributes({ 'el_groupo' => 'nuevo' })
+      @role.override_attributes({ 'deloused' => 'in the comatorium' })
+      @deserial = Chef::JSONCompat.from_json(Chef::JSONCompat.to_json(@role))
+    end
+
+    it "should deserialize to a Chef::Role object" do
+      @deserial.should be_a_kind_of(Chef::Role)
+    end
+
+    %w{
+      name
+      description
+      default_attributes
+      override_attributes
+      run_list
+    }.each do |t|
+      it "should preserves the '#{t}' attribute from the JSON object" do
+        @deserial.send(t.to_sym).should == @role.send(t.to_sym)
+      end
+    end
+  end
+
+  describe "when loading from disk" do
+    it "should return a Chef::Role object from JSON" do
+      File.should_receive(:exists?).with(File.join(Chef::Config[:role_path], 'lolcat.json')).exactly(1).times.and_return(true)
+      IO.should_receive(:read).with(File.join(Chef::Config[:role_path], 'lolcat.json')).and_return('{"name": "ceiling_cat", "json_class": "Chef::Role" }')
+      @role.should be_a_kind_of(Chef::Role)
+      @role.class.from_disk("lolcat")
+    end
+
+    it "should return a Chef::Role object from a Ruby DSL" do
+      File.should_receive(:exists?).with(File.join(Chef::Config[:role_path], 'lolcat.json')).exactly(1).times.and_return(false)
+      File.should_receive(:exists?).with(File.join(Chef::Config[:role_path], 'lolcat.rb')).exactly(2).times.and_return(true)
+      File.should_receive(:readable?).with(File.join(Chef::Config[:role_path], 'lolcat.rb')).exactly(1).times.and_return(true)
+      ROLE_DSL=<<-EOR
+name "ceiling_cat"
+description "like Aliens, but furry"
+EOR
+      IO.should_receive(:read).with(File.join(Chef::Config[:role_path], 'lolcat.rb')).and_return(ROLE_DSL)
+      @role.should be_a_kind_of(Chef::Role)
+      @role.class.from_disk("lolcat")
+    end
+
+    it "should raise an exception if the file does not exist" do
+      File.should_receive(:exists?).with(File.join(Chef::Config[:role_path], 'lolcat.json')).exactly(1).times.and_return(false)
+      File.should_receive(:exists?).with(File.join(Chef::Config[:role_path], 'lolcat.rb')).exactly(1).times.and_return(false)
+      lambda {@role.class.from_disk("lolcat")}.should raise_error(Chef::Exceptions::RoleNotFound)
+    end
+  end
+end
+

data/spec/unit/run_context_spec.rb

@@ -0,0 +1,64 @@
+#
+# Author:: Adam Jacob (<adam@opscode.com>)
+# Author:: Tim Hinderliter (<tim@opscode.com>)
+# Author:: Christopher Walters (<cw@opscode.com>)
+# Copyright:: Copyright (c) 2008, 2010 Opscode, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+# 
+#     http://www.apache.org/licenses/LICENSE-2.0
+# 
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'spec_helper'
+
+Chef::Log.level = :debug
+
+describe Chef::RunContext do
+  before(:each) do
+    Chef::Config.node_path(File.expand_path(File.join(CHEF_SPEC_DATA, "run_context", "nodes")))
+    @chef_repo_path = File.expand_path(File.join(CHEF_SPEC_DATA, "run_context", "cookbooks"))
+    @cookbook_collection = Chef::CookbookCollection.new(Chef::CookbookLoader.new(@chef_repo_path))
+    @node = Chef::Node.new
+    @node.find_file("run_context")
+    @events = Chef::EventDispatch::Dispatcher.new
+    @run_context = Chef::RunContext.new(@node, @cookbook_collection, @events)
+  end
+
+  it "has a cookbook collection" do
+    @run_context.cookbook_collection.should == @cookbook_collection
+  end
+
+  it "has a node" do
+    @run_context.node.should == @node
+  end
+
+  describe "after loading the cookbooks" do
+    before do
+      @run_context.load(@node.run_list.expand('_default'))
+    end
+
+    it "should load all the definitions in the cookbooks for this node" do
+      @run_context.definitions.should have_key(:new_cat)
+      @run_context.definitions.should have_key(:new_badger)
+      @run_context.definitions.should have_key(:new_dog)
+    end
+
+    it "should load all the recipes specified for this node" do
+      @run_context.resource_collection[0].to_s.should == "cat[einstein]"  
+      @run_context.resource_collection[1].to_s.should == "cat[loulou]"
+      @run_context.resource_collection[2].to_s.should == "cat[birthday]"
+      @run_context.resource_collection[3].to_s.should == "cat[peanut]"
+      @run_context.resource_collection[4].to_s.should == "cat[fat peanut]"
+    end
+  end
+
+end

data/spec/unit/run_list/run_list_expansion_spec.rb

@@ -0,0 +1,129 @@
+#
+# Author:: Daniel DeLeo (<dan@opscode.com>)
+# Copyright:: Copyright (c) 2010 Opscode, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'spec_helper'
+
+describe Chef::RunList::RunListExpansion do
+  before do
+    @run_list = Chef::RunList.new
+    @run_list << 'recipe[lobster]' << 'role[rage]' << 'recipe[fist]'
+    @expansion = Chef::RunList::RunListExpansion.new("_default", @run_list.run_list_items)
+  end
+
+  describe "before expanding the run list" do
+    it "has an array of run list items" do
+      @expansion.run_list_items.should == @run_list.run_list_items
+    end
+
+    it "has default_attrs" do
+      @expansion.default_attrs.should == Mash.new
+    end
+
+    it "has override attrs" do
+      @expansion.override_attrs.should == Mash.new
+    end
+
+    it "it has an empty list of recipes" do
+      @expansion.should have(0).recipes
+    end
+
+    it "has not applied its roles" do
+      @expansion.applied_role?('rage').should be_false
+    end
+  end
+
+  describe "after applying a role with environment-specific run lists" do
+    before do
+      @rage_role = Chef::Role.new.tap do |r|
+        r.name("rage")
+        r.env_run_lists('_default' => [], "prod" => ["recipe[prod-only]"])
+      end
+      @expansion = Chef::RunList::RunListExpansion.new("prod", @run_list.run_list_items)
+      @expansion.should_receive(:fetch_role).and_return(@rage_role)
+      @expansion.expand
+    end
+
+    it "has the correct list of recipes for the given environment" do
+      @expansion.recipes.should == ["lobster", "prod-only", "fist"]
+    end
+
+  end
+
+  describe "after applying a role" do
+    before do
+      @expansion.stub!(:fetch_role).and_return(Chef::Role.new)
+      @expansion.inflate_role('rage', "role[base]")
+    end
+
+    it "tracks the applied role" do
+      @expansion.applied_role?('rage').should be_true
+    end
+
+    it "does not inflate the role again" do
+      @expansion.inflate_role('rage', "role[base]").should be_false
+    end
+  end
+
+  describe "after expanding a run list" do
+    before do
+      @first_role = Chef::Role.new
+      @first_role.run_list('role[mollusk]')
+      @first_role.default_attributes({'foo' => 'bar'})
+      @first_role.override_attributes({'baz' => 'qux'})
+      @second_role = Chef::Role.new
+      @second_role.run_list('recipe[crabrevenge]')
+      @second_role.default_attributes({'foo' => 'boo'})
+      @second_role.override_attributes({'baz' => 'bux'})
+      @expansion.stub!(:fetch_role).and_return(@first_role, @second_role)
+      @expansion.expand
+    end
+
+    it "has the ordered list of recipes" do
+      @expansion.recipes.should == ['lobster', 'crabrevenge', 'fist']
+    end
+
+    it "has the merged attributes from the roles with outer roles overridding inner" do
+      @expansion.default_attrs.should == {'foo' => 'bar'}
+      @expansion.override_attrs.should == {'baz' => 'qux'}
+    end
+
+    it "has the list of all roles applied" do
+      # this is the correct order, but 1.8 hash order is not stable
+      @expansion.roles.should =~ ['rage', 'mollusk']
+    end
+
+  end
+
+  describe "after expanding a run list with a non existant role" do
+    before do
+      @expansion.stub!(:fetch_role) { @expansion.role_not_found('crabrevenge', "role[base]") }
+      @expansion.expand
+    end
+
+    it "is invalid" do
+      @expansion.should be_invalid
+      @expansion.errors?.should be_true # aliases
+    end
+
+    it "has a list of invalid role names" do
+      @expansion.errors.should include('crabrevenge')
+    end
+
+  end
+
+end