chef 10.12.0 → 10.14.0.beta.1

data/spec/unit/knife/cookbook_site_share_spec.rb

@@ -0,0 +1,146 @@
+#
+# Author:: Stephen Delano (<stephen@opscode.com>)
+# Copyright:: Copyright (c) 2010 Opscode, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'spec_helper'
+
+require 'chef/cookbook_uploader'
+require 'chef/cookbook_site_streaming_uploader'
+
+describe Chef::Knife::CookbookSiteShare do
+
+  before(:each) do
+    @knife = Chef::Knife::CookbookSiteShare.new
+    @knife.name_args = ['cookbook_name', 'AwesomeSausage']
+
+    @cookbook = Chef::CookbookVersion.new('cookbook_name')
+
+    @cookbook_loader = mock('Chef::CookbookLoader')
+    @cookbook_loader.stub!(:cookbook_exists?).and_return(true)
+    @cookbook_loader.stub!(:[]).and_return(@cookbook)
+    Chef::CookbookLoader.stub!(:new).and_return(@cookbook_loader)
+
+    @cookbook_uploader = Chef::CookbookUploader.new('herpderp', File.join(CHEF_SPEC_DATA, 'cookbooks'), :rest => "norest")
+    Chef::CookbookUploader.stub!(:new).and_return(@cookbook_uploader)
+    @cookbook_uploader.stub!(:validate_cookbook).and_return(true)
+    Chef::CookbookSiteStreamingUploader.stub!(:create_build_dir).and_return(Dir.mktmpdir)
+
+    Chef::Mixin::Command.stub(:run_command).and_return(true)
+    @stdout = StringIO.new
+    @knife.ui.stub!(:stdout).and_return(@stdout)
+  end
+
+  describe 'run' do
+
+    before(:each) do
+      @knife.stub!(:do_upload).and_return(true)
+    end
+
+    it 'should should print usage and exit when given no arguments' do
+      @knife.name_args = []
+      @knife.should_receive(:show_usage)
+      @knife.ui.should_receive(:fatal)
+      lambda { @knife.run }.should raise_error(SystemExit)
+    end
+
+    it 'should print usage and exit when given only 1 argument' do
+      @knife.name_args = ['cookbook_name']
+      @knife.should_receive(:show_usage)
+      @knife.ui.should_receive(:fatal)
+      lambda { @knife.run }.should raise_error(SystemExit)
+    end
+
+    it 'should check if the cookbook exists' do
+      @cookbook_loader.should_receive(:cookbook_exists?)
+      @knife.run
+    end
+
+    it "should exit and log to error if the cookbook doesn't exist" do
+      @cookbook_loader.stub(:cookbook_exists?).and_return(false)
+      @knife.ui.should_receive(:error)
+      lambda { @knife.run }.should raise_error(SystemExit)
+    end
+
+    it 'should make a tarball of the cookbook' do
+      Chef::Mixin::Command.should_receive(:run_command) { |args|
+        args[:command].should match /tar -czf/
+      }
+      @knife.run
+    end
+
+    it 'should exit and log to error when the tarball creation fails' do
+      Chef::Mixin::Command.stub!(:run_command).and_raise(Chef::Exceptions::Exec)
+      @knife.ui.should_receive(:error)
+      lambda { @knife.run }.should raise_error(SystemExit)
+    end
+
+    it 'should upload the cookbook and clean up the tarball' do
+      @knife.should_receive(:do_upload)
+      FileUtils.should_receive(:rm_rf)
+      @knife.run
+    end
+  end
+
+  describe 'do_upload' do
+
+    before(:each) do
+      @upload_response = mock('Net::HTTPResponse')
+      Chef::CookbookSiteStreamingUploader.stub!(:post).and_return(@upload_response)
+
+      @stdout = StringIO.new
+      @stderr = StringIO.new
+      @knife.ui.stub!(:stdout).and_return(@stdout)
+      @knife.ui.stub!(:stderr).and_return(@stderr)
+      File.stub(:open).and_return(true)
+    end
+
+    it 'should post the cookbook to "http://cookbooks.opscode.com"' do
+      response_text = {:uri => 'http://cookbooks.opscode.com/cookbooks/cookbook_name'}.to_json
+      @upload_response.stub!(:body).and_return(response_text)
+      @upload_response.stub!(:code).and_return(201)
+      Chef::CookbookSiteStreamingUploader.should_receive(:post).with(/cookbooks\.opscode\.com/, anything(), anything(), anything())
+      @knife.run
+    end
+
+    it 'should alert the user when a version already exists' do
+      response_text = {:error_messages => ['Version already exists']}.to_json
+      @upload_response.stub!(:body).and_return(response_text)
+      @upload_response.stub!(:code).and_return(409)
+      lambda { @knife.run }.should raise_error(SystemExit)
+      @stderr.string.should match(/ERROR(.+)cookbook already exists/)
+    end
+
+    it 'should pass any errors on to the user' do
+      response_text = {:error_messages => ["You're holding it wrong"]}.to_json
+      @upload_response.stub!(:body).and_return(response_text)
+      @upload_response.stub!(:code).and_return(403)
+      lambda { @knife.run }.should raise_error(SystemExit)
+      @stderr.string.should match("ERROR(.*)You're holding it wrong")
+    end
+
+    it 'should print the body if no errors are exposed on failure' do
+      response_text = {:system_error => "Your call was dropped", :reason => "There's a map for that"}.to_json
+      @upload_response.stub!(:body).and_return(response_text)
+      @upload_response.stub!(:code).and_return(500)
+      @knife.ui.should_receive(:error).with(/#{Regexp.escape(response_text)}/)#.ordered
+      @knife.ui.should_receive(:error).with(/Unknown error/)#.ordered
+      lambda { @knife.run }.should raise_error(SystemExit)
+    end
+
+  end
+
+end

data/spec/unit/knife/cookbook_site_unshare_spec.rb

@@ -0,0 +1,77 @@
+#
+# Author:: Stephen Delano (<stephen@opscode.com>)
+# Author:: Tim Hinderliter (<tim@opscode.com>)
+# Copyright:: Copyright (c) 2010 Opscode, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'spec_helper'
+
+describe Chef::Knife::CookbookSiteUnshare do
+
+  before(:each) do
+    @knife = Chef::Knife::CookbookSiteUnshare.new
+    @knife.name_args = ['cookbook_name']
+    @knife.stub!(:confirm).and_return(true)
+
+    @rest = mock('Chef::REST')
+    @rest.stub!(:delete_rest).and_return(true)
+    @knife.stub!(:rest).and_return(@rest)
+    @stdout = StringIO.new
+    @knife.ui.stub!(:stdout).and_return(@stdout)
+  end
+
+  describe 'run' do
+
+    describe 'with no cookbook argument' do
+      it 'should print the usage and exit' do
+        @knife.name_args = []
+        @knife.ui.should_receive(:fatal)
+        @knife.should_receive(:show_usage)
+        lambda { @knife.run }.should raise_error(SystemExit)
+      end
+    end
+
+    it 'should confirm you want to unshare the cookbook' do
+      @knife.should_receive(:confirm)
+      @knife.run
+    end
+
+    it 'should send a delete request to the cookbook site' do
+      @rest.should_receive(:delete_rest)
+      @knife.run
+    end
+
+    it 'should log an error and exit when forbidden' do
+      exception = mock('403 "Forbidden"', :code => '403')
+      @rest.stub!(:delete_rest).and_raise(Net::HTTPServerException.new('403 "Forbidden"', exception))
+      @knife.ui.should_receive(:error)
+      lambda { @knife.run }.should raise_error(SystemExit)
+    end
+
+    it 'should re-raise any non-forbidden errors on delete_rest' do
+      exception = mock('500 "Application Error"', :code => '500')
+      @rest.stub(:delete_rest).and_raise(Net::HTTPServerException.new('500 "Application Error"', exception))
+      lambda { @knife.run }.should raise_error(Net::HTTPServerException)
+    end
+
+    it 'should log a success message' do
+      @knife.ui.should_receive(:info)
+      @knife.run
+    end
+
+  end
+
+end

data/spec/unit/knife/cookbook_test_spec.rb

@@ -0,0 +1,83 @@
+#
+# Author:: Stephen Delano (<stephen@opscode.com>)$
+# Author:: Matthew Kent (<mkent@magoazul.com>)
+# Copyright:: Copyright (c) 2010 Opscode, Inc.$
+# Copyright:: Copyright (c) 2010 Matthew Kent
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'spec_helper'
+Chef::Knife::CookbookTest.load_deps
+
+describe Chef::Knife::CookbookTest do
+  before(:each) do
+    Chef::Config[:node_name]  = "webmonkey.example.com"
+    @knife = Chef::Knife::CookbookTest.new
+    @knife.config[:cookbook_path] = File.join(CHEF_SPEC_DATA,'cookbooks')
+    @knife.cookbook_loader.stub!(:cookbook_exists?).and_return(true)
+    @cookbooks = []
+    %w{tats central_market jimmy_johns pho}.each do |cookbook_name|
+      @cookbooks << Chef::CookbookVersion.new(cookbook_name)
+    end
+    @stdout = StringIO.new
+    @knife.ui.stub!(:stdout).and_return(@stdout)
+  end
+
+  describe "run" do
+    it "should test the cookbook" do
+      @knife.stub!(:test_cookbook).and_return(true)
+      @knife.name_args = ["italian"]
+      @knife.should_receive(:test_cookbook).with("italian")
+      @knife.run
+    end
+
+    it "should test multiple cookbooks when provided" do
+      @knife.stub!(:test_cookbook).and_return(true)
+      @knife.name_args = ["tats", "jimmy_johns"]
+      @knife.should_receive(:test_cookbook).with("tats")
+      @knife.should_receive(:test_cookbook).with("jimmy_johns")
+      @knife.should_not_receive(:test_cookbook).with("central_market")
+      @knife.should_not_receive(:test_cookbook).with("pho")
+      @knife.run
+    end
+
+    it "should test both ruby and templates" do
+      @knife.name_args = ["example"]
+      @knife.config[:cookbook_path].should_not be_empty
+      Array(@knife.config[:cookbook_path]).reverse.each do |path|
+        @knife.should_receive(:test_ruby).with(an_instance_of(Chef::Cookbook::SyntaxCheck))
+        @knife.should_receive(:test_templates).with(an_instance_of(Chef::Cookbook::SyntaxCheck))
+      end
+      @knife.run
+    end
+
+    describe "with -a or --all" do
+      it "should test all of the cookbooks" do
+        @knife.stub!(:test_cookbook).and_return(true)
+        @knife.config[:all] = true
+        @loader = {}
+        @cookbooks.each do |cookbook|
+          @loader[cookbook.name] = cookbook
+        end
+        @knife.stub!(:cookbook_loader).and_return(@loader)
+        @loader.each do |key, cookbook|
+          @knife.should_receive(:test_cookbook).with(cookbook.name)
+        end
+        @knife.run
+      end
+    end
+
+  end
+end

data/spec/unit/knife/cookbook_upload_spec.rb

@@ -0,0 +1,143 @@
+#
+# Author:: Matthew Kent (<mkent@magoazul.com>)
+# Author:: Steven Danna (<steve@opscode.com>)
+# Copyright:: Copyright (c) 2012 Opscode, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require File.expand_path(File.join(File.dirname(__FILE__), "..", "..", "spec_helper"))
+
+require 'chef/cookbook_uploader'
+require 'timeout'
+
+describe Chef::Knife::CookbookUpload do
+  before(:each) do
+    @knife = Chef::Knife::CookbookUpload.new
+    @knife.name_args = ['test_cookbook']
+
+    @cookbook = Chef::CookbookVersion.new('test_cookbook')
+
+    @cookbook_loader = {}
+    @cookbook_loader.stub!(:[]).and_return(@cookbook)
+    @cookbook_loader.stub!(:merged_cookbooks).and_return([])
+    Chef::CookbookLoader.stub!(:new).and_return(@cookbook_loader)
+
+    @output = StringIO.new
+    @knife.ui.stub!(:stdout).and_return(@output)
+    @knife.ui.stub!(:stderr).and_return(@output)
+  end
+
+  describe 'run' do
+    before(:each) do
+      @knife.stub!(:upload).and_return(true)
+      Chef::CookbookVersion.stub(:list_all_versions).and_return({})
+    end
+
+    it 'should print usage and exit when a cookbook name is not provided' do
+      @knife.name_args = []
+      @knife.should_receive(:show_usage)
+      @knife.ui.should_receive(:fatal)
+      lambda { @knife.run }.should raise_error(SystemExit)
+    end
+
+    describe 'when specifying a cookbook name' do
+      it 'should upload the cookbook' do
+        @knife.should_receive(:upload).once
+        @knife.run
+      end
+
+      it 'should report on success' do
+        @knife.should_receive(:upload).once
+        @knife.ui.should_receive(:info).with(/Uploaded 1 cookbook/)
+        @knife.run
+      end
+    end
+
+    # This is testing too much.  We should break it up.
+    describe 'when specifying a cookbook name with dependencies' do
+      it "should upload all dependencies once" do
+        @knife.name_args = ["test_cookbook2"]
+        @knife.config[:depends] = true
+        @test_cookbook1 = Chef::CookbookVersion.new('test_cookbook1')
+        @test_cookbook2 = Chef::CookbookVersion.new('test_cookbook2')
+        @test_cookbook3 = Chef::CookbookVersion.new('test_cookbook3')
+        @test_cookbook2.metadata.depends("test_cookbook3")
+        @test_cookbook3.metadata.depends("test_cookbook1")
+        @test_cookbook3.metadata.depends("test_cookbook2")
+        @cookbook_loader.stub!(:[])  do |ckbk|
+          { "test_cookbook1" =>  @test_cookbook1,
+            "test_cookbook2" =>  @test_cookbook2,
+            "test_cookbook3" => @test_cookbook3 }[ckbk]
+        end
+        @knife.should_receive(:upload).exactly(3).times
+        Timeout::timeout(5) do
+          @knife.run
+        end.should_not raise_error(Timeout::Error)
+      end
+    end
+
+    it "should freeze the version of the cookbooks if --freeze is specified" do
+      @knife.config[:freeze] = true
+      @cookbook.should_receive(:freeze_version).once
+      @knife.run
+    end
+
+    describe 'with -a or --all' do
+      before(:each) do
+        @knife.config[:all] = true
+        @test_cookbook1 = Chef::CookbookVersion.new('test_cookbook1')
+        @test_cookbook2 = Chef::CookbookVersion.new('test_cookbook2')
+        @cookbook_loader.stub!(:each).and_yield("test_cookbook1", @test_cookbook1).and_yield("test_cookbook2", @test_cookbook2)
+        @cookbook_loader.stub!(:cookbook_names).and_return(["test_cookbook1", "test_cookbook2"])
+      end
+
+      it 'should upload all cookbooks' do
+        @knife.should_receive(:upload).twice
+        @knife.run
+      end
+
+      it 'should report on success' do
+        @knife.should_receive(:upload).twice
+        @knife.ui.should_receive(:info).with(/Uploaded 2 cookbooks/)
+        @knife.run
+      end
+
+      it 'should update the version constraints for an environment' do
+        @knife.stub!(:assert_environment_valid!).and_return(true)
+        @knife.config[:environment] = "production"
+        @knife.should_receive(:update_version_constraints).once
+        @knife.run
+      end
+    end
+
+    describe 'when a frozen cookbook exists on the server' do
+      it 'should fail to replace it' do
+        @knife.stub!(:upload).and_raise(Chef::Exceptions::CookbookFrozen)
+        @knife.ui.should_receive(:error).with(/Failed to upload 1 cookbook/)
+        lambda { @knife.run }.should raise_error(SystemExit)
+      end
+
+      it 'should not update the version constraints for an environment' do
+        @knife.stub!(:assert_environment_valid!).and_return(true)
+        @knife.config[:environment] = "production"
+        @knife.stub!(:upload).and_raise(Chef::Exceptions::CookbookFrozen)
+        @knife.ui.should_receive(:error).with(/Failed to upload 1 cookbook/)
+        @knife.ui.should_receive(:warn).with(/Not updating version constraints/)
+        @knife.should_not_receive(:update_version_constraints)
+        lambda { @knife.run }.should raise_error(SystemExit)
+      end
+    end
+  end
+end # run