chef 10.12.0 → 10.14.0.beta.1

data/spec/unit/version_class_spec.rb

@@ -0,0 +1,172 @@
+#
+# Author:: Seth Falcon (<seth@opscode.com>)
+# Copyright:: Copyright (c) 2010 Opscode, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+# 
+#     http://www.apache.org/licenses/LICENSE-2.0
+# 
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+require 'spec_helper'
+require 'chef/version_class'
+
+describe Chef::Version do
+  before do
+    @v0 = Chef::Version.new "0.0.0"
+    @v123 = Chef::Version.new "1.2.3"
+  end
+
+  it "should turn itself into a string" do
+    @v0.to_s.should == "0.0.0"
+    @v123.to_s.should == "1.2.3"
+  end
+  
+  it "should make a round trip with its string representation" do
+    a = Chef::Version.new(@v123.to_s)
+    a.should == @v123
+  end
+  
+  it "should transform 1.2 to 1.2.0" do
+    Chef::Version.new("1.2").to_s.should == "1.2.0"
+  end
+
+  it "should transform 01.002.0003 to 1.2.3" do
+    a = Chef::Version.new "01.002.0003"
+    a.should == @v123
+  end
+
+  describe "when creating valid Versions" do
+    good_versions = %w(1.2 1.2.3 1000.80.50000 0.300.25 001.02.00003)
+    good_versions.each do |v|
+      it "should accept '#{v}'" do
+        Chef::Version.new v
+      end
+    end
+  end
+
+  describe "when given bogus input" do
+    bad_versions = ["1.2.3.4", "1.2.a4", "1", "a", "1.2 3", "1.2 a",
+                    "1 2 3", "1-2-3", "1_2_3", "1.2_3", "1.2-3"]
+    the_error = Chef::Exceptions::InvalidCookbookVersion
+    bad_versions.each do |v|
+      it "should raise #{the_error} when given '#{v}'" do
+        lambda { Chef::Version.new v }.should raise_error(the_error)
+      end
+    end
+  end
+
+  describe "<=>" do
+
+    it "should equate versions 1.2 and 1.2.0" do
+      Chef::Version.new("1.2").should == Chef::Version.new("1.2.0")
+    end
+
+    it "should equate version 1.04 and 1.4" do
+      Chef::Version.new("1.04").should == Chef::Version.new("1.4")
+    end
+
+    it "should treat versions as numbers in the right way" do
+      Chef::Version.new("2.0").should be < Chef::Version.new("11.0")
+    end
+
+    it "should sort based on the version number" do
+      examples = [
+                  # smaller, larger
+                  ["1.0", "2.0"],
+                  ["1.2.3", "1.2.4"],
+                  ["1.2.3", "1.3.0"],
+                  ["1.2.3", "1.3"],
+                  ["1.2.3", "2.1.1"],
+                  ["1.2.3", "2.1"],
+                  ["1.2", "1.2.4"],
+                  ["1.2", "1.3.0"],
+                  ["1.2", "1.3"],
+                  ["1.2", "2.1.1"],
+                  ["1.2", "2.1"]
+                 ]
+      examples.each do |smaller, larger|
+        sm = Chef::Version.new(smaller)
+        lg = Chef::Version.new(larger)
+        sm.should be < lg
+        lg.should be > sm
+        sm.should_not == lg
+      end
+    end
+
+    it "should sort an array of versions" do
+      a = %w{0.0.0 0.0.1 0.1.0 0.1.1 1.0.0 1.1.0 1.1.1}.map do |s|
+        Chef::Version.new(s)
+      end
+      got = a.sort.map {|v| v.to_s }
+      got.should == %w{0.0.0 0.0.1 0.1.0 0.1.1 1.0.0 1.1.0 1.1.1}
+    end
+
+    it "should sort an array of versions, part 2" do
+      a = %w{9.8.7 1.0.0 1.2.3 4.4.6 4.5.6 0.8.6 4.5.5 5.9.8 3.5.7}.map do |s|
+        Chef::Version.new(s)
+      end
+      got = a.sort.map { |v| v.to_s }
+      got.should == %w{0.8.6 1.0.0 1.2.3 3.5.7 4.4.6 4.5.5 4.5.6 5.9.8 9.8.7}
+    end
+
+    describe "comparison examples" do
+      [ 
+       [ "0.0.0", :>, "0.0.0", false ],
+       [ "0.0.0", :>=, "0.0.0", true ],
+       [ "0.0.0", :==, "0.0.0", true ],
+       [ "0.0.0", :<=, "0.0.0", true ],
+       [ "0.0.0", :<, "0.0.0", false ],
+       [ "0.0.0", :>, "0.0.1", false ],
+       [ "0.0.0", :>=, "0.0.1", false ],
+       [ "0.0.0", :==, "0.0.1", false ],
+       [ "0.0.0", :<=, "0.0.1", true ],
+       [ "0.0.0", :<, "0.0.1", true ],
+       [ "0.0.1", :>, "0.0.1", false ],
+       [ "0.0.1", :>=, "0.0.1", true ],
+       [ "0.0.1", :==, "0.0.1", true ],
+       [ "0.0.1", :<=, "0.0.1", true ],
+       [ "0.0.1", :<, "0.0.1", false ],
+       [ "0.1.0", :>, "0.1.0", false ],
+       [ "0.1.0", :>=, "0.1.0", true ],
+       [ "0.1.0", :==, "0.1.0", true ],
+       [ "0.1.0", :<=, "0.1.0", true ],
+       [ "0.1.0", :<, "0.1.0", false ],
+       [ "0.1.1", :>, "0.1.1", false ],
+       [ "0.1.1", :>=, "0.1.1", true ],
+       [ "0.1.1", :==, "0.1.1", true ],
+       [ "0.1.1", :<=, "0.1.1", true ],
+       [ "0.1.1", :<, "0.1.1", false ],
+       [ "1.0.0", :>, "1.0.0", false ],
+       [ "1.0.0", :>=, "1.0.0", true ],
+       [ "1.0.0", :==, "1.0.0", true ],
+       [ "1.0.0", :<=, "1.0.0", true ],
+       [ "1.0.0", :<, "1.0.0", false ],
+       [ "1.0.0", :>, "0.0.1", true ],
+       [ "1.0.0", :>=, "1.9.2", false ],
+       [ "1.0.0", :==, "9.7.2", false ],
+       [ "1.0.0", :<=, "1.9.1", true ],
+       [ "1.0.0", :<, "1.9.0", true ],
+       [ "1.2.2", :>, "1.2.1", true ],
+       [ "1.2.2", :>=, "1.2.1", true ],
+       [ "1.2.2", :==, "1.2.1", false ],
+       [ "1.2.2", :<=, "1.2.1", false ],
+       [ "1.2.2", :<, "1.2.1", false ]
+      ].each do |spec|
+        it "(#{spec.first(3).join(' ')}) should be #{spec[3]}" do
+          got = Chef::Version.new(spec[0]).send(spec[1],
+                                                Chef::Version.new(spec[2]))
+          got.should == spec[3]
+        end
+      end
+    end
+  end
+end
+

data/spec/unit/version_constraint_spec.rb

@@ -0,0 +1,134 @@
+#
+# Author:: Seth Falcon (<seth@opscode.com>)
+# Copyright:: Copyright 2010 Opscode, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+require 'spec_helper'
+require 'chef/version_constraint'
+
+describe Chef::VersionConstraint do
+  describe "validation" do
+    bad_version = ["> >", ">= 1.2.z", "> 1.2.3 < 5.0", "> 1.2.3, < 5.0"]
+    bad_op = ["<3.0.1", ">$ 1.2.3", "! 3.4"]
+    o_error = Chef::Exceptions::InvalidVersionConstraint
+    v_error = Chef::Exceptions::InvalidCookbookVersion
+    bad_version.each do |s|
+      it "should raise #{v_error} when given #{s}" do
+        lambda { Chef::VersionConstraint.new s }.should raise_error(v_error)
+      end
+    end
+    bad_op.each do |s|
+      it "should raise #{o_error} when given #{s}" do
+        lambda { Chef::VersionConstraint.new s }.should raise_error(o_error)
+      end
+    end
+
+    it "should interpret a lone version number as implicit = OP" do
+      vc = Chef::VersionConstraint.new("1.2.3")
+      vc.to_s.should == "= 1.2.3"
+    end
+
+    it "should allow initialization with [] for back compatibility" do
+      Chef::VersionConstraint.new([]) == Chef::VersionConstraint.new
+    end
+
+    it "should allow initialization with ['1.2.3'] for back compatibility" do
+      Chef::VersionConstraint.new(["1.2"]) == Chef::VersionConstraint.new("1.2")
+    end
+
+  end
+
+  it "should default to >= 0.0.0" do
+    vc = Chef::VersionConstraint.new
+    vc.to_s.should == ">= 0.0.0"
+  end
+
+  it "should default to >= 0.0.0 when initialized with nil" do
+    Chef::VersionConstraint.new(nil).to_s.should == ">= 0.0.0"
+  end
+
+  describe "include?" do
+    describe "handles various input data types" do
+      before do
+        @vc = Chef::VersionConstraint.new "> 1.2.3"
+      end
+      it "String" do
+        @vc.should include "1.4"
+      end
+      it "Chef::Version" do
+        @vc.should include Chef::Version.new("1.4")
+      end
+      it "Chef::CookbookVersion" do
+        cv = Chef::CookbookVersion.new("alice")
+        cv.version = "1.4"
+        @vc.should include cv
+      end
+    end
+
+    it "strictly less than" do
+      vc = Chef::VersionConstraint.new "< 1.2.3"
+      vc.should_not include "1.3.0"
+      vc.should_not include "1.2.3"
+      vc.should include "1.2.2"
+    end
+
+    it "strictly greater than" do
+      vc = Chef::VersionConstraint.new "> 1.2.3"
+      vc.should include "1.3.0"
+      vc.should_not include "1.2.3"
+      vc.should_not include "1.2.2"
+    end
+
+    it "less than or equal to" do
+      vc = Chef::VersionConstraint.new "<= 1.2.3"
+      vc.should_not include "1.3.0"
+      vc.should include "1.2.3"
+      vc.should include "1.2.2"
+    end
+
+    it "greater than or equal to" do
+      vc = Chef::VersionConstraint.new ">= 1.2.3"
+      vc.should include "1.3.0"
+      vc.should include "1.2.3"
+      vc.should_not include "1.2.2"
+    end
+
+    it "equal to" do
+      vc = Chef::VersionConstraint.new "= 1.2.3"
+      vc.should_not include "1.3.0"
+      vc.should include "1.2.3"
+      vc.should_not include "0.3.0"
+    end
+
+    it "pessimistic ~> x.y.z" do
+      vc = Chef::VersionConstraint.new "~> 1.2.3"
+      vc.should include "1.2.3"
+      vc.should include "1.2.4"
+
+      vc.should_not include "1.2.2"
+      vc.should_not include "1.3.0"
+      vc.should_not include "2.0.0"
+    end
+
+    it "pessimistic ~> x.y" do
+      vc = Chef::VersionConstraint.new "~> 1.2"
+      vc.should include "1.3.3"
+      vc.should include "1.4"
+
+      vc.should_not include "2.2"
+      vc.should_not include "0.3.0"
+    end
+  end
+end

data/spec/unit/webui_user_spec.rb

@@ -0,0 +1,238 @@
+#
+# Author:: Daniel DeLeo (<dan@kallistec.com>)
+# Copyright:: Copyright (c) 2009 Daniel DeLeo
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+# 
+#     http://www.apache.org/licenses/LICENSE-2.0
+# 
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'spec_helper'
+
+describe Chef::WebUIUser do
+  
+  before do
+    @webui_user = Chef::WebUIUser.new
+  end
+  
+  it "stores the admin status of the user" do
+    @webui_user.admin.should be_false
+    @webui_user.admin = true
+    @webui_user.admin.should be_true
+    @webui_user.should be_admin
+  end
+  
+  it "stores the name with underscores subbed for dots" do
+    @webui_user.name.should be_nil
+    @webui_user.name = "foo.bar.baz"
+    @webui_user.name.should == "foo_bar_baz"
+  end
+  
+  it "can be initialized with a hash to set instance variables" do
+    opt_hsh = {'name'=>'mud', 'salt'=>'just_a_lil', 'password'=>'beefded',
+              'openid'=>'notsomuch', '_rev'=>'0', '_id'=>'tehid'}
+    webui_user = Chef::WebUIUser.new(opt_hsh)
+    webui_user.name.should        == 'mud'
+    webui_user.salt.should        == 'just_a_lil'
+    webui_user.password.should    == 'beefded'
+    webui_user.openid.should      == 'notsomuch'
+    webui_user.couchdb_rev.should == '0'
+    webui_user.couchdb_id.should  == 'tehid'
+  end
+  
+  describe "when setting or verifying a password" do
+    it "raises an error when the password doesn't match the confirmation password" do
+      lambda {@webui_user.set_password("nomnomnom", "yukyukyuk")}.should raise_error(ArgumentError, /do not match/)
+    end
+    
+    it "doesn't allow blank passwords" do
+      lambda {@webui_user.set_password("", "")}.should raise_error(ArgumentError, /cannot be blank/)
+    end
+    
+    it "doesn't allow passwords less than 6 characters" do
+      lambda {@webui_user.set_password("2shrt", "2shrt")}.should raise_error(ArgumentError, /minimum of 6 characters/)
+    end
+    
+    it "generates a salt and hashes the password when the password is valid" do
+      @webui_user.set_password("valid_pw", "valid_pw")
+      @webui_user.salt.should_not be_nil
+      @webui_user.password.should match(/[0-9a-f]{32}/)
+    end
+    
+    it "verifies a correct password" do
+      @webui_user.set_password("valid_pw", "valid_pw")
+      @webui_user.verify_password("valid_pw").should be_true
+    end
+    
+    it "doesn't verify an incorrect password" do
+      @webui_user.set_password("valid_pw", "valid_pw")
+      @webui_user.verify_password("invalid_pw").should be_false
+    end
+  end
+  
+  describe "when doing CRUD operations via API" do
+    before do
+      @webui_user.name = "test_user"
+      @rest = mock("Chef::REST")
+      Chef::REST.stub!(:new).and_return(@rest)
+    end
+    
+    it "finds users by name via GET" do
+      @rest.should_receive(:get_rest).with("users/mud")
+      Chef::WebUIUser.load("mud")
+    end
+    
+    it "finds all ids in the database via GET" do
+      @rest.should_receive(:get_rest).with("users")
+      Chef::WebUIUser.list
+    end
+    
+    it "finds all documents in the database via GET" do
+      robots  = Chef::WebUIUser.new("name"=>"we_robots")
+      happy   = Chef::WebUIUser.new("name"=>"are_happy_robots")
+      query_results = [robots,happy]
+      query_obj = mock("Chef::Search::Query")
+      query_obj.should_receive(:search).with(:user).and_yield(query_results.first).and_yield(query_results.last)
+      Chef::Search::Query.stub!(:new).and_return(query_obj)
+      Chef::WebUIUser.list(true).should == {"we_robots" => robots, "are_happy_robots" => happy}
+    end
+    
+    it "updates via PUT when saving" do
+      @rest.should_receive(:put_rest).with("users/test_user", @webui_user)
+      @webui_user.save
+    end
+    
+    it "falls back to creating via POST if updating returns 404" do
+      response = mock("Net::HTTPResponse", :code => "404")
+      not_found = Net::HTTPServerException.new("404", response)
+      @rest.should_receive(:put_rest).with("users/test_user", @webui_user).and_raise(not_found)
+      @rest.should_receive(:post_rest).with("users", @webui_user)
+      @webui_user.save
+    end
+    
+    it "creates via POST" do
+      @rest.should_receive(:post_rest).with("users", @webui_user)
+      @webui_user.create
+    end
+    
+    it "deletes itself with DELETE" do
+      @rest.should_receive(:delete_rest).with("users/test_user")
+      @webui_user.destroy
+    end
+  end
+  
+  describe "when doing CRUD operations to the DB" do
+    before do
+      @webui_user.name = "relaxed_test"
+      @couchdb = mock("Chef::Couchdb")
+      Chef::CouchDB.stub(:new).and_return(@couchdb)
+      @webui_user.instance_variable_set(:@couchdb, @couchdb)
+    end
+    
+    it "finds users by name" do
+      @couchdb.should_receive(:load).with("webui_user", "test_user")
+      Chef::WebUIUser.cdb_load("test_user")
+    end
+    
+    it "finds all ids in the database" do
+      couch_rows = {"one"=>"mos_def","two"=>"and","three"=>"talib_kweli"}.map do |key, val|
+        {"key" => key, "value" => val}
+      end
+      couch_return_val = {"rows" => couch_rows}
+      @couchdb.should_receive(:list).with("users", false).and_return(couch_return_val)
+      Chef::WebUIUser.cdb_list.sort.should == %w{one two three}.sort
+    end
+    
+    it "finds all documents in the database" do
+      couch_rows = {"one"=>"mos_def","two"=>"and","three"=>"talib_kweli"}.map do |key, val|
+        {"key" => key, "value" => val}
+      end
+      couch_return_val = {"rows" => couch_rows}
+      @couchdb.should_receive(:list).with("users", true).and_return(couch_return_val)
+      Chef::WebUIUser.cdb_list(true).sort.should == %w{mos_def and talib_kweli}.sort
+    end
+    
+    it "updates and saves documents" do
+      @couchdb.should_receive(:store).with("webui_user", "relaxed_test", @webui_user).and_return("rev"=>"run")
+      @webui_user.cdb_save
+      @webui_user.couchdb_rev.should == "run"
+    end
+    
+    it "deletes itself" do
+      @webui_user = Chef::WebUIUser.new("_rev" => "run", "name" => "relaxed_test")
+      @couchdb.should_receive(:delete).with("webui_user", "relaxed_test", "run")
+      @webui_user.cdb_destroy
+    end
+  end
+  
+  describe "when converting to/from JSON" do
+    before do
+      @webui_user.name = "test_user"
+    end
+    
+    it "keeps type data so it can be deserialized" do
+      @webui_user.to_json.should match(Regexp.escape('"json_class":"Chef::WebUIUser"'))
+    end
+    
+    it "includes the name, salt, password, openid and admin status" do
+      @webui_user = Chef::WebUIUser.new("name"=>"test_user","password"=>"pw","salt"=>"pirate","openid"=>"really?")
+      @webui_user.admin = true
+      json = @webui_user.to_json
+      
+      json.should match(Regexp.escape('"name":"test_user"'))
+      json.should match(Regexp.escape('"password":"pw"'))
+      json.should match(Regexp.escape('"salt":"pirate"'))
+      json.should match(Regexp.escape('"openid":"really?"'))
+      json.should match(Regexp.escape('"admin":true'))
+    end
+    
+    it "includes the couchdb _rev if available" do
+      @webui_user = Chef::WebUIUser.new("_rev"=>"RuN")
+      json = @webui_user.to_json
+      json.should match(Regexp.escape('"_rev":"RuN"'))
+    end
+    
+    it "includes the couchdb _id if available" do
+      @webui_user = Chef::WebUIUser.new("_id"=>"ego")
+      json = @webui_user.to_json
+      json.should match(Regexp.escape('"_id":"ego"'))
+    end
+  end
+  
+  describe "behaving like a couch-able (relaxed?) object (cf CHEF-864)" do
+    it "has an attr reader for couchdb_id" do
+      @webui_user.should_not respond_to(:couchdb_id=)
+      @webui_user.should respond_to(:couchdb_id)
+      @webui_user.instance_variable_set(:@couchdb_id, "a big long UUID")
+      @webui_user.couchdb_id.should == "a big long UUID"
+    end
+    
+    it "sets its couchdb id when loading from the database" do
+      # reqs via REST eventually get to Chef::JSONCompat.from_json
+      webui_user = Chef::JSONCompat.from_json('{"salt":null,"name":"test_user","json_class":"Chef::WebUIUser","admin":false,"openid":null,"password":null,"chef_type":"webui_user","_id":"IdontNeedNoID"}')
+      webui_user.couchdb_id.should == "IdontNeedNoID"
+    end
+    
+    it "has an attr reader for couchdb_rev" do
+      @webui_user.should_not respond_to(:couchdb_rev=)
+      @webui_user.should respond_to(:couchdb_rev)
+      @webui_user.instance_variable_set(:@couchdb_rev, "a couchdb version string")
+      @webui_user.couchdb_rev.should == "a couchdb version string"
+    end
+    
+    it "sets the couchdb_rev when loading from the database" do
+      webui_user = Chef::JSONCompat.from_json('{"salt":null,"name":"test_user","json_class":"Chef::WebUIUser","admin":false,"openid":null,"password":null,"chef_type":"webui_user","_id":"IdontNeedNoID","_rev":"moto"}')
+      webui_user.couchdb_rev.should == "moto"
+    end
+  end
+  
+end