card 1.17.4 → 1.18.0

data/mod/05_standard/spec/set/type/html_spec.rb

@@ -5,19 +5,24 @@ describe Card::Set::Type::Html do
     Card::Auth.current_id = Card::WagnBotID
   end
 
-  it "should have special editor" do
+  it 'has special editor' do
     assert_view_select render_editor('Html'), 'textarea[rows="5"]'
   end
 
-  it "should not render any content in closed view" do
-    expect(render_card(:closed_content, type: 'Html', content: "<strong>Lions and Tigers</strong>")).to eq('')
+  it 'does not render any content in closed view' do
+    rendered = render_card :closed_content,
+                           type: 'Html',
+                           content: '<strong>Lions and Tigers</strong>'
+    expect(rendered).to eq('')
   end
 
-  it "should render inclusions" do
-    expect(render_card( :core, type: 'HTML', content: '{{a}}' )).to match(/slot/)
+  it 'renders nests' do
+    rendered = render_card :core, type: 'HTML', content: '{{a}}'
+    expect(rendered).to match(/slot/)
   end
 
-  it 'should not render uris' do
-    expect(render_card( :core, type: 'HTML', content: 'http://google.com' )).not_to match(/\<a/)
+  it 'does not render uris' do
+    rendered = render_card :core, type: 'HTML', content: 'http://google.com'
+    expect(rendered).not_to match(/\<a/)
   end
 end

data/mod/05_standard/spec/set/type/image_spec.rb

@@ -1,90 +1,97 @@
-# -*- encoding : utf-8 -*-require "image_spec"
-
+# -*- encoding : utf-8 -*-require 'image_spec'
 
 describe Card::Set::Type::Image do
-  it "has special editor" do
+  it 'has special editor' do
     assert_view_select render_editor('Image'), 'div[class="choose-file"]' do
       assert_select 'input[class~="file-upload slotter"]'
     end
   end
 
-  it "handles size argument in inclusion syntax" do
-    file = File.new(File.join FIXTURES_PATH, 'mao2.jpg')
+  it 'handles size argument in nest syntax' do
+    file = File.new File.join(FIXTURES_PATH, 'mao2.jpg')
     image_card = Card.create! name: 'TestImage', type: 'Image', image: file
-    including_card = Card.new name: 'Image1', content: "{{TestImage | core; size:small }}"
+    including_card = Card.new name: 'Image1',
+                              content: '{{TestImage | core; size:small }}'
     rendered = including_card.format._render :core
-    assert_view_select rendered, 'img[src=?]', "/files/~#{image_card.id}/#{image_card.last_content_action_id}-small.jpg"
+    assert_view_select(
+      rendered, 'img[src=?]',
+      "/files/~#{image_card.id}/#{image_card.last_content_action_id}-small.jpg"
+    )
   end
 
-
-  context "newly created image card" do
+  context 'newly created image card' do
     before do
       Card::Auth.as_bot do
-        Card.create! name: "image card", type: 'image', image: File.new( File.join FIXTURES_PATH, 'mao2.jpg' )
+        Card.create! name: 'image card', type: 'image',
+                     image: File.new(File.join(FIXTURES_PATH, 'mao2.jpg'))
       end
     end
     subject { Card['image card'] }
-    it "stores correct identifier" do
-      expect(subject.content).to eq "~#{subject.id}/#{subject.last_action_id}.jpg"
+    it 'stores correct identifier' do
+      expect(subject.content)
+        .to eq "~#{subject.id}/#{subject.last_action_id}.jpg"
     end
 
-    it "stores image" do
+    it 'stores image' do
       expect(subject.image.size).to eq 7202
     end
 
-    it "stores small size" do
+    it 'stores small size' do
       expect(subject.image.small.size).to be < 6000
       expect(subject.image.small.size).to be > 0
     end
 
-    it "stores icon size" do
+    it 'stores icon size' do
       expect(subject.image.icon.size).to be < 3000
       expect(subject.image.icon.size).to be > 0
     end
 
-    it "saves original file name as action comment" do
-      expect(subject.last_action.comment).to eq "mao2.jpg"
+    it 'saves original file name as action comment' do
+      expect(subject.last_action.comment).to eq 'mao2.jpg'
     end
 
-    it "has correct original filename" do
-      expect(subject.original_filename).to eq "mao2.jpg"
+    it 'has correct original filename' do
+      expect(subject.original_filename).to eq 'mao2.jpg'
     end
 
-    it "has correct url" do
-      expect(subject.image.url).to eq "/files/~#{subject.id}/#{subject.last_action_id}-original.jpg"
+    it 'has correct url' do
+      expect(subject.image.url)
+        .to eq "/files/~#{subject.id}/#{subject.last_action_id}-original.jpg"
     end
 
-
     describe 'view: source' do
       it 'renders url' do
-        expect(subject.format.render(:source)).to eq("/files/~#{subject.id}/#{subject.last_action_id}-medium.jpg")
+        expect(subject.format.render(:source))
+          .to eq("/files/~#{subject.id}/#{subject.last_action_id}-medium.jpg")
       end
     end
 
-
     describe 'view: act_expanded' do
       it 'gets image url' do
-        act_summary = subject.format.render(:act_expanded, act: subject.last_act)
+        act_summary = subject.format
+                             .render(:act_expanded, act: subject.last_act)
         current_url = subject.image.versions[:medium].url
-        expect(act_summary).to match /#{Regexp.quote current_url}/
+        expect(act_summary).to match(/#{Regexp.quote current_url}/)
       end
     end
 
-
-    context "updated file card" do
+    context 'updated file card' do
       before do
-        subject.update_attributes! image: File.new( File.join FIXTURES_PATH, 'rails.gif' )
+        subject.update_attributes!(
+          image: File.new(File.join(FIXTURES_PATH, 'rails.gif'))
+        )
       end
-      it "updates file" do
+      it 'updates file' do
         expect(subject.image.size).to eq 8533
       end
 
-      it "updates original file name" do
-        expect(subject.image.original_filename).to eq "rails.gif"
+      it 'updates original file name' do
+        expect(subject.image.original_filename).to eq 'rails.gif'
       end
 
-      it "updates url" do
-        expect(subject.image.url).to eq "/files/~#{subject.id}/#{subject.last_action_id}-original.gif"
+      it 'updates url' do
+        expect(subject.image.url)
+          .to eq "/files/~#{subject.id}/#{subject.last_action_id}-original.gif"
       end
     end
   end
@@ -95,31 +102,34 @@ describe Card::Set::Type::Image do
       expect(subject.image.size).to be > 0
     end
     it 'has correct url' do
-      expect(subject.image.url).to eq "/files/:logo/05_standard-original.png"
+      expect(subject.image.url).to eq '/files/:logo/05_standard-original.png'
     end
-    it "has correct url as content" do
+    it 'has correct url as content' do
       expect(subject.content).to eq ":#{subject.codename}/05_standard.png"
     end
 
-    it "becomes a regular file when changed" do
+    it 'becomes a regular file when changed' do
       Card::Auth.as_bot do
-        subject.update_attributes! image: File.new( File.join FIXTURES_PATH, 'rails.gif' )
+        subject.update_attributes!(
+          image: File.new(File.join(FIXTURES_PATH, 'rails.gif'))
+        )
       end
       expect(subject.mod_file?).to be_falsey
-      expect(subject.image.url).to eq "/files/~#{subject.id}/#{subject.last_action_id}-original.gif"
+      expect(subject.image.url)
+        .to eq "/files/~#{subject.id}/#{subject.last_action_id}-original.gif"
     end
 
-    describe "#mod_file?" do
-      it "returns the mod name" do
+    describe '#mod_file?' do
+      it 'returns the mod name' do
         expect(subject.mod_file?).to eq('05_standard')
       end
     end
 
-    describe "source view" do
-      it "renders url with medium version" do
-        expect(subject.format.render_source).to eq "/files/:#{subject.codename}/05_standard-medium.png"
+    describe 'source view' do
+      it 'renders url with medium version' do
+        expect(subject.format.render_source)
+          .to eq "/files/:#{subject.codename}/05_standard-medium.png"
       end
     end
   end
-
 end

data/mod/05_standard/spec/set/type/layout_type_spec.rb

@@ -1,7 +1,7 @@
 # -*- encoding : utf-8 -*-
 
 describe Card::Set::Type::LayoutType do
-  it "should include Html card methods" do
-    expect(Card.new( type: 'Layout' ).clean_html?).to be_falsey
+  it 'should include Html card methods' do
+    expect(Card.new(type: 'Layout').clean_html?).to be_falsey
   end
 end

data/mod/05_standard/spec/set/type/listed_by_spec.rb

@@ -81,7 +81,7 @@ describe Card::Set::Type::ListedBy do
               }
             )
             Card.fetch('Adventures of Buckleharry Finn+authors')
-              .update_attributes!(content: '[[Darles Chickens]]')
+                .update_attributes!(content: '[[Darles Chickens]]')
           end
         end
         it do
@@ -110,7 +110,7 @@ describe Card::Set::Type::ListedBy do
             )
           end
         end
-        it { is_expected.to eq ['50 grades of shy','Parry Moppins'] }
+        it { is_expected.to eq ['50 grades of shy', 'Parry Moppins'] }
       end
 
       context 'when the name of Darles Chickens changed' do

data/mod/05_standard/spec/set/type/number_spec.rb

@@ -1,7 +1,7 @@
 # -*- encoding : utf-8 -*-
 
 describe Card::Set::Type::Number do
-  it "should have special editor" do
+  it 'should have special editor' do
     assert_view_select render_editor('Number'), 'input[type="text"]'
   end
 end

data/mod/05_standard/spec/set/type/phrase_spec.rb

@@ -1,7 +1,7 @@
 # -*- encoding : utf-8 -*-
 
 describe Card::Set::Type::Phrase do
-  it "should have special editor" do
+  it 'should have special editor' do
     assert_view_select render_editor('Phrase'), 'input[type="text"][class~="card-content"]'
   end
 end

data/mod/05_standard/spec/set/type/search_type_spec.rb

@@ -1,38 +1,38 @@
 # -*- encoding : utf-8 -*-
 
 describe Card::Set::Type::SearchType do
-  it "wraps search items with correct view class" do
-    Card.create type: 'Search', name: 'Asearch', content: %{{"type":"User"}}
-    c=render_content("{{Asearch|core;item:name}}")
+  it 'wraps search items with correct view class' do
+    Card.create type: 'Search', name: 'Asearch', content: %({"type":"User"})
+    c = render_content('{{Asearch|core;item:name}}')
     expect(c).to match('search-result-item item-name')
-    expect(render_content("{{Asearch|core}}"          ).scan('search-result-item item-closed').size).to eq(14)
-    expect(render_content("{{Asearch|core;item:open}}").scan('search-result-item item-open'  ).size).to eq(14)
-    expect(render_content("{{Asearch|core|titled}}"   ).scan('search-result-item item-titled').size).to eq(14)
+    expect(render_content('{{Asearch|core}}').scan('search-result-item item-closed').size).to eq(14)
+    expect(render_content('{{Asearch|core;item:open}}').scan('search-result-item item-open').size).to eq(14)
+    expect(render_content('{{Asearch|core|titled}}').scan('search-result-item item-titled').size).to eq(14)
   end
 
   it "handles returning 'count'" do
-    expect(render_card(:core, type: 'Search', content: %{{ "type":"User", "return":"count"}})).to eq('14')
+    expect(render_card(:core, type: 'Search', content: %({ "type":"User", "return":"count"}))).to eq('14')
   end
 
-  it "passes item args correctly" do
+  it 'passes item args correctly' do
     Card.create!(
       name: 'Pointer2Searches',
       type_id: Card::PointerID,
       content: "[[Layout+*type+by name]]\n[[PlainText+*type+by name]]"
     )
-    r = render_content "{{Pointer2Searches|core|closed|hide:menu}}"
+    r = render_content '{{Pointer2Searches|core|closed|hide:menu}}'
     expect(r.scan('"view":"link"').size).to eq(0)
-    expect(r.scan('item-closed').size).to eq(2) #there are two of each
+    expect(r.scan('item-closed').size).to eq(2) # there are two of each
   end
 
   it 'handles type update from pointer' do
     pointer_card = Card.create!(
-        name: "PointerToSearches",
-        type_id: Card::PointerID,
+      name: 'PointerToSearches',
+      type_id: Card::PointerID
     )
 
-    pointer_card.update_attributes! type_id: Card::SearchTypeID,content: %{{"type":"User"}}
-    expect(pointer_card.content).to eq(%{{"type":"User"}})
+    pointer_card.update_attributes! type_id: Card::SearchTypeID, content: %({"type":"User"})
+    expect(pointer_card.content).to eq(%({"type":"User"}))
   end
 
   context 'references' do
@@ -47,12 +47,11 @@ describe Card::Set::Type::SearchType do
       Card['Y'].update_attributes! name: 'YYY', update_referers: true
       expect(subject.content).to eq '{"name":"YYY"}'
     end
-
   end
   context 'rss format' do
     it 'render rss without errors' do
       search_card = Card.create type: 'Search', name: 'Asearch',
-                                content: %{{"id":"1"}}
+                                content: %({"id":"1"})
       rss = search_card.format(:rss).render_feed
       expect(rss).to have_tag('title', text: 'Wagn Bot')
     end

data/mod/05_standard/spec/set/type/set_spec.rb

@@ -1,26 +1,25 @@
 # -*- encoding : utf-8 -*-
 
 describe Card::Set::Type::Set do
-  
   describe :junction_only? do
-    it "should identify sets that only apply to plus cards" do
-      expect(Card.fetch("*all").junction_only?).to be_falsey
-      expect(Card.fetch("*all plus").junction_only?).to be_truthy
-      expect(Card.fetch("Book+*type").junction_only?).to be_falsey
-      expect(Card.fetch("*to+*right").junction_only?).to be_truthy
-      expect(Card.fetch("Book+*to+*type plus right").junction_only?).to be_truthy
+    it 'should identify sets that only apply to plus cards' do
+      expect(Card.fetch('*all').junction_only?).to be_falsey
+      expect(Card.fetch('*all plus').junction_only?).to be_truthy
+      expect(Card.fetch('Book+*type').junction_only?).to be_falsey
+      expect(Card.fetch('*to+*right').junction_only?).to be_truthy
+      expect(Card.fetch('Book+*to+*type plus right').junction_only?).to be_truthy
     end
   end
-  
+
   describe :inheritable? do
-    it "should identify sets that can inherit rules" do
-      expect(Card.fetch("A+*self").inheritable?).to be_falsey
-      expect(Card.fetch("A+B+*self").inheritable?).to be_truthy
-      expect(Card.fetch("Book+*to+*type plus right").inheritable?).to be_truthy
-      expect(Card.fetch("Book+*type").inheritable?).to be_falsey
-      expect(Card.fetch("*to+*right").inheritable?).to be_truthy
-      expect(Card.fetch("*all plus").inheritable?).to be_truthy
-      expect(Card.fetch("*all").inheritable?).to be_falsey
+    it 'should identify sets that can inherit rules' do
+      expect(Card.fetch('A+*self').inheritable?).to be_falsey
+      expect(Card.fetch('A+B+*self').inheritable?).to be_truthy
+      expect(Card.fetch('Book+*to+*type plus right').inheritable?).to be_truthy
+      expect(Card.fetch('Book+*type').inheritable?).to be_falsey
+      expect(Card.fetch('*to+*right').inheritable?).to be_truthy
+      expect(Card.fetch('*all plus').inheritable?).to be_truthy
+      expect(Card.fetch('*all').inheritable?).to be_falsey
     end
   end
-end
+end

data/mod/05_standard/spec/set/type/signup_spec.rb

@@ -58,7 +58,9 @@ describe Card::Set::Type::Signup do
     end
 
     it 'notifies someone' do
-      expect(ActionMailer::Base.deliveries.last.to).to eq(['signups@wagn.org'])
+      expect(ActionMailer::Base.deliveries.map(&:to).sort).to(
+        eq [['signups@wagn.org'], ['wolf@wagn.org']]
+      )
     end
 
     it 'is activated by an update' do
@@ -77,7 +79,7 @@ describe Card::Set::Type::Signup do
                                         8.days.ago.strftime('%F %T')
       @account.token_card.expire
       Card::Env.params[:token] = @token
-
+      @signup = Card.fetch 'big bad wolf'
       result = @signup.update_attributes!({})
       # successfully completes save
       expect(result).to eq(true)
@@ -175,9 +177,9 @@ describe Card::Set::Type::Signup do
     end
 
     it 'sends welcome email when account is activated' do
-      @signup.run_phase :approve do
-        @signup.activate_account
-      end
+      # @signup.run_phase :approve do
+      @signup.activate_account
+      # end
       @mail = ActionMailer::Base.deliveries.find { |a| a.subject == 'welcome' }
       Mail::TestMailer.deliveries.clear
 

data/mod/05_standard/spec/set/type/toggle_spec.rb

@@ -1,12 +1,12 @@
 # -*- encoding : utf-8 -*-
 
 describe Card::Set::Type::Toggle do
-  it "should have special editor" do
+  it 'should have special editor' do
     assert_view_select render_editor('Toggle'), 'input[type="checkbox"]'
   end
 
-  it "should have yes/no as processed content" do
-    expect(render_card(:core, type: 'Toggle', content: "0")).to eq('no')
-    expect(render_card(:closed_content, type: 'Toggle', content: "1")).to eq('yes')
+  it 'should have yes/no as processed content' do
+    expect(render_card(:core, type: 'Toggle', content: '0')).to eq('no')
+    expect(render_card(:closed_content, type: 'Toggle', content: '1')).to eq('yes')
   end
 end

data/mod/05_standard/spec/set/type/uri_spec.rb

@@ -1,41 +1,41 @@
 # -*- encoding : utf-8 -*-
 
 describe Card::Set::Type::Uri do
-  it "should have special editor" do
+  it 'should have special editor' do
     assert_view_select render_editor('Uri'), 'input[type="text"][class~="card-content"]'
   end
 
-  it "renders core view links" do
+  it 'renders core view links' do
     card = Card.create(type: 'URI', name: 'A URI card', content: 'http://wagn.org/Home')
     assert_view_select card.format.render('core'), 'a[class="external-link"][href="http://wagn.org/Home"]' do
-      assert_select 'span[class="card-title"]', {text: 'A URI card' }
+      assert_select 'span[class="card-title"]', text: 'A URI card'
     end
   end
 
-  it "renders core view links with title arg" do
+  it 'renders core view links with title arg' do
     card = Card.create(type: 'URI', name: 'A URI card', content: 'http://wagn.org/Home')
     assert_view_select card.format.render('core', title: 'My Title'), 'a[class="external-link"][href="http://wagn.org/Home"]' do
-      assert_select 'span[class="card-title"]', {text: 'My Title' }
+      assert_select 'span[class="card-title"]', text: 'My Title'
     end
   end
 
-  it "renders title view in a plain formatter" do
+  it 'renders title view in a plain formatter' do
     card = Card['A']
     card.format(:text).render('title', title: 'My Title').should == 'My Title'
     card.format(:text).render('title').should == 'A'
   end
 
-  it "renders url_link for regular cards" do
+  it 'renders url_link for regular cards' do
     card = Card['A']
     card.format(:text).render('url_link').should == '/A'
     assert_view_select card.format.render('url_link'),
-      'a[class="internal-link"][href="/A"]',
-      {text: '/A' }
+                       'a[class="internal-link"][href="/A"]',
+                       text: '/A'
   end
 
-  it "renders a url_link view" do
+  it 'renders a url_link view' do
     card = Card.create(type: 'URI', name: 'A URI card', content: 'http://wagn.org/Home')
-    assert_view_select card.format.render('url_link'), 'a[class="external-link"]', {text: 'http://wagn.org/Home'}
+    assert_view_select card.format.render('url_link'), 'a[class="external-link"]', text: 'http://wagn.org/Home'
     card.format(:text).render('url_link').should == 'http://wagn.org/Home'
   end
 end