card 1.17.4 → 1.18.0

data/mod/05_email/spec/set/all/follow_spec.rb

@@ -1,16 +1,15 @@
 # -*- encoding : utf-8 -*-
 
-describe "Card::Set::All::Follow" do
+describe 'Card::Set::All::Follow' do
   def follow_view card_name
     render_card :follow_link, name: card_name
   end
 
-  describe "follower_ids" do
-
+  describe 'follower_ids' do
     context 'when a new +*follow rule created' do
       it 'contains id of a new follower' do
         Card::Auth.as_bot do
-          Card['Joe User'].follow "No One Sees Me"
+          Card['Joe User'].follow 'No One Sees Me'
           expect(Card['No One Sees Me'].follower_ids).to eq ::Set.new([Card['Joe User'].id])
         end
       end
@@ -18,51 +17,47 @@ describe "Card::Set::All::Follow" do
 
     subject { Card[cardname].follower_names.sort }
     context 'followers of No One Sees Me' do
-      let(:cardname) {'No One Sees Me'}
+      let(:cardname) { 'No One Sees Me' }
       it { is_expected.to eq([]) }
     end
 
     context 'followers of Magnifier' do
-      let(:cardname) {'Magnifier'}
-      it { is_expected.to eq([])}
+      let(:cardname) { 'Magnifier' }
+      it { is_expected.to eq([]) }
     end
 
     context 'followers of Magnifier+lens' do
-      let(:cardname) {'Magnifier+lens'}
-      it { is_expected.to eq ['Big Brother','Narcissist']}
+      let(:cardname) { 'Magnifier+lens' }
+      it { is_expected.to eq ['Big Brother', 'Narcissist'] }
     end
 
     context 'followers of Sunglasses' do
-      let(:cardname) {'Sunglasses'}
-      it { is_expected.to eq ['Big Brother', 'Narcissist', 'Optic fan', 'Sara', 'Sunglasses fan']}
+      let(:cardname) { 'Sunglasses' }
+      it { is_expected.to eq ['Big Brother', 'Narcissist', 'Optic fan', 'Sara', 'Sunglasses fan'] }
     end
     context 'followers of Sunglasses+tint' do
-      let(:cardname) {'Sunglasses+tint'}
-      it { is_expected.to eq ['Big Brother', 'Narcissist', 'Optic fan', 'Sara', 'Sunglasses fan']}
+      let(:cardname) { 'Sunglasses+tint' }
+      it { is_expected.to eq ['Big Brother', 'Narcissist', 'Optic fan', 'Sara', 'Sunglasses fan'] }
     end
 
     context 'followers of Google glass' do
-      let(:cardname) {'Google glass'}
-      it { is_expected.to eq ['Big Brother', 'Optic fan', 'Sara']}
+      let(:cardname) { 'Google glass' }
+      it { is_expected.to eq ['Big Brother', 'Optic fan', 'Sara'] }
     end
   end
 
-
-
-
-
-  describe "view: follow_link" do
+  describe 'view: follow_link' do
     before do
       Card::Auth.current_id = Card['Big Brother'].id
     end
 
     def assert_following_view name, args
-      assert_follow_view name, args.reverse_merge(following: true, text: "unfollow" )
+      assert_follow_view name, args.reverse_merge(following: true, text: 'unfollow')
     end
 
-#  href="/card/update/Home+*self+philipp+*follow?card%5Bcontent%5D=%5B%5Bnever%5D%5D&success%5Bid%5D=Home&success%5Bview%5D=follow"
+    #  href="/card/update/Home+*self+philipp+*follow?card%5Bcontent%5D=%5B%5Bnever%5D%5D&success%5Bid%5D=Home&success%5Bview%5D=follow"
     def assert_follow_view name, args
-      args[:user] ||= "Big_Brother"
+      args[:user] ||= 'Big_Brother'
       #      href = "/card/update/#{args[:add_set].to_name.url_key}+#{args[:user]}+*follow?"
       #      href += CGI.escape("card[content]") + '='
       #      href +=
@@ -75,61 +70,57 @@ describe "Card::Set::All::Follow" do
       #        end
 
       link_class = 'follow-link'
-      assert_view_select follow_view(name), "a[class~=#{link_class}][href*='']", args[:text] || "follow"
+      assert_view_select follow_view(name), "a[class~=#{link_class}][href*='']", args[:text] || 'follow'
     end
 
-
-
-
-    context "when not following" do
+    context 'when not following' do
       it 'renders follow link' do
         assert_follow_view 'No One Sees Me', add_set: 'No One Sees Me+*self'
       end
     end
 
-    context "when following *self" do
+    context 'when following *self' do
       it 'renders following link' do
         assert_following_view 'Look At Me', add_set: 'Look at me+*self'
       end
     end
 
-    context "when following *type" do
+    context 'when following *type' do
       it 'renders following link' do
         assert_following_view 'Sunglasses', add_set: 'Sunglasses+*self'
       end
     end
 
-    context "when following cardtype card" do
+    context 'when following cardtype card' do
       it 'renders following all link' do
         assert_following_view 'Optic', add_set: 'Optic+*type', text: 'unfollow'
       end
     end
 
-    context "when not following cardtype card" do
+    context 'when not following cardtype card' do
       it "renders 'follow all' link" do
         assert_follow_view 'Basic', add_set: 'Basic+*type', text: 'follow'
       end
     end
 
-    context "when following *right" do
-      it "renders following link" do
+    context 'when following *right' do
+      it 'renders following link' do
         assert_following_view 'Magnifier+lens', add_set: 'Magnifier+lens+*self'
       end
     end
 
     context 'when following content I created' do
       before { Card::Auth.current_id = Card['Narcissist'].id }
-      it "renders following link" do
+      it 'renders following link' do
         assert_following_view 'Sunglasses', add_set: 'Sunglasses+*self', user: 'Narcissist'
       end
     end
 
     context 'when following content I edited' do
       before { Card::Auth.current_id = Card['Narcissist'].id }
-      it "renders following link" do
+      it 'renders following link' do
         assert_following_view 'Magnifier+lens', add_set: 'Magnifier+lens+*self', user: 'Narcissist'
       end
     end
   end
-
 end

data/mod/05_email/spec/set/all/notify_spec.rb

@@ -46,7 +46,7 @@ shared_examples_for 'notifications' do
           name: 'bnn card', type: :pointer, content: 'changed content'
         )
         @card.format(format: format)
-          .render_list_of_changes(action_id: action_id)
+             .render_list_of_changes(action_id: action_id)
       end
       it { is_expected.to include "content: #{content}" }
     end
@@ -102,11 +102,11 @@ describe Card::Set::All::Notify do
       before do
         Card::Auth.as_bot do
           @card = Card.create!(name: name, content: content,
-                               subcards: { '+s1'=>{content: sub1_content},
-                                           '+s2'=>{content: sub2_content} })
+                               subcards: { '+s1' => { content: sub1_content },
+                                           '+s2' => { content: sub2_content } })
         end
       end
-      subject {
+      subject do
         Card[:follower_notification_email].format.render_mail(
           context:   @card.refresh(true),
           to:        Card['Joe User'].email,
@@ -114,7 +114,7 @@ describe Card::Set::All::Notify do
           followed_set:  "#{@card.name}+*self",
           follow_option: '*always'
         ).text_part.body.raw_source
-      }
+      end
 
       it { is_expected.to include content }
       it { is_expected.to include sub1_content }
@@ -132,20 +132,20 @@ describe Card::Set::All::Notify do
           end
         end
         context 'for main card' do
-          subject {
+          subject do
             Card[:follower_notification_email].format.render_mail(
-                context:   @card.refresh(true),
-                to:        Card['Joe User'].email,
-                follower:  Card['Joe User'].name,
-                followed_set:  @card.name+'+s1+*self',
-                follow_option: '*always'
-              ).text_part.body.raw_source
-          }
+              context:   @card.refresh(true),
+              to:        Card['Joe User'].email,
+              follower:  Card['Joe User'].name,
+              followed_set:  @card.name + '+s1+*self',
+              follow_option: '*always'
+            ).text_part.body.raw_source
+          end
           before do
             Card.create_or_update! "#{name}+*self+*read",
                                    type: 'Pointer', content: '[[Administrator]]'
             Card.create_or_update! "#{name}+s1+*self+*read",
-                                   type: 'Pointer',content: '[[Anyone]]'
+                                   type: 'Pointer', content: '[[Anyone]]'
           end
           it 'includes subcard content' do
             is_expected.to include sub1_content
@@ -194,17 +194,17 @@ describe Card::Set::All::Notify do
       sub2_content = 'new content of subcard 2'
       Card::Auth.as_bot do
         @card = Card.create!(name: name, content: content,
-                             subcards: { '+s1'=>{content: sub1_content},
-                                          '+s2'=>{content: sub2_content} })
+                             subcards: { '+s1' => { content: sub1_content },
+                                         '+s2' => { content: sub2_content } })
       end
-      result =  Card[:follower_notification_email].format.render_mail(
+      result = Card[:follower_notification_email].format.render_mail(
         context:   @card,
         to:        Card['Joe User'].email,
         follower:  Card['Joe User'].name,
         followed_set:  "#{@card.name}+*self",
         follow_option: '*always'
       ).text_part.body.raw_source
-      expect(result).to eq(%{"another card with subcards" was just created by Joe User.
+      expect(result).to eq(%("another card with subcards" was just created by Joe User.
 
    cardtype: Basic
    content: main content {{+s1}}  {{+s2}}
@@ -230,12 +230,11 @@ See the card: /another_card_with_subcards
 You received this email because you're following "another card with subcards".
 
 Use this link to unfollow /update/Joe_User+*follow?card%5Bsubcards%5D%5Banother+card+with+subcards%2B%2Aself%2BJoe+User%2B%2Afollow%5D=%2Anever
-})
+))
     end
   end
 
-
-  describe "#notify_followers" do
+  describe '#notify_followers' do
     def expect_user user_name
       expect(Card.fetch(user_name).account)
     end
@@ -252,8 +251,6 @@ Use this link to unfollow /update/Joe_User+*follow?card%5Bsubcards%5D%5Banother+
       Card[card_name].update_attributes! content: new_content
     end
 
-
-
     it 'sends notifications of edits' do
       expect_user('Big Brother').to be_notified_of 'All Eyes On Me+*self'
       update 'All Eyes On Me'
@@ -275,8 +272,6 @@ Use this link to unfollow /update/Joe_User+*follow?card%5Bsubcards%5D%5Banother+
       update 'No One Sees Me'
     end
 
-
-
     context 'when following *type sets' do
       before do
         Card::Auth.current_id = Card['joe admin'].id
@@ -343,7 +338,7 @@ Use this link to unfollow /update/Joe_User+*follow?card%5Bsubcards%5D%5Banother+
 
         context 'and follow fields rule contains *include' do
           it 'sends notification of new included card' do
-            new_card =  Card.new name: 'Sunglasses+lens'
+            new_card = Card.new name: 'Sunglasses+lens'
             expect_user('Sunglasses fan').to be_notified_of 'Sunglasses+*self'
             new_card.save!
           end

data/mod/05_email/spec/set/all/observer_spec.rb

@@ -3,44 +3,63 @@
 describe Card::Set::Type::EmailTemplate do
   before :each do
     Card::Auth.as_bot do
-      Card.create! name: "mail template",  type_code: 'email_template', subcards: {'+*html message'=>{content: 'Hi Joe! My name is {{_self|name}}'},
-                                                                                      '+*to'=>{content: 'joe@user.com'},
-                                                                                      '+*from'=>{content: 'from@user.com'} }
+      Card.create! name: 'mail template',  type_code: 'email_template',
+                   subcards: {
+                     '+*html message' => {
+                       content: 'Hi Joe! My name is {{_self|name}}'
+                     },
+                     '+*to' => { content: 'joe@user.com' },
+                     '+*from' => { content: 'from@user.com' }
+                   }
     end
   end
   it 'sends email on update' do
     Card::Auth.as_bot do
-      Card.create! name: "mail test+*self+*on update", type_code: :pointer, content: "[[mail template]]"
+      Card.create! name: 'mail test+*self+*on update', type_code: :pointer,
+                   content: '[[mail template]]'
     end
-    card = Card.fetch "mail test"
-    expect { Card::Auth.as_bot { card.update_attributes(content: "test") } }.to change { Mail::TestMailer.deliveries.count }.by(1)
+    card = Card.fetch 'mail test'
+    expect { Card::Auth.as_bot { card.update_attributes(content: 'test') } }
+      .to change { Mail::TestMailer.deliveries.count }.by(1)
   end
 
   it 'sends email on delete' do
     Card::Auth.as_bot do
-      Card.create! name: "mail test+*self+*on delete", type_code: :pointer, content: "[[mail template]]"
+      Card.create! name: 'mail test+*self+*on delete', type_code: :pointer,
+                   content: '[[mail template]]'
     end
-    card = Card.fetch "mail test"
-    expect { Card::Auth.as_bot { card.delete } }.to change { Mail::TestMailer.deliveries.count }.by(1)
+    card = Card.fetch 'mail test'
+    expect { Card::Auth.as_bot { card.delete } }
+      .to change { Mail::TestMailer.deliveries.count }.by(1)
   end
 
   it 'sends email on create' do
     Card::Auth.as_bot do
-      Card.create! name: "Cardtype A+*type+*on create", type_code: :pointer, content: "[[mail template]]"
+      Card.create! name: 'Cardtype A+*type+*on create', type_code: :pointer,
+                   content: '[[mail template]]'
     end
-    expect { Card::Auth.as_bot { Card.create! name: "mail test", type_code: :cardtype_a} }.to change { ActionMailer::Base.deliveries.count }.by(1)
+    expect do
+      Card::Auth.as_bot { Card.create! name: 'mailme', type_code: :cardtype_a }
+    end.to change { ActionMailer::Base.deliveries.count }.by(1)
   end
 
   describe '#send_action_mails' do
     before do
       Card::Auth.as_bot do
-        Card.create! name: "another mail template",  type_code: 'email_template', subcards: {'+*html message'=>{content: 'Hi Joe! My name is {{_self|name}}'},
-                                                                                        '+*to'=>{content: 'joe@user.com'},
-                                                                                        '+*from'=>{content: 'from@user.com'} }
-        Card.create! name: "mail test+*self+*on update", type_code: :pointer, content: "[[mail template]]\n[[another mail template]]"
-        Card.create! name: "mail test+*self+*on delete", type_code: :pointer, content: "[[mail template]]\n[[another mail template]]"
+        Card.create! name: 'another mail template',
+                     type_code: 'email_template',
+                     subcards: {
+                       '+*html message' => {
+                         content: 'Hi Joe! My name is {{_self|name}}'
+                       },
+                       '+*to' => { content: 'joe@user.com' },
+                       '+*from' => { content: 'from@user.com' } }
+        Card.create! name: 'mail test+*self+*on update', type_code: :pointer,
+                     content: "[[mail template]]\n[[another mail template]]"
+        Card.create! name: 'mail test+*self+*on delete', type_code: :pointer,
+                     content: "[[mail template]]\n[[another mail template]]"
       end
-      card = Card.fetch "mail test"
+      card = Card.fetch 'mail test'
       ActionMailer::Base.deliveries = []
       card.send_action_mails on: :update
     end
@@ -49,28 +68,30 @@ describe Card::Set::Type::EmailTemplate do
       expect(ActionMailer::Base.deliveries.size).to eq(2)
     end
     it 'uses correct context' do
-      expect(ActionMailer::Base.deliveries.last.body.raw_source).to include('My name is mail test')
+      expect(ActionMailer::Base.deliveries.last.body.raw_source)
+        .to include('My name is mail test')
     end
   end
 
   # describe '#send_timer_mails' do
- #    before do
- #      ActionMailer::Base.deliveries = []
- #      Card::Auth.as_bot do
- #        Card.create! name: "A+*hourly", type_code: 'email_template',  subcards: {'+*message'=>{content: 'hourly update name:{{_self|name}}'},
- #                                                                                      '+*to'=>{content: 'joe@user.com'},
- #                                                                                      '+*from'=>{content: 'from@user.com'}}
- #      end
- #      Card::Set::All::Observer.send_timer_mails :hourly
- #      @mail = ActionMailer::Base.deliveries.last
- #    end
- #
- #    it 'delivers hourly mails' do
- #      expect(@mail.body.raw_source).to include('hourly update')
- #    end
- #    it 'uses correct context' do
- #      expect(@mail.body.raw_source).to include('name:A')
- #    end
- #  end
+  #    before do
+  #      ActionMailer::Base.deliveries = []
+  #      Card::Auth.as_bot do
+  #        Card.create! name: "A+*hourly", type_code: 'email_template',
+  #           subcards: {
+  #              '+*message'=>{content: 'hourly update name:{{_self|name}}'},
+  #                     '+*to'=>{content: 'joe@user.com'},
+  #                     '+*from'=>{content: 'from@user.com'}}
+  #      end
+  #      Card::Set::All::Observer.send_timer_mails :hourly
+  #      @mail = ActionMailer::Base.deliveries.last
+  #    end
+  #
+  #    it 'delivers hourly mails' do
+  #      expect(@mail.body.raw_source).to include('hourly update')
+  #    end
+  #    it 'uses correct context' do
+  #      expect(@mail.body.raw_source).to include('name:A')
+  #    end
+  #  end
 end
-

data/mod/05_email/spec/set/right/followers_spec.rb

@@ -1,13 +1,11 @@
 # -*- encoding : utf-8 -*-
 
 describe Card::Set::Right::Followers do
-
-
-
   describe '#raw_content' do
     it 'returns a pointer list of followers' do
       card = Card.fetch 'All Eyes on me'
-      expect( card.followers_card.item_names.sort).to eq ['Big Brother','John','Sara']
+      expect(card.followers_card.item_names.sort)
+        .to eq ['Big Brother', 'John', 'Sara']
     end
   end
 
@@ -15,7 +13,7 @@ describe Card::Set::Right::Followers do
     it 'contains follower' do
       card = Card.fetch 'All Eyes on me'
       view = card.followers_card.format.render_core
-      expect(view).to include("Sara")
+      expect(view).to include('Sara')
     end
   end
 
@@ -23,16 +21,16 @@ describe Card::Set::Right::Followers do
     it 'renders a pointer list of followers' do
       card = Card.fetch 'All Eyes on me'
       view = card.followers_card.format.render_raw
-      expect(view.split("\n").sort).to eq ['[[Big Brother]]','[[John]]','[[Sara]]']
+      expect(view.split("\n").sort)
+        .to eq ['[[Big Brother]]', '[[John]]', '[[Sara]]']
     end
   end
 
-
   describe 'item_names' do
     subject { @card.followers_card.item_names.sort }
     it 'is an array of followers' do
       @card = Card['All Eyes On Me']
-      is_expected.to eq ['Big Brother','John','Sara']
+      is_expected.to eq ['Big Brother', 'John', 'Sara']
     end
 
     it 'recognizes card name changes' do
@@ -88,7 +86,7 @@ describe Card::Set::Right::Followers do
     context 'when following content I created' do
       it 'contains creator' do
         Card::Auth.current_id = Card['Big Brother'].id
-        @card = Card.create! name: "created by Follower"
+        @card = Card.create! name: 'created by Follower'
         is_expected.to include('Big Brother')
       end
     end
@@ -99,14 +97,13 @@ describe Card::Set::Right::Followers do
           Card['Sara'].follow '*all', '*edited'
         end
 
-        @card = Card.create! name: "edited by Sara"
+        @card = Card.create! name: 'edited by Sara'
         Card::Auth.current_id = Card['Sara'].id
         @card.update_attributes! content: 'some content'
         is_expected.to include('Sara')
       end
     end
 
-
     context 'for a set card' do
       it 'contains followers of that set' do
         @card = Card['lens+*right']
@@ -120,7 +117,5 @@ describe Card::Set::Right::Followers do
         is_expected.to include('Optic fan')
       end
     end
-
   end
-
-end
+end