card 1.17.4 → 1.18.0

data/mod/05_standard/spec/set/all/links_spec.rb

@@ -3,12 +3,12 @@ describe Card::Set::All::Links do
   require 'card'
   describe '#web_link' do
     it 'opens external link in new tab' do
-      link = Card['Home'].format.web_link("http://example.com")
+      link = Card['Home'].format.web_link('http://example.com')
       assert_view_select link, 'a[class="external-link"][target="_blank"][href="http://example.com"]'
     end
 
     it 'opens interal link in same tab' do
-      link = Card['Home'].format.web_link("/Home")
+      link = Card['Home'].format.web_link('/Home')
       assert_view_select link, 'a[target="_blank"]', false
     end
   end

data/mod/05_standard/spec/set/all/rich_html/editing_spec.rb

@@ -5,7 +5,6 @@ describe Card::Set::All::RichHtml::Editing do
     @mycard = Card['A'].format
   end
 
-
   def assert_active_toolbar_pill view, content, related_view=false
     view_selector = related_view ? 'related' : view
     assert_view_select @mycard.render(view), "div[class~='card-slot #{view_selector}-view']" do

data/mod/05_standard/spec/set/all/rich_html/form_spec.rb

@@ -1,43 +1,43 @@
 # -*- encoding : utf-8 -*-
 
 describe Card::Set::All::RichHtml::Form do
-  describe "type_list" do
+  describe 'type_list' do
     before do
       @card = Card['UserForm']  # no cards with this type
     end
 
-    it "should get type options from type_field renderer method" do
+    it 'should get type options from type_field renderer method' do
       expect(@card.format.type_field).to match(/<option [^>]*selected/)
-      tf=@card.format.type_field(no_current_type: true)
+      tf = @card.format.type_field(no_current_type: true)
       expect(tf).not_to match(/<option [^>]*selected/)
       expect(tf.scan(/<option /).length).to eq(29)
-      tf=@card.format.type_field
+      tf = @card.format.type_field
       expect(tf).to match(/<option [^>]*selected/)
       expect(tf.scan(/<option /).length).to eq(29)
     end
 
-    it "should get type list" do
+    it 'should get type list' do
       Card::Auth.as :anonymous do
-        tf=@card.format.type_field(no_current_type: true)
+        tf = @card.format.type_field(no_current_type: true)
         expect(tf).not_to match(/<option [^>]*selected/)
         expect(tf.scan(/<option /).length).to eq(1)
-        tf=@card.format.type_field
+        tf = @card.format.type_field
         expect(tf).to match(/<option [^>]*selected/)
         expect(tf.scan(/<option /).length).to eq(2)
       end
     end
   end
 
-  context "type and header" do
-    it "should render type without no-edit class when no cards of type" do
+  context 'type and header' do
+    it 'should render type without no-edit class when no cards of type' do
       card = Card['UserForm']  # no cards with this type
       expect(card.format.render_type).to match(/<a[^>]* class="([^"]*)?\bcardtype\b[^"]*"/)
       expect(card.format.render_type).not_to match(/<a[^>]* class="([^"]*)?\bno-edit\b[^"]*"/)
     end
-    it "should render type header with no-edit class when cards of type exist" do
+    it 'should render type header with no-edit class when cards of type exist' do
       no_edit_card = Card['cardtype a']
       expect(no_edit_card.format.render_type).to match(/<a[^>]* class="([^"]*)?\bcardtype\b[^"]*"/)
       expect(no_edit_card.format.render_type).to match(/<a[^>]* class="([^"]*)?\bno-edit\b[^"]*"/)
     end
   end
-end
+end

data/mod/05_standard/spec/set/all/rich_html/wrapper_spec.rb

@@ -1,12 +1,12 @@
 # -*- encoding : utf-8 -*-
 
 describe Card::Set::All::RichHtml::Wrapper do
-  context "full wrapping" do
+  context 'full wrapping' do
     before do
       @ocslot = Card['A'].format
     end
 
-    it "has the appropriate attributes on open" do
+    it 'has the appropriate attributes on open' do
       assert_view_select @ocslot.render(:open), 'div[class="card-slot open-view ALL TYPE-basic SELF-a"]' do
         assert_select 'div[class="card-frame panel panel-default"]' do
           assert_select 'div[class="card-header panel-heading"]' do
@@ -17,7 +17,7 @@ describe Card::Set::All::RichHtml::Wrapper do
       end
     end
 
-    it "has the appropriate attributes on closed" do
+    it 'has the appropriate attributes on closed' do
       v = @ocslot.render(:closed)
       assert_view_select v, 'div[class="card-slot closed-view ALL TYPE-basic SELF-a"]' do
         assert_select 'div[class="card-frame panel panel-default"]' do
@@ -29,4 +29,4 @@ describe Card::Set::All::RichHtml::Wrapper do
       end
     end
   end
-end
+end

data/mod/05_standard/spec/set/right/email_spec.rb

@@ -1,7 +1,6 @@
 # -*- encoding : utf-8 -*-
 
 describe Card::Set::Right::Email do
-
   context '<User>+*email' do
     before do
       @card = Card.fetch 'u1+*email'
@@ -26,7 +25,7 @@ describe Card::Set::Right::Email do
     end
   end
 
-  context "+*account+*email" do
+  context '+*account+*email' do
     context 'update' do
       before :each do
         @email_card = email_card = Card['u1'].account.email_card
@@ -48,8 +47,6 @@ describe Card::Set::Right::Email do
         @email_card.update_attributes content: 'joe@user.com'
         expect(@email_card.errors[:content].first).to match(/must be unique/)
       end
-
     end
   end
-
 end

data/mod/05_standard/spec/set/right/password_spec.rb

@@ -1,9 +1,8 @@
 # -*- encoding : utf-8 -*-
 
 describe Card::Set::Right::Password do
-
   before :each do
-    @account = Card::Auth[ 'joe@user.com' ]
+    @account = Card::Auth['joe@user.com']
   end
 
   describe '#update_attributes' do
@@ -28,17 +27,15 @@ describe Card::Set::Right::Password do
         pw_card = acct.password_card
         pw_card.content = ''
         pw_card.save
-        expect(original_pw).to eq(pw_card.refresh(force=true).content)
+        expect(original_pw).to eq(pw_card.refresh(_force = true).content)
       end
 
       it "shouldn't break email editing" do
-        @account.update_attributes! subcards: {'+*password'=>'', '+*email'=>'joe2@user.com'}
+        @account.update_attributes! subcards: { '+*password' => '',
+                                                '+*email' => 'joe2@user.com' }
         expect(@account.email).to eq('joe2@user.com')
         expect(@account.password).not_to be_empty
       end
     end
   end
-
-
-
 end

data/mod/05_standard/spec/set/right/stats_spec.rb

@@ -1,11 +1,10 @@
 # -*- encoding : utf-8 -*-
 
 describe Card::Set::Right::Stats do
-
-  context "core view" do
+  context 'core view' do
     it 'should have a table' do
       Card::Auth.as_bot do
-        @core = render_card :core, name: "A+*stats"
+        @core = render_card :core, name: 'A+*stats'
         assert_view_select @core, 'table'
       end
     end

data/mod/05_standard/spec/set/right/when_created_spec.rb

@@ -2,6 +2,6 @@
 
 describe Card::Set::Right::WhenCreated do
   it 'should produce a text date' do
-    expect(render_card( :core, name: 'A+*when created' )).to match(/\w+ \d+/)
+    expect(render_card(:core, name: 'A+*when created')).to match(/\w+ \d+/)
   end
 end

data/mod/05_standard/spec/set/right/when_last_edited_spec.rb

@@ -2,6 +2,6 @@
 
 describe Card::Set::Right::WhenLastEdited do
   it 'should produce a text date' do
-    expect(render_card( :core, name: 'A+*when last edited' )).to match(/\w+ \d+/)
+    expect(render_card(:core, name: 'A+*when last edited')).to match(/\w+ \d+/)
   end
 end

data/mod/05_standard/spec/set/rstar/rules_spec.rb

@@ -1,22 +1,22 @@
 # -*- encoding : utf-8 -*-
 
 describe Card::Set::Rstar::Rules do
-  it "should render setting view for a right set" do
-     r = Card['*read+*right'].format.render_open
+  it 'should render setting view for a right set' do
+    r = Card['*read+*right'].format.render_open
      expect(r).not_to match(/error/i)
      expect(r).not_to match('No Card!')
-     #warn "r = #{r}"
+     # warn "r = #{r}"
      assert_view_select r, 'table[class="set-rules table"]' do
        assert_select 'a[href~="/*read+*right+*read?view=open_rule"]', text: 'read'
      end
   end
 
-  it "should render setting view for a *input rule" do
+  it 'should render setting view for a *input rule' do
     Card::Auth.as_bot do
-      r = Card.fetch('*read+*right+*input',new: {}).format.render_open_rule
+      r = Card.fetch('*read+*right+*input', new: {}).format.render_open_rule
       expect(r).not_to match(/error/i)
       expect(r).not_to match('No Card!')
-      #warn "r = #{r}"
+      # warn "r = #{r}"
       assert_view_select r, 'tr[class="card-slot open-rule edit-rule"]' do
         assert_select 'input[id="success_id"][name=?][type="hidden"][value="*read+*right+*input"]', 'success[id]'
       end

data/mod/05_standard/spec/set/self/all_spec.rb

@@ -28,18 +28,16 @@ describe Card::Set::Self::All do
       end
     end
 
-=begin
-    it 'should be trigger reference repair' do
-      Card::Auth.as_bot do
-        a = Card['A']
-        puts a.references_out.count
-        Card::Env.params[:task] = :repair_references
-        puts a.references_out.count
-        @all.update_attributes({})
-        puts a.references_out.count
-
-      end
-    end
-=end
+    #     it 'should be trigger reference repair' do
+    #       Card::Auth.as_bot do
+    #         a = Card['A']
+    #         puts a.references_out.count
+    #         Card::Env.params[:task] = :repair_references
+    #         puts a.references_out.count
+    #         @all.update_attributes({})
+    #         puts a.references_out.count
+    #
+    #       end
+    #     end
   end
 end

data/mod/05_standard/spec/set/self/head_spec.rb

@@ -1,7 +1,7 @@
 # -*- encoding : utf-8 -*-
 
 describe Card::Set::Self::Head do
-  it "should have a javascript tag" do
+  it 'should have a javascript tag' do
     assert_view_select render_card(:raw, name: '*head'), 'script[type="text/javascript"]'
   end
 
@@ -10,8 +10,6 @@ describe Card::Set::Self::Head do
       @tinyMCE = Card[:tiny_mce]
     end
     it 'should handle tinyMCE configuration errors' do
-
     end
   end
-
 end

data/mod/05_standard/spec/set/self/navbox_spec.rb

@@ -1,7 +1,7 @@
 # -*- encoding : utf-8 -*-
 
 describe Card::Set::Self::Navbox do
-  it "should have a form" do
+  it 'should have a form' do
     assert_view_select render_card(:core, name: '*navbox'), 'form.navbox-form input.navbox'
   end
 end

data/mod/05_standard/spec/set/self/now_spec.rb

@@ -1,7 +1,7 @@
 # -*- encoding : utf-8 -*-
 
 describe Card::Set::Self::Now do
-  it "should have a date" do
-    expect(render_card(:raw, name: '*now').match(/\w+day, \w+ \d+, \d{4}/ )).not_to be_nil
+  it 'should have a date' do
+    expect(render_card(:raw, name: '*now').match(/\w+day, \w+ \d+, \d{4}/)).not_to be_nil
   end
 end

data/mod/05_standard/spec/set/self/signin_spec.rb

@@ -31,7 +31,7 @@ describe Card::Set::Self::Signin do
   end
 
   context '#update' do
-    it 'triggerk signin with valid credentials' do
+    it 'triggers signin with valid credentials' do
       @card.update_attributes! '+*email' => 'joe@admin.com',
                                '+*password' => 'joe_pass'
       expect(Card::Auth.current).to eq(Card['joe admin'])

data/mod/05_standard/spec/set/self/stats_spec.rb

@@ -6,7 +6,7 @@ describe Card::Set::Self::Stats do
       @core = render_card :core, name: :stats
     end
   end
-  it "should render a table" do
+  it 'should render a table' do
     assert_view_select @core, 'table'
   end
 end

data/mod/05_standard/spec/set/self/version_spec.rb

@@ -1,7 +1,7 @@
 # -*- encoding : utf-8 -*-
 
 describe Card::Set::Self::Version do
-  it "should have an X.X.X version" do
-    expect(render_card(:raw, name: '*version') =~ (/\d\.\d+\.\w+/ )).to be_truthy
+  it 'should have an X.X.X version' do
+    expect(render_card(:raw, name: '*version') =~ /\d\.\d+\.\w+/).to be_truthy
   end
 end

data/mod/05_standard/spec/set/type/cardtype_spec.rb

@@ -3,17 +3,16 @@
 describe Card::Set::Type::Cardtype do
   describe 'add_button view' do
     it 'creates link with correct path' do
-      add_link = render_content "{{Basic|add_button}}"
+      add_link = render_content '{{Basic|add_button}}'
       assert_view_select add_link, 'a[href="/new/Basic"]', 'Add Basic'
     end
     it 'handles title argument' do
-      add_link = render_content "{{Basic|add_button;title: custom link text}}"
+      add_link = render_content '{{Basic|add_button;title: custom link text}}'
       assert_view_select add_link, 'a[href="/new/Basic"]', 'custom link text'
     end
     it 'handles params' do
-      add_link = render_content "{{Basic|add_button;params:_project=_self}}"
+      add_link = render_content '{{Basic|add_button;params:_project=_self}}'
       assert_view_select add_link, 'a[href="/new/Basic?_project=Tempo+Rary+2"]'
     end
   end
 end
-

data/mod/05_standard/spec/set/type/date_spec.rb

@@ -1,7 +1,7 @@
 # -*- encoding : utf-8 -*-
 
 describe Card::Set::Type::Date do
-  it "should have special editor" do
+  it 'should have special editor' do
     assert_view_select render_editor('Date'), 'input[class~="date-editor"]'
   end
 end

data/mod/05_standard/spec/set/type/email_template_spec.rb

@@ -44,7 +44,7 @@ describe Card::Set::Type::EmailTemplate do
     end
 
     it 'renders html email if html message given' do
-      @fields = { '+*html_message' =>  'text' }
+      @fields = { '+*html_message' => 'text' }
       expect(content_type).to include 'text/html'
     end
 
@@ -111,7 +111,7 @@ describe Card::Set::Type::EmailTemplate do
       it 'does not render link' do
         is_expected.to include 'Link([[http://wagn.org|Wagn]])'
       end
-      it 'renders inclusion' do
+      it 'renders nest' do
         is_expected.to include 'Inclusion(B)'
       end
     end
@@ -128,7 +128,7 @@ describe Card::Set::Type::EmailTemplate do
       it 'renders link' do
         is_expected.to include 'Link(Wagn[http://wagn.org])'
       end
-      it 'renders inclusion' do
+      it 'renders nest' do
         is_expected.to include 'Inclusion(B)'
       end
     end
@@ -147,7 +147,7 @@ describe Card::Set::Type::EmailTemplate do
         is_expected.to include 'Link(<a target="_blank" class="external-link" '\
                                'href="http://wagn.org">Wagn</a>)'
       end
-      it 'renders inclusion' do
+      it 'renders nest' do
         is_expected.to include 'Inclusion(B)'
       end
       it 'renders absolute urls' do
@@ -183,7 +183,7 @@ describe Card::Set::Type::EmailTemplate do
         Card.create! name: 'default subject', content: 'a very nutty thang',
                      type: 'Phrase'
         Card.create! name: 'subject search+*right+*structure',
-                     content: %{{"referred_to_by":"_left+subject"}},
+                     content: %({"referred_to_by":"_left+subject"}),
                      type: 'Search'
         update_field '*subject', content: '{{+subject search|core;item:core}}'
         expect(subject[:subject]).to eq('a very nutty thang')

data/mod/05_standard/spec/set/type/file_spec.rb

@@ -1,32 +1,35 @@
 # -*- encoding : utf-8 -*-
 
 describe Card::Set::Type::File do
-
-  context "new file card" do
+  context 'new file card' do
     before do
       Card::Auth.as_bot do
-        Card.create name: "file card", type_code: 'file', file: File.new( File.join FIXTURES_PATH, 'file1.txt' )
+        Card.create name: 'file card', type_code: 'file',
+                    file: File.new(File.join(FIXTURES_PATH, 'file1.txt'))
       end
     end
     subject { Card['file card'] }
-    it "stores correct identifier (<card id>/<action id>.<ext>)" do
-      expect(subject.content).to eq "~#{subject.id}/#{subject.last_action_id}.txt"
+    it 'stores correct identifier (<card id>/<action id>.<ext>)' do
+      expect(subject.content)
+        .to eq "~#{subject.id}/#{subject.last_action_id}.txt"
     end
 
-    it "stores file" do
-      expect(subject.file.read.strip).to eq "file1"
+    it 'stores file' do
+      expect(subject.file.read.strip).to eq 'file1'
     end
 
-    it "saves original file name as action comment" do
-      expect(subject.last_action.comment).to eq "file1.txt"
+    it 'saves original file name as action comment' do
+      expect(subject.last_action.comment).to eq 'file1.txt'
     end
 
-    it "has correct original filename" do
-      expect(subject.original_filename).to eq "file1.txt"
+    it 'has correct original filename' do
+      expect(subject.original_filename).to eq 'file1.txt'
     end
 
-    it "has correct url" do
-      expect(subject.file.url).to eq "/files/~#{subject.id}/#{subject.last_action_id}.txt"
+    it 'has correct url' do
+      expect(subject.file.url).to(
+        eq "/files/~#{subject.id}/#{subject.last_action_id}.txt"
+      )
     end
 
     describe '#mod_file?' do
@@ -37,41 +40,60 @@ describe Card::Set::Type::File do
 
     describe 'view: source' do
       it 'renders url' do
-        expect(subject.format.render(:source)).to eq("/files/~#{subject.id}/#{subject.last_action_id}.txt")
+        expect(subject.format.render(:source)).to(
+          eq "/files/~#{subject.id}/#{subject.last_action_id}.txt"
+        )
       end
     end
 
-    context "updated file card" do
+    context 'updated file card' do
       before do
-        subject.update_attributes! file: File.new( File.join FIXTURES_PATH, 'file2.txt' )
+        file = File.new File.join(FIXTURES_PATH, 'file2.txt')
+        subject.update_attributes! file: file
       end
-      it "updates file" do
-        expect(subject.file.read.strip).to eq "file2"
+      it 'updates file' do
+        expect(subject.file.read.strip).to eq 'file2'
       end
 
-      it "updates original file name" do
-        expect(subject.original_filename).to eq "file2.txt"
+      it 'updates original file name' do
+        expect(subject.original_filename).to eq 'file2.txt'
       end
 
-      it "updates url" do
-        expect(subject.file.url).to eq "/files/~#{subject.id}/#{subject.last_action_id}.txt"
+      it 'updates url' do
+        expect(subject.file.url)
+          .to eq "/files/~#{subject.id}/#{subject.last_action_id}.txt"
       end
     end
 
     context 'subcards' do
       it 'handles file subcards' do
-        Card.create! name: 'new card with file', subcards: {'+my file'=>{content: 'ignore content', type_id: Card::FileID, file: File.open(File.join(FIXTURES_PATH, 'file1.txt'))}}
-        expect(Card['new card with file+my file'].file.file.read.strip).to eq 'file1'
+        file = File.open(File.join(FIXTURES_PATH, 'file1.txt'))
+        Card.create! name: 'new card with file',
+                     subcards: {
+                       '+my file' => {
+                         content: 'ignore content',
+                         type_id: Card::FileID,
+                         file: file
+                       }
+                     }
+        expect(Card['new card with file+my file'].file.file.read.strip)
+          .to eq 'file1'
       end
-
     end
   end
 
+  it 'creates empty file card without content' do
+    card = Card.create name: 'hide and seek', type_id: Card::FileID
+    expect(card.content).to eq('')
+  end
+
   it 'handles urls' do
-    url = 'http://wagn.org/files/bruce_logo-large-122798.png'
+    # wagn.org is down so we need another url
+    # url = 'http://wagn.org/files/bruce_logo-large-122798.png'
+    url = 'http://www.lcdmedia.de/UserFiles/Image/pages/reparatur/beamer_test.jpg'
+
     Card.create! name: 'url test', type_id: Card::FileID, remote_file_url: url
     expect(Card['url test'].file.size).to be > 0
-    expect(Card['url test'].file.url).to match /\.png$/
+    expect(Card['url test'].file.url).to match(/\.jpg$/)
   end
-
 end