capybara 3.2.1 → 3.3.0

data/spec/minitest_spec_spec.rb

@@ -11,6 +11,7 @@ class MinitestSpecTest < Minitest::Spec
   before do
     visit('/form')
   end
+
   after do
     Capybara.reset_sessions!
   end
@@ -115,6 +116,12 @@ class MinitestSpecTest < Minitest::Spec
   it "handles failures" do
     page.must_have_select('non_existing_form_title')
   end
+
+  it "supports style expectations" do
+    skip "Rack test doesn't support style" if Capybara.current_driver == :rack_test
+    visit('/with_html')
+    find(:css, '#second').must_have_style('display' => 'inline')
+  end
 end
 
 RSpec.describe 'capybara/minitest/spec' do
@@ -129,7 +136,7 @@ RSpec.describe 'capybara/minitest/spec' do
     reporter.start
     MinitestSpecTest.run reporter, {}
     reporter.report
-    expect(output.string).to include("18 runs, 41 assertions, 1 failures, 0 errors, 0 skips")
+    expect(output.string).to include("19 runs, 41 assertions, 1 failures, 0 errors, 1 skips")
     # Make sure error messages are displayed
     expect(output.string).to include('expected to find visible select box "non_existing_form_title" that is not disabled but there were no matches')
   end

data/spec/rack_test_spec.rb

@@ -16,6 +16,8 @@ skipped_tests = %i[
   server
   hover
   about_scheme
+  download
+  css
 ]
 Capybara::SpecHelper.run_specs TestSessions::RackTest, "RackTest", capybara_skip: skipped_tests
 
@@ -125,6 +127,14 @@ RSpec.describe Capybara::Session do # rubocop:disable RSpec/MultipleDescribes
         expect(normal.text).to eq 'banana'
       end
     end
+
+    describe '#style' do
+      it "should raise an error" do
+        @session.visit('/with_html')
+        el = @session.find(:css, '#first')
+        expect { el.style('display') }.to raise_error NotImplementedError, /not process CSS/
+      end
+    end
   end
 end
 

data/spec/rspec/shared_spec_matchers.rb

@@ -324,6 +324,7 @@ RSpec.shared_examples Capybara::RSpecMatchers do |session, _mode|
 
         context "with default selector CSS" do
           before { Capybara.default_selector = :css }
+
           it "fails if has_content? returns false" do
             expect do
               expect(page).to have_content('No such Text')
@@ -459,6 +460,7 @@ RSpec.shared_examples Capybara::RSpecMatchers do |session, _mode|
 
         context "with default selector CSS" do
           before { Capybara.default_selector = :css }
+
           it "fails if has_text? returns false" do
             expect do
               expect(page).to have_text('No such Text')

data/spec/selenium_spec_chrome.rb

@@ -11,6 +11,34 @@ CHROME_DRIVER = ENV['HEADLESS'] ? :selenium_chrome_headless : :selenium_chrome
 #   Selenium::WebDriver::Chrome.path='/usr/bin/google-chrome-beta'
 # end
 
+Capybara.register_driver :selenium_chrome do |app|
+  driver = Capybara::Selenium::Driver.new(app, browser: :chrome)
+  # TODO: Fix this when selenium with `download_path =` support is released
+  bridge = driver.browser.send(:bridge)
+  params = { cmd: 'Page.setDownloadBehavior', params: { behavior: 'allow', downloadPath: Capybara.save_path } }
+  command = +'/session/:session_id/chromium/send_command'
+  command[':session_id'] = bridge.session_id
+  bridge.http.call(:post, command, params)
+
+  driver
+end
+
+Capybara.register_driver :selenium_chrome_headless do |app|
+  browser_options = ::Selenium::WebDriver::Chrome::Options.new
+  browser_options.args << '--headless'
+  browser_options.args << '--disable-gpu' if Gem.win_platform?
+  driver = Capybara::Selenium::Driver.new(app, browser: :chrome, options: browser_options)
+
+  # TODO: Fix this when selenium with `download_path =` support is released
+  bridge = driver.browser.send(:bridge)
+  params = { cmd: 'Page.setDownloadBehavior', params: { behavior: 'allow', downloadPath: Capybara.save_path } }
+  command = +'/session/:session_id/chromium/send_command'
+  command[':session_id'] = bridge.session_id
+  bridge.http.call(:post, command, params)
+
+  driver
+end
+
 Capybara.register_driver :selenium_chrome_clear_storage do |app|
   chrome_options = {
     browser: :chrome,

data/spec/selenium_spec_chrome_remote.rb

@@ -39,7 +39,7 @@ module TestSessions
   Chrome = Capybara::Session.new(CHROME_REMOTE_DRIVER, TestApp)
 end
 
-skipped_tests = %i[response_headers status_code trigger]
+skipped_tests = %i[response_headers status_code trigger download]
 # skip window tests when headless for now - closing a window not supported by chromedriver/chrome
 skipped_tests << :windows if ENV['TRAVIS'] && (ENV['SKIP_WINDOW'] || ENV['HEADLESS'])
 
@@ -51,6 +51,6 @@ RSpec.describe "Capybara::Session with chrome" do
   include_examples  Capybara::RSpecMatchers, TestSessions::Chrome, CHROME_REMOTE_DRIVER
 
   it 'is considered to be chrome' do
-    expect(session.driver).to be_chrome
+    expect(session.driver.send(:chrome?)).to be_truthy
   end
 end

data/spec/selenium_spec_marionette.rb

@@ -10,13 +10,19 @@ browser_options.args << '--headless' if ENV['HEADLESS']
 browser_options.add_preference 'dom.file.createInChild', true
 # browser_options.add_option("log", {"level": "trace"})
 
+browser_options.profile = Selenium::WebDriver::Firefox::Profile.new.tap do |profile|
+  profile['browser.download.dir'] = Capybara.save_path
+  profile['browser.download.folderList'] = 2
+  profile['browser.helperApps.neverAsk.saveToDisk'] = 'text/csv'
+end
+
 Capybara.register_driver :selenium_marionette do |app|
   # ::Selenium::WebDriver.logger.level = "debug"
   Capybara::Selenium::Driver.new(
     app,
     browser: :firefox,
     desired_capabilities: { marionette: true, 'moz:webdriverClick': true },
-    options: browser_options
+    options: browser_options,
     # Get a trace level log from geckodriver
     # :driver_opts => { args: ['-vv'] }
   )
@@ -67,6 +73,7 @@ RSpec.describe Capybara::Selenium::Driver do
       before do
         @original_browser = @driver.browser
       end
+
       after do
         # Ensure browser is actually quit so we don't leave hanging processe
         RSpec::Mocks.space.proxy_for(@original_browser).reset
@@ -145,3 +152,16 @@ RSpec.describe Capybara::Selenium::Driver do
     end
   end
 end
+
+RSpec.describe Capybara::Selenium::Node do
+  context "#click" do
+    it "warns when attempting on a table row" do
+      session = TestSessions::SeleniumMarionette
+      session.visit('/tables')
+      tr = session.find(:css, '#agent_table tr:first-child')
+      allow(tr.base).to receive(:warn)
+      tr.click
+      expect(tr.base).to have_received(:warn).with(/Clicking the first cell in the row instead/)
+    end
+  end
+end

data/spec/server_spec.rb

@@ -219,7 +219,6 @@ RSpec.describe Capybara::Server do
     it "should attempt an HTTPS connection if HTTP connection returns #{err}" do
       app = -> { [200, {}, ['Hello, world']] }
       ordered_errors = [Errno::ECONNREFUSED, err]
-      # allow(Net::HTTP).to receive(:start).with(anything, anything, hash_excluding(:use_ssl)).and_yield { raise Errno::ECONNREFUSED }
       allow(Net::HTTP).to receive(:start).with(anything, anything, hash_excluding(:use_ssl)) do
         raise ordered_errors.shift
       end

data/spec/shared_selenium_session.rb

@@ -180,7 +180,22 @@ RSpec.shared_examples "Capybara::Session" do |session, mode|
         # this is here because it is testing for an XPath that is specific to the algorithm used in the selenium driver
         session.visit('/path')
         element = session.find(:link, 'Second Link')
-        expect(element.path).to eq('/html/body/div[2]/a[1]')
+        expect(element.path).to eq('/HTML/BODY/DIV[2]/A[1]')
+      end
+
+      it "handles namespaces" do
+        session.visit "/with_namespace"
+        rect = session.find(:css, "div svg rect")
+        expect(rect.path).to eq("/HTML/BODY/DIV/./*[((local-name(.) = 'svg') and (namespace-uri(.) = 'http://www.w3.org/2000/svg'))]/./*[((local-name(.) = 'rect') and (namespace-uri(.) = 'http://www.w3.org/2000/svg'))][1]")
+        expect(session.find(:xpath, rect.path)).to eq rect
+      end
+
+      it "handles case sensitive element names" do
+        session.visit "/with_namespace"
+        els = session.all(:css, "div *", visible: :all)
+        expect { els.map(&:path) }.not_to raise_error
+        lg = session.find(:css, "div linearGradient", visible: :all)
+        expect(session.find(:xpath, lg.path, visible: :all)).to eq lg
       end
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: capybara
 version: !ruby/object:Gem::Version
-  version: 3.2.1
+  version: 3.3.0
 platform: ruby
 authors:
 - Thomas Walpole
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain:
 - gem-public_cert.pem
-date: 2018-06-04 00:00:00.000000000 Z
+date: 2018-06-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -212,28 +212,16 @@ dependencies:
   name: selenium-webdriver
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '3.0'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '4.0'
-    - - "!="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.4.1
+        version: '3.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '3.0'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '4.0'
-    - - "!="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.4.1
+        version: '3.5'
 - !ruby/object:Gem::Dependency
   name: sinatra
   requirement: !ruby/object:Gem::Requirement
@@ -297,6 +285,7 @@ files:
 - lib/capybara/queries/match_query.rb
 - lib/capybara/queries/selector_query.rb
 - lib/capybara/queries/sibling_query.rb
+- lib/capybara/queries/style_query.rb
 - lib/capybara/queries/text_query.rb
 - lib/capybara/queries/title_query.rb
 - lib/capybara/rack_test/browser.rb
@@ -320,9 +309,13 @@ files:
 - lib/capybara/selector/filters/node_filter.rb
 - lib/capybara/selector/selector.rb
 - lib/capybara/selenium/driver.rb
+- lib/capybara/selenium/driver_specializations/chrome_driver.rb
+- lib/capybara/selenium/driver_specializations/marionette_driver.rb
 - lib/capybara/selenium/node.rb
+- lib/capybara/selenium/nodes/marionette_node.rb
 - lib/capybara/server.rb
 - lib/capybara/server/animation_disabler.rb
+- lib/capybara/server/checker.rb
 - lib/capybara/server/middleware.rb
 - lib/capybara/session.rb
 - lib/capybara/session/config.rb
@@ -342,6 +335,7 @@ files:
 - lib/capybara/spec/session/assert_all_of_selectors_spec.rb
 - lib/capybara/spec/session/assert_current_path_spec.rb
 - lib/capybara/spec/session/assert_selector_spec.rb
+- lib/capybara/spec/session/assert_style_spec.rb
 - lib/capybara/spec/session/assert_text_spec.rb
 - lib/capybara/spec/session/assert_title_spec.rb
 - lib/capybara/spec/session/attach_file_spec.rb
@@ -384,6 +378,7 @@ files:
 - lib/capybara/spec/session/has_none_selectors_spec.rb
 - lib/capybara/spec/session/has_select_spec.rb
 - lib/capybara/spec/session/has_selector_spec.rb
+- lib/capybara/spec/session/has_style_spec.rb
 - lib/capybara/spec/session/has_table_spec.rb
 - lib/capybara/spec/session/has_text_spec.rb
 - lib/capybara/spec/session/has_title_spec.rb
@@ -443,6 +438,7 @@ files:
 - lib/capybara/spec/views/with_html.erb
 - lib/capybara/spec/views/with_html_entities.erb
 - lib/capybara/spec/views/with_js.erb
+- lib/capybara/spec/views/with_namespace.erb
 - lib/capybara/spec/views/with_scope.erb
 - lib/capybara/spec/views/with_simple_html.erb
 - lib/capybara/spec/views/with_slow_unload.erb
@@ -454,6 +450,7 @@ files:
 - lib/capybara/window.rb
 - spec/basic_node_spec.rb
 - spec/capybara_spec.rb
+- spec/css_splitter_spec.rb
 - spec/dsl_spec.rb
 - spec/filter_set_spec.rb
 - spec/fixtures/capybara.csv
@@ -485,7 +482,9 @@ files:
 homepage: https://github.com/teamcapybara/capybara
 licenses:
 - MIT
-metadata: {}
+metadata:
+  changelog_uri: https://github.com/teamcapybara/capybara/blob/master/History.md
+  source_code_uri: https://github.com/teamcapybara/capybara
 post_install_message: 
 rdoc_options: []
 require_paths: