capybara 3.2.1 → 3.3.0

data/lib/capybara/spec/session/node_spec.rb

@@ -51,6 +51,17 @@ Capybara::SpecHelper.spec "node" do
     end
   end
 
+  describe "#style", requires: [:css] do
+    it "should return the computed style value" do
+      expect(@session.find(:css, '#first').style('display')).to eq('display' => 'block')
+      expect(@session.find(:css, '#second').style(:display)).to eq('display' => 'inline')
+    end
+
+    it "should return multiple style values" do
+      expect(@session.find(:css, '#first').style('display', :'line-height')).to eq('display' => 'block', 'line-height' => '25px')
+    end
+  end
+
   describe "#value" do
     it "should allow retrieval of the value" do
       expect(@session.find('//textarea[@id="normal"]').value).to eq('banana')
@@ -185,6 +196,7 @@ Capybara::SpecHelper.spec "node" do
         expect(@session.find('//option', text: 'Disabled Child Option')).to be_disabled
       end
     end
+
     it "should be boolean" do
       @session.visit('/form')
       expect(@session.find('//select[@id="form_disabled_select"]/option').disabled?).to be true
@@ -370,6 +382,12 @@ Capybara::SpecHelper.spec "node" do
       expect(locations[:x].to_f).to be_within(1).of(5)
       expect(locations[:y].to_f).to be_within(1).of(5)
     end
+
+    it "should be able to click a table row", requires: [:js] do
+      @session.visit('/tables')
+      tr = @session.find(:css, '#agent_table tr:first-child').click
+      expect(tr).to have_css('label', text: 'Clicked')
+    end
   end
 
   describe '#double_click', requires: [:js] do
@@ -497,9 +515,25 @@ Capybara::SpecHelper.spec "node" do
     end
   end
 
+  describe "#evaluate_async_script", requires: %i[js es_args] do
+    it "should evaluate the given script in the context of the element" do
+      @session.visit('/with_js')
+      el = @session.find(:css, '#with_change_event')
+      expect(el.evaluate_async_script("arguments[0](this.value)")).to eq('default value')
+    end
+
+    it "should support returning elements after asynchronous operation" do
+      @session.visit('/with_js')
+      change = @session.find(:css, '#change') # ensure page has loaded and element is available
+      el = change.evaluate_async_script("var cb = arguments[0]; setTimeout(function(el){ cb(el) }, 100, this)")
+      expect(el).to eq(change)
+    end
+  end
+
   describe '#reload', requires: [:js] do
     context "without automatic reload" do
       before { Capybara.automatic_reload = false }
+
       it "should reload the current context of the node" do
         @session.visit('/with_js')
         node = @session.find(:css, '#reload-me')

data/lib/capybara/spec/session/save_page_spec.rb

@@ -3,11 +3,13 @@
 Capybara::SpecHelper.spec '#save_page' do
   let(:alternative_path) { File.join(Dir.pwd, "save_and_open_page_tmp") }
   before do
+    @old_save_path = Capybara.save_path
+    Capybara.save_path = nil
     @session.visit("/foo")
   end
 
   after do
-    Capybara.save_path = nil
+    Capybara.save_path = @old_save_path
     Dir.glob("capybara-*.html").each do |file|
       FileUtils.rm(file)
     end
@@ -67,6 +69,7 @@ Capybara::SpecHelper.spec '#save_page' do
 
   context "asset_host contains a string" do
     before { Capybara.asset_host = "http://example.com" }
+
     after { Capybara.asset_host = nil }
 
     it "prepends base tag with value from asset_host to the head" do

data/lib/capybara/spec/session/save_screenshot_spec.rb

@@ -3,11 +3,13 @@
 Capybara::SpecHelper.spec '#save_screenshot', requires: [:screenshot] do
   let(:alternative_path) { File.join(Dir.pwd, "save_screenshot_tmp") }
   before do
+    @old_save_path = Capybara.save_path
+    Capybara.save_path = nil
     @session.visit '/foo'
   end
 
   after do
-    Capybara.save_path = nil
+    Capybara.save_path = @old_save_path
     FileUtils.rm_rf alternative_path
   end
 

data/lib/capybara/spec/session/text_spec.rb

@@ -44,6 +44,7 @@ Capybara::SpecHelper.spec '#text' do
 
   context "with css as default selector" do
     before { Capybara.default_selector = :css }
+
     it "should print the text of the page" do
       @session.visit('/with_simple_html')
       expect(@session.text).to eq('Bar')

data/lib/capybara/spec/session/title_spec.rb

@@ -8,6 +8,7 @@ Capybara::SpecHelper.spec '#title' do
 
   context "with css as default selector" do
     before { Capybara.default_selector = :css }
+
     it "should get the title of the page" do
       @session.visit('/with_title')
       expect(@session.title).to eq('Test Title')

data/lib/capybara/spec/session/window/current_window_spec.rb

@@ -5,6 +5,7 @@ Capybara::SpecHelper.spec '#current_window', requires: [:windows] do
     @window = @session.current_window
     @session.visit('/with_windows')
   end
+
   after do
     (@session.windows - [@window]).each do |w|
       @session.switch_to_window w

data/lib/capybara/spec/session/window/open_new_window_spec.rb

@@ -5,6 +5,7 @@ Capybara::SpecHelper.spec '#open_new_window', requires: [:windows] do
     @window = @session.current_window
     @session.visit('/with_windows')
   end
+
   after do
     (@session.windows - [@window]).each do |w|
       @session.switch_to_window w

data/lib/capybara/spec/session/window/window_opened_by_spec.rb

@@ -6,6 +6,7 @@ Capybara::SpecHelper.spec '#window_opened_by', requires: [:windows] do
     @session.visit('/with_windows')
     @session.assert_selector(:css, 'body.loaded')
   end
+
   after do
     (@session.windows - [@window]).each do |w|
       @session.switch_to_window w

data/lib/capybara/spec/session/window/window_spec.rb

@@ -5,6 +5,7 @@ Capybara::SpecHelper.spec Capybara::Window, requires: [:windows] do
     @window = @session.current_window
     @session.visit('/with_windows')
   end
+
   after do
     (@session.windows - [@window]).each do |w|
       @session.switch_to_window w
@@ -112,6 +113,7 @@ Capybara::SpecHelper.spec Capybara::Window, requires: [:windows] do
     before do
       @initial_size = @session.current_window.size
     end
+
     after do
       @session.current_window.resize_to(*@initial_size)
       sleep 0.5
@@ -143,6 +145,7 @@ Capybara::SpecHelper.spec Capybara::Window, requires: [:windows] do
     before do
       @initial_size = @session.current_window.size
     end
+
     after do
       @session.current_window.resize_to(*@initial_size)
       sleep 0.5
@@ -181,4 +184,21 @@ Capybara::SpecHelper.spec Capybara::Window, requires: [:windows] do
       expect(ow_height).to be > 300
     end
   end
+
+  describe '#fullscreen' do
+    before do
+      @initial_size = @session.current_window.size
+    end
+
+    after do
+      @session.current_window.resize_to(*@initial_size)
+      sleep 0.5
+    end
+
+    it "should be able to fullscreen the window" do
+      expect do
+        @session.current_window.fullscreen
+      end.not_to raise_error
+    end
+  end
 end

data/lib/capybara/spec/session/window/windows_spec.rb

@@ -10,6 +10,7 @@ Capybara::SpecHelper.spec '#windows', requires: [:windows] do
       raise Capybara::CapybaraError if @session.windows.size != 3
     end
   end
+
   after do
     (@session.windows - [@window]).each(&:close)
     @session.switch_to_window(@window)

data/lib/capybara/spec/session/window/within_window_spec.rb

@@ -10,6 +10,7 @@ Capybara::SpecHelper.spec '#within_window', requires: [:windows] do
       raise Capybara::CapybaraError if @session.windows.size != 3
     end
   end
+
   after do
     (@session.windows - [@window]).each do |w|
       @session.switch_to_window w

data/lib/capybara/spec/session/within_spec.rb

@@ -59,6 +59,7 @@ Capybara::SpecHelper.spec '#within' do
 
   context "with the default selector set to CSS" do
     before { Capybara.default_selector = :css }
+
     it "should use CSS" do
       @session.within("#for_bar li", text: 'With Simple HTML') do
         @session.click_link('Go')

data/lib/capybara/spec/spec_helper.rb

@@ -7,6 +7,8 @@ require "capybara/rspec" # Required here instead of in rspec_spec to avoid RSpec
 require "capybara/spec/test_app"
 require "nokogiri"
 
+Capybara.save_path = File.join(Dir.pwd, 'save_path_tmp')
+
 module Capybara
   module SpecHelper
     class << self
@@ -15,7 +17,7 @@ module Capybara
         config.before { Capybara::SpecHelper.reset! }
         config.after { Capybara::SpecHelper.reset! }
         # Test in 3.5+ where metadata doesn't autotrigger shared context inclusion - will be only behavior in RSpec 4
-        config.shared_context_metadata_behavior = :apply_to_host_groups if RSpec::Core::Version::STRING.to_f >= 3.5
+        config.shared_context_metadata_behavior = :apply_to_host_groups if config.respond_to?(:shared_context_metadata_behavior=)
       end
 
       def reset!

data/lib/capybara/spec/test_app.rb

@@ -38,6 +38,14 @@ class TestApp < Sinatra::Base
     redirect '/landed'
   end
 
+  post '/redirect_307' do
+    redirect '/landed', 307
+  end
+
+  post '/redirect_308' do
+    redirect '/landed', 308
+  end
+
   get '/referer_base' do
     '<a href="/get_referer">direct link</a>' \
     '<a href="/redirect_to_get_referer">link via redirect</a>' \
@@ -69,6 +77,10 @@ class TestApp < Sinatra::Base
     "You landed"
   end
 
+  post '/landed' do
+    "You post landed: #{params.dig(:form, 'data')}"
+  end
+
   get '/with-quotes' do
     %q("No," he said, "you can't do that.")
   end
@@ -153,6 +165,12 @@ class TestApp < Sinatra::Base
     HTML
   end
 
+  get '/download.csv' do
+    content_type "text/csv"
+    'This, is, comma, separated' \
+    'Thomas, Walpole, was , here'
+  end
+
   get '/:view' do |view|
     erb view.to_sym, locals: { referrer: request.referrer }
   end

data/lib/capybara/spec/views/form.erb

@@ -552,6 +552,14 @@ New line after and before textarea tag
   <p>
     <input type="submit" value="Go FAR"/>
   </p>
+
+  <input type="hidden" name="form[data]" value="TWTW"/>
+  <p>
+    <button formaction='/redirect_307'>Go 307</button>
+  </p>
+  <p>
+    <button formaction='/redirect_308'>Go 308</button>
+  </p>
 </form>
 
 <form action="/form" method="post">

data/lib/capybara/spec/views/tables.erb

@@ -3,7 +3,7 @@
   <table id="agent_table">
     <caption>Agent</caption>
 
-    <tr>
+    <tr onclick="this.querySelector('td label').innerHTML = 'Clicked'">
       <td>
         <label for="form_agent_name">Name</label>
       </td>

data/lib/capybara/spec/views/with_html.erb

@@ -1,4 +1,8 @@
 
+<style>
+  p { display: block; }
+</style>
+
 <div id="referrer"><%= referrer %></div>
 <h1>This is a test</h1>
 
@@ -13,7 +17,7 @@
 <span class="number">42</span>
 <span>Other span</span>
 
-<p class="para" id="first" data-random="abc\def">
+<p class="para" id="first" data-random="abc\def" style="line-height: 25px;">
   Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod
   tempor incididunt ut <a href="/with_simple_html" title="awesome title" class="simple">labore</a>
   et dolore magna aliqua. Ut enim ad minim veniam,
@@ -22,7 +26,7 @@
   <a href="/with_simple_html" aria-label="Go to simple"><img id="first_image" width="20" height="20" alt="awesome image" /></a>
 </p>
 
-<p class="para" id="second">
+<p class="para" id="second" style="display: inline;">
   Duis aute irure dolor in reprehenderit in voluptate velit esse cillum
   dolore eu fugiat <a href="/redirect" id="red">Redirect</a> pariatur. Excepteur sint occaecat cupidatat non proident,
   sunt in culpa qui officia
@@ -173,3 +177,6 @@ banana</textarea>
 <div id="ws">
 &#x20;&#x1680;&#x2000;&#x2001;&#x2002; &#x2003;&#x2004;&nbsp;&#x2005; &#x2006;&#x2007;&#x2008;&#x2009;&#x200A;&#x202F;&#x205F;&#x3000;
 </div>
+
+<a href="/download.csv" download>Download Me</a>
+<a href="/download.csv" download="other.csv">Download Other</a>

data/lib/capybara/spec/views/with_js.erb

@@ -72,6 +72,10 @@
       <a href="#" id="change-title">Change title</a>
     </p>
 
+    <p>
+      <a href="#" id="change-size">Change size</a>
+    </p>
+
     <p id="click-test">Click me</p>
 
     <p>

data/lib/capybara/spec/views/with_namespace.erb

@@ -0,0 +1,20 @@
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <title>Namespace</title>
+  </head>
+  <body id="body">
+    <div>
+      <svg xmlns="http://www.w3.org/2000/svg" version="1.1"
+        viewBox="0 0 100 100" preserveAspectRatio="xMidYMid slice"
+        style="width:100%; height:100%; position:absolute; top:0; left:0; z-index:-1;">
+        <linearGradient id="gradient">
+          <stop class="begin" offset="0%"/>
+          <stop class="end" offset="100%"/>
+        </linearGradient>
+        <rect x="0" y="0" width="100" height="100" style="fill:url(#gradient)" />
+        <rect x="150" y="150" width="25" height="25" style="fill:url(#gradient)" />
+        <circle cx="50" cy="50" r="30" style="fill:url(#gradient)" />
+      </svg>
+    <div>
+  </body>
+</html>

data/lib/capybara/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Capybara
-  VERSION = '3.2.1'
+  VERSION = '3.3.0'
 end

data/lib/capybara/window.rb

@@ -101,6 +101,17 @@ module Capybara
       wait_for_stable_size { @driver.maximize_window(handle) }
     end
 
+    ##
+    # Fullscreen window.
+    #
+    # If a particular driver doesn't have concept of fullscreen it may not support this method.
+    #
+    # @macro about_current
+    #
+    def fullscreen
+      @driver.fullscreen_window(handle)
+    end
+
     def eql?(other)
       other.is_a?(self.class) && @session == other.session && @handle == other.handle
     end

data/spec/css_splitter_spec.rb

@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe Capybara::Selector::CSS::Splitter do
+  let :splitter do
+    ::Capybara::Selector::CSS::Splitter.new
+  end
+
+  context "split not needed" do
+    it "normal CSS selector" do
+      css = 'div[id="abc"]'
+      expect(splitter.split(css)).to eq [css]
+    end
+
+    it "comma in strings" do
+      css = 'div[id="a,bc"]'
+      expect(splitter.split(css)).to eq [css]
+    end
+
+    it "comma in pseudo-selector" do
+      css = 'div.class1:not(.class1, .class2)'
+      expect(splitter.split(css)).to eq [css]
+    end
+  end
+
+  context "split needed" do
+    it "root level comma" do
+      css = 'div.class1, span, p.class2'
+      expect(splitter.split(css)).to eq ['div.class1', 'span', 'p.class2']
+    end
+
+    it "root level comma when quotes and pseudo selectors" do
+      css = 'div.class1[id="abc\\"def,ghi"]:not(.class3, .class4), span[id=\'a"c\\\'de\'], section, #abc\\,def'
+      expect(splitter.split(css)).to eq ['div.class1[id="abc\\"def,ghi"]:not(.class3, .class4)', 'span[id=\'a"c\\\'de\']', 'section', '#abc\\,def']
+    end
+  end
+end

data/spec/dsl_spec.rb

@@ -8,7 +8,7 @@ class TestClass
 end
 
 Capybara::SpecHelper.run_specs TestClass.new, "DSL", capybara_skip: %i[
-  js modals screenshot frames windows send_keys server hover about_scheme psc
+  js modals screenshot frames windows send_keys server hover about_scheme psc download css
 ]
 
 RSpec.describe Capybara::DSL do

data/spec/minitest_spec.rb

@@ -112,6 +112,12 @@ class MinitestTest < Minitest::Test
     assert_matches_xpath(find(:select, 'form_title'), './/select[@id="form_title"]')
     refute_matches_xpath(find(:select, 'form_title'), './/select[@id="form_other_title"]')
   end
+
+  def test_assert_style
+    skip "Rack test doesn't support style" if Capybara.current_driver == :rack_test
+    visit('/with_html')
+    assert_style(find(:css, '#second'), display: 'inline')
+  end
 end
 
 RSpec.describe 'capybara/minitest' do
@@ -126,6 +132,6 @@ RSpec.describe 'capybara/minitest' do
     reporter.start
     MinitestTest.run reporter, {}
     reporter.report
-    expect(output.string).to include("17 runs, 44 assertions, 0 failures, 0 errors, 0 skips")
+    expect(output.string).to include("18 runs, 44 assertions, 0 failures, 0 errors, 1 skips")
   end
 end