capybara 3.2.1 → 3.3.0

data/lib/capybara/selenium/driver_specializations/marionette_driver.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+require 'capybara/selenium/nodes/marionette_node'
+
+module Capybara::Selenium::Driver::MarionetteDriver
+  def resize_window_to(handle, width, height)
+    within_given_window(handle) do
+      # Don't set the size if already set - See https://github.com/mozilla/geckodriver/issues/643
+      if window_size(handle) == [width, height]
+        {}
+      else
+        super
+      end
+    end
+  end
+
+  def reset!
+    # Use instance variable directly so we avoid starting the browser just to reset the session
+    return unless @browser
+
+    switch_to_window(window_handles.first)
+    window_handles.slice(1..-1).each { |win| close_window(win) }
+    super
+  end
+
+private
+
+  def build_node(native_node)
+    ::Capybara::Selenium::MarionetteNode.new(self, native_node)
+  end
+end

data/lib/capybara/selenium/node.rb

@@ -28,6 +28,12 @@ class Capybara::Selenium::Node < Capybara::Driver::Node
     end
   end
 
+  def style(styles)
+    styles.each_with_object({}) do |style, result|
+      result[style] = native.css_value(style)
+    end
+  end
+
   ##
   #
   # Set the value of the form element to the given value.
@@ -91,6 +97,7 @@ class Capybara::Selenium::Node < Capybara::Driver::Node
        e.message =~ /Other element would receive the click/
       scroll_to_center
     end
+
     raise e
   end
 
@@ -133,18 +140,7 @@ class Capybara::Selenium::Node < Capybara::Driver::Node
   alias :checked? :selected?
 
   def disabled?
-    return true unless native.enabled?
-
-    # workaround for selenium-webdriver/geckodriver reporting elements as enabled when they are nested in disabling elements
-    if driver.marionette?
-      if %w[option optgroup].include? tag_name
-        find_xpath("parent::*[self::optgroup or self::select]")[0].disabled?
-      else
-        !find_xpath("parent::fieldset[@disabled] | ancestor::*[not(self::legend) or preceding-sibling::legend][parent::fieldset[@disabled]]").empty?
-      end
-    else
-      false
-    end
+    !native.enabled?
   end
 
   def content_editable?
@@ -167,9 +163,15 @@ class Capybara::Selenium::Node < Capybara::Driver::Node
     path = find_xpath(XPath.ancestor_or_self).reverse
 
     result = []
+    default_ns = path.last[:namespaceURI]
     while (node = path.shift)
       parent = path.first
-      selector = node.tag_name
+      selector = node[:tagName]
+      if node[:namespaceURI] != default_ns
+        selector = XPath.child.where((XPath.local_name == selector) & (XPath.namespace_uri == node[:namespaceURI])).to_s
+        selector
+      end
+
       if parent
         siblings = parent.find_xpath(selector)
         selector += "[#{siblings.index(node) + 1}]" unless siblings.size == 1
@@ -265,17 +267,12 @@ private
         arguments[0].dispatchEvent(new InputEvent('input'));
         arguments[0].dispatchEvent(new Event('change', { bubbles: true }));
       }
-      JS
+    JS
   end
 
   def set_file(value) # rubocop:disable Naming/AccessorMethodName
     path_names = value.to_s.empty? ? [] : value
-    if driver.marionette?
-      native.clear
-      Array(path_names).each { |p| native.send_keys(p) }
-    else
-      native.send_keys(Array(path_names).join("\n"))
-    end
+    native.send_keys(Array(path_names).join("\n"))
   end
 
   def set_content_editable(value) # rubocop:disable Naming/AccessorMethodName

data/lib/capybara/selenium/nodes/marionette_node.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+class Capybara::Selenium::MarionetteNode < Capybara::Selenium::Node
+  def click(keys = [], **options)
+    super
+  rescue ::Selenium::WebDriver::Error::ElementNotInteractableError
+    if tag_name == "tr"
+      warn "You are attempting to click a table row which has issues in geckodriver/marionette - see https://github.com/mozilla/geckodriver/issues/1228. " \
+           "Your test should probably be clicking on a table cell like a user would. Clicking the first cell in the row instead."
+      return find_css('th:first-child,td:first-child')[0].click
+    end
+    raise
+  end
+
+  def disabled?
+    return true if super
+
+    # workaround for selenium-webdriver/geckodriver reporting elements as enabled when they are nested in disabling elements
+    if %w[option optgroup].include? tag_name
+      find_xpath("parent::*[self::optgroup or self::select]")[0].disabled?
+    else
+      !find_xpath("parent::fieldset[@disabled] | ancestor::*[not(self::legend) or preceding-sibling::legend][parent::fieldset[@disabled]]").empty?
+    end
+  end
+
+  def set_file(value) # rubocop:disable Naming/AccessorMethodName
+    path_names = value.to_s.empty? ? [] : value
+    native.clear
+    Array(path_names).each { |p| native.send_keys(p) }
+  end
+end

data/lib/capybara/server.rb

@@ -5,6 +5,7 @@ require 'net/http'
 require 'rack'
 require 'capybara/server/middleware'
 require 'capybara/server/animation_disabler'
+require 'capybara/server/checker'
 
 module Capybara
   class Server
@@ -23,10 +24,10 @@ module Capybara
       @server_thread = nil # suppress warnings
       @host = deprecated_options[1] || host
       @reportable_errors = deprecated_options[2] || reportable_errors
-      @using_ssl = false
       @port = deprecated_options[0] || port
       @port ||= Capybara::Server.ports[port_key]
       @port ||= find_available_port(host)
+      @checker = Checker.new(@host, @port)
     end
 
     def reset_error!
@@ -38,22 +39,12 @@ module Capybara
     end
 
     def using_ssl?
-      @using_ssl
+      @checker.ssl?
     end
 
     def responsive?
       return false if @server_thread&.join(0)
-
-      begin
-        res = if !using_ssl?
-          http_connect
-        else
-          https_connect
-        end
-      rescue EOFError, Net::ReadTimeout
-        res = https_connect
-        @using_ssl = true
-      end
+      res = @checker.request { |http| http.get('/__identify__') }
 
       if res.is_a?(Net::HTTPSuccess) || res.is_a?(Net::HTTPRedirection)
         return res.body == app.object_id.to_s
@@ -63,11 +54,9 @@ module Capybara
     end
 
     def wait_for_pending_requests
-      start_time = Capybara::Helpers.monotonic_time
+      timer = Capybara::Helpers.timer(expire_in: 60)
       while pending_requests?
-        if (Capybara::Helpers.monotonic_time - start_time) > 60
-          raise "Requests did not finish in 60 seconds"
-        end
+        raise "Requests did not finish in 60 seconds" if timer.expired?
         sleep 0.01
       end
     end
@@ -80,11 +69,9 @@ module Capybara
           Capybara.server.call(middleware, port, host)
         end
 
-        start_time = Capybara::Helpers.monotonic_time
+        timer = Capybara::Helpers.timer(expire_in: 60)
         until responsive?
-          if (Capybara::Helpers.monotonic_time - start_time) > 60
-            raise "Rack application timed out during boot"
-          end
+          raise "Rack application timed out during boot" if timer.expired?
           @server_thread.join(0.1)
         end
       end
@@ -94,14 +81,6 @@ module Capybara
 
   private
 
-    def http_connect
-      Net::HTTP.start(host, port, read_timeout: 2) { |http| http.get('/__identify__') }
-    end
-
-    def https_connect
-      Net::HTTP.start(host, port, use_ssl: true, verify_mode: OpenSSL::SSL::VERIFY_NONE) { |http| http.get('/__identify__') }
-    end
-
     def middleware
       @middleware ||= Middleware.new(app, @reportable_errors, @extra_middleware)
     end

data/lib/capybara/server/checker.rb

@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+
+module Capybara
+  class Server
+    class Checker
+      def initialize(host, port)
+        @host, @port = host, port
+        @ssl = false
+      end
+
+      def request(&block)
+        ssl? ? https_request(&block) : http_request(&block)
+      rescue EOFError, Net::ReadTimeout
+        res = https_request(&block)
+        @ssl = true
+        res
+      end
+
+      def ssl?
+        @ssl
+      end
+
+    private
+
+      def http_request(&block)
+        Net::HTTP.start(@host, @port, read_timeout: 2, &block)
+      end
+
+      def https_request(&block)
+        Net::HTTP.start(@host, @port, ssl_options, &block)
+      end
+
+      def ssl_options
+        { use_ssl: true, verify_mode: OpenSSL::SSL::VERIFY_NONE }
+      end
+    end
+  end
+end

data/lib/capybara/spec/public/test.js

@@ -63,6 +63,11 @@ $(function() {
       $('title').text('changed title')
     }, 400)
   });
+  $('#change-size').click(function() {
+    setTimeout(function() {
+      document.getElementById('change').style.fontSize = '50px';
+    }, 500)
+  });
   $('#click-test').on({
     click: function(e) {
       var desc = "";

data/lib/capybara/spec/session/all_spec.rb

@@ -59,6 +59,7 @@ Capybara::SpecHelper.spec "#all" do
 
   context "with css as default selector" do
     before { Capybara.default_selector = :css }
+
     it "should find the first element using the given locator" do
       expect(@session.all('h1').first.text).to eq('This is a test')
       expect(@session.all("input[id='test_field']").first.value).to eq('monkey')
@@ -102,6 +103,7 @@ Capybara::SpecHelper.spec "#all" do
         expect { @session.all(:css, 'h1, p', count: 5) }.to raise_error(Capybara::ExpectationNotMet)
       end
     end
+
     context ':minimum' do
       it 'should succeed when the number of elements founds matches the expectation' do
         expect { @session.all(:css, 'h1, p', minimum: 0) }.not_to raise_error
@@ -110,6 +112,7 @@ Capybara::SpecHelper.spec "#all" do
         expect { @session.all(:css, 'h1, p', minimum: 5) }.to raise_error(Capybara::ExpectationNotMet)
       end
     end
+
     context ':maximum' do
       it 'should succeed when the number of elements founds matches the expectation' do
         expect { @session.all(:css, 'h1, p', maximum: 4) }.not_to raise_error
@@ -118,6 +121,7 @@ Capybara::SpecHelper.spec "#all" do
         expect { @session.all(:css, 'h1, p', maximum: 0) }.to raise_error(Capybara::ExpectationNotMet)
       end
     end
+
     context ':between' do
       it 'should succeed when the number of elements founds matches the expectation' do
         expect { @session.all(:css, 'h1, p', between: 2..7) }.not_to raise_error

data/lib/capybara/spec/session/assert_style_spec.rb

@@ -0,0 +1,26 @@
+# frozen_string_literal: true
+
+Capybara::SpecHelper.spec '#assert_style', requires: [:css] do
+  it "should not raise if the elements style contains the given properties" do
+    @session.visit('/with_html')
+    expect do
+      @session.find(:css, '#first').assert_style(display: 'block')
+    end.not_to raise_error
+  end
+
+  it "should raise error if the elements style doesn't contain the given properties" do
+    @session.visit('/with_html')
+    expect do
+      @session.find(:css, '#first').assert_style(display: 'inline')
+    end.to raise_error(Capybara::ExpectationNotMet, 'Expected node to have styles {"display"=>"inline"}. Actual styles were {"display"=>"block"}')
+  end
+
+  it "should wait for style", requires: %i[css js] do
+    @session.visit('/with_js')
+    el = @session.find(:css, '#change')
+    @session.click_link("Change size")
+    expect do
+      el.assert_style({ 'font-size': '50px' }, wait: 3)
+    end.not_to raise_error
+  end
+end

data/lib/capybara/spec/session/click_button_spec.rb

@@ -396,6 +396,16 @@ Capybara::SpecHelper.spec '#click_button' do
     expect(@session.current_url).to match(%r{/landed$})
   end
 
+  it "should follow temporary redirects that maintain method" do
+    @session.click_button('Go 307')
+    expect(@session).to have_content('You post landed: TWTW')
+  end
+
+  it "should follow permanent redirects that maintain method" do
+    @session.click_button('Go 308')
+    expect(@session).to have_content('You post landed: TWTW')
+  end
+
   it "should post pack to the same URL when no action given" do
     @session.visit('/postback')
     @session.click_button('With no action')

data/lib/capybara/spec/session/click_link_spec.rb

@@ -203,4 +203,15 @@ Capybara::SpecHelper.spec '#click_link' do
     el = @session.find(:link, 'Normal Anchor')
     expect(@session.click_link('Normal Anchor')).to eq el
   end
+
+  it "can download a file", requires: [:download] do
+    # This requires the driver used for the test to be configured
+    # to download documents with the mime type "text/csv"
+    download_file = File.join(Capybara.save_path, 'download.csv')
+    expect(File).not_to exist(download_file)
+    @session.click_link('Download Me')
+    sleep 2
+    expect(File).to exist(download_file)
+    FileUtils.rm_rf download_file
+  end
 end

data/lib/capybara/spec/session/fill_in_spec.rb

@@ -188,7 +188,9 @@ Capybara::SpecHelper.spec "#fill_in" do
 
   context "with ignore_hidden_fields" do
     before { Capybara.ignore_hidden_elements = true }
+
     after  { Capybara.ignore_hidden_elements = false }
+
     it "should not find a hidden field" do
       msg = "Unable to find visible field \"Super Secret\" that is not disabled"
       expect do

data/lib/capybara/spec/session/find_link_spec.rb

@@ -49,4 +49,22 @@ Capybara::SpecHelper.spec '#find_link' do
       expect(@session.find_link(href: '#anchor').text).to eq "Normal Anchor"
     end
   end
+
+  context "download filter" do
+    it "finds a download link" do
+      expect(@session.find_link("Download Me", download: true).text).to eq "Download Me"
+    end
+
+    it "doesn't find a download link if download is false" do
+      expect { @session.find_link("Download Me", download: false) }.to raise_error Capybara::ElementNotFound
+    end
+
+    it "finds a renaming download link" do
+      expect(@session.find_link(download: "other.csv").text).to eq "Download Other"
+    end
+
+    it "raises if passed an invalid value" do
+      expect { @session.find_link(download: 37) }.to raise_error ArgumentError
+    end
+  end
 end

data/lib/capybara/spec/session/find_spec.rb

@@ -206,6 +206,7 @@ Capybara::SpecHelper.spec '#find' do
 
   context "with css as default selector" do
     before { Capybara.default_selector = :css }
+
     it "should find the first element using the given locator" do
       expect(@session.find('h1').text).to eq('This is a test')
       expect(@session.find("input[id='test_field']").value).to eq('monkey')

data/lib/capybara/spec/session/first_spec.rb

@@ -51,6 +51,7 @@ Capybara::SpecHelper.spec '#first' do
 
   context "with css as default selector" do
     before { Capybara.default_selector = :css }
+
     it "should find the first element using the given locator" do
       expect(@session.first('h1').text).to eq('This is a test')
       expect(@session.first("input[id='test_field']").value).to eq('monkey')

data/lib/capybara/spec/session/has_css_spec.rb

@@ -115,12 +115,6 @@ Capybara::SpecHelper.spec '#has_css?' do
   end
 
   it "should allow escapes in the CSS selector" do
-    if (defined?(TestClass) && @session.is_a?(TestClass)) || @session.driver.is_a?(Capybara::RackTest::Driver)
-      # Nokogiri doesn't unescape CSS selectors when converting from CSS to XPath
-      # See: https://github.com/teamcapybara/capybara/issues/1866
-      # Also: https://github.com/sparklemotion/nokogiri/pull/1646
-      pending "Current Nokogiri doesn't handle escapes in CSS attribute selectors correctly"
-    end
     expect(@session).to have_css('p[data-random="abc\\\\def"]')
     expect(@session).to have_css("p[data-random='#{Capybara::Selector::CSS.escape('abc\def')}']")
   end

data/lib/capybara/spec/session/has_style_spec.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+Capybara::SpecHelper.spec '#has_style?', requires: [:css] do
+  before do
+    @session.visit('/with_html')
+  end
+
+  it "should be true if the element has the given style" do
+    expect(@session.find(:css, '#first')).to have_style(display: 'block')
+    expect(@session.find(:css, '#first').has_style?(display: 'block')).to be true
+    expect(@session.find(:css, '#second')).to have_style('display' => 'inline')
+    expect(@session.find(:css, '#second').has_style?('display' => 'inline')).to be true
+  end
+
+  it "should be false if the element does not have the given style" do
+    expect(@session.find(:css, '#first').has_style?('display' => 'inline')).to be false
+    expect(@session.find(:css, '#second').has_style?(display: 'block')).to be false
+  end
+
+  it "allows Regexp for value matching" do
+    expect(@session.find(:css, '#first')).to have_style(display: /^bl/)
+    expect(@session.find(:css, '#first').has_style?('display' => /^bl/)).to be true
+    expect(@session.find(:css, '#first').has_style?(display: /^in/)).to be false
+  end
+end