capybara 3.13.2 → 3.40.0

data/spec/shared_selenium_session.rb

@@ -23,32 +23,35 @@ RSpec.shared_examples 'Capybara::Session' do |session, mode|
       it 'freshly reset session should not be touched' do
         session.instance_variable_set(:@touched, true)
         session.reset!
-        expect(session.instance_variable_get(:@touched)).to eq false
+        expect(session.instance_variable_get(:@touched)).to be false
       end
     end
 
     describe 'exit codes' do
+      let(:env) { { 'SELENIUM_BROWSER' => session.driver.options[:browser].to_s } }
+      let!(:orig_dir) { Dir.getwd }
+
       before do
-        @current_dir = Dir.getwd
         Dir.chdir(File.join(File.dirname(__FILE__), '..'))
-        @env = { 'SELENIUM_BROWSER' => session.driver.options[:browser].to_s }
       end
 
       after do
-        Dir.chdir(@current_dir)
+        Dir.chdir(orig_dir)
       end
 
       it 'should have return code 1 when running selenium_driver_rspec_failure.rb' do
         skip 'only setup for local non-headless' if headless_or_remote?
+        skip 'Not setup for edge' if edge?(session)
 
-        system(@env, 'rspec spec/fixtures/selenium_driver_rspec_failure.rb', out: File::NULL, err: File::NULL)
+        system(env, 'rspec spec/fixtures/selenium_driver_rspec_failure.rb', out: File::NULL, err: File::NULL)
         expect($CHILD_STATUS.exitstatus).to eq(1)
       end
 
       it 'should have return code 0 when running selenium_driver_rspec_success.rb' do
         skip 'only setup for local non-headless' if headless_or_remote?
+        skip 'Not setup for edge' if edge?(session)
 
-        system(@env, 'rspec spec/fixtures/selenium_driver_rspec_success.rb', out: File::NULL, err: File::NULL)
+        system(env, 'rspec spec/fixtures/selenium_driver_rspec_success.rb', out: File::NULL, err: File::NULL)
         expect($CHILD_STATUS.exitstatus).to eq(0)
       end
     end
@@ -69,7 +72,7 @@ RSpec.shared_examples 'Capybara::Session' do |session, mode|
       end
     end
 
-    context '#fill_in_with empty string and no options' do
+    describe '#fill_in_with empty string and no options' do
       it 'should trigger change when clearing a field' do
         session.visit('/with_js')
         session.fill_in('with_change_event', with: '')
@@ -79,7 +82,7 @@ RSpec.shared_examples 'Capybara::Session' do |session, mode|
       end
     end
 
-    context '#fill_in with { :clear => :backspace } fill_option', requires: [:js] do
+    describe '#fill_in with { :clear => :backspace } fill_option', requires: [:js] do
       before do
         # Firefox has an issue with change events if the main window doesn't think it's focused
         session.execute_script('window.focus()')
@@ -115,6 +118,7 @@ RSpec.shared_examples 'Capybara::Session' do |session, mode|
 
       it 'should only trigger onchange once' do
         session.visit('/with_js')
+        sleep 2 if safari?(session) # Safari needs a delay (to load event handlers maybe ???)
         session.fill_in('with_change_event',
                         with: 'some value',
                         fill_options: { clear: :backspace })
@@ -139,22 +143,34 @@ RSpec.shared_examples 'Capybara::Session' do |session, mode|
                         with: '',
                         fill_options: { clear: :backspace })
         # click outside the field to trigger the change event
-        session.find(:css, 'body').click
+        # session.find(:css, 'body').click
+        session.find(:css, 'h1', text: 'FooBar').click
         expect(session).to have_xpath('//p[@class="input_event_triggered"]', count: 13)
       end
     end
 
-    context '#fill_in with { clear: :none } fill_options' do
+    describe '#fill_in with { clear: :none } fill_options' do
       it 'should append to content in a field' do
+        pending 'Safari overwrites by default - need to figure out a workaround' if safari?(session)
+
         session.visit('/form')
         session.fill_in('form_first_name',
                         with: 'Harry',
                         fill_options: { clear: :none })
         expect(session.find(:fillable_field, 'form_first_name').value).to eq('JohnHarry')
       end
+
+      it 'works with rapid fill' do
+        pending 'Safari overwrites by default - need to figure out a workaround' if safari?(session)
+
+        long_string = (0...60).map { |i| ((i % 26) + 65).chr }.join
+        session.visit('/form')
+        session.fill_in('form_first_name', with: long_string, fill_options: { clear: :none })
+        expect(session.find(:fillable_field, 'form_first_name').value).to eq("John#{long_string}")
+      end
     end
 
-    context  '#fill_in with Date' do
+    describe '#fill_in with Date' do
       before do
         session.visit('/form')
         session.find(:css, '#form_date').execute_script <<-JS
@@ -165,7 +181,8 @@ RSpec.shared_examples 'Capybara::Session' do |session, mode|
           });
         JS
         # work around weird FF issue where it would create an extra focus issue in some cases
-        session.find(:css, 'body').click
+        session.find(:css, 'h1', text: 'Form').click
+        # session.find(:css, 'body').click
       end
 
       it 'should generate standard events on changing value' do
@@ -183,7 +200,7 @@ RSpec.shared_examples 'Capybara::Session' do |session, mode|
       end
     end
 
-    context '#fill_in with { clear: Array } fill_options' do
+    describe '#fill_in with { clear: Array } fill_options' do
       it 'should pass the array through to the element' do
         # this is mainly for use with [[:control, 'a'], :backspace] - however since that is platform dependant I'm testing with something less useful
         session.visit('/form')
@@ -194,6 +211,26 @@ RSpec.shared_examples 'Capybara::Session' do |session, mode|
       end
     end
 
+    describe '#fill_in with Emoji' do
+      it 'sends emojis' do
+        session.visit('/form')
+        session.fill_in('form_first_name', with: 'a😀cd😴 🛌🏽🇵🇹 e🤾🏽‍♀️f')
+        expect(session.find(:fillable_field, 'form_first_name').value).to eq('a😀cd😴 🛌🏽🇵🇹 e🤾🏽‍♀️f')
+      end
+    end
+
+    describe '#send_keys' do
+      it 'defaults to sending keys to the active_element' do
+        session.visit('/form')
+
+        expect(session.active_element).to match_selector(:css, 'body')
+
+        session.send_keys(:tab)
+
+        expect(session.active_element).to match_selector(:css, '[tabindex="1"]')
+      end
+    end
+
     describe '#path' do
       it 'returns xpath' do
         # this is here because it is testing for an XPath that is specific to the algorithm used in the selenium driver
@@ -243,6 +280,13 @@ RSpec.shared_examples 'Capybara::Session' do |session, mode|
         expect(element).to eq session.find(:id, 'form_title')
       end
 
+      it 'returns a shadow root' do
+        session.visit('/with_shadow')
+        shadow = session.find(:css, '#shadow_host')
+        element = session.evaluate_script('arguments[0].shadowRoot', shadow)
+        expect(element).to be_instance_of(Capybara::Node::Element)
+      end
+
       it 'can return arrays of nested elements' do
         session.visit('/form')
         elements = session.evaluate_script('document.querySelectorAll("#form_city option")')
@@ -263,6 +307,7 @@ RSpec.shared_examples 'Capybara::Session' do |session, mode|
 
       describe '#evaluate_async_script' do
         it 'will timeout if the script takes too long' do
+          skip 'safaridriver returns the wrong error type' if safari?(session)
           session.visit('/with_js')
           expect do
             session.using_wait_time(1) do
@@ -287,65 +332,35 @@ RSpec.shared_examples 'Capybara::Session' do |session, mode|
     describe 'Element#click' do
       it 'should handle fixed headers/footers' do
         session.visit('/with_fixed_header_footer')
-        # session.click_link('Go to root')
-        session.find(:link, 'Go to root').click
+        session.using_wait_time(2) do
+          session.find(:link, 'Go to root').click
+        end
         expect(session).to have_current_path('/')
       end
     end
 
-    describe 'Element#drag_to' do
-      before do
-        skip "Firefox < 62 doesn't support a DataTransfer constuctor" if firefox_lt?(62.0, session)
-        skip "IE doesn't support a DataTransfer constuctor" if ie?(session)
-      end
-
-      it 'should HTML5 drag and drop an object' do
-        session.visit('/with_js')
-        element = session.find('//div[@id="drag_html5"]')
-        target = session.find('//div[@id="drop_html5"]')
-        element.drag_to(target)
-        expect(session).to have_xpath('//div[contains(., "HTML5 Dropped drag_html5")]')
-      end
-
-      it 'should not HTML5 drag and drop on a non HTML5 drop element' do
-        session.visit('/with_js')
-        element = session.find('//div[@id="drag_html5"]')
-        target = session.find('//div[@id="drop_html5"]')
-        target.execute_script("$(this).removeClass('drop');")
-        element.drag_to(target)
-        sleep 1
-        expect(session).not_to have_xpath('//div[contains(., "HTML5 Dropped drag_html5")]')
-      end
-
-      it 'should HTML5 drag and drop when scrolling needed' do
-        session.visit('/with_js')
-        element = session.find('//div[@id="drag_html5_scroll"]')
-        target = session.find('//div[@id="drop_html5_scroll"]')
-        element.drag_to(target)
-        expect(session).to have_xpath('//div[contains(., "HTML5 Dropped drag_html5_scroll")]')
-      end
-
-      it 'should drag HTML5 default draggable elements' do
-        session.visit('/with_js')
-        link = session.find_link('drag_link_html5')
-        target = session.find(:id, 'drop_html5')
-        link.drag_to target
-        expect(session).to have_xpath('//div[contains(., "HTML5 Dropped")]')
-      end
-    end
-
     describe 'Capybara#Node#attach_file' do
       it 'can attach a directory' do
         pending "Geckodriver doesn't support uploading a directory" if firefox?(session)
         pending "Selenium remote doesn't support transferring a directory" if remote?(session)
-        pending "Headless Chrome doesn't support directory upload - https://bugs.chromium.org/p/chromedriver/issues/detail?id=2521&q=directory%20upload&colspec=ID%20Status%20Pri%20Owner%20Summary" if chrome?(session) && ENV['HEADLESS']
+        pending "Headless Chrome doesn't support directory upload - https://bugs.chromium.org/p/chromedriver/issues/detail?id=2521&q=directory%20upload&colspec=ID%20Status%20Pri%20Owner%20Summary" if chrome?(session) && chrome_lt?(110, session) && ENV.fetch('HEADLESS', nil)
         pending "IE doesn't support uploading a directory" if ie?(session)
+        pending 'Chrome/chromedriver 73 breaks this' if chrome?(session) && chrome_gte?(73, session) && chrome_lt?(75, session)
 
         session.visit('/form')
-        @test_file_dir = File.expand_path('./fixtures', File.dirname(__FILE__))
-        session.attach_file('Directory Upload', @test_file_dir)
+        test_file_dir = File.expand_path('./fixtures', File.dirname(__FILE__))
+        session.attach_file('Directory Upload', test_file_dir)
         session.click_button('Upload Multiple')
-        expect(session.body).to include('5 | ') # number of files
+        expect(session).to have_text('5 | ') # number of files
+      end
+
+      it 'can attach a relative file' do
+        pending 'Geckdoriver on windows requires alternate file separator which path expansion replaces' if Gem.win_platform? && firefox?(session)
+
+        session.visit('/form')
+        session.attach_file('Single Document', 'spec/fixtures/capybara.csv')
+        session.click_button('Upload Single')
+        expect(session).to have_text('Content-type: text/csv')
       end
     end
 
@@ -357,17 +372,21 @@ RSpec.shared_examples 'Capybara::Session' do |session, mode|
       end
     end
 
+    # rubocop:disable RSpec/InstanceVariable
     describe 'Capybara#disable_animation' do
       context 'when set to `true`' do
         before(:context) do # rubocop:disable RSpec/BeforeAfterAll
+          skip "Safari doesn't support multiple sessions" if safari?(session)
           # NOTE: Although Capybara.SpecHelper.reset! sets Capybara.disable_animation to false,
           # it doesn't affect any of these tests because the settings are applied per-session
           Capybara.disable_animation = true
           @animation_session = Capybara::Session.new(session.mode, TestApp.new)
         end
 
-        after(:context) do # rubocop:disable RSpec/BeforeAfterAll
-          @animation_session = nil
+        it 'should add CSS to the <head> element' do
+          @animation_session.visit('with_animation')
+
+          expect(@animation_session).to have_selector(:css, 'head > style', text: 'transition: none', visible: :hidden)
         end
 
         it 'should disable CSS transitions' do
@@ -376,33 +395,87 @@ RSpec.shared_examples 'Capybara::Session' do |session, mode|
           expect(@animation_session).to have_no_link('transition me away', wait: 0.5)
         end
 
-        it 'should disable CSS animations' do
+        it 'should disable CSS animations (set to 0s)' do
           @animation_session.visit('with_animation')
+          sleep 1
           @animation_session.click_link('animate me away')
           expect(@animation_session).to have_no_link('animate me away', wait: 0.5)
         end
+
+        it 'should disable CSS animations on pseudo elements (set to 0s)' do
+          @animation_session.visit('with_animation')
+          sleep 1
+          @animation_session.find_link('animate me away').right_click
+          expect(@animation_session).to have_content('Animation Ended', wait: 0.1)
+        end
+
+        it 'should scroll the page instantly', requires: [:js] do
+          @animation_session.visit('with_animation')
+          scroll_y = @animation_session.evaluate_script(<<~JS)
+            (function(){
+              window.scrollTo(0,500);
+              return window.scrollY;
+            })()
+          JS
+          expect(scroll_y).to eq 500
+        end
+
+        it 'should scroll the page instantly without jquery animation', requires: [:js] do
+          @animation_session.visit('with_jquery_animation')
+          @animation_session.click_link('scroll top 500')
+          scroll_y = @animation_session.evaluate_script('window.scrollY')
+          expect(scroll_y).to eq 500
+        end
+      end
+
+      context 'when set to `false`' do
+        before(:context) do # rubocop:disable RSpec/BeforeAfterAll
+          skip "Safari doesn't support multiple sessions" if safari?(session)
+          # NOTE: Although Capybara.SpecHelper.reset! sets Capybara.disable_animation to false,
+          # it doesn't affect any of these tests because the settings are applied per-session
+          Capybara.disable_animation = false
+          @animation_session = Capybara::Session.new(session.mode, TestApp.new)
+        end
+
+        it 'should scroll the page with a smooth animation', requires: [:js] do
+          @animation_session.visit('with_animation')
+          scroll_y = @animation_session.evaluate_script(<<~JS)
+            (function(){
+              window.scrollTo(0,500);
+              return window.scrollY;
+            })()
+          JS
+          # measured over 0.5 seconds: 0, 75, 282, 478, 500
+          expect(scroll_y).to be < 500
+        end
+
+        it 'should scroll the page with jquery animation', requires: [:js] do
+          @animation_session.visit('with_jquery_animation')
+          @animation_session.click_link('scroll top 500')
+          scroll_y = @animation_session.evaluate_script('window.scrollY')
+          expect(scroll_y).to be < 500
+        end
       end
 
       context 'if we pass in css that matches elements' do
         before(:context) do # rubocop:disable RSpec/BeforeAfterAll
+          skip "safaridriver doesn't support multiple sessions" if safari?(session)
           # NOTE: Although Capybara.SpecHelper.reset! sets Capybara.disable_animation to false,
           # it doesn't affect any of these tests because the settings are applied per-session
           Capybara.disable_animation = '#with_animation a'
           @animation_session_with_matching_css = Capybara::Session.new(session.mode, TestApp.new)
         end
 
-        after(:context) do # rubocop:disable RSpec/BeforeAfterAll
-          @animation_session_with_matching_css = nil
-        end
-
         it 'should disable CSS transitions' do
           @animation_session_with_matching_css.visit('with_animation')
+          sleep 1
           @animation_session_with_matching_css.click_link('transition me away')
           expect(@animation_session_with_matching_css).to have_no_link('transition me away', wait: 0.5)
         end
 
         it 'should disable CSS animations' do
           @animation_session_with_matching_css.visit('with_animation')
+          sleep 1
           @animation_session_with_matching_css.click_link('animate me away')
           expect(@animation_session_with_matching_css).to have_no_link('animate me away', wait: 0.5)
         end
@@ -410,18 +483,16 @@ RSpec.shared_examples 'Capybara::Session' do |session, mode|
 
       context 'if we pass in css that does not match elements' do
         before(:context) do # rubocop:disable RSpec/BeforeAfterAll
+          skip "Safari doesn't support multiple sessions" if safari?(session)
           # NOTE: Although Capybara.SpecHelper.reset! sets Capybara.disable_animation to false,
           # it doesn't affect any of these tests because the settings are applied per-session
           Capybara.disable_animation = '.this-class-matches-nothing'
           @animation_session_without_matching_css = Capybara::Session.new(session.mode, TestApp.new)
         end
 
-        after(:context) do # rubocop:disable RSpec/BeforeAfterAll
-          @animation_session_without_matching_css = nil
-        end
-
         it 'should not disable CSS transitions' do
           @animation_session_without_matching_css.visit('with_animation')
+          sleep 1
           @animation_session_without_matching_css.click_link('transition me away')
           sleep 0.5 # Wait long enough for click to have been processed
           expect(@animation_session_without_matching_css).to have_link('transition me away', wait: false)
@@ -430,6 +501,7 @@ RSpec.shared_examples 'Capybara::Session' do |session, mode|
 
         it 'should not disable CSS animations' do
           @animation_session_without_matching_css.visit('with_animation')
+          sleep 1
           @animation_session_without_matching_css.click_link('animate me away')
           sleep 0.5 # Wait long enough for click to have been processed
           expect(@animation_session_without_matching_css).to have_link('animate me away', wait: false)
@@ -437,20 +509,53 @@ RSpec.shared_examples 'Capybara::Session' do |session, mode|
         end
       end
     end
+    # rubocop:enable RSpec/InstanceVariable
 
     describe ':element selector' do
       it 'can find html5 svg elements' do
         session.visit('with_html5_svg')
         expect(session).to have_selector(:element, :svg)
-        expect(session).to have_selector(:element, :rect, visible: true)
+        expect(session).to have_selector(:element, :rect, visible: :visible)
         expect(session).to have_selector(:element, :circle)
         expect(session).to have_selector(:element, :linearGradient, visible: :all)
       end
 
       it 'can query attributes with strange characters' do
         session.visit('/form')
-        expect(session).to have_selector(:element, "{custom}": true)
-        expect(session).to have_selector(:element, "{custom}": 'abcdef')
+        expect(session).to have_selector(:element, '{custom}': true)
+        expect(session).to have_selector(:element, '{custom}': 'abcdef')
+      end
+    end
+
+    describe 'with react' do
+      context 'controlled components' do
+        it 'can set and clear a text field' do
+          skip "This test doesn't support older browsers" if ie?(session)
+
+          session.visit 'react'
+
+          session.fill_in('Name:', with: 'abc')
+          session.accept_prompt 'A name was submitted: abc' do
+            session.click_button('Submit')
+          end
+
+          session.fill_in('Name:', with: '')
+          session.accept_prompt(/A name was submitted: $/) do
+            session.click_button('Submit')
+          end
+        end
+
+        it 'works with rapid fill' do
+          skip "This test doesn't support older browsers" if ie?(session)
+
+          session.visit 'react'
+          long_string = (0...60).map { |i| ((i % 26) + 65).chr }.join
+
+          session.fill_in('Name:', with: long_string)
+          session.accept_prompt "A name was submitted: #{long_string}" do
+            session.click_button('Submit')
+          end
+        end
       end
     end
   end

data/spec/spec_helper.rb

@@ -1,15 +1,23 @@
 # frozen_string_literal: true
 
 require 'rspec/expectations'
-require 'capybara/spec/spec_helper'
-require 'webdrivers' if ENV['CI']
+require 'webdrivers' if ENV.fetch('WEBDRIVERS', nil)
 require 'selenium_statistics'
+if ENV['TRAVIS']
+  require 'coveralls'
+  Coveralls.wear! do
+    add_filter '/lib/capybara/driver/'
+    add_filter '/lib/capybara/registrations/'
+  end
+end
+require 'capybara/spec/spec_helper'
 
 module Capybara
   module SpecHelper
     def firefox?(session)
       browser_name(session) == :firefox &&
-        session.driver.browser.capabilities.is_a?(::Selenium::WebDriver::Remote::W3C::Capabilities)
+        ((defined?(::Selenium::WebDriver::VERSION) && (Gem::Version.new(::Selenium::WebDriver::VERSION) >= Gem::Version.new('4'))) ||
+         session.driver.browser.capabilities.is_a?(::Selenium::WebDriver::Remote::W3C::Capabilities))
     end
 
     def firefox_lt?(version, session)
@@ -20,26 +28,80 @@ module Capybara
       firefox?(session) && (session.driver.browser.capabilities[:browser_version].to_f >= version)
     end
 
+    def geckodriver_version(session)
+      Gem::Version.new(session.driver.browser.capabilities['moz:geckodriverVersion'])
+    end
+
+    def geckodriver_gte?(version, session)
+      firefox?(session) && geckodriver_version(session) >= Gem::Version.new(version)
+    end
+
+    def geckodriver_lt?(version, session)
+      firefox?(session) && geckodriver_version(session) < Gem::Version.new(version)
+    end
+
     def chrome?(session)
       browser_name(session) == :chrome
     end
 
+    def chrome_version(session)
+      (session.driver.browser.capabilities[:browser_version] ||
+        session.driver.browser.capabilities[:version]).to_f
+    end
+
     def chrome_lt?(version, session)
-      chrome?(session) && (session.driver.browser.capabilities[:version].to_f < version)
+      chrome?(session) && (chrome_version(session) < version)
     end
 
     def chrome_gte?(version, session)
-      chrome?(session) && (session.driver.browser.capabilities[:version].to_f >= version)
+      chrome?(session) && (chrome_version(session) >= version)
+    end
+
+    def chromedriver_version(session)
+      Gem::Version.new(session.driver.browser.capabilities['chrome']['chromedriverVersion'].split[0])
+    end
+
+    def chromedriver_gte?(version, session)
+      chrome?(session) && chromedriver_version(session) >= Gem::Version.new(version)
+    end
+
+    def chromedriver_lt?(version, session)
+      chrome?(session) && chromedriver_version(session) < Gem::Version.new(version)
+    end
+
+    def selenium?(session)
+      session.driver.is_a? Capybara::Selenium::Driver
+    end
+
+    def selenium_lt?(version, session)
+      selenium?(session) &&
+        Gem::Version.new(::Selenium::WebDriver::VERSION) < Gem::Version.new(version)
     end
 
     def edge?(session)
+      browser_name(session).to_s.start_with?('edge')
+    end
+
+    def legacy_edge?(session)
       browser_name(session) == :edge
     end
 
+    def edge_lt?(version, session)
+      edge?(session) && (chrome_version(session) < version)
+    end
+
+    def edge_gte?(version, session)
+      edge?(session) && (chrome_version(session) >= version)
+    end
+
     def ie?(session)
       %i[internet_explorer ie].include?(browser_name(session))
     end
 
+    def safari?(session)
+      %i[safari Safari Safari_Technology_Preview].include?(browser_name(session))
+    end
+
     def browser_name(session)
       session.driver.browser.browser if session.respond_to?(:driver)
     end
@@ -47,11 +109,24 @@ module Capybara
     def remote?(session)
       session.driver.browser.is_a? ::Selenium::WebDriver::Remote::Driver
     end
+
+    def self.log_selenium_driver_version(mod)
+      mod = mod::Service if ::Selenium::WebDriver::Service.respond_to? :driver_path
+      path = mod.driver_path
+      path = path.call if path.respond_to? :call
+      $stdout.puts `#{path.gsub(' ', '\ ')} --version` if path
+    end
   end
 end
 
 RSpec.configure do |config|
   Capybara::SpecHelper.configure(config)
+  config.expect_with :rspec do |expectations|
+    expectations.syntax = :expect
+  end
+  config.mock_with :rspec do |mocks|
+    mocks.verify_partial_doubles = true
+  end
   config.filter_run_including focus_: true unless ENV['CI']
   config.run_all_when_everything_filtered = true
   config.after(:suite) { SeleniumStatistics.print_results }

data/spec/whitespace_normalizer_spec.rb

@@ -0,0 +1,54 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'capybara/node/whitespace_normalizer'
+
+RSpec.describe Capybara::Node::WhitespaceNormalizer do
+  subject(:normalizer) do
+    klass = Class.new do
+      include Capybara::Node::WhitespaceNormalizer
+    end
+
+    klass.new
+  end
+
+  let(:text_needing_correction) do
+    <<~TEXT
+      Some     #{described_class::NON_BREAKING_SPACE}text
+      #{described_class::RIGHT_TO_LEFT_MARK}
+      #{described_class::ZERO_WIDTH_SPACE * 30}
+      #{described_class::LEFT_TO_RIGHT_MARK}
+      Here
+    TEXT
+  end
+
+  describe '#normalize_spacing' do
+    it 'does nothing to text not containing special characters' do
+      expect(normalizer.normalize_spacing('text')).to eq('text')
+    end
+
+    it 'compresses excess breaking spacing' do
+      expect(
+        normalizer.normalize_spacing(text_needing_correction)
+      ).to eq('Some  text Here')
+    end
+  end
+
+  describe '#normalize_visible_spacing' do
+    it 'does nothing to text not containing special characters' do
+      expect(normalizer.normalize_visible_spacing('text')).to eq('text')
+    end
+
+    it 'compresses excess breaking visible spacing' do
+      expect(
+        normalizer.normalize_visible_spacing(text_needing_correction)
+      ).to eq <<~TEXT.chomp
+        Some  text
+        #{described_class::RIGHT_TO_LEFT_MARK}
+        #{described_class::ZERO_WIDTH_SPACE * 30}
+        #{described_class::LEFT_TO_RIGHT_MARK}
+        Here
+      TEXT
+    end
+  end
+end

data/spec/xpath_builder_spec.rb

@@ -2,9 +2,10 @@
 
 require 'spec_helper'
 
+# rubocop:disable RSpec/InstanceVariable
 RSpec.describe Capybara::Selector::XPathBuilder do
   let :builder do
-    ::Capybara::Selector::XPathBuilder.new(@xpath)
+    described_class.new(@xpath)
   end
 
   context 'add_attribute_conditions' do
@@ -89,3 +90,4 @@ RSpec.describe Capybara::Selector::XPathBuilder do
     end
   end
 end
+# rubocop:enable RSpec/InstanceVariable