capybara 3.13.2 → 3.40.0

data/spec/rspec_spec.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+# rubocop:disable RSpec/MultipleDescribes
+
 require 'spec_helper'
 
 RSpec.describe 'capybara/rspec' do
@@ -13,7 +15,7 @@ RSpec.describe 'capybara/rspec' do
       expect(self.class.ancestors).to include Capybara::RSpecMatcherProxies
     end
 
-    context 'resetting session' do
+    context 'resetting session', order: :defined do
       it 'sets a cookie in one example...' do
         visit('/set_cookie')
         expect(page.body).to include('Cookie set to test_cookie')
@@ -25,7 +27,7 @@ RSpec.describe 'capybara/rspec' do
       end
     end
 
-    context 'setting the current driver' do
+    context 'setting the current driver', order: :defined do
       it 'sets the current driver in one example...' do
         Capybara.current_driver = :selenium
       end
@@ -35,7 +37,7 @@ RSpec.describe 'capybara/rspec' do
       end
     end
 
-    it 'switches to the javascript driver when giving it as metadata', js: true do
+    it 'switches to the javascript driver when giving it as metadata', :js do
       expect(Capybara.current_driver).to eq(Capybara.javascript_driver)
     end
 
@@ -43,7 +45,7 @@ RSpec.describe 'capybara/rspec' do
       expect(Capybara.current_driver).to eq(:culerity)
     end
 
-    context '#all' do
+    describe '#all' do
       it 'allows access to the Capybara finder' do
         visit('/with_html')
         found = all(:css, 'h2') { |element| element[:class] == 'head' }
@@ -57,7 +59,7 @@ RSpec.describe 'capybara/rspec' do
       end
     end
 
-    context '#within' do
+    describe '#within' do
       it 'allows access to the Capybara scoper' do
         visit('/with_html')
         expect do
@@ -75,40 +77,38 @@ RSpec.describe 'capybara/rspec' do
 
   context 'Type: Other', type: :other do
     context 'when RSpec::Matchers is included after Capybara::DSL' do
-      before do
-        class DSLMatchersTest
+      let(:test_class_instance) do
+        Class.new do
           include Capybara::DSL
           include RSpec::Matchers
-        end
-
-        @test_class_instance = DSLMatchersTest.new
+        end.new
       end
 
-      context '#all' do
+      describe '#all' do
         it 'allows access to the Capybara finder' do
-          @test_class_instance.visit('/with_html')
-          expect(@test_class_instance.all(:css, 'h2.head').size).to eq(5)
+          test_class_instance.visit('/with_html')
+          expect(test_class_instance.all(:css, 'h2.head').size).to eq(5)
         end
 
         it 'allows access to the RSpec matcher' do
-          @test_class_instance.visit('/with_html')
+          test_class_instance.visit('/with_html')
           strings = %w[test1 test2]
-          expect(strings).to @test_class_instance.all(be_a(String))
+          expect(strings).to test_class_instance.all(be_a(String))
         end
       end
 
-      context '#within' do
+      describe '#within' do
         it 'allows access to the Capybara scoper' do
-          @test_class_instance.visit('/with_html')
+          test_class_instance.visit('/with_html')
           expect do
-            @test_class_instance.within(:css, '#does_not_exist') { @test_class_instance.click_link 'Go to simple' }
+            test_class_instance.within(:css, '#does_not_exist') { test_class_instance.click_link 'Go to simple' }
           end.to raise_error(Capybara::ElementNotFound)
         end
 
         it 'allows access to the RSpec matcher' do
-          @test_class_instance.visit('/with_html')
+          test_class_instance.visit('/with_html')
           # This reads terribly, but must call #within
-          expect(@test_class_instance.find(:css, 'span.number').text.to_i).to @test_class_instance.within(1).of(41)
+          expect(test_class_instance.find(:css, 'span.number').text.to_i).to test_class_instance.within(1).of(41)
         end
       end
 
@@ -124,7 +124,7 @@ RSpec.describe 'capybara/rspec' do
         it 'can be called with `not_to`' do
           # This test is for a bug in jruby where `super` isn't defined correctly - https://github.com/jruby/jruby/issues/4678
           # Reported in https://github.com/teamcapybara/capybara/issues/2115
-          @test_class_instance.instance_eval do
+          test_class_instance.instance_eval do
             expect do
               expect(true).not_to only_match_matcher(false) # rubocop:disable RSpec/ExpectActual
             end.not_to raise_error
@@ -145,3 +145,5 @@ feature 'Feature DSL' do
     expect(page.body).to include('Another World')
   end
 end
+
+# rubocop:enable RSpec/MultipleDescribes

data/spec/sauce_spec_chrome.rb

@@ -0,0 +1,43 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'selenium-webdriver'
+
+require 'sauce_whisk'
+# require 'shared_selenium_session'
+# require 'shared_selenium_node'
+# require 'rspec/shared_spec_matchers'
+
+Capybara.register_driver :sauce_chrome do |app|
+  options = {
+    selenium_version: '4.8.0',
+    platform: 'macOS 10.12',
+    browser_name: 'chrome',
+    version: '65.0',
+    name: 'Capybara test',
+    build: ENV.fetch('TRAVIS_REPO_SLUG', "Ruby-RSpec-Selenium: Local-#{Time.now.to_i}"),
+    username: ENV.fetch('SAUCE_USERNAME', nil),
+    access_key: ENV.fetch('SAUCE_ACCESS_KEY', nil)
+  }
+
+  options.delete(:browser_name)
+
+  capabilities = Selenium::WebDriver::Remote::Capabilities.chrome(options)
+  url = 'https://ondemand.saucelabs.com:443/wd/hub'
+
+  Capybara::Selenium::Driver.new(app,
+                                 browser: :remote, url: url,
+                                 capabilities: capabilities,
+                                 options: Selenium::WebDriver::Chrome::Options.new(args: ['']))
+end
+
+CHROME_REMOTE_DRIVER = :sauce_chrome
+
+module TestSessions
+  Chrome = Capybara::Session.new(CHROME_REMOTE_DRIVER, TestApp)
+end
+
+skipped_tests = %i[response_headers status_code trigger download]
+
+Capybara::SpecHelper.run_specs TestSessions::Chrome, CHROME_REMOTE_DRIVER.to_s, capybara_skip: skipped_tests do |example|
+end

data/spec/selector_spec.rb

@@ -3,9 +3,10 @@
 require 'spec_helper'
 
 RSpec.describe Capybara do
+  include Capybara::RSpecMatchers
   describe 'Selectors' do
     let :string do
-      Capybara.string <<-STRING
+      described_class.string <<-STRING
         <html>
           <head>
             <title>selectors</title>
@@ -42,18 +43,39 @@ RSpec.describe Capybara do
             <table>
               <tr><td></td></tr>
             </table>
+            <table id="rows">
+              <tr>
+                <td>A</td><td>B</td><td>C</td>
+              </tr>
+              <tr>
+                <td>D</td><td>E</td><td>F</td>
+              </tr>
+            </table>
+            <table id="cols">
+            <tbody>
+              <tr>
+                <td>A</td><td>D</td>
+              </tr>
+              <tr>
+                <td>B</td><td>E</td>
+              </tr>
+              <tr>
+                <td>C</td><td>F</td>
+              </tr>
+              </tbody>
+            </table>
           </body>
         </html>
       STRING
     end
 
     before do
-      Capybara.add_selector :custom_selector do
+      described_class.add_selector :custom_selector do
         css { |css_class| "div.#{css_class}" }
         node_filter(:not_empty, boolean: true, default: true, skip_if: :all) { |node, value| value ^ (node.text == '') }
       end
 
-      Capybara.add_selector :custom_css_selector do
+      described_class.add_selector :custom_css_selector do
         css(:name, :other_name) do |selector, name: nil, **|
           selector ||= ''
           selector += "[name='#{name}']" if name
@@ -73,7 +95,7 @@ RSpec.describe Capybara do
         end
       end
 
-      Capybara.add_selector :custom_xpath_selector do
+      described_class.add_selector :custom_xpath_selector do
         xpath(:valid1, :valid2) { |selector| selector }
         match { |value| value == 'match_me' }
       end
@@ -81,7 +103,7 @@ RSpec.describe Capybara do
 
     it 'supports `filter` as an alias for `node_filter`' do
       expect do
-        Capybara.add_selector :filter_alias_selector do
+        described_class.add_selector :filter_alias_selector do
           css { |_unused| 'div' }
           filter(:something) { |_node, _value| true }
         end
@@ -89,13 +111,13 @@ RSpec.describe Capybara do
     end
 
     describe 'adding a selector' do
-      it 'can set default visiblity' do
-        Capybara.add_selector :hidden_field do
+      it 'can set default visibility' do
+        described_class.add_selector :hidden_field do
           visible :hidden
           css { |_sel| 'input[type="hidden"]' }
         end
 
-        expect(string).to have_no_css('input[type="hidden"]')
+        expect(string).to have_no_css('input[type="hidden"]') # rubocop:disable Capybara/SpecificMatcher
         expect(string).to have_selector(:hidden_field)
       end
     end
@@ -104,7 +126,7 @@ RSpec.describe Capybara do
       it 'allows modifying a selector' do
         el = string.find(:custom_selector, 'aa')
         expect(el.tag_name).to eq 'div'
-        Capybara.modify_selector :custom_selector do
+        described_class.modify_selector :custom_selector do
           css { |css_class| "h1.#{css_class}" }
         end
         el = string.find(:custom_selector, 'aa')
@@ -112,7 +134,7 @@ RSpec.describe Capybara do
       end
 
       it "doesn't change existing filters" do
-        Capybara.modify_selector :custom_selector do
+        described_class.modify_selector :custom_selector do
           css { |css_class| "p.#{css_class}" }
         end
         expect(string).to have_selector(:custom_selector, 'bb', count: 1)
@@ -137,31 +159,34 @@ RSpec.describe Capybara do
       end
 
       it 'returns nil if no match' do
-        expect(Capybara::Selector.for('nothing')).to be nil
+        expect(Capybara::Selector.for('nothing')).to be_nil
       end
     end
 
     describe 'xpath' do
       it 'uses filter names passed in' do
-        selector = Capybara::Selector.new :test do
+        described_class.add_selector :test do
           xpath(:something, :other) { |_locator| XPath.descendant }
         end
+        selector = Capybara::Selector.new :test, config: nil, format: nil
 
         expect(selector.expression_filters.keys).to include(:something, :other)
       end
 
       it 'gets filter names from block if none passed to xpath method' do
-        selector = Capybara::Selector.new :test do
+        described_class.add_selector :test do
           xpath { |_locator, valid3:, valid4: nil| "#{valid3} #{valid4}" }
         end
+        selector = Capybara::Selector.new :test, config: nil, format: nil
 
         expect(selector.expression_filters.keys).to include(:valid3, :valid4)
       end
 
       it 'ignores block parameters if names passed in' do
-        selector = Capybara::Selector.new :test do
+        described_class.add_selector :test do
           xpath(:valid1) { |_locator, valid3:, valid4: nil| "#{valid3} #{valid4}" }
         end
+        selector = Capybara::Selector.new :test, config: nil, format: nil
 
         expect(selector.expression_filters.keys).to include(:valid1)
         expect(selector.expression_filters.keys).not_to include(:valid3, :valid4)
@@ -181,25 +206,28 @@ RSpec.describe Capybara do
       end
 
       it 'uses filter names passed in' do
-        selector = Capybara::Selector.new :text do
+        described_class.add_selector :test do
           css(:name, :other_name) { |_locator| '' }
         end
+        selector = Capybara::Selector.new :test, config: nil, format: nil
 
         expect(selector.expression_filters.keys).to include(:name, :other_name)
       end
 
       it 'gets filter names from block if none passed to css method' do
-        selector = Capybara::Selector.new :test do
+        described_class.add_selector :test do
           css { |_locator, valid3:, valid4: nil| "#{valid3} #{valid4}" }
         end
+        selector = Capybara::Selector.new :test, config: nil, format: nil
 
         expect(selector.expression_filters.keys).to include(:valid3, :valid4)
       end
 
       it 'ignores block parameters if names passed in' do
-        selector = Capybara::Selector.new :test do
+        described_class.add_selector :test do
           css(:valid1) { |_locator, valid3:, valid4: nil| "#{valid3} #{valid4}" }
         end
+        selector = Capybara::Selector.new :test, config: nil, format: nil
 
         expect(selector.expression_filters.keys).to include(:valid1)
         expect(selector.expression_filters.keys).not_to include(:valid3, :valid4)
@@ -299,9 +327,23 @@ RSpec.describe Capybara do
           expect(string.find(:custom_xpath_selector, './/div', class: /dOm WoR/i)[:id]).to eq 'random_words'
         end
 
-        it 'accepts Regexp for CSS base selectors' do
+        it 'accepts Regexp for CSS based selectors' do
           expect(string.find(:custom_css_selector, 'div', class: /random/)[:id]).to eq 'random_words'
         end
+
+        it 'accepts Regexp for individual class names for XPath based selectors' do
+          expect(string.find(:custom_xpath_selector, './/div', class: [/random/, 'some'])[:id]).to eq 'random_words'
+          expect(string.find(:custom_xpath_selector, './/div', class: [/om/, /wor/])[:id]).to eq 'random_words'
+          expect { string.find(:custom_xpath_selector, './/div', class: [/not/, /wor/]) }.to raise_error(Capybara::ElementNotFound)
+          expect { string.find(:custom_xpath_selector, './/div', class: [/dom wor/]) }.to raise_error(Capybara::ElementNotFound)
+        end
+
+        it 'accepts Regexp for individual class names for CSS based selectors' do
+          expect(string.find(:custom_css_selector, 'div', class: [/random/])[:id]).to eq 'random_words'
+          expect(string.find(:custom_css_selector, 'div', class: [/om/, /wor/, 'some'])[:id]).to eq 'random_words'
+          expect { string.find(:custom_css_selector, 'div', class: [/not/, /wor/]) }.to raise_error(Capybara::ElementNotFound)
+          expect { string.find(:custom_css_selector, 'div', class: [/dom wor/]) }.to raise_error(Capybara::ElementNotFound)
+        end
       end
 
       context 'with :style option' do
@@ -429,7 +471,7 @@ RSpec.describe Capybara do
         end
 
         it 'includes wildcarded keys in description' do
-          expect { string.find(:element, 'input', not_there: 'bad', presence: true, absence: false, count: 1) }
+          expect { string.all(:element, 'input', not_there: 'bad', presence: true, absence: false, count: 1) }
             .to(raise_error do |e|
               expect(e).to be_a(Capybara::ElementNotFound)
               expect(e.message).to include 'not_there => bad'
@@ -449,14 +491,18 @@ RSpec.describe Capybara do
       end
 
       describe ':link_or_button selector' do
-        around(:all) do |example|
-          Capybara.modify_selector(:link_or_button) do
+        around do |example|
+          described_class.modify_selector(:link_or_button) do
             expression_filter(:random) { |xpath, _| xpath } # do nothing filter
           end
           example.run
           Capybara::Selector[:link_or_button].expression_filters.delete(:random)
         end
 
+        it 'should not find links when disabled == true' do
+          expect(string.all(:link_or_button, disabled: true).size).to eq 0
+        end
+
         context 'when modified' do
           it 'should still work' do
             filter = Capybara::Selector[:link_or_button].expression_filters[:random]
@@ -467,6 +513,16 @@ RSpec.describe Capybara do
           end
         end
       end
+
+      describe ':table selector' do
+        it 'finds by rows' do
+          expect(string.find(:table, with_rows: [%w[D E F]])[:id]).to eq 'rows'
+        end
+
+        it 'finds by columns' do
+          expect(string.find(:table, with_cols: [%w[A B C]])[:id]).to eq 'cols'
+        end
+      end
     end
   end
 end

data/spec/selenium_spec_chrome.rb

@@ -3,26 +3,77 @@
 require 'spec_helper'
 require 'selenium-webdriver'
 require 'shared_selenium_session'
+require 'shared_selenium_node'
 require 'rspec/shared_spec_matchers'
 
 CHROME_DRIVER = :selenium_chrome
 
-browser_options = ::Selenium::WebDriver::Chrome::Options.new
-browser_options.headless! if ENV['HEADLESS']
-browser_options.add_option(:w3c, !!ENV['W3C'])
+Selenium::WebDriver::Chrome.path = '/usr/bin/google-chrome-beta' if ENV.fetch('CI', nil) && ENV.fetch('CHROME_BETA', nil)
+
+Selenium::WebDriver.logger.ignore(:selenium_manager)
+
+browser_options = if ENV['HEADLESS']
+  Selenium::WebDriver::Options.chrome(args: ['--headless=new'])
+else
+  Selenium::WebDriver::Options.chrome
+end
+
+# Chromedriver 77 requires setting this for headless mode on linux
+# Different versions of Chrome/selenium-webdriver require setting differently - jus set them all
+browser_options.add_preference('download.default_directory', Capybara.save_path)
+browser_options.add_preference(:download, default_directory: Capybara.save_path)
 
 Capybara.register_driver :selenium_chrome do |app|
-  Capybara::Selenium::Driver.new(app, browser: :chrome, options: browser_options, timeout: 30).tap do |driver|
+  version = Capybara::Selenium::Driver.load_selenium
+  options_key = Capybara::Selenium::Driver::CAPS_VERSION.satisfied_by?(version) ? :capabilities : :options
+  driver_options = { browser: :chrome, timeout: 30 }.tap do |opts|
+    opts[options_key] = browser_options
+  end
+
+  Capybara::Selenium::Driver.new(app, **driver_options).tap do |driver|
+    # Set download dir for Chrome < 77
     driver.browser.download_path = Capybara.save_path
   end
 end
 
 Capybara.register_driver :selenium_chrome_not_clear_storage do |app|
-  chrome_options = {
-    browser: :chrome,
-    options: browser_options
-  }
-  Capybara::Selenium::Driver.new(app, chrome_options.merge(clear_local_storage: false, clear_session_storage: false))
+  version = Capybara::Selenium::Driver.load_selenium
+  options_key = Capybara::Selenium::Driver::CAPS_VERSION.satisfied_by?(version) ? :capabilities : :options
+  chrome_options = { browser: :chrome, clear_local_storage: false, clear_session_storage: false }.tap do |opts|
+    opts[options_key] = browser_options
+  end
+
+  Capybara::Selenium::Driver.new(app, **chrome_options)
+end
+
+Capybara.register_driver :selenium_chrome_not_clear_session_storage do |app|
+  version = Capybara::Selenium::Driver.load_selenium
+  options_key = Capybara::Selenium::Driver::CAPS_VERSION.satisfied_by?(version) ? :capabilities : :options
+  chrome_options = { browser: :chrome, clear_session_storage: false }.tap do |opts|
+    opts[options_key] = browser_options
+  end
+
+  Capybara::Selenium::Driver.new(app, **chrome_options)
+end
+
+Capybara.register_driver :selenium_chrome_not_clear_local_storage do |app|
+  version = Capybara::Selenium::Driver.load_selenium
+  options_key = Capybara::Selenium::Driver::CAPS_VERSION.satisfied_by?(version) ? :capabilities : :options
+  chrome_options = { browser: :chrome, clear_local_storage: false }.tap do |opts|
+    opts[options_key] = browser_options
+  end
+  Capybara::Selenium::Driver.new(app, **chrome_options)
+end
+
+Capybara.register_driver :selenium_driver_subclass_with_chrome do |app|
+  version = Capybara::Selenium::Driver.load_selenium
+  options_key = Capybara::Selenium::Driver::CAPS_VERSION.satisfied_by?(version) ? :capabilities : :options
+  subclass = Class.new(Capybara::Selenium::Driver)
+  chrome_options = { browser: :chrome, timeout: 30 }.tap do |opts|
+    opts[options_key] = browser_options
+  end
+
+  subclass.new(app, **chrome_options)
 end
 
 module TestSessions
@@ -31,42 +82,65 @@ end
 
 skipped_tests = %i[response_headers status_code trigger]
 
-$stdout.puts `#{Selenium::WebDriver::Chrome.driver_path} --version` if ENV['CI']
+Capybara::SpecHelper.log_selenium_driver_version(Selenium::WebDriver::Chrome) if ENV['CI']
 
 Capybara::SpecHelper.run_specs TestSessions::Chrome, CHROME_DRIVER.to_s, capybara_skip: skipped_tests do |example|
   case example.metadata[:full_description]
   when /#click_link can download a file$/
     skip 'Need to figure out testing of file downloading on windows platform' if Gem.win_platform?
-  when /Capybara::Session selenium_chrome Capybara::Window#maximize/
-    pending "Chrome headless doesn't support maximize" if ENV['HEADLESS']
+  when /Capybara::Session selenium_chrome node #shadow_root should get visible text/
+    pending "Selenium doesn't currently support getting visible text for shadow root elements"
+  when /Capybara::Session selenium_chrome node #shadow_root/
+    skip 'Not supported with this chromedriver version' if chromedriver_lt?('96.0', @session)
   end
 end
 
 RSpec.describe 'Capybara::Session with chrome' do
   include Capybara::SpecHelper
-  include_examples  'Capybara::Session', TestSessions::Chrome, CHROME_DRIVER
-  include_examples  Capybara::RSpecMatchers, TestSessions::Chrome, CHROME_DRIVER
+  ['Capybara::Session', 'Capybara::Node', Capybara::RSpecMatchers].each do |examples|
+    include_examples examples, TestSessions::Chrome, CHROME_DRIVER
+  end
 
   context 'storage' do
     describe '#reset!' do
       it 'clears storage by default' do
-        @session = TestSessions::Chrome
-        @session.visit('/with_js')
-        @session.find(:css, '#set-storage').click
-        @session.reset!
-        @session.visit('/with_js')
-        expect(@session.evaluate_script('Object.keys(localStorage)')).to be_empty
-        expect(@session.evaluate_script('Object.keys(sessionStorage)')).to be_empty
+        session = TestSessions::Chrome
+        session.visit('/with_js')
+        session.find(:css, '#set-storage').click
+        session.reset!
+        session.visit('/with_js')
+        expect(session.evaluate_script('Object.keys(localStorage)')).to be_empty
+        expect(session.evaluate_script('Object.keys(sessionStorage)')).to be_empty
       end
 
       it 'does not clear storage when false' do
-        @session = Capybara::Session.new(:selenium_chrome_not_clear_storage, TestApp)
-        @session.visit('/with_js')
-        @session.find(:css, '#set-storage').click
-        @session.reset!
-        @session.visit('/with_js')
-        expect(@session.evaluate_script('Object.keys(localStorage)')).not_to be_empty
-        expect(@session.evaluate_script('Object.keys(sessionStorage)')).not_to be_empty
+        session = Capybara::Session.new(:selenium_chrome_not_clear_storage, TestApp)
+        session.visit('/with_js')
+        session.find(:css, '#set-storage').click
+        session.reset!
+        session.visit('/with_js')
+        expect(session.evaluate_script('Object.keys(localStorage)')).not_to be_empty
+        expect(session.evaluate_script('Object.keys(sessionStorage)')).not_to be_empty
+      end
+
+      it 'can not clear session storage' do
+        session = Capybara::Session.new(:selenium_chrome_not_clear_session_storage, TestApp)
+        session.visit('/with_js')
+        session.find(:css, '#set-storage').click
+        session.reset!
+        session.visit('/with_js')
+        expect(session.evaluate_script('Object.keys(localStorage)')).to be_empty
+        expect(session.evaluate_script('Object.keys(sessionStorage)')).not_to be_empty
+      end
+
+      it 'can not clear local storage' do
+        session = Capybara::Session.new(:selenium_chrome_not_clear_local_storage, TestApp)
+        session.visit('/with_js')
+        session.find(:css, '#set-storage').click
+        session.reset!
+        session.visit('/with_js')
+        expect(session.evaluate_script('Object.keys(localStorage)')).not_to be_empty
+        expect(session.evaluate_script('Object.keys(sessionStorage)')).to be_empty
       end
     end
   end
@@ -79,29 +153,57 @@ RSpec.describe 'Capybara::Session with chrome' do
 
   describe 'filling in Chrome-specific date and time fields with keystrokes' do
     let(:datetime) { Time.new(1983, 6, 19, 6, 30) }
+    let(:session) { TestSessions::Chrome }
 
     before do
-      @session = TestSessions::Chrome
-      @session.visit('/form')
+      session.visit('/form')
     end
 
     it 'should fill in a date input with a String' do
-      @session.fill_in('form_date', with: '06/19/1983')
-      @session.click_button('awesome')
-      expect(Date.parse(extract_results(@session)['date'])).to eq datetime.to_date
+      session.fill_in('form_date', with: '06/19/1983')
+      session.click_button('awesome')
+      expect(Date.parse(extract_results(session)['date'])).to eq datetime.to_date
     end
 
     it 'should fill in a time input with a String' do
-      @session.fill_in('form_time', with: '06:30A')
-      @session.click_button('awesome')
-      results = extract_results(@session)['time']
+      session.fill_in('form_time', with: '06:30A')
+      session.click_button('awesome')
+      results = extract_results(session)['time']
       expect(Time.parse(results).strftime('%r')).to eq datetime.strftime('%r')
     end
 
     it 'should fill in a datetime input with a String' do
-      @session.fill_in('form_datetime', with: "06/19/1983\t06:30A")
-      @session.click_button('awesome')
-      expect(Time.parse(extract_results(@session)['datetime'])).to eq datetime
+      session.fill_in('form_datetime', with: "06/19/1983\t06:30A")
+      session.click_button('awesome')
+      expect(Time.parse(extract_results(session)['datetime'])).to eq datetime
+    end
+  end
+
+  describe 'using subclass of selenium driver' do
+    it 'works' do
+      session = Capybara::Session.new(:selenium_driver_subclass_with_chrome, TestApp)
+      session.visit('/form')
+      expect(session).to have_current_path('/form')
+    end
+  end
+
+  describe 'log access' do
+    let(:logs) do
+      session.driver.browser.then do |chrome_driver|
+        chrome_driver.respond_to?(:logs) ? chrome_driver : chrome_driver.manage
+      end.logs
+    end
+
+    it 'does not error getting log types' do
+      expect do
+        logs.available_types
+      end.not_to raise_error
+    end
+
+    it 'does not error when getting logs' do
+      expect do
+        logs.get(:browser)
+      end.not_to raise_error
     end
   end
 end