capybara 3.13.2 → 3.40.0

data/spec/rack_test_spec.rb

@@ -1,12 +1,6 @@
 # frozen_string_literal: true
 
 require 'spec_helper'
-nokogumbo_required = begin
-                       require 'nokogumbo'
-                       true
-                     rescue LoadError
-                       false
-                     end
 
 module TestSessions
   RackTest = Capybara::Session.new(:rack_test, TestApp)
@@ -25,6 +19,10 @@ skipped_tests = %i[
   download
   css
   scroll
+  spatial
+  html_validation
+  shadow_dom
+  active_element
 ]
 Capybara::SpecHelper.run_specs TestSessions::RackTest, 'RackTest', capybara_skip: skipped_tests do |example|
   case example.metadata[:full_description]
@@ -32,111 +30,145 @@ Capybara::SpecHelper.run_specs TestSessions::RackTest, 'RackTest', capybara_skip
     skip "Nokogiri doesn't support case insensitive CSS attribute matchers"
   when /#click_button should follow permanent redirects that maintain method/
     skip "Rack < 2 doesn't support 308" if Gem.loaded_specs['rack'].version < Gem::Version.new('2.0.0')
+  when /#attach_file with multipart form should send prior hidden field if no file submitted/
+    skip 'Rack-test < 2 needs an empty file to detect multipart form' if Gem.loaded_specs['rack-test'].version < Gem::Version.new('2.0.0')
   end
 end
 
 RSpec.describe Capybara::Session do # rubocop:disable RSpec/MultipleDescribes
+  include Capybara::RSpecMatchers
   context 'with rack test driver' do
-    before do
-      @session = TestSessions::RackTest
-    end
+    let(:session) { TestSessions::RackTest }
 
     describe '#driver' do
       it 'should be a rack test driver' do
-        expect(@session.driver).to be_an_instance_of(Capybara::RackTest::Driver)
+        expect(session.driver).to be_an_instance_of(Capybara::RackTest::Driver)
       end
     end
 
     describe '#mode' do
       it 'should remember the mode' do
-        expect(@session.mode).to eq(:rack_test)
+        expect(session.mode).to eq(:rack_test)
       end
     end
 
     describe '#click_link' do
       after do
-        @session.driver.options[:respect_data_method] = false
+        session.driver.options[:respect_data_method] = false
       end
 
       it 'should use data-method if option is true' do
-        @session.driver.options[:respect_data_method] = true
-        @session.visit '/with_html'
-        @session.click_link 'A link with data-method'
-        expect(@session.html).to include('The requested object was deleted')
+        session.driver.options[:respect_data_method] = true
+        session.visit '/with_html'
+        session.click_link 'A link with data-method'
+        expect(session.html).to include('The requested object was deleted')
       end
 
       it 'should not use data-method if option is false' do
-        @session.driver.options[:respect_data_method] = false
-        @session.visit '/with_html'
-        @session.click_link 'A link with data-method'
-        expect(@session.html).to include('Not deleted')
+        session.driver.options[:respect_data_method] = false
+        session.visit '/with_html'
+        session.click_link 'A link with data-method'
+        expect(session.html).to include('Not deleted')
       end
 
       it "should use data-method if available even if it's capitalized" do
-        @session.driver.options[:respect_data_method] = true
-        @session.visit '/with_html'
-        @session.click_link 'A link with capitalized data-method'
-        expect(@session.html).to include('The requested object was deleted')
+        session.driver.options[:respect_data_method] = true
+        session.visit '/with_html'
+        session.click_link 'A link with capitalized data-method'
+        expect(session.html).to include('The requested object was deleted')
       end
     end
 
     describe '#fill_in' do
       it 'should warn that :fill_options are not supported' do
-        allow_any_instance_of(Capybara::RackTest::Node).to receive(:warn)
-        @session.visit '/with_html'
-        field = @session.fill_in 'test_field', with: 'not_monkey', fill_options: { random: true }
-        expect(@session).to have_field('test_field', with: 'not_monkey')
-        expect(field.base).to have_received(:warn).with("Options passed to Node#set but the RackTest driver doesn't support any - ignoring")
+        session.visit '/with_html'
+        expect { session.fill_in 'test_field', with: 'not_monkey', fill_options: { random: true } }.to \
+          output(/^Options passed to Node#set but the RackTest driver doesn't support any - ignoring/).to_stderr
+        expect(session).to have_field('test_field', with: 'not_monkey')
       end
     end
 
     describe '#attach_file' do
       context 'with multipart form' do
         it 'should submit an empty form-data section if no file is submitted' do
-          @session.visit('/form')
-          @session.click_button('Upload Empty')
-          expect(@session.html).to include('Successfully ignored empty file field.')
+          session.visit('/form')
+          session.click_button('Upload Empty')
+          expect(session.html).to include('Successfully ignored empty file field.')
+        end
+
+        it 'should submit multipart even if no file is submitted' do
+          session.visit('/form')
+          session.click_button('Upload Empty')
+          expect(session.html).to include('Content type was multipart/form-data;')
         end
       end
 
       it 'should not submit an obsolete mime type' do
-        @test_jpg_file_path = File.expand_path('fixtures/capybara.csv', File.dirname(__FILE__))
-        @session.visit('/form')
-        @session.attach_file 'form_document', @test_jpg_file_path
-        @session.click_button('Upload Single')
-        expect(@session).to have_content('Content-type: text/csv')
+        test_jpg_file_path = File.expand_path('fixtures/capybara.csv', File.dirname(__FILE__))
+        session.visit('/form')
+        session.attach_file 'form_document', test_jpg_file_path
+        session.click_button('Upload Single')
+        expect(session).to have_content('Content-type: text/csv')
       end
     end
 
     describe '#click' do
       context 'on a label' do
         it 'should toggle the associated checkbox' do
-          @session.visit('/form')
-          expect(@session).to have_unchecked_field('form_pets_cat')
-          @session.find(:label, 'Cat').click
-          expect(@session).to have_checked_field('form_pets_cat')
-          @session.find(:label, 'Cat').click
-          expect(@session).to have_unchecked_field('form_pets_cat')
-          @session.find(:label, 'McLaren').click
-          expect(@session).to have_checked_field('form_cars_mclaren', visible: :hidden)
+          session.visit('/form')
+          expect(session).to have_unchecked_field('form_pets_cat')
+          session.find(:label, 'Cat').click
+          expect(session).to have_checked_field('form_pets_cat')
+          session.find(:label, 'Cat').click
+          expect(session).to have_unchecked_field('form_pets_cat')
+          session.find(:label, 'McLaren').click
+          expect(session).to have_checked_field('form_cars_mclaren', visible: :hidden)
         end
 
         it 'should toggle the associated radio' do
-          @session.visit('/form')
-          expect(@session).to have_unchecked_field('gender_male')
-          @session.find(:label, 'Male').click
-          expect(@session).to have_checked_field('gender_male')
-          @session.find(:label, 'Female').click
-          expect(@session).to have_unchecked_field('gender_male')
+          session.visit('/form')
+          expect(session).to have_unchecked_field('gender_male')
+          session.find(:label, 'Male').click
+          expect(session).to have_checked_field('gender_male')
+          session.find(:label, 'Female').click
+          expect(session).to have_unchecked_field('gender_male')
+        end
+
+        it 'should rewrite the forms action query for get submission' do
+          session.visit('/form')
+          session.click_button('mediocre')
+          expect(session).not_to have_current_path(/foo|bar/)
         end
+
+        it 'should rewrite the submit buttons formaction query for get submission' do
+          session.visit('/form')
+          session.click_button('mediocre2')
+          expect(session).not_to have_current_path(/foo|bar/)
+        end
+      end
+    end
+
+    describe '#send_keys' do
+      it 'raises an UnsupportedMethodError' do
+        session.visit('/form')
+
+        expect { session.send_keys(:tab) }.to raise_error(Capybara::NotSupportedByDriverError)
+      end
+    end
+
+    describe '#active_element' do
+      it 'raises an UnsupportedMethodError' do
+        session.visit('/form')
+
+        expect { session.active_element }.to raise_error(Capybara::NotSupportedByDriverError)
       end
     end
 
     describe '#text' do
       it 'should return original text content for textareas' do
-        @session.visit('/with_html')
-        @session.find_field('normal', type: 'textarea', with: 'banana').set('hello')
-        normal = @session.find(:css, '#normal')
+        session.visit('/with_html')
+        session.find_field('normal', type: 'textarea', with: 'banana').set('hello')
+        normal = session.find(:css, '#normal')
         expect(normal.value).to eq 'hello'
         expect(normal.text).to eq 'banana'
       end
@@ -144,8 +176,8 @@ RSpec.describe Capybara::Session do # rubocop:disable RSpec/MultipleDescribes
 
     describe '#style' do
       it 'should raise an error' do
-        @session.visit('/with_html')
-        el = @session.find(:css, '#first')
+        session.visit('/with_html')
+        el = session.find(:css, '#first')
         expect { el.style('display') }.to raise_error NotImplementedError, /not process CSS/
       end
     end
@@ -153,87 +185,87 @@ RSpec.describe Capybara::Session do # rubocop:disable RSpec/MultipleDescribes
 end
 
 RSpec.describe Capybara::RackTest::Driver do
-  before do
-    @driver = TestSessions::RackTest.driver
-  end
+  let(:driver) { TestSessions::RackTest.driver }
 
   describe ':headers option' do
     it 'should always set headers' do
-      @driver = Capybara::RackTest::Driver.new(TestApp, headers: { 'HTTP_FOO' => 'foobar' })
-      @driver.visit('/get_header')
-      expect(@driver.html).to include('foobar')
+      driver = described_class.new(TestApp, headers: { 'HTTP_FOO' => 'foobar' })
+      driver.visit('/get_header')
+      expect(driver.html).to include('foobar')
     end
 
     it 'should keep headers on link clicks' do
-      @driver = Capybara::RackTest::Driver.new(TestApp, headers: { 'HTTP_FOO' => 'foobar' })
-      @driver.visit('/header_links')
-      @driver.find_xpath('.//a').first.click
-      expect(@driver.html).to include('foobar')
+      driver = described_class.new(TestApp, headers: { 'HTTP_FOO' => 'foobar' })
+      driver.visit('/header_links')
+      driver.find_xpath('.//a').first.click
+      expect(driver.html).to include('foobar')
     end
 
     it 'should keep headers on form submit' do
-      @driver = Capybara::RackTest::Driver.new(TestApp, headers: { 'HTTP_FOO' => 'foobar' })
-      @driver.visit('/header_links')
-      @driver.find_xpath('.//input').first.click
-      expect(@driver.html).to include('foobar')
+      driver = described_class.new(TestApp, headers: { 'HTTP_FOO' => 'foobar' })
+      driver.visit('/header_links')
+      driver.find_xpath('.//input').first.click
+      expect(driver.html).to include('foobar')
     end
 
     it 'should keep headers on redirects' do
-      @driver = Capybara::RackTest::Driver.new(TestApp, headers: { 'HTTP_FOO' => 'foobar' })
-      @driver.visit('/get_header_via_redirect')
-      expect(@driver.html).to include('foobar')
+      driver = described_class.new(TestApp, headers: { 'HTTP_FOO' => 'foobar' })
+      driver.visit('/get_header_via_redirect')
+      expect(driver.html).to include('foobar')
     end
   end
 
   describe ':follow_redirects option' do
     it 'defaults to following redirects' do
-      @driver = Capybara::RackTest::Driver.new(TestApp)
+      driver = described_class.new(TestApp)
+
+      driver.visit('/redirect')
+      expect(driver.response.headers['Location']).to be_nil
+      expect(driver.current_url).to match %r{/landed$}
+    end
 
-      @driver.visit('/redirect')
-      expect(@driver.response.header['Location']).to be_nil
-      expect(@driver.current_url).to match %r{/landed$}
+    it 'should not include fragments in the referer header' do
+      driver.visit('/header_links#an-anchor')
+      driver.find_xpath('.//input').first.click
+      expect(driver.request.get_header('HTTP_REFERER')).to eq('http://www.example.com/header_links')
     end
 
     it 'is possible to not follow redirects' do
-      @driver = Capybara::RackTest::Driver.new(TestApp, follow_redirects: false)
+      driver = described_class.new(TestApp, follow_redirects: false)
 
-      @driver.visit('/redirect')
-      expect(@driver.response.header['Location']).to match %r{/redirect_again$}
-      expect(@driver.current_url).to match %r{/redirect$}
+      driver.visit('/redirect')
+      expect(driver.response.headers['Location']).to match %r{/redirect_again$}
+      expect(driver.current_url).to match %r{/redirect$}
     end
   end
 
   describe ':redirect_limit option' do
     context 'with default redirect limit' do
-      before do
-        @driver = Capybara::RackTest::Driver.new(TestApp)
-      end
+      let(:driver) { described_class.new(TestApp) }
 
       it 'should follow 5 redirects' do
-        @driver.visit('/redirect/5/times')
-        expect(@driver.html).to include('redirection complete')
+        driver.visit('/redirect/5/times')
+        expect(driver.html).to include('redirection complete')
       end
 
       it 'should not follow more than 6 redirects' do
         expect do
-          @driver.visit('/redirect/6/times')
+          driver.visit('/redirect/6/times')
         end.to raise_error(Capybara::InfiniteRedirectError)
       end
     end
 
     context 'with 21 redirect limit' do
-      before do
-        @driver = Capybara::RackTest::Driver.new(TestApp, redirect_limit: 21)
-      end
+      let(:driver) { described_class.new(TestApp, redirect_limit: 21) }
 
       it 'should follow 21 redirects' do
-        @driver.visit('/redirect/21/times')
-        expect(@driver.html).to include('redirection complete')
+        driver.visit('/redirect/21/times')
+        expect(driver.html).to include('redirection complete')
       end
 
       it 'should not follow more than 21 redirects' do
         expect do
-          @driver.visit('/redirect/22/times')
+          driver.visit('/redirect/22/times')
         end.to raise_error(Capybara::InfiniteRedirectError)
       end
     end
@@ -241,11 +273,12 @@ RSpec.describe Capybara::RackTest::Driver do
 end
 
 RSpec.describe 'Capybara::String' do
-  it 'should use gumbo' do
-    skip 'Only  valid if gumbo is included' unless nokogumbo_required
-    allow(Nokogiri).to receive(:HTML5).and_call_original
+  it 'should use HTML5 parsing' do
+    skip 'Only valid if Nokogiri >= 1.12.0 or gumbo is included' unless defined? Nokogiri::HTML5
+    Capybara.use_html5_parsing = true
+    allow(Nokogiri::HTML5).to receive(:parse).and_call_original
     Capybara.string('<div id=test_div></div>')
-    expect(Nokogiri).to have_received(:HTML5)
+    expect(Nokogiri::HTML5).to have_received(:parse)
   end
 end
 
@@ -259,6 +292,6 @@ RSpec.describe Capybara::RackTest::CSSHandlers do
   include CSSHandlerIncludeTester
 
   it 'should not be extended by global includes' do
-    expect(Capybara::RackTest::CSSHandlers.new).not_to respond_to(:dont_extend_css_handler)
+    expect(described_class.new).not_to respond_to(:dont_extend_css_handler)
   end
 end

data/spec/regexp_dissassembler_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe Capybara::Selector::RegexpDisassembler do
+RSpec.describe Capybara::Selector::RegexpDisassembler, :aggregate_failures do
   it 'handles strings' do
     verify_strings(
       /abcdef/ => %w[abcdef],
@@ -44,20 +44,22 @@ RSpec.describe Capybara::Selector::RegexpDisassembler do
       /abc?def?g/ => %w[ab de g],
       /d?/ => []
     }.each do |regexp, expected|
-      expect(Capybara::Selector::RegexpDisassembler.new(regexp).substrings).to eq expected
+      expect(described_class.new(regexp).substrings).to eq expected
     end
   end
 
   it 'handles optional characters for #alternated_substrings' do
     verify_alternated_strings(
-      /abc*def/ => [%w[ab def]],
-      /abc*/ => [%w[ab]],
-      /c*/ => [],
-      /abc?def/ => [%w[abdef], %w[abcdef]],
-      /abc?/ => [%w[ab]],
-      /abc?def?/ => [%w[abde], %w[abcde]],
-      /abc?def?g/ => [%w[abdeg], %w[abdefg], %w[abcdeg], %w[abcdefg]],
-      /d?/ => []
+      {
+        /abc*def/ => [%w[ab def]],
+        /abc*/ => [%w[ab]],
+        /c*/ => [],
+        /abc?def/ => [%w[abdef], %w[abcdef]],
+        /abc?/ => [%w[ab]],
+        /abc?def?/ => [%w[abde], %w[abcde]],
+        /abc?def?g/ => [%w[abdeg], %w[abdefg], %w[abcdeg], %w[abcdefg]],
+        /d?/ => []
+      }
     )
   end
 
@@ -131,40 +133,42 @@ RSpec.describe Capybara::Selector::RegexpDisassembler do
       /ab(cd|cd)?ef/ => %w[ab ef],
       /ab\\?cd/ => %w[ab cd]
     }.each do |regexp, expected|
-      expect(Capybara::Selector::RegexpDisassembler.new(regexp).substrings).to eq expected
+      expect(described_class.new(regexp).substrings).to eq expected
     end
   end
 
   it 'handles alternation for #alternated_substrings' do
     verify_alternated_strings(
-      /abc|def/ => [%w[abc], %w[def]],
-      /ab(?:c|d)/ => [%w[abc], %w[abd]],
-      /ab(c|d|e)fg/ => [%w[abcfg], %w[abdfg], %w[abefg]],
-      /ab?(c|d)fg/ => [%w[acfg], %w[adfg], %w[abcfg], %w[abdfg]],
-      /ab(c|d)ef/ => [%w[abcef], %w[abdef]],
-      /ab(cd?|ef)g/ => [%w[abcg], %w[abcdg], %w[abefg]],
-      /ab(cd|ef*)g/ => [%w[abcdg], %w[abe g]],
-      /ab|cd*/ => [%w[ab], %w[c]],
-      /cd(?:ef|gh)|xyz/ => [%w[cdef], %w[cdgh], %w[xyz]],
-      /(cd(?:ef|gh)|xyz)/ => [%w[cdef], %w[cdgh], %w[xyz]],
-      /cd(ef|gh)+/ => [%w[cdef], %w[cdgh]],
-      /cd(ef|gh)?/ => [%w[cd]],
-      /cd(ef|gh)?ij/ => [%w[cdij], %w[cdefij], %w[cdghij]],
-      /cd(ef|gh)+ij/ => [%w[cdef ij], %w[cdgh ij]],
-      /cd(ef|gh){2}ij/ => [%w[cdefefij], %w[cdefghij], %w[cdghefij], %w[cdghghij]],
-      /(cd(ef|g*))/ => [%w[cd]],
-      /a|b*/ => [],
-      /ab(?:c|d?)/ => [%w[ab]],
-      /ab(c|d)|a*/ => [],
-      /(abc)?(d|e)/ => [%w[d], %w[e]],
-      /(abc*de)?(d|e)/ => [%w[d], %w[e]],
-      /(abc*de)?(d|e?)/ => [],
-      /(abc)?(d|e?)/ => [],
-      /ab(cd){0,2}ef/ => [%w[ab ef]],
-      /ab(cd){0,1}ef/ => [%w[abef], %w[abcdef]],
-      /ab(cd|cd)ef/ => [%w[abcdef]],
-      /ab(cd|cd)?ef/ => [%w[abef], %w[abcdef]],
-      /ab\\?cd/ => [%w[abcd], %w[ab\cd]]
+      {
+        /abc|def/ => [%w[abc], %w[def]],
+        /ab(?:c|d)/ => [%w[abc], %w[abd]],
+        /ab(c|d|e)fg/ => [%w[abcfg], %w[abdfg], %w[abefg]],
+        /ab?(c|d)fg/ => [%w[acfg], %w[adfg], %w[abcfg], %w[abdfg]],
+        /ab(c|d)ef/ => [%w[abcef], %w[abdef]],
+        /ab(cd?|ef)g/ => [%w[abcg], %w[abcdg], %w[abefg]],
+        /ab(cd|ef*)g/ => [%w[abcdg], %w[abe g]],
+        /ab|cd*/ => [%w[ab], %w[c]],
+        /cd(?:ef|gh)|xyz/ => [%w[cdef], %w[cdgh], %w[xyz]],
+        /(cd(?:ef|gh)|xyz)/ => [%w[cdef], %w[cdgh], %w[xyz]],
+        /cd(ef|gh)+/ => [%w[cdef], %w[cdgh]],
+        /cd(ef|gh)?/ => [%w[cd]],
+        /cd(ef|gh)?ij/ => [%w[cdij], %w[cdefij], %w[cdghij]],
+        /cd(ef|gh)+ij/ => [%w[cdef ij], %w[cdgh ij]],
+        /cd(ef|gh){2}ij/ => [%w[cdefefij], %w[cdefghij], %w[cdghefij], %w[cdghghij]],
+        /(cd(ef|g*))/ => [%w[cd]],
+        /a|b*/ => [],
+        /ab(?:c|d?)/ => [%w[ab]],
+        /ab(c|d)|a*/ => [],
+        /(abc)?(d|e)/ => [%w[d], %w[e]],
+        /(abc*de)?(d|e)/ => [%w[d], %w[e]],
+        /(abc*de)?(d|e?)/ => [],
+        /(abc)?(d|e?)/ => [],
+        /ab(cd){0,2}ef/ => [%w[ab ef]],
+        /ab(cd){0,1}ef/ => [%w[abef], %w[abcdef]],
+        /ab(cd|cd)ef/ => [%w[abcdef]],
+        /ab(cd|cd)?ef/ => [%w[abef], %w[abcdef]],
+        /ab\\?cd/ => [%w[abcd], %w[ab\cd]]
+      }
     )
   end
 
@@ -212,6 +216,16 @@ RSpec.describe Capybara::Selector::RegexpDisassembler do
     )
   end
 
+  it 'ignores negative lookaheads' do
+    verify_strings(
+      /^(?!.*\bContributing Editor\b).*$/ => %w[],
+      /abc(?!.*def).*/ => %w[abc],
+      /(?!.*def)abc/ => %w[abc],
+      /abc(?!.*def.*).*ghi/ => %w[abc ghi],
+      /abc(?!.*bcd)def/ => %w[abcdef]
+    )
+  end
+
   it 'handles anchors' do
     verify_strings(
       /^abc/ => %w[abc],