capybara 3.0.0 → 3.40.0

data/lib/capybara/spec/session/window/window_spec.rb

@@ -1,94 +1,97 @@
 # frozen_string_literal: true
 
+# NOTE: This file uses `sleep` to sync up parts of the tests. This is only implemented like this
+# because of the methods being tested. In tests using Capybara this type of behavior should be implemented
+# using Capybara provided assertions with builtin waiting behavior.
+
 Capybara::SpecHelper.spec Capybara::Window, requires: [:windows] do
-  before(:each) do
-    @window = @session.current_window
+  let!(:orig_window) { @session.current_window }
+  before do
     @session.visit('/with_windows')
   end
-  after(:each) do
-    (@session.windows - [@window]).each do |w|
+
+  after do
+    (@session.windows - [orig_window]).each do |w|
       @session.switch_to_window w
       w.close
     end
-    @session.switch_to_window(@window)
+    @session.switch_to_window(orig_window)
   end
 
   describe '#exists?' do
-    before(:each) do
-      @other_window = @session.window_opened_by do
+    it 'should become false after window was closed' do
+      other_window = @session.window_opened_by do
         @session.find(:css, '#openWindow').click
       end
-    end
 
-    it "should become false after window was closed" do
       expect do
-        @session.switch_to_window @other_window
-        @other_window.close
-      end.to change { @other_window.exists? }.from(true).to(false)
+        @session.switch_to_window other_window
+        other_window.close
+      end.to change(other_window, :exists?).from(true).to(false)
     end
   end
 
   describe '#closed?' do
-    it "should become true after window was closed" do
-      @other_window = @session.window_opened_by do
+    it 'should become true after window was closed' do
+      other_window = @session.window_opened_by do
         @session.find(:css, '#openWindow').click
       end
       expect do
-        @session.switch_to_window @other_window
-        @other_window.close
-      end.to change { @other_window.closed? }.from(false).to(true)
+        @session.switch_to_window other_window
+        other_window.close
+      end.to change { other_window.closed? }.from(false).to(true)
     end
   end
 
   describe '#current?' do
-    before(:each) do
-      @other_window = @session.window_opened_by do
+    let(:other_window) do
+      @session.window_opened_by do
         @session.find(:css, '#openWindow').click
       end
     end
 
     it 'should become true after switching to window' do
       expect do
-        @session.switch_to_window(@other_window)
-      end.to change { @other_window.current? }.from(false).to(true)
+        @session.switch_to_window(other_window)
+      end.to change(other_window, :current?).from(false).to(true)
     end
 
     it 'should return false if window is closed' do
-      @session.switch_to_window(@other_window)
-      @other_window.close
-      expect(@other_window.current?).to eq(false)
+      @session.switch_to_window(other_window)
+      other_window.close
+      expect(other_window.current?).to be(false)
     end
   end
 
   describe '#close' do
-    before(:each) do
-      @other_window = @session.window_opened_by do
+    let!(:other_window) do
+      @session.window_opened_by do
         @session.find(:css, '#openWindow').click
       end
     end
 
     it 'should switch to original window if invoked not for current window' do
       expect(@session.windows.size).to eq(2)
-      expect(@session.current_window).to eq(@window)
-      @other_window.close
+      expect(@session.current_window).to eq(orig_window)
+      other_window.close
       expect(@session.windows.size).to eq(1)
-      expect(@session.current_window).to eq(@window)
+      expect(@session.current_window).to eq(orig_window)
     end
 
     it 'should make subsequent invocations of other methods raise no_such_window_error if invoked for current window' do
-      @session.switch_to_window(@other_window)
-      expect(@session.current_window).to eq(@other_window)
-      @other_window.close
+      @session.switch_to_window(other_window)
+      expect(@session.current_window).to eq(other_window)
+      other_window.close
       expect do
         @session.find(:css, '#some_id')
       end.to raise_error(@session.driver.no_such_window_error)
-      @session.switch_to_window(@window)
+      @session.switch_to_window(orig_window)
     end
   end
 
   describe '#size' do
     def win_size
-      @session.evaluate_script("[window.outerWidth || window.innerWidth, window.outerHeight || window.innerHeight]")
+      @session.evaluate_script('[window.outerWidth || window.innerWidth, window.outerHeight || window.innerHeight]')
     end
 
     it 'should return size of whole window', requires: %i[windows js] do
@@ -96,42 +99,57 @@ Capybara::SpecHelper.spec Capybara::Window, requires: [:windows] do
     end
 
     it 'should switch to original window if invoked not for current window' do
-      @other_window = @session.window_opened_by do
+      other_window = @session.window_opened_by do
         @session.find(:css, '#openWindow').click
       end
       sleep 1
-      size = @session.within_window(@other_window) do
+      size = @session.within_window(other_window) do
         win_size
       end
-      expect(@other_window.size).to eq(size)
-      expect(@session.current_window).to eq(@window)
+      expect(other_window.size).to eq(size)
+      expect(@session.current_window).to eq(orig_window)
     end
   end
 
   describe '#resize_to' do
+    let!(:initial_size) { @session.current_window.size }
+
+    after do
+      @session.current_window.resize_to(*initial_size)
+      sleep 1
+    end
+
     it 'should be able to resize window', requires: %i[windows js] do
-      width, height = @session.current_window.size
+      width, height = initial_size
       @session.current_window.resize_to(width - 100, height - 100)
       sleep 1
       expect(@session.current_window.size).to eq([width - 100, height - 100])
     end
 
     it 'should stay on current window if invoked not for current window', requires: %i[windows js] do
-      @other_window = @session.window_opened_by do
+      other_window = @session.window_opened_by do
         @session.find(:css, '#openWindow').click
       end
-      @other_window.resize_to(400, 300)
-      expect(@session.current_window).to eq(@window)
 
-      # #size returns values larger than availWidth, availHeight with Chromedriver
-      @session.within_window(@other_window) do
-        expect(@session.current_window.size).to eq([400, 300])
-        # expect(@session.evaluate_script("[window.outerWidth, window.outerHeight]")).to eq([400,300])
+      other_window.resize_to(600, 400)
+      expect(@session.current_window).to eq(orig_window)
+
+      @session.within_window(other_window) do
+        expect(@session.current_window.size).to eq([600, 400])
       end
     end
   end
 
   describe '#maximize' do
+    let! :initial_size do
+      @session.current_window.size
+    end
+
+    after do
+      @session.current_window.resize_to(*initial_size)
+      sleep 0.5
+    end
+
     it 'should be able to maximize window', requires: %i[windows js] do
       start_width, start_height = 400, 300
       @session.current_window.resize_to(start_width, start_height)
@@ -148,22 +166,38 @@ Capybara::SpecHelper.spec Capybara::Window, requires: [:windows] do
     end
 
     it 'should stay on current window if invoked not for current window', requires: %i[windows js] do
-      cur_window_size = @session.current_window.size
-      @other_window = @session.window_opened_by do
+      other_window = @session.window_opened_by do
         @session.find(:css, '#openWindow').click
       end
-
-      @other_window.resize_to(400, 300)
+      other_window.resize_to(400, 300)
       sleep 0.5
-      @other_window.maximize
+      other_window.maximize
       sleep 0.5 # The timing on maximize is finicky on Travis -- wait a bit for maximize to occur
 
-      expect(@session.current_window).to eq(@window)
-      expect(@session.current_window.size).to eq(cur_window_size)
+      expect(@session.current_window).to eq(orig_window)
+      # Maximizing the browser affects all tabs so this may not be valid in real browsers
+      # expect(@session.current_window.size).to eq(initial_size)
 
-      ow_width, ow_height = @other_window.size
+      ow_width, ow_height = other_window.size
       expect(ow_width).to be > 400
       expect(ow_height).to be > 300
     end
   end
+
+  describe '#fullscreen' do
+    let! :initial_size do
+      @session.current_window.size
+    end
+
+    after do
+      @session.current_window.resize_to(*initial_size)
+      sleep 1
+    end
+
+    it 'should be able to fullscreen the window' do
+      expect do
+        @session.current_window.fullscreen
+      end.not_to raise_error
+    end
+  end
 end

data/lib/capybara/spec/session/window/windows_spec.rb

@@ -1,7 +1,11 @@
 # frozen_string_literal: true
 
+# NOTE: This file uses `sleep` to sync up parts of the tests. This is only implemented like this
+# because of the methods being tested. In tests using Capybara this type of behavior should be implemented
+# using Capybara provided assertions with builtin waiting behavior.
+
 Capybara::SpecHelper.spec '#windows', requires: [:windows] do
-  before(:each) do
+  before do
     @window = @session.current_window
     @session.visit('/with_windows')
     @session.find(:css, '#openTwoWindows').click
@@ -10,11 +14,9 @@ Capybara::SpecHelper.spec '#windows', requires: [:windows] do
       raise Capybara::CapybaraError if @session.windows.size != 3
     end
   end
-  after(:each) do
-    (@session.windows - [@window]).each do |w|
-      @session.switch_to_window w
-      w.close
-    end
+
+  after do
+    (@session.windows - [@window]).each(&:close)
     @session.switch_to_window(@window)
   end
 
@@ -22,10 +24,11 @@ Capybara::SpecHelper.spec '#windows', requires: [:windows] do
     expect(@session.windows.map { |window| window.instance_of?(Capybara::Window) }).to eq([true] * 3)
   end
 
-  it 'should switchable windows' do
+  it 'should be able to switch to windows' do
+    sleep 1 # give windows enough time to fully load
     titles = @session.windows.map do |window|
       @session.within_window(window) { @session.title }
     end
-    expect(titles).to match_array(['With Windows', 'Title of the first popup', 'Title of popup two'])
+    expect(titles).to match_array(['With Windows', 'Title of the first popup', 'Title of popup two']) # rubocop:disable RSpec/MatchArray
   end
 end

data/lib/capybara/spec/session/window/within_window_spec.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 Capybara::SpecHelper.spec '#within_window', requires: [:windows] do
-  before(:each) do
+  before do
     @window = @session.current_window
     @session.visit('/with_windows')
     @session.find(:css, '#openTwoWindows').click
@@ -10,7 +10,8 @@ Capybara::SpecHelper.spec '#within_window', requires: [:windows] do
       raise Capybara::CapybaraError if @session.windows.size != 3
     end
   end
-  after(:each) do
+
+  after do
     (@session.windows - [@window]).each do |w|
       @session.switch_to_window w
       w.close
@@ -18,8 +19,8 @@ Capybara::SpecHelper.spec '#within_window', requires: [:windows] do
     @session.switch_to_window(@window)
   end
 
-  context "with an instance of Capybara::Window" do
-    it "should not invoke driver#switch_to_window when given current window" do
+  context 'with an instance of Capybara::Window' do
+    it 'should not invoke driver#switch_to_window when given current window' do
       allow(@session.driver).to receive(:switch_to_window).and_call_original
       @session.within_window @window do
         expect(@session.title).to eq('With Windows')
@@ -27,7 +28,7 @@ Capybara::SpecHelper.spec '#within_window', requires: [:windows] do
       expect(@session.driver).not_to have_received(:switch_to_window)
     end
 
-    it "should be able to switch to another window" do
+    it 'should be able to switch to another window' do
       window = (@session.windows - [@window]).first
       @session.within_window window do
         expect(@session).to have_title(/Title of the first popup|Title of popup two/)
@@ -35,7 +36,7 @@ Capybara::SpecHelper.spec '#within_window', requires: [:windows] do
       expect(@session.title).to eq('With Windows')
     end
 
-    it "returns value from the block" do
+    it 'returns value from the block' do
       window = (@session.windows - [@window]).first
       value = @session.within_window window do
         43252003274489856000
@@ -43,7 +44,7 @@ Capybara::SpecHelper.spec '#within_window', requires: [:windows] do
       expect(value).to eq(43252003274489856000)
     end
 
-    it "should switch back if exception was raised inside block" do
+    it 'should switch back if exception was raised inside block' do
       window = (@session.windows - [@window]).first
       expect do
         @session.within_window(window) do
@@ -57,7 +58,7 @@ Capybara::SpecHelper.spec '#within_window', requires: [:windows] do
       expect(@session.send(:scopes)).to eq([nil])
     end
 
-    it "should leave correct scopes after execution in case of error", requires: %i[windows frames] do
+    it 'should leave correct scopes after execution in case of error', requires: %i[windows frames] do
       window = (@session.windows - [@window]).first
       expect do
         @session.within_frame 'frameOne' do
@@ -85,14 +86,14 @@ Capybara::SpecHelper.spec '#within_window', requires: [:windows] do
     end
   end
 
-  context "with lambda" do
-    it "should find the div in another window" do
+  context 'with lambda' do
+    it 'should find the div in another window' do
       @session.within_window(-> { @session.title == 'Title of the first popup' }) do
         expect(@session).to have_css('#divInPopupOne')
       end
     end
 
-    it "should find divs in both windows" do
+    it 'should find divs in both windows' do
       @session.within_window(-> { @session.title == 'Title of popup two' }) do
         expect(@session).to have_css('#divInPopupTwo')
       end
@@ -102,7 +103,7 @@ Capybara::SpecHelper.spec '#within_window', requires: [:windows] do
       expect(@session.title).to eq('With Windows')
     end
 
-    it "should be able to nest within_window" do
+    it 'should be able to nest within_window' do
       @session.within_window(-> { @session.title == 'Title of popup two' }) do
         expect(@session).to have_css('#divInPopupTwo')
         @session.within_window(-> { @session.title == 'Title of the first popup' }) do
@@ -116,7 +117,7 @@ Capybara::SpecHelper.spec '#within_window', requires: [:windows] do
       expect(@session.title).to eq('With Windows')
     end
 
-    it "should work inside a normal scope" do
+    it 'should work inside a normal scope' do
       expect(@session).to have_css('#openWindow')
       @session.within(:css, '#scope') do
         @session.within_window(-> { @session.title == 'Title of the first popup' }) do
@@ -132,18 +133,18 @@ Capybara::SpecHelper.spec '#within_window', requires: [:windows] do
         @session.within_window(-> { @session.title == 'Invalid title' }) do
           expect(@session).to have_css('#divInPopupOne')
         end
-      end.to raise_error(Capybara::WindowError, "Could not find a window matching block/lambda")
+      end.to raise_error(Capybara::WindowError, 'Could not find a window matching block/lambda')
       expect(@session.current_window).to eq(@window)
       expect(@session).to have_css('#doesNotOpenWindows')
       expect(@session.send(:scopes)).to eq([nil])
     end
 
-    it "returns value from the block" do
+    it 'returns value from the block' do
       value = @session.within_window(-> { @session.title == 'Title of popup two' }) { 42 }
       expect(value).to eq(42)
     end
 
-    it "should switch back if exception was raised inside block" do
+    it 'should switch back if exception was raised inside block' do
       expect do
         @session.within_window(-> { @session.title == 'Title of popup two' }) do
           raise 'some error'

data/lib/capybara/spec/session/within_spec.rb

@@ -5,31 +5,67 @@ Capybara::SpecHelper.spec '#within' do
     @session.visit('/with_scope')
   end
 
-  context "with CSS selector" do
-    it "should click links in the given scope" do
-      @session.within(:css, "#for_bar li", text: 'With Simple HTML') do
+  context 'with CSS selector' do
+    it 'should click links in the given scope' do
+      @session.within(:css, '#for_bar li:first-child') do
         @session.click_link('Go')
       end
       expect(@session).to have_content('Bar')
     end
 
-    it "should assert content in the given scope" do
-      @session.within(:css, "#for_foo") do
+    it 'should assert content in the given scope' do
+      @session.within(:css, '#for_foo') do
         expect(@session).not_to have_content('First Name')
       end
       expect(@session).to have_content('First Name')
     end
 
-    it "should accept additional options" do
-      @session.within(:css, "#for_bar li", text: 'With Simple HTML') do
+    it 'should accept additional options' do
+      @session.within(:css, '#for_bar li', text: 'With Simple HTML') do
         @session.click_link('Go')
       end
       expect(@session).to have_content('Bar')
     end
+
+    it 'should reload the node if the page is changed' do
+      @session.within(:css, '#for_foo') do
+        @session.visit('/with_scope_other')
+        expect(@session).to have_content('Different text')
+      end
+    end
+
+    it 'should reload multiple nodes if the page is changed' do
+      @session.within(:css, '#for_bar') do
+        @session.within(:css, 'form[action="/redirect"]') do
+          @session.refresh
+          expect(@session).to have_content('First Name')
+        end
+      end
+    end
+
+    it 'should error if the page is changed and a matching node no longer exists' do
+      @session.within(:css, '#for_foo') do
+        @session.visit('/')
+        expect { @session.text }.to raise_error(StandardError)
+      end
+    end
+
+    it 'should pass scope element to the block' do
+      @session.within(:css, '#another_foo') do |scope|
+        expect(scope).to match_css('#another_foo')
+      end
+    end
+
+    it 'should scope click', requires: [:js] do
+      @session.within(:css, '#another_foo') do |scope|
+        @session.click
+        expect(scope).to have_text('I was clicked')
+      end
+    end
   end
 
-  context "with XPath selector" do
-    it "should click links in the given scope" do
+  context 'with XPath selector' do
+    it 'should click links in the given scope' do
       @session.within(:xpath, "//div[@id='for_bar']//li[contains(.,'With Simple HTML')]") do
         @session.click_link('Go')
       end
@@ -37,8 +73,8 @@ Capybara::SpecHelper.spec '#within' do
     end
   end
 
-  context "with the default selector" do
-    it "should use XPath" do
+  context 'with the default selector' do
+    it 'should use XPath' do
       @session.within("//div[@id='for_bar']//li[contains(.,'With Simple HTML')]") do
         @session.click_link('Go')
       end
@@ -46,9 +82,9 @@ Capybara::SpecHelper.spec '#within' do
     end
   end
 
-  context "with Node rather than selector" do
-    it "should click links in the given scope" do
-      node_of_interest = @session.find(:css, "#for_bar li", text: 'With Simple HTML')
+  context 'with Node rather than selector' do
+    it 'should click links in the given scope' do
+      node_of_interest = @session.find(:css, '#for_bar li', text: 'With Simple HTML')
 
       @session.within(node_of_interest) do
         @session.click_link('Go')
@@ -57,19 +93,21 @@ Capybara::SpecHelper.spec '#within' do
     end
   end
 
-  context "with the default selector set to CSS" do
+  context 'with the default selector set to CSS' do
     before { Capybara.default_selector = :css }
-    it "should use CSS" do
-      @session.within("#for_bar li", text: 'With Simple HTML') do
+
+    after { Capybara.default_selector = :xpath }
+
+    it 'should use CSS' do
+      @session.within('#for_bar li', text: 'With Simple HTML') do
         @session.click_link('Go')
       end
       expect(@session).to have_content('Bar')
     end
-    after { Capybara.default_selector = :xpath }
   end
 
-  context "with nested scopes" do
-    it "should respect the inner scope" do
+  context 'with nested scopes' do
+    it 'should respect the inner scope' do
       @session.within("//div[@id='for_bar']") do
         @session.within(".//li[contains(.,'Bar')]") do
           @session.click_link('Go')
@@ -78,7 +116,7 @@ Capybara::SpecHelper.spec '#within' do
       expect(@session).to have_content('Another World')
     end
 
-    it "should respect the outer scope" do
+    it 'should respect the outer scope' do
       @session.within("//div[@id='another_foo']") do
         @session.within(".//li[contains(.,'With Simple HTML')]") do
           @session.click_link('Go')
@@ -88,14 +126,14 @@ Capybara::SpecHelper.spec '#within' do
     end
   end
 
-  it "should raise an error if the scope is not found on the page" do
+  it 'should raise an error if the scope is not found on the page' do
     expect do
       @session.within("//div[@id='doesnotexist']") do
       end
     end.to raise_error(Capybara::ElementNotFound)
   end
 
-  it "should restore the scope when an error is raised" do
+  it 'should restore the scope when an error is raised' do
     expect do
       @session.within("//div[@id='for_bar']") do
         expect do
@@ -103,12 +141,12 @@ Capybara::SpecHelper.spec '#within' do
             @session.within(".//div[@id='doesnotexist']") do
             end
           end.to raise_error(Capybara::ElementNotFound)
-        end.to_not change { @session.has_xpath?(".//div[@id='another_foo']") }.from(false)
+        end.not_to change { @session.has_xpath?(".//div[@id='another_foo']") }.from(false)
       end
-    end.to_not change { @session.has_xpath?(".//div[@id='another_foo']") }.from(true)
+    end.not_to change { @session.has_xpath?(".//div[@id='another_foo']") }.from(true)
   end
 
-  it "should fill in a field and click a button" do
+  it 'should fill in a field and click a button' do
     @session.within("//li[contains(.,'Bar')]") do
       @session.click_button('Go')
     end
@@ -121,9 +159,9 @@ Capybara::SpecHelper.spec '#within' do
     expect(extract_results(@session)['first_name']).to eq('Dagobert')
   end
 
-  it "should have #within_element as an alias" do
+  it 'should have #within_element as an alias' do
     expect(Capybara::Session.instance_method(:within)).to eq Capybara::Session.instance_method(:within_element)
-    @session.within_element(:css, "#for_foo") do
+    @session.within_element(:css, '#for_foo') do
       expect(@session).not_to have_content('First Name')
     end
   end
@@ -134,18 +172,18 @@ Capybara::SpecHelper.spec '#within_fieldset' do
     @session.visit('/fieldsets')
   end
 
-  it "should restrict scope to a fieldset given by id" do
-    @session.within_fieldset("villain_fieldset") do
-      @session.fill_in("Name", with: 'Goldfinger')
-      @session.click_button("Create")
+  it 'should restrict scope to a fieldset given by id' do
+    @session.within_fieldset('villain_fieldset') do
+      @session.fill_in('Name', with: 'Goldfinger')
+      @session.click_button('Create')
     end
     expect(extract_results(@session)['villain_name']).to eq('Goldfinger')
   end
 
-  it "should restrict scope to a fieldset given by legend" do
-    @session.within_fieldset("Villain") do
-      @session.fill_in("Name", with: 'Goldfinger')
-      @session.click_button("Create")
+  it 'should restrict scope to a fieldset given by legend' do
+    @session.within_fieldset('Villain') do
+      @session.fill_in('Name', with: 'Goldfinger')
+      @session.click_button('Create')
     end
     expect(extract_results(@session)['villain_name']).to eq('Goldfinger')
   end
@@ -156,18 +194,18 @@ Capybara::SpecHelper.spec '#within_table' do
     @session.visit('/tables')
   end
 
-  it "should restrict scope to a fieldset given by id" do
-    @session.within_table("girl_table") do
-      @session.fill_in("Name", with: 'Christmas')
-      @session.click_button("Create")
+  it 'should restrict scope to a fieldset given by id' do
+    @session.within_table('girl_table') do
+      @session.fill_in('Name', with: 'Christmas')
+      @session.click_button('Create')
     end
     expect(extract_results(@session)['girl_name']).to eq('Christmas')
   end
 
-  it "should restrict scope to a fieldset given by legend" do
-    @session.within_table("Villain") do
-      @session.fill_in("Name", with: 'Quantum')
-      @session.click_button("Create")
+  it 'should restrict scope to a fieldset given by legend' do
+    @session.within_table('Villain') do
+      @session.fill_in('Name', with: 'Quantum')
+      @session.click_button('Create')
     end
     expect(extract_results(@session)['villain_name']).to eq('Quantum')
   end