capybara 3.0.0 → 3.40.0

data/lib/capybara/result.rb

@@ -7,7 +7,7 @@ module Capybara
   # A {Capybara::Result} represents a collection of {Capybara::Node::Element} on the page. It is possible to interact with this
   # collection similar to an Array because it implements Enumerable and offers the following Array methods through delegation:
   #
-  # * []
+  # * \[\]
   # * each()
   # * at()
   # * size()
@@ -16,6 +16,8 @@ module Capybara
   # * first()
   # * last()
   # * empty?()
+  # * values_at()
+  # * sample()
   #
   # @see Capybara::Node::Element
   #
@@ -26,35 +28,52 @@ module Capybara
     def initialize(elements, query)
       @elements = elements
       @result_cache = []
-      @results_enum = lazy_select_elements { |node| query.matches_filters?(node) }
+      @filter_errors = []
+      @results_enum = lazy_select_elements { |node| query.matches_filters?(node, @filter_errors) }
       @query = query
+      @allow_reload = false
     end
 
-    def_delegators :full_results, :size, :length, :last, :values_at, :inspect, :sample
+    def_delegators :full_results, :size, :length, :last, :values_at, :inspect, :sample, :to_ary
 
-    alias :index :find_index
+    alias index find_index
 
     def each(&block)
-      return enum_for(:each) unless block_given?
+      return enum_for(:each) unless block
 
       @result_cache.each(&block)
       loop do
         next_result = @results_enum.next
-        @result_cache << next_result
+        add_to_cache(next_result)
         yield next_result
       end
       self
     end
 
     def [](*args)
-      if (args.size == 1) && ((idx = args[0]).is_a? Integer) && (idx >= 0)
-        @result_cache << @results_enum.next while @result_cache.size <= idx
-        @result_cache[idx]
-      else
+      idx, length = args
+      max_idx = case idx
+      when Integer
+        if idx.negative?
+          nil
+        else
+          length.nil? ? idx : idx + length - 1
+        end
+      when Range
+        # idx.max is broken with beginless ranges
+        # idx.end && idx.max # endless range will have end == nil
+        max = idx.end
+        max = nil if max&.negative?
+        max -= 1 if max && idx.exclude_end?
+        max
+      end
+
+      if max_idx.nil?
         full_results[*args]
+      else
+        load_up_to(max_idx + 1)
+        @result_cache[*args]
       end
-    rescue StopIteration
-      return nil
     end
     alias :at :[]
 
@@ -63,46 +82,28 @@ module Capybara
     end
 
     def compare_count
+      return 0 unless @query
+
+      count, min, max, between = @query.options.values_at(:count, :minimum, :maximum, :between)
+
       # Only check filters for as many elements as necessary to determine result
-      if @query.options[:count]
-        count_opt = Integer(@query.options[:count])
-        loop do
-          break if @result_cache.size > count_opt
-          @result_cache << @results_enum.next
-        end
-        return @result_cache.size <=> count_opt
+      if count && (count = Integer(count))
+        return load_up_to(count + 1) <=> count
       end
 
-      if @query.options[:minimum]
-        min_opt = Integer(@query.options[:minimum])
-        begin
-          @result_cache << @results_enum.next while @result_cache.size < min_opt
-        rescue StopIteration
-          return -1
-        end
-      end
+      return -1 if min && (min = Integer(min)) && (load_up_to(min) < min)
 
-      if @query.options[:maximum]
-        max_opt = Integer(@query.options[:maximum])
-        begin
-          @result_cache << @results_enum.next while @result_cache.size <= max_opt
-          return 1
-        rescue StopIteration
-        end
-      end
+      return 1 if max && (max = Integer(max)) && (load_up_to(max + 1) > max)
 
-      if @query.options[:between]
-        min, max = @query.options[:between].minmax
-        loop do
-          break if @result_cache.size > max
-          @result_cache << @results_enum.next
-        end
-        return 0 if @query.options[:between].include?(@result_cache.size)
-        return -1 if @result_cache.size < min
-        return 1
+      if between
+        min, max = (between.begin && between.min) || 1, between.end
+        max -= 1 if max && between.exclude_end?
+
+        size = load_up_to(max ? max + 1 : min)
+        return size <=> min unless between.include?(size)
       end
 
-      return 0
+      0
     end
 
     def matches_count?
@@ -112,13 +113,15 @@ module Capybara
     def failure_message
       message = @query.failure_message
       if count.zero?
-        message << " but there were no matches"
+        message << ' but there were no matches'
       else
-        message << ", found #{count} #{Capybara::Helpers.declension("match", "matches", count)}: " << full_results.map(&:text).map(&:inspect).join(", ")
+        message << ", found #{count} #{Capybara::Helpers.declension('match', 'matches', count)}: " \
+                << full_results.map { |r| r.text.inspect }.join(', ')
       end
       unless rest.empty?
-        elements = rest.map { |el| el.text rescue "<<ERROR>>" }.map(&:inspect).join(", ")
-        message << ". Also found " << elements << ", which matched the selector but not all filters."
+        elements = rest.map { |el| el.text rescue '<<ERROR>>' }.map(&:inspect).join(', ') # rubocop:disable Style/RescueModifier
+        message << '. Also found ' << elements << ', which matched the selector but not all filters. '
+        message << @filter_errors.join('. ') if (rest.size == 1) && count.zero?
       end
       message
     end
@@ -127,8 +130,34 @@ module Capybara
       failure_message.sub(/(to find)/, 'not \1')
     end
 
+    def unfiltered_size
+      @elements.length
+    end
+
+    ##
+    # @api private
+    #
+    def allow_reload!
+      @allow_reload = true
+      self
+    end
+
   private
 
+    def add_to_cache(elem)
+      elem.allow_reload!(@result_cache.size) if @allow_reload
+      @result_cache << elem
+    end
+
+    def load_up_to(num)
+      loop do
+        break if @result_cache.size >= num
+
+        add_to_cache(@results_enum.next)
+      end
+      @result_cache.size
+    end
+
     def full_results
       loop { @result_cache << @results_enum.next }
       @result_cache
@@ -138,13 +167,18 @@ module Capybara
       @rest ||= @elements - full_results
     end
 
-    def lazy_select_elements(&block)
-      # JRuby has an issue with lazy enumerators which
+    if RUBY_PLATFORM == 'java'
+      # JRuby < 9.2.8.0 has an issue with lazy enumerators which
       # causes a concurrency issue with network requests here
       # https://github.com/jruby/jruby/issues/4212
-      if RUBY_PLATFORM == 'java'
+      # while JRuby >= 9.2.8.0 leaks threads when using lazy enumerators
+      # https://github.com/teamcapybara/capybara/issues/2349
+      # so disable the use and JRuby users will need to pay a performance penalty
+      def lazy_select_elements(&block)
         @elements.select(&block).to_enum # non-lazy evaluation
-      else
+      end
+    else
+      def lazy_select_elements(&block)
         @elements.lazy.select(&block)
       end
     end

data/lib/capybara/rspec/features.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-RSpec.shared_context "Capybara Features", capybara_feature: true do
+RSpec.shared_context 'Capybara Features', capybara_feature: true do
   instance_eval do
     alias background before
     alias given let
@@ -9,17 +9,15 @@ RSpec.shared_context "Capybara Features", capybara_feature: true do
 end
 
 # ensure shared_context is included if default shared_context_metadata_behavior is changed
-if RSpec::Core::Version::STRING.to_f >= 3.5
-  RSpec.configure do |config|
-    config.include_context "Capybara Features", capybara_feature: true
-  end
+RSpec.configure do |config|
+  config.include_context 'Capybara Features', capybara_feature: true if config.respond_to?(:include_context)
 end
 
 RSpec.configure do |config|
-  config.alias_example_group_to :feature, capybara_feature: true, type: :feature
-  config.alias_example_group_to :xfeature, capybara_feature: true, type: :feature, skip: "Temporarily disabled with xfeature"
-  config.alias_example_group_to :ffeature, capybara_feature: true, type: :feature, focus: true
+  config.alias_example_group_to :feature, :capybara_feature, type: :feature
+  config.alias_example_group_to :xfeature, :capybara_feature, type: :feature, skip: 'Temporarily disabled with xfeature'
+  config.alias_example_group_to :ffeature, :capybara_feature, :focus, type: :feature
   config.alias_example_to :scenario
-  config.alias_example_to :xscenario, skip: "Temporarily disabled with xscenario"
-  config.alias_example_to :fscenario, focus: true
+  config.alias_example_to :xscenario, skip: 'Temporarily disabled with xscenario'
+  config.alias_example_to :fscenario, :focus
 end

data/lib/capybara/rspec/matcher_proxies.rb

@@ -2,41 +2,66 @@
 
 module Capybara
   module RSpecMatcherProxies
-    def all(*args, &block)
+    def all(*args, **kwargs, &block)
       if defined?(::RSpec::Matchers::BuiltIn::All) && args.first.respond_to?(:matches?)
         ::RSpec::Matchers::BuiltIn::All.new(*args)
       else
-        find_all(*args, &block)
+        find_all(*args, **kwargs, &block)
       end
     end
 
-    def within(*args)
-      if block_given?
-        within_element(*args, &Proc.new)
+    def within(*args, **kwargs, &block)
+      if block
+        within_element(*args, **kwargs, &block)
       else
         be_within(*args)
       end
     end
   end
+end
+
+if RUBY_ENGINE == 'jruby'
+  # :nocov:
+  module Capybara::DSL
+    class << self
+      remove_method :included
 
-  module DSLRSpecProxyInstaller
-    module ClassMethods
       def included(base)
-        if defined?(::RSpec::Matchers)
-          base.include(::Capybara::RSpecMatcherProxies) if base.include?(::RSpec::Matchers)
+        warn 'including Capybara::DSL in the global scope is not recommended!' if base == Object
+        if defined?(::RSpec::Matchers) && base.include?(::RSpec::Matchers)
+          base.send(:include, ::Capybara::RSpecMatcherProxies)
         end
         super
       end
     end
+  end
+
+  if defined?(RSpec::Matchers)
+    module ::RSpec::Matchers
+      def self.included(base)
+        base.send(:include, ::Capybara::RSpecMatcherProxies) if base.include?(::Capybara::DSL)
+        super
+      end
+    end
+  end
+  # :nocov:
+else
+  module Capybara::DSLRSpecProxyInstaller
+    module ClassMethods
+      def included(base)
+        base.include(::Capybara::RSpecMatcherProxies) if defined?(::RSpec::Matchers) && base.include?(::RSpec::Matchers)
+        super
+      end
+    end
 
     def self.prepended(base)
-      class <<base
+      class << base
         prepend ClassMethods
       end
     end
   end
 
-  module RSpecMatcherProxyInstaller
+  module Capybara::RSpecMatcherProxyInstaller
     module ClassMethods
       def included(base)
         base.include(::Capybara::RSpecMatcherProxies) if base.include?(::Capybara::DSL)
@@ -45,17 +70,13 @@ module Capybara
     end
 
     def self.prepended(base)
-      class <<base
+      class << base
         prepend ClassMethods
       end
     end
   end
 
-  DSL.prepend ::Capybara::DSLRSpecProxyInstaller
-end
+  Capybara::DSL.prepend Capybara::DSLRSpecProxyInstaller
 
-if defined?(::RSpec::Matchers)
-  module ::RSpec::Matchers
-    prepend ::Capybara::RSpecMatcherProxyInstaller
-  end
+  RSpec::Matchers.prepend Capybara::RSpecMatcherProxyInstaller if defined?(RSpec::Matchers)
 end

data/lib/capybara/rspec/matchers/base.rb

@@ -0,0 +1,113 @@
+# frozen_string_literal: true
+
+require 'capybara/rspec/matchers/compound'
+require 'capybara/rspec/matchers/count_sugar'
+require 'capybara/rspec/matchers/spatial_sugar'
+
+module Capybara
+  module RSpecMatchers
+    module Matchers
+      class Base
+        include ::Capybara::RSpecMatchers::Matchers::Compound if defined?(::Capybara::RSpecMatchers::Matchers::Compound)
+
+        attr_reader :failure_message, :failure_message_when_negated
+
+        def initialize(*args, **kw_args, &filter_block)
+          @args = args.dup
+          @kw_args = kw_args || {}
+          @filter_block = filter_block
+        end
+
+      private
+
+        def session_query_args
+          # if @args.last.is_a? Hash
+          #   @args.last[:session_options] = session_options
+          # else
+          #   @args.push(session_options: session_options)
+          # end
+          @args
+        end
+
+        def session_query_options
+          @kw_args[:session_options] = session_options
+          @kw_args
+        end
+
+        def session_options
+          @context_el ||= nil
+          if @context_el.respond_to? :session_options
+            @context_el.session_options
+          elsif @context_el.respond_to? :current_scope
+            @context_el.current_scope.session_options
+          else
+            Capybara.session_options
+          end
+        end
+      end
+
+      class WrappedElementMatcher < Base
+        def matches?(actual, &filter_block)
+          @filter_block ||= filter_block
+          element_matches?(wrap(actual))
+        rescue Capybara::ExpectationNotMet => e
+          @failure_message = e.message
+          false
+        end
+
+        def does_not_match?(actual, &filter_block)
+          @filter_block ||= filter_block
+          element_does_not_match?(wrap(actual))
+        rescue Capybara::ExpectationNotMet => e
+          @failure_message_when_negated = e.message
+          false
+        end
+
+      private
+
+        def wrap(actual)
+          actual = actual.to_capybara_node if actual.respond_to?(:to_capybara_node)
+          @context_el = if actual.respond_to?(:has_selector?)
+            actual
+          else
+            Capybara.string(actual.to_s)
+          end
+        end
+      end
+
+      class CountableWrappedElementMatcher < WrappedElementMatcher
+        include ::Capybara::RSpecMatchers::CountSugar
+        include ::Capybara::RSpecMatchers::SpatialSugar
+      end
+
+      class NegatedMatcher
+        include ::Capybara::RSpecMatchers::Matchers::Compound if defined?(::Capybara::RSpecMatchers::Matchers::Compound)
+
+        def initialize(matcher)
+          super()
+          @matcher = matcher
+        end
+
+        def matches?(actual, &filter_block)
+          @matcher.does_not_match?(actual, &filter_block)
+        end
+
+        def does_not_match?(actual, &filter_block)
+          @matcher.matches?(actual, &filter_block)
+        end
+
+        def description
+          "not #{@matcher.description}"
+        end
+
+        def failure_message
+          @matcher.failure_message_when_negated
+        end
+
+        def failure_message_when_negated
+          @matcher.failure_message
+        end
+      end
+    end
+  end
+end

data/lib/capybara/rspec/matchers/become_closed.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+module Capybara
+  module RSpecMatchers
+    module Matchers
+      class BecomeClosed
+        def initialize(options)
+          @options = options
+        end
+
+        def matches?(window)
+          @window = window
+          @wait_time = Capybara::Queries::BaseQuery.wait(@options, window.session.config.default_max_wait_time)
+          timer = Capybara::Helpers.timer(expire_in: @wait_time)
+          while window.exists?
+            return false if timer.expired?
+
+            sleep 0.01
+          end
+          true
+        end
+
+        def failure_message
+          "expected #{@window.inspect} to become closed after #{@wait_time} seconds"
+        end
+
+        def failure_message_when_negated
+          "expected #{@window.inspect} not to become closed after #{@wait_time} seconds"
+        end
+      end
+    end
+  end
+end

data/lib/capybara/rspec/matchers/compound.rb

@@ -0,0 +1,88 @@
+# frozen_string_literal: true
+
+if defined?(RSpec::Expectations::Version)
+  module Capybara
+    module RSpecMatchers
+      module Matchers
+        module Compound
+          include ::RSpec::Matchers::Composable
+
+          def and(matcher)
+            And.new(self, matcher)
+          end
+
+          def and_then(matcher)
+            ::RSpec::Matchers::BuiltIn::Compound::And.new(self, matcher)
+          end
+
+          def or(matcher)
+            Or.new(self, matcher)
+          end
+
+          class CapybaraEvaluator
+            def initialize(actual)
+              @actual = actual
+              @match_results = Hash.new { |hsh, matcher| hsh[matcher] = matcher.matches?(@actual) }
+            end
+
+            def matcher_matches?(matcher)
+              @match_results[matcher]
+            end
+
+            def reset
+              @match_results.clear
+            end
+          end
+
+          # @api private
+          module Synchronizer
+            def match(_expected, actual)
+              @evaluator = CapybaraEvaluator.new(actual)
+              syncer = sync_element(actual)
+              begin
+                syncer.synchronize do
+                  @evaluator.reset
+                  raise ::Capybara::ElementNotFound unless synchronized_match?
+
+                  true
+                end
+              rescue StandardError
+                false
+              end
+            end
+
+            def sync_element(el)
+              if el.respond_to? :synchronize
+                el
+              elsif el.respond_to? :current_scope
+                el.current_scope
+              else
+                Capybara.string(el)
+              end
+            end
+          end
+
+          class And < ::RSpec::Matchers::BuiltIn::Compound::And
+            include Synchronizer
+
+          private
+
+            def synchronized_match?
+              [matcher_1_matches?, matcher_2_matches?].all?
+            end
+          end
+
+          class Or < ::RSpec::Matchers::BuiltIn::Compound::Or
+            include Synchronizer
+
+          private
+
+            def synchronized_match?
+              [matcher_1_matches?, matcher_2_matches?].any?
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/capybara/rspec/matchers/count_sugar.rb

@@ -0,0 +1,37 @@
+# frozen_string_literal: true
+
+module Capybara
+  module RSpecMatchers
+    module CountSugar
+      def once; exactly(1); end
+      def twice; exactly(2); end
+      def thrice; exactly(3); end
+
+      def exactly(number)
+        options[:count] = number
+        self
+      end
+
+      def at_most(number)
+        options[:maximum] = number
+        self
+      end
+
+      def at_least(number)
+        options[:minimum] = number
+        self
+      end
+
+      def times
+        self
+      end
+
+    private
+
+      def options
+        # (@args.last.is_a?(Hash) ? @args : @args.push({})).last
+        @kw_args
+      end
+    end
+  end
+end

data/lib/capybara/rspec/matchers/have_ancestor.rb

@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+require 'capybara/rspec/matchers/base'
+
+module Capybara
+  module RSpecMatchers
+    module Matchers
+      class HaveAncestor < CountableWrappedElementMatcher
+        def element_matches?(el)
+          el.assert_ancestor(*@args, **session_query_options, &@filter_block)
+        end
+
+        def element_does_not_match?(el)
+          el.assert_no_ancestor(*@args, **session_query_options, &@filter_block)
+        end
+
+        def description
+          "have ancestor #{query.description}"
+        end
+
+        def query
+          # @query ||= Capybara::Queries::AncestorQuery.new(*session_query_args, &@filter_block)
+          @query ||= Capybara::Queries::AncestorQuery.new(*session_query_args, **session_query_options, &@filter_block)
+        end
+      end
+    end
+  end
+end

data/lib/capybara/rspec/matchers/have_current_path.rb

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+require 'capybara/rspec/matchers/base'
+
+module Capybara
+  module RSpecMatchers
+    module Matchers
+      class HaveCurrentPath < WrappedElementMatcher
+        def element_matches?(el)
+          el.assert_current_path(current_path, **@kw_args, &@filter_block)
+        end
+
+        def element_does_not_match?(el)
+          el.assert_no_current_path(current_path, **@kw_args, &@filter_block)
+        end
+
+        def description
+          "have current path #{current_path.inspect}"
+        end
+
+      private
+
+        def current_path
+          @args.first
+        end
+      end
+    end
+  end
+end