briard 2.4.1 → 2.6.0

data/spec/readers/bibtex_reader_spec.rb

@@ -3,61 +3,66 @@
 require 'spec_helper'
 
 describe Briard::Metadata, vcr: true do
-  let(:input) { fixture_path + "crossref.bib" }
+  subject { described_class.new(input: input) }
 
-  subject { Briard::Metadata.new(input: input) }
+  let(:input) { "#{fixture_path}crossref.bib" }
 
-  context "detect format" do
-    it "extension" do
+  context 'detect format' do
+    it 'extension' do
       expect(subject.valid?).to be true
     end
 
-    it "string" do
-      Briard::Metadata.new(input: IO.read(input).strip)
+    it 'string' do
+      described_class.new(input: File.read(input).strip)
       expect(subject.valid?).to be true
-      expect(subject.id).to eq("https://doi.org/10.7554/elife.01567")
+      expect(subject.id).to eq('https://doi.org/10.7554/elife.01567')
     end
   end
 
-  context "get bibtex raw" do
-    it "Crossref DOI" do
-      expect(subject.raw).to eq(IO.read(input).strip)
+  context 'get bibtex raw' do
+    it 'Crossref DOI' do
+      expect(subject.raw).to eq(File.read(input).strip)
     end
   end
 
-  context "get bibtex metadata" do
-    it "Crossref DOI" do
+  context 'get bibtex metadata' do
+    it 'Crossref DOI' do
       expect(subject.valid?).to be true
-      expect(subject.id).to eq("https://doi.org/10.7554/elife.01567")
-      expect(subject.types).to eq("bibtex"=>"article", "citeproc"=>"article-journal", "resourceTypeGeneral"=>"JournalArticle", "resourceType"=>"JournalArticle", "ris"=>"JOUR", "schemaOrg"=>"ScholarlyArticle")
-      expect(subject.url).to eq("http://elifesciences.org/lookup/doi/10.7554/eLife.01567")
+      expect(subject.id).to eq('https://doi.org/10.7554/elife.01567')
+      expect(subject.types).to eq('bibtex' => 'article', 'citeproc' => 'article-journal',
+                                  'resourceTypeGeneral' => 'JournalArticle', 'resourceType' => 'JournalArticle', 'ris' => 'JOUR', 'schemaOrg' => 'ScholarlyArticle')
+      expect(subject.url).to eq('http://elifesciences.org/lookup/doi/10.7554/eLife.01567')
       expect(subject.creators.length).to eq(5)
-      expect(subject.creators.first).to eq("familyName"=>"Sankar", "givenName"=>"Martial", "name"=>"Sankar, Martial", "nameType"=>"Personal")
-      expect(subject.titles).to eq([{"title"=>"Automated quantitative histology reveals vascular morphodynamics during Arabidopsis hypocotyl secondary growth"}])
-      expect(subject.descriptions.first["description"]).to start_with("Among various advantages, their small size makes model organisms preferred subjects of investigation.")
-      expect(subject.rights_list).to eq([{"rights"=>"Creative Commons Attribution 3.0 Unported",
-        "rightsIdentifier"=>"cc-by-3.0",
-        "rightsIdentifierScheme"=>"SPDX",
-        "rightsUri"=>"https://creativecommons.org/licenses/by/3.0/legalcode",
-        "schemeUri"=>"https://spdx.org/licenses/"}])
-      expect(subject.dates).to eq([{"date"=>"2014", "dateType"=>"Issued"}])
-      expect(subject.publication_year).to eq("2014")
-      expect(subject.related_identifiers).to eq([{"relatedIdentifier"=>"2050-084X", "relatedIdentifierType"=>"ISSN", "relationType"=>"IsPartOf", "title"=>"eLife", "type"=>"Periodical"}])
+      expect(subject.creators.first).to eq('familyName' => 'Sankar', 'givenName' => 'Martial',
+                                           'name' => 'Sankar, Martial', 'nameType' => 'Personal')
+      expect(subject.titles).to eq([{ 'title' => 'Automated quantitative histology reveals vascular morphodynamics during Arabidopsis hypocotyl secondary growth' }])
+      expect(subject.descriptions.first['description']).to start_with('Among various advantages, their small size makes model organisms preferred subjects of investigation.')
+      expect(subject.rights_list).to eq([{ 'rights' => 'Creative Commons Attribution 3.0 Unported',
+                                           'rightsIdentifier' => 'cc-by-3.0',
+                                           'rightsIdentifierScheme' => 'SPDX',
+                                           'rightsUri' => 'https://creativecommons.org/licenses/by/3.0/legalcode',
+                                           'schemeUri' => 'https://spdx.org/licenses/' }])
+      expect(subject.dates).to eq([{ 'date' => '2014', 'dateType' => 'Issued' }])
+      expect(subject.publication_year).to eq('2014')
+      expect(subject.related_identifiers).to eq([{ 'relatedIdentifier' => '2050-084X',
+                                                   'relatedIdentifierType' => 'ISSN', 'relationType' => 'IsPartOf', 'title' => 'eLife', 'type' => 'Periodical' }])
     end
 
-    it "DOI does not exist" do
-      input = fixture_path + "pure.bib"
-      doi = "10.7554/elife.01567"
-      subject = Briard::Metadata.new(input: input, doi: doi)
+    it 'DOI does not exist' do
+      input = "#{fixture_path}pure.bib"
+      doi = '10.7554/elife.01567'
+      subject = described_class.new(input: input, doi: doi)
       expect(subject.valid?).to be false
-      expect(subject.state).to eq("not_found")
-      expect(subject.id).to eq("https://doi.org/10.7554/elife.01567")
-      expect(subject.types).to eq("bibtex"=>"phdthesis", "citeproc"=>"thesis", "resourceTypeGeneral"=>"Dissertation", "resourceType"=>"Dissertation", "ris"=>"THES", "schemaOrg"=>"Thesis")
-      expect(subject.creators).to eq([{"familyName"=>"Toparlar", "givenName"=>"Y.", "name"=>"Toparlar, Y.", "nameType"=>"Personal"}])
-      expect(subject.titles).to eq([{"title"=>"A multiscale analysis of the urban heat island effect: from city averaged temperatures to the energy demand of individual buildings"}])
-      expect(subject.descriptions.first["description"]).to start_with("Designing the climates of cities")
-      expect(subject.dates).to eq([{"date"=>"2018", "dateType"=>"Issued"}])
-      expect(subject.publication_year).to eq("2018")
+      expect(subject.state).to eq('not_found')
+      expect(subject.id).to eq('https://doi.org/10.7554/elife.01567')
+      expect(subject.types).to eq('bibtex' => 'phdthesis', 'citeproc' => 'thesis',
+                                  'resourceTypeGeneral' => 'Dissertation', 'resourceType' => 'Dissertation', 'ris' => 'THES', 'schemaOrg' => 'Thesis')
+      expect(subject.creators).to eq([{ 'familyName' => 'Toparlar', 'givenName' => 'Y.',
+                                        'name' => 'Toparlar, Y.', 'nameType' => 'Personal' }])
+      expect(subject.titles).to eq([{ 'title' => 'A multiscale analysis of the urban heat island effect: from city averaged temperatures to the energy demand of individual buildings' }])
+      expect(subject.descriptions.first['description']).to start_with('Designing the climates of cities')
+      expect(subject.dates).to eq([{ 'date' => '2018', 'dateType' => 'Issued' }])
+      expect(subject.publication_year).to eq('2018')
     end
   end
 end

data/spec/readers/cff_reader_spec.rb

@@ -3,170 +3,182 @@
 require 'spec_helper'
 
 describe Briard::Metadata, vcr: true do
-  let(:input) { "https://github.com/citation-file-format/ruby-cff/blob/main/CITATION.cff" }
+  subject { described_class.new(input: input) }
 
-  subject { Briard::Metadata.new(input: input) }
+  let(:input) { 'https://github.com/citation-file-format/ruby-cff/blob/main/CITATION.cff' }
 
-  context "get cff metadata" do
-    it "ruby-cff" do
+  context 'get cff metadata' do
+    it 'ruby-cff' do
       expect(subject.valid?).to be true
-      expect(subject.id).to eq("https://doi.org/10.5281/zenodo.1184077")
-      expect(subject.url).to eq("https://github.com/citation-file-format/ruby-cff")
-      expect(subject.types).to eq("bibtex"=>"misc", "citeproc"=>"article-journal", "resourceTypeGeneral"=>"Software", "ris"=>"COMP", "schemaOrg"=>"SoftwareSourceCode")
-      expect(subject.creators).to eq([{"affiliation"=>[{"name"=>"The University of Manchester, UK"}], "familyName"=>"Haines", "givenName"=>"Robert", "name"=>"Haines, Robert", "nameIdentifiers"=>
-        [{"nameIdentifier"=>"https://orcid.org/0000-0002-9538-7919",
-          "nameIdentifierScheme"=>"ORCID",
-          "schemeUri"=>"https://orcid.org"}], "nameType"=>"Personal"}, {"name"=>"The Ruby Citation File Format Developers", "nameType"=>"Organizational"}])
-      expect(subject.titles).to eq([{"title"=>"Ruby CFF Library"}])
-      expect(subject.descriptions.first["description"]).to start_with("This library provides a Ruby interface to manipulate Citation File Format files")
-      expect(subject.subjects).to eq([{"subject"=>"ruby"},
-        {"subject"=>"credit"},
-        {"subject"=>"software citation"},
-        {"subject"=>"research software"},
-        {"subject"=>"software sustainability"},
-        {"subject"=>"metadata"},
-        {"subject"=>"citation file format"},
-        {"subject"=>"cff"}])
-      expect(subject.version_info).to eq("0.9.0")
-      expect(subject.dates).to eq([{"date"=>"2021-08-18", "dateType"=>"Issued"}])
-      expect(subject.publication_year).to eq("2021")
-      expect(subject.publisher).to eq("GitHub")
-      expect(subject.rights_list).to eq([{"rights"=>"Apache License 2.0",
-        "rightsIdentifier"=>"apache-2.0",
-        "rightsIdentifierScheme"=>"SPDX",
-        "rightsUri"=>"http://www.apache.org/licenses/LICENSE-2.0",
-        "schemeUri"=>"https://spdx.org/licenses/"}])
-      expect(subject.related_identifiers).to eq([{"relatedIdentifier"=>"https://doi.org/10.5281/zenodo.1003149", "relatedIdentifierType"=>"DOI", "relationType"=>"References"}])
+      expect(subject.id).to eq('https://doi.org/10.5281/zenodo.1184077')
+      expect(subject.url).to eq('https://github.com/citation-file-format/ruby-cff')
+      expect(subject.types).to eq('bibtex' => 'misc', 'citeproc' => 'article-journal',
+                                  'resourceTypeGeneral' => 'Software', 'ris' => 'COMP', 'schemaOrg' => 'SoftwareSourceCode')
+      expect(subject.creators).to eq([{ 'affiliation' => [{ 'name' => 'The University of Manchester, UK' }], 'familyName' => 'Haines', 'givenName' => 'Robert', 'name' => 'Haines, Robert', 'nameIdentifiers' =>
+        [{ 'nameIdentifier' => 'https://orcid.org/0000-0002-9538-7919',
+           'nameIdentifierScheme' => 'ORCID',
+           'schemeUri' => 'https://orcid.org' }], 'nameType' => 'Personal' }, { 'name' => 'The Ruby Citation File Format Developers', 'nameType' => 'Organizational' }])
+      expect(subject.titles).to eq([{ 'title' => 'Ruby CFF Library' }])
+      expect(subject.descriptions.first['description']).to start_with('This library provides a Ruby interface to manipulate Citation File Format files')
+      expect(subject.subjects).to eq([{ 'subject' => 'ruby' },
+                                      { 'subject' => 'credit' },
+                                      { 'subject' => 'software citation' },
+                                      { 'subject' => 'research software' },
+                                      { 'subject' => 'software sustainability' },
+                                      { 'subject' => 'metadata' },
+                                      { 'subject' => 'citation file format' },
+                                      { 'subject' => 'cff' }])
+      expect(subject.version_info).to eq('0.9.0')
+      expect(subject.dates).to eq([{ 'date' => '2021-08-18', 'dateType' => 'Issued' }])
+      expect(subject.publication_year).to eq('2021')
+      expect(subject.publisher).to eq('GitHub')
+      expect(subject.rights_list).to eq([{ 'rights' => 'Apache License 2.0',
+                                           'rightsIdentifier' => 'apache-2.0',
+                                           'rightsIdentifierScheme' => 'SPDX',
+                                           'rightsUri' => 'http://www.apache.org/licenses/LICENSE-2.0',
+                                           'schemeUri' => 'https://spdx.org/licenses/' }])
+      expect(subject.related_identifiers).to eq([{
+                                                  'relatedIdentifier' => 'https://doi.org/10.5281/zenodo.1003149', 'relatedIdentifierType' => 'DOI', 'relationType' => 'References'
+                                                }])
     end
 
-    it "cff-converter-python" do
-      input = "https://github.com/citation-file-format/cff-converter-python/blob/main/CITATION.cff"
-      subject = Briard::Metadata.new(input: input)
-      expect(subject.id).to eq("https://doi.org/10.5281/zenodo.1162057")
-      expect(subject.url).to eq("https://github.com/citation-file-format/cff-converter-python")
-      expect(subject.types).to eq("bibtex"=>"misc", "citeproc"=>"article-journal", "resourceTypeGeneral"=>"Software", "ris"=>"COMP", "schemaOrg"=>"SoftwareSourceCode")
-      expect(subject.creators).to eq([{"affiliation"=>[{"name"=>"Netherlands eScience Center"}],
-        "familyName"=>"Spaaks",
-        "givenName"=>"Jurriaan H.",
-        "name"=>"Spaaks, Jurriaan H.",
-        "nameIdentifiers"=>
-          [{"nameIdentifier"=>"https://orcid.org/0000-0002-7064-4069",
-            "nameIdentifierScheme"=>"ORCID",
-            "schemeUri"=>"https://orcid.org"}],
-        "nameType"=>"Personal"},
-       {"affiliation"=>[{"name"=>"Netherlands eScience Center"}],
-        "familyName"=>"Klaver",
-        "givenName"=>"Tom",
-        "name"=>"Klaver, Tom",
-        "nameType"=>"Personal"},
-      {"affiliation"=>[{"name"=>"Netherlands eScience Center"}],
-        "familyName"=>"Verhoeven",
-        "givenName"=>"Stefan",
-        "name"=>"Verhoeven, Stefan",
-        "nameIdentifiers"=>
-          [{"nameIdentifier"=>"https://orcid.org/0000-0002-5821-2060",
-            "nameIdentifierScheme"=>"ORCID",
-            "schemeUri"=>"https://orcid.org"}],
-        "nameType"=>"Personal"},
-       {"affiliation"=>[{"name"=>"Humboldt-Universit??t zu Berlin"}],
-        "familyName"=>"Druskat",
-        "givenName"=>"Stephan",
-        "name"=>"Druskat, Stephan",
-        "nameIdentifiers"=>
-          [{"nameIdentifier"=>"https://orcid.org/0000-0003-4925-7248",
-            "nameIdentifierScheme"=>"ORCID",
-            "schemeUri"=>"https://orcid.org"}],
-        "nameType"=>"Personal"},
-       {"affiliation"=>[{"name"=>"University of Oslo"}],
-        "familyName"=>"Leoncio",
-        "givenName"=>"Waldir",
-        "name"=>"Leoncio, Waldir",
-        "nameType"=>"Personal"}])
-      expect(subject.titles).to eq([{"title"=>"cffconvert"}])
-      expect(subject.descriptions.first["description"]).to start_with("Command line program to validate and convert CITATION.cff files")
-      expect(subject.subjects).to eq([{"subject"=>"bibliography"},
-        {"subject"=>"bibtex"},
-        {"subject"=>"cff"},
-        {"subject"=>"citation"},
-        {"subject"=>"citation.cff"},
-        {"subject"=>"codemeta"},
-        {"subject"=>"endnote"},
-        {"subject"=>"ris"},
-        {"subject"=>"citation file format"}])
-      expect(subject.version_info).to eq("2.0.0")
-      expect(subject.dates).to eq([{"date"=>"2021-09-22", "dateType"=>"Issued"}])
-      expect(subject.publication_year).to eq("2021")
-      expect(subject.publisher).to eq("GitHub")
-      expect(subject.rights_list).to eq([{"rights"=>"Apache License 2.0",
-        "rightsIdentifier"=>"apache-2.0",
-        "rightsIdentifierScheme"=>"SPDX",
-        "rightsUri"=>"http://www.apache.org/licenses/LICENSE-2.0",
-        "schemeUri"=>"https://spdx.org/licenses/"}])
-      expect(subject.related_identifiers).to eq([{"relatedIdentifier"=>"https://doi.org/10.5281/zenodo.1310751", "relatedIdentifierType"=>"DOI", "relationType"=>"References"}])
+    it 'cff-converter-python' do
+      input = 'https://github.com/citation-file-format/cff-converter-python/blob/main/CITATION.cff'
+      subject = described_class.new(input: input)
+      expect(subject.id).to eq('https://doi.org/10.5281/zenodo.1162057')
+      expect(subject.url).to eq('https://github.com/citation-file-format/cff-converter-python')
+      expect(subject.types).to eq('bibtex' => 'misc', 'citeproc' => 'article-journal',
+                                  'resourceTypeGeneral' => 'Software', 'ris' => 'COMP', 'schemaOrg' => 'SoftwareSourceCode')
+      expect(subject.creators).to eq([{ 'affiliation' => [{ 'name' => 'Netherlands eScience Center' }],
+                                        'familyName' => 'Spaaks',
+                                        'givenName' => 'Jurriaan H.',
+                                        'name' => 'Spaaks, Jurriaan H.',
+                                        'nameIdentifiers' =>
+          [{ 'nameIdentifier' => 'https://orcid.org/0000-0002-7064-4069',
+             'nameIdentifierScheme' => 'ORCID',
+             'schemeUri' => 'https://orcid.org' }],
+                                        'nameType' => 'Personal' },
+                                      { 'affiliation' => [{ 'name' => 'Netherlands eScience Center' }],
+                                        'familyName' => 'Klaver',
+                                        'givenName' => 'Tom',
+                                        'name' => 'Klaver, Tom',
+                                        'nameType' => 'Personal' },
+                                      { 'affiliation' => [{ 'name' => 'Netherlands eScience Center' }],
+                                        'familyName' => 'Verhoeven',
+                                        'givenName' => 'Stefan',
+                                        'name' => 'Verhoeven, Stefan',
+                                        'nameIdentifiers' =>
+                                          [{ 'nameIdentifier' => 'https://orcid.org/0000-0002-5821-2060',
+                                             'nameIdentifierScheme' => 'ORCID',
+                                             'schemeUri' => 'https://orcid.org' }],
+                                        'nameType' => 'Personal' },
+                                      { 'affiliation' => [{ 'name' => 'Humboldt-Universit??t zu Berlin' }],
+                                        'familyName' => 'Druskat',
+                                        'givenName' => 'Stephan',
+                                        'name' => 'Druskat, Stephan',
+                                        'nameIdentifiers' =>
+                                         [{ 'nameIdentifier' => 'https://orcid.org/0000-0003-4925-7248',
+                                            'nameIdentifierScheme' => 'ORCID',
+                                            'schemeUri' => 'https://orcid.org' }],
+                                        'nameType' => 'Personal' },
+                                      { 'affiliation' => [{ 'name' => 'University of Oslo' }],
+                                        'familyName' => 'Leoncio',
+                                        'givenName' => 'Waldir',
+                                        'name' => 'Leoncio, Waldir',
+                                        'nameType' => 'Personal' }])
+      expect(subject.titles).to eq([{ 'title' => 'cffconvert' }])
+      expect(subject.descriptions.first['description']).to start_with('Command line program to validate and convert CITATION.cff files')
+      expect(subject.subjects).to eq([{ 'subject' => 'bibliography' },
+                                      { 'subject' => 'bibtex' },
+                                      { 'subject' => 'cff' },
+                                      { 'subject' => 'citation' },
+                                      { 'subject' => 'citation.cff' },
+                                      { 'subject' => 'codemeta' },
+                                      { 'subject' => 'endnote' },
+                                      { 'subject' => 'ris' },
+                                      { 'subject' => 'citation file format' }])
+      expect(subject.version_info).to eq('2.0.0')
+      expect(subject.dates).to eq([{ 'date' => '2021-09-22', 'dateType' => 'Issued' }])
+      expect(subject.publication_year).to eq('2021')
+      expect(subject.publisher).to eq('GitHub')
+      expect(subject.rights_list).to eq([{ 'rights' => 'Apache License 2.0',
+                                           'rightsIdentifier' => 'apache-2.0',
+                                           'rightsIdentifierScheme' => 'SPDX',
+                                           'rightsUri' => 'http://www.apache.org/licenses/LICENSE-2.0',
+                                           'schemeUri' => 'https://spdx.org/licenses/' }])
+      expect(subject.related_identifiers).to eq([{
+                                                  'relatedIdentifier' => 'https://doi.org/10.5281/zenodo.1310751', 'relatedIdentifierType' => 'DOI', 'relationType' => 'References'
+                                                }])
     end
 
-    it "ruby-cff" do
+    it 'ruby-cff' do
       expect(subject.valid?).to be true
-      expect(subject.id).to eq("https://doi.org/10.5281/zenodo.1184077")
-      expect(subject.url).to eq("https://github.com/citation-file-format/ruby-cff")
-      expect(subject.types).to eq("bibtex"=>"misc", "citeproc"=>"article-journal", "resourceTypeGeneral"=>"Software", "ris"=>"COMP", "schemaOrg"=>"SoftwareSourceCode")
-      expect(subject.creators).to eq([{"affiliation"=>[{"name"=>"The University of Manchester, UK"}], "familyName"=>"Haines", "givenName"=>"Robert", "name"=>"Haines, Robert", "nameIdentifiers"=>
-        [{"nameIdentifier"=>"https://orcid.org/0000-0002-9538-7919",
-          "nameIdentifierScheme"=>"ORCID",
-          "schemeUri"=>"https://orcid.org"}], "nameType"=>"Personal"}, {"name"=>"The Ruby Citation File Format Developers", "nameType"=>"Organizational"}])
-      expect(subject.titles).to eq([{"title"=>"Ruby CFF Library"}])
-      expect(subject.descriptions.first["description"]).to start_with("This library provides a Ruby interface to manipulate Citation File Format files")
-      expect(subject.subjects).to eq([{"subject"=>"ruby"},
-        {"subject"=>"credit"},
-        {"subject"=>"software citation"},
-        {"subject"=>"research software"},
-        {"subject"=>"software sustainability"},
-        {"subject"=>"metadata"},
-        {"subject"=>"citation file format"},
-        {"subject"=>"cff"}])
-      expect(subject.version_info).to eq("0.9.0")
-      expect(subject.dates).to eq([{"date"=>"2021-08-18", "dateType"=>"Issued"}])
-      expect(subject.publication_year).to eq("2021")
-      expect(subject.publisher).to eq("GitHub")
-      expect(subject.rights_list).to eq([{"rights"=>"Apache License 2.0",
-        "rightsIdentifier"=>"apache-2.0",
-        "rightsIdentifierScheme"=>"SPDX",
-        "rightsUri"=>"http://www.apache.org/licenses/LICENSE-2.0",
-        "schemeUri"=>"https://spdx.org/licenses/"}])
-      expect(subject.related_identifiers).to eq([{"relatedIdentifier"=>"https://doi.org/10.5281/zenodo.1003149", "relatedIdentifierType"=>"DOI", "relationType"=>"References"}])
+      expect(subject.id).to eq('https://doi.org/10.5281/zenodo.1184077')
+      expect(subject.url).to eq('https://github.com/citation-file-format/ruby-cff')
+      expect(subject.types).to eq('bibtex' => 'misc', 'citeproc' => 'article-journal',
+                                  'resourceTypeGeneral' => 'Software', 'ris' => 'COMP', 'schemaOrg' => 'SoftwareSourceCode')
+      expect(subject.creators).to eq([{ 'affiliation' => [{ 'name' => 'The University of Manchester, UK' }], 'familyName' => 'Haines', 'givenName' => 'Robert', 'name' => 'Haines, Robert', 'nameIdentifiers' =>
+        [{ 'nameIdentifier' => 'https://orcid.org/0000-0002-9538-7919',
+           'nameIdentifierScheme' => 'ORCID',
+           'schemeUri' => 'https://orcid.org' }], 'nameType' => 'Personal' }, { 'name' => 'The Ruby Citation File Format Developers', 'nameType' => 'Organizational' }])
+      expect(subject.titles).to eq([{ 'title' => 'Ruby CFF Library' }])
+      expect(subject.descriptions.first['description']).to start_with('This library provides a Ruby interface to manipulate Citation File Format files')
+      expect(subject.subjects).to eq([{ 'subject' => 'ruby' },
+                                      { 'subject' => 'credit' },
+                                      { 'subject' => 'software citation' },
+                                      { 'subject' => 'research software' },
+                                      { 'subject' => 'software sustainability' },
+                                      { 'subject' => 'metadata' },
+                                      { 'subject' => 'citation file format' },
+                                      { 'subject' => 'cff' }])
+      expect(subject.version_info).to eq('0.9.0')
+      expect(subject.dates).to eq([{ 'date' => '2021-08-18', 'dateType' => 'Issued' }])
+      expect(subject.publication_year).to eq('2021')
+      expect(subject.publisher).to eq('GitHub')
+      expect(subject.rights_list).to eq([{ 'rights' => 'Apache License 2.0',
+                                           'rightsIdentifier' => 'apache-2.0',
+                                           'rightsIdentifierScheme' => 'SPDX',
+                                           'rightsUri' => 'http://www.apache.org/licenses/LICENSE-2.0',
+                                           'schemeUri' => 'https://spdx.org/licenses/' }])
+      expect(subject.related_identifiers).to eq([{
+                                                  'relatedIdentifier' => 'https://doi.org/10.5281/zenodo.1003149', 'relatedIdentifierType' => 'DOI', 'relationType' => 'References'
+                                                }])
     end
 
-    it "ruby-cff repository url" do
-      input = "https://github.com/citation-file-format/ruby-cff"
-      subject = Briard::Metadata.new(input: input)
+    it 'ruby-cff repository url' do
+      input = 'https://github.com/citation-file-format/ruby-cff'
+      subject = described_class.new(input: input)
       expect(subject.valid?).to be true
-      expect(subject.id).to eq("https://doi.org/10.5281/zenodo.1184077")
-      expect(subject.url).to eq("https://github.com/citation-file-format/ruby-cff")
-      expect(subject.types).to eq("bibtex"=>"misc", "citeproc"=>"article-journal", "resourceTypeGeneral"=>"Software", "ris"=>"COMP", "schemaOrg"=>"SoftwareSourceCode")
-      expect(subject.creators).to eq([{"affiliation"=>[{"name"=>"The University of Manchester, UK"}], "familyName"=>"Haines", "givenName"=>"Robert", "name"=>"Haines, Robert", "nameIdentifiers"=>
-        [{"nameIdentifier"=>"https://orcid.org/0000-0002-9538-7919",
-          "nameIdentifierScheme"=>"ORCID",
-          "schemeUri"=>"https://orcid.org"}], "nameType"=>"Personal"}, {"name"=>"The Ruby Citation File Format Developers", "nameType"=>"Organizational"}])
-      expect(subject.titles).to eq([{"title"=>"Ruby CFF Library"}])
-      expect(subject.descriptions.first["description"]).to start_with("This library provides a Ruby interface to manipulate Citation File Format files")
-      expect(subject.subjects).to eq([{"subject"=>"ruby"},
-        {"subject"=>"credit"},
-        {"subject"=>"software citation"},
-        {"subject"=>"research software"},
-        {"subject"=>"software sustainability"},
-        {"subject"=>"metadata"},
-        {"subject"=>"citation file format"},
-        {"subject"=>"cff"}])
-      expect(subject.version_info).to eq("0.9.0")
-      expect(subject.dates).to eq([{"date"=>"2021-08-18", "dateType"=>"Issued"}])
-      expect(subject.publication_year).to eq("2021")
-      expect(subject.publisher).to eq("GitHub")
-      expect(subject.rights_list).to eq([{"rights"=>"Apache License 2.0",
-        "rightsIdentifier"=>"apache-2.0",
-        "rightsIdentifierScheme"=>"SPDX",
-        "rightsUri"=>"http://www.apache.org/licenses/LICENSE-2.0",
-        "schemeUri"=>"https://spdx.org/licenses/"}])
-      expect(subject.related_identifiers).to eq([{"relatedIdentifier"=>"https://doi.org/10.5281/zenodo.1003149", "relatedIdentifierType"=>"DOI", "relationType"=>"References"}])
+      expect(subject.id).to eq('https://doi.org/10.5281/zenodo.1184077')
+      expect(subject.url).to eq('https://github.com/citation-file-format/ruby-cff')
+      expect(subject.types).to eq('bibtex' => 'misc', 'citeproc' => 'article-journal',
+                                  'resourceTypeGeneral' => 'Software', 'ris' => 'COMP', 'schemaOrg' => 'SoftwareSourceCode')
+      expect(subject.creators).to eq([{ 'affiliation' => [{ 'name' => 'The University of Manchester, UK' }], 'familyName' => 'Haines', 'givenName' => 'Robert', 'name' => 'Haines, Robert', 'nameIdentifiers' =>
+        [{ 'nameIdentifier' => 'https://orcid.org/0000-0002-9538-7919',
+           'nameIdentifierScheme' => 'ORCID',
+           'schemeUri' => 'https://orcid.org' }], 'nameType' => 'Personal' }, { 'name' => 'The Ruby Citation File Format Developers', 'nameType' => 'Organizational' }])
+      expect(subject.titles).to eq([{ 'title' => 'Ruby CFF Library' }])
+      expect(subject.descriptions.first['description']).to start_with('This library provides a Ruby interface to manipulate Citation File Format files')
+      expect(subject.subjects).to eq([{ 'subject' => 'ruby' },
+                                      { 'subject' => 'credit' },
+                                      { 'subject' => 'software citation' },
+                                      { 'subject' => 'research software' },
+                                      { 'subject' => 'software sustainability' },
+                                      { 'subject' => 'metadata' },
+                                      { 'subject' => 'citation file format' },
+                                      { 'subject' => 'cff' }])
+      expect(subject.version_info).to eq('0.9.0')
+      expect(subject.dates).to eq([{ 'date' => '2021-08-18', 'dateType' => 'Issued' }])
+      expect(subject.publication_year).to eq('2021')
+      expect(subject.publisher).to eq('GitHub')
+      expect(subject.rights_list).to eq([{ 'rights' => 'Apache License 2.0',
+                                           'rightsIdentifier' => 'apache-2.0',
+                                           'rightsIdentifierScheme' => 'SPDX',
+                                           'rightsUri' => 'http://www.apache.org/licenses/LICENSE-2.0',
+                                           'schemeUri' => 'https://spdx.org/licenses/' }])
+      expect(subject.related_identifiers).to eq([{
+                                                  'relatedIdentifier' => 'https://doi.org/10.5281/zenodo.1003149', 'relatedIdentifierType' => 'DOI', 'relationType' => 'References'
+                                                }])
     end
   end
 end

data/spec/readers/citeproc_reader_spec.rb

@@ -3,59 +3,64 @@
 require 'spec_helper'
 
 describe Briard::Metadata, vcr: true do
-  let(:input) { fixture_path + "citeproc.json" }
+  subject { described_class.new(input: input, from: 'citeproc') }
 
-  subject { Briard::Metadata.new(input: input, from: "citeproc") }
+  let(:input) { "#{fixture_path}citeproc.json" }
 
-  context "get citeproc raw" do
-    it "BlogPosting" do
-      expect(subject.raw).to eq(IO.read(input).strip)
+  context 'get citeproc raw' do
+    it 'BlogPosting' do
+      expect(subject.raw).to eq(File.read(input).strip)
     end
   end
 
-  context "get citeproc metadata" do
-    it "BlogPosting" do
+  context 'get citeproc metadata' do
+    it 'BlogPosting' do
       expect(subject.valid?).to be true
-      expect(subject.id).to eq("https://doi.org/10.5438/4k3m-nyvg")
-      expect(subject.url).to eq("https://blog.datacite.org/eating-your-own-dog-food")
-      expect(subject.types).to eq("bibtex"=>"article", "citeproc"=>"post-weblog", "resourceTypeGeneral"=>"Text", "ris"=>"GEN", "schemaOrg"=>"BlogPosting")
-      expect(subject.creators).to eq([{"familyName"=>"Fenner", "givenName"=>"Martin", "name"=>"Fenner, Martin"}])
-      expect(subject.titles).to eq([{"title"=>"Eating your own Dog Food"}])
-      expect(subject.descriptions.first["description"]).to start_with("Eating your own dog food")
-      expect(subject.dates).to eq([{"date"=>"2016-12-20", "dateType"=>"Issued"}])
-      expect(subject.publication_year).to eq("2016")
+      expect(subject.id).to eq('https://doi.org/10.5438/4k3m-nyvg')
+      expect(subject.url).to eq('https://blog.datacite.org/eating-your-own-dog-food')
+      expect(subject.types).to eq('bibtex' => 'article', 'citeproc' => 'post-weblog',
+                                  'resourceTypeGeneral' => 'Text', 'ris' => 'GEN', 'schemaOrg' => 'BlogPosting')
+      expect(subject.creators).to eq([{ 'familyName' => 'Fenner', 'givenName' => 'Martin',
+                                        'name' => 'Fenner, Martin' }])
+      expect(subject.titles).to eq([{ 'title' => 'Eating your own Dog Food' }])
+      expect(subject.descriptions.first['description']).to start_with('Eating your own dog food')
+      expect(subject.dates).to eq([{ 'date' => '2016-12-20', 'dateType' => 'Issued' }])
+      expect(subject.publication_year).to eq('2016')
     end
   end
 
-  context "get citeproc no categories" do
-    it "BlogPosting" do
-      input = fixture_path + "citeproc-no-categories.json"
-      subject = Briard::Metadata.new(input: input)
+  context 'get citeproc no categories' do
+    it 'BlogPosting' do
+      input = "#{fixture_path}citeproc-no-categories.json"
+      subject = described_class.new(input: input)
       expect(subject.valid?).to be true
-      expect(subject.id).to eq("https://doi.org/10.5072/4k3m-nyvg")
-      expect(subject.url).to eq("https://blog.datacite.org/eating-your-own-dog-food")
-      expect(subject.types).to eq("bibtex"=>"article", "citeproc"=>"post-weblog", "resourceTypeGeneral"=>"Text", "ris"=>"GEN", "schemaOrg"=>"BlogPosting")
-      expect(subject.creators).to eq([{"familyName"=>"Fenner", "givenName"=>"Martin", "name"=>"Fenner, Martin"}])
-      expect(subject.titles).to eq([{"title"=>"Eating your own Dog Food"}])
-      expect(subject.descriptions.first["description"]).to start_with("Eating your own dog food")
-      expect(subject.dates).to eq([{"date"=>"2016-12-20", "dateType"=>"Issued"}])
-      expect(subject.publication_year).to eq("2016")
+      expect(subject.id).to eq('https://doi.org/10.5072/4k3m-nyvg')
+      expect(subject.url).to eq('https://blog.datacite.org/eating-your-own-dog-food')
+      expect(subject.types).to eq('bibtex' => 'article', 'citeproc' => 'post-weblog',
+                                  'resourceTypeGeneral' => 'Text', 'ris' => 'GEN', 'schemaOrg' => 'BlogPosting')
+      expect(subject.creators).to eq([{ 'familyName' => 'Fenner', 'givenName' => 'Martin',
+                                        'name' => 'Fenner, Martin' }])
+      expect(subject.titles).to eq([{ 'title' => 'Eating your own Dog Food' }])
+      expect(subject.descriptions.first['description']).to start_with('Eating your own dog food')
+      expect(subject.dates).to eq([{ 'date' => '2016-12-20', 'dateType' => 'Issued' }])
+      expect(subject.publication_year).to eq('2016')
     end
   end
 
-  context "get citeproc no author" do
-    it "Journal article" do
-      input = fixture_path + "citeproc-no-author.json"
-      subject = Briard::Metadata.new(input: input)
-      #expect(subject.valid?).to be true
-      expect(subject.id).to eq("https://doi.org/10.5438/4k3m-nyvg")
-      expect(subject.url).to eq("https://blog.datacite.org/eating-your-own-dog-food")
-      expect(subject.types).to eq("bibtex"=>"article", "citeproc"=>"post-weblog", "resourceTypeGeneral"=>"Text", "ris"=>"GEN", "schemaOrg"=>"BlogPosting")
-      expect(subject.creators).to eq([{"name"=>":(unav)", "nameType"=>"Organizational"}])
-      expect(subject.titles).to eq([{"title"=>"Eating your own Dog Food"}])
-      expect(subject.descriptions.first["description"]).to start_with("Eating your own dog food")
-      expect(subject.dates).to eq([{"date"=>"2016-12-20", "dateType"=>"Issued"}])
-      expect(subject.publication_year).to eq("2016")
+  context 'get citeproc no author' do
+    it 'Journal article' do
+      input = "#{fixture_path}citeproc-no-author.json"
+      subject = described_class.new(input: input)
+      # expect(subject.valid?).to be true
+      expect(subject.id).to eq('https://doi.org/10.5438/4k3m-nyvg')
+      expect(subject.url).to eq('https://blog.datacite.org/eating-your-own-dog-food')
+      expect(subject.types).to eq('bibtex' => 'article', 'citeproc' => 'post-weblog',
+                                  'resourceTypeGeneral' => 'Text', 'ris' => 'GEN', 'schemaOrg' => 'BlogPosting')
+      expect(subject.creators).to eq([{ 'name' => ':(unav)', 'nameType' => 'Organizational' }])
+      expect(subject.titles).to eq([{ 'title' => 'Eating your own Dog Food' }])
+      expect(subject.descriptions.first['description']).to start_with('Eating your own dog food')
+      expect(subject.dates).to eq([{ 'date' => '2016-12-20', 'dateType' => 'Issued' }])
+      expect(subject.publication_year).to eq('2016')
     end
   end
 end