braintree 4.14.0 → 4.16.0

data/lib/braintree/transaction.rb

@@ -77,9 +77,9 @@ module Braintree
       All = constants.map { |c| const_get(c) }
     end
 
-    module Type # :nodoc:
-      Credit = "credit" # :nodoc:
-      Sale = "sale" # :nodoc:
+    module Type
+      Credit = "credit"
+      Sale = "sale"
 
       All = constants.map { |c| const_get(c) }
     end
@@ -91,8 +91,9 @@ module Braintree
       end
     end
 
-    attr_reader :acquirer_reference_number
     attr_reader :ach_return_code
+    attr_reader :ach_return_responses
+    attr_reader :acquirer_reference_number
     attr_reader :add_ons
     attr_reader :additional_processor_response          # The raw response from the processor.
     attr_reader :amount
@@ -111,6 +112,7 @@ module Braintree
     attr_reader :custom_fields
     attr_reader :customer_details
     attr_reader :cvv_response_code
+    attr_reader :debit_network
     attr_reader :descriptor
     attr_reader :disbursement_details
     attr_reader :discount_amount
@@ -129,6 +131,8 @@ module Braintree
     attr_reader :merchant_account_id
     attr_reader :merchant_advice_code
     attr_reader :merchant_advice_code_text
+    attr_reader :meta_checkout_card_details
+    attr_reader :meta_checkout_token_details
     attr_reader :network_response_code                  # Response code from the card network
     attr_reader :network_response_text                  # Response text from the card network
     attr_reader :network_token_details
@@ -140,18 +144,18 @@ module Braintree
     attr_reader :paypal_details
     attr_reader :paypal_here_details
     attr_reader :plan_id
-    attr_reader :processor_authorization_code           # Authorization code from the processor.
-    attr_reader :processor_response_code                # Response code from the processor.
-    attr_reader :processor_response_text                # Response text from the processor.
-    attr_reader :processor_response_type                # Response type from the processor.
-    attr_reader :processor_settlement_response_code     # Settlement response code from the processor.
-    attr_reader :processor_settlement_response_text     # Settlement response text from the processor.
+    attr_reader :processor_authorization_code
+    attr_reader :processor_response_code
+    attr_reader :processor_response_text
+    attr_reader :processor_response_type
+    attr_reader :processor_settlement_response_code
+    attr_reader :processor_settlement_response_text
     attr_reader :product_sku
     attr_reader :purchase_order_number
     attr_reader :recurring
     attr_reader :refund_ids
-    attr_reader :refunded_transaction_id
     attr_reader :refunded_installments
+    attr_reader :refunded_transaction_id
     attr_reader :retried
     attr_reader :retried_transaction_id                 # the primary/parent transaction id of any retried transaction
     attr_reader :retrieval_reference_number
@@ -159,9 +163,9 @@ module Braintree
     attr_reader :risk_data
     attr_reader :samsung_pay_card_details
     attr_reader :sca_exemption_requested
-    attr_reader :service_fee_amount
     attr_reader :sepa_direct_debit_account_details
     attr_reader :sepa_direct_debit_return_code
+    attr_reader :service_fee_amount
     attr_reader :settlement_batch_id
     attr_reader :shipping_amount
     attr_reader :shipping_details
@@ -173,13 +177,12 @@ module Braintree
     attr_reader :tax_amount
     attr_reader :tax_exempt
     attr_reader :three_d_secure_info
-    attr_reader :type                                   # Will either be "sale" or "credit"
+    attr_reader :type
     attr_reader :updated_at
     attr_reader :us_bank_account_details
     attr_reader :venmo_account_details
     attr_reader :visa_checkout_card_details
     attr_reader :voice_referral_number
-    attr_reader :ach_return_responses
 
     def self.adjust_authorization(*args)
       Configuration.gateway.transaction.adjust_authorization(*args)
@@ -297,7 +300,7 @@ module Braintree
       Configuration.gateway.transaction.void!(*args)
     end
 
-    def initialize(gateway, attributes) # :nodoc:
+    def initialize(gateway, attributes)
       @gateway = gateway
       set_instance_variables_from_hash(attributes)
 
@@ -312,6 +315,8 @@ module Braintree
       @disbursement_details = DisbursementDetails.new(@disbursement_details)
       @google_pay_details = GooglePayDetails.new(@google_pay_card)
       @local_payment_details = LocalPaymentDetails.new(@local_payment)
+      @meta_checkout_card_details = MetaCheckoutCardDetails.new(attributes[:meta_checkout_card])
+      @meta_checkout_token_details = MetaCheckoutTokenDetails.new(attributes[:meta_checkout_token])
       @payment_instrument_type = attributes[:payment_instrument_type]
       @payment_receipt = PaymentReceipt.new(attributes[:payment_receipt]) if attributes[:payment_receipt]
       @paypal_details = PayPalDetails.new(@paypal)
@@ -341,7 +346,7 @@ module Braintree
       refunded_installments.map! { |attrs| Installment.new(attrs) } if refunded_installments
     end
 
-    def inspect # :nodoc:
+    def inspect
       first = [:id, :type, :amount, :status]
       order = first + (self.class._attributes - first)
       nice_attributes = order.map do |attr|
@@ -358,12 +363,10 @@ module Braintree
       @gateway.transaction_line_item.find_all(id)
     end
 
-    # Returns true if the transaction has been refunded. False otherwise.
     def refunded?
       !@refund_id.nil?
     end
 
-    # Returns true if the transaction has been disbursed. False otherwise.
     def disbursed?
       @disbursement_details.valid?
     end
@@ -372,6 +375,7 @@ module Braintree
     # vault_billing_address will return the associated Braintree::Address. Because the
     # vault billing address can be updated after the transaction was created, the attributes
     # on vault_billing_address may not match the attributes on billing_details.
+    # NEXT_MAJOR_VERSION these methods are not documented in the developer docs, remove
     def vault_billing_address
       return nil if billing_details.id.nil?
       @gateway.address.find(customer_details.id, billing_details.id)
@@ -381,6 +385,7 @@ module Braintree
     # vault_credit_card will return the associated Braintree::CreditCard. Because the
     # vault credit card can be updated after the transaction was created, the attributes
     # on vault_credit_card may not match the attributes on credit_card_details.
+    # NEXT_MAJOR_VERSION these methods are not documented in the developer docs, remove
     def vault_credit_card
       return nil if credit_card_details.token.nil?
       @gateway.credit_card.find(credit_card_details.token)
@@ -390,6 +395,7 @@ module Braintree
     # vault_customer will return the associated Braintree::Customer. Because the
     # vault customer can be updated after the transaction was created, the attributes
     # on vault_customer may not match the attributes on customer_details.
+    # NEXT_MAJOR_VERSION these methods are not documented in the developer docs, remove
     def vault_customer
       return nil if customer_details.id.nil?
       @gateway.customer.find(customer_details.id)
@@ -399,6 +405,7 @@ module Braintree
     # vault_shipping_address will return the associated Braintree::Address. Because the
     # vault shipping address can be updated after the transaction was created, the attributes
     # on vault_shipping_address may not match the attributes on shipping_details.
+    # NEXT_MAJOR_VERSION these methods are not documented in the developer docs, remove
     def vault_shipping_address
       return nil if shipping_details.id.nil?
       @gateway.address.find(customer_details.id, shipping_details.id)
@@ -410,12 +417,12 @@ module Braintree
 
     class << self
       protected :new
-      def _new(*args) # :nodoc:
+      def _new(*args)
         self.new(*args)
       end
     end
 
-    def self._attributes # :nodoc:
+    def self._attributes
       [:amount, :created_at, :credit_card_details, :customer_details, :id, :status, :subscription_details, :type, :updated_at, :processed_with_network_token?]
     end
   end

data/lib/braintree/transaction_gateway.rb

@@ -1,5 +1,5 @@
 module Braintree
-  class TransactionGateway # :nodoc:
+  class TransactionGateway
     include BaseModule
 
     def initialize(gateway)
@@ -9,6 +9,14 @@ module Braintree
     end
 
     def create(attributes)
+      # NEXT_MAJOR_VERSION remove this check
+      if attributes.has_key?(:venmo_sdk_payment_method_code) || attributes.has_key?(:venmo_sdk_session)
+        warn "[DEPRECATED] The Venmo SDK integration is Unsupported. Please update your integration to use Pay with Venmo instead."
+      end
+      # NEXT_MAJOR_VERSION remove this check
+      if attributes.has_key?(:three_d_secure_token)
+        warn "[DEPRECATED] Passing :three_d_secure_token to create is deprecated. Please use :three_d_secure_authentication_id"
+      end
       Util.verify_keys(TransactionGateway._create_signature, attributes)
       _do_create "/transactions", :transaction => attributes
     end
@@ -179,19 +187,22 @@ module Braintree
       return_object_or_raise(:transaction) { void(*args) }
     end
 
-    def self._clone_signature # :nodoc:
+    def self._clone_signature
       [:amount, :channel, {:options => [:submit_for_settlement]}]
     end
 
-    def self._create_signature # :nodoc:
+    # NEXT_MAJOR_VERSION Remove venmo_sdk_payment_method_code, venmo_sdk_session, and three_d_secure_token
+    # The old venmo SDK class has been deprecated
+    # three_d_secure_token has been deprecated in favor of three_d_secure_authentication_id
+    def self._create_signature
       [
         :amount, :billing_address_id, :channel, :customer_id, :device_data, :discount_amount,
         :merchant_account_id, :order_id, :payment_method_nonce, :payment_method_token,
         :product_sku, :purchase_order_number, :service_fee_amount, :shared_billing_address_id,
         :shared_customer_id, :shared_payment_method_nonce, :shared_payment_method_token,
         :shared_shipping_address_id, :shipping_address_id, :shipping_amount,
-        :ships_from_postal_code, :tax_amount, :tax_exempt, :three_d_secure_authentication_id,
-        :three_d_secure_token, :transaction_source, :type, :venmo_sdk_payment_method_code,
+        :ships_from_postal_code, :tax_amount, :tax_exempt, :three_d_secure_authentication_id,:three_d_secure_token, #Deprecated
+        :transaction_source, :type, :venmo_sdk_payment_method_code, # Deprecated
         :sca_exemption, :currency_iso_code, :exchange_rate_quote_id,
         {:line_items => [:quantity, :name, :description, :kind, :unit_amount, :unit_tax_amount, :total_amount, :discount_amount, :tax_amount, :unit_of_measure, :product_code, :commodity_code, :url]},
         {:risk_data => [:customer_browser, :customer_device_id, :customer_ip, :customer_location_zip, :customer_tenure]},
@@ -222,7 +233,7 @@ module Braintree
           :submit_for_settlement,
           :add_billing_address_to_payment_method,
           :store_shipping_address_in_vault,
-          :venmo_sdk_session,
+          :venmo_sdk_session, # Deprecated
           :payee_id,
           :payee_email,
           :skip_advanced_fraud_checking,
@@ -246,7 +257,7 @@ module Braintree
         {:industry => [
           :industry_type,
           {:data => [
-            :folio_number, :check_in_date, :check_out_date, :travel_package, :lodging_check_in_date, :lodging_check_out_date, :departure_date, :lodging_name, :room_rate, :room_tax,
+            :country_code, :date_of_birth, :folio_number, :check_in_date, :check_out_date, :travel_package, :lodging_check_in_date, :lodging_check_out_date, :departure_date, :lodging_name, :room_rate, :room_tax,
             :passenger_first_name, :passenger_last_name, :passenger_middle_initial, :passenger_title, :issued_date, :travel_agency_name, :travel_agency_code, :ticket_number,
             :issuing_carrier_code, :customer_code, :fare_amount, :fee_amount, :tax_amount, :restricted_ticket, :no_show, :advanced_deposit, :fire_safe, :property_phone, :ticket_issuer_address, :arrival_date,
             {:legs => [
@@ -264,14 +275,14 @@ module Braintree
       ]
     end
 
-    def self._submit_for_settlement_signature # :nodoc:
+    def self._submit_for_settlement_signature
       [
         :order_id,
         {:descriptor => [:name, :phone, :url]},
         {:industry => [
           :industry_type,
           {:data => [
-            :folio_number, :check_in_date, :check_out_date, :travel_package, :lodging_check_in_date, :lodging_check_out_date, :departure_date, :lodging_name, :room_rate, :room_tax,
+            :country_code, :date_of_birth, :folio_number, :check_in_date, :check_out_date, :travel_package, :lodging_check_in_date, :lodging_check_out_date, :departure_date, :lodging_name, :room_rate, :room_tax,
             :passenger_first_name, :passenger_last_name, :passenger_middle_initial, :passenger_title, :issued_date, :travel_agency_name, :travel_agency_code, :ticket_number,
             :issuing_carrier_code, :customer_code, :fare_amount, :fee_amount, :tax_amount, :restricted_ticket, :no_show, :advanced_deposit, :fire_safe, :property_phone, :ticket_issuer_address, :arrival_date,
             {:legs => [
@@ -299,7 +310,7 @@ module Braintree
       ]
     end
 
-    def self._update_details_signature # :nodoc:
+    def self._update_details_signature
       [
         :amount,
         :order_id,
@@ -315,7 +326,7 @@ module Braintree
       ]
     end
 
-    def _do_create(path, params=nil) # :nodoc:
+    def _do_create(path, params=nil)
       if !params.nil?
         params = Util.replace_key(params, :google_pay_card, :android_pay_card)
       end
@@ -323,7 +334,7 @@ module Braintree
       _handle_transaction_response(response)
     end
 
-    def _fetch_transactions(search, ids) # :nodoc:
+    def _fetch_transactions(search, ids)
       search.ids.in ids
       response = @config.http.post("#{@config.base_merchant_path}/transactions/advanced_search", {:search => search.to_hash})
       attributes = response[:credit_card_transactions]

data/lib/braintree/transaction_line_item.rb

@@ -15,7 +15,7 @@ module Braintree
     attr_reader :commodity_code
     attr_reader :url
 
-    def initialize(gateway, attributes) # :nodoc:
+    def initialize(gateway, attributes)
       @gateway = gateway
       set_instance_variables_from_hash(attributes)
       @quantity = Util.to_big_decimal(quantity)
@@ -28,7 +28,7 @@ module Braintree
 
     class << self
       protected :new
-      def _new(*args) # :nodoc:
+      def _new(*args)
         self.new(*args)
       end
     end

data/lib/braintree/transaction_line_item_gateway.rb

@@ -1,5 +1,5 @@
 module Braintree
-  class TransactionLineItemGateway # :nodoc:
+  class TransactionLineItemGateway
     def initialize(gateway)
       @gateway = gateway
       @config = gateway.config

data/lib/braintree/transaction_review.rb

@@ -10,7 +10,7 @@ module Braintree
 
     class << self
       protected :new
-      def _new(*args) # :nodoc:
+      def _new(*args)
         self.new(*args)
       end
     end

data/lib/braintree/transaction_search.rb

@@ -1,5 +1,5 @@
 module Braintree
-  class TransactionSearch < AdvancedSearch # :nodoc:
+  class TransactionSearch < AdvancedSearch
     text_fields(
       :billing_company,
       :billing_country_name,
@@ -54,15 +54,16 @@ module Braintree
       CreditCard::CustomerLocation::International,
       CreditCard::CustomerLocation::US
     ]
+    multiple_value_field :debit_network, :allows => CreditCard::DebitNetwork::All
     multiple_value_field :ids
-    multiple_value_field :payment_instrument_type
-    multiple_value_field :user
     multiple_value_field :merchant_account_id
-    multiple_value_field :status, :allows => Transaction::Status::All
+    multiple_value_field :payment_instrument_type
+    multiple_value_field :reason_code
     multiple_value_field :source
-    multiple_value_field :type, :allows => Transaction::Type::All
+    multiple_value_field :status, :allows => Transaction::Status::All
     multiple_value_field :store_ids
-    multiple_value_field :reason_code
+    multiple_value_field :type, :allows => Transaction::Type::All
+    multiple_value_field :user
 
     key_value_fields :refund
 

data/lib/braintree/unknown_payment_method.rb

@@ -19,7 +19,7 @@ module Braintree
       "https://assets.braintreegateway.com/payment_method_logo/unknown.png"
     end
 
-    def self._new(*args) # :nodoc:
+    def self._new(*args)
       self.new(*args)
     end
   end

data/lib/braintree/us_bank_account.rb

@@ -14,7 +14,7 @@ module Braintree
     attr_reader :verifications
     attr_reader :verified
 
-    def initialize(gateway, attributes) # :nodoc:
+    def initialize(gateway, attributes)
       @gateway = gateway
       set_instance_variables_from_hash(attributes)
       @ach_mandate = AchMandate.new(attributes[:ach_mandate]) if attributes[:ach_mandate]
@@ -34,7 +34,7 @@ module Braintree
       protected :new
     end
 
-    def self._new(*args) # :nodoc:
+    def self._new(*args)
       self.new(*args)
     end
 

data/lib/braintree/us_bank_account_verification.rb

@@ -22,33 +22,41 @@ module Braintree
       All = [IndependentCheck, NetworkCheck, TokenizedCheck, MicroTransfers]
     end
 
+    module VerificationAddOns
+      CustomerVerification = "customer_verification"
+
+      All = [CustomerVerification]
+    end
+
+    attr_reader :additional_processor_response
+    attr_reader :created_at
+    attr_reader :gateway_rejection_reason
     attr_reader :id
-    attr_reader :status
-    attr_reader :verification_determined_at
-    attr_reader :verification_method
+    attr_reader :merchant_account_id
     attr_reader :processor_response_code
     attr_reader :processor_response_text
-    attr_reader :merchant_account_id
-    attr_reader :gateway_rejection_reason
+    attr_reader :status
     attr_reader :us_bank_account
-    attr_reader :created_at
+    attr_reader :verification_determined_at
+    attr_reader :verification_method
 
-    def initialize(attributes) # :nodoc:
+    def initialize(attributes)
       set_instance_variables_from_hash(attributes)
     end
 
-    def inspect # :nodoc:
+    def inspect
       attr_order = [
-        :status,
-        :processor_response_code,
-        :processor_response_text,
-        :merchant_account_id,
+        :additional_processor_response,
+        :created_at,
         :gateway_rejection_reason,
         :id,
+        :merchant_account_id,
+        :processor_response_code,
+        :processor_response_text,
+        :status,
         :us_bank_account,
-        :verification_method,
         :verification_determined_at,
-        :created_at
+        :verification_method
       ]
 
       formatted_attrs = attr_order.map do |attr|
@@ -62,7 +70,7 @@ module Braintree
       protected :new
     end
 
-    def self._new(*args) # :nodoc:
+    def self._new(*args)
       self.new(*args)
     end
 

data/lib/braintree/us_bank_account_verification_search.rb

@@ -1,5 +1,5 @@
 module Braintree
-  class UsBankAccountVerificationSearch < AdvancedSearch # :nodoc:
+  class UsBankAccountVerificationSearch < AdvancedSearch
      text_fields(
        :id,
        :account_holder_name,

data/lib/braintree/util.rb

@@ -1,5 +1,5 @@
 module Braintree
-  module Util # :nodoc:
+  module Util
     def self.extract_attribute_as_array(hash, attribute)
       raise UnexpectedError.new("Unprocessable entity due to an invalid request") if hash.nil?
       value = hash.has_key?(attribute) ? hash.delete(attribute) : []
@@ -195,14 +195,14 @@ module Braintree
     end
 
     module IdEquality
-      def ==(other) # :nodoc:
+      def ==(other)
         return false unless other.is_a?(self.class)
         id == other.id
       end
     end
 
     module TokenEquality
-      def ==(other) # :nodoc:
+      def ==(other)
         return false unless other.is_a?(self.class)
         token == other.token
       end

data/lib/braintree/validation_error.rb

@@ -18,7 +18,7 @@ module Braintree
       set_instance_variables_from_hash error_hash
     end
 
-    def inspect # :nodoc:
+    def inspect
       "#<#{self.class} (#{code}) #{message}>"
     end
   end

data/lib/braintree/validation_error_collection.rb

@@ -2,7 +2,7 @@ module Braintree
   class ValidationErrorCollection
     include Enumerable
 
-    def initialize(data) # :nodoc:
+    def initialize(data)
       return if !data.is_a? Hash
       @errors = (data[:errors] || {}).map { |hash| Braintree::ValidationError.new(hash) }
       @nested = {}
@@ -42,7 +42,7 @@ module Braintree
       self.for("index_#{index}".to_sym)
     end
 
-    def inspect # :nodoc:
+    def inspect
       "#<#{self.class} errors#{_inner_inspect}>"
     end
 
@@ -61,7 +61,7 @@ module Braintree
       @errors.size
     end
 
-    def _inner_inspect(scope = []) # :nodoc:
+    def _inner_inspect(scope = [])
       all = []
       scope_string = scope.join("/")
       if @errors.any?

data/lib/braintree/venmo_account.rb

@@ -1,6 +1,6 @@
 module Braintree
   class VenmoAccount
-    include BaseModule # :nodoc:
+    include BaseModule
 
     attr_reader :created_at
     attr_reader :customer_id
@@ -13,7 +13,7 @@ module Braintree
     attr_reader :username
     attr_reader :venmo_user_id
 
-    def initialize(gateway, attributes) # :nodoc:
+    def initialize(gateway, attributes)
       @gateway = gateway
       set_instance_variables_from_hash(attributes)
       @subscriptions = (@subscriptions || []).map { |subscription_hash| Subscription._new(@gateway, subscription_hash) }
@@ -27,7 +27,7 @@ module Braintree
       protected :new
     end
 
-    def self._new(*args) # :nodoc:
+    def self._new(*args)
       self.new(*args)
     end
   end

data/lib/braintree/venmo_profile_data.rb

@@ -2,13 +2,15 @@ module Braintree
   class VenmoProfileData
     include BaseModule
 
-    attr_reader :username
+    attr_reader :billing_address
+    attr_reader :email
     attr_reader :first_name
     attr_reader :last_name
     attr_reader :phone_number
-    attr_reader :email
+    attr_reader :shipping_address
+    attr_reader :username
 
-    def initialize(attributes) # :nodoc:
+    def initialize(attributes)
       set_instance_variables_from_hash(attributes)
     end
 
@@ -16,7 +18,7 @@ module Braintree
       protected :new
     end
 
-    def self._new(*args) # :nodoc:
+    def self._new(*args)
       self.new(*args)
     end
   end

data/lib/braintree/version.rb

@@ -1,7 +1,7 @@
 module Braintree
   module Version
     Major = 4
-    Minor = 14
+    Minor = 16
     Tiny = 0
 
     String = "#{Major}.#{Minor}.#{Tiny}"

data/lib/braintree/visa_checkout_card.rb

@@ -1,6 +1,6 @@
 module Braintree
   class VisaCheckoutCard
-    include BaseModule # :nodoc:
+    include BaseModule
     include Braintree::Util::TokenEquality
 
     attr_reader :billing_address
@@ -30,7 +30,7 @@ module Braintree
     attr_reader :updated_at
     attr_reader :verification
 
-    def initialize(gateway, attributes) # :nodoc:
+    def initialize(gateway, attributes)
       @gateway = gateway
       set_instance_variables_from_hash(attributes)
       @billing_address = attributes[:billing_address] ? Address._new(@gateway, attributes[:billing_address]) : nil
@@ -39,8 +39,8 @@ module Braintree
     end
 
     def _most_recent_verification(attributes)
-      verification = (attributes[:verifications] || []).sort_by { |verification| verification[:created_at] }.reverse.first
-      CreditCardVerification._new(verification) if verification
+      sorted_verifications = (attributes[:verifications] || []).sort_by { |verification| verification[:created_at] }.reverse.first
+      CreditCardVerification._new(sorted_verifications) if sorted_verifications
     end
 
     def default?
@@ -56,7 +56,7 @@ module Braintree
       @expired
     end
 
-    def inspect # :nodoc:
+    def inspect
       first = [:token]
       order = first + (self.class._attributes - first)
       nice_attributes = order.map do |attr|
@@ -73,7 +73,7 @@ module Braintree
       protected :new
     end
 
-    def self._attributes # :nodoc:
+    def self._attributes
       [
         :billing_address, :bin, :card_type, :cardholder_name, :created_at,
         :customer_id, :customer_location, :expiration_month, :expiration_year,
@@ -83,7 +83,7 @@ module Braintree
       ]
     end
 
-    def self._new(*args) # :nodoc:
+    def self._new(*args)
       self.new(*args)
     end
   end

data/lib/braintree/webhook_notification.rb

@@ -45,6 +45,7 @@ module Braintree
 
       RecipientUpdatedGrantedPaymentMethod = "recipient_updated_granted_payment_method"
 
+      SubscriptionBillingSkipped = "subscription_billing_skipped"
       SubscriptionCanceled = "subscription_canceled"
       SubscriptionChargedSuccessfully = "subscription_charged_successfully"
       SubscriptionChargedUnsuccessfully = "subscription_charged_unsuccessfully"
@@ -91,7 +92,7 @@ module Braintree
       Configuration.gateway.webhook_notification.verify(*args)
     end
 
-    def initialize(gateway, attributes) # :nodoc:
+    def initialize(gateway, attributes)
       @gateway = gateway
       set_instance_variables_from_hash(attributes)
       @error_result = ErrorResult.new(gateway, @subject[:api_error_response]) if @subject.has_key?(:api_error_response)
@@ -134,7 +135,7 @@ module Braintree
 
     class << self
       protected :new
-      def _new(*args) # :nodoc:
+      def _new(*args)
         self.new(*args)
       end
     end

data/lib/braintree/webhook_notification_gateway.rb

@@ -1,5 +1,5 @@
 module Braintree
-  class WebhookNotificationGateway # :nodoc:
+  class WebhookNotificationGateway
     def initialize(gateway)
       @gateway = gateway
       @config = gateway.config
@@ -36,8 +36,8 @@ module Braintree
       public_key, signature = _matching_signature_pair(signature_string)
       raise InvalidSignature, "no matching public key" if public_key.nil?
 
-      signature_matches = [payload, payload + "\n"].any? do |payload|
-        payload_signature = Braintree::Digest.hexdigest(@config.private_key, payload)
+      signature_matches = [payload, payload + "\n"].any? do |_payload|
+        payload_signature = Braintree::Digest.hexdigest(@config.private_key, _payload)
         Braintree::Digest.secure_compare(signature, payload_signature)
       end
       raise InvalidSignature, "signature does not match payload - one has been modified" unless signature_matches