braintree 4.14.0 → 4.16.0

data/spec/integration/braintree/http_spec.rb

@@ -34,7 +34,7 @@ describe Braintree::Http do
           Braintree::Configuration.logger.level = Logger::INFO
           Braintree::Customer.all
           utc_or_gmt = Time.now.utc.strftime("%Z")
-          output.string.should include("[Braintree] [10/Oct/2009 13:55:36 #{utc_or_gmt}] POST /merchants/integration_merchant_id/customers/advanced_search_ids 200")
+          expect(output.string).to include("[Braintree] [10/Oct/2009 13:55:36 #{utc_or_gmt}] POST /merchants/integration_merchant_id/customers/advanced_search_ids 200")
         end
       ensure
         Braintree::Configuration.logger = old_logger
@@ -56,13 +56,13 @@ describe Braintree::Http do
             :number => Braintree::Test::CreditCardNumbers::Visa,
             :expiration_date => "05/2009",
           )
-          result.success?.should == true
+          expect(result.success?).to eq(true)
           utc_or_gmt = Time.now.utc.strftime("%Z")
-          output.string.should include("[Braintree] [10/Oct/2009 13:55:36 #{utc_or_gmt}] POST /merchants/integration_merchant_id/payment_methods")
-          output.string.should include("[Braintree]   <cardholder-name>Sam Jones</cardholder-name>")
-          output.string.should include("[Braintree]   <number>401288******1881</number>")
-          output.string.should include("[Braintree] [10/Oct/2009 13:55:36 #{utc_or_gmt}] 201 Created")
-          output.string.should match(/\[Braintree\]   <token>\w+<\/token>/)
+          expect(output.string).to include("[Braintree] [10/Oct/2009 13:55:36 #{utc_or_gmt}] POST /merchants/integration_merchant_id/payment_methods")
+          expect(output.string).to include("[Braintree]   <cardholder-name>Sam Jones</cardholder-name>")
+          expect(output.string).to include("[Braintree]   <number>401288******1881</number>")
+          expect(output.string).to include("[Braintree] [10/Oct/2009 13:55:36 #{utc_or_gmt}] 201 Created")
+          expect(output.string).to match(/\[Braintree\]   <token>\w+<\/token>/)
         end
       ensure
         Braintree::Configuration.logger = old_logger
@@ -73,8 +73,8 @@ describe Braintree::Http do
       config = Braintree::Configuration.instantiate
       file = File.new("#{File.dirname(__FILE__)}/../../fixtures/files/bt_logo.png", "r")
       response = config.http.post("#{config.base_merchant_path}/document_uploads", {"document_upload[kind]" => "evidence_document"}, file)
-      response[:document_upload][:content_type].should == "image/png"
-      response[:document_upload][:id].should_not be_nil
+      expect(response[:document_upload][:content_type]).to eq("image/png")
+      expect(response[:document_upload][:id]).not_to be_nil
     end
 
     describe "user_agent" do
@@ -85,14 +85,14 @@ describe Braintree::Http do
       it "sets the User-Agent header using the default user agent" do
         config = Braintree::Configuration.instantiate
         response = config.http.get("#{config.base_merchant_path}/test/headers")
-        response[:headers][:HTTP_USER_AGENT].should == "Braintree Ruby Gem #{Braintree::Version::String}"
+        expect(response[:headers][:HTTP_USER_AGENT]).to eq("Braintree Ruby Gem #{Braintree::Version::String}")
       end
 
       it "sets the User-Agent header using a customer user agent" do
         Braintree::Configuration.custom_user_agent = "ActiveMerchant 1.2.3"
         config = Braintree::Configuration.instantiate
         response = config.http.get("#{config.base_merchant_path}/test/headers")
-        response[:headers][:HTTP_USER_AGENT].should == "Braintree Ruby Gem #{Braintree::Version::String} (ActiveMerchant 1.2.3)"
+        expect(response[:headers][:HTTP_USER_AGENT]).to eq("Braintree Ruby Gem #{Braintree::Version::String} (ActiveMerchant 1.2.3)")
       end
     end
 
@@ -102,7 +102,7 @@ describe Braintree::Http do
           original_env = Braintree::Configuration.environment
           Braintree::Configuration.environment = :sandbox
           Braintree::Configuration.ssl_version = :TLSv1
-          Braintree::Configuration.stub(:base_merchant_path).and_return("/")
+          allow(Braintree::Configuration).to receive(:base_merchant_path).and_return("/")
 
           expect do
             Braintree::Configuration.instantiate.http._http_do(Net::HTTP::Get, "/login")
@@ -118,7 +118,7 @@ describe Braintree::Http do
           original_env = Braintree::Configuration.environment
           Braintree::Configuration.environment = :sandbox
           Braintree::Configuration.ssl_version = :TLSv1_2
-          Braintree::Configuration.stub(:base_merchant_path).and_return("/")
+          allow(Braintree::Configuration).to receive(:base_merchant_path).and_return("/")
 
           expect do
             Braintree::Configuration.instantiate.http._http_do(Net::HTTP::Get, "/login")
@@ -136,8 +136,8 @@ describe Braintree::Http do
           original_env = Braintree::Configuration.environment
           Braintree::Configuration.environment = :development
           config = Braintree::Configuration.instantiate
-          config.stub(:ssl?).and_return(true)
-          config.stub(:port).and_return(SSL_TEST_PORT)
+          allow(config).to receive(:ssl?).and_return(true)
+          allow(config).to receive(:port).and_return(SSL_TEST_PORT)
 
           start_ssl_server do
             expect do
@@ -155,11 +155,11 @@ describe Braintree::Http do
           Braintree::Configuration.environment = :development
           # Random CA root file from a different certificate authority
           config = Braintree::Configuration.instantiate
-          config.stub(:ca_file).and_return(
+          allow(config).to receive(:ca_file).and_return(
             File.expand_path(File.join(File.dirname(__FILE__), "..", "..", "ssl", "geotrust_global.crt")),
           )
-          config.stub(:ssl?).and_return(true)
-          config.stub(:port).and_return(SSL_TEST_PORT)
+          allow(config).to receive(:ssl?).and_return(true)
+          allow(config).to receive(:port).and_return(SSL_TEST_PORT)
 
           start_ssl_server do
             expect do
@@ -175,7 +175,7 @@ describe Braintree::Http do
         begin
           original_env = Braintree::Configuration.environment
           Braintree::Configuration.environment = :qa
-          Braintree::Configuration.stub(:base_merchant_path).and_return("/")
+          allow(Braintree::Configuration).to receive(:base_merchant_path).and_return("/")
 
           expect do
             Braintree::Configuration.instantiate.http._http_do(Net::HTTP::Get, "/login")
@@ -189,7 +189,7 @@ describe Braintree::Http do
         begin
           original_env = Braintree::Configuration.environment
           Braintree::Configuration.environment = :sandbox
-          Braintree::Configuration.stub(:base_merchant_path).and_return("/")
+          allow(Braintree::Configuration).to receive(:base_merchant_path).and_return("/")
 
           expect do
             Braintree::Configuration.instantiate.http._http_do(Net::HTTP::Get, "/login")
@@ -203,7 +203,7 @@ describe Braintree::Http do
         begin
           original_env = Braintree::Configuration.environment
           Braintree::Configuration.environment = :production
-          Braintree::Configuration.stub(:base_merchant_path).and_return("/")
+          allow(Braintree::Configuration).to receive(:base_merchant_path).and_return("/")
 
           expect do
             Braintree::Configuration.instantiate.http._http_do(Net::HTTP::Get, "/login")
@@ -218,8 +218,8 @@ describe Braintree::Http do
           original_env = Braintree::Configuration.environment
           Braintree::Configuration.environment = :sandbox
           config = Braintree::Configuration.instantiate
-          config.stub(:base_merchant_path).and_return("/")
-          config.stub(:ca_file).and_return("does_not_exist")
+          allow(config).to receive(:base_merchant_path).and_return("/")
+          allow(config).to receive(:ca_file).and_return("does_not_exist")
 
           expect do
             config.http._http_do(Net::HTTP::Get, "/login")
@@ -234,13 +234,13 @@ describe Braintree::Http do
   describe "self._verify_ssl_certificate" do
     it "is false if preverify is false" do
       context = OpenSSL::X509::StoreContext.new(OpenSSL::X509::Store.new)
-      Braintree::Configuration.instantiate.http._verify_ssl_certificate(false, context).should == false
+      expect(Braintree::Configuration.instantiate.http._verify_ssl_certificate(false, context)).to eq(false)
     end
 
     it "returns false if ssl_context doesn't have an error code of 0" do
       context = OpenSSL::X509::StoreContext.new(OpenSSL::X509::Store.new)
       context.error = 19 # ca_file incorrect, self-signed
-      Braintree::Configuration.instantiate.http._verify_ssl_certificate(true, context).should == false
+      expect(Braintree::Configuration.instantiate.http._verify_ssl_certificate(true, context)).to eq(false)
     end
 
     it "doesn't raise if there is no error" do
@@ -258,8 +258,8 @@ describe Braintree::Http do
         utc_or_gmt = Time.now.utc.strftime("%Z")
         context = OpenSSL::X509::StoreContext.new(OpenSSL::X509::Store.new)
         context.error = 19
-        Braintree::Configuration.instantiate.http._verify_ssl_certificate(false, context).should == false
-        output.string.should include("SSL Verification failed -- Preverify: false, Error: self signed certificate in certificate chain (19)")
+        expect(Braintree::Configuration.instantiate.http._verify_ssl_certificate(false, context)).to eq(false)
+        expect(output.string).to include("SSL Verification failed -- Preverify: false, Error: self signed certificate in certificate chain (19)")
       ensure
         Braintree::Configuration.logger = old_logger
       end
@@ -275,7 +275,7 @@ describe Braintree::Http do
         expect do
           Braintree::Configuration.instantiate.http._verify_ssl_certificate(true, context)
         end.to_not raise_error
-        output.string.should == ""
+        expect(output.string).to eq("")
       ensure
         Braintree::Configuration.logger = old_logger
       end