braintree 4.14.0 → 4.16.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4b00fbf3fe7587ce0788471b730caa3db11f9b574a0077d83e03a9c0aef54e01
-  data.tar.gz: 3dd4395b7ca564f1ac454a290451c9716953b9297ad3b9101d7d6e07f3cc1972
+  metadata.gz: fbacdc492fa27aed57086131c1feab00ed435923034cae5dd7b5c6d4c3184a1a
+  data.tar.gz: a3c9be778fb88ef5a0ea6c23182f74654b511dca659e34529fade077712418ef
 SHA512:
-  metadata.gz: 665d8cef94dfe888f82c1b50c65bad773f5c6b4600937118b37cdc68f92b47150c148d6c0c45130e8e867f7507f13929975f3357ac769c8b9e982f1d7988cab6
-  data.tar.gz: 3555eb3944bf02f23912d17c323250d7112722f09bd825b7e6a5571fa44470d52800a7e92d4d738e6ab8f69c6a2fb98adddf626139b4ec78d39679beea0fee86
+  metadata.gz: 3b6e24f668d3bd022069f5e85ed55afe9fbdce43205af6dd44a101f6aef3f78d2b2099d5b8d5c8297cbf3076dee72da16e61d7b758cb162278190e99d9f95d91
+  data.tar.gz: 3ee3af6a1854de4b02db4670b3d32232b2ce7d26ae478bfa792dcc4ccfe638f52259e80e818704d630c8a0b453a1f566062865045f370f5f83a377e0c7083d16

data/lib/braintree/account_updater_daily_report.rb

@@ -1,5 +1,5 @@
 module Braintree
-  class AccountUpdaterDailyReport # :nodoc:
+  class AccountUpdaterDailyReport
     include BaseModule
 
     attr_reader :report_date
@@ -7,12 +7,12 @@ module Braintree
 
     class << self
       protected :new
-      def _new(*args) # :nodoc:
+      def _new(*args)
         self.new(*args)
       end
     end
 
-    def initialize(attributes) # :nodoc:
+    def initialize(attributes)
       set_instance_variables_from_hash(attributes)
       @report_date = Date.parse(report_date)
     end

data/lib/braintree/ach_mandate.rb

@@ -1,6 +1,6 @@
 module Braintree
   class AchMandate
-    include BaseModule # :nodoc:
+    include BaseModule
 
     attr_reader :accepted_at
     attr_reader :text

data/lib/braintree/add_on_gateway.rb

@@ -1,5 +1,5 @@
 module Braintree
-  class AddOnGateway # :nodoc
+  class AddOnGateway
     def initialize(gateway)
       @gateway = gateway
       @config = gateway.config

data/lib/braintree/address.rb

@@ -1,6 +1,6 @@
 module Braintree
   class Address
-    include BaseModule # :nodoc:
+    include BaseModule
 
     attr_reader :company
     attr_reader :country_code_alpha2
@@ -44,12 +44,12 @@ module Braintree
       Configuration.gateway.address.update!(*args)
     end
 
-    def initialize(gateway, attributes) # :nodoc:
+    def initialize(gateway, attributes)
       @gateway = gateway
       set_instance_variables_from_hash(attributes)
     end
 
-    def ==(other) # :nodoc:
+    def ==(other)
       return false unless other.is_a?(Address)
       id == other.id && customer_id == other.customer_id
     end
@@ -58,7 +58,7 @@ module Braintree
       protected :new
     end
 
-    def self._new(*args) # :nodoc:
+    def self._new(*args)
       self.new(*args)
     end
   end

data/lib/braintree/address_gateway.rb

@@ -1,5 +1,5 @@
 module Braintree
-  class AddressGateway # :nodoc
+  class AddressGateway
     include BaseModule
 
     def initialize(gateway)
@@ -62,7 +62,7 @@ module Braintree
       return_object_or_raise(:address) { update(*args) }
     end
 
-    def _determine_customer_id(customer_or_customer_id) # :nodoc:
+    def _determine_customer_id(customer_or_customer_id)
       customer_id = customer_or_customer_id.is_a?(Customer) ? customer_or_customer_id.id : customer_or_customer_id
       unless customer_id =~ /\A[\w_-]+\z/
         raise ArgumentError, "customer_id contains invalid characters"
@@ -70,17 +70,17 @@ module Braintree
       customer_id
     end
 
-    def self._create_signature # :nodoc:
+    def self._create_signature
       _shared_signature + [:customer_id]
     end
 
-    def self._shared_signature # :nodoc:
+    def self._shared_signature
       [:company, :country_code_alpha2, :country_code_alpha3, :country_code_numeric,
         :country_name, :extended_address, :first_name, :last_name, :locality, :phone_number,
         :postal_code, :region, :street_address]
     end
 
-    def self._update_signature # :nodoc:
+    def self._update_signature
       _create_signature
     end
   end

data/lib/braintree/advanced_search.rb

@@ -1,6 +1,6 @@
 module Braintree
-  class AdvancedSearch # :nodoc:
-    class SearchNode # :nodoc:
+  class AdvancedSearch
+    class SearchNode
       def self.operators(*operator_names)
         operator_names.each do |operator|
           define_method(operator) do |value|
@@ -14,29 +14,29 @@ module Braintree
       end
     end
 
-    class IsNode < SearchNode # :nodoc:
+    class IsNode < SearchNode
       operators :is
     end
 
-    class EqualityNode < IsNode # :nodoc:
+    class EqualityNode < IsNode
       operators :is_not
     end
 
-    class PartialMatchNode < EqualityNode # :nodoc:
+    class PartialMatchNode < EqualityNode
       operators :ends_with, :starts_with
     end
 
-    class TextNode < PartialMatchNode # :nodoc:
+    class TextNode < PartialMatchNode
       operators :contains
     end
 
-    class KeyValueNode < SearchNode # :nodoc:
+    class KeyValueNode < SearchNode
       def is(value)
         @parent.add_criteria(@node_name, value)
       end
     end
 
-    class MultipleValueNode < SearchNode # :nodoc:
+    class MultipleValueNode < SearchNode
       def in(*values)
         values.flatten!
 
@@ -62,7 +62,7 @@ module Braintree
       end
     end
 
-    class EndsWithNode < SearchNode # :nodoc:
+    class EndsWithNode < SearchNode
       operators :ends_with
     end
 
@@ -76,7 +76,7 @@ module Braintree
       end
     end
 
-    class RangeNode < SearchNode # :nodoc:
+    class RangeNode < SearchNode
       operators :is
 
       def between(min, max)

data/lib/braintree/apple_pay.rb

@@ -1,8 +1,8 @@
 module Braintree
   class ApplePay
-    include BaseModule # :nodoc:
+    include BaseModule
 
-    def initialize(gateway, attributes) # :nodoc:
+    def initialize(gateway, attributes)
       set_instance_variables_from_hash(attributes)
     end
 
@@ -10,7 +10,7 @@ module Braintree
       protected :new
     end
 
-    def self._new(*args) # :nodoc:
+    def self._new(*args)
       self.new(*args)
     end
 

data/lib/braintree/apple_pay_card.rb

@@ -1,6 +1,6 @@
 module Braintree
   class ApplePayCard
-    include BaseModule # :nodoc:
+    include BaseModule
 
     module CardType
       AmEx = "Apple Pay - American Express"
@@ -39,7 +39,7 @@ module Braintree
     attr_reader :token
     attr_reader :updated_at
 
-    def initialize(gateway, attributes) # :nodoc:
+    def initialize(gateway, attributes)
       @gateway = gateway
       set_instance_variables_from_hash(attributes)
       @billing_address = attributes[:billing_address] ? Address._new(@gateway, attributes[:billing_address]) : nil
@@ -58,7 +58,7 @@ module Braintree
       protected :new
     end
 
-    def self._new(*args) # :nodoc:
+    def self._new(*args)
       self.new(*args)
     end
   end

data/lib/braintree/apple_pay_options.rb

@@ -1,10 +1,10 @@
 module Braintree
   class ApplePayOptions
-    include BaseModule # :nodoc:
+    include BaseModule
 
     attr_reader :domains
 
-    def initialize(attributes) # :nodoc:
+    def initialize(attributes)
       set_instance_variables_from_hash(attributes)
     end
 
@@ -12,7 +12,7 @@ module Braintree
       protected :new
     end
 
-    def self._new(*args) # :nodoc:
+    def self._new(*args)
       self.new(*args)
     end
   end

data/lib/braintree/authorization_adjustment.rb

@@ -1,5 +1,5 @@
 module Braintree
-  class AuthorizationAdjustment # :nodoc:
+  class AuthorizationAdjustment
     include BaseModule
 
     attr_reader :amount
@@ -11,12 +11,12 @@ module Braintree
 
     class << self
       protected :new
-      def _new(*args) # :nodoc:
+      def _new(*args)
         self.new(*args)
       end
     end
 
-    def initialize(attributes) # :nodoc:
+    def initialize(attributes)
       set_instance_variables_from_hash(attributes)
     end
   end

data/lib/braintree/base_module.rb

@@ -1,5 +1,5 @@
 module Braintree
-  module BaseModule # :nodoc: all
+  module BaseModule
     module Methods
       def return_object_or_raise(object_to_return)
         result = yield

data/lib/braintree/bin_data.rb

@@ -1,5 +1,5 @@
 module Braintree
-  class BinData # :nodoc:
+  class BinData
     include BaseModule
 
     attr_reader :commercial
@@ -23,7 +23,7 @@ module Braintree
       "#<#{self.class} #{formatted_attributes.join(", ")}>"
     end
 
-    def self._attributes # :nodoc:
+    def self._attributes
       [
         :commercial, :country_of_issuance, :debit, :durbin_regulated, :healthcare,
         :issuing_bank, :payroll, :prepaid, :product_id

data/lib/braintree/client_token_gateway.rb

@@ -25,7 +25,7 @@ module Braintree
       end
     end
 
-    def self._generate_signature # :nodoc:
+    def self._generate_signature
       [
         :address_id, :customer_id, :proxy_merchant_id, :merchant_account_id,
         :version,

data/lib/braintree/configuration.rb

@@ -1,8 +1,9 @@
 module Braintree
   class Configuration
-    API_VERSION = "6" # :nodoc:
-    DEFAULT_ENDPOINT = "api" # :nodoc:
-    GRAPHQL_API_VERSION = "2018-09-10" # :nodoc:
+    API_VERSION = "6"
+    DEFAULT_ENDPOINT = "api"
+    # NEXT_MAJOR_VERSION update to the latest version of GraphQL API
+    GRAPHQL_API_VERSION = "2018-09-10"
 
     READABLE_ATTRIBUTES = [
       :merchant_id,
@@ -47,18 +48,17 @@ module Braintree
     attr_reader(*NON_REQUIRED_READABLE_ATTRIBUTES)
     attr_writer(*WRITABLE_ATTRIBUTES)
 
-    def self.expectant_reader(*attributes) # :nodoc:
+    def self.expectant_reader(*attributes)
       attributes.each do |attribute|
         (class << self; self; end).send(:define_method, attribute) do
           attribute_value = instance_variable_get("@#{attribute}")
-          raise ConfigurationError.new("Braintree::Configuration.#{attribute.to_s} needs to be set") if attribute_value.nil? || attribute_value.to_s.empty?
+          raise ConfigurationError.new("Braintree::Configuration.#{attribute} needs to be set") if attribute_value.nil? || attribute_value.to_s.empty?
           attribute_value
         end
       end
     end
     expectant_reader(*READABLE_ATTRIBUTES)
 
-    # Sets the Braintree environment to use. Valid values are <tt>:sandbox</tt> and <tt>:production</tt>
     def self.environment=(env)
       env = env.to_sym
       unless [:development, :qa, :sandbox, :production].include?(env)
@@ -67,11 +67,11 @@ module Braintree
       @environment = env
     end
 
-    def self.gateway # :nodoc:
+    def self.gateway
       Braintree::Gateway.new(instantiate)
     end
 
-    def self.instantiate # :nodoc:
+    def self.instantiate
       config = new(
         :custom_user_agent => @custom_user_agent,
         :endpoint => @endpoint,
@@ -158,15 +158,15 @@ module Braintree
       end
     end
 
-    def api_version # :nodoc:
+    def api_version
       API_VERSION
     end
 
-    def graphql_api_version # :nodoc:
+    def graphql_api_version
       GRAPHQL_API_VERSION
     end
 
-    def base_merchant_path # :nodoc:
+    def base_merchant_path
       "/merchants/#{merchant_id}"
     end
 
@@ -178,11 +178,11 @@ module Braintree
       "#{protocol}://#{graphql_server}:#{graphql_port}/graphql"
     end
 
-    def base_merchant_url # :nodoc:
+    def base_merchant_url
       "#{base_url}#{base_merchant_path}"
     end
 
-    def ca_file # :nodoc:
+    def ca_file
       File.expand_path(File.join(File.dirname(__FILE__), "..", "ssl", "api_braintreegateway_com.ca.crt"))
     end
 
@@ -190,7 +190,7 @@ module Braintree
       @endpoint || DEFAULT_ENDPOINT
     end
 
-    def http # :nodoc:
+    def http
       Http.new(self)
     end
 
@@ -202,7 +202,7 @@ module Braintree
       @logger ||= self.class._default_logger
     end
 
-    def port # :nodoc:
+    def port
       case @environment
       when :development, :integration
         ENV["GATEWAY_PORT"] || 3000
@@ -211,7 +211,7 @@ module Braintree
       end
     end
 
-    def graphql_port # :nodoc:
+    def graphql_port
       case @environment
       when :development, :integration
         ENV["GRAPHQL_PORT"] || 8080
@@ -220,7 +220,7 @@ module Braintree
       end
     end
 
-    def protocol # :nodoc:
+    def protocol
       ssl? ? "https" : "http"
     end
 
@@ -232,7 +232,7 @@ module Braintree
       @http_read_timeout
     end
 
-    def server # :nodoc:
+    def server
       case @environment
       when :development, :integration
         ENV["GATEWAY_HOST"] || "localhost"
@@ -245,7 +245,7 @@ module Braintree
       end
     end
 
-    def graphql_server # :nodoc:
+    def graphql_server
       case @environment
       when :development, :integration
         ENV["GRAPHQL_HOST"] || "graphql.bt.local"
@@ -271,7 +271,7 @@ module Braintree
       end
     end
 
-    def ssl? # :nodoc:
+    def ssl?
       case @environment
       when :development, :integration
         false
@@ -280,12 +280,12 @@ module Braintree
       end
     end
 
-    def user_agent # :nodoc:
+    def user_agent
       base_user_agent = "Braintree Ruby Gem #{Braintree::Version::String}"
       @custom_user_agent ? "#{base_user_agent} (#{@custom_user_agent})" : base_user_agent
     end
 
-    def self._default_logger # :nodoc:
+    def self._default_logger
       logger = Logger.new(STDOUT)
       logger.level = Logger::INFO
       logger

data/lib/braintree/connected_merchant_paypal_status_changed.rb

@@ -14,7 +14,7 @@ module Braintree
 
     class << self
       protected :new
-      def _new(*args) # :nodoc:
+      def _new(*args)
         self.new(*args)
       end
     end

data/lib/braintree/connected_merchant_status_transitioned.rb

@@ -14,7 +14,7 @@ module Braintree
 
     class << self
       protected :new
-      def _new(*args) # :nodoc:
+      def _new(*args)
         self.new(*args)
       end
     end

data/lib/braintree/credit_card.rb

@@ -1,6 +1,6 @@
 module Braintree
   class CreditCard
-    include BaseModule # :nodoc:
+    include BaseModule
     include Braintree::Util::TokenEquality
 
     module CardType
@@ -23,6 +23,17 @@ module Braintree
       All = constants.map { |c| const_get(c) }
     end
 
+    module DebitNetwork
+      Accel = "ACCEL"
+      Maestro = "MAESTRO"
+      Nyce = "NYCE"
+      Pulse = "PULSE"
+      Star = "STAR"
+      Star_Access = "STAR_ACCESS"
+
+      All = constants.map { |c| const_get(c) }
+    end
+
     module CustomerLocation
       International = "international"
       US = "us"
@@ -114,7 +125,7 @@ module Braintree
       Configuration.gateway.credit_card.update!(*args)
     end
 
-    def initialize(gateway, attributes) # :nodoc:
+    def initialize(gateway, attributes)
       @gateway = gateway
       set_instance_variables_from_hash(attributes)
       @billing_address = attributes[:billing_address] ? Address._new(@gateway, attributes[:billing_address]) : nil
@@ -123,11 +134,10 @@ module Braintree
     end
 
     def _most_recent_verification(attributes)
-      verification = (attributes[:verifications] || []).sort_by { |verification| verification[:created_at] }.reverse.first
-      CreditCardVerification._new(verification) if verification
+      sorted_verifications = (attributes[:verifications] || []).sort_by { |verification| verification[:created_at] }.reverse.first
+      CreditCardVerification._new(sorted_verifications) if sorted_verifications
     end
 
-    # Returns true if this credit card is the customer's default payment method.
     def default?
       @default
     end
@@ -137,12 +147,11 @@ module Braintree
       "#{expiration_month}/#{expiration_year}"
     end
 
-    # Returns true if the credit card is expired.
     def expired?
       @expired
     end
 
-    def inspect # :nodoc:
+    def inspect
       first = [:token]
       order = first + (self.class._attributes - first)
       nice_attributes = order.map do |attr|
@@ -159,8 +168,12 @@ module Braintree
       @nonce ||= PaymentMethodNonce.create(token)
     end
 
+    # NEXT_MAJOR_VERSION can this be removed? Venmo SDK integration is no more
     # Returns true if the card is associated with Venmo SDK
+    # NEXT_MAJOR_VERSION Remove this method
+    # The old venmo SDK class has been deprecated
     def venmo_sdk?
+      warn "[DEPRECATED] The Venmo SDK integration is Unsupported. Please update your integration to use Pay with Venmo instead."
       @venmo_sdk
     end
 
@@ -172,7 +185,7 @@ module Braintree
       protected :new
     end
 
-    def self._attributes # :nodoc:
+    def self._attributes
       [
         :billing_address, :bin, :card_type, :cardholder_name, :created_at, :customer_id, :expiration_month,
         :expiration_year, :last_4, :token, :updated_at, :prepaid, :payroll, :product_id, :commercial, :debit, :durbin_regulated,
@@ -180,7 +193,7 @@ module Braintree
       ]
     end
 
-    def self._new(*args) # :nodoc:
+    def self._new(*args)
       self.new(*args)
     end
   end

data/lib/braintree/credit_card_gateway.rb

@@ -1,5 +1,5 @@
 module Braintree
-  class CreditCardGateway # :nodoc:
+  class CreditCardGateway
     include BaseModule
 
     def initialize(gateway)
@@ -12,6 +12,10 @@ module Braintree
       if attributes.has_key?(:expiration_date) && (attributes.has_key?(:expiration_month) || attributes.has_key?(:expiration_year))
         raise ArgumentError.new("create with both expiration_month and expiration_year or only expiration_date")
       end
+      # NEXT_MAJOR_VERSION remove this check
+      if attributes.has_key?(:venmo_sdk_payment_method_code) || attributes.has_key?(:venmo_sdk_session)
+        warn "[DEPRECATED] The Venmo SDK integration is Unsupported. Please update your integration to use Pay with Venmo instead."
+      end
       Util.verify_keys(CreditCardGateway._create_signature, attributes)
       _do_create("/payment_methods", :credit_card => attributes)
     end
@@ -61,6 +65,10 @@ module Braintree
     end
 
     def update(token, attributes)
+      # NEXT_MAJOR_VERSION remove this check
+      if attributes.has_key?(:venmo_sdk_payment_method_code) || attributes.has_key?(:venmo_sdk_session)
+        warn "[DEPRECATED] The Venmo SDK integration is Unsupported. Please update your integration to use Pay with Venmo instead."
+      end
       Util.verify_keys(CreditCardGateway._update_signature, attributes)
       _do_update(:put, "/payment_methods/credit_card/#{token}", :credit_card => attributes)
     end
@@ -69,31 +77,35 @@ module Braintree
       return_object_or_raise(:credit_card) { update(*args) }
     end
 
-    def self._create_signature # :nodoc:
+    def self._create_signature
       _signature(:create)
     end
 
-    def self._update_signature # :nodoc:
+    def self._update_signature
       _signature(:update)
     end
 
-    def self._signature(type) # :nodoc:
+    def self._signature(type)
       billing_address_params = AddressGateway._shared_signature
+      # NEXT_MAJOR_VERSION Remove venmo_sdk_session
+      # The old venmo SDK class has been deprecated
       options = [
         :fail_on_duplicate_payment_method,
         :make_default,
         :skip_advanced_fraud_checking,
-        :venmo_sdk_session,
+        :venmo_sdk_session, # Deprecated
         :verification_account_type,
         :verification_amount,
         :verification_currency_iso_code,
         :verification_merchant_account_id,
         :verify_card
       ]
+      # NEXT_MAJOR_VERSION Remove venmo_sdk_payment_method_code
+      # The old venmo SDK class has been deprecated
       signature = [
         :billing_address_id, :cardholder_name, :cvv, :expiration_date, :expiration_month,
-        :expiration_year, :number, :token, :venmo_sdk_payment_method_code, :device_data,
-        :payment_method_nonce,
+        :expiration_year, :number, :token, :venmo_sdk_payment_method_code, # Deprecated
+        :device_data, :payment_method_nonce,
         {:external_vault => [:network_transaction_id]},
         {:options => options},
         {:billing_address => billing_address_params}
@@ -124,7 +136,7 @@ module Braintree
       return signature
     end
 
-    def _do_create(path, params=nil) # :nodoc:
+    def _do_create(path, params=nil)
       response = @config.http.post("#{@config.base_merchant_path}#{path}", params)
       if response[:credit_card]
         SuccessfulResult.new(:credit_card => CreditCard._new(@gateway, response[:credit_card]))
@@ -135,7 +147,7 @@ module Braintree
       end
     end
 
-    def _do_update(http_verb, path, params) # :nodoc:
+    def _do_update(http_verb, path, params)
       response = @config.http.send(http_verb, "#{@config.base_merchant_path}#{path}", params)
       if response[:credit_card]
         SuccessfulResult.new(:credit_card => CreditCard._new(@gateway, response[:credit_card]))
@@ -146,13 +158,13 @@ module Braintree
       end
     end
 
-    def _fetch_expired(ids) # :nodoc:
+    def _fetch_expired(ids)
       response = @config.http.post("#{@config.base_merchant_path}/payment_methods/all/expired", :search => {:ids => ids})
       attributes = response[:payment_methods]
       Util.extract_attribute_as_array(attributes, :credit_card).map { |attrs| CreditCard._new(@gateway, attrs) }
     end
 
-    def _fetch_expiring_between(formatted_start_date, formatted_end_date, ids) # :nodoc:
+    def _fetch_expiring_between(formatted_start_date, formatted_end_date, ids)
       response = @config.http.post(
         "#{@config.base_merchant_path}/payment_methods/all/expiring?start=#{formatted_start_date}&end=#{formatted_end_date}",
         :search => {:ids => ids},