braintree 2.104.1 → 3.4.0

data/spec/unit/braintree/credit_card_verification_search_spec.rb

@@ -9,7 +9,7 @@ module Braintree
 
         lambda do
           search.credit_card_card_type.in(
-            *Braintree::CreditCard::CardType::All
+            *Braintree::CreditCard::CardType::All,
           )
         end.should_not raise_error
       end

data/spec/unit/braintree/credit_card_verification_spec.rb

@@ -30,7 +30,7 @@ describe Braintree::CreditCardVerification do
         :cvv_response_code => "I",
         :processor_response_code => "2000",
         :processor_response_text => "Do Not Honor",
-        :merchant_account_id => "some_id"
+        :merchant_account_id => "some_id",
       )
 
       verification.status.should == Braintree::CreditCardVerification::Status::Verified
@@ -44,7 +44,7 @@ describe Braintree::CreditCardVerification do
 
   it "accepts network_transaction_id" do
     verification = Braintree::CreditCardVerification._new(
-      :network_transaction_id => "123456789012345"
+      :network_transaction_id => "123456789012345",
     )
     expect(verification.network_transaction_id).to eq "123456789012345"
   end
@@ -117,14 +117,18 @@ describe Braintree::CreditCardVerification do
       verification = Braintree::CreditCardVerification._new(:risk_data => {
         :id => "123",
         :decision => "WOO YOU WON $1000 dollars",
+        :decision_reasons => ["reason"],
         :device_data_captured => true,
-        :fraud_service_provider => "kount"
+        :fraud_service_provider => "paypal_fraud_protection",
+        :transaction_risk_score => "12",
       })
 
       verification.risk_data.id.should == "123"
       verification.risk_data.decision.should == "WOO YOU WON $1000 dollars"
+      verification.risk_data.decision_reasons.should == ["reason"]
       verification.risk_data.device_data_captured.should == true
-      verification.risk_data.fraud_service_provider.should == "kount"
+      verification.risk_data.fraud_service_provider.should == "paypal_fraud_protection"
+      verification.risk_data.transaction_risk_score.should == "12"
     end
 
     it "handles a nil risk_data" do

data/spec/unit/braintree/customer_spec.rb

@@ -3,7 +3,7 @@ require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
 describe Braintree::Customer do
   describe "inspect" do
     it "includes the id first" do
-      output = Braintree::Customer._new(:gateway, {:first_name => 'Dan', :id => '1234'}).inspect
+      output = Braintree::Customer._new(:gateway, {:first_name => "Dan", :id => "1234"}).inspect
       output.should include("#<Braintree::Customer id: \"1234\",")
     end
 
@@ -18,7 +18,7 @@ describe Braintree::Customer do
         :phone => "802-483-5932",
         :website => "patrick.smith.com",
         :created_at => Time.now,
-        :updated_at => Time.now
+        :updated_at => Time.now,
       )
       output = customer.inspect
       output.should include(%q(company: "Company"))
@@ -91,7 +91,6 @@ describe Braintree::Customer do
           :billing_address_id,
           :cardholder_name,
           :cvv,
-          :device_session_id,
           :expiration_date,
           :expiration_month,
           :expiration_year,
@@ -99,10 +98,9 @@ describe Braintree::Customer do
           :token,
           :venmo_sdk_payment_method_code,
           :device_data,
-          :fraud_merchant_id,
           :payment_method_nonce,
           {:external_vault=>[:network_transaction_id]},
-          {:options => [:make_default, :verification_merchant_account_id, :verify_card, :verification_amount, :venmo_sdk_session, :fail_on_duplicate_payment_method, :verification_account_type]},
+          {:options => [:make_default, :verification_merchant_account_id, :verify_card, :verification_amount, :venmo_sdk_session, :fail_on_duplicate_payment_method, :verification_account_type, :verification_currency_iso_code]},
           {:billing_address => [
             :company,
             :country_code_alpha2,
@@ -182,7 +180,6 @@ describe Braintree::Customer do
           :billing_address_id,
           :cardholder_name,
           :cvv,
-          :device_session_id,
           :expiration_date,
           :expiration_month,
           :expiration_year,
@@ -190,7 +187,6 @@ describe Braintree::Customer do
           :token,
           :venmo_sdk_payment_method_code,
           :device_data,
-          :fraud_merchant_id,
           :payment_method_nonce,
           {:external_vault=>[:network_transaction_id]},
           {:options => [
@@ -201,6 +197,7 @@ describe Braintree::Customer do
             :venmo_sdk_session,
             :fail_on_duplicate_payment_method,
             :verification_account_type,
+            :verification_currency_iso_code,
             :update_existing_token
           ]},
           {:billing_address => [
@@ -259,14 +256,6 @@ describe Braintree::Customer do
     end
   end
 
-  describe "self.create_from_transparent_redirect" do
-    it "raises an exception if the query string is forged" do
-      expect do
-        Braintree::Customer.create_from_transparent_redirect("http_status=200&forged=query_string")
-      end.to raise_error(Braintree::ForgedQueryString)
-    end
-  end
-
   describe "==" do
     it "returns true when given a customer with the same id" do
       first = Braintree::Customer._new(:gateway, :id => 123)
@@ -301,7 +290,7 @@ describe Braintree::Customer do
         :paypal_accounts => [
           {:token => "paypal_1"},
           {:token => "paypal_2"}
-        ]
+        ],
       )
 
       customer.credit_cards.size.should == 2

data/spec/unit/braintree/disbursement_spec.rb

@@ -28,18 +28,18 @@ describe Braintree::Disbursement do
         :exception_message => "invalid_account_number",
         :follow_up_action => "update",
         :retry => false,
-        :success => false
+        :success => false,
       )
 
       disbursement.inspect.should include('id: "123456"')
       disbursement.inspect.should include('amount: "100.0"')
       disbursement.inspect.should include('exception_message: "invalid_account_number"')
-      disbursement.inspect.should include('disbursement_date: 2013-04-10')
+      disbursement.inspect.should include("disbursement_date: 2013-04-10")
       disbursement.inspect.should include('follow_up_action: "update"')
-      disbursement.inspect.should include('merchant_account: #<Braintree::MerchantAccount: ')
+      disbursement.inspect.should include("merchant_account: #<Braintree::MerchantAccount: ")
       disbursement.inspect.should include('transaction_ids: ["sub_merchant_transaction"]')
-      disbursement.inspect.should include('retry: false')
-      disbursement.inspect.should include('success: false')
+      disbursement.inspect.should include("retry: false")
+      disbursement.inspect.should include("success: false")
     end
   end
 
@@ -56,7 +56,7 @@ describe Braintree::Disbursement do
           :status => "active"
         },
         :success => false,
-        :disbursement_date => "2013-04-10"
+        :disbursement_date => "2013-04-10",
       )
       disbursement.success?.should == false
 
@@ -71,7 +71,7 @@ describe Braintree::Disbursement do
           :status => "active"
         },
         :success => true,
-        :disbursement_date => "2013-04-10"
+        :disbursement_date => "2013-04-10",
       )
       disbursement.success?.should == true
     end

data/spec/unit/braintree/dispute_spec.rb

@@ -137,13 +137,13 @@ describe Braintree::Dispute do
       it "does not raise an exception if the optional parameters are valid" do
         Braintree::Http.stub(:new).and_return double.as_null_object
         expect do
-          Braintree::Dispute.add_file_evidence("dispute_id", { category: "GENERAL", document_id: "document_id" })
+          Braintree::Dispute.add_file_evidence("dispute_id", {category: "GENERAL", document_id: "document_id"})
         end.to_not raise_error
       end
 
       it "raises an exception if the optional params contain invalid keys" do
         expect do
-          Braintree::Dispute.add_file_evidence("dispute_id", { random_param: "" })
+          Braintree::Dispute.add_file_evidence("dispute_id", {random_param: ""})
         end.to raise_error(ArgumentError)
       end
 
@@ -151,7 +151,7 @@ describe Braintree::Dispute do
         Braintree::Http.stub(:new).and_return double.as_null_object
 
         expect do
-          Braintree::Dispute.add_file_evidence("dispute_id", { category: 3, document_id: "document_id" })
+          Braintree::Dispute.add_file_evidence("dispute_id", {category: 3, document_id: "document_id"})
         end.to raise_error(ArgumentError)
       end
     end
@@ -200,38 +200,31 @@ describe Braintree::Dispute do
       it "does not raise an exception if the optional parameters are valid" do
         Braintree::Http.stub(:new).and_return double.as_null_object
         expect do
-          Braintree::Dispute.add_text_evidence("dispute_id", { content: "a", tag: "", sequence_number: 3 })
-        end.to_not raise_error
-      end
-
-      it "does not raise an exception if the category parameter is provided" do
-        Braintree::Http.stub(:new).and_return double.as_null_object
-        expect do
-          Braintree::Dispute.add_text_evidence("dispute_id", { content: "a", category: "", sequence_number: 3 })
+          Braintree::Dispute.add_text_evidence("dispute_id", {content: "a", category: "", sequence_number: 3})
         end.to_not raise_error
       end
 
       it "raises an exception if the optional params contain invalid keys" do
         expect do
-          Braintree::Dispute.add_text_evidence("dispute_id", { random_param: "" })
+          Braintree::Dispute.add_text_evidence("dispute_id", {random_param: ""})
         end.to raise_error(ArgumentError)
       end
 
       it "raises an exception if sequence_number is provided and not an integer" do
         expect do
-          Braintree::Dispute.add_text_evidence("dispute_id", { sequence_number: "abc" })
+          Braintree::Dispute.add_text_evidence("dispute_id", {sequence_number: "abc"})
         end.to raise_error(ArgumentError)
       end
 
       it "raises an exception if the param tag is not a string" do
         expect do
-          Braintree::Dispute.add_text_evidence("dispute_id", { tag: 3 })
+          Braintree::Dispute.add_text_evidence("dispute_id", {tag: 3})
         end.to raise_error(ArgumentError)
       end
 
       it "raises an exception if the param category is not a string" do
         expect do
-          Braintree::Dispute.add_text_evidence("dispute_id", { category: 3 })
+          Braintree::Dispute.add_text_evidence("dispute_id", {category: 3})
         end.to raise_error(ArgumentError)
       end
     end
@@ -327,7 +320,7 @@ describe Braintree::Dispute do
       dispute.transaction.payment_instrument_subtype.should == "Visa"
     end
 
-    it "converts status_history hash into an array of Dispute::HistoryEvent objects" do
+    it "converts status_history hash into an array of Dispute::StatusHistory objects" do
       dispute = Braintree::Dispute._new(attributes)
 
       dispute.status_history.length.should == 1
@@ -398,10 +391,6 @@ describe Braintree::Dispute do
   describe "comments" do
     let(:dispute) { Braintree::Dispute._new(attributes) }
 
-    it "#forwarded_comments returns `processor_comments`" do
-      expect(dispute.forwarded_comments).to eq(dispute.processor_comments)
-    end
-
     it "#processor_comments" do
       expect(dispute.processor_comments).to eq(attributes[:processor_comments])
     end

data/spec/unit/braintree/error_result_spec.rb

@@ -10,7 +10,7 @@ describe Braintree::ErrorResult do
           :params => "params",
           :errors => {:errors => []},
           :extra => "is ignored",
-          :message => "foo bar"
+          :message => "foo bar",
         )
       end.to_not raise_error
     end
@@ -36,7 +36,7 @@ describe Braintree::ErrorResult do
         :params => "params",
         :errors => {},
         :verification => {},
-        :transaction => nil
+        :transaction => nil,
       )
       result.inspect.should include("credit_card_verification: #<Braintree::CreditCardVerification status: ")
     end
@@ -47,7 +47,7 @@ describe Braintree::ErrorResult do
         :params => "params",
         :errors => {},
         :verification => nil,
-        :transaction => nil
+        :transaction => nil,
       )
       result.inspect.should_not include("credit_card_verification")
     end
@@ -58,7 +58,7 @@ describe Braintree::ErrorResult do
         :params => "params",
         :errors => {},
         :verification => nil,
-        :transaction => {}
+        :transaction => {},
       )
       result.inspect.should include("transaction: #<Braintree::Transaction id: ")
     end
@@ -69,7 +69,7 @@ describe Braintree::ErrorResult do
         :params => "params",
         :errors => {},
         :verification => nil,
-        :transaction => nil
+        :transaction => nil,
       )
       result.inspect.should_not include("transaction")
     end

data/spec/unit/braintree/errors_spec.rb

@@ -4,7 +4,7 @@ describe Braintree::Errors do
   describe "for" do
     it "accesses errors for the given scope" do
       errors = Braintree::Errors.new(
-        :level1 => {:errors => [{:code => "code1", :attribute => "attr", :message => "message"}]}
+        :level1 => {:errors => [{:code => "code1", :attribute => "attr", :message => "message"}]},
       )
       errors.for(:level1).size.should == 1
       errors.for(:level1)[0].code.should == "code1"
@@ -12,7 +12,7 @@ describe Braintree::Errors do
 
     it "returns nil if there are no errors at the given scope" do
       errors = Braintree::Errors.new(
-        :level1 => {:errors => [{:code => "code1", :attribute => "attr", :message => "message"}]}
+        :level1 => {:errors => [{:code => "code1", :attribute => "attr", :message => "message"}]},
       )
       errors.for(:no_errors_here).should == nil
     end
@@ -21,7 +21,7 @@ describe Braintree::Errors do
   describe "inspect" do
     it "is better than the default inspect" do
       errors = Braintree::Errors.new(
-        :level1 => {:errors => [{:code => "code1", :attribute => "attr", :message => "message"}]}
+        :level1 => {:errors => [{:code => "code1", :attribute => "attr", :message => "message"}]},
       )
       errors.inspect.should == "#<Braintree::Errors level1:[(code1) message]>"
     end
@@ -33,7 +33,7 @@ describe Braintree::Errors do
           :level2 => {
             :errors => [{:code => "code2", :attribute => "attr2", :message => "message2"}],
           }
-        }
+        },
       )
       errors.inspect.should == "#<Braintree::Errors level1:[(code1) message], level1/level2:[(code2) message2]>"
     end
@@ -48,7 +48,7 @@ describe Braintree::Errors do
               :errors => [{:code => "code3", :attribute => "attr3", :message => "message3"}],
             }
           }
-        }
+        },
       )
       errors.inspect.should == "#<Braintree::Errors level1:[(code1) message], level1/level2:[(code2) message2], level1/level2/level3:[(code3) message3]>"
     end
@@ -65,7 +65,7 @@ describe Braintree::Errors do
               {:code => "3", :attribute => "attr3", :message => "message3"}
             ],
           }
-        }
+        },
       )
       errors.map { |e| e.code }.sort.should == %w[1 2 3]
     end
@@ -74,7 +74,7 @@ describe Braintree::Errors do
   describe "size" do
     it "returns the number of validation errors at the first level if only has one level" do
       errors = Braintree::Errors.new(
-        :level1 => {:errors => [{:code => "1", :attribute => "attr", :message => "message"}]}
+        :level1 => {:errors => [{:code => "1", :attribute => "attr", :message => "message"}]},
       )
       errors.size.should == 1
     end
@@ -89,7 +89,7 @@ describe Braintree::Errors do
               {:code => "3", :attribute => "attr3", :message => "message3"}
             ],
           }
-        }
+        },
       )
       errors.size.should == 3
     end

data/spec/unit/braintree/http_spec.rb

@@ -67,7 +67,7 @@ END
         :proxy_address => "localhost",
         :proxy_port => 8080,
         :proxy_user => "user",
-        :proxy_pass => "test"
+        :proxy_pass => "test",
       )
 
       http = Braintree::Http.new(config)
@@ -75,7 +75,7 @@ END
         "Net::HTTP",
         :open_timeout= => nil,
         :read_timeout= => nil,
-        :start => nil
+        :start => nil,
       )
 
       Net::HTTP.should_receive(:new).with(nil, nil, "localhost", 8080, "user", "test").and_return(net_http_instance)
@@ -86,7 +86,7 @@ END
     it "accepts a partially specified proxy" do
       config = Braintree::Configuration.new(
         :proxy_address => "localhost",
-        :proxy_port => 8080
+        :proxy_port => 8080,
       )
 
       http = Braintree::Http.new(config)
@@ -94,7 +94,7 @@ END
         "Net::HTTP",
         :open_timeout= => nil,
         :read_timeout= => nil,
-        :start => nil
+        :start => nil,
       )
 
       Net::HTTP.should_receive(:new).with(nil, nil, "localhost", 8080, nil, nil).and_return(net_http_instance)
@@ -109,7 +109,7 @@ END
         "Net::HTTP",
         :open_timeout= => nil,
         :read_timeout= => nil,
-        :start => nil
+        :start => nil,
       )
 
       Net::HTTP.should_receive(:new).with(nil, nil).and_return(net_http_instance)
@@ -130,7 +130,7 @@ END
       expect(default_headers["Accept-Encoding"]).to eq("gzip")
       expect(default_headers["Content-Type"]).to eq("application/xml")
       expect(default_headers["User-Agent"]).to match(/Braintree Ruby Gem .*/)
-      expect(default_headers["X-ApiVersion"]).to eq("5")
+      expect(default_headers["X-ApiVersion"]).to eq("6")
     end
 
     it "overwrites defaults with override headers" do
@@ -144,7 +144,7 @@ END
       expect(headers["Authorization"]).to eq("token")
       expect(headers["Content-Type"]).to eq("application/xml")
       expect(headers["User-Agent"]).to match(/Braintree Ruby Gem .*/)
-      expect(headers["X-ApiVersion"]).to eq("5")
+      expect(headers["X-ApiVersion"]).to eq("6")
     end
 
     it "extends default headers when new headers are specified" do
@@ -156,7 +156,7 @@ END
       expect(headers["Accept-Encoding"]).to eq("gzip")
       expect(headers["Content-Type"]).to eq("application/xml")
       expect(headers["User-Agent"]).to match(/Braintree Ruby Gem .*/)
-      expect(headers["X-ApiVersion"]).to eq("5")
+      expect(headers["X-ApiVersion"]).to eq("6")
       expect(headers["New-Header"]).to eq("New Value")
     end
   end

data/spec/unit/braintree/merchant_account_spec.rb

@@ -13,7 +13,7 @@ describe Braintree::MerchantAccount do
         nil,
         :id => "merchant_account",
         :status => "active",
-        :master_merchant_account => {:id => "master_merchant_account", :status => "active", :master_merchant_account => nil}
+        :master_merchant_account => {:id => "master_merchant_account", :status => "active", :master_merchant_account => nil},
       )
 
       master_merchant_account = "#<Braintree::MerchantAccount: id: \"master_merchant_account\", status: \"active\", master_merchant_account: nil>"