braintree 2.104.1 → 3.4.0

data/spec/oauth_test_helper.rb

@@ -10,7 +10,7 @@ module Braintree
     def self.create_token(gateway, params)
       code = create_grant(gateway, params)
       gateway.oauth.create_token_from_code(
-        :code => code
+        :code => code,
       )
     end
   end

data/spec/script/httpsd.rb

@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
-require 'webrick'
-require 'webrick/https'
-require 'openssl'
+require "webrick"
+require "webrick/https"
+require "openssl"
 
 private_key_file = File.expand_path(File.join(File.dirname(__FILE__), "..", "ssl", "privateKey.key"))
 cert_file = File.expand_path(File.join(File.dirname(__FILE__), "..", "ssl", "certificate.crt"))
@@ -12,7 +12,7 @@ cert = OpenSSL::X509::Certificate.new(File.read(cert_file))
 pid_file = ARGV[0]
 
 s = WEBrick::HTTPServer.new(
-  :Port => (ENV['SSL_TEST_PORT'] || 8444),
+  :Port => (ENV["SSL_TEST_PORT"] || 8444),
   :Logger => WEBrick::Log::new(nil, WEBrick::Log::ERROR),
   :DocumentRoot => File.join(File.dirname(__FILE__)),
   :ServerType => WEBrick::Daemon,
@@ -21,7 +21,7 @@ s = WEBrick::HTTPServer.new(
   :SSLCertificate => cert,
   :SSLPrivateKey => pkey,
   :SSLCertName => [ [ "CN",WEBrick::Utils::getservername ] ],
-  :StartCallback => proc { File.open(pid_file, "w") { |f| f.write $$.to_s }}
+  :StartCallback => proc { File.open(pid_file, "w") { |f| f.write $$.to_s } },
 )
-trap("INT"){ s.shutdown }
+trap("INT") { s.shutdown }
 s.start

data/spec/spec_helper.rb

@@ -4,7 +4,6 @@ unless defined?(SPEC_HELPER_LOADED)
   require "rubygems"
   require "bundler/setup"
   require "rspec"
-  require "libxml"
   require "pry"
 
   braintree_lib = "#{project_root}/lib"
@@ -28,10 +27,6 @@ unless defined?(SPEC_HELPER_LOADED)
     end
   end
 
-  def now_in_eastern
-    (Time.now.utc - 5*60*60).strftime("%Y-%m-%d")
-  end
-
   module SpecHelper
 
     DefaultMerchantAccountId = "sandbox_credit_card"
@@ -44,6 +39,8 @@ unless defined?(SPEC_HELPER_LOADED)
     AnotherUsBankMerchantAccountId = "another_us_bank_merchant_account"
     AdyenMerchantAccountId = "adyen_ma"
     HiperBRLMerchantAccountId = "hiper_brl"
+    CardProcessorBRLMerchantAccountId = "card_processor_brl"
+    FakeFirstDataMerchantAccountId = "fake_first_data_merchant_account"
 
     TrialPlan = {
       :description => "Plan for integration tests -- with trial",
@@ -92,13 +89,13 @@ unless defined?(SPEC_HELPER_LOADED)
                                                       :environment => Braintree::Configuration.environment,
                                                       :merchant_id => "test_merchant_id",
                                                       :public_key => "test_public_key",
-                                                      :private_key => "test_private_key"
+                                                      :private_key => "test_private_key",
                                                       )
 
     def self.make_past_due(subscription, number_of_days_past_due = 1)
       config = Braintree::Configuration.instantiate
       config.http.put(
-        "#{config.base_merchant_path}/subscriptions/#{subscription.id}/make_past_due?days_past_due=#{number_of_days_past_due}"
+        "#{config.base_merchant_path}/subscriptions/#{subscription.id}/make_past_due?days_past_due=#{number_of_days_past_due}",
       )
     end
 
@@ -117,7 +114,7 @@ unless defined?(SPEC_HELPER_LOADED)
       gateway = Braintree::Gateway.new(
         :client_id => "client_id$#{Braintree::Configuration.environment}$integration_client_id",
         :client_secret => "client_secret$#{Braintree::Configuration.environment}$integration_client_secret",
-        :logger => Logger.new("/dev/null")
+        :logger => Logger.new("/dev/null"),
       )
 
       gateway.merchant.create({
@@ -188,16 +185,11 @@ unless defined?(SPEC_HELPER_LOADED)
       end
 
       def matches?(xml_string)
-        @libxml_parse = Braintree::Xml::Parser.hash_from_xml(xml_string, Braintree::Xml::Libxml)
-        @rexml_parse = Braintree::Xml::Parser.hash_from_xml(xml_string, Braintree::Xml::Rexml)
+        @libxml_parse = Braintree::Xml::Parser.hash_from_xml(xml_string)
         if @libxml_parse != @expected_hash
           @results = @libxml_parse
           @failed_parser = "libxml"
           false
-        elsif @rexml_parse != @expected_hash
-          @results = @rexml_parse
-          @failed_parser = "rexml"
-          false
         else
           true
         end

data/spec/unit/braintree/address_spec.rb

@@ -3,7 +3,7 @@ require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
 describe Braintree::Address do
   describe "==" do
     it "returns true if given an address with the same id and customer_id" do
-      first = Braintree::Address._new(:gateway, :customer_id => "c1", :id => 'a1')
+      first = Braintree::Address._new(:gateway, :customer_id => "c1", :id => "a1")
       second = Braintree::Address._new(:gateway, :customer_id => "c1", :id => "a1")
 
       first.should == second
@@ -94,12 +94,4 @@ describe Braintree::Address do
       end.to raise_error(NoMethodError, /protected method .new/)
     end
   end
-
-  describe "update" do
-    it "raises an exception if hash includes an invalid key" do
-      expect do
-        Braintree::Address._new(Braintree::Configuration.gateway, {}).update(:street_address => "456 E Main", :invalid_key2 => "foo")
-      end.to raise_error(ArgumentError, "invalid keys: invalid_key2")
-    end
-  end
 end

data/spec/unit/braintree/apple_pay_card_spec.rb

@@ -3,7 +3,7 @@ require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
 describe Braintree::ApplePayCard do
   describe "bin" do
     it "returns Apple pay card bin" do
-      Braintree::ApplePayCard._new(:gateway, bin: '411111').bin.should == '411111'
+      Braintree::ApplePayCard._new(:gateway, bin: "411111").bin.should == "411111"
     end
   end
 

data/spec/unit/braintree/client_token_spec.rb

@@ -16,7 +16,7 @@ module Braintree
         expect {
           client_token = Braintree::ClientToken.generate(
             :public_key => "bad_key",
-            :created_at => "bad_time"
+            :created_at => "bad_time",
           )
         }.to raise_error(ArgumentError, /created_at, public_key/)
       end
@@ -27,7 +27,7 @@ module Braintree
         it "raises an ArgumentError if #{option_name} is present" do
           expect do
             Braintree::ClientToken.generate(
-              option_name.to_sym => true
+              option_name.to_sym => true,
             )
           end.to raise_error(ArgumentError, /#{option_name}/)
         end

data/spec/unit/braintree/configuration_spec.rb

@@ -1,4 +1,4 @@
-require 'stringio'
+require "stringio"
 
 require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
 
@@ -22,26 +22,26 @@ describe Braintree::Configuration do
   describe "initialize" do
     it "accepts merchant credentials" do
       config = Braintree::Configuration.new(
-        :merchant_id => 'merchant_id',
-        :public_key => 'public_key',
-        :private_key => 'private_key'
+        :merchant_id => "merchant_id",
+        :public_key => "public_key",
+        :private_key => "private_key",
       )
 
-      config.merchant_id.should == 'merchant_id'
-      config.public_key.should == 'public_key'
-      config.private_key.should == 'private_key'
+      config.merchant_id.should == "merchant_id"
+      config.public_key.should == "public_key"
+      config.private_key.should == "private_key"
     end
 
     it "accepts partner credentials" do
       config = Braintree::Configuration.new(
-        :partner_id => 'partner_id',
-        :public_key => 'public_key',
-        :private_key => 'private_key'
+        :partner_id => "partner_id",
+        :public_key => "public_key",
+        :private_key => "private_key",
       )
 
-      config.merchant_id.should == 'partner_id'
-      config.public_key.should == 'public_key'
-      config.private_key.should == 'private_key'
+      config.merchant_id.should == "partner_id"
+      config.public_key.should == "public_key"
+      config.private_key.should == "private_key"
     end
 
     it "raises if combining client_id/secret with access_token" do
@@ -49,7 +49,7 @@ describe Braintree::Configuration do
         Braintree::Configuration.new(
           :client_id => "client_id$development$integration_client_id",
           :client_secret => "client_secret$development$integration_client_secret",
-          :access_token => "access_token$development$integration_merchant_id$fb27c79dd"
+          :access_token => "access_token$development$integration_merchant_id$fb27c79dd",
         )
       end.to raise_error(Braintree::ConfigurationError, /mixed credential types/)
     end
@@ -62,7 +62,7 @@ describe Braintree::Configuration do
           :merchant_id => "merchant_id",
           :public_key => "public_key",
           :private_key => "private_key",
-          :environment => "development"
+          :environment => "development",
         )
       end.to raise_error(Braintree::ConfigurationError, /mixed credential types/)
     end
@@ -96,21 +96,21 @@ describe Braintree::Configuration do
 
     it "accepts proxy params" do
       config = Braintree::Configuration.new(
-        :proxy_address => 'localhost',
+        :proxy_address => "localhost",
         :proxy_port => 8080,
-        :proxy_user => 'user',
-        :proxy_pass => 'test'
+        :proxy_user => "user",
+        :proxy_pass => "test",
       )
 
-      config.proxy_address.should == 'localhost'
+      config.proxy_address.should == "localhost"
       config.proxy_port.should == 8080
-      config.proxy_user.should == 'user'
-      config.proxy_pass.should == 'test'
+      config.proxy_user.should == "user"
+      config.proxy_pass.should == "test"
     end
 
     it "accepts ssl version" do
       config = Braintree::Configuration.new(
-        :ssl_version => :TLSv1_2
+        :ssl_version => :TLSv1_2,
       )
 
       config.ssl_version.should == :TLSv1_2
@@ -146,14 +146,14 @@ describe Braintree::Configuration do
       Braintree::Configuration.environment = :sandbox
       ca_file = Braintree::Configuration.instantiate.ca_file
       ca_file.should match(/api_braintreegateway_com\.ca\.crt$/)
-      File.exists?(ca_file).should == true
+      File.exist?(ca_file).should == true
     end
 
     it "production" do
       Braintree::Configuration.environment = :production
       ca_file = Braintree::Configuration.instantiate.ca_file
       ca_file.should match(/api_braintreegateway_com\.ca\.crt$/)
-      File.exists?(ca_file).should == true
+      File.exist?(ca_file).should == true
     end
   end
 
@@ -238,12 +238,12 @@ describe Braintree::Configuration do
 
     it "allows the environment to be set with a string value" do
       expect do
-        Braintree::Configuration.environment = 'sandbox'
+        Braintree::Configuration.environment = "sandbox"
       end.not_to raise_error
     end
 
     it "sets the environment as a symbol" do
-      Braintree::Configuration.environment = 'sandbox'
+      Braintree::Configuration.environment = "sandbox"
       expect(Braintree::Configuration.environment).to eq :sandbox
     end
   end
@@ -326,15 +326,15 @@ describe Braintree::Configuration do
 
     it "is 3000 or GATEWAY_PORT environment variable for development" do
       Braintree::Configuration.environment = :development
-      old_gateway_port = ENV['GATEWAY_PORT']
+      old_gateway_port = ENV["GATEWAY_PORT"]
       begin
-        ENV['GATEWAY_PORT'] = nil
+        ENV["GATEWAY_PORT"] = nil
         Braintree::Configuration.instantiate.port.should == 3000
 
-        ENV['GATEWAY_PORT'] = '1234'
-        Braintree::Configuration.instantiate.port.should == '1234'
+        ENV["GATEWAY_PORT"] = "1234"
+        Braintree::Configuration.instantiate.port.should == "1234"
       ensure
-        ENV['GATEWAY_PORT'] = old_gateway_port
+        ENV["GATEWAY_PORT"] = old_gateway_port
       end
     end
   end
@@ -359,15 +359,15 @@ describe Braintree::Configuration do
   describe "graphql_server" do
     it "is localhost or GRAPHQL_HOST environment variable for development" do
       Braintree::Configuration.environment = :development
-      old_gateway_url = ENV['GRAPHQL_HOST']
+      old_gateway_url = ENV["GRAPHQL_HOST"]
       begin
-        ENV['GRAPHQL_HOST'] = nil
+        ENV["GRAPHQL_HOST"] = nil
         Braintree::Configuration.instantiate.graphql_server.should == "graphql.bt.local"
 
-        ENV['GRAPHQL_HOST'] = 'gateway'
-        Braintree::Configuration.instantiate.graphql_server.should == 'gateway'
+        ENV["GRAPHQL_HOST"] = "gateway"
+        Braintree::Configuration.instantiate.graphql_server.should == "gateway"
       ensure
-        ENV['GRAPHQL_HOST'] = old_gateway_url
+        ENV["GRAPHQL_HOST"] = old_gateway_url
       end
     end
   end
@@ -375,15 +375,15 @@ describe Braintree::Configuration do
   describe "server" do
     it "is localhost or GATEWAY_HOST environment variable for development" do
       Braintree::Configuration.environment = :development
-      old_gateway_url = ENV['GATEWAY_HOST']
+      old_gateway_url = ENV["GATEWAY_HOST"]
       begin
-        ENV['GATEWAY_HOST'] = nil
+        ENV["GATEWAY_HOST"] = nil
         Braintree::Configuration.instantiate.server.should == "localhost"
 
-        ENV['GATEWAY_HOST'] = 'gateway'
-        Braintree::Configuration.instantiate.server.should == 'gateway'
+        ENV["GATEWAY_HOST"] = "gateway"
+        Braintree::Configuration.instantiate.server.should == "gateway"
       ensure
-        ENV['GATEWAY_HOST'] = old_gateway_url
+        ENV["GATEWAY_HOST"] = old_gateway_url
       end
     end
 
@@ -468,7 +468,7 @@ describe Braintree::Configuration do
     it "masks the private_key" do
       config = Braintree::Configuration.new(:private_key => "secret_key")
       config.inspect.should include('@private_key="[FILTERED]"')
-      config.inspect.should_not include('secret_key')
+      config.inspect.should_not include("secret_key")
     end
   end
 

data/spec/unit/braintree/credit_card_spec.rb

@@ -4,7 +4,7 @@ describe Braintree::CreditCard do
   describe "self.create" do
     it "raises an exception if attributes contain an invalid key" do
       expect do
-        Braintree::CreditCard.create(:invalid_key => 'val')
+        Braintree::CreditCard.create(:invalid_key => "val")
       end.to raise_error(ArgumentError, "invalid keys: invalid_key")
     end
   end
@@ -15,7 +15,6 @@ describe Braintree::CreditCard do
         :billing_address_id,
         :cardholder_name,
         :cvv,
-        :device_session_id,
         :expiration_date,
         :expiration_month,
         :expiration_year,
@@ -23,10 +22,9 @@ describe Braintree::CreditCard do
         :token,
         :venmo_sdk_payment_method_code,
         :device_data,
-        :fraud_merchant_id,
         :payment_method_nonce,
         {:external_vault=>[:network_transaction_id]},
-        {:options => [:make_default, :verification_merchant_account_id, :verify_card, :verification_amount, :venmo_sdk_session, :fail_on_duplicate_payment_method, :verification_account_type]},
+        {:options => [:make_default, :verification_merchant_account_id, :verify_card, :verification_amount, :venmo_sdk_session, :fail_on_duplicate_payment_method, :verification_account_type, :verification_currency_iso_code]},
         {:billing_address => [
           :company,
           :country_code_alpha2,
@@ -63,7 +61,6 @@ describe Braintree::CreditCard do
         :billing_address_id,
         :cardholder_name,
         :cvv,
-        :device_session_id,
         :expiration_date,
         :expiration_month,
         :expiration_year,
@@ -71,10 +68,9 @@ describe Braintree::CreditCard do
         :token,
         :venmo_sdk_payment_method_code,
         :device_data,
-        :fraud_merchant_id,
         :payment_method_nonce,
         {:external_vault=>[:network_transaction_id]},
-        {:options => [:make_default, :verification_merchant_account_id, :verify_card, :verification_amount, :venmo_sdk_session, :fail_on_duplicate_payment_method, :verification_account_type]},
+        {:options => [:make_default, :verification_merchant_account_id, :verify_card, :verification_amount, :venmo_sdk_session, :fail_on_duplicate_payment_method, :verification_account_type, :verification_currency_iso_code]},
         {:billing_address => [
           :company,
           :country_code_alpha2,
@@ -105,21 +101,6 @@ describe Braintree::CreditCard do
     end
   end
 
-  describe "self.create_from_transparent_redirect" do
-    it "raises an exception if the query string is forged" do
-      expect do
-        Braintree::CreditCard.create_from_transparent_redirect("http_status=200&forged=query_string")
-      end.to raise_error(Braintree::ForgedQueryString)
-    end
-  end
-
-  describe "self.create_credit_card_url" do
-    it "returns the url" do
-      config = Braintree::Configuration.instantiate
-      Braintree::CreditCard.create_credit_card_url.should == "http#{config.ssl? ? 's' : ''}://#{config.server}:#{config.port}/merchants/integration_merchant_id/payment_methods/all/create_via_transparent_redirect_request"
-    end
-  end
-
   describe "==" do
     it "returns true if given a credit card with the same token" do
       first = Braintree::CreditCard._new(:gateway, :token => 123)
@@ -222,7 +203,7 @@ describe Braintree::CreditCard do
       credit_card = Braintree::CreditCard._new(
         :gateway,
         :bin => "510510",
-        :last_4 => "5100"
+        :last_4 => "5100",
       )
       credit_card.masked_number.should == "510510******5100"
     end
@@ -234,7 +215,7 @@ describe Braintree::CreditCard do
         :gateway,
         :bin => "510510",
         :last_4 => "5100",
-        :is_network_tokenized => true
+        :is_network_tokenized => true,
       )
       credit_card.is_network_tokenized?.should == true
     end
@@ -244,7 +225,7 @@ describe Braintree::CreditCard do
         :gateway,
         :bin => "510510",
         :last_4 => "5100",
-        :is_network_tokenized => false
+        :is_network_tokenized => false,
       )
       credit_card.is_network_tokenized?.should == false
     end
@@ -253,7 +234,7 @@ describe Braintree::CreditCard do
   describe "self.update" do
     it "raises an exception if attributes contain an invalid key" do
       expect do
-        Braintree::CreditCard._new(Braintree::Configuration.gateway, {}).update(:invalid_key => 'val')
+        Braintree::CreditCard.update(:gateway, :invalid_key => "val")
       end.to raise_error(ArgumentError, "invalid keys: invalid_key")
     end
   end
@@ -269,8 +250,8 @@ describe Braintree::CreditCard do
   describe "self._new" do
     describe "initializing verification" do
       it "picks the youngest verification" do
-        verification1 = { :created_at => Time.now, :id => 123 }
-        verification2 = { :created_at => Time.now - 3600, :id => 456 }
+        verification1 = {:created_at => Time.now, :id => 123}
+        verification2 = {:created_at => Time.now - 3600, :id => 456}
         credit_card = Braintree::CreditCard._new(Braintree::Configuration.gateway, {:verifications => [verification1, verification2]})
         credit_card.verification.id.should == 123
       end