braintree 2.104.1 → 3.4.0

data/spec/integration/braintree/transaction_us_bank_account_spec.rb

@@ -14,7 +14,8 @@ describe Braintree::Transaction do
         let(:plaid_nonce) { generate_valid_plaid_us_bank_account_nonce }
 
         context "nonce" do
-          it "sale succeeds" do
+          # we are temporarily skipping this test until we have a more stable CI env
+          xit "sale succeeds" do
             result = Braintree::Transaction.create(
               :type => "sale",
               :amount => Braintree::Test::TransactionAmounts::Authorize,
@@ -22,7 +23,7 @@ describe Braintree::Transaction do
               :payment_method_nonce => plaid_nonce,
               :options => {
                 :submit_for_settlement => true,
-              }
+              },
             )
             result.success?.should == true
             result.transaction.id.should =~ /^\w{6,}$/
@@ -41,13 +42,14 @@ describe Braintree::Transaction do
         end
 
         context "token" do
-          it "payment_method#create then sale succeeds" do
+          # we are temporarily skipping this test until we have a more stable CI env
+          xit "payment_method#create then sale succeeds" do
             payment_method = Braintree::PaymentMethod.create(
               :payment_method_nonce => plaid_nonce,
               :customer_id => Braintree::Customer.create.customer.id,
               :options => {
                 :verification_merchant_account_id => SpecHelper::AnotherUsBankMerchantAccountId,
-              }
+              },
             ).payment_method
 
             payment_method.verifications.count.should == 1
@@ -64,7 +66,7 @@ describe Braintree::Transaction do
               :payment_method_token => payment_method.token,
               :options => {
                 :submit_for_settlement => true,
-              }
+              },
             )
 
             result.success?.should == true
@@ -84,7 +86,8 @@ describe Braintree::Transaction do
             transaction.us_bank_account_details.ach_mandate.accepted_at.should be_a Time
           end
 
-          it "transaction#create store_in_vault then sale succeeds" do
+          # we are temporarily skipping this test until we have a more stable CI env
+          xit "transaction#create store_in_vault then sale succeeds" do
             result = Braintree::Transaction.create(
               :type => "sale",
               :amount => Braintree::Test::TransactionAmounts::Authorize,
@@ -93,7 +96,7 @@ describe Braintree::Transaction do
               :options => {
                 :submit_for_settlement => true,
                 :store_in_vault => true,
-              }
+              },
             )
 
             result.success?.should == true
@@ -105,7 +108,7 @@ describe Braintree::Transaction do
               :payment_method_token => result.transaction.us_bank_account_details.token,
               :options => {
                 :submit_for_settlement => true,
-              }
+              },
             )
 
             result.success?.should == true
@@ -140,7 +143,7 @@ describe Braintree::Transaction do
               :payment_method_nonce => non_plaid_nonce,
               :options => {
                 :submit_for_settlement => true,
-              }
+              },
             )
             result.success?.should == false
             result.errors.for(:transaction).on(:payment_method_nonce)[0].code.should == Braintree::ErrorCodes::Transaction::UsBankAccountNonceMustBePlaidVerified
@@ -154,7 +157,7 @@ describe Braintree::Transaction do
               :payment_method_nonce => invalid_nonce,
               :options => {
                 :submit_for_settlement => true,
-              }
+              },
             )
             result.success?.should == false
             result.errors.for(:transaction).on(:payment_method_nonce)[0].code.should == Braintree::ErrorCodes::Transaction::PaymentMethodNonceUnknown
@@ -169,7 +172,7 @@ describe Braintree::Transaction do
               :options => {
                 :us_bank_account_verification_method => "independent_check",
                 :verification_merchant_account_id => SpecHelper::AnotherUsBankMerchantAccountId,
-              }
+              },
             )
             payment_method = result.payment_method
 
@@ -187,7 +190,7 @@ describe Braintree::Transaction do
               :payment_method_token => payment_method.token,
               :options => {
                 :submit_for_settlement => true,
-              }
+              },
             )
 
             result.success?.should == true
@@ -199,7 +202,7 @@ describe Braintree::Transaction do
               :customer_id => Braintree::Customer.create.customer.id,
               :options => {
                 :verification_merchant_account_id => SpecHelper::AnotherUsBankMerchantAccountId,
-              }
+              },
             ).payment_method
 
             payment_method.verifications.count.should == 0
@@ -212,7 +215,7 @@ describe Braintree::Transaction do
               :payment_method_token => payment_method.token,
               :options => {
                 :submit_for_settlement => true,
-              }
+              },
             )
 
             result.success?.should == false
@@ -233,7 +236,8 @@ describe Braintree::Transaction do
         let(:plaid_nonce) { generate_valid_plaid_us_bank_account_nonce }
 
         context "nonce" do
-          it "sale succeeds" do
+          # we are temporarily skipping this test until we have a more stable CI env
+          xit "sale succeeds" do
             result = Braintree::Transaction.create(
               :type => "sale",
               :amount => Braintree::Test::TransactionAmounts::Authorize,
@@ -241,7 +245,7 @@ describe Braintree::Transaction do
               :payment_method_nonce => plaid_nonce,
               :options => {
                 :submit_for_settlement => true,
-              }
+              },
             )
             result.success?.should == true
             result.transaction.id.should =~ /^\w{6,}$/
@@ -260,13 +264,14 @@ describe Braintree::Transaction do
         end
 
         context "token" do
-          it "payment_method#create then sale succeeds" do
+          # we are temporarily skipping this test until we have a more stable CI env
+          xit "payment_method#create then sale succeeds" do
             result = Braintree::PaymentMethod.create(
               :payment_method_nonce => plaid_nonce,
               :customer_id => Braintree::Customer.create.customer.id,
               :options => {
                 :verification_merchant_account_id => SpecHelper::UsBankMerchantAccountId,
-              }
+              },
             )
 
             payment_method = result.payment_method
@@ -285,7 +290,7 @@ describe Braintree::Transaction do
               :payment_method_token => payment_method.token,
               :options => {
                 :submit_for_settlement => true,
-              }
+              },
             )
 
             result.success?.should == true
@@ -305,7 +310,8 @@ describe Braintree::Transaction do
             transaction.us_bank_account_details.ach_mandate.accepted_at.should be_a Time
           end
 
-          it "transaction#create store_in_vault then sale succeeds" do
+          # we are temporarily skipping this test until we have a more stable CI env
+          xit "transaction#create store_in_vault then sale succeeds" do
             result = Braintree::Transaction.create(
               :type => "sale",
               :amount => Braintree::Test::TransactionAmounts::Authorize,
@@ -314,7 +320,7 @@ describe Braintree::Transaction do
               :options => {
                 :submit_for_settlement => true,
                 :store_in_vault => true,
-              }
+              },
             )
 
             result.success?.should == true
@@ -326,7 +332,7 @@ describe Braintree::Transaction do
               :payment_method_token => result.transaction.us_bank_account_details.token,
               :options => {
                 :submit_for_settlement => true,
-              }
+              },
             )
 
             result.success?.should == true
@@ -361,7 +367,7 @@ describe Braintree::Transaction do
               :payment_method_nonce => non_plaid_nonce,
               :options => {
                 :submit_for_settlement => true,
-              }
+              },
             )
             result.success?.should == true
 
@@ -388,7 +394,7 @@ describe Braintree::Transaction do
               :payment_method_nonce => invalid_nonce,
               :options => {
                 :submit_for_settlement => true,
-              }
+              },
             )
             result.success?.should == false
             result.errors.for(:transaction).on(:payment_method_nonce)[0].code.should == Braintree::ErrorCodes::Transaction::PaymentMethodNonceUnknown
@@ -402,7 +408,7 @@ describe Braintree::Transaction do
               :customer_id => Braintree::Customer.create.customer.id,
               :options => {
                 :verification_merchant_account_id => SpecHelper::UsBankMerchantAccountId,
-              }
+              },
             )
             payment_method = result.payment_method
 
@@ -420,7 +426,7 @@ describe Braintree::Transaction do
               :payment_method_token => payment_method.token,
               :options => {
                 :submit_for_settlement => true,
-              }
+              },
             )
 
             result.success?.should == true

data/spec/integration/braintree/us_bank_account_spec.rb

@@ -12,7 +12,7 @@ describe Braintree::UsBankAccount do
         :customer_id => customer.id,
         :options => {
           :verification_merchant_account_id => SpecHelper::UsBankMerchantAccountId,
-        }
+        },
       )
       result.should be_success
 
@@ -44,14 +44,14 @@ describe Braintree::UsBankAccount do
         :customer_id => customer.id,
         :options => {
           :verification_merchant_account_id => SpecHelper::UsBankMerchantAccountId,
-        }
+        },
       )
       result.should be_success
 
       result = Braintree::UsBankAccount.sale(
         result.payment_method.token,
         :merchant_account_id => SpecHelper::UsBankMerchantAccountId,
-        :amount => "100.00"
+        :amount => "100.00",
       )
 
       result.success?.should == true
@@ -78,14 +78,14 @@ describe Braintree::UsBankAccount do
         :customer_id => customer.id,
         :options => {
           :verification_merchant_account_id => SpecHelper::UsBankMerchantAccountId,
-        }
+        },
       )
       result.should be_success
 
       transaction = Braintree::UsBankAccount.sale!(
         result.payment_method.token,
         :merchant_account_id => SpecHelper::UsBankMerchantAccountId,
-        :amount => "100.00"
+        :amount => "100.00",
       )
 
       transaction.amount.should == BigDecimal("100.00")
@@ -105,7 +105,7 @@ describe Braintree::UsBankAccount do
         Braintree::UsBankAccount.sale!(
           generate_invalid_us_bank_account_nonce,
           :merchant_account_id => SpecHelper::UsBankMerchantAccountId,
-          :amount => "100.00"
+          :amount => "100.00",
         )
       end.to raise_error(Braintree::ValidationsFailed)
     end

data/spec/integration/braintree/us_bank_account_verification_search_spec.rb

@@ -21,7 +21,7 @@ describe Braintree::UsBankAccountVerification, "search" do
       :customer_id => customer.id,
       :options => {
         :verification_merchant_account_id => SpecHelper::UsBankMerchantAccountId,
-      }
+      },
     ).payment_method
     verification = payment_method.verifications.first
 
@@ -70,7 +70,7 @@ describe Braintree::UsBankAccountVerification, "search" do
         :customer_id => customer.id,
         :options => {
           :verification_merchant_account_id => SpecHelper::UsBankMerchantAccountId,
-        }
+        },
       ).payment_method
       verification1 = payment_method1.verifications.first
 
@@ -79,7 +79,7 @@ describe Braintree::UsBankAccountVerification, "search" do
         :customer_id => customer.id,
         :options => {
           :verification_merchant_account_id => SpecHelper::UsBankMerchantAccountId,
-        }
+        },
       ).payment_method
       verification2 = payment_method2.verifications.first
 
@@ -100,7 +100,7 @@ describe Braintree::UsBankAccountVerification, "search" do
         :customer_id => customer.id,
         :options => {
           :verification_merchant_account_id => SpecHelper::UsBankMerchantAccountId,
-        }
+        },
       ).payment_method
       verification = payment_method.verifications.first
 
@@ -110,7 +110,7 @@ describe Braintree::UsBankAccountVerification, "search" do
         search.id.is verification.id
         search.created_at.between(
           created_at - 60,
-          created_at + 60
+          created_at + 60,
         )
       end
 
@@ -137,7 +137,7 @@ describe Braintree::UsBankAccountVerification, "search" do
         search.id.is verification.id
         search.created_at.between(
           created_at - 300,
-          created_at - 100
+          created_at - 100,
         )
       end
 
@@ -162,7 +162,7 @@ describe Braintree::UsBankAccountVerification, "search" do
         :customer_id => customer.id,
         :options => {
           :verification_merchant_account_id => SpecHelper::UsBankMerchantAccountId,
-        }
+        },
       ).payment_method
       verification = payment_method.verifications.first
 

data/spec/integration/braintree/us_bank_account_verification_spec.rb

@@ -36,7 +36,7 @@ describe Braintree::UsBankAccountVerification do
           :options => {
             :verification_merchant_account_id => SpecHelper::AnotherUsBankMerchantAccountId,
             :us_bank_account_verification_method => Braintree::UsBankAccountVerification::VerificationMethod::MicroTransfers,
-          }
+          },
         )
 
         result.should be_success
@@ -64,7 +64,7 @@ describe Braintree::UsBankAccountVerification do
           :options => {
             :verification_merchant_account_id => SpecHelper::AnotherUsBankMerchantAccountId,
             :us_bank_account_verification_method => Braintree::UsBankAccountVerification::VerificationMethod::MicroTransfers,
-          }
+          },
         )
 
         result.should be_success
@@ -86,7 +86,7 @@ describe Braintree::UsBankAccountVerification do
           :options => {
             :verification_merchant_account_id => SpecHelper::AnotherUsBankMerchantAccountId,
             :us_bank_account_verification_method => Braintree::UsBankAccountVerification::VerificationMethod::MicroTransfers,
-          }
+          },
         )
 
         result.should be_success
@@ -108,7 +108,7 @@ describe Braintree::UsBankAccountVerification do
           :options => {
             :verification_merchant_account_id => SpecHelper::AnotherUsBankMerchantAccountId,
             :us_bank_account_verification_method => Braintree::UsBankAccountVerification::VerificationMethod::MicroTransfers,
-          }
+          },
         )
 
         result.should be_success
@@ -139,7 +139,7 @@ describe Braintree::UsBankAccountVerification do
           :options => {
             :verification_merchant_account_id => SpecHelper::AnotherUsBankMerchantAccountId,
             :us_bank_account_verification_method => Braintree::UsBankAccountVerification::VerificationMethod::MicroTransfers,
-          }
+          },
         )
 
         result.should be_success
@@ -160,7 +160,7 @@ describe Braintree::UsBankAccountVerification do
           :options => {
             :verification_merchant_account_id => SpecHelper::AnotherUsBankMerchantAccountId,
             :us_bank_account_verification_method => Braintree::UsBankAccountVerification::VerificationMethod::NetworkCheck,
-          }
+          },
         )
 
         result.should be_success
@@ -182,7 +182,7 @@ describe Braintree::UsBankAccountVerification do
         :options => {
           :verification_merchant_account_id => SpecHelper::UsBankMerchantAccountId,
           :us_bank_account_verification_method => Braintree::UsBankAccountVerification::VerificationMethod::NetworkCheck,
-        }
+        },
       )
 
       result.should be_success
@@ -208,7 +208,7 @@ describe Braintree::UsBankAccountVerification do
         :options => {
           :verification_merchant_account_id => SpecHelper::UsBankMerchantAccountId,
           :us_bank_account_verification_method => Braintree::UsBankAccountVerification::VerificationMethod::NetworkCheck,
-        }
+        },
       ).payment_method
     end
 

data/spec/integration/braintree/visa_checkout_card_spec.rb

@@ -7,7 +7,7 @@ describe Braintree::VisaCheckoutCard do
 
     result = Braintree::PaymentMethod.create(
       :payment_method_nonce => Braintree::Test::Nonce::VisaCheckoutDiscover,
-      :customer_id => customer.id
+      :customer_id => customer.id,
     )
     result.should be_success
 
@@ -53,7 +53,7 @@ describe Braintree::VisaCheckoutCard do
     result = Braintree::PaymentMethod.create(
       :payment_method_nonce => Braintree::Test::Nonce::VisaCheckoutDiscover,
       :customer_id => customer.id,
-      :options => { :verify_card => true }
+      :options => {:verify_card => true},
     )
     result.should be_success
     result.payment_method.verification.status.should == Braintree::CreditCardVerification::Status::Verified
@@ -62,7 +62,7 @@ describe Braintree::VisaCheckoutCard do
   it "can search for transactions" do
     transaction_create_result = Braintree::Transaction.sale(
       :payment_method_nonce => Braintree::Test::Nonce::VisaCheckoutDiscover,
-      :amount => '47.00',
+      :amount => "47.00",
     )
     transaction_create_result.should be_success
     transaction_id = transaction_create_result.transaction.id
@@ -80,8 +80,8 @@ describe Braintree::VisaCheckoutCard do
     result = Braintree::Transaction.sale(
       :payment_method_nonce => Braintree::Test::Nonce::VisaCheckoutDiscover,
       :customer_id => customer.id,
-      :amount => '47.00',
-      :options => { :store_in_vault => true },
+      :amount => "47.00",
+      :options => {:store_in_vault => true},
     )
     result.should be_success
 

data/spec/integration/spec_helper.rb

@@ -2,10 +2,9 @@ require "securerandom"
 
 unless defined?(INTEGRATION_SPEC_HELPER_LOADED)
   INTEGRATION_SPEC_HELPER_LOADED = true
-  SSL_TEST_PORT = ENV['SSL_TEST_PORT'] || 8444
+  SSL_TEST_PORT = ENV["SSL_TEST_PORT"] || 8444
 
   require File.dirname(__FILE__) + "/../spec_helper"
-  require File.dirname(__FILE__) + "/../hacks/tcp_socket"
 
   def start_ssl_server
     web_server_pid_file = File.expand_path(File.join(File.dirname(__FILE__), "..", "httpsd.pid"))
@@ -13,11 +12,9 @@ unless defined?(INTEGRATION_SPEC_HELPER_LOADED)
     FileUtils.rm(web_server_pid_file) if File.exist?(web_server_pid_file)
     command = File.expand_path(File.join(File.dirname(__FILE__), "..", "script", "httpsd.rb"))
     `#{command} #{web_server_pid_file}`
-    TCPSocket.wait_for_service :host => "127.0.0.1", :port => SSL_TEST_PORT
+    TCPSocket.new("127.0.0.1",SSL_TEST_PORT)
 
-    yield
-
-    10.times { unless File.exists?(web_server_pid_file); sleep 1; end }
+    10.times { unless File.exist?(web_server_pid_file); sleep 1; end }
   ensure
     Process.kill "INT", File.read(web_server_pid_file).to_i
   end
@@ -45,12 +42,18 @@ unless defined?(INTEGRATION_SPEC_HELPER_LOADED)
     end
   end
 
-  def with_advanced_fraud_integration_merchant(&block)
+  def with_advanced_fraud_kount_integration_merchant(&block)
     with_other_merchant("advanced_fraud_integration_merchant_id", "advanced_fraud_integration_public_key", "advanced_fraud_integration_private_key") do
       block.call
     end
   end
 
+  def with_fraud_protection_enterprise_merchant(&block)
+    with_other_merchant("fraud_protection_enterprise_integration_merchant_id", "fraud_protection_enterprise_integration_public_key", "fraud_protection_enterprise_integration_private_key") do
+      block.call
+    end
+  end
+
   def with_altpay_merchant(&block)
     with_other_merchant("altpay_merchant", "altpay_merchant_public_key", "altpay_merchant_private_key", &block)
   end