braintree 1.0.1 → 1.1.0

data/spec/unit/braintree/ssl_expiration_check_spec.rb

@@ -56,23 +56,32 @@ describe Braintree::SSLExpirationCheck do
 
     # We assume that testing logging for one is good enough for all, so we won't duplicate those tests from above
     it "checks the sandbox cert" do
-        Braintree::SSLExpirationCheck.stub(:sandbox_expiration_date).and_return(Date.today)
-        output = StringIO.new
-        Braintree::Configuration.logger = Logger.new(output)
-        Braintree::Configuration.logger.level = Logger::WARN
+      Braintree::SSLExpirationCheck.stub(:sandbox_expiration_date).and_return(Date.today)
+      output = StringIO.new
+      Braintree::Configuration.logger = Logger.new(output)
+      Braintree::Configuration.logger.level = Logger::WARN
 
-        Braintree::SSLExpirationCheck.check_dates
+      Braintree::SSLExpirationCheck.check_dates
 
-        output.string.should match(/\[Braintree\] The SSL Certificate for the Sandbox environment will expire on \d{4}-\d{2}-\d{2}\. Please check for an updated client library\./)
+      output.string.should match(/\[Braintree\] The SSL Certificate for the Sandbox environment will expire on \d{4}-\d{2}-\d{2}\. Please check for an updated client library\./)
     end
 
-    xit "Patrick -- waiting on a production box -- checks the production server cert"
+    it "checks the production server cert" do
+      Braintree::SSLExpirationCheck.stub(:production_expiration_date).and_return(Date.today)
+      output = StringIO.new
+      Braintree::Configuration.logger = Logger.new(output)
+      Braintree::Configuration.logger.level = Logger::WARN
+
+      Braintree::SSLExpirationCheck.check_dates
+
+      output.string.should match(/\[Braintree\] The SSL Certificate for the Production environment will expire on \d{4}-\d{2}-\d{2}\. Please check for an updated client library\./)
+    end
   end
 
   describe "production_expiration_date" do
-    xit "Patrick -- waiting on a production box -- is the date the production cert expires" do
+    it "is the date the production cert expires" do
       Braintree::SSLExpirationCheck.production_expiration_date.should be_a(Date)
-      Braintree::SSLExpirationCheck.qa_expiration_date.should == fetch_expiration_date(PRODUCTION)
+      Braintree::SSLExpirationCheck.production_expiration_date.should == fetch_expiration_date(PRODUCTION)
     end
   end
 

data/spec/unit/braintree/transaction/credit_card_details_spec.rb

@@ -11,6 +11,21 @@ describe Braintree::Transaction::CreditCardDetails do
     end
   end
 
+  describe "inspect" do
+    it "inspects" do
+      details = Braintree::Transaction::CreditCardDetails.new(
+        :bin => "123456",
+        :card_type => "Visa",
+        :expiration_month => "05",
+        :expiration_year => "2012",
+        :last_4 => "6789",
+        :token => "token",
+        :customer_location => "US"
+      )
+      details.inspect.should == %(#<token: "token", bin: "123456", last_4: "6789", card_type: "Visa", expiration_date: "05/2012", customer_location: "US">)
+    end
+  end
+
   describe "masked_number" do
     it "concatenates the bin, some *'s, and the last_4" do
       details = Braintree::Transaction::CreditCardDetails.new(

data/spec/unit/braintree/transaction/customer_details_spec.rb

@@ -0,0 +1,19 @@
+require File.dirname(__FILE__) + "/../../spec_helper"
+
+describe Braintree::Transaction::CustomerDetails do
+  describe "inspect" do
+    it "inspects" do
+      details = Braintree::Transaction::CustomerDetails.new(
+        :id => "id",
+        :first_name => "Amy",
+        :last_name => "Smith",
+        :email => "amy.smith@example.com",
+        :company => "Smith Co.",
+        :website => "http://www.example.com",
+        :phone => "6145551234",
+        :fax => "3125551234"
+      )
+      details.inspect.should == %(#<id: "id", first_name: "Amy", last_name: "Smith", email: "amy.smith@example.com", company: "Smith Co.", website: "http://www.example.com", phone: "6145551234", fax: "3125551234">)
+    end
+  end
+end

data/spec/unit/braintree/transaction_spec.rb

@@ -30,7 +30,7 @@ describe Braintree::Transaction do
       end.to raise_error(ArgumentError, "transaction_id is invalid")
     end
   end
-  
+
   describe "initialize" do
     it "sets up customer attributes in customer_details" do
       transaction = Braintree::Transaction._new(
@@ -54,7 +54,7 @@ describe Braintree::Transaction do
       transaction.customer_details.phone.should == "1-999-652-4189 x56883"
       transaction.customer_details.fax.should == "012-161-8055"
     end
-    
+
     it "sets up credit card attributes in credit_card_details" do
       transaction = Braintree::Transaction._new(
         :credit_card => {
@@ -64,7 +64,7 @@ describe Braintree::Transaction do
           :card_type => "Visa",
           :expiration_month => "08",
           :expiration_year => "2009",
-          :issuer_location => "US"
+          :customer_location => "US"
         }
       )
       transaction.credit_card_details.token.should == "mzg2"
@@ -73,14 +73,14 @@ describe Braintree::Transaction do
       transaction.credit_card_details.card_type.should == "Visa"
       transaction.credit_card_details.expiration_month.should == "08"
       transaction.credit_card_details.expiration_year.should == "2009"
-      transaction.credit_card_details.issuer_location.should == "US"
+      transaction.credit_card_details.customer_location.should == "US"
     end
 
     it "sets up history attributes in status_history" do
       time = Time.utc(2010,1,14)
       transaction = Braintree::Transaction._new(
         :status_history => [
-          { :timestamp => time, :amount => "12.00", :transaction_source => "API", 
+          { :timestamp => time, :amount => "12.00", :transaction_source => "API",
             :user => "larry", :status => "authorized" },
           { :timestamp => Time.utc(2010,1,15), :amount => "12.00", :transaction_source => "API",
             :user => "curly", :status => "scheduled_for_settlement"}
@@ -100,7 +100,7 @@ describe Braintree::Transaction do
       )
     end
   end
-  
+
   describe "inspect" do
     it "includes the id, type, amount, and status first" do
       transaction = Braintree::Transaction._new(
@@ -110,28 +110,28 @@ describe Braintree::Transaction do
         :status => "authorized"
       )
       output = transaction.inspect
-      output.should include(%Q(#<Braintree::Transaction id: "1234", type: "sale", amount: "100.00", status: "authorized"))
+      output.should include(%Q(#<Braintree::Transaction id: "1234", type: "sale", amount: "100.0", status: "authorized"))
     end
   end
-  
+
   describe "==" do
     it "returns true when it should" do
       first = Braintree::Transaction._new(:id => 123)
       second = Braintree::Transaction._new(:id => 123)
-      
+
       first.should == second
       second.should == first
     end
-    
+
     it "returns false when it should" do
       first = Braintree::Transaction._new(:id => 123)
       second = Braintree::Transaction._new(:id => 124)
-      
+
       first.should_not == second
-      second.should_not == first      
+      second.should_not == first
     end
   end
-  
+
   describe "new" do
     it "is protected" do
       expect do
@@ -139,7 +139,7 @@ describe Braintree::Transaction do
       end.to raise_error(NoMethodError, /protected method .new/)
     end
   end
-  
+
   describe "refunded?" do
     it "is true if the transaciton has been refunded" do
       transaction = Braintree::Transaction._new(:refund_id => "123")

data/spec/unit/braintree/transparent_redirect_spec.rb

@@ -25,22 +25,22 @@ describe Braintree::TransparentRedirect do
     it "returns the parsed query string params if the hash is valid" do
       query_string_without_hash = "one=1&two=2&http_status=200"
       hash = Braintree::Digest.hexdigest(query_string_without_hash)
-      
+
       query_string_with_hash = "#{query_string_without_hash}&hash=#{hash}"
       result = Braintree::TransparentRedirect.parse_and_validate_query_string query_string_with_hash
       result.should == {:one => "1", :two => "2", :http_status => "200", :hash => hash}
     end
-    
+
     it "raises Braintree::ForgedQueryString if the hash param is not valid" do
       query_string_without_hash = "one=1&two=2"
       hash = Digest::SHA1.hexdigest("invalid#{query_string_without_hash}")
-      
+
       query_string_with_hash = "#{query_string_without_hash}&hash=#{hash}"
       expect do
         Braintree::TransparentRedirect.parse_and_validate_query_string query_string_with_hash
       end.to raise_error(Braintree::ForgedQueryString)
     end
-    
+
     it "raises Braintree::ForgedQueryString if hash is missing from the query string" do
       expect do
         Braintree::TransparentRedirect.parse_and_validate_query_string "query_string=without_a_hash"
@@ -58,7 +58,7 @@ describe Braintree::TransparentRedirect do
         Braintree::TransparentRedirect.parse_and_validate_query_string add_hash_to_query_string("http_status=403")
       end.to raise_error(Braintree::AuthorizationError)
     end
-    
+
     it "raises a ServerError if the server 500's" do
       expect do
         Braintree::TransparentRedirect.parse_and_validate_query_string add_hash_to_query_string("http_status=500")
@@ -70,7 +70,7 @@ describe Braintree::TransparentRedirect do
         Braintree::TransparentRedirect.parse_and_validate_query_string add_hash_to_query_string("http_status=503")
       end.to raise_error(Braintree::DownForMaintenanceError)
     end
-    
+
     it "raises an UnexpectedError if some other code is returned" do
       expect do
         Braintree::TransparentRedirect.parse_and_validate_query_string add_hash_to_query_string("http_status=600")
@@ -86,7 +86,7 @@ describe Braintree::TransparentRedirect do
         )
       end.to raise_error(ArgumentError, "invalid keys: transaction[invalid_key]")
     end
-    
+
     it "raises an exception if not given a type" do
       expect do
         Braintree::TransparentRedirect.transaction_data(
@@ -95,7 +95,7 @@ describe Braintree::TransparentRedirect do
         )
       end.to raise_error(ArgumentError, "expected transaction[type] of sale or credit, was: nil")
     end
-    
+
     it "raises an exception if not given a type of sale or credit" do
       expect do
         Braintree::TransparentRedirect.transaction_data(
@@ -114,14 +114,14 @@ describe Braintree::TransparentRedirect do
         )
       end.to raise_error(ArgumentError, "invalid keys: credit_card[invalid_key]")
     end
-    
+
     it "raises an exception if not given a payment_method_token" do
       expect do
         Braintree::TransparentRedirect.update_credit_card_data({})
       end.to raise_error(ArgumentError, "expected params to contain :payment_method_token of payment method to update")
     end
   end
-  
+
   describe "self.update_customer_data" do
     it "raises an exception if any keys are invalid" do
       expect do
@@ -145,7 +145,7 @@ describe Braintree::TransparentRedirect do
       end.to raise_error(ArgumentError, "expected params to contain :redirect_url")
     end
   end
-  
+
   def add_hash_to_query_string(query_string_without_hash)
     hash = Braintree::TransparentRedirect._hash(query_string_without_hash)
     query_string_without_hash + "&hash=" + hash

data/spec/unit/braintree/util_spec.rb

@@ -13,7 +13,7 @@ describe Braintree::Util do
         Braintree::Util.verify_keys([:allowed], :allowed => "ok", :disallowed => "bad", "also_invalid" => true)
       end.to raise_error(ArgumentError, "invalid keys: also_invalid, disallowed")
     end
-    
+
     it "raises an exception if a nested hash contains an invalid key" do
       expect do
         Braintree::Util.verify_keys(
@@ -53,7 +53,7 @@ describe Braintree::Util do
           }
         )
       end.to raise_error(ArgumentError, "invalid keys: allowed[custom_fields][bad_nesting]")
-    end    
+    end
 
     it "raises an exception if a deeply nested hash contains an invalid key" do
       expect do
@@ -74,7 +74,7 @@ describe Braintree::Util do
       end.to raise_error(ArgumentError, "invalid keys: nested[deeply_allowed][real_deep_invalid], nested[nested_invalid], top_level_invalid")
     end
   end
-  
+
   describe "self._flatten_hash_keys" do
     it "flattens hash keys" do
       Braintree::Util._flatten_hash_keys(:nested => {
@@ -124,13 +124,13 @@ describe Braintree::Util do
       hash = {:foo => {:key_one => "value_one", :key_two => "value_two"}}
       Braintree::Util.hash_to_query_string(hash).should == "foo%5Bkey_one%5D=value_one&foo%5Bkey_two%5D=value_two"
     end
-    
+
     it "works for nesting 2 levels deep" do
       hash = {:foo => {:nested => {:key_one => "value_one", :key_two => "value_two"}}}
       Braintree::Util.hash_to_query_string(hash).should == "foo%5Bnested%5D%5Bkey_one%5D=value_one&foo%5Bnested%5D%5Bkey_two%5D=value_two"
     end
   end
-  
+
   describe "self.parse_query_string" do
     it "parses the query string" do
       query_string = "foo=bar%20baz&hash=a1b2c3"
@@ -150,7 +150,7 @@ describe Braintree::Util do
         Braintree::Util.raise_exception_for_status_code(403)
       end.to raise_error(Braintree::AuthorizationError)
     end
-    
+
     it "raises a ServerError if the server 500's" do
       expect do
         Braintree::Util.raise_exception_for_status_code(500)
@@ -162,7 +162,7 @@ describe Braintree::Util do
         Braintree::Util.raise_exception_for_status_code(503)
       end.to raise_error(Braintree::DownForMaintenanceError)
     end
-    
+
     it "raises an UnexpectedError if some other code is returned" do
       expect do
         Braintree::Util.raise_exception_for_status_code(600)
@@ -170,7 +170,7 @@ describe Braintree::Util do
     end
   end
 
-  
+
   describe "self.url_encode" do
     it "url encodes the given text" do
       Braintree::Util.url_encode("foo?bar").should == "foo%3Fbar"

data/spec/unit/braintree/validation_error_collection_spec.rb

@@ -1,7 +1,7 @@
 require File.dirname(__FILE__) + "/../spec_helper"
 
 describe Braintree::ValidationErrorCollection do
-  
+
   describe "initialize" do
     it "builds an error object given an array of hashes" do
       hash = {:errors => [{ :attribute => "some model attribute", :code => 1, :message => "bad juju" }]}
@@ -12,7 +12,7 @@ describe Braintree::ValidationErrorCollection do
       error.message.should == "bad juju"
     end
   end
-  
+
   describe "for" do
     it "provides access to nested errors" do
       hash = {
@@ -64,7 +64,7 @@ describe Braintree::ValidationErrorCollection do
       errors.inspect.should == "#<Braintree::ValidationErrorCollection errors:[(code1) message1], level1:[(code2) message2], level1/level2:[(code3) message3]>"
     end
   end
-  
+
   describe "on" do
     it "returns an array of errors on the given attribute" do
       errors = Braintree::ValidationErrorCollection.new(:errors => [
@@ -75,14 +75,14 @@ describe Braintree::ValidationErrorCollection do
       errors.on("name").size.should == 2
       errors.on("name").map{ |e| e.code }.should == [1, 2]
     end
-    
+
     it "has indifferent access" do
       errors = Braintree::ValidationErrorCollection.new(:errors => [
         { :attribute => "name", :code => 3, :message => "is too long" },
       ])
       errors.on(:name).size.should == 1
       errors.on(:name)[0].code.should == 3
-      
+
     end
   end
 
@@ -124,5 +124,5 @@ describe Braintree::ValidationErrorCollection do
       errors.deep_size.should == 5
     end
   end
-  
+
 end

data/spec/unit/braintree/validation_error_spec.rb

@@ -3,13 +3,13 @@ require File.dirname(__FILE__) + "/../spec_helper"
 describe Braintree::ValidationError do
   describe "initialize" do
     it "works" do
-      error = Braintree::ValidationError.new :attribute => "some model attribute", :code => 1, :message => "bad juju" 
+      error = Braintree::ValidationError.new :attribute => "some model attribute", :code => 1, :message => "bad juju"
       error.attribute.should == "some model attribute"
       error.code.should == 1
       error.message.should == "bad juju"
     end
   end
-  
+
   describe "inspect" do
     it "is pretty" do
       error = Braintree::ValidationError.new :attribute => "number", :code => "123456", :message => "Number is bad juju."

data/spec/unit/braintree/xml/libxml_spec.rb

@@ -6,7 +6,7 @@ describe Braintree::Xml::Libxml do
       xml = "<root><foo type=\"integer\">123</foo></root>"
       Braintree::Xml::Libxml.parse(xml).should == {"root"=>{"foo"=>{"__content__"=>"123", "type"=>"integer"}}}
     end
-    
+
     it "works with dashes or underscores" do
       xml = <<-END
         <root>
@@ -16,7 +16,7 @@ describe Braintree::Xml::Libxml do
       END
       Braintree::Xml::Libxml.parse(xml).should == {"root"=>{"dash-es"=>{}, "under_scores"=>{}}}
     end
-    
+
     it "uses nil if nil=true, otherwise uses empty string" do
       xml = <<-END
         <root>
@@ -26,7 +26,7 @@ describe Braintree::Xml::Libxml do
       END
       Braintree::Xml::Libxml.parse(xml).should == {"root"=>{"a_nil_value"=>{"nil"=>"true"}, "an_empty_string"=>{}}}
     end
-    
+
     it "typecasts dates and times" do
       xml = <<-END
         <root>
@@ -35,7 +35,7 @@ describe Braintree::Xml::Libxml do
       END
       Braintree::Xml::Libxml.parse(xml).should == {"root"=>{"created-at"=>{"__content__"=>"2009-10-28T10:19:49Z", "type"=>"datetime"}}}
     end
-      
+
     it "builds an array if type=array" do
       xml = <<-END
         <root>
@@ -48,4 +48,4 @@ describe Braintree::Xml::Libxml do
       Braintree::Xml::Libxml.parse(xml).should == {"root"=>{"customers"=>{"type"=>"array", "customer"=>[{"name"=>{"__content__"=>"Adam"}}, {"name"=>{"__content__"=>"Ben"}}]}}}
     end
   end
-end
+end

data/spec/unit/braintree/xml_spec.rb

@@ -6,7 +6,7 @@ describe Braintree::Xml do
       hash = Braintree::Xml.hash_from_xml("<root><foo type=\"integer\">123</foo></root>")
       hash.should == {:root => {:foo => 123}}
     end
-    
+
     it "works with dashes or underscores" do
       xml = <<-END
         <root>
@@ -14,11 +14,11 @@ describe Braintree::Xml do
           <under_scores />
         </root>
       END
-      
+
       hash = Braintree::Xml.hash_from_xml(xml)
       hash.should == {:root => {:dash_es => "", :under_scores => ""}}
     end
-    
+
     it "uses nil if nil=true, otherwise uses empty string" do
       xml = <<-END
         <root>
@@ -29,7 +29,7 @@ describe Braintree::Xml do
       hash = Braintree::Xml.hash_from_xml(xml)
       hash.should == {:root => {:a_nil_value => nil, :an_empty_string => ""}}
     end
-    
+
     it "typecasts dates and times" do
       hash = Braintree::Xml.hash_from_xml <<-END
         <root>
@@ -38,7 +38,7 @@ describe Braintree::Xml do
       END
       hash.should == {:root => {:created_at => Time.utc(2009, 10, 28, 10, 19, 49)}}
     end
-    
+
     it "builds an array if type=array" do
       hash = Braintree::Xml.hash_from_xml <<-END
         <root>
@@ -50,7 +50,7 @@ describe Braintree::Xml do
       END
       hash.should == {:root => {:customers => [{:name => "Adam"}, {:name => "Ben"}]}}
     end
-    
+
     it "turns 1 and true to boolean if type = boolean" do
       hash = Braintree::Xml.hash_from_xml <<-END
         <root>
@@ -66,7 +66,7 @@ describe Braintree::Xml do
         :uncasted_true => "true"
       }}
     end
-    
+
     it "handles values that are arrays of hashes" do
       hash = Braintree::Xml.hash_from_xml("
         <container>
@@ -78,45 +78,45 @@ describe Braintree::Xml do
       hash.should == {:container => {:elem => [{:value => "one"}, {:value => "two"}, {:value => "three"}]}}
     end
   end
-  
+
   describe "self.hash_to_xml" do
     def verify_to_xml_and_back(hash)
       Braintree::Xml.hash_from_xml(Braintree::Xml.hash_to_xml(hash)).should == hash
     end
-    
+
     it "works for a simple case" do
       hash = {:root => {:foo => "foo_value", :bar => "bar_value"}}
       verify_to_xml_and_back hash
     end
-    
+
     it "works for arrays" do
       hash = {:root => {:items => [{:name => "first"}, {:name => "second"}]}}
       verify_to_xml_and_back hash
     end
-    
+
     it "type casts booleans" do
       hash = {:root => {:string_true => "true", :bool_true => true, :bool_false => false, :string_false => "false"}}
       verify_to_xml_and_back hash
     end
-    
+
     it "type casts time" do
       hash = {:root => {:a_time => Time.utc(2009, 10, 28, 1, 2, 3), :a_string_that_looks_like_time => "2009-10-28T10:19:49Z"}}
       verify_to_xml_and_back hash
     end
-    
+
     it "can distinguish nil from empty string" do
       hash = {:root => {:an_empty_string => "", :a_nil_value => nil}}
       verify_to_xml_and_back hash
     end
-    
+
     it "includes the encoding" do
       xml = Braintree::Xml.hash_to_xml(:root => {:root => "bar"})
       xml.should include("<?xml version=\"1.0\" encoding=\"UTF-8\"?>")
     end
-    
+
     it "works for only a root node and a string" do
       hash = {:id => "123"}
       verify_to_xml_and_back hash
     end
   end
-end
+end