braintree 1.0.1 → 1.1.0

data/spec/integration/spec_helper.rb

@@ -10,7 +10,7 @@ unless defined?(INTEGRATION_SPEC_HELPER_LOADED)
     GATEWAY_SERVER_PORT = 3000
     GATEWAY_PID_FILE = "/tmp/gateway_server_#{Braintree::Configuration.port}.pid"
     SPHINX_PID_FILE = "#{GATEWAY_ROOT}/log/searchd.integration.pid"
-    
+
     gateway_already_started = File.exist?(GATEWAY_PID_FILE)
     sphinx_already_started = File.exist?(SPHINX_PID_FILE)
     config.before(:suite) do

data/spec/spec_helper.rb

@@ -8,7 +8,7 @@ unless defined?(SPEC_HELPER_LOADED)
   braintree_lib = "#{project_root}/lib"
   $LOAD_PATH << braintree_lib
   require "braintree"
-  
+
   Braintree::Configuration.environment = :development
   Braintree::Configuration.merchant_id = "integration_merchant_id"
   Braintree::Configuration.public_key = "integration_public_key"
@@ -21,7 +21,7 @@ unless defined?(SPEC_HELPER_LOADED)
       Time.class_eval do
         class << self
           alias original_now now
-        end  
+        end
       end
       (class << Time; self; end).class_eval do
         define_method(:now) { desired_time }
@@ -31,8 +31,8 @@ unless defined?(SPEC_HELPER_LOADED)
       Time.class_eval do
         class << self
           alias now original_now
-        end  
-      end  
+        end
+      end
     end
   end
 end

data/spec/unit/braintree/address_spec.rb

@@ -5,19 +5,19 @@ describe Braintree::Address do
     it "returns true if given an address with the same id and customer_id" do
       first = Braintree::Address._new(:customer_id => "c1", :id => 'a1')
       second = Braintree::Address._new(:customer_id => "c1", :id => "a1")
-      
+
       first.should == second
       second.should == first
     end
-    
+
     it "returns false if given an address with a different id and the same customer_id" do
       first = Braintree::Address._new(:customer_id => "c1", :id => "a1")
       second = Braintree::Address._new(:customer_id => "c1", :id => "not a1")
-      
+
       first.should_not == second
       second.should_not == first
     end
-    
+
     it "returns false if given an address with a different customer_id and the same id" do
       first = Braintree::Address._new(:customer_id => "c1", :id => "a1")
       second = Braintree::Address._new(:customer_id => "not c1", :id => "a1")
@@ -51,7 +51,7 @@ describe Braintree::Address do
       end.to raise_error(ArgumentError, "invalid keys: invalid_key")
     end
   end
-  
+
   describe "self.update" do
     it "raises an exception if hash includes an invalid key" do
       expect do
@@ -67,7 +67,7 @@ describe Braintree::Address do
       end.to raise_error(ArgumentError, "customer_id contains invalid characters")
     end
   end
-  
+
   describe "self.new" do
     it "is protected" do
       expect do

data/spec/unit/braintree/base_module_spec.rb

@@ -0,0 +1,18 @@
+require File.dirname(__FILE__) + "/../spec_helper"
+
+describe Braintree::BaseModule do
+  describe "return_object_or_raise" do
+    it "inspects the error_result when inspecting the exception" do
+      result = Braintree::ErrorResult.new(:errors => {})
+      begin
+        klass = Class.new { include Braintree::BaseModule }
+        klass.return_object_or_raise(:obj) { result }
+      rescue Braintree::ValidationsFailed => ex
+      end
+      ex.should_not == nil
+      ex.error_result.should == result
+      ex.inspect.should include(result.inspect)
+      ex.to_s.should include(result.inspect)
+    end
+  end
+end

data/spec/unit/braintree/configuration_spec.rb

@@ -1,7 +1,7 @@
 require File.dirname(__FILE__) + "/../spec_helper"
 
 describe Braintree::Configuration do
-  
+
   before do
     @original_merchant_id = Braintree::Configuration.merchant_id
     @original_public_key = Braintree::Configuration.public_key
@@ -11,11 +11,11 @@ describe Braintree::Configuration do
 
   after do
     Braintree::Configuration.merchant_id = @original_merchant_id
-    Braintree::Configuration.public_key  = @original_public_key 
+    Braintree::Configuration.public_key  = @original_public_key
     Braintree::Configuration.private_key = @original_private_key
     Braintree::Configuration.environment = @original_environment
   end
-  
+
   describe "self.base_merchant_path" do
     it "returns /merchants/{merchant_id}" do
       Braintree::Configuration.base_merchant_path.should == "/merchants/integration_merchant_id"
@@ -70,7 +70,7 @@ describe Braintree::Configuration do
       end.to raise_error(Braintree::ConfigurationError, "Braintree::Configuration.environment needs to be set")
     end
   end
-  
+
   describe "self.environment=" do
     it "raises an exception if the environment is invalid" do
       expect do
@@ -78,7 +78,7 @@ describe Braintree::Configuration do
       end.to raise_error(ArgumentError, ":invalid_environment is not a valid environment")
     end
   end
-  
+
   describe "self.logger" do
     it "defaults to logging to stdout with log_level info" do
       begin
@@ -99,7 +99,7 @@ describe Braintree::Configuration do
       end.to raise_error(Braintree::ConfigurationError, "Braintree::Configuration.merchant_id needs to be set")
     end
   end
-  
+
   describe "self.public_key" do
     it "raises an exception if it hasn't been set yet" do
       Braintree::Configuration.instance_variable_set(:@public_key, nil)
@@ -137,12 +137,12 @@ describe Braintree::Configuration do
 
   describe "self.protocol" do
     it "is http for development" do
-      Braintree::Configuration.environment = :development      
+      Braintree::Configuration.environment = :development
       Braintree::Configuration.protocol.should == "http"
     end
 
     it "is https for production" do
-      Braintree::Configuration.environment = :production      
+      Braintree::Configuration.environment = :production
       Braintree::Configuration.protocol.should == "https"
     end
 
@@ -169,7 +169,7 @@ describe Braintree::Configuration do
       Braintree::Configuration.server.should == "sandbox.braintreegateway.com"
     end
   end
-  
+
   describe "self.ssl?" do
     it "returns false for development" do
       Braintree::Configuration.environment = :development
@@ -186,5 +186,5 @@ describe Braintree::Configuration do
       Braintree::Configuration.ssl?.should == true
     end
   end
-  
+
 end

data/spec/unit/braintree/credit_card_spec.rb

@@ -21,41 +21,41 @@ describe Braintree::CreditCard do
     it "returns the url" do
       Braintree::CreditCard.create_credit_card_url.should == "http://localhost:3000/merchants/integration_merchant_id/payment_methods/all/create_via_transparent_redirect_request"
     end
-  end  
+  end
 
   describe "==" do
     it "returns true if given a credit card with the same token" do
       first = Braintree::CreditCard._new(:token => 123)
       second = Braintree::CreditCard._new(:token => 123)
-      
+
       first.should == second
       second.should == first
     end
-    
+
     it "returns false if given a credit card with a different token" do
       first = Braintree::CreditCard._new(:token => 123)
       second = Braintree::CreditCard._new(:token => 124)
-      
+
       first.should_not == second
-      second.should_not == first      
+      second.should_not == first
     end
-    
+
     it "returns false if not given a credit card" do
       credit_card = Braintree::CreditCard._new(:token => 123)
       credit_card.should_not == "not a credit card"
     end
   end
-  
+
   describe "default?" do
     it "is true if the credit card is the default credit card for the customer" do
       Braintree::CreditCard._new(:default => true).default?.should == true
     end
-    
+
     it "is false if the credit card is not the default credit card for the customer" do
       Braintree::CreditCard._new(:default => false).default?.should == false
     end
   end
-  
+
   describe "expired?" do
     it "is true if the payment method is this year and the month has passed" do
       SpecHelper.stub_time_dot_now(Time.mktime(2009, 10, 20)) do
@@ -63,18 +63,18 @@ describe Braintree::CreditCard do
         expired_pm.expired?.should == true
       end
     end
-    
+
     it "is true if the payment method is in a previous year" do
       expired_pm = Braintree::CreditCard._new(:expiration_month => "12", :expiration_year => (Time.now.year - 1).to_s)
       expired_pm.expired?.should == true
     end
-    
+
     it "is false if the payment method is not expired" do
       not_expired_pm = Braintree::CreditCard._new(:expiration_month => "01", :expiration_year => (Time.now.year + 1).to_s)
       not_expired_pm.expired?.should == false
     end
   end
-  
+
   describe "inspect" do
     it "includes the token first" do
       output = Braintree::CreditCard._new(:token => "cc123").inspect
@@ -108,7 +108,7 @@ describe Braintree::CreditCard do
       output.should include(%Q(created_at: #{credit_card.created_at.inspect}))
     end
   end
-  
+
   describe "masked_number" do
     it "uses the bin and last_4 to build the masked number" do
       credit_card = Braintree::CreditCard._new(
@@ -118,7 +118,7 @@ describe Braintree::CreditCard do
       credit_card.masked_number.should == "510510******5100"
     end
   end
-  
+
   describe "self.update" do
     it "raises an exception if attributes contain an invalid key" do
       expect do
@@ -126,7 +126,7 @@ describe Braintree::CreditCard do
       end.to raise_error(ArgumentError, "invalid keys: invalid_key")
     end
   end
-  
+
   describe "self.new" do
     it "is protected" do
       expect do

data/spec/unit/braintree/credit_card_verification_spec.rb

@@ -8,9 +8,11 @@ describe Braintree::CreditCardVerification do
         :avs_error_response_code => "I",
         :avs_postal_code_response_code => "I",
         :avs_street_address_response_code => "I",
-        :cvv_response_code => "I"
+        :cvv_response_code => "I",
+        :processor_response_code => "2000",
+        :processor_response_text => "Do Not Honor"
       )
-      verification.inspect.should == %(#<Braintree::CreditCardVerification status: "verified", cvv_response_code: "I", avs_error_response_code: "I", avs_postal_code_response_code: "I", avs_street_address_response_code: "I">)
+      verification.inspect.should == %(#<Braintree::CreditCardVerification status: "verified", processor_response_code: "2000", processor_response_text: "Do Not Honor", cvv_response_code: "I", avs_error_response_code: "I", avs_postal_code_response_code: "I", avs_street_address_response_code: "I">)
     end
   end
 end

data/spec/unit/braintree/customer_spec.rb

@@ -6,7 +6,7 @@ describe Braintree::Customer do
       output = Braintree::Customer._new({:first_name => 'Dan', :id => '1234'}).inspect
       output.should include("#<Braintree::Customer id: \"1234\",")
     end
-    
+
     it "includes all customer attributes" do
       customer = Braintree::Customer._new(
         :company => "Company",
@@ -31,7 +31,7 @@ describe Braintree::Customer do
       output.should include(%Q(updated_at: #{customer.updated_at.inspect}))
     end
   end
-    
+
   describe "self.create" do
     it "raises an exception if hash includes an invalid key" do
       expect do
@@ -39,7 +39,7 @@ describe Braintree::Customer do
       end.to raise_error(ArgumentError, "invalid keys: invalid_key")
     end
   end
-  
+
   describe "self.update" do
     it "raises an exception if hash includes an invalid key" do
       expect do
@@ -60,19 +60,19 @@ describe Braintree::Customer do
     it "returns true when given a customer with the same id" do
       first = Braintree::Customer._new(:id => 123)
       second = Braintree::Customer._new(:id => 123)
-      
+
       first.should == second
       second.should == first
     end
-    
+
     it "returns false when given a customer with a different id" do
       first = Braintree::Customer._new(:id => 123)
       second = Braintree::Customer._new(:id => 124)
-      
+
       first.should_not == second
       second.should_not == first
     end
-    
+
     it "returns false when not given a customer" do
       customer = Braintree::Customer._new(:id => 123)
       customer.should_not == "not a customer"
@@ -92,7 +92,7 @@ describe Braintree::Customer do
       customer.credit_cards[1].token.should == "pm2"
     end
   end
-  
+
   describe "new" do
     it "is protected" do
       expect do

data/spec/unit/braintree/digest_spec.rb

@@ -23,6 +23,10 @@ describe Braintree::Digest do
         Braintree::Configuration.private_key = original_key
       end
     end
+
+    it "doesn't blow up if message is nil" do
+      expect { Braintree::Digest.hexdigest(nil) }.to_not raise_error
+    end
   end
 end
 

data/spec/unit/braintree/http_spec.rb

@@ -17,7 +17,7 @@ END
 END
       Braintree::Http._format_and_sanitize_body_for_log(input_xml).should == expected_xml
     end
-    
+
     it "sanitizes credit card number and cvv" do
       input_xml = <<-END
 <customer>
@@ -27,7 +27,7 @@ END
   <cvv>123</cvv>
 </customer>
       END
-      
+
       expected_xml = <<-END
 [Braintree] <customer>
 [Braintree]   <first-name>Joe</first-name>

data/spec/unit/braintree/paged_collection_spec.rb

@@ -14,7 +14,7 @@ describe "Braintree::PagedCollection" do
       collection[3].should == nil
     end
   end
-  
+
   describe "each" do
     it "iterates over the contents" do
       expected = ["apples", "bananas", "cherries"]
@@ -28,7 +28,7 @@ describe "Braintree::PagedCollection" do
       actual.should == expected
     end
   end
-  
+
   describe "first" do
     it "returns the first element" do
       collection = Braintree::PagedCollection.new(
@@ -37,7 +37,7 @@ describe "Braintree::PagedCollection" do
       collection.first.should == "apples"
     end
   end
-  
+
   describe "initialize" do
     it "initializes attributes as expected" do
       collection = Braintree::PagedCollection.new(
@@ -64,7 +64,7 @@ describe "Braintree::PagedCollection" do
       collection.last_page?.should == false
     end
   end
-  
+
   describe "next_page" do
     it "returns the next page of results" do
       collection = Braintree::PagedCollection.new(
@@ -73,20 +73,20 @@ describe "Braintree::PagedCollection" do
           :total_items => 2
         ) do |page_num|
         "contents of page #{page_num}"
-      end      
+      end
       collection.next_page.should == "contents of page 2"
     end
-    
+
     it "returns nil if on last page" do
       collection = Braintree::PagedCollection.new(
           :current_page_number => 2,
           :page_size => 2,
           :total_items => 4
-        )      
+        )
       collection.next_page.should == nil
     end
   end
-  
+
   describe "next_page_number" do
     it "returns the next page number when not on the last page" do
       collection = Braintree::PagedCollection.new(
@@ -96,17 +96,17 @@ describe "Braintree::PagedCollection" do
       )
       collection.next_page_number.should == 3
     end
-    
+
     it "returns nil when on the last page" do
       collection = Braintree::PagedCollection.new(
         :current_page_number => 1,
         :page_size => 1,
         :total_items => 1
       )
-      collection.next_page_number.should == nil      
+      collection.next_page_number.should == nil
     end
   end
-  
+
   describe "total_pages" do
     it "calculates the total number of pages when total items is not evenly divisible by page size" do
       collection = Braintree::PagedCollection.new(
@@ -124,5 +124,5 @@ describe "Braintree::PagedCollection" do
       collection.total_pages.should == 4
     end
   end
-  
+
 end