braintree 1.0.1 → 1.1.0

data/lib/braintree/transparent_redirect.rb

@@ -38,6 +38,20 @@ module Braintree
       _data(params)
     end
 
+    def self.parse_and_validate_query_string(query_string) # :nodoc:
+      params = Util.symbolize_keys(Util.parse_query_string(query_string))
+      query_string_without_hash = query_string[/(.*)&hash=.*/, 1]
+      if _hash(query_string_without_hash) == params[:hash]
+        if params[:http_status] == '200'
+          params
+        else
+          Util.raise_exception_for_status_code(params[:http_status])
+        end
+      else
+        raise ForgedQueryString
+      end
+    end
+
     # Returns the tr_data string for creating a transaction.
     def self.transaction_data(params)
       Util.verify_keys(TransactionSignature, params)
@@ -78,20 +92,6 @@ module Braintree
       _data(params)
     end
 
-    def self.parse_and_validate_query_string(query_string) # :nodoc:
-      params = Util.symbolize_keys(Util.parse_query_string(query_string))
-      query_string_without_hash = query_string[/(.*)&hash=.*/, 1]
-      if _hash(query_string_without_hash) == params[:hash]
-        if params[:http_status] == '200'
-          params
-        else
-          Util.raise_exception_for_status_code(params[:http_status])
-        end
-      else
-        raise ForgedQueryString
-      end
-    end
-
     def self._data(params) # :nodoc:
       raise ArgumentError, "expected params to contain :redirect_url" unless params[:redirect_url]
       tr_data_segment = Util.hash_to_query_string(params.merge(
@@ -102,7 +102,7 @@ module Braintree
       tr_data_hash = _hash(tr_data_segment)
       "#{tr_data_hash}|#{tr_data_segment}"
     end
-    
+
     def self._hash(string) # :nodoc:
       ::Braintree::Digest.hexdigest(string)
     end

data/lib/braintree/util.rb

@@ -15,7 +15,7 @@ module Braintree
         end
       end.sort * '&'
     end
-    
+
     def self.parse_query_string(qs)
       qs.split('&').inject({}) do |result, couplet|
         pair = couplet.split('=')
@@ -23,7 +23,7 @@ module Braintree
         result
       end
     end
-    
+
     def self.url_encode(text)
       CGI.escape text.to_s
     end
@@ -37,10 +37,10 @@ module Braintree
         elsif value.is_a?(Array) && value.all? { |v| v.is_a?(Hash) }
           value.each { |v| symbolize_keys(v) }
         end
-      end 
+      end
       hash
     end
-    
+
     def self.raise_exception_for_status_code(status_code)
       case status_code.to_i
       when 401
@@ -57,7 +57,7 @@ module Braintree
         raise UnexpectedError, "Unexpected HTTP_RESPONSE #{status_code.to_i}"
       end
     end
-    
+
     def self.verify_keys(valid_keys, hash)
       flattened_valid_keys = _flatten_valid_keys(valid_keys)
       invalid_keys = _flatten_hash_keys(hash) - flattened_valid_keys
@@ -67,7 +67,7 @@ module Braintree
         raise ArgumentError, "invalid keys: #{sorted}"
       end
     end
-    
+
     def self._flatten_valid_keys(valid_keys, namespace = nil)
       valid_keys.inject([]) do |result, key|
         if key.is_a?(Hash)
@@ -85,7 +85,7 @@ module Braintree
         result
       end.sort
     end
-    
+
     def self._flatten_hash_keys(hash, namespace = nil)
       hash.inject([]) do |result, (key, value)|
         full_key = (namespace ? "#{namespace}[#{key}]" : key.to_s)

data/lib/braintree/validation_error.rb

@@ -7,7 +7,7 @@ module Braintree
     def initialize(attributes)
       set_instance_variables_from_hash attributes
     end
-    
+
     def inspect # :nodoc:
       "#<#{self.class} (#{code}) #{message}>"
     end

data/lib/braintree/validation_error_collection.rb

@@ -20,7 +20,7 @@ module Braintree
   #   #=> [#<Braintree::ValidationError (91803) Country name is not an accepted country.>]
   class ValidationErrorCollection
     include Enumerable
-  
+
     def initialize(data) # :nodoc:
       @errors = data[:errors].map { |hash| Braintree::ValidationError.new(hash) }
       @nested = {}
@@ -29,7 +29,7 @@ module Braintree
         @nested[key] = ValidationErrorCollection.new(data[key])
       end
     end
-    
+
     # Accesses the error at the given index.
     def [](index)
       @errors[index]
@@ -38,7 +38,7 @@ module Braintree
     def deep_size # :nodoc:
       size + @nested.values.inject(0) { |count, error_collection| count + error_collection.deep_size }
     end
-  
+
     # Iterates over errors at the current level. Nested errors will not be yielded.
     def each(&block)
       @errors.each(&block)
@@ -58,11 +58,11 @@ module Braintree
     def on(attribute)
       @errors.select { |error| error.attribute == attribute.to_s }
     end
-  
+
     # The number of errors at this level. This does not include nested errors.
     def size
       @errors.size
-    end  
+    end
 
     def _inner_inspect(scope = []) # :nodoc:
       all = []
@@ -75,6 +75,6 @@ module Braintree
       end
       all.join(", ")
     end
-  end  
+  end
 end
 

data/lib/braintree/version.rb

@@ -1,9 +1,9 @@
 module Braintree
   module Version
     Major = 1
-    Minor = 0
-    Tiny = 1
-    
+    Minor = 1
+    Tiny = 0
+
     String = "#{Major}.#{Minor}.#{Tiny}"
   end
 end

data/lib/braintree/xml/generator.rb

@@ -15,7 +15,7 @@ module Braintree
         "symbol"   => Proc.new { |symbol| symbol.to_s },
         "datetime" => Proc.new { |time| time.xmlschema },
       }
-      
+
       def self.hash_to_xml(hash)
         root, contents = hash.keys[0], hash.values[0]
 
@@ -60,7 +60,7 @@ module Braintree
         end
 
       end
-      
+
       def self._array_to_xml(array, options = {})
         raise "expected all elements to be hashes" unless array.all? { |e| e.is_a?(Hash) }
         raise "expected options[:root]" unless options[:root]

data/lib/braintree/xml/libxml.rb

@@ -13,7 +13,7 @@ module Braintree
       ensure
         ::LibXML::XML.default_keep_blanks = old_keep_blanks_setting
       end
-      
+
       def self._node_to_hash(node, hash = {})
         if node.text?
           raise ::LibXML::XML::Error if node.content.length >= LIB_XML_LIMIT

data/lib/braintree/xml/parser.rb

@@ -48,7 +48,7 @@ module Braintree
               ""
             elsif value.nil? || value['nil'] == 'true'
               nil
-            # If the type is the only element which makes it then 
+            # If the type is the only element which makes it then
             # this still makes the value nil, except if type is
             # a XML node(where type['value'] is a Hash)
             elsif value['type'] && value.size == 1 && !value['type'].is_a?(::Hash)

data/spec/integration/braintree/address_spec.rb

@@ -28,7 +28,7 @@ describe Braintree::Address do
       result.address.postal_code.should == "60622"
       result.address.country_name.should == "United States of America"
     end
-    
+
     it "returns an error response if invalid" do
       customer = Braintree::Customer.create!(:last_name => "Wilson")
       result = Braintree::Address.create(
@@ -72,7 +72,7 @@ describe Braintree::Address do
       address.postal_code.should == "60623"
       address.country_name.should == "United States of America"
     end
-    
+
     it "raises a ValidationsFailed if invalid" do
       customer = Braintree::Customer.create!(:last_name => "Wilson")
       expect do
@@ -83,7 +83,7 @@ describe Braintree::Address do
       end.to raise_error(Braintree::ValidationsFailed)
     end
   end
-  
+
   describe "self.delete" do
     it "deletes the address given a customer id and an address id" do
       customer = Braintree::Customer.create!(:last_name => "Wilson")
@@ -103,7 +103,7 @@ describe Braintree::Address do
       end.to raise_error(Braintree::NotFoundError)
     end
   end
-  
+
   describe "self.find" do
     it "finds the address given a customer and an address id" do
       customer = Braintree::Customer.create!(:last_name => "Wilson")
@@ -116,7 +116,7 @@ describe Braintree::Address do
       address = Braintree::Address.create!(:customer_id => customer.id, :street_address => "123 E Main St")
       Braintree::Address.find(customer.id, address.id).should == address
     end
-    
+
     it "raises a NotFoundError if it cannot be found because of customer id" do
       customer = Braintree::Customer.create!(:last_name => "Wilson")
       address = Braintree::Address.create!(:customer_id => customer.id, :street_address => "123 E Main St")
@@ -137,7 +137,7 @@ describe Braintree::Address do
         "address for customer \"#{customer.id}\" with id \"invalid\" not found")
     end
   end
-  
+
   describe "self.update" do
     it "raises NotFoundError if the address can't be found" do
       customer = Braintree::Customer.create!(:last_name => "Wilson")
@@ -176,7 +176,7 @@ describe Braintree::Address do
       result.address.postal_code.should == "60621"
       result.address.country_name.should == "United States of America"
     end
-    
+
     it "returns an error response if invalid" do
       customer = Braintree::Customer.create!(:last_name => "Miller")
       address = Braintree::Address.create!(
@@ -232,7 +232,7 @@ describe Braintree::Address do
       updated_address.postal_code.should == "60621"
       updated_address.country_name.should == "United States of America"
     end
-    
+
     it "raises a ValidationsFailed invalid" do
       customer = Braintree::Customer.create!(:last_name => "Miller")
       address = Braintree::Address.create!(
@@ -250,7 +250,7 @@ describe Braintree::Address do
     end
   end
 
-  
+
   describe "delete" do
     it "deletes the address" do
       customer = Braintree::Customer.create!(:last_name => "Wilson")
@@ -261,7 +261,7 @@ describe Braintree::Address do
       end.to raise_error(Braintree::NotFoundError)
     end
   end
-  
+
   describe "update" do
     it "returns a success response and updates the address if valid" do
       customer = Braintree::Customer.create!(:last_name => "Miller")
@@ -291,7 +291,7 @@ describe Braintree::Address do
       address.postal_code.should == "60621"
       address.country_name.should == "United States of America"
     end
-    
+
     it "returns an error response if invalid" do
       customer = Braintree::Customer.create!(:last_name => "Miller")
       address = Braintree::Address.create!(
@@ -334,7 +334,7 @@ describe Braintree::Address do
       address.postal_code.should == "60621"
       address.country_name.should == "United States of America"
     end
-    
+
     it "raises a ValidationsFailed invalid" do
       customer = Braintree::Customer.create!(:last_name => "Miller")
       address = Braintree::Address.create!(

data/spec/integration/braintree/credit_card_spec.rb

@@ -53,6 +53,8 @@ describe Braintree::CreditCard do
       )
       result.success?.should == false
       result.credit_card_verification.status.should == "processor_declined"
+      result.credit_card_verification.processor_response_code.should == "2000"
+      result.credit_card_verification.processor_response_text.should == "Do Not Honor"
       result.credit_card_verification.cvv_response_code.should == "I"
       result.credit_card_verification.avs_error_response_code.should == nil
       result.credit_card_verification.avs_postal_code_response_code.should == "I"
@@ -69,7 +71,7 @@ describe Braintree::CreditCard do
       )
       result.success?.should == true
     end
-    
+
     it "adds credit card with billing address to customer" do
       customer = Braintree::Customer.create!
       result = Braintree::CreditCard.create(
@@ -88,7 +90,7 @@ describe Braintree::CreditCard do
       credit_card.bin.should == Braintree::Test::CreditCardNumbers::MasterCard[0, 6]
       credit_card.billing_address.street_address.should == "123 Abc Way"
     end
-     
+
     it "returns an error response if unsuccessful" do
       customer = Braintree::Customer.create!
       result = Braintree::CreditCard.create(
@@ -127,7 +129,7 @@ describe Braintree::CreditCard do
       end.to raise_error(Braintree::ValidationsFailed)
     end
   end
-  
+
   describe "self.credit" do
     it "creates a credit transaction using the payment method token, returning a result object" do
       customer = Braintree::Customer.create!(
@@ -141,7 +143,7 @@ describe Braintree::CreditCard do
         :amount => "100.00"
       )
       result.success?.should == true
-      result.transaction.amount.should == "100.00"
+      result.transaction.amount.should == BigDecimal.new("100.00")
       result.transaction.type.should == "credit"
       result.transaction.customer_details.id.should == customer.id
       result.transaction.credit_card_details.token.should == customer.credit_cards[0].token
@@ -150,7 +152,7 @@ describe Braintree::CreditCard do
       result.transaction.credit_card_details.expiration_date.should == "05/2010"
     end
   end
-  
+
   describe "self.credit!" do
     it "creates a credit transaction using the payment method token, returning the transaction" do
       customer = Braintree::Customer.create!(
@@ -163,7 +165,7 @@ describe Braintree::CreditCard do
         customer.credit_cards[0].token,
         :amount => "100.00"
       )
-      transaction.amount.should == "100.00"
+      transaction.amount.should == BigDecimal.new("100.00")
       transaction.type.should == "credit"
       transaction.customer_details.id.should == customer.id
       transaction.credit_card_details.token.should == customer.credit_cards[0].token
@@ -202,7 +204,7 @@ describe Braintree::CreditCard do
       credit_card.expiration_date.should == "05/2012"
       credit_card.customer_id.should == customer.id
     end
-    
+
     it "returns xml with nested errors if validation errors" do
       customer = Braintree::Customer.create.customer
       params =  {
@@ -218,7 +220,7 @@ describe Braintree::CreditCard do
         }
       }
       query_string_response = create_credit_card_via_tr(params, tr_data_params)
-      result = Braintree::CreditCard.create_from_transparent_redirect(query_string_response)      
+      result = Braintree::CreditCard.create_from_transparent_redirect(query_string_response)
       result.success?.should == false
       result.params[:customer_id] == customer.id
       result.params[:credit_card]["cardholder_name"] == customer.id
@@ -227,6 +229,156 @@ describe Braintree::CreditCard do
     end
   end
 
+  describe "self.update" do
+    it "updates the credit card" do
+      customer = Braintree::Customer.create!
+      credit_card = Braintree::CreditCard.create!(
+        :cardholder_name => "Original Holder",
+        :customer_id => customer.id,
+        :cvv => "123",
+        :number => Braintree::Test::CreditCardNumbers::Visa,
+        :expiration_date => "05/2012"
+      )
+      update_result = Braintree::CreditCard.update(credit_card.token,
+        :cardholder_name => "New Holder",
+        :cvv => "456",
+        :number => Braintree::Test::CreditCardNumbers::MasterCard,
+        :expiration_date => "06/2013"
+      )
+      update_result.success?.should == true
+      update_result.credit_card.should == credit_card
+      updated_credit_card = update_result.credit_card
+      updated_credit_card.bin.should == Braintree::Test::CreditCardNumbers::MasterCard[0, 6]
+      updated_credit_card.last_4.should == Braintree::Test::CreditCardNumbers::MasterCard[-4..-1]
+      updated_credit_card.expiration_date.should == "06/2013"
+      updated_credit_card.cardholder_name.should == "New Holder"
+    end
+
+    it "verifies the update if options[verify_card]=true" do
+      customer = Braintree::Customer.create!
+      credit_card = Braintree::CreditCard.create!(
+        :cardholder_name => "Original Holder",
+        :customer_id => customer.id,
+        :cvv => "123",
+        :number => Braintree::Test::CreditCardNumbers::Visa,
+        :expiration_date => "05/2012"
+      )
+      update_result = Braintree::CreditCard.update(credit_card.token,
+        :cardholder_name => "New Holder",
+        :cvv => "456",
+        :number => Braintree::Test::CreditCardNumbers::FailsSandboxVerification::MasterCard,
+        :expiration_date => "06/2013",
+        :options => {:verify_card => true}
+      )
+      update_result.success?.should == false
+      update_result.credit_card_verification.status.should == "processor_declined"
+    end
+
+    it "can update the billing address" do
+      customer = Braintree::Customer.create!
+      credit_card = Braintree::CreditCard.create!(
+        :cardholder_name => "Original Holder",
+        :customer_id => customer.id,
+        :cvv => "123",
+        :number => Braintree::Test::CreditCardNumbers::Visa,
+        :expiration_date => "05/2012",
+        :billing_address => {
+          :first_name => "Old First Name",
+          :last_name => "Old Last Name",
+          :company => "Old Company",
+          :street_address => "123 Old St",
+          :extended_address => "Apt Old",
+          :locality => "Old City",
+          :region => "Old State",
+          :postal_code => "12345",
+          :country_name => "Canada"
+        }
+      )
+      result = Braintree::CreditCard.update(credit_card.token,
+        :options => {:verify_card => false},
+        :billing_address => {
+          :first_name => "New First Name",
+          :last_name => "New Last Name",
+          :company => "New Company",
+          :street_address => "123 New St",
+          :extended_address => "Apt New",
+          :locality => "New City",
+          :region => "New State",
+          :postal_code => "56789",
+          :country_name => "United States of America"
+        }
+      )
+      result.success?.should == true
+      address = result.credit_card.billing_address
+      address.first_name.should == "New First Name"
+      address.last_name.should == "New Last Name"
+      address.company.should == "New Company"
+      address.street_address.should == "123 New St"
+      address.extended_address.should == "Apt New"
+      address.locality.should == "New City"
+      address.region.should == "New State"
+      address.postal_code.should == "56789"
+      address.country_name.should == "United States of America"
+    end
+
+    it "returns an error response if invalid" do
+      customer = Braintree::Customer.create!
+      credit_card = Braintree::CreditCard.create!(
+        :cardholder_name => "Original Holder",
+        :customer_id => customer.id,
+        :number => Braintree::Test::CreditCardNumbers::Visa,
+        :expiration_date => "05/2012"
+      )
+      update_result = Braintree::CreditCard.update(credit_card.token,
+        :cardholder_name => "New Holder",
+        :number => "invalid",
+        :expiration_date => "05/2014"
+      )
+      update_result.success?.should == false
+      update_result.errors.for(:credit_card).on(:number)[0].message.should == "Credit card number must be 12-19 digits."
+    end
+  end
+
+  describe "self.update!" do
+    it "updates the credit card and returns true if valid" do
+      customer = Braintree::Customer.create!
+      credit_card = Braintree::CreditCard.create!(
+        :cardholder_name => "Original Holder",
+        :customer_id => customer.id,
+        :number => Braintree::Test::CreditCardNumbers::Visa,
+        :expiration_date => "05/2012"
+      )
+      updated_credit_card = Braintree::CreditCard.update!(credit_card.token,
+        :cardholder_name => "New Holder",
+        :number => Braintree::Test::CreditCardNumbers::MasterCard,
+        :expiration_date => "06/2013"
+      )
+      updated_credit_card.token.should == credit_card.token
+      updated_credit_card.bin.should == Braintree::Test::CreditCardNumbers::MasterCard[0, 6]
+      updated_credit_card.last_4.should == Braintree::Test::CreditCardNumbers::MasterCard[-4..-1]
+      updated_credit_card.expiration_date.should == "06/2013"
+      updated_credit_card.cardholder_name.should == "New Holder"
+      updated_credit_card.updated_at.between?(Time.now - 5, Time.now).should == true
+    end
+
+    it "raises a ValidationsFailed if invalid" do
+      customer = Braintree::Customer.create!
+      credit_card = Braintree::CreditCard.create!(
+        :cardholder_name => "Original Holder",
+        :customer_id => customer.id,
+        :number => Braintree::Test::CreditCardNumbers::Visa,
+        :expiration_date => "05/2012"
+      )
+      expect do
+        Braintree::CreditCard.update!(credit_card.token,
+          :cardholder_name => "New Holder",
+          :number => Braintree::Test::CreditCardNumbers::MasterCard,
+          :expiration_date => "invalid/date"
+        )
+      end.to raise_error(Braintree::ValidationsFailed)
+    end
+  end
+
   describe "self.update_from_transparent_redirect" do
     it "updates the credit card" do
       old_token = "token#{rand(1_000_000)}"
@@ -276,7 +428,7 @@ describe Braintree::CreditCard do
         :amount => "100.00"
       )
       result.success?.should == true
-      result.transaction.amount.should == "100.00"
+      result.transaction.amount.should == BigDecimal.new("100.00")
       result.transaction.type.should == "credit"
       result.transaction.customer_details.id.should == customer.id
       result.transaction.credit_card_details.token.should == customer.credit_cards[0].token
@@ -295,7 +447,7 @@ describe Braintree::CreditCard do
         }
       )
       transaction = customer.credit_cards[0].credit!(:amount => "100.00")
-      transaction.amount.should == "100.00"
+      transaction.amount.should == BigDecimal.new("100.00")
       transaction.type.should == "credit"
       transaction.customer_details.id.should == customer.id
       transaction.credit_card_details.token.should == customer.credit_cards[0].token
@@ -303,7 +455,7 @@ describe Braintree::CreditCard do
       transaction.credit_card_details.last_4.should == Braintree::Test::CreditCardNumbers::Visa[-4..-1]
       transaction.credit_card_details.expiration_date.should == "05/2010"
     end
-    
+
     it "raises a ValidationsFailed if invalid" do
       customer = Braintree::Customer.create!(
         :credit_card => {
@@ -316,16 +468,16 @@ describe Braintree::CreditCard do
       end.to raise_error(Braintree::ValidationsFailed)
     end
   end
-  
+
   describe "delete" do
     it "deletes the credit card" do
       customer = Braintree::Customer.create.customer
       result = Braintree::CreditCard.create(
         :customer_id => customer.id,
         :number => Braintree::Test::CreditCardNumbers::Visa,
-        :expiration_date => "05/2012"        
+        :expiration_date => "05/2012"
       )
-      
+
       result.success?.should == true
       credit_card = result.credit_card
       credit_card.delete.should == true
@@ -334,7 +486,7 @@ describe Braintree::CreditCard do
       end.to raise_error(Braintree::NotFoundError)
     end
   end
-  
+
   describe "self.expired" do
     it "finds expired payment methods, paginated" do
       first_page = Braintree::CreditCard.expired
@@ -353,7 +505,7 @@ describe Braintree::CreditCard do
       # second_page.all? { |pm| pm.expired?.should == true }
     end
   end
-  
+
   describe "self.expiring_between" do
     it "finds payment methods expiring between the given dates" do
       next_year = Time.now.year + 1
@@ -382,7 +534,7 @@ describe Braintree::CreditCard do
       result = Braintree::CreditCard.create(
         :customer_id => customer.id,
         :number => Braintree::Test::CreditCardNumbers::Visa,
-        :expiration_date => "05/2012"        
+        :expiration_date => "05/2012"
       )
       result.success?.should == true
       credit_card = Braintree::CreditCard.find(result.credit_card.token)
@@ -391,14 +543,14 @@ describe Braintree::CreditCard do
       credit_card.token.should == result.credit_card.token
       credit_card.expiration_date.should == "05/2012"
     end
-    
+
     it "raises a NotFoundError exception if payment method cannot be found" do
       expect do
         Braintree::CreditCard.find("invalid-token")
       end.to raise_error(Braintree::NotFoundError, 'payment method with token "invalid-token" not found')
     end
   end
-  
+
   describe "self.sale" do
     it "creates a sale transaction using the credit card, returning a result object" do
       customer = Braintree::Customer.create!(
@@ -410,7 +562,7 @@ describe Braintree::CreditCard do
       result = Braintree::CreditCard.sale(customer.credit_cards[0].token, :amount => "100.00")
 
       result.success?.should == true
-      result.transaction.amount.should == "100.00"
+      result.transaction.amount.should == BigDecimal.new("100.00")
       result.transaction.type.should == "sale"
       result.transaction.customer_details.id.should == customer.id
       result.transaction.credit_card_details.token.should == customer.credit_cards[0].token
@@ -429,7 +581,7 @@ describe Braintree::CreditCard do
         }
       )
       transaction = Braintree::CreditCard.sale!(customer.credit_cards[0].token, :amount => "100.00")
-      transaction.amount.should == "100.00"
+      transaction.amount.should == BigDecimal.new("100.00")
       transaction.type.should == "sale"
       transaction.customer_details.id.should == customer.id
       transaction.credit_card_details.token.should == customer.credit_cards[0].token
@@ -438,7 +590,7 @@ describe Braintree::CreditCard do
       transaction.credit_card_details.expiration_date.should == "05/2010"
     end
   end
-  
+
   describe "sale" do
     it "creates a sale transaction using the credit card, returning a result object" do
       customer = Braintree::Customer.create!(
@@ -451,7 +603,7 @@ describe Braintree::CreditCard do
         :amount => "100.00"
       )
       result.success?.should == true
-      result.transaction.amount.should == "100.00"
+      result.transaction.amount.should == BigDecimal.new("100.00")
       result.transaction.type.should == "sale"
       result.transaction.customer_details.id.should == customer.id
       result.transaction.credit_card_details.token.should == customer.credit_cards[0].token
@@ -470,7 +622,7 @@ describe Braintree::CreditCard do
         }
       )
       transaction = customer.credit_cards[0].sale!(:amount => "100.00")
-      transaction.amount.should == "100.00"
+      transaction.amount.should == BigDecimal.new("100.00")
       transaction.type.should == "sale"
       transaction.customer_details.id.should == customer.id
       transaction.credit_card_details.token.should == customer.credit_cards[0].token
@@ -478,7 +630,7 @@ describe Braintree::CreditCard do
       transaction.credit_card_details.last_4.should == Braintree::Test::CreditCardNumbers::Visa[-4..-1]
       transaction.credit_card_details.expiration_date.should == "05/2010"
     end
-    
+
     it "raises a ValidationsFailed if invalid" do
       customer = Braintree::Customer.create!(
         :credit_card => {
@@ -491,7 +643,7 @@ describe Braintree::CreditCard do
       end.to raise_error(Braintree::ValidationsFailed)
     end
   end
-  
+
   describe "update" do
     it "updates the credit card" do
       customer = Braintree::Customer.create!
@@ -500,7 +652,7 @@ describe Braintree::CreditCard do
         :customer_id => customer.id,
         :cvv => "123",
         :number => Braintree::Test::CreditCardNumbers::Visa,
-        :expiration_date => "05/2012"        
+        :expiration_date => "05/2012"
       )
       update_result = credit_card.update(
         :cardholder_name => "New Holder",
@@ -524,7 +676,7 @@ describe Braintree::CreditCard do
         :customer_id => customer.id,
         :cvv => "123",
         :number => Braintree::Test::CreditCardNumbers::Visa,
-        :expiration_date => "05/2012"        
+        :expiration_date => "05/2012"
       )
       update_result = credit_card.update(
         :cardholder_name => "New Holder",
@@ -555,7 +707,7 @@ describe Braintree::CreditCard do
           :region => "Old State",
           :postal_code => "12345",
           :country_name => "Canada"
-        }        
+        }
       )
       result = credit_card.update(
         :options => {:verify_card => false},
@@ -584,14 +736,14 @@ describe Braintree::CreditCard do
       address.postal_code.should == "56789"
       address.country_name.should == "United States of America"
     end
-    
+
     it "returns an error response if invalid" do
       customer = Braintree::Customer.create!
       credit_card = Braintree::CreditCard.create!(
         :cardholder_name => "Original Holder",
         :customer_id => customer.id,
         :number => Braintree::Test::CreditCardNumbers::Visa,
-        :expiration_date => "05/2012"        
+        :expiration_date => "05/2012"
       )
       update_result = credit_card.update(
         :cardholder_name => "New Holder",
@@ -610,7 +762,7 @@ describe Braintree::CreditCard do
         :cardholder_name => "Original Holder",
         :customer_id => customer.id,
         :number => Braintree::Test::CreditCardNumbers::Visa,
-        :expiration_date => "05/2012"        
+        :expiration_date => "05/2012"
       )
       credit_card.update!(
         :cardholder_name => "New Holder",
@@ -623,14 +775,14 @@ describe Braintree::CreditCard do
       credit_card.cardholder_name.should == "New Holder"
       credit_card.updated_at.between?(Time.now - 5, Time.now).should == true
     end
-    
+
     it "raises a ValidationsFailed if invalid" do
       customer = Braintree::Customer.create!
       credit_card = Braintree::CreditCard.create!(
         :cardholder_name => "Original Holder",
         :customer_id => customer.id,
         :number => Braintree::Test::CreditCardNumbers::Visa,
-        :expiration_date => "05/2012"        
+        :expiration_date => "05/2012"
       )
       expect do
         credit_card.update!(
@@ -641,7 +793,7 @@ describe Braintree::CreditCard do
       end.to raise_error(Braintree::ValidationsFailed)
     end
   end
-  
+
   def create_credit_card_via_tr(regular_params, tr_params = {})
     response = nil
     Net::HTTP.start("localhost", Braintree::Configuration.port) do |http|
@@ -652,7 +804,7 @@ describe Braintree::CreditCard do
       response = http.request(request)
     end
     if response.code.to_i == 303
-      query_string = response["Location"].split("?", 2).last  
+      query_string = response["Location"].split("?", 2).last
     else
       raise "did not receive a valid tr response: #{response.body[0,1000].inspect}"
     end
@@ -668,7 +820,7 @@ describe Braintree::CreditCard do
       response = http.request(request)
     end
     if response.code.to_i == 303
-      query_string = response["Location"].split("?", 2).last  
+      query_string = response["Location"].split("?", 2).last
     else
       raise "did not receive a valid tr response: #{response.body[0,1000].inspect}"
     end