berkshelf 5.5.0 → 5.6.0

data/spec/unit/berkshelf/logger_spec.rb

@@ -1,9 +1,9 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe Berkshelf::Logger do
-  %w(info warn error fatal debug deprecate exception).each do |meth|
+  %w{info warn error fatal debug deprecate exception}.each do |meth|
     describe "##{meth}" do
-      it 'responds' do
+      it "responds" do
         expect(subject).to respond_to(meth.to_sym)
       end
     end

data/spec/unit/berkshelf/mixin/logging_spec.rb

@@ -1,18 +1,18 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe Berkshelf::Mixin::Logging do
   subject do
     Class.new { include Berkshelf::Mixin::Logging }.new
   end
 
-  describe '#logger' do
-    it 'returns the Berkshelf::Logger' do
+  describe "#logger" do
+    it "returns the Berkshelf::Logger" do
       expect(subject.logger).to be_a(Berkshelf::Logger)
     end
   end
 
-  describe '#log' do
-    it 'returns the Berkshelf::Logger' do
+  describe "#log" do
+    it "returns the Berkshelf::Logger" do
       expect(subject.log).to be_a(Berkshelf::Logger)
     end
   end

data/spec/unit/berkshelf/packager_spec.rb

@@ -1,10 +1,10 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe Berkshelf::Packager do
   let(:target) { tmp_path.join("cookbooks.tar.gz").to_s }
   subject { described_class.new(target) }
 
-  it 'has the correct out_file' do
+  it "has the correct out_file" do
     expect(subject.out_file).to eq(target)
   end
 

data/spec/unit/berkshelf/resolver/graph_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe Berkshelf::Resolver::Graph, :not_supported_on_windows do
   subject { described_class.new }

data/spec/unit/berkshelf/resolver_spec.rb

@@ -1,7 +1,7 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe Berkshelf::Resolver do
-  let(:berksfile) { double('berksfile') }
+  let(:berksfile) { double("berksfile") }
   let(:demand) { Berkshelf::Dependency.new(berksfile, "mysql", constraint: "= 1.2.4") }
 
   before(:each) do
@@ -11,7 +11,7 @@ describe Berkshelf::Resolver do
 
   describe "ClassMethods" do
     describe "::initialize" do
-      it 'adds the specified dependencies to the dependencies hash' do
+      it "adds the specified dependencies to the dependencies hash" do
         resolver = described_class.new(berksfile, demand)
         expect(resolver).to have_demand(demand)
       end
@@ -21,17 +21,17 @@ describe Berkshelf::Resolver do
   subject { Berkshelf::Resolver.new(berksfile) }
 
   describe "#add_demand" do
-    it 'adds the demand to the instance of resolver' do
+    it "adds the demand to the instance of resolver" do
       subject.add_demand(demand)
       expect(subject.demands).to include(demand)
     end
 
-    it 'raises a DuplicateDemand exception if a demand of the same name is added' do
+    it "raises a DuplicateDemand exception if a demand of the same name is added" do
       expect(subject).to receive(:has_demand?).with(demand).and_return(true)
 
-      expect {
+      expect do
         subject.add_demand(demand)
-      }.to raise_error(Berkshelf::DuplicateDemand)
+      end.to raise_error(Berkshelf::DuplicateDemand)
     end
   end
 
@@ -44,44 +44,44 @@ describe Berkshelf::Resolver do
   describe "#get_demand" do
     before { subject.add_demand(demand) }
 
-    context 'given a string representation of the demand to retrieve' do
-      it 'returns a Berkshelf::Dependency of the same name' do
+    context "given a string representation of the demand to retrieve" do
+      it "returns a Berkshelf::Dependency of the same name" do
         expect(subject.get_demand(demand.name)).to eq(demand)
       end
     end
   end
 
-  describe '#has_demand?' do
+  describe "#has_demand?" do
     before { subject.add_demand(demand) }
 
-    it 'returns true if the demand exists' do
+    it "returns true if the demand exists" do
       expect(subject.has_demand?(demand.name)).to be(true)
     end
 
-    it 'returns false if the demand does not exist' do
-      expect(subject.has_demand?('non-existent')).to be(false)
+    it "returns false if the demand does not exist" do
+      expect(subject.has_demand?("non-existent")).to be(false)
     end
   end
 
   describe "#resolve" do
-    describe 'given a missing required solver' do
+    describe "given a missing required solver" do
       before do
         allow(berksfile).to receive(:required_solver).and_return(:xyzzy)
         allow(berksfile).to receive(:preferred_solver).and_return(nil)
       end
 
-      it 'should raise an exception about missing required resolver :xyzzy' do
+      it "should raise an exception about missing required resolver :xyzzy" do
         expect { subject.compute_solver_engine(berksfile) }.to raise_error(/Engine `xyzzy` is not supported/)
       end
     end
 
-    describe 'given a missing preferred solver' do
+    describe "given a missing preferred solver" do
       before do
         allow(berksfile).to receive(:required_solver).and_return(nil)
         allow(berksfile).to receive(:preferred_solver).and_return(:xyzzy)
       end
 
-      it 'should not raise an exception about missing preferred resolver :xyzzy' do
+      it "should not raise an exception about missing preferred resolver :xyzzy" do
         expect { subject.compute_solver_engine(berksfile) }.not_to raise_error
       end
     end

data/spec/unit/berkshelf/shell_spec.rb

@@ -1,9 +1,9 @@
-require 'spec_helper'
+require "spec_helper"
 
 module Berkshelf
   describe Shell do
-    let(:stdout) { double('stdout', tty?: true) }
-    let(:stderr) { double('stderr') }
+    let(:stdout) { double("stdout", tty?: true) }
+    let(:stderr) { double("stderr") }
 
     before do
       allow_any_instance_of(described_class).to receive(:stdout)
@@ -13,119 +13,119 @@ module Berkshelf
         .and_return(stderr)
     end
 
-    describe '#mute!' do
-      it 'sets @mute to true' do
+    describe "#mute!" do
+      it "sets @mute to true" do
         subject.mute!
         expect(subject.instance_variable_get(:@mute)).to be(true)
       end
     end
 
-    describe '#unmute!' do
-      it 'sets @mute to false' do
+    describe "#unmute!" do
+      it "sets @mute to false" do
         subject.unmute!
         expect(subject.instance_variable_get(:@mute)).to be(false)
       end
     end
 
-    describe '#say' do
-      context 'when quiet?' do
+    describe "#say" do
+      context "when quiet?" do
         before do
           allow(subject).to receive(:quiet?).and_return(true)
         end
 
-        it 'does not output anything', :not_supported_on_windows do
+        it "does not output anything", :not_supported_on_windows do
           expect(stdout).to_not receive(:print)
           expect(stdout).to_not receive(:puts)
-          subject.say 'message'
+          subject.say "message"
         end
       end
 
-      context 'with not quiet?' do
+      context "with not quiet?" do
         before do
           allow(subject).to receive(:quiet?).and_return(false)
         end
 
-        it 'prints to stdout' do
+        it "prints to stdout" do
           expect(stdout).to receive(:print).once
           expect(stdout).to receive(:flush).once
-          subject.say 'message'
+          subject.say "message"
         end
       end
     end
 
-    describe '#say_status' do
-      context 'when quiet?' do
+    describe "#say_status" do
+      context "when quiet?" do
         before do
           allow(subject).to receive(:quiet?).and_return(true)
         end
 
-        it 'does not output anything' do
+        it "does not output anything" do
           expect(stdout).to_not receive(:print)
           expect(stdout).to_not receive(:puts)
-          subject.say_status 5, 'message'
+          subject.say_status 5, "message"
         end
       end
 
-      context 'with not quiet?' do
+      context "with not quiet?" do
         before do
           allow(subject).to receive(:quiet?).and_return(false)
         end
 
-        it 'prints to stdout' do
+        it "prints to stdout" do
           expect(stdout).to receive(:print).once
           expect(stdout).to receive(:flush).once
-          subject.say_status 5, 'message'
+          subject.say_status 5, "message"
         end
       end
     end
 
-    describe '#warn' do
-      context 'when quiet?' do
+    describe "#warn" do
+      context "when quiet?" do
         before do
           allow(subject).to receive(:quiet?).and_return(true)
         end
 
-        it 'does not output anything' do
+        it "does not output anything" do
           expect(stdout).to_not receive(:print)
           expect(stdout).to_not receive(:puts)
-          subject.warn 'warning'
+          subject.warn "warning"
         end
       end
 
-      context 'with not quiet?' do
+      context "with not quiet?" do
         before do
           allow(subject).to receive(:quiet?).and_return(false)
         end
 
-        it 'calls #say with yellow coloring' do
+        it "calls #say with yellow coloring" do
           expect(stdout).to receive(:print).once
           expect(stdout).to receive(:flush).once
-          subject.warn 'warning'
+          subject.warn "warning"
         end
       end
     end
 
-    context '#error' do
-      context 'when quiet?' do
+    context "#error" do
+      context "when quiet?" do
         before do
           allow(subject).to receive(:quiet?).and_return(true)
         end
 
         it "outputs an error message", :not_supported_on_windows do
           expect(stderr).to receive(:puts)
-          subject.error 'error!'
+          subject.error "error!"
         end
       end
 
-      context 'with not quiet?' do
+      context "with not quiet?" do
         before do
           allow(subject).to receive(:quiet?).and_return(false)
         end
 
-        it 'prints to stderr' do
+        it "prints to stderr" do
           expect(stderr).to receive(:puts)
             .with(windows? ? "error!" : "\e[31merror!\e[0m")
-          subject.error 'error!'
+          subject.error "error!"
         end
       end
     end

data/spec/unit/berkshelf/source_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "spec_helper"
 
 module Berkshelf
   describe Source do
@@ -22,28 +22,29 @@ module Berkshelf
       end
     end
 
-    describe '.default?' do
-      it 'returns true when the source is the default' do
+    describe ".default?" do
+      it "returns true when the source is the default" do
         instance = described_class.new(Berksfile::DEFAULT_API_URL)
         expect(instance).to be_default
       end
 
-      it 'returns true when the scheme is different' do
-        instance = described_class.new('http://supermarket.chef.io')
+      it "returns true when the scheme is different" do
+        instance = described_class.new("http://supermarket.chef.io")
         expect(instance).to be_default
       end
 
-      it 'returns false when the source is not the default' do
-        instance = described_class.new('http://localhost:8080')
+      it "returns false when the source is not the default" do
+        instance = described_class.new("http://localhost:8080")
         expect(instance).to_not be_default
       end
     end
 
     describe "#search" do
-      let (:cookbooks) {[ 
-        APIClient::RemoteCookbook.new("cb1","1.0.8"),
-        APIClient::RemoteCookbook.new("cb1","1.0.22")
-      ]}
+      let (:cookbooks) do
+        [
+        APIClient::RemoteCookbook.new("cb1", "1.0.8"),
+        APIClient::RemoteCookbook.new("cb1", "1.0.22"),
+      ] end
 
       before do
         allow_any_instance_of(APIClient::Connection).to receive(:universe).and_return(cookbooks)

data/spec/unit/berkshelf/source_uri_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe Berkshelf::SourceURI do
   describe "ClassMethods" do

data/spec/unit/berkshelf/ssl_policies_spec.rb

@@ -1,21 +1,21 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe Berkshelf::SSLPolicy do
-  let(:self_signed_crt_path) { File.join(BERKS_SPEC_DATA, 'trusted_certs') }
+  let(:self_signed_crt_path) { File.join(BERKS_SPEC_DATA, "trusted_certs") }
 
   let(:chef_config) do
     double(Ridley::Chef::Config,
-      node_name: 'fake-client',
-      client_key: 'client-key',
-      chef_server_url: 'http://configured-chef-server/',
-      validation_client_name: 'validator',
-      validation_key: 'validator.pem',
-      cookbook_copyright: 'user',
-      cookbook_email: 'user@example.com',
-      cookbook_license: 'apachev2',
+      node_name: "fake-client",
+      client_key: "client-key",
+      chef_server_url: "http://configured-chef-server/",
+      validation_client_name: "validator",
+      validation_key: "validator.pem",
+      cookbook_copyright: "user",
+      cookbook_email: "user@example.com",
+      cookbook_license: "apachev2",
       trusted_certs_dir: self_signed_crt_path,
       knife: {
-        chef_guard: false
+        chef_guard: false,
       }
     )
   end
@@ -35,38 +35,38 @@ describe Berkshelf::SSLPolicy do
     allow(Berkshelf).to receive(:config).and_return(berkshelf_config)
   end
 
-  describe '#initialize' do
-    it 'sets up the store' do
+  describe "#initialize" do
+    it "sets up the store" do
       expect(subject.store.class).to be(OpenSSL::X509::Store)
     end
 
-    it 'sets up custom certificates for chef' do
+    it "sets up custom certificates for chef" do
     end
   end
 
-  describe '#trusted_certs_dir' do
-    it 'uses the trusted_certs_dir from Berkshelf config' do
-        expect(subject.trusted_certs_dir).to eq(self_signed_crt_path)
+  describe "#trusted_certs_dir" do
+    it "uses the trusted_certs_dir from Berkshelf config" do
+      expect(subject.trusted_certs_dir).to eq(self_signed_crt_path)
     end
 
-    context 'trusted_certs_dir in Berkshelf' do
+    context "trusted_certs_dir in Berkshelf" do
 
-      context 'config is not set' do
+      context "config is not set" do
         before { allow(chef_config).to receive_messages(trusted_certs_dir: nil) }
 
-        it 'defaults to ~/.chef/trusted_certs' do
+        it "defaults to ~/.chef/trusted_certs" do
           expect(subject.trusted_certs_dir).to eq(
-            File.join(ENV['HOME'], '.chef', 'trusted_certs')
+            File.join(ENV["HOME"], ".chef", "trusted_certs")
           )
         end
       end
 
-      context 'config is seti but does not exist' do
-        before { allow(chef_config).to receive_messages(trusted_certs_dir: '/fake') }
+      context "config is seti but does not exist" do
+        before { allow(chef_config).to receive_messages(trusted_certs_dir: "/fake") }
 
-        it 'defaults to ~/.chef/trusted_certs' do
+        it "defaults to ~/.chef/trusted_certs" do
           expect(subject.trusted_certs_dir).to eq(
-            File.join(ENV['HOME'], '.chef', 'trusted_certs')
+            File.join(ENV["HOME"], ".chef", "trusted_certs")
           )
         end
       end